October 2007 - Wine-Devel - list.winehq.org

Re: wininet: ftp test hangs behind firewall, so turn it off by default
by Alexandre Julliard Oct. 23, 2007

Oct. 23, 2007

"Dan Kegel" <dank(a)kegel.com> writes: > This gets rid of one more place I have to do 'wineserver -k' to > make tests complete. I don't think it really hangs, it just takes a long time to complete. > It would be better to embed a little ftp server into the test, > and connect to that instead of a public one, but that would > be a pain. No, we clearly want to run the test against a real ftp server. Running it against different types of servers would be even better. What we should probably do is try to connect to a server on localhost first, this way people can install the server of their choice to provide more test coverage. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: msi: Propogate errors from events all the way up to the parent dialog
by Alexandre Julliard Oct. 23, 2007

Oct. 23, 2007

"James Hawkins" <truiken(a)gmail.com> writes: > Fixes bug 10107. http://bugs.winehq.org/show_bug.cgi?id=10107 > > Changelog: > * Propogate errors from events all the way up to the parent dialog. This one fails for me: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so package.c && touch package.ok package.c:587: Test failed: wrong return val make: *** [package.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32 (2/2): fix unchecked NULL ptr in BIDI_Reorder
by Alexandre Julliard Oct. 23, 2007

Oct. 23, 2007

Alexander Dorofeyev <alexd14(a)hushmail.com> writes: > 3rd try. In this version I don't create a temp buffer, instead pass the original > string to subroutines; in BidiLines an additional parameter had to be added, to > indicate that the original string has been passed and in-place modifications it > normally does on the buffer must be skipped. You should pass separate in and out pointers, since the input pointer is const you can't use it in place of the output one. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] updated authors
by Dmitry Timoshkov Oct. 23, 2007

Oct. 23, 2007

"Marcus Meissner" <meissner(a)suse.de> wrote: > --- > AUTHORS | 138 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 136 insertions(+), 2 deletions(-) I've found more duplicates, sorry for the trouble. > +Veksler Michael This is a duplicate due to the reversed last/first names. > Zoltan Nagy > +Zoly Nagy The two names above look similar enough, but changelog doesn't provide enough information to distinguish them. > +Brouard Nicolas Again a duplicate due to the reversed last/first names. > +Tom Spear Not sure if have him already under an old name (can't remember which one). -- Dmitry.

3 2

Re: pdh: Remove or fix tests that fail on Windows.
by Hans Leidekker Oct. 23, 2007

Oct. 23, 2007

On Monday 22 October 2007 14:43:59 Jeff Latimer wrote: > to test with and hence the delay. The current patch I submitted was > cleaning up the Null reference issue before moving on to sorting out the I don't see any crash on Wine or XP when running the test. You are trying to protect against a hypothetical case where an app specifies a size > 0 but no buffer. XP won't accept that anyway and it's unlikely any app will do that on non-XP systems. In fact your patch will break in another - also unlikely - situation where an app relies on non-XP behaviour, which is to accept a null buffer and size > 0 but less than the required size. So a crash is even desirable here, because it tells us immediately that the app is doing something peculiar. -Hans

2 1

iexplore text input
by Luke Bratch Oct. 23, 2007

Oct. 23, 2007

Hi all As you probably know, text input in iexplore isn't working at the moment, and hasn't worked since this commmit: http://source.winehq.org/git/wine.git/?a=commit;h=92b3cab7916445d79d2559e4b… (Found by Simon in this bug: http://bugs.winehq.org/show_bug.cgi?id=9746) I've posted a patch in there: http://bugs.winehq.org/attachment.cgi?id=8647 That seems to make text input work be reversing part of that commit. As far as I can see that doesn't break anything else. Your thoughts? Thanks Luke ___________________________________________________________ Want ideas for reducing your carbon footprint? Visit Yahoo! For Good http://uk.promotions.yahoo.com/forgood/environment.html

2 1

Re: [PATCH] updated AUTHORS according to "git log"
by Dmitry Timoshkov Oct. 23, 2007

Oct. 23, 2007

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: I briefly looked over the diff and found some duplicates, perhaps there are more of them: > Guy Albertelli > +Guy L. Albertelli This one is probably a duplicate. > +Turchanov Sergei And this one already exists as 'Sergey Turchanov'. > +NF Stevens > Norman Stevens According to the e-mail addresses the two above is a single person. > +Josh Thielen > Joshua Thielen And these two as well. > +Sergei Turchanov > Sergey Turchanov Again a duplicate. -- Dmitry.

1 0

urlmon: Fix the MIME type reported by the HTTP protocol when the Content-Type headers contains charset data too.
by Misha Koshelev Oct. 23, 2007

Oct. 23, 2007

> Sorry to send this out after the patch has already been committed, but > this patch is wrong. If you just output the Content-Type in > test/protocol.c you'll see that the charset data is included in the > "MIME type" in both Windows XP and on wine with native urlmon (from > WinME or 98; I believe the XP one crashes wine or at least it used to). > That is why when I was fixing the original test I just changed it to a > memcmp from a strcmp. > Misha > Just checked on Win98, the behavior to keep the charset in the "MIME type" is correct on Win98 as well. Misha

1 0

urlmon: Fix the MIME type reported by the HTTP protocol when the Content-Type headers contains charset data too.
by Misha Koshelev Oct. 23, 2007

Oct. 23, 2007

Sorry to send this out after the patch has already been committed, but this patch is wrong. If you just output the Content-Type in test/protocol.c you'll see that the charset data is included in the "MIME type" in both Windows XP and on wine with native urlmon (from WinME or 98; I believe the XP one crashes wine or at least it used to). That is why when I was fixing the original test I just changed it to a memcmp from a strcmp. Misha

1 0

Photoshop Elements 5 Tryout?
by Dan Kegel Oct. 22, 2007

Oct. 22, 2007

Anyone have a URL for PSE 5 trial version? I'm updating http://wiki.winehq.org/AdobePhotoshop Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

7 15

Re: [4/5] WineD3D: Enable the draw buffers extension only when used
by H. Verbeet Oct. 22, 2007

Oct. 22, 2007

On 22/10/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > The shader works in the end, but the complaints pollute the logs and > make tracking real failures more difficult. I don't think this change makes things better there.

2 3

Re: gdi32 (1/2): fix unchecked NULL ptr in BIDI_Reorder
by Alexandre Julliard Oct. 22, 2007

Oct. 22, 2007

Alexander Dorofeyev <alexd14(a)hushmail.com> writes: > >> One problem is that it wasn't assured lpOutString isn't NULL, and NULL > >> was getting passed to this routine by GetCharacterPlacementW. so it was > >> crashing in memcpy. This patch creates a temporary buffer when > >> lpOutString is NULL and it is used for in-place modifications instead in > >> such case. You shouldn't need to allocate a new buffer, the output modifications should be skipped when no output string is requested. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Add tests for BindToObject for URL monikers based on the existing tests for BindToStorage.
by Alexandre Julliard Oct. 22, 2007

Oct. 22, 2007

Robert Shearman <rob(a)codeweavers.com> writes: > dlls/urlmon/tests/url.c | 201 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 196 insertions(+), 5 deletions(-) Some of the todos are succeeding here: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so url.c && touch url.ok url.c:1293: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1299: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1293: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1299: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1293: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1299: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1293: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1299: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1293: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1299: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1293: Test succeeded inside todo block: expected QueryInterface_IServiceProvider url.c:1299: Test succeeded inside todo block: expected QueryInterface_IServiceProvider make[2]: *** [url.ok] Error 12 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] WineD3D: A point size fix
by H. Verbeet Oct. 22, 2007

Oct. 22, 2007

On 22/10/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > D3D's point size limit is the output point size, GLs the input. Modify > the scale parameters to deal with this. Shouldn't the caps be changed as well then?

2 1

Re: pdh: check for NULL pointer reference
by Hans Leidekker Oct. 22, 2007

Oct. 22, 2007

On Monday 22 October 2007 11:30:10 Jeff Latimer wrote: > This function has specific XP behaviour which I have tested but I have > not been able to verify that Win2k etc works the same. Any comment welcome. I don't think we want to emulate the broken XP behaviour of requiring a buffer, even when querying the buffer size. Apps written to comply with this behaviour should work on the current implementation. And MSDN mentions only XP, which implies that it has been fixed in Win2k3 and up. -Hans

2 3

Phoronix: Ubuntu 7.10 + WINE vs. Windows XP
by speedator Oct. 22, 2007

Oct. 22, 2007

Hello everybody, new benchmark-test at phoronix.com: http://www.phoronix.com/scan.php?page=article&item=882&num=1

8 15

re: ReplaceFileW (was: Phoronix: Ubuntu 7.10 + WINE vs. Windows XP)
by Dan Kegel Oct. 22, 2007

Oct. 22, 2007

Reece Dunn wrote: > The patch was rejected by Alexandre because the patch was > implementing that command using Windows API calls, > when it should be implemented natively as POSIX/GNU calls. Really? Where did he say that? It'd be nice to link to that from http://bugs.winehq.org/show_bug.cgi?id=7544 - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 5

WOAFONT needed
by Uwe Bonnes Oct. 21, 2007

Oct. 21, 2007

Hello, http://dmt.mhilfe.de/ is a tool to read out DSL-line parameters. The windows version knows about a lot of DSL Modems, while a linux rewrite only knows of a small amount of modems. Running as root, because of an ICMP call in the program to find the DSL modem in the network, the program runs fine. However the font is unreadable small. The author uses the app850.fon font, which seems to cause a lot of trouble in windows too. However the cures given in the webpage (put the font into windows/fonts and add [386enh] [woafont=app850.FON]) don't help for me. wine/dlls/gdi32/freetype.c also talks about the app850 font, however neither gives a hint usefull for me. Any ideas? -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

1 0

IntelMac compile error
by Steve Brown Oct. 21, 2007

Oct. 21, 2007

Hi All, Trying to build Wine 0.9.47 on an Intel MacBook Pro (2.16GHz Core Duo).... compilation stops at: mach.c: In function 'get_thread_context': mach.c:166: error: 'x86_debug_state32_t' undeclared (first use in this function) mach.c:166: error: (Each undeclared identifier is reported only once mach.c:166: error: for each function it appears in.) mach.c:166: error: parse error before 'state' mach.c:167: error: 'state' undeclared (first use in this function) mach.c:182: error: 'x86_DEBUG_STATE32' undeclared (first use in this function) mach.c: In function 'set_thread_context': mach.c:210: error: 'x86_debug_state32_t' undeclared (first use in this function) mach.c:210: error: parse error before 'state' mach.c:211: error: 'state' undeclared (first use in this function) mach.c:245: error: 'x86_DEBUG_STATE32' undeclared (first use in this function) make[1]: *** [mach.o] Error 1 make: *** [server] Error 2 I stared briefly at the code, and didn't see anything obvious -- also a quick grep through the source directories and the XCode Headers didn't find a header file that included "x86_debug" (case insensitive grep). Ideas? Steve Brown sbrown7(a)umbc.edu

2 2

Re: [AppDB] Tell the user not to submit screenshots of installers, error messages etc.
by Vitaliy Margolen Oct. 21, 2007

Oct. 21, 2007

Alexander Nicolaysen Sørnes wrote: > These don't really say much about how an application works. > > Why wouldn't you want to see game menu? I think that's a bit way too much. Then the next step would be to require movie of the actual game play? Installers - yeah it's a bit irrelevant. However even errors helpful. When errors are fixed people can see that. And image can be easily removed. So in short - you can add installers to the list of don'ts. But that's about it. Vitaliy.

1 0

[AppDB] Fix maintainer processing
by Alexander Nicolaysen Sørnes Oct. 21, 2007

Oct. 21, 2007

Fix maintainer processing Alexander N. Sørnes

1 0

msi testing
by EA Durbin Oct. 20, 2007

Oct. 20, 2007

I recently purchased the book "The Definitive Guide to Windows Installer". I haven't really started reading it yet, but the source code and sample files are available online so I starting testing the sample .msi files in wine and windows out of curiousity . These files are relatively small and are targeted to demonstrate specific .msi functionality. They might work nicely for testing installer functionality in wine without being obscured by large amounts of other application related debug output. http://www.apress.com/book/downloadfile/1645 _________________________________________________________________ Boo! Scare away worms, viruses and so much more! Try Windows Live OneCare! http://onecare.live.com/standard/en-us/purchase/trial.aspx?s_cid=wl_hotmail…

1 0

Re: gdi32: fix unchecked NULL ptr and off by one error in BIDI_Reorder
by Michael Stefaniuc Oct. 20, 2007

Oct. 20, 2007

Hello Alexander! Alexander Dorofeyev wrote: > This patch fixes two problems that are causing crashes in Thanks for the patch. Could you please split the patch in two; one patch for each problem fixed. Please also do not use C++ style comments aka // > BIDI_Reorder. In particular, Skype 3.5.0 crashed every time I type > anything in the chat edit box. > > One problem is that it wasn't assured lpOutString isn't NULL, and NULL > was getting passed to this routine by GetCharacterPlacementW. so it was > crashing in memcpy. This patch creates a temporary buffer when > lpOutString is NULL and it is used for in-place modifications instead in > such case. > > Another is off by one error in setting lpOrder. > > --- > dlls/gdi32/bidi.c | 33 ++++++++++++++++++++++++++++----- > 1 files changed, 28 insertions(+), 5 deletions(-) > > > ------------------------------------------------------------------------ > > diff --git a/dlls/gdi32/bidi.c b/dlls/gdi32/bidi.c > index cac9453..2b1320e 100644 > --- a/dlls/gdi32/bidi.c > +++ b/dlls/gdi32/bidi.c > + > + if (!lpOutString) > + { > + //temporary buffer was created > + HeapFree(GetProcessHeap(), 0, lpReorderBuffer); > + } > + > return TRUE; > } thanks bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111

1 0

Solidworks 2007 Test with 0.9.47
by Stephan Rose Oct. 20, 2007

Oct. 20, 2007

Major improvement with Solidworks 2007 on the latest version. Visually, everything actually looks perfect now. OpenGL windows are where they are supposed to be. Font is right. So from that end, everything appears to work very well. What's still broken: - Performance is extremely bad. Even on my Dual Core with 4 gigs of RAM. - Memory usage is extremely high still at around 2 gigs. - Extrude function, first thing I test as it's the most fundamental, still won't work. CPU will just go to full load on that core and just sit there forever. Infinite loop maybe? Definite improvement though, thanks everyone. =) Stephan

1 0

winmm test runs forever?
by Dan Kegel Oct. 19, 2007

Oct. 19, 2007

Today I'm starting to see winmm_test spew an infinite series of failures on line 467 of mixer.c: ../../../tools/runtest -q -P wine -M winmm.dll -T ../../.. -p winmm_test.exe.so mixer.c && touch mixer.ok ALSA lib seq_hw.c:456:(snd_seq_hw_open) open /dev/snd/seq failed: No such file or directory mixer.c:359: Test failed: mixerGetDevCapsA: MMSYSERR_NOERROR expected, got MMSYSERR_BADDEVICEID mixer.c:364: Test failed: mixerGetDevCapsA: MMSYSERR_NOERROR expected, got MMSYSERR_BADDEVICEID mixer.c:408: Test failed: mixerGetLineInfoA(MIXER_GETLINEINFOF_DESTINATION): MMSYSERR_INVALPARAM or MIXERR_INVALLINE expected, got MMSYSERR_BADDEVICEID mixer.c:433: Test failed: mixerGetLineInfoA(MIXER_GETLINEINFOF_DESTINATION): MMSYSERR_NOERROR expected, got MMSYSERR_BADDEVICEID mixer.c:467: Test failed: mixerGetLineInfoA(MIXER_GETLINEINFOF_SOURCE): MMSYSERR_NOERROR expected, got MMSYSERR_BADDEVICEID mixer.c:467: Test failed: mixerGetLineInfoA(MIXER_GETLINEINFOF_SOURCE): MMSYSERR_NOERROR expected, got MMSYSERR_BADDEVICEID mixer.c:467: Test failed: mixerGetLineInfoA(MIXER_GETLINEINFOF_SOURCE): MMSYSERR_NOERROR expected, got MMSYSERR_BADDEVICEID mixer.c:467: Test failed: mixerGetLineInfoA(MIXER_GETLINEINFOF_SOURCE): MMSYSERR_NOERROR expected, got MMSYSERR_BADDEVICEID ... I have to do wineserver -k to make progress.

2 2

Make test drill, next steps, call for help with Winetest
by Jeremy White Oct. 19, 2007

Oct. 19, 2007

Hi Folks, So I had plan to report on the status of make test, and sound a call to action. That is, one of the best and most fun things we did at Wineconf was to call bullshit on the failure of make test to work reliably. That is, it only runs cleanly on Alexandre's machine, and not even all the time then. So, we worked hard to make 'make test' work reliably on other folks systems at Wineconf. We made a lot of progress; cutting failures by half, I would say. The closest we got was with Michael; I think he was down to 3 at the end. However, we're still plagued with differences due to chipsets, locales, and other differences. But I think it is vital that we continue this work. The fact that 'make test' doesn't work anywhere, really, is bullshit. However, I'm enough of a weasel that I wanted to get out of collating all of this data myself. So I investigated (or tried to investigate) winetest to see if I could dump this work on a tool. And it looks like it would be great. Of course, with a few caveats :-/. In my opinion, it needs the following: 1. A Wiki page! I could not find *any* documentation on this utility. For example, I'm still not entirely clear on how to setup and/or register my build.id so that my results are available on the web site. (And the rather non intuitive requirement to 'know' the unpublished url http://test.winehq.org/data/ is harsh). 2. Headless operation From my experiments, there were a number of dialogs I had to dismiss, and some worrying complaints in unpacking msvcrtd and msvcrt tests. This second point is probably a bit less important than the first. However, it looked like if just a few little glitches could be ironed out, that it would be a fantastic tool for working on the make test problem. We'd be able to see the common failures, and work to resolve them and drive them to zero. Is there someone that could do the first part of this? Just document what is already there? Or point me to the page that exists that I just missed? Cheers, Jeremy

4 8

Re: D3DX8: [4/13]: implement D3DX__Add with a test
by Stefan Dösinger Oct. 19, 2007

Oct. 19, 2007

Am Freitag, 19. Oktober 2007 10:13:39 schrieb David.Adam(a)math.cnrs.fr: > +#define expect_vec3(expectedvec,gotvec) ok((fabs(expectedvec.x-gotvec.x)<admitted_error)&&(fabs(expectedvec.y-gotvec.y)<admitted_error)&&(fabs(expectedvec.z-gotvec.z)<admitted_error),"Expected Vector= (%f, %f,%f)\n , Got Vector= (%f, %f, %f)\n", expectedvec.x, expectedvec.y, expectedvec.z, gotvec.x, gotvec.y, gotvec.z); Usually inline functions are prefered over macros. I don't know how well that works with ok though, since it might drop the line of the error and make debugging harder.

1 0

Re: D3DX8: [1/13] resent: implement D3Dx__Length with a test
by Stefan Dösinger Oct. 19, 2007

Oct. 19, 2007

Am Freitag, 19. Oktober 2007 10:10:07 schrieb David.Adam(a)math.cnrs.fr: > ----- > Pièces jointes (Les liens expireront le May 1, 2008) > https://webmail.math.cnrs.fr/horde/imp/attachment.php?u=dadam%40math.cnrs.f >r&t=1192788607&f=0001-Implement-D3DX___Length-function-with-a-test.patch.pat >ch Did you forget to attachthe file?

1 0

Use warn+heap when running 'make test'
by Dan Kegel Oct. 19, 2007

Oct. 19, 2007

As noted in http://bugs.winehq.org/show_bug.cgi?id=9916 using warn+heap poisons free memory, and finds a few more bugs. People who run 'make test' should consider running WINEDEBUG=warn+heap make test instead. (I don't know whether we should make that the default, though. Anyone have an opinion?)

2 1

Re: wined3d: Fix resource cleanup if CreateCubeTexture fails.
by Stefan Dösinger Oct. 19, 2007

Oct. 19, 2007

Am Freitag, 19. Oktober 2007 07:14:17 schrieb Allan Tong: Looks good to me

1 0

notepad: Dangling pointer fix
by Andrew Talbot Oct. 18, 2007

Oct. 18, 2007

Please ignore this patch. Thanks, -- Andy.

1 0

Re: [PATCH] wininet: Conformance test for InternetCrackUrlA (try 2)
by Detlef Riekenberg Oct. 18, 2007

Oct. 18, 2007

On Mi, 2007-10-17 at 13:17 -0700, Nigel Liang wrote: > + urlCompa.dwStructSize = sizeof(urlCompa); > + bRet = InternetCrackUrlA(sUrl, 11, 0, &urlCompa); > + ZeroMemory(&urlCompa, sizeof(urlCompa)); > + ZeroMemory(&szBuf, sizeof(char)*1024); > + urlCompa.dwUserNameLength = 1024; It looks much better, when you avoid constant numbers. I suggest to use sizeof() instead. (but never use "sizeof()" in "ok()" or in "trace()".) Thanks for helping wine. -- By by ... Detlef

1 0

Re: widl [4/4]: Detect conformant arrays of user types correctly.
by Robert Shearman Oct. 18, 2007

Oct. 18, 2007

Dan Hipschman wrote: > @@ -1859,6 +1859,7 @@ static int get_struct_type(var_list_t *fields) > case RPC_FC_OP: > case RPC_FC_CARRAY: > case RPC_FC_CVARRAY: > + case RPC_FC_BOGUS_ARRAY: > has_pointer = 1; > break; > > @@ -1897,15 +1898,9 @@ static int get_struct_type(var_list_t *fields) > /* fallthru - treat it as complex */ > > /* as soon as we see one of these these members, it's bogus... */ > - case RPC_FC_IP: > case RPC_FC_ENCAPSULATED_UNION: > case RPC_FC_NON_ENCAPSULATED_UNION: > - case RPC_FC_TRANSMIT_AS: > - case RPC_FC_REPRESENT_AS: > - case RPC_FC_PAD: > - case RPC_FC_EMBEDDED_COMPLEX: > case RPC_FC_BOGUS_STRUCT: > - case RPC_FC_BOGUS_ARRAY: > return RPC_FC_BOGUS_STRUCT; > } > } > Hi Dan, What's the reasoning behind this part of the patch? It seems to me like most of the cases that you removed from becoming a complex structure are actually valid. The hunk further up also confuses me - the presence of a complex array shouldn't just make the resulting structure into a pointer structure, it should make it into a complex structure, since it can't be marshalled solely by using memcpy. -- Rob Shearman

2 1

Priority/severity of test suite hangs
by Dan Kegel Oct. 18, 2007

Oct. 18, 2007

I'm going to start filing bugs for anything that makes the test suite hang, and I'm going to lash out and give them unreasonably high priority and severity. There's just no excuse for a test suite that can't run to completion. -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: [2/3] hlink: Undefine the GetObject macro when compiling the Wine source to avoid errors.
by Jacek Caban Oct. 18, 2007

Oct. 18, 2007

Hi Francois, Francois Gouget wrote: > > +/* GetObject is defined in wingdi.h as WINELIB_NAME_AW(GetObject), > + * which resolves to a compilation failure if WINE_NO_UNICODE_MACROS is > + * defined, but GetObject is used as a valid method name below, so we have > + * to undefine it in that case */ > +cpp_quote("#ifdef WINE_NO_UNICODE_MACROS") > +cpp_quote("#undef GetObject") > +cpp_quote("#endif") > + > /***************************************************************************** > * IHlinkBrowseContext interface > */ > I've sent a patch for it yesterday and it's applied now: http://source.winehq.org/git/wine.git/?a=commitdiff;h=a41cab9b52893f472de6c… I've also sent a patch for mshtml.idl patch (but my version didn't include import shtypes.idl): http://source.winehq.org/git/wine.git/?a=commitdiff;h=62894b488d0b03a922b80… Thanks, Jacek

1 0

Re: inkobj: Implement IClassFactory
by Alexandre Julliard Oct. 18, 2007

Oct. 18, 2007

"John Klehm" <xixsimplicityxix(a)gmail.com> writes: > This patch is largely based on the code found in mshtml. What I did > was separate it into its own file and restyle it to my liking. Restyling it wasn't such a good idea I'm afraid, the original code is better without these ugly casts, and the Release function was correct, unlike yours. Also please don't name your files inkobj_something, they are in the inkobj directory already, no need to repeat that in the file name. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW (try 2)
by Alexandre Julliard Oct. 18, 2007

Oct. 18, 2007

Nigel Liang <ncliang(a)gmail.com> writes: > Previous patch had incorrect bounds for memchrW. There are other places in that function that assume that the string is null-terminated, please fix those too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Added support for installing Gecko from build dir.
by Alexandre Julliard Oct. 18, 2007

Oct. 18, 2007

Jacek Caban <jacek(a)codeweavers.com> writes: > - static const char gecko_dir[] = "/gecko/"; > - > - data_dir = wine_get_data_dir(); > - if(!data_dir) return FALSE; > + if((data_dir = wine_get_data_dir())) > + subdir = "/gecko/"; > + else if((data_dir = wine_get_build_dir())) > + subdir = "/dlls/mshtml/"; I don't think this file should be inside the build dir, it's not something that can be easily regenerated. Maybe we should look for it in $build_dir/.. ? -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: msi: make the WriteEnvironmentStrings handling of [~] a bit better
by EA Durbin Oct. 18, 2007

Oct. 18, 2007

The compiler complains at this line about lstrlenW being passed an incompatible pointer type + else if (lstrlenW(value) >= prefix_len) should it be lstrlenW(*value) ? _________________________________________________________________ Climb to the top of the charts! Play Star Shuffle: the word scramble challenge with star power. http://club.live.com/star_shuffle.aspx?icid=starshuffle_wlmailtextlink_oct

2 1

Re: [PATCH] wininet: Close sockets open in http requests
by Misha Koshelev Oct. 18, 2007

Oct. 18, 2007

> n 10/13/07, Nigel Liang <ncliang at gmail.com> wrote: > > Hi, > > > > Http requests open sockets and forget to close them. Left running over a long > > period, the socket file descriptor starts getting large. Once it exceeds > > FD_SETSIZE, the behavior becomes unpredictable and results in funcky crashes. > > > > -Nigel > > > > --- > > dlls/wininet/internet.c | 3 +++ > > 1 files changed, 3 insertions(+), 0 deletions(-) > > > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > > index 0edca74..8e3a98e 100644 > > --- a/dlls/wininet/internet.c > > +++ b/dlls/wininet/internet.c > > @@ -1014,6 +1014,9 @@ BOOL WINAPI InternetCloseHandle(HINTERNE > > return FALSE; > > } > > > > + if (lpwh->htype == WH_HHTTPREQ) > > + NETCON_close(&((LPWININETHTTPREQW)lpwh)->netConnection); > > + > > WININET_Release( lpwh ); > > WININET_FreeHandle( hInternet ); > > > > -- > > 1.4.1 > > > > > > Hi, > > This patch was sent 4 days ago and it hasn't gone in yet. Could anyone > give me some comments on it? Dan filed bug 10032 which is related to > this. While we shouldn't be using select() on high FDs for networking, > this patch closes the sockets that were open by http requests to avoid > getting to high FDs... > > Thanks, > -Nigel Hi, well looking over this very quickly right off the bat it does not seem correct to me. WININET_Release will call the close_connection method of the handle if it is defined, and for WH_HHTTPREQ this is HTTP_CloseConnection, which does call NETCON_Close along with sending all the proper status notifications, etc. So if in fact NETCON_Close is _not_ being called for some reason, you need to track down where involving those functions either why the proper one is not getting called (if that is the case) or if that function somehow needs to call NETCON_Close when it doesn't. Misha

2 3

Re: [PATCH] wininet: Close sockets open in http requests
by Nigel Liang Oct. 17, 2007

Oct. 17, 2007

On 10/13/07, Nigel Liang <ncliang(a)gmail.com> wrote: > Hi, > > Http requests open sockets and forget to close them. Left running over a long > period, the socket file descriptor starts getting large. Once it exceeds > FD_SETSIZE, the behavior becomes unpredictable and results in funcky crashes. > > -Nigel > > --- > dlls/wininet/internet.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index 0edca74..8e3a98e 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -1014,6 +1014,9 @@ BOOL WINAPI InternetCloseHandle(HINTERNE > return FALSE; > } > > + if (lpwh->htype == WH_HHTTPREQ) > + NETCON_close(&((LPWININETHTTPREQW)lpwh)->netConnection); > + > WININET_Release( lpwh ); > WININET_FreeHandle( hInternet ); > > -- > 1.4.1 > > Hi, This patch was sent 4 days ago and it hasn't gone in yet. Could anyone give me some comments on it? Dan filed bug 10032 which is related to this. While we shouldn't be using select() on high FDs for networking, this patch closes the sockets that were open by http requests to avoid getting to high FDs... Thanks, -Nigel

1 0

wnaspi and DVD Burner
by Stefan Leichter Oct. 17, 2007

Oct. 17, 2007

Hello, i tried to make some progress with Ahead Nero, but now i'm stuck. I found the NeroSDK-1.08.zip and inside the comand line tool NeroAPITest.exe. The source code of NeroAPITest.exe is in the archive too. This makes finding the problems easier. Executing the comand 'wine NeroAPITest.exe --listdrives' the open function in SCSI_OpenDevice fails first with ENOMEDIUM. Putting a disk into the drive the command fails with errno 30 (Read-only). Opening the drive read only works, but next is a write on the file descriptor that fails because it was opened readonly ... The scenario above fails only for my PATA DVD burner. My SCSI DVD reader and my SCSI CD reader are working well with the command sequence listed above. My OS is Debian etch (32bit) the burner is a Plextor PX-716A. Is the reason for this the difference between IDE and SCSI in the kernel? Is it a fault of the DVD burner device (firmware)? What might be a workaround for the problem? Thanks for your thought Stefan

1 0

Wine Stats Malfunctioning
by luis.busquets＠ilidium.com Oct. 17, 2007

Oct. 17, 2007

Web page: http://www.winehq.org/site/winapi_stats on wine statistics does not work.

2 1

Re: [PATCH] wininet: Substitute strchrW with memchrW in InternetCrackUrlW.txt
by Frank Richter Oct. 17, 2007

Oct. 17, 2007

On 17.10.2007 06:49, Nigel Liang wrote: > Hi, > > strchrW assumes a NULL-terminated string. May crash if terminating character is > not found. memchrW is better because you can specify the maximum number of > bytes to search. On the flipside, memchrW() doesn't stop at a NUL... -f.r.

2 1

Possible WIne regression with Warcraft
by Michael Lothian Oct. 17, 2007

Oct. 17, 2007

Hi I've noticed a problem in wine recently. When I try and join a network game in Warcraft I can see the game but I'm unable to join it. These errors are printing out: fireburn(a)tau ~/.wine/drive_c/Program Files/Warcraft III $ wine Frozen\ Throne.exe ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib control.c:909:(snd_ctl_open_noupdate) Invalid CTL default:0 err:ole:CoCreateInstance apartment not initialised fixme:advapi:SetSecurityInfo stub fixme:win:EnumDisplayDevicesW ((null),0,0x34f3d8,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f7b0,0x00000000), stub! fixme:win:EnumDisplayDevicesW ((null),0,0x34f3bc,0x00000000), stub! fireburn(a)tau ~/.wine/drive_c/Program Files/Warcraft III $ fixme:winsock:WSAIoctl unsupported WS_IOCTL cmd (9800000c) fixme:mswsock:AcceptEx (listen=8552, accept=8564, 0x31100e8, 0, 32, 32, 0x34f498, 0x31100b8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8568, 0x3110170, 0, 32, 32, 0x34f498, 0x3110140), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8572, 0x31101f8, 0, 32, 32, 0x34f498, 0x31101c8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8576, 0x3110280, 0, 32, 32, 0x34f498, 0x3110250), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8580, 0x3110308, 0, 32, 32, 0x34f498, 0x31102d8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8584, 0x3110390, 0, 32, 32, 0x34f498, 0x3110360), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8588, 0x3110418, 0, 32, 32, 0x34f498, 0x31103e8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8592, 0x31104a0, 0, 32, 32, 0x34f498, 0x3110470), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8596, 0x3110528, 0, 32, 32, 0x34f498, 0x31104f8), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8600, 0x31105b0, 0, 32, 32, 0x34f498, 0x3110580), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8604, 0x3110638, 0, 32, 32, 0x34f498, 0x3110608), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8608, 0x31106c0, 0, 32, 32, 0x34f498, 0x3110690), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8612, 0x3110748, 0, 32, 32, 0x34f498, 0x3110718), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8616, 0x31107d0, 0, 32, 32, 0x34f498, 0x31107a0), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8620, 0x3110858, 0, 32, 32, 0x34f498, 0x3110828), not implemented fixme:mswsock:AcceptEx (listen=8552, accept=8624, 0x31108e0, 0, 32, 32, 0x34f498, 0x31108b0), not implemented fixme:imm:ImmAssociateContextEx (0x30028, (nil), 16): stub I'm going to try rolling back to an old version of Wine, I currently use the latest git. I'll post back if it does work. Mike

4 7

Re: widl [1/2]: Improve file cleanup when errors occur
by Alexandre Julliard Oct. 17, 2007

Oct. 17, 2007

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -446,10 +441,18 @@ static void rm_tempfile(void) > abort_import(); > if(temp_name) > unlink(temp_name); > - if (header_name) > - unlink(header_name); > - if (client_name) > - unlink(client_name); > - if (server_name) > - unlink(server_name); > + if (nerrors) { > + if (do_header) > + unlink(header_name); > + if (do_client) > + unlink(client_name); > + if (do_server) > + unlink(server_name); > + if (do_idfile) > + unlink(idfile_name); > + if (do_proxies) > + unlink(proxy_name); > + if (do_typelib) > + unlink(typelib_name); > + } This will break cleanup on signals. I think it's better to always remove the files instead of relying on the error count being set correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

"make test" failure in gdi32/bitmap.c
by Dan Kegel Oct. 17, 2007

Oct. 17, 2007

"make test" fails for me with: bitmap.c:1113: Test failed: GetDIBits with 4 bpp DIB selected in DC: Invalid DIB bits bitmap.c:1113: Test failed: GetDIBits with 8 bpp DIB selected in DC: Invalid DIB bits err:x11drv:X11DRV_CreateBitmap Trying to make bitmap with planes=1, bpp=24 err:bitmap:DIB_GetBitmapInfo (39): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (11): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (13): unknown/wrong size for header err:bitmap:DIB_GetBitmapInfo (16): unknown/wrong size for header make[2]: *** [bitmap.ok] Error 2 make[2]: Leaving directory `/home/dank/wine-git/dlls/gdi32/tests' I think this is new since I last ran the tests (at wineconf)...?

3 2

Re: [PATCH] wininet: Conformance test for InternetCrackUrlA.txt
by Dmitry Timoshkov Oct. 17, 2007

Oct. 17, 2007

"Nigel Liang" <ncliang(a)gmail.com> wrote: > + ok( GetLastError() == ERROR_INVALID_PARAMETER, "Last error wrong: %p\n", > + GetLastError()); GetLastError() returns not a pointer. -- Dmitry.

1 0

Wine 1.0 bugs, release criteria
by Denali Coldstar Oct. 16, 2007

Oct. 16, 2007

Dan Kegel <dank <at> kegel.com> writes: >* *>* At Wineconf 2007, I was appointed to be the guy who decides *>* (with Alexandre's approval) what bugs are 1.0 bugs and what aren't. *>* So I've started adjusting the "Target Release" fields on a few *>* bugs in Bugzilla. *>* Over the next month or so, I'd like Wine developers to nominate important * >* Comments? *>* - Dan *>* *> === Good Afternoon, I believe Ventrilo meets the criteria set forth in http://wiki.winehq.org/WineReleaseCriteria. In the gaming community, when you use VOIP applications, it generally boils down to TeamSpeak and Ventrilo. While TeamSpeak has a Linux native client, Ventrilo doesn't. I can't necessarily say Vent holds 50% of the market, but I feel safe in saying it holds a significant share of it. This is mainly based on the fact several companies have sprung up over the years to offer hosting of Vent servers. The client can be freely downloaded from the Ventrilo website ( http://www.ventrilo.com/download.php) but I'm not sure if it can be grabbed with wget. Lastly, it does not have an autoupdate but it will pop up a notice if a new version is available. If it is found that Ventrilo would be a suitable program for consideration in the 1.0 release, the following issues would need to be addressed: http://bugs.winehq.org/show_bug.cgi?id=1348 http://bugs.winehq.org/show_bug.cgi?id=5178 http://bugs.winehq.org/show_bug.cgi?id=5924 http://bugs.winehq.org/show_bug.cgi?id=5978 Thank you for reading this post. Steve

2 1

Error compiling progman
by Daniel Nylander Oct. 16, 2007

Oct. 16, 2007

I have some problems compiling progman. gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o string.o string.c ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -forsrc.res rsrc.rc Xx.rc:23:8: Error: syntax error make: *** [rsrc.res] Error 1 Line 23 in Xx.rc looks like this: CONCAT(MENU_, LANGUAGE_ID) MENU What could be the problem? -- Daniel Nylander (CISSP, GCUX, GCFA) Stockholm, Sweden http://www.DanielNylander.se info(a)danielnylander.se yeager(a)ubuntu.com dnylande(a)gnome.org

2 1