November 2007 - Wine-Devel - list.winehq.org

Re: [PATCH 1/7] advapi32: Implement CredWriteW.
by Detlef Riekenberg Nov. 3, 2007

Nov. 3, 2007

On Di, 2007-10-30 at 12:36 +0000, Robert Shearman wrote: > +static DWORD open_cred_mgr_key(HKEY *hkey, BOOL open_for_write) > +{ > + return RegCreateKeyExW(HKEY_CURRENT_USER, > wszCredentialManagerKey, 0, > + NULL, REG_OPTION_NON_VOLATILE, > + KEY_READ | KEY_WRITE, NULL, hkey, NULL); > +} > + What's the reason of the Parameter "BOOL open_for_write" ? open_cred_mgr_key is called with (..., TRUE) and (..., FALSE), but you always use "KEY_READ | KEY_WRITE". On the other hand, gcc does not warn about that unused Parameter. My first Idea was the optimizer in gcc, but removing "-O2" does not give us a warning. With "-pedantic", we lost (but still no warning for "open_for_write"). -- By by ... Detlef

2 2

Re: msxml - Fix Memory Leak
by Vitaliy Margolen Nov. 3, 2007

Nov. 3, 2007

Not really. Now it's an attachment of "application/octet-stream" type. Not plain/text. Try renaming the file to *.patch.txt. Vitaliy. Alistair Leslie-Hughes wrote: > Hi Vitaliy, > > Thanks for the information, I though I had fixed my News client. > > Does this work better? Ill forward to the patch list if this works. > > Best Regards > Alistair > > > > > 00 > > From: wine-devel(a)kievinfo.com > > To: wine-devel(a)winehq.org > > CC: leslie_alistair(a)hotmail.com > > Subject: Re: msxml - Fix Memory Leak > > > > Alistair Leslie-Hughes wrote: > > > Hi, > > > > > > Changelog: > > > Fixed memory leak > > > > > > > > > Regards > > > Alistair Leslie-Hughes > > > > > > > > > begin 666 xmlelem.diff > > > > Please attach patches as a plain text. This patch is not an > attachment and > > is unreadable. > > > > Vitaliy. > >

1 0

re: USER32: win16 applications should not see long filenames returned from dialog control
by Dan Kegel Nov. 2, 2007

Nov. 2, 2007

Alex wrote: > Legacy Win16 applications display file/directory selection listboxes and > expect to receive a short name from the control.... >The attached patch attempts to fix this >by converting the about-to-be-returned name to a short name if the expected >windows version is not at least Win95 How about converting to a short name in the win16 wrapper code instead?

1 0

Re: mshtml: Set IE version when installing wine gecko
by Jacek Caban Nov. 2, 2007

Nov. 2, 2007

Hi Chris, This patch is already committed, but, I'm afraid, it's wrong. Setting these registries has nothing to do with installing Gecko. Setting them in Gecko installer will only make supporting it harder. We don't want to tell user to "run iexplore about:blank" to get an app working. I will send a better patch that always sets them. Last time Alexandre didn't accept such a patch, because of apps that need native IE and install it only when this key is not found. It looks like it's time for such change. Thanks, Jacek

4 8

Generic text printer driver
by Juan Luis Ramos Nov. 2, 2007

Nov. 2, 2007

Hi all, is there anybody working in the generic text printer driver o raw printer driver? I've a problem with a compatible Epson POS printer so, I've modified the text.c code inside wineps.drv to send the text to the printer without postscript processing. The function that send the data is PSDRV_ExtTextOut, but the LPCWSTR parameter passed (str) doesn't contain the ESCAPE codes sent to the printer. I don't find when does the program call the PSDRV_ExtTextOut function. Can anybody help me? Thanks.

2 1

Re: [PATCH 07/18] inetcomm: Add an implementation of an SMTP transport.
by Juan Lang Nov. 2, 2007

Nov. 2, 2007

Hi Rob, + const char szHostName[] = "roblaptop"; /* FIXME */ Did you mean to leave that in? --Juan

3 2

Re: Fix type of loop variable in alloc_device().
by Vitaliy Margolen Nov. 2, 2007

Nov. 2, 2007

Gerald Pfeifer wrote: > We iterate between 0 and and the value of an usigned variable, so we > should adjust the loop variable accordingly (not the list to silence > GCC). > - int i; > + unsigned i; If there is nothing wrong about it, then why do you change it? If even gcc does not complain about it. Vitaliy.

2 1

Re: [Bug 10266] Numpad keyboard handling is strange, Del key produces two events
by Peter Åstrand Nov. 2, 2007

Nov. 2, 2007

Perhaps we need to gather more input from other developers: > http://bugs.winehq.org/show_bug.cgi?id=10266 > > --- Comment #4 from Dmitry Timoshkov <dmitry(a)codeweavers.com> 2007-11-01 08:32:46 --- > > But in that case, you will find all of your X11 applications on your desktop, > > including Firefox etc, confusing as well? > > Yes, and this behaviour is very annoying and not consistent IMO. Let's break down this statement into two: 1) "Not consistent" It might be interesting to compare with CapsLock. Shift can cancel CapsLock, but also substitute it. This is true on both Windows and Linux. Additionally, on Linux, NumLock works the same, ie Shift works in both directions. On Windows, however, Shift can only cancel NumLock, not substitute it. Regardless of whether users actually finds this useful or not, I think it's hard to argue for that this is "logical" or "consistent". 2) "Annoying" Can it be that you have a Windows background and are therefore used to the Windows behaviour? I haven't actually asked any users yet, but my general opinion is that all applications on the same desktop should behave the same, if possible. We are decorating the Windows windows with the normal window manager decorations etc so I think it's reasonable that the keyboard should behave according to the native system model. Another thing to keep in mind is that most users actually never use the numpad keys in conjunction with Shift. I know this from several years of experience of keyboard hacking - there have been plenty of bugs in many softwares in this area but very few actual bug reports. > Besides, I just tested with Wine's notepad and don't see the problem you > are reporting. Which keyboard layout are you using? On my system, Wine selects the Swedish keyboard layout. Regards, --- Peter Åstrand ThinLinc Chief Developer Cendio AB http://www.cendio.se Wallenbergs gata 4 583 30 Linköping Phone: +46-13-21 46 00 ThinLinc User Group 2007 Höstkonferens --- 15-16 november, Linköping. Program och anmälan: http://www.thinlincusergroup.se/aktiviteter

2 5

Re: [PATCH 04/18] inetcomm: Add self-registration code.
by Paul Vriens Nov. 2, 2007

Nov. 2, 2007

Robert Shearman wrote: > --- +static LONG recursive_delete_key(HKEY key); +static LONG recursive_delete_keyA(HKEY base, char const *name); +static LONG recursive_delete_keyW(HKEY base, WCHAR const *name); We just got rid of all the self build recursive delete ones. Can you use RegDeleteTree[AW] (or is there a specific reason not to)? -- Cheers, Paul.

3 2

Re: msxml - Fix Memory Leak
by Vitaliy Margolen Nov. 2, 2007

Nov. 2, 2007

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > Fixed memory leak > > > Regards > Alistair Leslie-Hughes > > > begin 666 xmlelem.diff Please attach patches as a plain text. This patch is not an attachment and is unreadable. Vitaliy.

1 0

Re: shell32: Use SHStrDupW in IShellFolder2::GetDetailsOf to allocate returned string
by Vitaliy Margolen Nov. 2, 2007

Nov. 2, 2007

Thomas Weidenmueller wrote: > Use SHStrDupW in IShellFolder2::GetDetailsOf to allocate the returned > string. pOleStr in the STRRET structure has to be allocated using > CoTaskMemAlloc(). SHStrDupW uses CoTaskMemAlloc() whereas StrDupW uses > LocalAlloc(). > > - Thomas > ------------------------------------------------------------------------ > > Index: recyclebin.c > =================================================================== > RCS file: /home/wine/wine/dlls/shell32/recyclebin.c,v > retrieving revision 1.5 > diff -u -r1.5 recyclebin.c > --- recyclebin.c 11 Jun 2007 13:47:57 -0000 1.5 > +++ recyclebin.c 1 Nov 2007 21:58:30 -0000 Please diff it from the top of the source tree. The above should say dlls/shell32/recyclebin.c Vitaliy.

1 0

Re: [PATCH 02/18] inetcomm: Add a framework for connecting to a server and sending/receiving data asynchronously with callbacks being called in the context of the original thread, using window messages.
by Alexandre Julliard Nov. 2, 2007

Nov. 2, 2007

Robert Shearman <rob(a)codeweavers.com> writes: > +#include "winsock2.h" > +#include "winuser.h" > + > +#undef GetProp > +#undef SendMessage > +#undef SetProp > + > +#include "objbase.h" > +#include "imnxport.h" You forgot to submit the new imnxport.idl. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: setupapi: Add stub for SetupInstallServicesFromInfSectionW
by Robert Shearman Nov. 2, 2007

Nov. 2, 2007

Chris Robinson wrote: > @ stdcall SetupInstallFromInfSectionA(long long str long long str long ptr ptr long ptr) > @ stdcall SetupInstallFromInfSectionW(long long wstr long long wstr long ptr ptr long ptr) > @ stdcall SetupInstallServicesFromInfSectionA(long str long) > +@ stdcall SetupInstallServicesFromInfSectionW(long wstr long) > @ stub SetupInstallServicesFromInfSectionExA > @ stub SetupInstallServicesFromInfSectionExW > -@ stub SetupInstallServicesFromInfSectionW > @ stdcall SetupIterateCabinetA(str long ptr ptr) > @ stdcall SetupIterateCabinetW(wstr long ptr ptr) > @ stub SetupLogErrorA > There's no need to move the entry for SetupInstallServicesFromInfSectionW. The list was sorted alphabetically, but now it isn't. -- Rob Shearman

3 2

Valgrind and structs with holes
by Dan Kegel Nov. 2, 2007

Nov. 2, 2007

Valgrind is a great tool, but if there's a struct with a hole in it, and we write that struct to a socket (say, to send it to the server), valgrind will likely complain that the hole is uninitialized. For instance, the warning ==3415== Syscall param writev(vector[1]) points to uninitialised byte(s) ==3415== at 0x40007F2: (within /lib/ld-2.6.1.so) ==3415== by 0x4412E24: wine_server_call (server.c:244) ==3415== by 0x43EBA73: server_ioctl_file (file.c:1010) ==3415== by 0x43EC570: NtFsControlFile (file.c:1223) ==3415== by 0x45394C1: WaitNamedPipeW (sync.c:1298) ==3415== by 0x453963B: WaitNamedPipeA (sync.c:1225) ==3415== by 0x46490B5: test_CreateNamedPipe (pipe.c:97) in kernel32/tests/sync.c can be silenced either by appeasing Valgrind with a patch like --- a/dlls/kernel32/sync.c +++ b/dlls/kernel32/sync.c @@ -1285,6 +1285,12 @@ BOOL WINAPI WaitNamedPipeW (LPCWSTR name, DWORD nTimeOut) return FALSE; } + /* FILE_PIPE_WAIT_FOR_BUFFER has a hole after boolean TimeoutSpecified. + * Clear the hole so valgrind doesn't get upset about uninitialized bytes. + * No need to zero Name[1...], which is initialized ok later. + */ + memset(pipe_wait, 0, sizeof(FILE_PIPE_WAIT_FOR_BUFFER)); or by using a suppression like { wine_struct_hole_FILE_PIPE_WAIT_FOR_BUFFER Memcheck:Param writev(vector[1]) obj:* fun:wine_server_call fun:server_ioctl_file fun:NtFsControlFile fun:WaitNamedPipeW } Alexandre, which approach would you prefer? If you say #1, I'll eat my hat. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Exception but not when running with +relay
by Paul Vriens Nov. 2, 2007

Nov. 2, 2007

Hi, I just tried the latest PE Explorer (http://www.heaventools.com/download-pe-explorer.htm) When I stopped the application I ran into an exception within NtSetInformationThread. If I however do a +relay I don't get into this exception. What does such a difference point to? -- Cheers, Paul.

1 0

valgrind results online
by Dan Kegel Nov. 2, 2007

Nov. 2, 2007

I've posted results from running the entire conformance test suit under Valgrind at http://kegel.com/wine/valgrind/20071001/ There are 100 files there; one for each test that had warnings. (And one more file with everything concatenated together, http://kegel.com/wine/valgrind/20071001/vg-all.txt) A lot of the warnings are probably just problems in our conformance tests, not in Wine, and several of the warnings might be problems in Valgrind. But I wouldn't be surprised if there were several dozen real problems in Wine, so please take a look. (Juan has already submitted a bunch of cleanups for crypt32. I'll probably run these tests daily for a while and upload the results to a new directory for each day.) I've also updated the instructions on how to run tests under Valgrind, http://wiki.winehq.org/Wine_and_Valgrind and updated the Wine patch there to include a bunch more suppressions. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Dead code in dlls/ntdll/tape.c
by Gerald Pfeifer Nov. 1, 2007

Nov. 1, 2007

We currently have the following code in tape.c: if (data->Offset.u.LowPart >= 0) { cmd.mt_op = MTFSF; cmd.mt_count = data->Offset.u.LowPart; } else { cmd.mt_op = MTBSF; cmd.mt_count = -data->Offset.u.LowPart; } data is of type TAPE_SET_POSITION*, which in turn is defined as typedef struct _TAPE_SET_POSITION { ULONG Method; ULONG Partition; LARGE_INTEGER Offset; BOOLEAN Immediate; } TAPE_SET_POSITION, *PTAPE_SET_POSITION; Offset is of type LARGE_INTEGER which is defined as struct { DWORD LowPart; LONG HighPart; } u; Note how LowPart is unsigned (DWORD) here, so indeed the comparisons for >= 0 is always going to evaluate to true. Hans, I believe you originally wrote that code. Do you remember what you where trying to do here? The patch below removes this dead code and is equivalent to what we currently have. I am not sure it is the desired way to fix what I describe above, though. Gerald Index: dlls/ntdll/tape.c =================================================================== RCS file: /home/wine/wine/dlls/ntdll/tape.c,v retrieving revision 1.16 diff -u -3 -p -r1.16 tape.c --- dlls/ntdll/tape.c 26 Jun 2007 12:14:34 -0000 1.16 +++ dlls/ntdll/tape.c 1 Nov 2007 16:32:29 -0000 @@ -427,25 +427,13 @@ static NTSTATUS TAPE_SetPosition( int fd break; #endif case TAPE_SPACE_FILEMARKS: - if (data->Offset.u.LowPart >= 0) { - cmd.mt_op = MTFSF; - cmd.mt_count = data->Offset.u.LowPart; - } - else { - cmd.mt_op = MTBSF; - cmd.mt_count = -data->Offset.u.LowPart; - } + cmd.mt_op = MTFSF; + cmd.mt_count = data->Offset.u.LowPart; break; #if defined(MTFSS) && defined(MTBSS) case TAPE_SPACE_SETMARKS: - if (data->Offset.u.LowPart >= 0) { - cmd.mt_op = MTFSS; - cmd.mt_count = data->Offset.u.LowPart; - } - else { - cmd.mt_op = MTBSS; - cmd.mt_count = -data->Offset.u.LowPart; - } + cmd.mt_op = MTFSS; + cmd.mt_count = data->Offset.u.LowPart; break; #endif case TAPE_LOGICAL_BLOCK:

3 2

Wine Gecko packaging
by Jacek Caban Nov. 1, 2007

Nov. 1, 2007

Hello, As you probably have noticed, downloading Gecko on first use confuses users. Now, with last week patches, there is an other way to do it, transparent for users. MSHTML code looks for cab file in $data_dir/gecko (that is usually /usr/share/wine/gecko). Alternatively, if you run Wine from build dir, it looks for $build_dir/../gecko. Wine checks it both in wineprefixcreate and, if Gecko is not installed, on first usage. It means that if you download wine_gecko-0.1.0.cab from SourceForge and put it in the right place, you will no longer have to care about installing Gecko. Now, it's time to consider Linux packages to simplify its use. In Gentoo it may be a separate USE flag, but for other distributions that don't support such things, we'll need a separate package. Such package will need only one file placed in the right place, so it should be easy to do and maintain (I don't expect versions to change often). Are Wine packagers interested in creating Gecko packages? Thanks, Jacek

4 6

iexplore proxy server
by Luke Bratch Nov. 1, 2007

Nov. 1, 2007

Hello Is there supposed to be a way to set a HTTP (or otherwise) proxy server in Wine's iexplore at the moment? I can't find any such documentation, but searching around has found a lot of people suggesting that setting these keys will help: [Software\\Microsoft\\Windows\\CurrentVersion\\Internet Settings] "ProxyEnable"=dword:00000001 "ProxyServer"="proxyserver:8080" Setting those didn't make any difference in iexplore, but the attached patch which edits a file that the Gecko installer creates, makes HTTP proxy support work perfectly. Is this the correct/only way to do this? Thanks Luke Bratch ___________________________________________________________ Yahoo! Answers - Got a question? Someone out there knows the answer. Try it now. http://uk.answers.yahoo.com/

2 1

Cleanup of riched20 tests - request for help on test_WM_PASTE
by Alex Villacís Lasso Nov. 1, 2007

Nov. 1, 2007

I am currently trying to clean up the riched20 tests that are failing in WinXP. While doing this, I have encountered the following problem: on the function test_WM_PASTE() (at line 1959 of dlls/riched20/tests/editor.c in current git), the test is supposed to feed simulated keystrokes corresponding to Ctrl-C, Ctrl-V, and so on, supposedly to test copy and paste features via the keyboard. The problem is that the verification at line 1989 fails on WinXP, because the text on the control has not been modified - the control seems to disregard simulated WM_CHAR messages of the Ctrl-<keystroke> variety. The test at line 1977 succeeds accidentally, because the sequence of Ctrl-C, Ctrl-V, Ctrl-Z that is being tested is equivalent to not modifying the control text at all. A more through test would be to send WM_GETTEXT messages after each step to ensure that the text is actually being modified, but the bigger problem is how to make the control obey the keystrokes in the first place. If I place a message loop right before the DestroyWindow() call, I can send keystrokes manually and they work as expected. Only simulated WM_CHAR messages are being discarded. I have tried changing the SendMessage() calls into PostMessage() calls (since Visual Studio's Spy++ shows that WM_CHAR messages were posted, not sent), but to no avail. I have also tried placing message loops between messages, with no luck. I have even tried to simulate the WM_KEYDOWN and WM_KEYUP messages with parameters exactly as seen by Spy++, but this does not work either. So I am asking for help. What could be going wrong with this test? How can I feed the expected keystrokes so that the test works as expected? Has this test ever worked before? It fails in both WinXP (real machine) and inside a QEMU session running Win98. (All tests on WinXP were compiled with CygWin) -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

1 1

Re: Make test drill, next steps, call for help with Winetest
by Hans Leidekker Nov. 1, 2007

Nov. 1, 2007

I have written attached script to facilitate automated winetest runs. It needs a VirtualBox virtual machine with either Windows or a Wine platform configured to run autorun.inf files. The script downloads the latest winetest binary and puts it in an iso image, along with an autorun file to trigger its execution when the image is 'inserted' into the virtual drive. A snapshot is used to revert the vm to its original state, so no need to worry about winetest screwing up your installation. -Hans #!/bin/bash if [ $# -lt 2 ]; then echo "Usage: $0 <vmname> <tag>" echo "" echo "vmname: Virtual machine to use (must be in suspended state). echo "tag: Tag built from [-.0-9a-zA-Z] to identify test report. exit 1 fi TMPDIR=/tmp/winetest$$ LOGFILE=$TMPDIR/log mkdir -p $TMPDIR/master echo "downloading winetest binary" wget -P $TMPDIR http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/winetest-latest.exe >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi mv $TMPDIR/winetest-latest.exe $TMPDIR/master/winetest.exe echo "creating autorun.inf" cat > $TMPDIR/master/autorun.inf <<_EOF_ [autorun] open=winetest.exe -q -t $2 _EOF_ echo "creating cd image" mkisofs -o $TMPDIR/winetest.iso $TMPDIR/master >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "checking vm $1 state" VBoxManage showvminfo $1 | grep "^State:" | grep "saved" >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "creating snapshot for vm $1" VBoxManage snapshot $1 take before-winetest >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "starting vm $1" VBoxManage startvm $1 >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "waiting until vm $1 is up and running" RUNNING="false" while [ $RUNNING != "true" ] do VBoxManage showvminfo $1 | grep "^State:" | grep "running" >> $LOGFILE 2>&1 if [ $? -eq 0 ]; then RUNNING="true" fi sleep 1 done echo "attaching cd image to vm $1" VBoxManage controlvm $1 dvdattach $TMPDIR/winetest.iso >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "sleeping while vm $1 runs winetest" sleep 1800 # 30 minutes should be enough for winetest to finish echo "suspending vm $1" VBoxManage controlvm $1 savestate >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi echo "waiting until vm $1 is suspended" SAVED="false" while [ $SAVED != "true" ] do VBoxManage showvminfo $1 | grep "^State:" | grep "saved" >> $LOGFILE 2>&1 if [ $? -eq 0 ]; then SAVED="true" fi sleep 1 done echo "reverting vm $1 to previous state" VBoxManage snapshot $1 discardcurrent -all >> $LOGFILE 2>&1 if [ $? -ne 0 ]; then exit 1 fi rm -rf $TMPDIR exit 0

5 10

Bug in dlls/oleaut32/tests/vartype.c?
by Gerald Pfeifer Nov. 1, 2007

Nov. 1, 2007

dlls/oleaut32/tests/vartype.c has the following snippet of code: + f = -1e-400; /* deliberately cause underflow */ + hres = pVarBstrFromR4(f, lcid, 0, &bstr); + ok(hres == S_OK, "got hres 0x%08lx\n", hres); + if (bstr) + { + todo_wine ok(memcmp(bstr, szZero, sizeof(szZero)) == 0, "negative zero (got %s)\n", wtoascii(bstr)); + } which was added in revision 1.27 Alex Villacís Lasso <a_villacis(a)palosanto.com> Test for behavior of negative underflow formatting. This doesn't seem to work as intended, because it is a floating point *constant* which current versions of GCC simply truncate to 0.0. Gerald -- Gerald (Jerry) Pfeifer gerald(a)pfeifer.com http://www.pfeifer.com/gerald/

2 3

New DLL, Server and Service Documentation
by Roy Shea Nov. 1, 2007

Nov. 1, 2007

Howdy All, This autumn I began learning both Wine and COM. A combination of limited documentation and trouble finding the right example code for my task at hand made this a difficult process. In an attempt to help other new Wine and COM developers I wrote a tutorial on COM development the Wine way. This tutorial describes: - A simple DLL providing a in-process COM object - A simple server providing a local COM object - A simple service that publishes a COM object and the corresponding proxy / stub required to use the service with instructions on Wine integration and, for Windows users or testers building for Windows, basic instructions on building and running these same applications in Windows. The tutorial is available at: http://ambleramble.org/wine/ I hope other developers enjoy this documentation. If you see mistakes, either minor typos or conceptual problems, please drop me an email and I'll clean up the docs. Peace, -Roy

2 1

Re: wined3d: Enable clip planes with GLSL shader backend
by Ivan Gyurdiev Nov. 1, 2007

Nov. 1, 2007

> + if (use_vs(stateblock->wineD3DDevice) && stateblock->wineD3DDevice->vs_selected_mode == SHADER_ARB) GLSL specific logic should go in glsl_shader.c. Please try to get away from writing code in terms of flags and if statements - use the OOP model. Backend-specific logic should be removed from pixelshader and vertexshader too...

2 1