December 2007 - Wine-Devel - list.winehq.org

Re: comctl32: Remove unneeded casts (1 of 3)
by Andrew Talbot Dec. 31, 2007

Dec. 31, 2007

Please do not commit this patch. It relies on UINT (= unsigned int) and DWORD (= unsigned long int) both being 32 bits wide. Thanks, -- Andy.

2 1

Re: [PATCH] ddraw: Return a nullpointer as lpSurface in Lock() if the rect is invalid.
by Stefan Dösinger Dec. 31, 2007

Dec. 31, 2007

Am Mittwoch, 26. Dezember 2007 22:35:16 schrieb Günther Brammer: > + memset(&locked_desc, 1, sizeof(locked_desc)); > + locked_desc.dwSize = sizeof(locked_desc); > + > hr = IDirectDrawSurface_Lock(surface, rect, &locked_desc, > DDLOCK_WAIT, NULL); ok(hr == DDERR_INVALIDPARAMS, "Lock returned 0x%08x for > rect [%d, %d]->[%d, %d]" ", expected DDERR_INVALIDPARAMS (0x%08x)\n", hr, > rect->left, rect->top, rect->right, rect->bottom, DDERR_INVALIDPARAMS); + > ok(!memcmp(&locked_desc, &surface_desc, sizeof(locked_desc)), > "IDirectDrawSurface_Lock did not set lpSurface in the surface desc\n"); } I think you should just compare lpSurface instead of memcmp'ing the entire structure. Also, in the patch that changes surface.c, it seems that the patch changes a few whitespaces(unless I missed something).

2 1

Packaging - Bundling Mono and Gecko
by Scott Ritchie Dec. 31, 2007

Dec. 31, 2007

If I wanted a Wine package to include mono and gecko, what would the best way to do this be? I know we support having gecko installed somewhere on the filesystem so it doesn't have to be downloaded (where?), but would I need to make any further changes other than adding it to the package at the appropriate path? How about mono? Would it be possible to have mono installed at wineprefixcreate time? Thanks, Scott Ritchie

2 1

Re: crypt32: Remove unneeded casts
by Andrew Talbot Dec. 31, 2007

Dec. 31, 2007

Please do not commit this patch. Thanks, -- Andy.

1 0

Re: comctl32: Remove unneeded casts (2 of 3)
by Andrew Talbot Dec. 31, 2007

Dec. 31, 2007

Please do not commit this patch. Thanks, -- Andy.

1 0

Re: dlls/wined3d/basetexture.c
by Stefan Dösinger Dec. 31, 2007

Dec. 31, 2007

Am Samstag, 29. Dezember 2007 09:32:43 schrieb Gerald Pfeifer: > Current snapshots of GCC 4.3 issue the following warning (with -Wextra, > for example) > > basetexture.c:437: warning: comparison of unsigned expression < 0 is > always false basetexture.c:438: warning: comparison of unsigned expression > < 0 is always false > > Indeed WINED3DTEXF_NONE is 0 and thus the comparison is a noop. I see > three ways to handle this: > > 1. the straightforward patch below, I think your patch is OK, this check just seems to be a range check for the parameters that was apparently written without taking the type of the enumeration into account.

1 0

Can't Run Day Of Defeat 1.3
by Duncan Youngson Dec. 31, 2007

Dec. 31, 2007

I've been trying to run an old steam game that I used to play quite a bit off. I'm running Ubuntu 7.10 with the very latest NVidia drivers and it crashes every time. I want to run it in opengl because it performs much better and I can use AA. The game crashes every time I go to start it, unless I add the -d3d command line (to run the game in d3d quite slower) or -software (even worse!) Here are the errors that come up when it crashes! fixme:d3d:IWineD3DImpl_FillGLCaps OpenGL implementation supports 32 vertex samplers and 32 total samplers fixme:d3d:IWineD3DImpl_FillGLCaps Expected vertex samplers + MAX_TEXTURES(=8) > combined_samplers fixme:win:EnumDisplayDevicesW ((null),0,0x34f654,0x00000000), stub! err:ntlm:SECUR32_initNTLMSP ntlm_auth was not found or is outdated. Make sure that ntlm_auth >= 3.0.25 is in your path. err:ntlm:SECUR32_initNTLMSP Usually, you can find it in the winbind package of your distribution. Please help!!

2 1

.NET apps with mono... some testing.
by Jérôme Gardou Dec. 31, 2007

Dec. 31, 2007

Many .NET/C# apps don't work with the combination wine-mono..... I've discovered that installing the arial32 from msttcorefonts solves a lot of problems, especially with graphical apps. I've tested a few apps (supreme commander patches, fastmd5 (tested here http://bugs.winehq.org/show_bug.cgi?id=10467 with native .NET...) and all of them worked quite well, although not quite beautiful. ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

4 5

Re: [PATCH] set last error on enumerating displaysettings
by Dmitry Timoshkov Dec. 31, 2007

Dec. 31, 2007

"Marcus Meissner" <marcus(a)jet.franken.de> wrote: > + num = 1; > + while (1) { > + SetLastError (0xdeadbeef); > + if (!EnumDisplaySettings(NULL, num++, &devmode)) { > + DWORD le = GetLastError(); > + ok (le == ERROR_NO_MORE_FILES, "Last error on EnumDisplaySettings was %d, expected ERROR_NO_MORE_FILES\n", le); > + break; > + } > + } Shouldn't the loop start from 'num = 0;' since the modes are 0 based? -- Dmitry.

1 0

IDirectSound and Unknown IID
by Guillaume B. Dec. 31, 2007

Dec. 31, 2007

Hi, First post here, so I don't know if it's the right place for this. I'm trying to make the sound and music work in a game with Wine. Currently, the sound doesn't work because the game does some tests to check if everything is OK before it starts the music. For now, it fails early in those tests but I've hacked some things in the latest git source and the game goes a little farther before it stops trying to make the sound and music work. But now I'm stuck so I was wondering if anyone had an idea. Here's a part of the dsound trace: trace:dsound:IDirectSound8_IDirectSound8_QueryInterface (0x2ce8de8 {2a8af120-e9de-4132-aaa5-4bdda5f325b8},0x34d634) trace:dsound:DSOUND_QueryInterface8 (0x2fdc1e0 {2a8af120-e9de-4132-aaa5-4bdda5f325b8},0x34d634) warn:dsound:DSOUND_QueryInterface8 Unknown IID {2a8af120-e9de-4132-aaa5-4bdda5f325b8} So the problem is that the interace {2a8af120-e9de-4132-aaa5-4bdda5f325b8} is not supported by the current Wine implementation. I've searched around but I couldn't find anything about this IID. If I knew what interface it was, maybe I could implement a stub and it might make the sound work. So does anyone has an idea? Thanks, Guillaume B.

1 0

Re: [2/6] wined3d: free palette handle when destroying IWineD3DPaletteImpl
by Stefan Dösinger Dec. 31, 2007

Dec. 31, 2007

Am Montag, 31. Dezember 2007 03:03:35 schrieb Alexander Dorofeyev: > Together with 3/6 patch this is needed to fix bad memory and palette handle > leaks in Aliens vs Predator 1 game (which does CreatePalette and Setpalette > every frame), and thus fix the eventual crash because of this leaks > (http://bugs.winehq.org/show_bug.cgi?id=3003) > --- > dlls/wined3d/palette.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) This patch, as well as patch 3, 4 and 6 look good to me.

1 0

Re: [1/6] wined3d: add rhw=1.0 optimization to position_float4
by Stefan Dösinger Dec. 30, 2007

Dec. 30, 2007

Am Montag, 31. Dezember 2007 03:02:07 schrieb Alexander Dorofeyev: > Hi. I found out that versions around ~0.9.50 had rhw==1.0f check here for > optimization, before that special case was lost in rewrite. Unfortunately > when I restored special case for zero/near zero rhw I was comparing to much > older version which had no rhw==1.0f optimization. But I guess it makes > sense to restore that too. I am not sure how much this check gains. We're saving divisions at the cost of a conditional. Wether it gains anything or not depends on the application(how many vertices with rhw = 1.0 does it send in). I think in the past it was used for avoiding the divisions in the D3DDECLTYPE_FLOAT3 case. It was a bad thing that I removed this optimization in my patch, but I don't think we should add it back, unless benchmarks clearly say that it helps.

1 0

Re: [1/3] WineD3D: Fix a problem in BltOverride
by Maxime Bellengé Dec. 30, 2007

Dec. 30, 2007

Hi Stephan, Since this patch has been commited to git I have a big regression in the game Syberia. Everything is black. Nothing is displayed expected some menu items. In order to determine that this is this patch which is the problem I did a "git bisect". Maxime

2 1

appdb new version submission form has awkward radio buttons
by Dan Kegel Dec. 30, 2007

Dec. 30, 2007

When submitting a new version, clicking the radio button next to "Request being a maintainer for this version, allowing you to edit it later" or "Monitor changes to this version, also after it has been accepted" can't be undone. There should be a way to get back to the state of no button clicked. Perhaps those should be checkboxes instead.

2 1

Re: [1/3] WineD3D: Fix a problem in BltOverride
by Alexander Dorofeyev Dec. 30, 2007

Dec. 30, 2007

Hi. I think it may be the same regression I also saw in another app. At least it seems to be in that place too. Can you check if this patch helps? Maxime Bellengé wrote: > Hi Stephan, > > Since this patch has been commited to git I have a big regression in the > game Syberia. Everything is black. Nothing is displayed expected some > menu items. > > In order to determine that this is this patch which is the problem I did > a "git bisect". > > Maxime

2 3

Re: What happened to the videos from WineConf?
by Remco Dec. 30, 2007

Dec. 30, 2007

"H. Verbeet" <hverbeet(a)gmail.com> wrote: > > The videos have been processed and encoded, but we ran into problems > > getting them on youtube. I've found the right person to talk to > > about this, so hopefully they'll get the videos online in the next > > couple weeks. > > FWIW, personally I don't care much for youtube. Just having an .ogg we > can download somewhere would be enough for me. Maybe the full-res Theora videos can be published as torrents on a strictly legal tracker like legittorrents.info? Alternatively, WineHQ.org could host a tracker. This can be useful for bandwidth-reduction on all downloads from WineHQ.org. Remco ____________________________________________________________________________________ Looking for last minute shopping deals? Find them fast with Yahoo! Search. http://tools.search.yahoo.com/newsearch/category.php?category=shopping

1 0

splitting out on_winver_change() and friends
by Robert Millan Dec. 29, 2007

Dec. 29, 2007

Hi I'm writing a small application to automate the process of setting Windows version for executables that are known to require a specific one. I'd like it to use the knowledge about defining Windows versions contained in winecfg/appdefaults.c instead of duplicating/forking code from it. Would it be ok to move on_winver_change() and some of its friends like win_versions[] and set_reg_key() to libwine.so.1 for this purpose ? -- Robert Millan <GPLv2> I know my rights; I want my phone call! <DRM> What use is a phone call, if you are unable to speak? (as seen on /.)

4 13

RtlpWaitForCriticalSection
by Luis A. Montes Dec. 29, 2007

Dec. 29, 2007

I got a game (Need for speed III) that has been reported to work by others. On my computer, though, the game hangs at different places about 50% of the time. I compiled Wine 0.9.51 from source on a Slackware 12.0 dual core Athlon, and although I'm sure most people this days buy at least that kind of computer, maybe that was not true when the reports came out. What I'm thinking is that this is a race condition brought out because of the two cores. I think that because if I run inside gdb I catch a SIGTERM going to a thread that then exits. Another thread then prints the: err:ntdll:RtlpWaitForCriticalSection section ... wait timed out in thread ..., blocked by <dead_thread>, retrying (60 sec) I see three ways to fix this problem: - When a thread dies, release the locks it has. Of course this wouldn't be compatible with windows, but perhaps a command line option could activate that code. In any case I could try something like that for this game in particular. I'm looking for some pointers on where should I start looking. - Looking into why the thread is getting a SIGTERM in the first place. Perhaps there is a way to delay the signal from being sent in a reasonable way? Who would be sending it? - Run the game in a single core (setting the affinity?) It just occur to me that I should be able to set the affinity on a bash shell and then start wine from there. I'll try that.

1 0

icmp states I need to be running wine as root
by EA Durbin Dec. 29, 2007

Dec. 29, 2007

I tried to update the Ocean application as outlined in bug 8332 and got a message from the console stating I needed to be running as root for ICMP to work. I thought wine was not to be run as root, is this not correct? int sid=socket(AF_INET,SOCK_RAW,IPPROTO_ICMP); if (sid < 0) { MESSAGE("WARNING: Trying to use ICMP (network ping) will fail unless running as root\n"); SetLastError(ERROR_ACCESS_DENIED); return INVALID_HANDLE_VALUE; } _________________________________________________________________ Peek-a-boo FREE Tricks & Treats for You! http://www.reallivemoms.com?ocid=TXT_TAGHM&loc=us

5 8

COM/DCOM of WINE
by Fong, Man To Dec. 29, 2007

Dec. 29, 2007

> Dear Sir / Madam, > > We are developing a software which is running on Linux platform. The > software will retrieve the information from TETRA Connectivity Server > (TCS) which is running on Window 2003 server. The communication > protocol, pre-defined by TCS manufacturing, is DCOM. Since the > communication protocol is not opened by the manufacturer. We must > install the API provided by the manufacturer on our workstation > running on Linux. Does WINE support the DCOM function? > > Best Regards, > CLP Engineering > Project Engineer > MT Fong Disclaimer: This e-mail is intended for the addressee(s) only. It is privileged and may also be confidential. Any copying, modification, retransmission or other use of this e-mail or the information contained therein is prohibited. If you are not the addressee(s) or have received this e-mail in error, please contact the sender and delete this email from your computer systems. Internet communications cannot be guaranteed to be timely, secure, error-free or virus-free. The sender will not accept any responsibility for any errors or omissions contained in this e-mail. Website: http://www.clpgroup.com

4 3

Re: bug 9986
by Juan Lang Dec. 29, 2007

Dec. 29, 2007

Hi Tom, > Exchanged interpretation of XON and XOFF. It might help if you wrote the same explanation about their meanings being reversed in your email that you did in the patch: Alexandre's not likely to go check up on bugzilla. --Juan

5 6

err:ntdll:RtlpWaitForCriticalSection blocked
by Stefani Seibold Dec. 29, 2007

Dec. 29, 2007

Hi, i still try since more than two years to bring up the old windows 95 game "pitfall: the mayan adventure". The games runs well without sound, but if i try to enable the sound a small sound chuck will be played and the games freeze with the message: err:ntdll:RtlpWaitForCriticalSection section 0x20017c90 "?" wait timed out in thread 0009, blocked by 000f, retrying (60 sec) err:ntdll:RtlpWaitForCriticalSection section 0x20017c90 "?" wait timed out in thread 000e, blocked by 000f, retrying (60 sec) All Wine Versions since the last two years have the same effect, included the newest 0.9.52. Any idea? Thanx for helping me... Stefani

1 0

Re: user32: Remove unneeded casts.
by Andrew Talbot Dec. 29, 2007

Dec. 29, 2007

Michael Stefaniuc wrote: > I just stumbled upon those while researching a potential problem for > which Smatch issued a warning. > [...] > @@ -1324,7 +1324,7 @@ HDDEDATA WINAPI DdeAddData(HDDEDATA hData, LPBYTE > pSrc, DWORD cb, DWORD cbOff) > if (new_sz > old_sz) > { > DdeUnaccessData(hData); > - hData = GlobalReAlloc((HGLOBAL)hData, new_sz + > sizeof(DDE_DATAHANDLE_HEAD), > + hData = GlobalReAlloc(hData, new_sz + sizeof(DDE_DATAHANDLE_HEAD), [...] Hi, In general, I have left the casts in where one PVOID-type handle was cast as another, e.g. HMODULE as HANDLE: I wasn't sure if strict typing might (one day) be an issue. AFAIK, my only transgressions were when I removed the casts from the return values of some {Local|Global}Alloc() and family functions, where they, strictly speaking, return a handle, not a literal PVOID, so arguably should be cast. For example: PSID pSid = (PSID)LocalAlloc(0, cBytes); Since LocalAlloc() returns a HLOCAL - which just happens to be a PVOID - one might argue that the cast should remain. As another example of type-equivalence versus -distinction, DWORD and ULONG are both defined as unsigned long, but I have currently left them as distinct types, too. I would be glad for feedback on how type-strict we should be, please. Thanks, -- Andy.

2 1

re: Uninitialized static consts
by Dan Kegel Dec. 28, 2007

Dec. 28, 2007

Samuel wrote: > I discovered a static constant wasn't initialized in RedrawWindow when I > was using Valgrind. I wonder if this is a problem or not, because it has > been there since 2005 and it doesn't give any compiler warnings. static vars are located in the bss section and are initialized to zero by the runtime loader, iirc. Can you give more details about the error you found with Valgrind? - Dan

2 1

Uninitialized static consts
by Samuel Lidén Borell Dec. 28, 2007

Dec. 28, 2007

Hi, I discovered a static constant wasn't initialized in RedrawWindow when I was using Valgrind. I wonder if this is a problem or not, because it has been there since 2005 and it doesn't give any compiler warnings. AFAIK constants can't be initialized later (unless they are pointers), so it seems to me that this really is a problem. I used a regex to find other occurrences of uninitialized consts, and I found a lot of them. Most of them are interfaces, but I don't know what interfaces *really* are, so I don't know about these. But types like structs and unions should be initialized, right? Here's the command I used: grep -E 'static const [^*=;]+;' `find -iname '*.c'` Please CC me any replies because I'm not subscribing to the list. Regards, Samuel Lidén Borell

2 1