December 2007 - Wine-Devel - list.winehq.org

Re: msi: fix memory leaks (found by Smatch).
by James Hawkins Dec. 9, 2007

Dec. 9, 2007

On Dec 9, 2007 4:44 AM, Lionel_Debroux <lionel_debroux(a)yahoo.fr> wrote: > "msi_build_insertsql_data" and "MSI_DatabaseImport" in > dlls/msi/database.c get flagged by Michael Stefaniuc's unfree-wine.pl > script. > > It looks there are more leaks than unfree-wine.pl reports, due to > constructs of the form > ptr = msi_realloc(ptr, size); > Fixed those as well. > > 2007-12-09 Lionel Debroux <lionel_debroux(a)yahoo.fr> > * dlls/msi/database.c: > msi: fix memory leaks (found by Smatch). > - columns = msi_realloc(columns, sql_size * sizeof(WCHAR)); - if (!columns) + temp_columns = msi_realloc(columns, sql_size * sizeof(WCHAR)); + if (!temp_columns) + { + HeapFree( GetProcessHeap(), 0, columns); return NULL; + } lstrcatW(columns, expanded); This is wrong. There's no guarantee that realloc returns the same position in memory. -- James Hawkins

1 0

Re: [PATCH 3/6] COMDLG32: printdlg: check hook pointer (resend 3)
by Dmitry Timoshkov Dec. 9, 2007

Dec. 9, 2007

"Vitaly Lipatov" <lav(a)etersoft.ru> wrote: > --- dlls/commdlg/printdlg.c 11 Jan 2006 11:37:03 -0000 1.100 > +++ dlls/comdlg32/printdlg.c 24 Feb 2006 17:47:53 -0000 The way you've generated this patch looks pretty strange. > /* Call user paint hook if enable */ > if (pda->dlga->Flags & PSD_ENABLEPAGEPAINTHOOK) > - if (pda->dlga->lpfnPagePaintHook(hwndDlg, uMsg, wParam, lParam)) > + if (pda->dlga->lpfnPagePaintHook && pda->dlga->lpfnPagePaintHook(hwndDlg, uMsg, wParam, lParam)) You have to add the checks existing in PageSetupDlgA to PageSetupDlgW instead. Also, in order to increase the probability of your patches to be included should either point to existing bug that each of your patches fix, or/and add a test case which doesn't pass without your patch and does with it. -- Dmitry.

2 2

speeding up regression testing by disabling building of tests?
by Dan Kegel Dec. 9, 2007

Dec. 9, 2007

Lots of the time in regression searches is spent compiling tests, but when you're only going to run the app that's breaking, that's not too useful. How does one disable compilation of conformance tests? I have this funny feeling Lei or Mikolaj did this recently, but I couldn't track it down.

2 2

Read Application Memory
by Kai Lauterbach Dec. 9, 2007

Dec. 9, 2007

Hi, at the moment I'm writing a little Linux based program to read some variables from a Windows application. But my problem is, that i can't access to the virtual memory of the Win App running under wine. I don't know how to do this. c/c++ isn't the problem but the right way to do it. I've already read the wineserver's main.c and fd.c but I think that it's not a good way to put a code into, which give's me the chance to read something. I need sth to connect, like /dev/mem or a network port. My second idea was the wine debugger. Is it possible to get access the application memory at runtime from this? I mean, without stopping the application? I hope you can help me and I've described my problem as clear as possible ;) Greetings, Kai -- Kai Lauterbach <klaute(a)web.de>

1 0

Re: Alexander Nicolaysen Sørnes : comdlg32: PageSetupDlgA: Read margins from correct edit boxes.
by Vitaly Lipatov Dec. 9, 2007

Dec. 9, 2007

Hello, I already posted the same patch to wine-patches one month ago: http://www.winehq.org/pipermail/wine-patches/2007-November/046156.html Why my patch was ignored? I am in some black list? В сообщении от 8 декабря 2007 Alexandre Julliard написал(a): > Module: wine > Branch: master > Commit: 51086b5513a436f51460d006f4fa7156e9d58a92 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=51086b5513a436f51460d006f >4fa7156e9d58a92 > > Author: Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> > Date: Sat Dec 8 13:53:32 2007 +0100 > > comdlg32: PageSetupDlgA: Read margins from correct edit boxes. > > --- > > dlls/comdlg32/printdlg.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/comdlg32/printdlg.c b/dlls/comdlg32/printdlg.c > index e04e145..5baa90e 100644 > --- a/dlls/comdlg32/printdlg.c > +++ b/dlls/comdlg32/printdlg.c > @@ -2890,10 +2890,10 @@ PRINTDLG_PS_WMCommandA( > GETVAL(id, pda->curdlg.rtMargin.left); > break; > case edt5: > - GETVAL(id, pda->curdlg.rtMargin.right); > + GETVAL(id, pda->curdlg.rtMargin.top); > break; > case edt6: > - GETVAL(id, pda->curdlg.rtMargin.top); > + GETVAL(id, pda->curdlg.rtMargin.right); > break; > case edt7: > GETVAL(id, pda->curdlg.rtMargin.bottom); -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 2

Saturday's(!) valgrind results
by Dan Kegel Dec. 9, 2007

Dec. 9, 2007

For the first time I can recall, Alexandre committed lots of changes on a Saturday, so I did a valgrind run. http://kegel.com/wine/valgrind/logs-2007-12-08-summary.txt shows the highlights; basically, lots more warnings like + Syscall param writev(vector[1]) points to uninitialised byte(s) For example, the one at the top of http://kegel.com/wine/valgrind/logs-2007-12-08/vg-user32_edit-diff.txt + Syscall param writev(vector[1]) points to uninitialised byte(s) + at (within /lib/ld-2.5.so) + by writev (in /lib/tls/i686/cmov/libc-2.5.so) + by wine_server_call (server.c:244) The only change in the server was http://source.winehq.org/git/wine.git/?a=commitdiff;h=edd3f264d95c0c6bed9c1… so I guess the new errors reflect additional error completion events being sent, and that kind of event just happens to contain some uninitialized bytes. So this is probably in Alexandre's court, and my guess is he'll consider this a false positive. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: Valgrind support for our unit tests
by Robert Shearman Dec. 8, 2007

Dec. 8, 2007

Dan Kegel wrote: > +{ > + todo_suppress_exception_addr4 > + Memcheck:Addr4 > + fun:__wine_call_from_32_regs > + obj:/home/dank/wine-git/dlls/ntdll/ntdll.dll.so > + obj:/home/dank/wine-git/dlls/ntdll/ntdll.dll.so > + fun:raise_exception I'm not sure this will work for other people unless they log on as dank :-) However, I don't think maintaining the valgrind suppressions file in tree is viable since most of the warnings come from system libraries which means that it is very dependent on user's distribution. It might be best to set up an external git tree for this, which would allow for people to submit patches for any bogus warnings in the runs that you publish on your website. -- Rob Shearman

4 4

File a bug report?
by Gilles May Dec. 8, 2007

Dec. 8, 2007

Hi everybody. After updating WINE to from 0.9.49 to 0.9.50 I noticed major slowdown in Company of Heroes, to the point that I get like 1 Frame every 2 seconds. Wine spams the console with: fixme:d3d_shader:IWineD3DVertexShaderImpl_CompileShader Vertexshader 0x4d20b78 recompiled more than 50 times Trying to find out the cause for the slowdown I did my first attempt at using git bisect and I could trace the slowdown to this patch: 959212304dfaf0e7459374593b20b74fe22a0b57 is first bad commit commit 959212304dfaf0e7459374593b20b74fe22a0b57 Author: Stefan Dösinger <stefan(a)codeweavers.com> Date: Tue Nov 20 21:14:10 2007 +0100 wined3d: Track vertex declaration changes on vertex shaders. If an attribute has type D3DDECLTYPE_D3DCOLOR, the red and blue channels are swizzled in the shader. Since the attribute is stored in the vertex declaration and not the vertex shader, it can change by setting a new vertex declaration. If this happens, we have to recompile the shader with the swizzling of that specific attribute turned on or off. :040000 040000 327661a4d0f8a02bdc18380084589c891b64af9c e35a2bcbf9514e4f261d8b7a93dcb24c0b3c89a7 M dlls Now without that patch there is slight texture corruption in the game, with the patch it's much much less but it renders the game unplayable. The reason I didn't file a bug report is that I am not sure if it is really a bug or not since obviously the patch fixes in-game texture corruption. Regards, Gilles

3 2

Re: ddraw: fix wrong initialization order in IDirect3DDevice vtable
by Stefan Dösinger Dec. 8, 2007

Dec. 8, 2007

Am Sonntag, 9. Dezember 2007 03:00:28 schrieb Alexander Dorofeyev: > Helps bug#7584 (http://bugs.winehq.org/show_bug.cgi?id=7584) > --- > dlls/ddraw/device.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Looks correct to me, good catch!

1 0

Re: dlls/comctl32/listview.c warning elimination
by Alexandre Julliard Dec. 8, 2007

Dec. 8, 2007

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Not a patch I am particularily proud of, but the best way I found to get > rid of > > listview.c:5043: warning: 'strW' might be used uninitialized in this function > > issued by GCC, and apart from the added cast it actually is simpler than > the original. It was done the way it is precisely to avoid the non-const cast, which triggers a warning too. -- Alexandre Julliard julliard(a)winehq.org

2 2

Mono 1.2.5.1 on Wine
by Kornél Pál Dec. 8, 2007

Dec. 8, 2007

Hi, I tried to run Mono 1.2.5.1 on Wine but it dies with the "Weird VirtualQuery result" error message. Are there any know bugs of Wine or Mono that prevent it from running? I would like to make Mono run on Wine and I am willing to contribute patches to Wine and Mono as well to achieve that. Kornél

2 1

re: Wine Problem
by Dan Kegel Dec. 8, 2007

Dec. 8, 2007

Pedro Ferreira wrote: > I installed a software that talks with the informix client 2.7.0 > everything was running fine, the instalation went with minor problems. > Until now > >when i stated a connection to the informix server wine simply stops Which version of Wine? Have you tested the connection using the ilogin.exe demo that comes with the informix SDK? If you don't have it, you can download a free trial of the 2.80 SDK, that's probably close enough. The procedure for testing the connection is described here: http://www.synametrics.com/ifmxODBC.htm BTW the right mailing list for this is probably wine-users, not wine-devel. - Dan

1 0

Re: [Wine] TortoiseCVS- Unimplemented functions in ntdll.dll causes program to terminate.
by James McKenzie Dec. 7, 2007

Dec. 7, 2007

Jean-Claude Gervais wrote: > Thank you, Austin! > > I installed Samba to obtain winbind and ntlm_auth, and it did change > the outcome a bit: > > Tortoise still checks out the first file and pops up an error dialog, > so there is no apparent difference, but the session output from Wine HAS > changed, it has gotten quieter: > > wine TortoiseAct.exe CVSCheckOut -f "C:\windows\Temp\TCV1.tmp" -h > 0x300b4 > fixme:actctx:parse_depend_manifests Could not find dependent assembly > L"Microsoft.Windows.Common-Controls" > fixme:richedit:RichEditWndProc_common WM_STYLECHANGING: stub > fixme:richedit:RichEditWndProc_common WM_STYLECHANGED: stub > wine: Call from 0x7bc38828 to unimplemented function > ntdll.dll.NtQueryEaFile, aborting > wine: Call from 0x7bc38828 to unimplemented function > ntdll.dll.NtSetEaFile, aborting > err:mmio:MMIO_ParseExtA No . in szFileName: "TCVS_Error" > > Sadly, it appears that it really is the two unimplemented functions > (NtQueryEaFile and NtSetEaFile) causing the problem. > > Thank you kindly for your help in any case and if you have any other > strategies or ideas to workaround this, I would gladly try them. > > Thanks again. > J > As others have stated here, please file a bug against ntdll.dll and name your program as the source of the problem. It may be possible to get your program to run with a minimum of effort, but this may take considerable effort. The more reports of problems with these functions, the more effort should be brought in to build and implement these functions. It also appears that you are using a program that is dependent on other functions that are implemented elsewhere in the Windows environment. James

2 1

Re: Monthcal lost focus fix
by Alexandre Julliard Dec. 7, 2007

Dec. 7, 2007

Gregor Brunmar <gregor.brunmar(a)home.se> writes: > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c > index 8a92d42..e826612 100644 > --- a/dlls/comctl32/monthcal.c > +++ b/dlls/comctl32/monthcal.c > @@ -1719,11 +1719,12 @@ MONTHCAL_Paint(MONTHCAL_INFO *infoPtr, WPARAM wParam) > > > static LRESULT > -MONTHCAL_KillFocus(const MONTHCAL_INFO *infoPtr) > +MONTHCAL_KillFocus(const MONTHCAL_INFO *infoPtr, HWND hFocusWnd) > { > TRACE("\n"); > > - InvalidateRect(infoPtr->hwndSelf, NULL, TRUE); > + if (infoPtr->hwndNotify != hFocusWnd) > + ShowWindow(infoPtr->hwndSelf, SW_HIDE); Is there a reason for removing the InvalidateRect completely? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/5] winealsa: Make widGetPos more accurate
by Alexandre Julliard Dec. 7, 2007

Dec. 7, 2007

Maarten Lankhorst <maarten(a)codeweavers.com> writes: > --- > dlls/winealsa.drv/wavein.c | 6 +++++- This doesn't work for me: ../../../tools/runtest -q -P wine -M winmm.dll -T ../../.. -p winmm_test.exe.so capture.c && touch capture.ok capture.c:73: Test failed: waveInGetPosition(0): returned 2730 bytes, should be 0 capture.c:84: Test failed: waveInGetPosition(0): returned 2730 samples, should be 0 capture.c:96: Test failed: waveInGetPosition(0): returned 341 ms, should be 0 capture.c:108: Test failed: waveInGetPosition(0): SMPTE test failed capture.c:119: Test failed: waveInGetPosition(0): MIDI test failed capture.c:130: Test failed: waveInGetPosition(0): TICKS test failed [lots more of the same] -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: msi 2: Reimplement MsiGetProductCode
by Alexandre Julliard Dec. 7, 2007

Dec. 7, 2007

"James Hawkins" <truiken(a)gmail.com> writes: > Changelog: > * Reimplement MsiGetProductCode. The test fails occasionally with something like: ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so msi.c && touch msi.ok msi.c:1426: Test failed: Expected {E853FAEA-A4E2-11DC-A19E-001A923592CB}, got {E853FAAE-A4E2-11DC-A19E-001A923592CB} msi.c:1530: Test failed: Expected {E853FAEA-A4E2-11DC-A19E-001A923592CB}, got {E853FAAE-A4E2-11DC-A19E-001A923592CB} make: *** [msi.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Missing 32bit support libraries on x86_64 Debian
by Ben Hodgetts Dec. 7, 2007

Dec. 7, 2007

I just submitted this to the Debian tracker system, thought it may be useful to echo here in-case anyone else is using x86_64 Debian as it seems since Julliard put in a patch just before .42 to check more completely for dependencies it now shows that Debian (64) actually lacks certain deps for Wine. Ben H. --------------------------------------- Package: wine Version: All Severity: important Wine, when compiled from source (upstream source) shows that Debian is missing certain dependencies which cause loss of functionality in Wine on x86_64. These are libpng, libcups, libcapi20, libhal and openssl. This means that 32bit support packages need to be made for Debian for Wine to work properly (just like there is currently a lib32asound(-dev), etc to give ALSA support). -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (500, 'testing') Architecture: amd64 (x86_64) Kernel: Linux 2.6.22-3-amd64 (SMP w/2 CPU cores) Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages wine depends on: ii debconf [debconf-2.0] 1.5.17 Debian configuration management sy pn libwine <none> (no description available) ii xbase-clients 1:7.3+7 miscellaneous X clients - metapack Versions of packages wine recommends: ii msttcorefonts 2.4 Installer for Microsoft TrueType c pn wine-utils <none> (no description available)

1 0

Re: Assorted spelling fixes.
by H. Verbeet Dec. 7, 2007

Dec. 7, 2007

On 07/12/2007, Francois Gouget <fgouget(a)free.fr> wrote: > --- a/dlls/wined3d/glsl_shader.c > +++ b/dlls/wined3d/glsl_shader.c > - * out. The nvidia driver only does that if the parameter is inout instead of out, hence the > - * inout. > + * out. The nvidia driver only does that if the parameter is in/out instead of out, hence the > + * in/out. I don't think that change is correct. GLSL function parameters can have qualifiers to specify how the parameter is used. The possible qualifiers are "in", "out" and "inout", where specifying no qualifier is the same as specifying "in". I suppose the first "inout" could be replaced with "in/out" without changing the meaning of the sentence too much, but the second one is a reference to the actual qualifier.

2 1

Re: (corrected) Add 18 pixel strike with japanese fonts to system.sdf Widths corrected and double checked for both strikes
by Huw Davies Dec. 7, 2007

Dec. 7, 2007

Aric Stewart wrote: > --- > fonts/system.sfd | 1587 > +++++++++++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 1341 insertions(+), 246 deletions(-) You seem to have changed a couple of glyphs in the 16 pixel strike too. Was that on purpose (and if so shouldn't it be a separate patch?). Huw.

2 2

Nifty new valgrind report script. New error in oleaut32. Call for volunteer(s).
by Dan Kegel Dec. 7, 2007

Dec. 7, 2007

I finally got tired of doing "history | grep diff" etc, and partially automated the daily valgrind run; the resulting script is at http://kegel.com/wine/valgrind/valgrind-daily.sh The results are now in directories named like http://kegel.com/wine/valgrind/logs-2007-12-06/ A summary of the new problems compared to last run are in files named like http://kegel.com/wine/valgrind/logs-2007-12-06-summary.txt And next to each individual result, there is a diff with the previous run, e.g. http://kegel.com/wine/valgrind/logs-2007-12-06/vg-oleaut32_varformat.txt http://kegel.com/wine/valgrind/logs-2007-12-06/vg-oleaut32_varformat-diff.t… To look at what changed since yesterday, start by looking at the day's summary file. In it, there's one line per test, followed by the changes in that test's results, if any. Lines that start with + indicate new problems (boo); lines that start with - indicate old problems that are now gone (yay!) Nearby lines that are identical except for one starting with + and one starting with - indicate a problem that moved, so ignore those. For example, in today's summary, http://kegel.com/wine/valgrind/logs-2007-12-06-summary.txt the first test with changes is in hlink: diff -u logs-2007-12-05/vg-hlink_hlink.txt logs-2007-12-06/vg-hlink_hlink.txt - Syscall param write(buf) points to uninitialised byte(s) That means the hlink test has one fewer error. Yay! The next test with changes is diff -u logs-2007-12-05/vg-ole32_moniker.txt logs-2007-12-06/vg-ole32_moniker.txt + Syscall param write(buf) points to uninitialised byte(s) - Syscall param write(buf) points to uninitialised byte(s) - Conditional jump or move depends on uninitialised value(s) The 'Syscall' error just moved, so that's not really a change. The 'Conditional' error went away, yay! The next test with changes is diff -u logs-2007-12-05/vg-oleaut32_varformat.txt logs-2007-12-06/vg-oleaut32_varformat.txt + Invalid read of size 2 That's a + with no matching -, so it's a new error, boo! Let's see if it's a real error, or just crap in the log. The first thing to check is the diff of that test's results with the last run: http://kegel.com/wine/valgrind/logs-2007-12-06/vg-oleaut32_varformat-diff.t… It shows a fairly convincing new error: + Invalid read of size 2 + at VarFormatFromTokens (varformat.c:1888) + by VarFormat (varformat.c:2096) + by func_varformat (varformat.c:317) + by run_test (test.h:387) + by main (test.h:436) + Address 0x7F00AB01 is 15 bytes before a block of size 8 alloc'd + at RtlAllocateHeap (heap.c:1225) + by SysAllocStringByteLen (oleaut.c:357) + by VariantCopy (variant.c:722) + by VariantChangeTypeEx (variant.c:992) + by VarFormatFromTokens (varformat.c:1884) + by VarFormat (varformat.c:2096) + by func_varformat (varformat.c:317) + by run_test (test.h:387) + by main (test.h:436) Now, sometimes tests are flaky, and errors just happen to come and go, so this doesn't mean for sure it's a new error. But looking back a few days, I don't see it before. So it's probably a new error. Let's see, who's been submitting changes to oleaut32 lately? Only change in git since the last run seems to be http://www.winehq.org/pipermail/wine-cvs/2007-December/038491.html It's not clear how that patch could have caused the error offhand, but it's worth emailing the author and asking him to check, so I've cc'd him. And that's the only new error in the whole run. It's worth watching for new errors and alerting the authors, since the change is fresh in their mind, they'll probably be able to fix it quickly. Egg in the face is a dish best served warm. I'll try to keep running this script daily, but it'd be nice if somebody else took over (and possibly even increased the automation; I still have to do git pull, run the script, and upload by hand.) It doesn't help that valgrind only works well on some machines, but hey, what's life without challenges. - Dan

1 0

Re: gdi32: Update fontsubstitutes and add ms shell dlg 2
by Huw Davies Dec. 7, 2007

Dec. 7, 2007

On Fri, Dec 07, 2007 at 01:20:59PM +0100, Maarten Lankhorst wrote: > --- > dlls/gdi32/freetype.c | 34 ++++++++++++++++++---------------- > 1 files changed, 18 insertions(+), 16 deletions(-) > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index e9fb663..1542e29 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -1884,83 +1884,83 @@ static const struct nls_update_font_list > const char *oem, *fixed, *system; > const char *courier, *serif, *small, *sserif; > /* these are for font substitute */ > - const char *shelldlg, *tmsrmn; > + const char *shelldlg, *shelldlg2, *tmsrmn; > } nls_update_font_list[] = > { > /* Latin 1 (United States) */ > { 1252, 437, "vgaoem.fon", "vgafix.fon", "vgasys.fon", > "coure.fon", "serife.fon", "smalle.fon", "sserife.fon", > - "Tahoma","Times New Roman", > + "MS Sans Serif", "Tahoma","Times New Roman", > }, I'm fairly sure we don't want to map MS Shell Dlg to MS Sans Serif. Which version of Windows has this mapping? Some map it to Microsoft Sans Serif, but that's a completely different font... Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: [2/2] msxml3: Register Missing Components
by Huw Davies Dec. 7, 2007

Dec. 7, 2007

On Fri, Dec 07, 2007 at 02:07:44PM +1100, Alistair Leslie-Hughes wrote: > diff --git a/dlls/msxml3/regsvr.c b/dlls/msxml3/regsvr.c > index 9a0d938..1beed5b 100644 > --- a/dlls/msxml3/regsvr.c > +++ b/dlls/msxml3/regsvr.c > @@ -465,13 +465,13 @@ static LONG register_key_defvalueA( > */ > static struct regsvr_coclass const coclass_list[] = { > { &CLSID_DOMDocument, > - "XML DOM Document", > - NULL, > - "msxml3.dll", > - "Both", > - "Microsoft.XMLDOM", > - "1.0" > - }, > + "XML DOM Document", > + NULL, > + "msxml3.dll", > + "Both", > + "Microsoft.XMLDOM", > + "1.0" > + }, There are a lot of white-space changes in this patch. Please re-submit without them. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0

d3d fill caps oddity
by Christoph Frick Dec. 7, 2007

Dec. 7, 2007

Hi wined3d devs, i get this message on my notebook (Quadro 570m): fixme:d3d:IWineD3DImpl_FillGLCaps OpenGL implementation supports 32 vertex samplers and 32 total samplers fixme:d3d:IWineD3DImpl_FillGLCaps Expected vertex samplers + MAX_TEXTURES(=8) > combined_samplers does anyone want some traces or other infos? or is this a problem most likely going away with the next nvidia driver update? -- cu

2 1

Re: [1/2] msxml3: Implement IPersistStream
by Robert Shearman Dec. 7, 2007

Dec. 7, 2007

Alistair Leslie-Hughes wrote: > + hr = CreateStreamOnHGlobal(NULL, TRUE, &This->stream); > + if (FAILED(hr)) > + return hr You need to free This->stream somewhere. -- Rob Shearman

1 0

Re: [5/5] WineD3D: Use the disabled opengl extension string
by H. Verbeet Dec. 7, 2007

Dec. 7, 2007

The clearest way to do this would probably be to simply do the disabling in a separate loop over the disabled extensions string, similarly to how we detect the extensions.

2 1