December 2007 - Wine-Devel - list.winehq.org

Re: includes: Update oleacc with new constants and iaccessible interface
by Alexandre Julliard Dec. 13, 2007

Dec. 13, 2007

Maarten Lankhorst <maarten(a)codeweavers.com> writes: > +cpp_quote("#define ROLE_SYSTEM_ALERT 8") > +cpp_quote("#define ROLE_SYSTEM_ANIMATION 54") > +cpp_quote("#define ROLE_SYSTEM_APPLICATION 14") > +cpp_quote("#define ROLE_SYSTEM_BORDER 19") > +cpp_quote("#define ROLE_SYSTEM_BUTTONDROPDOWN 56") > +cpp_quote("#define ROLE_SYSTEM_BUTTONDROPDOWNGRID 58") > +cpp_quote("#define ROLE_SYSTEM_BUTTONMENU 57") > +cpp_quote("#define ROLE_SYSTEM_CARET 7") Entries should be sorted by value, not by name. > +typedef enum tagSELFLAG > +{ > + SELFLAG_NONE = 0, > + SELFLAG_TAKEFOCUS = 1, > + SELFLAG_TAKESELECTION = 2, > + SELFLAG_EXTENDSELECTION = 4, > + SELFLAG_ADDSELECTION = 8, > + SELFLAG_REMOVESELECTION = 16 > +} SELFLAG; These should be defines, not enums. > + HRESULT get_accParent([out, retval]IDispatch** ppdispParent); > + HRESULT get_accChildCount([out, retval] long* pcountChildren); > + HRESULT get_accChild([in] VARIANT varChildID, [out, retval]IDispatch **ppdispChild); These (and the others) should be propget functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/4] WineX11: Ignore the alpha if all pixels are 0x00
by Juan Lang Dec. 13, 2007

Dec. 13, 2007

Hi Stefan, a few minor nits: + * one pixel has alpha != 0x00, and the mask ignored as described in the Do you mean, "the mask is ignored...", or "the AND mask is ignored..." ? + * written at 8 / 16 bpp times do not knwow about the 32 bit alpha, so s/knwow/know/ + for (y = 0; y < ymax; ++y) + { + xor_ptr = xor_bits + (y * xor_width_bytes); + for (x = 0; x < xmax; ++x) + { + if(xor_ptr[3] != 0x00) { + alpha_zero = FALSE; + break; For the first for loop, you probably want something like (for y = 0; alpha_zero && y < ymax... Also, the whitespace around the if is a bit funny. --Juan

2 1

Re: shdocvw #3: Set default home and search page.
by Aric Stewart Dec. 13, 2007

Dec. 13, 2007

I see that the native shdocvw sets neither the Start page nor the Search page when registered. This patch forces the users home page to initially be www.winehq.com which can be confusing to IE users who are expecting the normal default of msn.com While amusing I do not think this is correct. -aric Jacek Caban wrote: > --- > dlls/hlink/tests/hlink.c | 4 ---- > dlls/shdocvw/shdocvw.inf | 12 +++++++++--- > 2 files changed, 9 insertions(+), 7 deletions(-) > > > ------------------------------------------------------------------------ > >

3 8

Re: Patch for process title on FreeBSD
by Stefan Dösinger Dec. 12, 2007

Dec. 12, 2007

Am Mittwoch, 12. Dezember 2007 18:50:39 schrieb Kris Moore: > Hey all! > > One of our devs noticed that on FreeBSD we don't get the process name > set properly, so in "ps" we get a lot of wine-pthread garbage. Here's a > small patch to fix this in dlls/kernel32/process.c > > I tried to make this as small & simple as possible, please let me know > what you think! I think using argv[1] is not the best way, as some wine parameter might be added in the future, or someone might use something like binfmt_misc on Linux to launch the app. In that case the .exe name is propably argv[0], but I am not sure.

2 1

Re: [5/5] gdi: Test bitmap depths
by Dmitry Timoshkov Dec. 12, 2007

Dec. 12, 2007

Stefan Doesinger <stefan(a)codeweavers.com> wrote: > This obsolettes the 15 bpp bitmap and 16 bpp screen compatibility since > 15 bpp bitmaps do not exist. 15 bpp bitmaps do exist. According to the Feng Yuan's book that depends on the driver and hardware. -- Dmitry.

3 4

Re: Undocumented behaviour in ReqQueryValueEx when 'count' and 'type' point to the same address
by Juan Lang Dec. 12, 2007

Dec. 12, 2007

Hi Sam, - DWORD total_size; + DWORD total_size, datalen; (snip) + if (count) datalen = *count; (snip) - if (len > *count) status = STATUS_BUFFER_OVERFLOW; + if (len > datalen) status = STATUS_BUFFER_OVERFLOW; I mentioned when I reviewed the patch that datalen might be uninitialized. You're right that it isn't, since it's set when count is not NULL, and read when data is not NULL. The function fails earlier if data is not NULL and count is NULL, so again, you're right: it isn't uninitialized when it's read. Nevertheless, it took a pretty in-depth read to check that, and the patch introduces an unneeded warning. You can avoid it simply, so please do. --Juan

1 0

Valgrind results Dec 11: new quartz/filtergraph crash (oh, Lei...)
by Dan Kegel Dec. 12, 2007

Dec. 12, 2007

New results at http://kegel.com/wine/valgrind/logs-2007-12-11-summary.txt The changes from yesterday are probably noise except: The tests crashed and valgrind hung while running the quartz/filtergraph test; see http://kegel.com/wine/valgrind/logs-2007-12-11/vg-quartz_filtergraph-diff.t… +Unhandled exception: page fault on read access to 0xffffffff in 32-bit code (0x045e1290). +Backtrace: +=>1 0x045e1290 func_filtergraph+0x110() [/home/dank/wine-git/dlls/quartz/tests/filtergraph.c:161] in quartz_test (0x7f22fe58) + 2 0x045e20e8 run_test+0x128(name=0x7f0003f7) [/home/dank/wine-git/dlls/quartz/tests/../../../include/wine/test.h:389] in quartz_test (0x7f22fea8) + 3 0x045e277d main+0x14d(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/dank/wine-git/dlls/quartz/tests/../../../include/wine/test.h:437] in quartz_test (0x7f22fed8) + 4 0x045e284b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/dank/wine-git/dlls/winecrt0/exe_entry.c:36] in quartz_test (0x7f22ff08) + 5 0x045198be start_process+0xee(arg=0x0) [/home/dank/wine-git/dlls/kernel32/process.c:839] in kernel32 (0x7f22ffe8) + 6 0x0402c9e7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) +0x045e1290 func_filtergraph+0x110 [/home/dank/wine-git/dlls/quartz/tests/filtergraph.c:161] in quartz_test: movl 0x0(%eax),%edx +161 hr = IFilterGraph2_Release(pF); Lei, could you have a look? You were just in here... - Dan

4 3

Re: #2 usp10: Do glyph translation for truetype fonts only.
by Alexandre Julliard Dec. 12, 2007

Dec. 12, 2007

Hans Leidekker <hans(a)it.vu.nl> writes: > Changelog > Do glyph translation for truetype fonts only. This fails here: ../../../tools/runtest -q -P wine -M usp10.dll -T ../../.. -p usp10_test.exe.so usp10.c && touch usp10.ok usp10.c:217: Test failed: Translation to place when told not to. WCHAR 0 - 0054 != 0037 make[2]: *** [usp10.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

hlsl2glsl
by luis.busquets＠ilidium.com Dec. 12, 2007

Dec. 12, 2007

hlsl2glsl is the good solution for implementing shaders on directX 10. Nevertheless, the hlsl compilation to tokens has to be done for d3d9. On the other hand, if we implement d3dx9_xx, it is likely that the application will be using the compile D3DX9CompileShader to get the tokens. Currently it works and we can use the libraries d3dx9_xx and get good results but the following tranfosmations: 1. HLSL is compiled to tokens 2. Tokens are transformed to GLSL. I think that a good addition if the d3dx9_xx libraries are going to be implemented is to put a resource in wined3d that would let know which source HLSL code the tokens are meant to be and add the capability to instead of transform tokens to GLSL, to let wine know which is the HLSL source code the tokens came from. Then, there is the possibility to let wine do if it is available a HLSL2GLSL transfomation directly from the HLSL to GLSL. 1. HLSL is compiled to tokens and the result structure has a pointer to the HLSL source code. 2. If activated the "use HLSL2GLSL for directX9 Shaders when available" and the HLSL source code is available then 2.1. use HLSL2GLSL to transform the HLSL source code 2.2. Compile GLSL. 3. If not 2. then Tokens are transformed to GLSL. The aim would not be to gain compilation time but to be more loyal to the source HLSL. The final executable instead of making exactly what the ASM is meant to do, it would make exactly what the HLSL is meant to do and probably would be more optimized for the particular system. HLSL --> Tokens --> GLSL --> Executable that performs the actions of the tokens HLSL --> GLSL --> Executable that performs the actions of the HLSL. Furthermo, taking into consideration the need of HLSL2GLSL for DirectX 10, the hlsl2glsl will have to be set anyway. Therefore, the code needs are not so big but just leaving the door open. What do you all think and in particular David?

4 6

wine proccess list
by Gonzalo Martinez - Sanjuan Sanchez Dec. 12, 2007

Dec. 12, 2007

Hello to all. I have something in mind that I would like to ask to Wine developers. Is it possible using a hack/trick or a hidden option to change the name of wine in the proccess lists? I mean, Is it possible to list 'wine' proccess as, for example 'iexplorer' when I use Internet Explorer under Wine? Thanks a lot for your work, hope my question find the answer here.

9 10