February 2007 - Wine-Devel - list.winehq.org

Re: [00/16] CMD.exe patches
by Stefan Dösinger Feb. 20, 2007

Feb. 20, 2007

Am Dienstag 20 Februar 2007 01:32 schrieb Ann & Jason Edmeades: > After being away from active development in wine for a while I wanted to > start somewhere easy, and picked some bugs from the bug database in the > wcmd (cmd.exe) shell. > > I think I got carried away, but the following patches fix some reported > bugs and lots of other issues I found while doing some playing within the > shell. > > All feedback welcome, although I think I need to lean to use git a bit > better! Did patches 1-5 get lost?

1 0

Re: [10/10] WineD3D: With FVFs only one stream is used
by H. Verbeet Feb. 20, 2007

Feb. 20, 2007

Eventually, the FVF path should be removed from wined3d completely. We should convert the FVF in d3d8 to a vertex declaration, just like in d3d9.

2 2

Re: Comctl32 Status Bar Test
by Felix Nawothnig Feb. 20, 2007

Feb. 20, 2007

Alex Arazi wrote: > - ok(rc.top == 2, "Expected 2, got %d\n", rc.top); > - ok(rc.bottom == 21, "Expected 21, got %d\n", rc.bottom); > - ok(rc.left == 0, "Expected 0, got %d\n", rc.left); > - ok(rc.right == 50, "Expected 50, got %d\n", rc.right); I didn't really look at your new tests but the second of those tests you removed failed ("got 1" IIRC) on Windows (XP) because we don't create a parent window (and because the 21 is wrong. Should be 22 IIRC) - native comctl32 sometimes does some strange stuff when a control doesn't have one - so the test should create it. Felix

2 1

Re: [PATCH 3/3] ntdll: fix up instruction pointer in context insideraise_exception
by Dmitry Timoshkov Feb. 20, 2007

Feb. 20, 2007

"Peter Oberndorfer" <kumbayo84(a)arcor.de> wrote: > I'm not fully sure if the fixup also happens for other architectures > (i guess not) > so this patch is more a RFC > @@ -336,6 +336,10 @@ static NTSTATUS raise_exception( EXCEPTION_RECORD *rec, CONTEXT *context, BOOL f > if (status == DBG_CONTINUE || status == DBG_EXCEPTION_HANDLED) > return STATUS_SUCCESS; > > + /* fix up instruction pointer in context for EXCEPTION_BREAKPOINT */ > + if (rec->ExceptionCode == EXCEPTION_BREAKPOINT) > + GET_IP(context) = (DWORD_PTR)GET_IP(context) - 1; Gary Nebbett's book "Windows Nt/2000 Native API Reference" in the section C "Exceptions and Debugging" provides a pseudocode for KiDispatchException (page 439, Example C.1), and it does exactly the same thing as the patch above. *But* it does it as a very first thing after getting the context and before sending the debugger event. -- Dmitry.

2 2

AppDB e-mail notifications.
by Vitaliy Margolen Feb. 20, 2007

Feb. 20, 2007

Can some one fix e-mail notifications sent err. NOT sent from appdb? I have not received a single notification from the apps I am a super maintainer for! Except my own messages! On a side not, thanks to whomever that was who edited steam's howto and erased all the formatting! And they haven't even added themselves to the "laste changed by" entry. Vitaliy

1 0

Re: [8/10] WineD3D: Move the scissor rectangle to the state table,Stefan Dösinger
by Vitaliy Margolen Feb. 20, 2007

Feb. 20, 2007

Stefan Dösinger wrote: > + if(memcmp(&This->updateStateBlock->scissorRect, pRect, sizeof(*pRect)) == 0) { > + TRACE("App is setting the old scissor rectangle over, nothing to do\n"); > + return WINED3D_OK; > + } > memcpy(&This->updateStateBlock->scissorRect, pRect, sizeof(*pRect)); You should use EqualRect() and CopyRect() instead of memcmp and memcpy for RECTs. Vitaliy

1 0

Re: [start][start] Output with console encoding
by Vitaliy Margolen Feb. 20, 2007

Feb. 20, 2007

Anatoly Lyutin wrote: > Vitaliy Margolen wrote: >>> Changelog: >>> Fix output console to output with console encoding. >>> static void output(const char *message) >> >> This is not correct. This function and everything else, using it should >> be rewritten as unicode, not ansi. Also you should use >> HeapAlloc/HeapFree. >> > This program works with 8-bits strings and rewritten all "start" to > unicode is precocious because wineconsole now not yet support unicode in > curses mode (I`m working on it) :) > All you need to do is to convert output() function and all callers into WCHAR. Then you can do whatever magic you need inside of output(). Then you can properly load resources and deal with them properly until the step you need to display them. Vitaliy

1 0

re: XCOPY support
by Dan Kegel Feb. 20, 2007

Feb. 20, 2007

Jason, >Hi, Looking at the cmd.exe bugs in the database, one is caused by a lack of >XCOPY support. I've been wishing for this for other reasons lately. Glad you're looking at it! >Does anyone have anything like this in their tree, or should >I try to knock something up? I'm not aware of anything like it in the wine tree. (It's tempting to borrow code from freedos, but they're GPL... still, you could peek at e.g. http://www.ibiblio.org/pub/micro/pc-stuff/freedos/files/dos/xcopy/rxcopy/ and maybe ask the author to relicense if you like it.) >I also assume it needs to be a separate program, not part of cmd.exe, to >mimic how windows does it? Yes. BTW, it would be nice if you could include a conformace test of some sort. Maybe a batch file that reports problems by using echo FAIL ...reason... ? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: generic.ppd does not appear in the build dir - cannot print
by Michael [Plouj] Ploujnikov Feb. 20, 2007

Feb. 20, 2007

I have just finished confirming that this problem was indeed caused by some mess up in Gentoo's 32bit filesystem layout (as we discussed on IRC). A solution has been posted: http://wiki.winehq.org/WineOn64bit I am now able to print in Wine using CUPS, not Wine's generic.ppd, again. Thanks for the input. -- Libre Software: http://www.gnu.org/philosophy/free-sw.html

1 0

XCOPY support
by Ann & Jason Edmeades Feb. 20, 2007

Feb. 20, 2007

Hi, Looking at the cmd.exe bugs in the database, one is caused by a lack of XCOPY support. Does anyone have anything like this in their tree, or should I try to knock something up? I also assume it needs to be a separate program, not part of cmd.exe, to mimic how windows does it? Jason

1 0

Re: [2/2] quartz: Return proper error codes from GraphBuilder_RenderFile
by Mirek Feb. 20, 2007

Feb. 20, 2007

Hi, this patch caused regression in TES IV: Oblivion, now it can't run, here is output: fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb41-f175-11d1-a392-00e0291f3959} not found fixme:devenum:DEVENUM_ICreateDevEnum_CreateClassEnumerator Category {cc7bfb46-f175-11d1-a392-00e0291f3959} not found wine: Unhandled page fault on read access to 0xffffffea at address 0x7bfd278f (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0xffffffea in 32-bit code (0x7bfd278f). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7bfd278f ESP:0034f098 EBP:0034f1d0 EFLAGS:00010282( - 00 - RIS1) EAX:00000001 EBX:7bffec00 ECX:0034f198 EDX:ffffffea ESI:80004005 EDI:00000001 Stack dump: 0x0034f098: 115cc680 00000001 0034f198 0034f19c 0x0034f0a8: 00000000 00000001 00000001 0034f150 0x0034f0b8: 00000000 00000000 00000000 00000000 0x0034f0c8: 00000000 00000000 00000000 00000000 0x0034f0d8: 0034f108 7efa09be 7bff527c 0034f19c 0x0034f0e8: 0034f198 0034f1ac 0034f1a8 00000010 Backtrace: =>1 0x7bfd278f GraphBuilder_RenderFile+0x66f(iface=0x115cb968, lpcwstrFile=0x34f3f0, lpcwstrPlayList=0x0) [/usr/src/wine/dlls/q uartz/filtergraph.c:1094] in quartz (0x0034f1d0) 2 0x0069302b in oblivion (+0x29302b) (0x00000008) 3 0x00000000 (0x00000000) 0x7bfd278f GraphBuilder_RenderFile+0x66f [/usr/src/wine/dlls/quartz/filtergraph.c:1094] in quartz: movl 0x0(%edx),%eax 1094 IBaseFilter_Release(psplitter); Modules: Module Address Debug info Name (109 modules) PE 400000-b59000 Export oblivion PE b60000-daf000 Deferred d3dx9_27 PE 18000000-18068000 Deferred binkw32 PE 70000000-700b2000 Deferred dinput8 ELF 7b2de000-7b2f2000 Deferred avicap32<elf> \-PE 7b2e0000-7b2f2000 \ avicap32 ELF 7b2f2000-7b38b000 Deferred oleaut32<elf> \-PE 7b300000-7b38b000 \ oleaut32 ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7bf81000-7bfa8000 Deferred msvfw32<elf> \-PE 7bf90000-7bfa8000 \ msvfw32 ELF 7bfa8000-7c000000 Dwarf quartz<elf> \-PE 7bfb0000-7c000000 \ quartz ELF 7c4b4000-7c4bf000 Deferred libgcc_s.so.1 ELF 7c5a4000-7c634000 Deferred libglu.so.1 ELF 7c634000-7c653000 Deferred devenum<elf> \-PE 7c640000-7c653000 \ devenum ELF 7c653000-7c70d000 Deferred wined3d<elf> \-PE 7c660000-7c70d000 \ wined3d ELF 7c70d000-7c737000 Deferred d3d9<elf> \-PE 7c710000-7c737000 \ d3d9 ELF 7c857000-7c86b000 Deferred winejoystick<elf> \-PE 7c860000-7c86b000 \ winejoystick ELF 7c86b000-7c882000 Deferred cfgmgr32<elf> \-PE 7c870000-7c882000 \ cfgmgr32 ELF 7c882000-7c8de000 Deferred setupapi<elf> \-PE 7c890000-7c8de000 \ setupapi ELF 7c8de000-7c8f2000 Deferred hid<elf> \-PE 7c8e0000-7c8f2000 \ hid ELF 7c9ed000-7caae000 Deferred libasound.so.2 ELF 7caae000-7cad9000 Deferred winealsa<elf> \-PE 7cac0000-7cad9000 \ winealsa ELF 7cad9000-7cb0b000 Deferred uxtheme<elf> \-PE 7cae0000-7cb0b000 \ uxtheme ELF 7cd9e000-7cdb3000 Deferred midimap<elf> \-PE 7cda0000-7cdb3000 \ midimap ELF 7cdb3000-7cdb8000 Deferred libxfixes.so.3 ELF 7cdbd000-7cdd5000 Deferred msacm32<elf> \-PE 7cdc0000-7cdd5000 \ msacm32 ELF 7cdd7000-7cdda000 Deferred libxinerama.so.1 ELF 7cddd000-7cdf9000 Deferred imm32<elf> \-PE 7cde0000-7cdf9000 \ imm32 ELF 7d7a3000-7d7a5000 Deferred libnvidia-tls.so.1 ELF 7d7a5000-7e116000 Deferred libglcore.so.1 ELF 7e116000-7e1aa000 Deferred libgl.so.1 ELF 7e1aa000-7e1af000 Deferred libxdmcp.so.6 ELF 7e1af000-7e1b2000 Deferred libxau.so.6 ELF 7e1b2000-7e29e000 Deferred libx11.so.6 ELF 7e29e000-7e2ac000 Deferred libxext.so.6 ELF 7e2ac000-7e2b1000 Deferred libxxf86vm.so.1 ELF 7e2b1000-7e2c9000 Deferred libice.so.6 ELF 7e2c9000-7e2d2000 Deferred libsm.so.6 ELF 7e2d3000-7e2dc000 Deferred libxcursor.so.1 ELF 7e2dc000-7e2df000 Deferred libxrandr.so.2 ELF 7e2df000-7e2e7000 Deferred libxrender.so.1 ELF 7e2f1000-7e37f000 Deferred winex11<elf> \-PE 7e300000-7e37f000 \ winex11 ELF 7e3fb000-7e41b000 Deferred libexpat.so.1 ELF 7e41b000-7e446000 Deferred libfontconfig.so.1 ELF 7e446000-7e45a000 Deferred libz.so.1 ELF 7e45a000-7e4c4000 Deferred libfreetype.so.6 ELF 7e4e3000-7e50f000 Deferred ws2_32<elf> \-PE 7e4f0000-7e50f000 \ ws2_32 ELF 7e50f000-7e529000 Deferred wsock32<elf> \-PE 7e520000-7e529000 \ wsock32 ELF 7e529000-7e58d000 Deferred msvcrt<elf> \-PE 7e540000-7e58d000 \ msvcrt ELF 7e58d000-7e5a1000 Deferred lz32<elf> \-PE 7e590000-7e5a1000 \ lz32 ELF 7e5a1000-7e5f9000 Deferred shlwapi<elf> \-PE 7e5b0000-7e5f9000 \ shlwapi ELF 7e5f9000-7e6ee000 Deferred shell32<elf> \-PE 7e610000-7e6ee000 \ shell32 ELF 7e6ee000-7e701000 Deferred libresolv.so.2 ELF 7e707000-7e720000 Deferred version<elf> \-PE 7e710000-7e720000 \ version ELF 7e720000-7e73e000 Deferred iphlpapi<elf> \-PE 7e730000-7e73e000 \ iphlpapi ELF 7e73e000-7e793000 Deferred rpcrt4<elf> \-PE 7e750000-7e793000 \ rpcrt4 ELF 7e793000-7e82c000 Deferred ole32<elf> \-PE 7e7a0000-7e82c000 \ ole32 ELF 7e82c000-7e875000 Deferred dsound<elf> \-PE 7e830000-7e875000 \ dsound ELF 7e875000-7e903000 Deferred winmm<elf> \-PE 7e880000-7e903000 \ winmm ELF 7e903000-7e949000 Deferred advapi32<elf> \-PE 7e910000-7e949000 \ advapi32 ELF 7e949000-7e9dc000 Deferred gdi32<elf> \-PE 7e960000-7e9dc000 \ gdi32 ELF 7e9dc000-7eb16000 Deferred user32<elf> \-PE 7ea00000-7eb16000 \ user32 ELF 7eb16000-7ebd6000 Deferred comctl32<elf> \-PE 7eb20000-7ebd6000 \ comctl32 ELF 7edd6000-7eefc000 Deferred kernel32<elf> \-PE 7edf0000-7eefc000 \ kernel32 ELF 7eefc000-7ef07000 Deferred libnss_files.so.2 ELF 7ef07000-7ef11000 Deferred libnss_nis.so.2 ELF 7ef11000-7ef27000 Deferred libnsl.so.1 ELF 7ef27000-7ef4c000 Deferred libm.so.6 ELF 7ef6b000-7f000000 Deferred ntdll<elf> \-PE 7ef80000-7f000000 \ ntdll ELF b7cb6000-b7cba000 Deferred libdl.so.2 ELF b7cba000-b7dec000 Deferred libc.so.6 ELF b7dec000-b7dfe000 Deferred libpthread.so.0 ELF b7e11000-b7e15000 Deferred iso8859-2.so ELF b7e15000-b7e1e000 Deferred libnss_compat.so.2 ELF b7e1e000-b7f2f000 Deferred libwine.so.1 ELF b7f31000-b7f48000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000a 0000000c 0 0000000b 0 00000008 (D) G:\usr\games\oblivion\Oblivion.exe 00000010 2 0000000f -1 0000000e -1 0000000d 15 00000009 0 <== Mirek Chris Robinson napsal(a): > > ------------------------------------------------------------------------ > > From 427782e216badd48afc917c85682bc5a1954b24b Mon Sep 17 00:00:00 2001 > From: Chris Robinson <chris.kcat(a)gmail.com> > Date: Wed, 14 Feb 2007 11:27:26 -0800 > Subject: [PATCH] quartz: Return proper error codes from GraphBuilder_RenderFile > > --- > dlls/quartz/filtergraph.c | 82 +++++++++++++++++++++++---------------------- > 1 files changed, 42 insertions(+), 40 deletions(-) > > diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c > index 8b38a3b..a3db8dd 100644 > --- a/dlls/quartz/filtergraph.c > +++ b/dlls/quartz/filtergraph.c > @@ -961,9 +961,9 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > IEnumPins* penumpins; > ULONG pin; > HRESULT hr; > - IEnumMoniker* pEnumMoniker; > + IEnumMoniker* pEnumMoniker = NULL; > GUID tab[2]; > - IPin** ppins; > + IPin** ppins = NULL; > ULONG nb; > IMoniker* pMoniker; > IFileSourceFilter* pfile = NULL; > @@ -972,6 +972,9 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > > TRACE("(%p/%p)->(%s, %s)\n", This, iface, debugstr_w(lpcwstrFile), debugstr_w(lpcwstrPlayList)); > > + if (lpcwstrPlayList != NULL) > + return E_INVALIDARG; > + > hr = IGraphBuilder_AddSourceFilter(iface, lpcwstrFile, string, &preader); > > /* Retrieve file media type */ > @@ -982,6 +985,13 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > IFileSourceFilter_Release(pfile); > } > > + if (SUCCEEDED(hr)) > + hr = IBaseFilter_EnumPins(preader, &penumpins); > + if (SUCCEEDED(hr)) { > + hr = IEnumPins_Next(penumpins, 1, &ppinreader, &pin); > + IEnumPins_Release(penumpins); > + } > + > if (SUCCEEDED(hr)) { > tab[0] = mt.majortype; > tab[1] = mt.subtype; > @@ -990,6 +1000,8 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > > if (FAILED(hr)) > { > + if (pEnumMoniker) > + IEnumMoniker_Release(pEnumMoniker); > if (preader) { > IGraphBuilder_RemoveFilter(iface, preader); > IBaseFilter_Release(preader); > @@ -1019,65 +1031,49 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > hr = IGraphBuilder_AddFilter(iface, psplitter, NULL); > if (FAILED(hr)) { > ERR("Unable add filter (%x)\n", hr); > - return hr; > + IBaseFilter_Release(psplitter); > + continue; > } > > /* Connect file source and splitter filters together */ > /* Make the splitter analyze incoming data */ > - hr = IBaseFilter_EnumPins(preader, &penumpins); > - if (FAILED(hr)) { > - ERR("Enumpins (%x)\n", hr); > - return hr; > - } > - hr = IEnumPins_Next(penumpins, 1, &ppinreader, &pin); > - if (FAILED(hr)) { > - ERR("Next (%x)\n", hr); > - return hr; > - } > - if (pin == 0) { > - ERR("No Pin\n"); > - return E_FAIL; > - } > - IEnumPins_Release(penumpins); > > hr = IBaseFilter_EnumPins(psplitter, &penumpins); > - if (FAILED(hr)) { > - ERR("Splitter Enumpins (%x)\n", hr); > - return hr; > - } > - hr = IEnumPins_Next(penumpins, 1, &ppinsplitter, &pin); > - if (FAILED(hr)) { > - ERR("Next (%x)\n", hr); > - return hr; > - } > - if (pin == 0) { > - ERR("No Pin\n"); > - return E_FAIL; > + if (SUCCEEDED(hr)) { > + hr = IEnumPins_Next(penumpins, 1, &ppinsplitter, &pin); > + IEnumPins_Release(penumpins); > } > - IEnumPins_Release(penumpins); > > - hr = IPin_Connect(ppinreader, ppinsplitter, NULL); > + if (SUCCEEDED(hr)) > + hr = IPin_Connect(ppinreader, ppinsplitter, NULL); > if (SUCCEEDED(hr)) { > /* Make sure there's some output pins in the filter */ > hr = GetInternalConnections(psplitter, ppinsplitter, &ppins, &nb); > - if(SUCCEEDED(hr)) { > + if (SUCCEEDED(hr)) { > if(nb > 0) { > TRACE("Successfully connected to filter\n"); > break; > } > CoTaskMemFree(ppins); > ppins = NULL; > - TRACE("No output pins found in filter\n"); > } > - IBaseFilter_Release(ppinsplitter); > - ppinsplitter = NULL; > + > + TRACE("No output pins found in filter\n"); > + hr = VFW_E_CANNOT_RENDER; > } > + > + IPin_Release(ppinsplitter); > + ppinsplitter = NULL; > + IGraphBuilder_RemoveFilter(iface, psplitter); > + IBaseFilter_Release(psplitter); > + ppinsplitter = NULL; > + > TRACE("Cannot connect to filter (%x), trying next one\n", hr); > - hr = E_FAIL; > } > > /* Render all output pin of the splitter by calling IGraphBuilder_Render on each of them */ > if (SUCCEEDED(hr)) { > + int partial = 0; > int i; > TRACE("pins to consider: %d\n", nb); > for(i = 0; i < nb; i++) { > @@ -1085,13 +1081,19 @@ static HRESULT WINAPI GraphBuilder_RenderFile(IGraphBuilder *iface, > hr = IGraphBuilder_Render(iface, ppins[i]); > if (FAILED(hr)) { > ERR("Cannot render pin %p (%x)\n", ppins[i], hr); > - /* FIXME: We should clean created things properly */ > - break; > + partial = 1; > } > + IPin_Release(ppins[i]); > } > CoTaskMemFree(ppins); > + > + hr = (partial ? VFW_S_PARTIAL_RENDER : S_OK); > } > - > + > + if (psplitter) > + IBaseFilter_Release(psplitter); > + IBaseFilter_Release(preader); > + > return hr; > } > > > > ------------------------------------------------------------------------ > >

1 0

Re: [start][start][try2] Output with console encoding
by Robert Shearman Feb. 19, 2007

Feb. 19, 2007

Anatoly Lyutin wrote: > + len = MultiByteToWideChar( CP_ACP, 0, message, -1, NULL, 0 ); > + bufW = HeapAlloc( GetProcessHeap(), 0, len ); > + len is in WCHARs, not bytes so this will cause heap corruption. It really would be a lot easier to make "output" take a Unicode string instead. -- Rob Shearman

1 0

Re: [PATCH] return when not finding the name
by Eric Pouech Feb. 19, 2007

Feb. 19, 2007

Marcus Meissner a écrit : > --- > dlls/dbghelp/dwarf.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/dbghelp/dwarf.c b/dlls/dbghelp/dwarf.c > index 4f74b6a..f51a948 100644 > --- a/dlls/dbghelp/dwarf.c > +++ b/dlls/dbghelp/dwarf.c > @@ -1203,7 +1203,7 @@ static void dwarf2_parse_enumerator(dwar > > TRACE("%s, for %s\n", dwarf2_debug_ctx(ctx), dwarf2_debug_di(di)); > > - if (!dwarf2_find_attribute(ctx, di, DW_AT_name, &name)) name.u.string = NULL; > + if (!dwarf2_find_attribute(ctx, di, DW_AT_name, &name)) return; > if (!dwarf2_find_attribute(ctx, di, DW_AT_const_value, &value)) value.u.svalue = 0; > symt_add_enum_element(ctx->module, parent, name.u.string, value.u.svalue); > > Hi Marcus, can you send me the ELF file(s) which is/are causing this? A+

2 2

Re: Resend 1/4 NtCreateMailslotFile tests
by Eric Pouech Feb. 19, 2007

Feb. 19, 2007

Jeff Latimer a écrit : > Establish the framework for testing NtCreateMailslotFile. Have fixed > issues with NTSTATUS return codes etc. those tests belong to dlls/ntdll, not dlls/kernel32 also, if the test is for ntdll functions, it shouldn't use kernel32 ones... hence, NtClose should be used instead of CloseHandle A+

3 4

Re: [9/10] WineD3D: Use VBOs for index buffers
by H. Verbeet Feb. 19, 2007

Feb. 19, 2007

On 19/02/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ GLint vbo; vbo should be a GLuint.

1 0

Re: winecfg: Add check for device access to Drives tab.
by Vitaliy Margolen Feb. 19, 2007

Feb. 19, 2007

Any reasons why this patch is not applied? http://www.winehq.org/pipermail/wine-patches/2007-January/035264.html This is one of the major headaches for users trying to get programs requiring direct CD-ROM drive access to work. And it's nearly impossible to get required information from users to find if the direct access actually works or not. If there are some other ways to check this, please let me know. I'm sure everyone who tried to get something like Diablo II working will appreciate it! Vitaliy.

2 3

Re: comctl32: rebar[1/4]: rewrite the layouting code
by Alexandre Julliard Feb. 19, 2007

Feb. 19, 2007

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > From 2b42e9b97b443ced2531a445b531fddc5db2dcad Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Sat, 17 Feb 2007 19:24:25 +0100 > Subject: [PATCH] comctl32: rebar: rewrite the layouting code This crashes in make test: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so rebar.c && touch rebar.ok wine: Unhandled page fault on read access to 0xffff001a at address 0x601bb75b (thread 0024), starting debugger... WineDbg starting on pid 0023 Unhandled exception: page fault on read access to 0xffff001a in 32-bit code (0x601bb75b). err:dbghelp:elf_load_debug_info_from_map Bad CRC for module (got 1ef14dcf while expecting 31f52e76) Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:601bb75b ESP:0033e50c EBP:0033e548 EFLAGS:00010202( - 00 - -RI1) EAX:ffff001a EBX:7b8aa9a0 ECX:00000002 EDX:00000000 ESI:00000000 EDI:ffffffff Stack dump: 0x0033e50c: 7b85b545 ffff001a 00000000 606a0081 0x0033e51c: 605b4fbc 0015df30 00000006 0033e548 0x0033e52c: 6055ddc0 00000040 0000000c 00000006 0x0033e53c: 605e9244 0015e0fc 0033f560 0033e578 0x0033e54c: 6055de30 00000000 00000000 ffff001a 0x0033e55c: ffffffff 00000000 00000000 0033e578 Backtrace: =>1 0x601bb75b strlen+0xb() in libc.so.6 (0x0033e548) 2 0x6055de30 Str_SetPtrAtoW+0x60(lppDest=0x15e10c, lpSrc=0xffff001a) [/home/julliard/wine/wine/dlls/comctl32/comctl32undoc.c:949] in comctl32 (0x0033e578) 3 0x605c06ef TOOLBAR_AddButtonsT+0x14f(hwnd=0x4002c, wParam=0x6, lParam=0x33f53c, fUnicode=0x0) [/home/julliard/wine/wine/dlls/comctl32/toolbar.c:2880] in comctl32 (0x0033e5c8) 4 0x605c2842 ToolbarWindowProc+0x1b52(hwnd=0x4002c, uMsg=<register EDI not in topmost frame>, wParam=0x6, lParam=0x33f53c) [/home/julliard/wine/wine/dlls/comctl32/toolbar.c:6622] in comctl32 (0x0033ee58) 5 0x606bb40a WINPROC_wrapper+0x1a() in user32 (0x0033ee88) 6 0x606bbb6b call_window_proc+0x6b(hwnd=<register EDI not in topmost frame>, msg=0x414, wp=0x6, lp=0x33f53c, result=0x33f3b8, arg=0x605c0cf0) [/home/julliard/wine/wine/dlls/user32/winproc.c:452] in user32 (0x0033eec8) 7 0x606beae7 WINPROC_CallProcAtoW+0x2c7(callback=0x606bbb00, hwnd=0x4002c, msg=0x414, wParam=0x6, lParam=0x33f53c, result=0x33f3b8, arg=0x605c0cf0) [/home/julliard/wine/wine/dlls/user32/winproc.c:903] in user32 (0x0033f388) 8 0x606bf923 CallWindowProcA+0xc3(func=0xffff0014, hwnd=0x4002c, msg=<register EDI not in topmost frame>, wParam=<register ESI not in topmost frame>, lParam=0x33f53c) [/home/julliard/wine/wine/dlls/user32/winproc.c:2229] in user32 (0x0033f3c8) 9 0x60688023 call_window_proc+0xe3(hwnd=<register ESI not in topmost frame>, msg=0x414, wparam=0x6, lparam=0x33f53c, unicode=0x0, same_thread=0x1) [/home/julliard/wine/wine/dlls/user32/message.c:1547] in user32 (0x0033f438) 10 0x6068bba1 SendMessageTimeoutA+0x201(hwnd=<register ESI not in topmost frame>, msg=0x414, wparam=0x6, lparam=0x33f53c, flags=0x0, timeout=0x0, res_ptr=0x33f4e0) [/home/julliard/wine/wine/dlls/user32/message.c:2457] in user32 (0x0033f4a8) 11 0x6068bc5c SendMessageA+0x4c(hwnd=0x4002c, msg=0x414, wparam=0x6, lparam=0x33f53c) [/home/julliard/wine/wine/dlls/user32/message.c:2496] in user32 (0x0033f4e8) 12 0x60507938 build_toolbar+0x2c8(nr=0x1, hParent=<is not available>) [/home/julliard/wine/wine/dlls/comctl32/tests/rebar.c:79] in comctl32_test (0x0033f5e8) 13 0x60508011 add_band_w+0x71(hRebar=<register EDI not in topmost frame>, lpszText=<is not available>, cxMinChild=<register ESI not in topmost frame>, cx=0x28, cxIdeal=0x64) [/home/julliard/wine/wine/dlls/comctl32/tests/rebar.c:288] in comctl32_test (0x0033f778) 14 0x6050c205 func_rebar+0x4175() [/home/julliard/wine/wine/dlls/comctl32/tests/rebar.c:358] in comctl32_test (0x0033fe58) 15 0x60525f20 run_test+0x120(name=0x1103a1) [/home/julliard/wine/wine/dlls/comctl32/tests/../../../include/wine/test.h:389] in comctl32_test (0x0033fea8) 16 0x605265a1 main+0x141(argc=<register ECX not in topmost frame>, argv=<register ECX not in topmost frame>) [/home/julliard/wine/wine/dlls/comctl32/tests/../../../include/wine/test.h:437] in comctl32_test (0x0033fed8) 17 0x6052666b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [/home/julliard/wine/wine/dlls/winecrt0/exe_entry.c:36] in comctl32_test (0x0033ff08) 18 0x7b86fbeb start_process+0xeb() in kernel32 (0x0033ffe8) 19 0x6001f7a7 wine_switch_to_stack+0x17() in libwine.so.1 (0x00000000) 0x601bb75b strlen+0xb in libc.so.6: cmpb %ch,0x0(%eax) Wine-dbg> -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: 1/4 NtCreateMailslotFile tests
by Dmitry Timoshkov Feb. 19, 2007

Feb. 19, 2007

"Jeff Latimer" <lats(a)yless4u.com.au> wrote: > + rc = pNtCreateMailslotFile(&hslot, DesiredAccess, > + &attr, &IoStatusBlock, CreateOptions, MailslotQuota, MaxMessageSize, > + &TimeOut); > + ok( rc == S_OK, "Create MailslotFile failed rc = %x %u\n", rc, GetLastError()); NT APIs return STATUS_xxx error codes, S_OK is an OLE error value. > + ok( hslot != INVALID_HANDLE_VALUE, "Handle is invalid\n"); INVALID_HANDLE_VALUE is a kernel32 thing, NT APIs don't use it. Most likely you need to test returned value against 0. > + ok( CloseHandle(hslot), "CloseHandle failed\n"); To close the handle returned by an NT API you have you use an NT API as well. -- Dmitry.

3 6

Updated version of Wine-0.9.18 RPMs with ntoskrnl for SuSE 10.1
by Vitaliy Margolen Feb. 19, 2007

Feb. 19, 2007

Same as before. Just recompiled with new version. http://www.kievinfo.com/wine-0.9.18-1.2.i586.rpm http://www.kievinfo.com/wine-0.9.18-1.2.src.rpm -- Best regards, Vitaliy

3 3

Let's get rid of the FAQ and move it into the wiki
by Scott Ritchie Feb. 19, 2007

Feb. 19, 2007

Updating the FAQ is a bit of a pain, as is maintaining it. There is, after all, still a lot of ancient stuff in it. Why not just move it into the wiki and point the link on the web page there? I promise I'll watch it a bit closer. Thanks, Scott Ritchie

2 1

What does it mean if doing WINEDEBUG=+relay fixes a bug?
by Misha Koshelev Feb. 19, 2007

Feb. 19, 2007

Hi, I am trying to debug bug #7484 but am having some problems as simply doing a WINEDEBUG=+relay causes this bug to be fixed, thus making it difficult for me to track it down (WINEDEBUG=+listview or WINEDEBUG= +snoop do not have this effect of fixing it). If there is something that the fact that this bug is fixed by +relay suggests, I would love to know. Thanks a lot Misha

2 1

Re: [wineconsole][dialog] Fix inversion in work Up-down control (Option Dialog)
by Dmitry Timoshkov Feb. 19, 2007

Feb. 19, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > struct dialog_info* di; > unsigned idc; > + unsigned nMaxHistUD = 500; > > switch (msg) > { > @@ -66,6 +67,8 @@ static INT_PTR WINAPI WCUSER_OptionDlgPr > di = (struct dialog_info*)((PROPSHEETPAGEA*)lParam)->lParam; > di->hDlg = hDlg; > SetWindowLongPtr(hDlg, DWLP_USER, (LONG_PTR)di); > + > + SendMessage(GetDlgItem(hDlg,IDC_OPT_HIST_SIZE_UD), UDM_SETRANGE, (WPARAM) 0, MAKELONG (nMaxHistUD, 0)); There is no need for (WPARAM) cast. Better use MAKELPARAM to construct an lParam instead of MAKELONG. Simple MAKELPARAM(500, 0) works just fine without introducing a new variable. -- Dmitry.

1 0

Re: [start][start] Output with console encoding
by Dmitry Timoshkov Feb. 19, 2007

Feb. 19, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > @@ -33,7 +33,20 @@ > static void output(const char *message) > { > DWORD count; > - WriteFile(GetStdHandle(STD_OUTPUT_HANDLE), message, strlen(message), &count, NULL); > + WCHAR *bufW; > + char *bufC; > + int len = strlen(message); > + bufW = calloc(len+1,sizeof(WCHAR)); > + bufC = calloc(len+1,sizeof(CHAR)); Please do not use calloc/malloc calls in the Wine code, use win32 API HeapAlloc instead. > + MultiByteToWideChar( CP_ACP, 0, message, len, bufW, len ); > + WideCharToMultiByte( GetConsoleOutputCP(), 0, bufW, len, bufC, len, NULL, NULL ); > + bufC[len] = '\0'; Please refer to other parts of Wine code how to properly allocate space for this kind of a conversion. -- Dmitry.

1 0

Re: Make wineprefixcreate put wordpad.exe where XP does; fixes bug 5627
by Dan Kegel Feb. 19, 2007

Feb. 19, 2007

[reposting to right list. Maybe I should break down and subscribe to wine-devel so I can just hit 'reply'...] Detlef wrote: >The Idea sounds good, but your Patch is wrong for every >system in the World, that does not use English as locale: Oh, right. Well, at least I'm enthusiastic, if not wise :-) I guess the way to fix this right would be to create IDS_PROGRAM_FILES_ACCESSORIES analogous to IDS_PROGRAM_FILES; that would let us localize the path in shell32.dll, and setupapi.dll could handle it just like it does IDS_PROGRAM_FILES already (it translates the %16422% into the localized Program Files directory name). Then maybe get rid of the need to create the directores in wineprefixcreate by modifying create_fake_dll in setupapi/fakedll.c to create the directories if they don't exist. Lotta trouble to go through just to support broken-ish apps that need to know where wordpad is, but maybe I'll see about doing it if nobody else fixes this.

1 0

-ansi, -pedantic warnings and errors on
by Joris Huizer Feb. 19, 2007

Feb. 19, 2007

Hello, I was looking at the result of configuring with -ansi, -pedantic flags. It gives loads of warnings (not all relevant - also complaining about 'long long' not being ansi) and indicates unnamed unions, among other things. Could someone confirm my idea that unnamed unions must all be dealt with? Am hoping to fix those if I get it to compile thus far; At this point, it complains about include/wine/unicode.h which has the combination 'extern' and 'inline', which it doesn't like. Getting rid of that, with -Dinline=__inline__, helps it get a bit further Next it complains about is libs/wine/string.c, which implements several functions that are also implemented in include/wine/unicode.h. These are again the 'extern inline' functions. As most headers have 'static inline' instead of 'extern inline', with the advantage of not having to duplicate the functions. I'm hoping this is an allowed fix, it gets compiling further anyway ____________________________________________________________________________________ Finding fabulous fares is fun. Let Yahoo! FareChase search your favorite travel sites to find flight and hotel bargains. http://farechase.yahoo.com/promo-generic-14795097

3 4