February 2007 - Wine-Devel - list.winehq.org

Re: [00/16] CMD.exe patches
by Stefan Dösinger Feb. 20, 2007

Feb. 20, 2007

Am Dienstag 20 Februar 2007 01:32 schrieb Ann & Jason Edmeades: > After being away from active development in wine for a while I wanted to > start somewhere easy, and picked some bugs from the bug database in the > wcmd (cmd.exe) shell. > > I think I got carried away, but the following patches fix some reported > bugs and lots of other issues I found while doing some playing within the > shell. > > All feedback welcome, although I think I need to lean to use git a bit > better! Did patches 1-5 get lost?

1 0

Re: [10/10] WineD3D: With FVFs only one stream is used
by H. Verbeet Feb. 20, 2007

Feb. 20, 2007

Eventually, the FVF path should be removed from wined3d completely. We should convert the FVF in d3d8 to a vertex declaration, just like in d3d9.

2 2

Re: Comctl32 Status Bar Test
by Felix Nawothnig Feb. 20, 2007

Feb. 20, 2007

Alex Arazi wrote: > - ok(rc.top == 2, "Expected 2, got %d\n", rc.top); > - ok(rc.bottom == 21, "Expected 21, got %d\n", rc.bottom); > - ok(rc.left == 0, "Expected 0, got %d\n", rc.left); > - ok(rc.right == 50, "Expected 50, got %d\n", rc.right); I didn't really look at your new tests but the second of those tests you removed failed ("got 1" IIRC) on Windows (XP) because we don't create a parent window (and because the 21 is wrong. Should be 22 IIRC) - native comctl32 sometimes does some strange stuff when a control doesn't have one - so the test should create it. Felix

2 1

Re: [PATCH 3/3] ntdll: fix up instruction pointer in context insideraise_exception
by Dmitry Timoshkov Feb. 20, 2007

Feb. 20, 2007

"Peter Oberndorfer" <kumbayo84(a)arcor.de> wrote: > I'm not fully sure if the fixup also happens for other architectures > (i guess not) > so this patch is more a RFC > @@ -336,6 +336,10 @@ static NTSTATUS raise_exception( EXCEPTION_RECORD *rec, CONTEXT *context, BOOL f > if (status == DBG_CONTINUE || status == DBG_EXCEPTION_HANDLED) > return STATUS_SUCCESS; > > + /* fix up instruction pointer in context for EXCEPTION_BREAKPOINT */ > + if (rec->ExceptionCode == EXCEPTION_BREAKPOINT) > + GET_IP(context) = (DWORD_PTR)GET_IP(context) - 1; Gary Nebbett's book "Windows Nt/2000 Native API Reference" in the section C "Exceptions and Debugging" provides a pseudocode for KiDispatchException (page 439, Example C.1), and it does exactly the same thing as the patch above. *But* it does it as a very first thing after getting the context and before sending the debugger event. -- Dmitry.

2 2

AppDB e-mail notifications.
by Vitaliy Margolen Feb. 20, 2007

Feb. 20, 2007

Can some one fix e-mail notifications sent err. NOT sent from appdb? I have not received a single notification from the apps I am a super maintainer for! Except my own messages! On a side not, thanks to whomever that was who edited steam's howto and erased all the formatting! And they haven't even added themselves to the "laste changed by" entry. Vitaliy

1 0

Re: [8/10] WineD3D: Move the scissor rectangle to the state table,Stefan Dösinger
by Vitaliy Margolen Feb. 20, 2007

Feb. 20, 2007

Stefan Dösinger wrote: > + if(memcmp(&This->updateStateBlock->scissorRect, pRect, sizeof(*pRect)) == 0) { > + TRACE("App is setting the old scissor rectangle over, nothing to do\n"); > + return WINED3D_OK; > + } > memcpy(&This->updateStateBlock->scissorRect, pRect, sizeof(*pRect)); You should use EqualRect() and CopyRect() instead of memcmp and memcpy for RECTs. Vitaliy

1 0

Re: [start][start] Output with console encoding
by Vitaliy Margolen Feb. 20, 2007

Feb. 20, 2007

Anatoly Lyutin wrote: > Vitaliy Margolen wrote: >>> Changelog: >>> Fix output console to output with console encoding. >>> static void output(const char *message) >> >> This is not correct. This function and everything else, using it should >> be rewritten as unicode, not ansi. Also you should use >> HeapAlloc/HeapFree. >> > This program works with 8-bits strings and rewritten all "start" to > unicode is precocious because wineconsole now not yet support unicode in > curses mode (I`m working on it) :) > All you need to do is to convert output() function and all callers into WCHAR. Then you can do whatever magic you need inside of output(). Then you can properly load resources and deal with them properly until the step you need to display them. Vitaliy

1 0

re: XCOPY support
by Dan Kegel Feb. 20, 2007

Feb. 20, 2007

Jason, >Hi, Looking at the cmd.exe bugs in the database, one is caused by a lack of >XCOPY support. I've been wishing for this for other reasons lately. Glad you're looking at it! >Does anyone have anything like this in their tree, or should >I try to knock something up? I'm not aware of anything like it in the wine tree. (It's tempting to borrow code from freedos, but they're GPL... still, you could peek at e.g. http://www.ibiblio.org/pub/micro/pc-stuff/freedos/files/dos/xcopy/rxcopy/ and maybe ask the author to relicense if you like it.) >I also assume it needs to be a separate program, not part of cmd.exe, to >mimic how windows does it? Yes. BTW, it would be nice if you could include a conformace test of some sort. Maybe a batch file that reports problems by using echo FAIL ...reason... ? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: generic.ppd does not appear in the build dir - cannot print
by Michael [Plouj] Ploujnikov Feb. 20, 2007

Feb. 20, 2007

I have just finished confirming that this problem was indeed caused by some mess up in Gentoo's 32bit filesystem layout (as we discussed on IRC). A solution has been posted: http://wiki.winehq.org/WineOn64bit I am now able to print in Wine using CUPS, not Wine's generic.ppd, again. Thanks for the input. -- Libre Software: http://www.gnu.org/philosophy/free-sw.html

1 0

XCOPY support
by Ann & Jason Edmeades Feb. 20, 2007

Feb. 20, 2007

Hi, Looking at the cmd.exe bugs in the database, one is caused by a lack of XCOPY support. Does anyone have anything like this in their tree, or should I try to knock something up? I also assume it needs to be a separate program, not part of cmd.exe, to mimic how windows does it? Jason

1 0