February 2007 - Wine-Devel - list.winehq.org

Re: winetest: add support for http_proxy environment variable
by Detlef Riekenberg Feb. 2, 2007

Feb. 2, 2007

On So, 2007-01-14 at 15:13 +0100, Németh Márton wrote: Welcome to wine. I have some comments about your Patch: > diff -u -r wine-0.9.29.orig/ChangeLog wine-0.9.29/ChangeLog > --- wine-0.9.29.orig/ChangeLog 2007-01-09 16:42:47.000000000 +0100 > +++ wine-0.9.29/ChangeLog 2007-01-14 15:02:31.000000000 +0100 The changelog will be updated during a release with the Informations from the subject. > + > + http_proxy = getenv("http_proxy"); > + if (http_proxy) { > + /* Proxy configuration found */ > + memset(&regex, 0, sizeof(regex)); > + retval = regcomp(&regex, The Idea to support a http-proxy is good, but the Programm must run on Windows. 1. I never saw an environment-variable "http_proxy" on Windows. Most Windows-Applications use the Proxy-Data from IE (Get the settings from there) 2. "regcomp" and friends are posix, but not available on windows Thanks for helping wine. -- By by ... Detlef

1 0

Re: [PATCH] ole32: Add CoWaitForMultipleHandles to spec file do it will be visible to windows apps.
by Paul Vriens Feb. 2, 2007

Feb. 2, 2007

John Morris wrote: > I'm resubmitting the patch without the changelog entry. > > > ------------------------------------------------------------------------ > > From 4c51e49d432eb8342cadb71a3d539b2e8574849b Mon Sep 17 00:00:00 2001 > From: John Morris <mailjohnmorris(a)gmail.com> > Date: Fri, 2 Feb 2007 13:20:34 -0600 > Subject: ole32: Add CoWaitForMultipleHandles to spec file do it will be visible to windows apps. > > --- > dlls/ole32/ole32.spec | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/ole32/ole32.spec b/dlls/ole32/ole32.spec > index d775556..3ae0240 100644 > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -76,6 +76,7 @@ > @ stub CoUnloadingWOW > @ stdcall CoUnmarshalHresult(ptr ptr) > @ stdcall CoUnmarshalInterface(ptr ptr ptr) > +@ stdcall CoWaitForMultipleHandles(long long long ptr ptr) > @ stdcall CreateAntiMoniker(ptr) > @ stdcall CreateBindCtx(long ptr) > @ stdcall CreateClassMoniker(ptr ptr) > > > ------------------------------------------------------------------------ > > Hi, I thought we use: @ stub CoWaitForMultipleHandles for functions that should be exported and are not implemented at all, and use @ stdcall CoWaitForMultipleHandles(long long long ptr ptr) where we at least have something in a *.c file (although that could be a simple return): HRESULT WINAPI CoWaitForMultipleHandles(<stuff>) { FIXME("unimplemented stub!\n"); return E_FAIL; <or something alike> } Isn't the first one a stub and the second one a semi-stub, or have I mixed up things? Cheers, Paul.

2 1

Re: Added CoWaitForMultipleHandles to ole32.spec so it will be visible to W indows apps.
by Michael Stefaniuc Feb. 2, 2007

Feb. 2, 2007

Hello John, thanks for the patch. You do not need to add the entry to the ChangeLog file. That is done automaticly using the git changelog entries during the release of a new Wine version. Would you mind resubmitting the patch without that? bye michael John Morris wrote: > From 79b3a4ba86ec3ddbd4b8be7c04bb350d78c78bfa Mon Sep 17 00:00:00 2001 > From: John Morris <mailjohnmorris(a)gmail.com> > Date: Wed, 31 Jan 2007 17:38:04 -0600 > Subject: Added CoWaitForMultipleHandles to ole32.spec so it will be visible to Windows apps. > > --- > ChangeLog | 5 +++++ > dlls/ole32/ole32.spec | 1 + > 2 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/ChangeLog b/ChangeLog > index 658036c..ce545d0 100644 > --- a/ChangeLog > +++ b/ChangeLog > @@ -1,3 +1,8 @@ > +2007-01-31 John Morris <mailjohnmorris(a)gmail.com> > + > + * dlls/ole32/ole32.spec: > + ole32: Add CoWaitForMultipleHandles to spec file so it will be visible to windows apps. > + > 2007-01-24 Vitaliy Margolen <wine-patches(a)kievinfo.com> > > * server/token.c: > diff --git a/dlls/ole32/ole32.spec b/dlls/ole32/ole32.spec > index d775556..3ae0240 100644 > --- a/dlls/ole32/ole32.spec > +++ b/dlls/ole32/ole32.spec > @@ -76,6 +76,7 @@ > @ stub CoUnloadingWOW > @ stdcall CoUnmarshalHresult(ptr ptr) > @ stdcall CoUnmarshalInterface(ptr ptr ptr) > +@ stdcall CoWaitForMultipleHandles(long long long ptr ptr) > @ stdcall CreateAntiMoniker(ptr) > @ stdcall CreateBindCtx(long ptr) > @ stdcall CreateClassMoniker(ptr ptr) > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

2 1

Re: comdlg32-colordlg fix bgcolor
by Dmitry Timoshkov Feb. 2, 2007

Feb. 2, 2007

"Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > The patch corrects background color of a dialogue window " Choose color " at > copying a triangular marker, the user colors and the predetermined colors. > Earlier the background about these elements was more dark than the basic > background of a window. > + SetClassLongPtrW( hwnd, GCLP_HBRBACKGROUND, (LONG_PTR) GetSysColorBrush(COLOR_BTNFACE)); This fix is not correct, think for instance about different color themes. Probably CC_PaintTriangle needs to specify the background color of a triangle explicitly. -- Dmitry.

2 2

Re: Conformance test for bug #7286
by Dmitry Timoshkov Feb. 2, 2007

Feb. 2, 2007

"Misha Koshelev" <mk144210(a)bcm.tmc.edu> wrote: > + /* Now create the notification thread */ > + events[1] = CreateThread(NULL, 0, NotificationThread, (LPVOID)events[0], > + 0, &threadId); > + ok(events[1] != INVALID_HANDLE_VALUE, "CreateThread error: %d\n", GetLastError()); CreateThread returns NULL on error, not INVALID_HANDLE_VALUE. -- Dmitry.

3 3

Re: [PATCH 3/7] server: Implement object's security descriptor check against token.
by Robert Shearman Feb. 1, 2007

Feb. 1, 2007

Vitaliy Margolen wrote: > + res = token_access_check( token, obj->sd, *access, &priv, &priv_count, > + &mapping, access, &status ) == STATUS_SUCCESS && > + status == STATUS_SUCCESS; > + if (!res) > + { > + fprintf( stderr, "access check failed\n" ); > + set_error( STATUS_ACCESS_DENIED ); > + } We don't want anything in the wineserver that can possibly spam the console, so this should be made conditional on debug_level being non-zero. Also, is there any reason you return STATUS_ACCESS_DENIED instead of the statuses returned by token_access_check? Could you try writing a test that creates or opens an object with ACCESS_SYSTEM_SECURITY access and see if it returns STATUS_PRIVILEGE_NOT_HELD or STATUS_ACCESS_DENIED? -- Rob Shearman

2 1

Re: [PATCH 1/7] server: Get the primary group from the token.
by Robert Shearman Feb. 1, 2007

Feb. 1, 2007

Vitaliy Margolen wrote: > list_add_tail( &token->groups, &group->entry ); > + /* Use first owner capable group as an owner */ > + if (!token->primary_group && group->owner) > + token->primary_group = &group->sid; > + } > + /* we really need a primary group */ > + if (!token->primary_group && group_count) > + { > + release_object( token ); > + return NULL; > } > According to documentation from Microsoft, "the primary group only needs to be set if POSIX compatibility is required." Also, the default security descriptor does not require a group - a NULL group is fine. -- Rob Shearman

2 1

Re: [PATCH] rasapi32: RasEnumConnections now returns correct buffer size (zero) when there are zero connections available
by James Hawkins Feb. 1, 2007

Feb. 1, 2007

On 2/1/07, John Smith <xixsimplicityxix(a)gmail.com> wrote: > When RasEnumConnections completes the expected behaviour is to have the > needed buffer size stored in *lpcb. Right now wine just leaves it at > whatever size was passed. The windows 2000 behaviour (tested) for when > they're are zero connections, *lpcb is 0. > > Changelog: > RasEnumConnections the buffersize needed reported is now 0 when the number > of connections is 0 > You need to add a test to the test suite for this. -- James Hawkins

1 0

Office 2003 Installation
by Jan de Mooij Feb. 1, 2007

Feb. 1, 2007

Hi, I have tried to run the office 2003 installation, and in doing that I came across the following issues: - I think we need to undo a patch for msiexec [1]. CommandLineToArgvW does not what we want with slashes in paths followed by an " (this also happens on Windows). Therefore we need to parse the commandline arguments ourselves, what's done by reverting the patch. I can give an example of when it goes wrong if you want. - Office 2003 installation fails with this (from the log): ------------------------ Successfully launched MsiExec.... 2/1/2007 8:30:55 PM Chained install return code: 1603 Exit code was an error. Shutting down chained setup processing. Set Verbose logging for subsequent setup. ------------------------ BUT, when I add WINEDEBUG=+relay,+seh,+tid,+msi,+msiexec, it runs well and installs alright, so I think it's a timing issue. Anyone has experienced this before? What would be the best way to debug this? (I only choose to install Word, I don't know what happens when I select the other Office-applications) Thanks in advance, Jan de Mooij [1] http://source.winehq.org/git/wine.git/?a=blobdiff;f=programs/msiexec/msiexe…

1 0