February 2007 - Wine-Devel - list.winehq.org

Re: kernel32: Implement ReplaceFileA/ReplaceFileW
by Felix Nawothnig Feb. 27, 2007

Feb. 27, 2007

Erich Hoover wrote: > Real Name: > Erich Hoover > Description: > Implements the functions ReplaceFileA and ReplaceFileW in kernel32 > (Bug #7544). Also provides conformance test code to ensure proper > functionality. > Changelog: > kernel32: Implement ReplaceFileA/ReplaceFileW Your patch seems to introduce lots of race cons. It's possible these exist on Win32 too but can't we avoid them?

2 4

Re: [7/12] WineD3D: Select an onscreen context based on the thread
by Stefan Dösinger Feb. 27, 2007

Feb. 27, 2007

Am Montag 26 Februar 2007 13:49 schrieb Stefan Dösinger: Alexandre, do not patch 7, 8 and 9 yet, they are reported to cause regressions. Patch 10, 11 and 12 should apply without them too.

1 0

Re: Add localizable strings support for popup menu in selection tree control.
by James Hawkins Feb. 26, 2007

Feb. 26, 2007

On 2/26/07, Крылов Николай <krna(a)rambler.ru> wrote: > diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c > index 35a192c..3826326 100644 > --- a/dlls/msi/dialog.c > +++ b/dlls/msi/dialog.c > @@ -1755,17 +1755,41 @@ msi_seltree_popup_menu( HWND hwnd, INT x > HMENU hMenu; > INT r; > > + static const WCHAR szMenuLocal[] = > {'M','e','n','u','L','o','c','a','l',0}; > + static const WCHAR szMenuAllLocal[] = > {'M','e','n','u','A','l','l','L','o','c','a','l',0}; > + static const WCHAR szMenuAdvertise[] = > {'M','e','n','u','A','d','v','e','r','t','i','s','e',0}; > + static const WCHAR szMenuAbsent[] = > {'M','e','n','u','A','b','s','e','n','t',0}; > + /* If msi_dialog_get_uitext returns NULL - use default strings: */ > + static const WCHAR szMenuLocalDef[] = > {'I','n','s','t','a','l','l',' ','f','e','a','t','u','r','e',' ', > 'l','o','c','a','l','l','y',0}; > + static const WCHAR szMenuAllLocalDef[] = > {'I','n','s','t','a','l','l',' ','e','n','t','i','r','e',' > ','f','e','a','t','u','r','e',0}; > + static const WCHAR szMenuAdvertiseDef[] = > {'I','n','s','t','a','l','l',' ','o','n',' ','d','e','m','a','n','d',0}; > + static const WCHAR szMenuAbsentDef[] = {'D','o','n','\'','t',' > ','i','n','s','t','a','l','l',0}; > + > + LPWSTR szLocal,szAllLocal,szAdvertise,szAbsent; > + struct msi_selection_tree_info *info; > + > + info = GetPropW(hwnd, szButtonData); > + > + szLocal= msi_dialog_get_uitext( info->dialog, szMenuLocal ); > + szAllLocal= msi_dialog_get_uitext( info->dialog, szMenuAllLocal ); > + szAdvertise= msi_dialog_get_uitext( info->dialog, szMenuAdvertise > ); > + szAbsent= msi_dialog_get_uitext( info->dialog, szMenuAbsent ); > + > /* create a menu to display */ > hMenu = CreatePopupMenu(); > > - /* FIXME: load strings from resources */ > - AppendMenuA( hMenu, MF_ENABLED, INSTALLSTATE_LOCAL, "Install > feature locally"); > - AppendMenuA( hMenu, MF_GRAYED, 0x1000, "Install entire feature"); > - AppendMenuA( hMenu, MF_ENABLED, INSTALLSTATE_ADVERTISED, "Install > on demand"); > - AppendMenuA( hMenu, MF_ENABLED, INSTALLSTATE_ABSENT, "Don't > install"); > + /* Use strings from resources */ > + AppendMenuW( hMenu, MF_ENABLED, INSTALLSTATE_LOCAL, > (szLocal==NULL)?szMenuLocalDef:szLocal ); > + AppendMenuW( hMenu, MF_GRAYED, 0x1000, > (szAllLocal==NULL)?szMenuAllLocalDef:szAllLocal ); > + AppendMenuW( hMenu, MF_ENABLED, INSTALLSTATE_ADVERTISED, > (szAdvertise==NULL)?szMenuAdvertiseDef:szAdvertise ); > + AppendMenuW( hMenu, MF_ENABLED, INSTALLSTATE_ABSENT, > (szAbsent==NULL)?szMenuAbsentDef:szAbsent ); > r = TrackPopupMenu( hMenu, TPM_LEFTALIGN | TPM_TOPALIGN | > TPM_RETURNCMD, > x, y, 0, hwnd, NULL ); > DestroyMenu( hMenu ); > + if(szLocal) msi_free(szLocal); > + if(szAllLocal) msi_free(szAllLocal); > + if(szAdvertise) msi_free(szAdvertise); > + if(szAbsent) msi_free(szAbsent); > return r; > } > Don't check values for NULL before freeing them. The check is redundant, and we spent a long time removing such checks. -- James Hawkins

1 0

Wine and XP Themes
by Andrew J. Barr Feb. 26, 2007

Feb. 26, 2007

I would like to use the XP ClearLooks theme that is available to make Wine apps blend in with my GNOME desktop. However, it seems that using themes in Wine makes it rather slow. Is this a known problem, is there a workaround of some kind, a registry setting or a patch, or is it best just not to use themes with Wine right now? I am running Wine 0.9.31. According to a Google search, there seem to be scattered reports of this problem but no diagnosis or solution. Regards, Andrew Barr (cc'd replies requested)

5 4

Using InternalGetWindowText Instead of Sending WM_GETTEXT when Drawing Window Captions
by Robert Shearman Feb. 26, 2007

Feb. 26, 2007

Hi Alexandre, A patch of yours from 2.5 years ago (http://source.winehq.org/git/wine.git/?a=commitdiff;h=b72994b6d4a04352e1893…) changed the behaviour to not send WM_GETTEXT any more. My experiments on Windows show that WM_GETTEXT should be used. Can you remember what the reasoning behind the change in this patch was? -- Rob Shearman

2 3

wine or wine-preloader exit with code 2 on x86_64
by Escuder Nicolas Feb. 26, 2007

Feb. 26, 2007

Hello, I have build wine with the help of wiki WineOn64bit LDFLAGS="-L/lib32 -L/usr/lib32 -Wl,-rpath,/lib32 -Wl,-rpath,/usr/lib32" ./configure --prefix=/opt/wine --datadir=/usr/share But wine or wine-preloader always return 2 as you can see : [root(a)nico wine-0.9.31]# loader/wine-preloader [root(a)nico wine-0.9.31]# echo $? 2 [root(a)nico wine-0.9.31]# ./wine --version [root(a)nico wine-0.9.31]# echo $? 2 Anyone can help please ? See you, Escuder Nicolas

1 0

Re: [2/4 revised] msi: Expand IDL file to contain all OLE automation interfaces.
by James Hawkins Feb. 26, 2007

Feb. 26, 2007

On 2/25/07, Misha Koshelev <mk144210(a)bcm.tmc.edu> wrote: > This patch expands the IDL to contain all OLE automation interfaces that > the freely downloadable MS Windows Installer contains, and adds a > msiserver_dispids.h file that has define statements for all the dispids. > > Changelog: > > * msi: Expand IDL file to contain all OLE automation interfaces. > * Copyright (C) 2007 Mike McCormack + * Misha Koshelev You have to repeat the Copyright (C) 2007 part for your name. + [id(DISPID_INSTALLER_OPENDATABASE)] + Database* OpenDatabase( + [in] BSTR DatabasePath, + [in] VARIANT OpenMode); + [id(DISPID_INSTALLER_SUMMARYINFORMATION), propget] + SummaryInfo* SummaryInformation( + [in] BSTR PackagePath, + [in, optional, defaultvalue(0)] long UpdateCount); + [id(DISPID_INSTALLER_ENABLELOG)] + void EnableLog( + [in] BSTR LogMode, + [in] BSTR LogFile); Did you copy and paste this from OleView? This formatting is ridiculous. -- James Hawkins

2 1

Re: dlls: Move the 16-bit dll stubs to the appropriate subdirectories.
by Alexandre Julliard Feb. 26, 2007

Feb. 26, 2007

Brian Gerst <bgerst(a)didntduck.org> writes: >>From 36873109949f308cc9d34f4df9bb0af4c219262b Mon Sep 17 00:00:00 2001 > From: Brian Gerst <bgerst(a)didntduck.org> > Date: Sat, 24 Feb 2007 08:59:48 -0500 > Subject: dlls: Move the 16-bit dll stubs to the appropriate subdirectories. This won't work, they won't be found when running inside the build tree. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: rebar[2/3]: WM_SETFONT should send a RBN_HEIGHTCHANGED if necessary (with testcase)
by Alexandre Julliard Feb. 26, 2007

Feb. 26, 2007

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > This allows as to eliminate the third parameter of REBAR_Layout. > From 2edae3656159e84a0366b65e1bd1d13e3089dc97 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 19 Feb 2007 20:42:08 +0100 > Subject: [PATCH] comctl32: rebar: WM_SETFONT should send a RBN_HEIGHTCHANGED if necessary (with testcase) The tests fail here: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so rebar.c && touch rebar.ok rebar.c:696: Test failed: (int)SendMessage(hRebar, RB_GETROWCOUNT, 0, 0) expected 2 got 1 rebar.c:696: Test failed: invalid rect (notify) (-1,-1) (-1,-1) - expected (0,0) (672,20) make: *** [rebar.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

We should have a .desktop file for the Uninstaller application
by Scott Ritchie Feb. 26, 2007

Feb. 26, 2007

As it is, most people don't even know this handy uninstaller applet exists. So let's fix that. Thanks, Scott Ritchie

3 2