March 2007 - Wine-Devel - list.winehq.org

Work legalities
by Juan Lang March 7, 2007

March 7, 2007

> I'm worried about the copyright of any external work I do, so I need a > little advice. > > What do I need from my employer to clear me to work on wine? > Is something verbal ok, or should I get it in writing? In the US, if you do the Wine work outside of your workplace, on your own time and with your own equipment, it should be okay. IANAL, but see e.g.: http://www.supnik.com/reid.htm --Juan

1 0

A Survey on Defect Management Practices in Free/Open Source Software
by anugupta＠pu.ac.in March 7, 2007

March 7, 2007

Dear Wine Contributors, I seek help from designers, developers, testers,defect fixers,project managers or playing any other key role in Free/Open Source software development or maintenence in carrying out a study to identify practices and problems of defect management in various Free/Open Source Software projects. The insights gained from the study can further help us to extract publicly accessible defect data and determine impact of defect management practices on software quality. Please spend a few minutes of your precious time to fill up the Questionnaire. The most of the questions follow multiple choice formats and are quite easy to answer. To have the Online Questionnaire, please visit: http://anu.puchd.ac.in/phpESP/public/survey.php?name=FOSS_Defect_Survey (You can also copy and paste this link into your browser, and hit the 'Return' key.) I hope you will find all the questions interesting and thought-provoking. Your answers will be kept anonymous.The data thus collected will only be used for research purpose.It would be nice if you may further refer this mail to others actively engaged with Free/Open Source Software development. If you have any query or suggestions then feel free to contact. Thank You With regards, Anu Gupta Senior Lecturer Department of Computer Science and Applications, Panjab University, Chandigarh. INDIA In case of any problem in accessing/using the above mentioned link please contact: E-mail: anugupta(a)pu.ac.in anugupta98(a)gmail.com

1 0

[winealsa] Mind buffer loops when pausing
by Chris Bandy March 7, 2007

March 7, 2007

This patch should fix the incorrect handling of WaveHdr loops when pausing. Like the non-loop case written before, this sums the buffer lengths between dwPlayedTotal and dwWrittenTotal to calculate the new dwPartialOffset. Instead of blindly moving from one buffer to the next, however, this traverses the list using BeginWaveHdr and PlayPtrNext. This has added benefit of correctly initializing all pointers and counters for playback. It looks correct on paper, but I don't seem to have any applications that even attempt to pause. Can anyone suggest an application to test this with? All feedback welcome. Note: this branch in the function is a 'software' pause. To test you may need to override the check for ALSA's hardware pause at line 418 (snd_pcm_hw_params_can_pause) -- Chris diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 6a8a435..4ac50c6 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -319,9 +319,9 @@ static DWORD wodPlayer_NotifyCompletions(WINE_WAVEDEV* wwo, BOOL force) * * wodPlayer helper. Resets current output stream. */ -static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) +static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) { - int err; + int err; TRACE("(%p)\n", wwo); /* flush all possible output */ @@ -329,7 +329,7 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) wodUpdatePlayedTotal(wwo, NULL); /* updates current notify list */ - wodPlayer_NotifyCompletions(wwo, FALSE); + wodPlayer_NotifyCompletions(wwo, reset); if ( (err = snd_pcm_drop(wwo->pcm)) < 0) { FIXME("flush: %s\n", snd_strerror(err)); @@ -345,9 +345,6 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) DWORD param; HANDLE ev; - /* remove any buffer */ - wodPlayer_NotifyCompletions(wwo, TRUE); - wwo->lpPlayPtr = wwo->lpQueuePtr = wwo->lpLoopPtr = NULL; wwo->state = WINE_WS_STOPPED; wwo->dwPlayedTotal = wwo->dwWrittenTotal = 0; @@ -368,32 +365,34 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) ((LPWAVEHDR)param)->dwFlags &= ~WHDR_INQUEUE; ((LPWAVEHDR)param)->dwFlags |= WHDR_DONE; - wodNotifyClient(wwo, WOM_DONE, param, 0); + wodNotifyClient(wwo, WOM_DONE, param, 0); } ALSA_ResetRingMessage(&wwo->msgRing); LeaveCriticalSection(&wwo->msgRing.msg_crst); } else { - if (wwo->lpLoopPtr) { - /* complicated case, not handled yet (could imply modifying the loop counter */ - FIXME("Pausing while in loop isn't correctly handled yet, except strange results\n"); - wwo->lpPlayPtr = wwo->lpLoopPtr; - wwo->dwPartialOffset = 0; - wwo->dwWrittenTotal = wwo->dwPlayedTotal; /* this is wrong !!! */ - } else { - LPWAVEHDR ptr; - DWORD sz = wwo->dwPartialOffset; + DWORD diff = wwo->dwWrittenTotal - wwo->dwPlayedTotal; + DWORD sz; + + /* no pointers or counters need to change */ + if (diff <= wwo->dwPartialOffset) + wwo->dwPartialOffset -= diff; + else { + wwo->lpLoopPtr = NULL; + wodPlayer_BeginWaveHdr(wwo, wwo->lpQueuePtr); - /* reset all the data as if we had written only up to lpPlayedTotal bytes */ - /* compute the max size playable from lpQueuePtr */ - for (ptr = wwo->lpQueuePtr; ptr != wwo->lpPlayPtr; ptr = ptr->lpNext) { - sz += ptr->dwBufferLength; + diff -= wwo->dwPartialOffset; + sz = wwo->lpPlayPtr->dwBufferLength; + + while (sz < diff) { + wodPlayer_PlayPtrNext(wwo); + sz += wwo->lpPlayPtr->dwBufferLength; } - /* because the reset lpPlayPtr will be lpQueuePtr */ - if (wwo->dwWrittenTotal > wwo->dwPlayedTotal + sz) ERR("grin\n"); - wwo->dwPartialOffset = sz - (wwo->dwWrittenTotal - wwo->dwPlayedTotal); - wwo->dwWrittenTotal = wwo->dwPlayedTotal; - wwo->lpPlayPtr = wwo->lpQueuePtr; + + wwo->dwPartialOffset = sz - diff; + wodPlayer_BeginWaveHdr(wwo, wwo->lpQueuePtr); } + + wwo->dwWrittenTotal = wwo->dwPlayedTotal; wwo->state = WINE_WS_PAUSED; } }

1 0

Re: [3/4] WineD3D: Blit the offscreen texture into the drawable if needed
by Stefan Dösinger March 7, 2007

March 7, 2007

Am Mittwoch 07 März 2007 02:43 schrieb Stefan Dösinger: Do not apply this patch yet. Cube textures aren't that easy

1 0

App DB TOP-10 issue
by speedator＠gmx.de March 7, 2007

March 7, 2007

Hi, I want to annotate that there are apps/games twice in the Platinum List(Diablo II Lord of Destruction 1.x , Outlaws All versions) even thrice(if you add Diablo II 1.x and LoD up for such a list). Btw: Why are Outlaws and IDA Pro "top"? Doesn't seem they are so popular, nvm.

2 1

Re: [PATCH] DirectPlay should keep track of the current number of players
by Kai Blin March 7, 2007

March 7, 2007

On Tuesday 06 March 2007 23:25, Alessandro Pignotti wrote: > Hi everyone, > this patch fixes the behaviour of dplayx that was not adding new player to > its counter. I don't see a patch. Did you attach it? Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: comctl32: Implement LVS_EX_DOUBLEBUFFER
by Dimi Paun March 6, 2007

March 6, 2007

On Tue, March 6, 2007 16:27, Felix Nawothnig wrote: > Tested with utorrent - completly removes the flickering from #7344. > In case you're wondering about the change in EraseBkgnd() - this is how > native behaves, they recreate the double buffer on each refresh so we > need to move the erase. Please tell me if I broke anything. It looks good, but you don't cleanup the new DC if the bitmap creation fails. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: [localspl/tests] Remove tempfile after running the tests
by Detlef Riekenberg March 6, 2007

March 6, 2007

On Di, 2007-03-06 at 18:47 +0100, Paul Vriens wrote: > We had a leftover file in the temp directory. > > Changelog > Remove tempfile after running the tests Ignore my prev. mail. I looked always in "c:\temp" and found the files in "c:\tmp" :-( Sorry for the noise. -- By by ... Detlef

1 0

Re: [localspl/tests] Remove tempfile after running the tests
by Detlef Riekenberg March 6, 2007

March 6, 2007

On Di, 2007-03-06 at 18:47 +0100, Paul Vriens wrote: > + > + /* Cleanup our temporary file */ > + DeleteFileW(tempfileW); Where / when did you see an undeleted File for this test? localspl_test.exe does not create a temporary file yet. -- By by ... Detlef

1 0

dll that just forward
by Luis Carlos Busquets Pérez March 6, 2007

March 6, 2007

Concerning dlls dpnaddr.dll dpnlobby.dll They both are dlls with just one function and that it is forwarded to dpnet.dll. I understand that this is just for compatibility reasons. If we add to the git tree these two spec files dlls/dpnaddr/dpnaddr.spec: stdcall DirectPlay8AddressCreate( ptr ptr ptr ) dpnet.DirectPlay8AddressCreate dlls/dpnlobby/dpnlobby.spec: stdcall DirectPlay8Create(ptr ptr ptr) dpnet.DirectPlay8Create Shouldn't these do to have both dlls implemented natively in wine? Do we need to add anymore code for dll functions which are just forwarded in windows?

2 1

Regression in Lotus Notes R5 between wine-0.9.27 and wine-0.9.28
by Pedro Araujo Chaves Jr. March 6, 2007

March 6, 2007

Hi all, There's been a regression in printing in Lotus Notes R5 somewhere between wine-0.9.27 and wine-0.9.28: it seems that the presence of an inline picture (in this case, a logo) in the mail stationery prevents all text (including header text) from being printed. Odd as it may seem, my regression testing pointed commit 21635133fb271405fefd6bce3078cf971e84c426 as the cause. I positioned my tree just before it, and the mail printed okay; I applied it, the mail came out blank again. As I still couldn't see any direct relation between the said commit and this issue, I'm posting here in the hope someone would be able to figure out what's going on. If that's the case, then, I'll file a bug report and upload a database containing a message with one of these problematic stationeries. Regards, -- - Pedro.

2 3

Re: [wordpad]updated Korean Resource
by Detlef Riekenberg March 6, 2007

March 6, 2007

On Di, 2007-03-06 at 17:35 +0900, Hwang YunSong(황윤성) wrote: > MENUITEM "(&C)\tCtrl+C", ID_EDIT_COPY > + MENUITEM "ٿֱ(&P)\tCtrl+V", ID_EDIT_PASTE > + MENUITEM "(&C)\tDEL", ID_EDIT_CLEAR > + MENUITEM " (&S)\tCtrl+A", ID_EDIT_SELECTALL > MENUITEM SEPARATOR The idention is different. Please replace the tab with "4 Space" (Similar in the Stringtable below that Part) -- By by ... Detlef

1 0

Question some code in server/request.c
by Paul Vriens March 6, 2007

March 6, 2007

Hi, while going through the Coverity reports I found CID-293 that mentions a possible NULL-RETURN. Marcus sent in a patch that wasn't applied. If I look at the code (starting at line 537): /* create the server directory and chdir to it */ static void create_server_dir( const char *dir ) { char *p, *server_dir; struct stat st, st2; if (!(server_dir = strdup( dir ))) fatal_error( "out of memory\n" ); /* first create the base directory if needed */ p = strrchr( server_dir, '/' ); *p = 0; create_dir( server_dir, &st ); /* now create the server directory */ *p = '/'; create_dir( server_dir, &st ); if (chdir( server_dir ) == -1) fatal_perror( "chdir %s", server_dir ); if (stat( ".", &st2 ) == -1) fatal_perror( "stat %s", server_dir ); if (st.st_dev != st2.st_dev || st.st_ino != st2.st_ino) fatal_error( "chdir did not end up in %s\n", server_dir ); free( server_dir ); } it looks to me that 'p' is not used at all (this is so since June 2002). Am I completely missing something? Cheers, Paul.

5 5

Re: ddraw: Don't include window border in default surface size (ignore the other patch)
by Stefan Dösinger March 6, 2007

March 6, 2007

Am Sonntag 04 März 2007 20:49 schrieb Samuel Lidén Borell: > If no width or height is passed to CreateSurface, use GetClientRect > instead of GetWindowRect to calculate a default size. tbh, the whole thing is wrong. Whatever cooperative level is used, and whatever the surface size is, windows creates a front buffer surface of the full screen size. So if you have a res of 1400x1050 and a window of 64x64, the front buffer is 1400x1050 pixels in size. I wanted to change that somewhen, but the windowed d3d rendering needs some adjustments for it(Not the usual opengl problem).

1 0

Re: [1/2] gdi32: Implement AddFontMemResourceEx api.
by Dmitry Timoshkov March 6, 2007

March 6, 2007

"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote: > These patches fix the BUG #5865 > http://bugs.winehq.org/show_bug.cgi?id=5865. > > changelog: > Implement AddFontMemResourceEx. You shouldn't need to create a temp file, FT_New_Memory_Face is able to load font data from memory just fine. FT_New_Memory_Face is already used by OpenFontFile, you need to adapt existing code to not require fonts to be passed as a file name in general. -- Dmitry.

2 2

Re: 0001-server-main.c-fixed-command-line-parsing-using-GNU-getopt
by Dmitry Timoshkov March 6, 2007

March 6, 2007

"Srivatsa Kanchi, R" <skanchi(a)nexthop.com> wrote: > replaced the custom 'parse_args' function with GNU getopt And what's wrong with current parser, except it being custom? > applied some coding style to limit code 80 characters /line Please leave existing style alone, even if you don't like it. -- Dmitry.

2 3

Working on DIBEngine for SOC
by Ivan de Jesus Deras Tabora March 5, 2007

March 5, 2007

Hello everyone. I'm thinking about participating in the Google SOC 2007. Given that Wine in one of my favorite Open Source projects I find interesting the idea of implementing the DIBEngine. In the past I've worked in some Open Source projects, one of them QT-Win32 and also I did little contributions to the OFC (Open Foundation Class). I've experience with C coding, mostly from working on Educational OS like GeekOS and PintOS. >From what I understood the hard part of this project is INTEGRATION. I mean integrating the new code into the Wine repository without breaking everything? Am I right? About the drawing code, I read that is possible to use the X11 code, also the ReactOS code and the old Transgaming DIBEngine (incomplete). Is that correct? Waiting for your comments and ideas. Regards, Ivan

5 4

Re: AppDB performance issue
by Tony Lambregts March 5, 2007

March 5, 2007

Nick Law wrote: > Hi Tony, > Just lately, I've noticed that AppDB seems to be very slow, i.e it can > take15 seconds or more for a page to come up or simply to login. Is > there a bandwidth problem or is the server getting overwhelmed or is > it a problem at my end (UK). 30 seconds later it's back to being very > responsive as if the server was a bit overloaded for 30 seconds or so. > Other websites I try at the time work fine including winehq. Is winehq > on a different server ? > I have noticed this too and it is very annoying. Yes www.winehq.org qpdb.winehq.or and bugs.winehq.org are all on the same server. Winehq and bugzilla are quite snappy but the AppDB is a pig now. I have know idea what is wrong -- Tony Lambregst

9 19

Current wine and HL2 family - well done!
by Luke Bratch March 5, 2007

March 5, 2007

> without an annoying graphics glitch causing parts of skies to be > replaced with some bogus contents like white, black, mirrors of a part of > ground etc. Are you finding no errors at all? In Counter-Strike: Source, when running in anything above DX7 mode, on the map "de_aztec", the screen is often completely black - it appears to be when looking at water. ___________________________________________________________ Inbox full of unwanted email? Get leading protection and 1GB storage with All New Yahoo! Mail. http://uk.docs.yahoo.com/nowyoucan.html

7 15

mingw linking problem
by Stefan Leichter March 5, 2007

March 5, 2007

Hello, i'm trying to build wine/its dlls with mingw. This fail for some dlls at the linking, eg. comdlg32.dll misses the imports _IID_IContextMenu, _IID_IShellFolder, _IID_IPersistFolder2, _IID_IShellBrowser, _IID_ICommDlgBrowser, _IID_IShellView, _SID_STopLevelBrowser My investigations are showing that mingw has the missing imports in libshell32.a., but the linker links against wine's shell32.dll. The missing symbols are also in wine's libuuid.a, but this is not used because the linker does not see the file. When i extend the linker call with -L../../dlls/uuid i can link the comdlg32.dll successfully.. I have tried to find the symbols with strings on my win2k box, but the symbols are not there. So the first question is: What is the correct way to build the dll? The second question when we agreed on the first one is: Can someone please fix configure/Makefile.in to work properly . Thanks Stefan

3 3

Visualizing skip on test.winehq.org (and getting rid of visible desktop border)
by Paul Vriens March 5, 2007

March 5, 2007

Hi, currently all tests on test.winehq.org show the blue border to indicate the test is running on a visible desktop. I think we can get rid of this one as winetest will not run if we don't have a visible desktop. My idea is to visualize the skipped tests by using the blue border at the single test level to indicate tests are skipped (see attached picture). Comments, idea's, thoughts? Cheers, Paul.

3 2

fc4 rpms
by Bill Medland March 5, 2007

March 5, 2007

Is there any chance that someone with the ability can create the fedora core 4 wine rpms for version 0.9.30? Bill Medland

4 4

Re: Problems with Alice
by gslink March 5, 2007

March 5, 2007

After considerable digging the problems with sound in Alice were traced to a bad software load. While digging another thing came to our attention that may be of interest to others. When we put in the latest fixes to FC6 Wine quit running. This was traced to the fact that the latest fixes contain a set of fixes for the X server and replace the open GL library. The drivers posted by Nvidia, which were installed, have their own GL library and will not work with the RH GL library. If you install an update to FC and are using the Nvidia drivers reinstall the drivers if things in the X server quit working. This is true even if the kernel version is not changed.

1 0

Re: secur32: NTLM's AcquireCredentialHandleA/W should accept domains and usernames with lengths of 0.
by Kai Blin March 5, 2007

March 5, 2007

On Monday 05 March 2007 13:02, Robert Shearman wrote: > + if(pQuerySecurityPackageInfoA(sec_pkg_name, &pkg_info) != SEC_E_OK) > + { > + trace("NTLM package not installed, skipping test\n"); > + return; > + } I've just started using skip() for skipping tests. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

2 1

Writing IDL and other definition files
by Jeff L March 5, 2007

March 5, 2007

I am looking at writing a piece of IDL and a header file I am wrestling with how to do it without infringing copyright. IDL looks particularly hard to write from first principles and is probably hard to write in a different way as the functions being implemented are defined and require IDL similar code. Is there any advice as to what type of code can be copied and what constitutes a rewrite to avoid copyright? Jeff

2 2