March 2007 - Wine-Devel - list.winehq.org

re: Corrupted system.reg in clustered environment - where to look?
by Dan Kegel March 30, 2007

March 30, 2007

Alexander.Farber at nokia.com wrote: > [I use wine on multiple machines with ~/.wine shared via NFS, > and after a while, the registry is corrupt.] Well, if it hurts, don't do it :-) Seriously. NFS is not a good place to put WINEPREFIX. In my testing, it causes serious performance problems. And NFS file locking has been broken from day 1. They keep trying to make it work, but it's never going to make you happy. So why not take the easy way out, and put WINEPREFIX on local disk? Surely you can do this. If you really need the Wine applications to share data, you can do it by creating D: or some directory in C: as a shared folder. Just don't share everything. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: Stub for all raw input functions
by Dmitry Timoshkov March 30, 2007

March 30, 2007

"Kovács András" <andras(a)csevego.net> wrote: > +LRESULT WINAPI DefRawInputProc( PRAWINPUT *paRawInput, INT nInput, UINT cbSizeHeader ) > +{ > + FIXME("(paRawInput=%p, nInput=%d, cbSizeHeader=%d) stub!\n", *paRawInput, nInput, cbSizeHeader); > + > + return S_OK; > +} Although MSDN documents that on success DefRawInputProc returns S_OK, that's most likely a misguided documenters error: S_OK is an HRESULT and an OLE error value, while it's user32 and return type is LRESULT. So IMO simply returning 0 should be OK here. > +BOOL WINAPI RegisterRawInputDevices( PRAWINPUTDEVICE pRawInputDevices, UINT uiNumDevices, UINT cbSize ) > +{ > + FIXME("(pRawInputDevices=%p, uiNumDevices=%d, cbSize=%d) stub!\n", pRawInputDevices, uiNumDevices, cbSize); > + > + return TRUE; > +} Probably this stub should return FALSE. > +UINT WINAPI GetRawInputBuffer( PRAWINPUT pData, PUINT pcbSize, UINT cbSizeHeader ) > +{ > + FIXME("(pData=%p, pcbSize=%p, cbSizeHeader=%d) stub!\n", pData, pcbSize, cbSizeHeader); > + > + return 0; > +} MSDN says that an error indicator is -1, not 0, same as for others raw input APIs. -- Dmitry.

2 1

Corrupted system.reg in clustered environment - where to look?
by Alexander.Farber＠nokia.com March 30, 2007

March 30, 2007

Hello Wine developers, we try to use Wine in clustered environment with multiple Wine processes being started simultaneously on 8 to 80 Linux machines by a modified GNU make. The source code being built is located on an NFS mount visible by all cluster machines. Unfortunately Wine fails after some time because of corrupted ~/.wine/system.reg. I guess multiple Wine processes try to update some keys in that file, like (differing) processor steppings etc. and this goes wrong at some point. Also I've noticed, that the registry is being re-saved every 30 seconds (why?) - here in wine-0.9.32/server/registry.c: static const int save_period = 30000; /* delay between periodic saves (in ms) */ I've tried adding file locking using fcntl() (which should work over NFS too) by modifiyng load_registry() and save_registry() as in the attached diff, but unfortunately it doesn't help. Does anybody have a hint where to look? Why updating registry is needed at all and can I disable it maybe? (And where would be the good spot to do that?) Thank you Alex

2 2

Re: [1/2] regedit: Support the REG_MULTI_SZ.
by Juan Lang March 30, 2007

March 30, 2007

Hi Byeong-Sik, + lRet = RegSetValueEx(hKey, valueName, 0, type, (LPBYTE)stringValueData, j); I think that should be j * sizeof(TCHAR), yes? --Juan ____________________________________________________________________________________ Food fight? Enjoy some healthy debate in the Yahoo! Answers Food & Drink Q&A. http://answers.yahoo.com/dir/?link=list&sid=396545367

2 1

RE: Jason Edmeades : xcopy: Add support for COPYCMD override and fix /-y.
by Alexander.Farber＠nokia.com March 30, 2007

March 30, 2007

Hello, wouldn't it be nicer to use sizeof(copyCmd) here? if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) { There are many spots like this in wcmdmain.c Regards Alex > -----Original Message----- > From: wine-cvs-bounces(a)winehq.org > [mailto:wine-cvs-bounces(a)winehq.org] On Behalf Of ext Alexandre Julliard .... > > + /* Preinitialize flags based on COPYCMD */ > + if (GetEnvironmentVariable(COPYCMD, copyCmd, MAXSTRING)) { > + if (wcsstr(copyCmd, PROMPTSTR1) != NULL || > + wcsstr(copyCmd, PROMPTSTR2) != NULL) { > + flags |= OPT_NOPROMPT; > + } > + } > + >

1 0

Re: [1/2 RESEND] gdi32: Add failing metrics test for negative font widths
by Alexandre Julliard March 30, 2007

March 30, 2007

Felix Nawothnig <flexo(a)holycrap.org> writes: > Please tell me if this still fails on your box (both versions pass on mine). Now it succeeds where it shouldn't... ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:541: Tests skipped: Symbol is not installed so skipping this test font.c:784: Tests skipped: Arial is not installed font.c:1094: Tests skipped: Arial is not installed font.c:1228: Tests skipped: Arial Black is not installed font.c:1228: Tests skipped: Symbol is not installed font.c:1688: Tests skipped: Arial Black or Symbol/Wingdings is not installed font.c:1514: Test succeeded inside todo block: gm1=62,57,0,60,61,0 gm2=62,57,0,60,61,0 make: *** [font.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv: Remove an unnecessary XFlush().
by Alexandre Julliard March 30, 2007

March 30, 2007

Huw Davies <huw(a)codeweavers.com> writes: > --- a/dlls/winex11.drv/xrender.c > +++ b/dlls/winex11.drv/xrender.c > @@ -596,7 +596,6 @@ void X11DRV_XRender_UpdateDrawable(X11DRV_PDEVICE *physDev) > if(physDev->xrender->pict) > { > TRACE("freeing pict = %lx dc = %p\n", physDev->xrender->pict, physDev->hdc); > - XFlush(gdi_display); > pXRenderFreePicture(gdi_display, physDev->xrender->pict); > physDev->xrender->pict = 0; > } This causes a test failure here: ../../../tools/runtest -q -P wine -M comctl32.dll -T ../../.. -p comctl32_test.exe.so header.c && touch header.ok X Error of failed request: BadPixmap (invalid Pixmap parameter) Major opcode of failed request: 54 (X_FreePixmap) Resource id in failed request: 0x2400023 Serial number of failed request: 461 Current serial number in output stream: 472 make: *** [header.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 18/18] XCOPY: Add help
by Joerg Mayer March 30, 2007

March 30, 2007

Umm, is there a specific reason why you created the mails by replying to the previous patch? This doesn't look that good with mailers that keep track of replies and e.g. indents them. ciao Joerg

1 0

Re: Declare another bunch of raw input structures and constants
by Dmitry Timoshkov March 30, 2007

March 30, 2007

"Kovács András" <andras(a)csevego.net> wrote: > +typedef struct tagRAWMOUSE { > + USHORT usFlags; > + union { > + ULONG ulButtons; > + struct { > + USHORT usButtonFlags; > + USHORT usButtonData; > + } s; > + } u; You have to use DUMMYSTRUCTNAME and DUMMYUNIONNAME instead of s and u. Also please use 4 spaces indents instead of strange mix of 2 + 7 + 2. -- Dmitry.

1 0

Re: Allow enabling/disabling Direct3D usage of GLSL in Winecfg + update Czech locales for Winecfg
by Ivan Gyurdiev March 29, 2007

March 29, 2007

Vit Hrachovy wrote: > Hi, > according to thread 'WineCfg and DirectX options' at wine-devel, That thread was heading in the wrong direction... > I'm > proposing a patch for winecfg to allow enabling/disabling usage of GLSL > for Direct3D applications rendering. Do you want to make it easy to configure GLSL, or make it easy to enable GLSL? In other words, can you enumerate the cases where one would disable GLSL? Should those be in a document somewhere on the wiki as blockers to 1.0 (since GLSL default was pointed out as a 1.0 requirement)? Do we expect this option to be around for a long time? I don't see consensus to add these options in the referenced thread - if more testing exposure is needed, why not just enable this by default?

3 2

Re: gdi32: Add failing metrics test for negative font widths
by Felix Nawothnig March 29, 2007

March 29, 2007

Felix Nawothnig wrote: > --- > dlls/gdi32/tests/font.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 files changed, 37 insertions(+), 0 deletions(-) Anything wrong with this patch?

2 1

Question about OpenAL
by Mike Schaadt March 29, 2007

March 29, 2007

Is there any interest in adding OpenAL to Wine? I would imagine it's relatively simple to implement the OpenAL dll that would be a simple wrap around the Linux OpenAL library assuming they have the same functionality(from what I know of OpenAL, they should). It's not a very common library, but if we could implement it on top of the local implementation, that would mean that programs that use it would be using local devices without having to go through the DirectSound library. I'm not talking about using OpenAL as an audio driver, but an implementation of the OpenAL library for Wine that would use the local version of OpenAL. I tried looking around, and the only thing I found was talk about the OpenAL driver, and also brief requests for an OpenAL dll, but I didn't see anything official. Any thoughts on if this is something that would be beneficial to add?

5 4

Wine Benchmarks and CAPS
by Tom Wickline March 29, 2007

March 29, 2007

Hello, I have the 0.9.33 page done, and you may notice that Wine regressed in a couple of the test. When looking at these scores you will need to take into account the actual visual quality . The scores were somewhat high in past test because everything wasn't being rendered, while that makes for a nice score the visual wasn't on par with that of Windows. As of 0.9.33 the visual quality is very close to that of Windows, so in test like 3DMark2001SE we not only got drastically improved visual quality, we also have a 50% improvement in performance! And 3DMark 03 has a nice showing out of the gate as well. Why no OpenGL test? I plan to wait for a resolution to a couple outstanding OpenGL bugs, and then run the test again. I also plan to dramatically increase the screen resolution in the next update, GL-Excess in the past was run at only 640x480x16 in the future all test will be run at a resolution of 1024x768x32 or greater. If all goes well In a couple months there should be another update with OpenGL test and 3DMark 05/06 results. If 3DMark 2000, 2001SE or 2003 should drastically change ill also update them as well at that time. I also updated the CAPS page with 0.9.33 and 1.0.9755. 0.9.33 results: http://wiki.winehq.org/BenchMark-0.9.33 Past results: http://wiki.winehq.org/BenchMarks CAPS results: http://wiki.winehq.org/DirectX-Caps Some screen shots of past test results.... You may want to look at them ASAP if your interested in them, I plan to ask Dimi to rm -rf the page in a couple weeks to save the HD space on the wiki server, this way I can start a new "In Progress" page and not feel guilty about uploading all the shots :D http://wiki.winehq.org/BenchMark-0.9.6 Cheers! -- Tom Wickline Respectable computing - Linux/FOSS

4 5

Re: [PATCH 2/3] wined3d: Add NV/ARB_texture_rectangle extension (try 2)
by Stefan Dösinger March 29, 2007

March 29, 2007

Am Donnerstag 29 März 2007 17:13 schrieb Vitaly Budovski: > Add support for NV_texture_rectangle and ARB_texture_rectangle extensions. > --- > dlls/wined3d/directx.c | 6 ++++++ > include/wine/wined3d_gl.h | 19 +++++++++++++++++++ > 2 files changed, 25 insertions(+), 0 deletions(-) Nothing really wrong with this patch, though I am concerned about patch 3. This patch is a dependency of patch 3, but there is nothing really wrong with adding the extensions.

2 3

Re: [PATCH 2/3] wined3d: Add ARB_texture_rectangle extension
by Frank Richter March 29, 2007

March 29, 2007

On 29.03.2007 16:02, Stefan Dösinger wrote: > Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski: >> Add support for ARB_texture_rectangle extension. >> --- >> dlls/wined3d/directx.c | 3 +++ >> include/wine/wined3d_gl.h | 9 +++++++++ >> 2 files changed, 12 insertions(+), 0 deletions(-) > There is also GL_NV_texture_rectangle. Is that one related? I think they're the same. -f.r.

2 1

Re: [PATCH 3/3] wined3d: Correctly set conditional NPOT caps bit
by Stefan Dösinger March 29, 2007

March 29, 2007

Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski: > This patch sets the conditional NPOT bit only when required. If an > implementation has full support for NPOT textures through the > ARB_texture_non_power_of_two extension, then support for the subset of > capabilities provided by the ARB_texture_rectangle extension is implied. > --- > dlls/wined3d/directx.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) I am not sure if we shouldn't set NONPOWER2CONDITIONAL unconditionally if POW2 is set. WineD3D emulates np2 textures by using a texture of the next pow2size and adjusting the texture matrix accordingly. This doesn't work for shaders though, but mipmapping and other things are supported.

2 1

Re: [PATCH 3/3] wined3d: Correctly set conditional NPOT caps bit (try 2)
by H. Verbeet March 29, 2007

March 29, 2007

On 29/03/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > This patch sets the conditional NPOT bit only when required. If an > implementation has full support for NPOT textures through the > ARB_texture_non_power_of_two extension, then support for the subset of > capabilities provided by the ARB_texture_rectangle extension is implied. > > Add additional check for the equivalent NV extension. > --- Do you know what ARB_texture_rectangle is? It's not a subset of ARB_texture_non_power_of_two, and it doesn't correspond to WINED3DPTEXTURECAPS_NONPOW2CONDITIONAL in any way. Please read http://www.opengl.org/registry/specs/ARB/texture_rectangle.txt

1 0

Nine good SoC propsals!
by Dan Kegel March 29, 2007

March 29, 2007

Wow. We have 29 or so total proposals, of which nine or ten seem like contenders. It's an embarrassment of riches! I wish we could pick them all. Time for the mentors to start arm-wrestling...

4 3

Re: [PATCH 2/3] wined3d: Add ARB_texture_rectangle extension
by Stefan Dösinger March 29, 2007

March 29, 2007

Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski: > Add support for ARB_texture_rectangle extension. > --- > dlls/wined3d/directx.c | 3 +++ > include/wine/wined3d_gl.h | 9 +++++++++ > 2 files changed, 12 insertions(+), 0 deletions(-) There is also GL_NV_texture_rectangle. Is that one related?

1 0

Re: gdi32: Implement the fake_bold for one faced fonts.
by Huw Davies March 29, 2007

March 29, 2007

On Thu, Mar 29, 2007 at 10:00:12PM +0900, Byeong-Sik Jeon wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index f7b1220..427def4 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > + memcpy(&gmetrix, &ft_face->glyph->metrics, sizeof(FT_Glyph_Metrics)); > + if ( font->fake_bold ) > + { > + /* fitting values to MS-Windows */ > + strength = pFT_MulFix( ft_face->units_per_EM, ft_face->size->metrics.y_scale ) / 42; > + if ( strength < 64) > + { > + gmetrix.width += strength; > + gmetrix.height += strength; > + gmetrix.horiBearingY += strength; > + gmetrix.horiAdvance += strength; > + } > + else if ( strength < 77) > + { > + gmetrix.width += 63; > + gmetrix.height += 63; > + gmetrix.horiBearingY += 63; > + gmetrix.horiAdvance += 63; > + } > + else > + { > + gmetrix.width += strength; > + gmetrix.height += strength; > + gmetrix.horiBearingY += strength; > + } This needs more investigation. I can't believe Windows uses this algorithm... Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: imm32: Change the default IME window to better reflect applications request
by Byeong-Sik Jeon March 29, 2007

March 29, 2007

It looks good to me. Thanks to Aric :) Aric Stewart wrote: > First part of this change was proposed by Byeong-Sik Jeon > <wjsqudtlr(a)gmail.com> > Use a tooltip window instead to avoid stealing focus from the application. > Additionally respect parameters give to us by ImmSetCompositionWindow > for placement of the composition window.

1 0

re: Improvement of WSAIoctl
by Dan Kegel March 29, 2007

March 29, 2007

Hi Axel, > some days ago, I tried to run the retail management software, we are developing in our > company now for over 15 years, with Wine on Linux. Unfortunatly it didn't work. > > The reason was not our product itself, but the ODBC driver form MS for MS-SQL-Server. > It uses a command for WSAIoctl in ws2_32.dll, wich isn't implemented in Wine yet. > Because of the lack of this command, the driver fails and our software does not work. > > With other databases it works great, but unfortunatly most of our customers prefer using > MS-SQL-Server, so this piece of MS-Software is a must for us. I'm thrilled you're doing this. What's your software called? > + case WS_SIO_KEEPALIVE_VALS: > + { > + /* FIXME: not fully implemented */ > + BOOL value; > + > + if (cbInBuffer < sizeof(struct tcp_keepalive) || !lpvInBuffer) > + { > + WSASetLastError(WSAEFAULT); > + return SOCKET_ERROR; > + } > + > + value = ((struct tcp_keepalive *)lpvInBuffer)->onoff; > + return WS_setsockopt(s, WS_SOL_SOCKET, WS_SO_KEEPALIVE, (char *)&value, sizeof(BOOL)); > + } I think that looks great. If your patch isn't accepted in the next couple of days, consider adding a simple conformance test and resubmitting. But you can't do this: > + * Copyright (C) the Wine project as there's no legal entity called "the Wine project". You have to use your company's name, I think. (And be sure they've granted permission.) Or if you have the rights to what you do in your spare time, your own name is fine. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: ntdll: "add" ZwAreMappedFilesTheSame to ntdll.spec
by Dmitry Timoshkov March 29, 2007

March 29, 2007

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec > index e315057..3377db3 100644 > --- a/dlls/ntdll/ntdll.spec > +++ b/dlls/ntdll/ntdll.spec > @@ -948,7 +948,7 @@ > # @ stub ZwAllocateUserPhysicalPages > @ stdcall ZwAllocateUuids(ptr ptr ptr) NtAllocateUuids > @ stdcall ZwAllocateVirtualMemory(long ptr ptr ptr long long) NtAllocateVirtualMemory > -# @ stub ZwAreMappedFilesTheSame > +@ stub ZwAreMappedFilesTheSame > # @ stub ZwAssignProcessToJobObject > @ stub ZwCallbackReturn > # @ stub ZwCancelDeviceWakeupRequest It seems you haven't read an introducing comment in the first lines of ntdll.spec before changing it. -- Dmitry.

1 0

What is the X11 lock?
by Shachar Shemesh March 29, 2007

March 29, 2007

Hi list, Can anyone please explain to me what the x11 lock is used for? I can see that SOME X11 functions (e.g. - read description on X11DRV_KEYBOARD_DetectLayout) require a lock, while others seem to call X11 functions with no lock. I can see that sometimes the x11 lock is obtained around a single X11 call. Is there any guideline I can follow that will tell me whether I need a lock for code I'm writing? What is the race this lock was designed to fix? Thanks, Shachar

1 0

Undocumented function syssetup.dll.SetupQueryRegisteredOsComponent
by Dan Kegel March 28, 2007

March 28, 2007

Any suggestions as to how to discover the prototype of the apparently undocumented function syssetup.dll.SetupQueryRegisteredOsComponent ? It seems to be needed to install mdac-2.8. ( http://bugs.winehq.org/show_bug.cgi?id=5824 ) - Dan

5 5