March 2007 - Wine-Devel - list.winehq.org

Re: Patch to fix bug 892
by Steven Edwards March 26, 2007

March 26, 2007

On 3/25/07, Patrick Baggett <baggett.patrick(a)gmail.com> wrote: > There also was a problem with getting the number of processors. The old code > assumed always 1 processor. The new code uses POSIX interfaces, if > available, at compile time and correctly builds a bitmask of the active > processors. It seems to me this should really be detected at runtime. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: Safedisc support (was: Road to 1.0)
by Timo Jyrinki March 25, 2007

March 25, 2007

Alexandre Julliard wrote: > And if we delay it a bit more maybe we can slip in Safedisc > support too... Regarding which, does anyone have more up-to-date code and/or information regarding Safedisc support, than what is currently on the brand new Wine wiki page: http://wiki.winehq.org/SafeDisc ? Safedisc support seems to be a topic that is hacked upon by various people every now and then, but it does not seem very coordinated. It'd be great if the wiki page would help to report on who's working on what etc., and maybe even provide usable patches for users to try. -Timo

4 4

re: Winebot
by Dan Kegel March 25, 2007

March 25, 2007

Vit wrote: > I'll write the manifest (a),(c) and post it onto Winebot Wiki. Cool... where is that? > I gladly accept any input to create a regression test repository, > would you be so kind and point me to some list of programs / test > miniprograms to make a reference implementation? I'd be glad to. I, Lei, and Nigel are just getting that going, and will be in touch via email. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS fix
by Robert Shearman March 25, 2007

March 25, 2007

Andrew O. Shadoura wrote: > break; > } > > + if (flags & MB_USEGLYPHCHARS) { > + for (i=0; i!=dstlen; i++) > + if (dst[i]<0x20) dst[i]=glyph_xlat[dst[i]]; > + } > + > I think you need to take into account the codepage when doing this translation. -- Rob Shearman

4 6

Game road to 1.0
by Stefan Dösinger March 25, 2007

March 25, 2007

Hi, In another thread Alexandre has mentioned to wait for game stuff to stabilize before the 1.0 freeze. I think its time for another brainstorm of what features are still missing which we want in 1.0. The DirectX Todo has a long list but it tends to be useless to me. And I see that it can use some more cleanup( /me blames Tom-W for not nagging me enough :-) ) It also sounds like AJ takes games as an excuse to delay the freeze for the display driver cleanup, and I was tempted to take the display driver cleanup as an excuse to get more dx stuff in. So which of the following things do we want for 1.0? Direct3D: * Some SM 3.0 features are still missing. Instancing is now in, vertex textures and some other stuff still missing. Not widely used among games yet. * Multithreading. OpenGL part done(except of 3 patches which I'll NOT send for now (*) ), but needs synchronisation. Will take a lot of time. * OpenGL ddraw. Render target locking improvements, multithreading. * Many games to not run yet, problems on MacOS drivers and fglrx. For the D3D part I see that as bugfixes which can happen after the freeze as far as I understand things. * Direct3D10. Will see if someone applies for my SoC proposal. (*) The patches that do the context selection. I won't send them because with my testing patches people started hunting phantom bugs which were the result of missing synchronisation. DirectSound: Maarten plans to work on that for SoC I think. Freezing now would make that difficult. Would mean to delay the freeze until September / October most at least. I'd personally really apprechiate dsound and alsa working better in 1.0. OpenGL: I don't really know of the windowed opengl state, and the wined3d -> wgl move. Still planned? DirectPlay: Kai works on the protocol, but I think he doesn't plan to implement it anytime soon. It seems the current idea is to improve our networking libs to get native dplay working.

6 11

Driver/os bug test app
by Stefan Dösinger March 25, 2007

March 25, 2007

Hi, Some other thread got into a sub-discussion of how to deal with driver issues. I think it is a slightly bigger issue, so I start a seperate thread about it. First of all, we will never get rid of driver bugs. Even if all bugs are fixed in drivers there will be old driver versions around, and there will be misconfiguration. My experince with supporting CrossOver users, and (older) memories of #winehq shows that many people run into problem which are caused by missing 3D drivers. The usual procedure is to isolate the issue, then write a seperate test app and report the issue to the driver developer. Thats perfectly fine I'd say. My suggestion is to collect those test cases in a Wine driver test suit somewhere, a seperate application(in the wine tree or not) which users can run to test their systems for known issues. This would make dealing with bugs easier, when a user complains why wow is terribly slow tell him to check his system with that test app, or if a user reports a bug with simmilar issues tell him to test the driver too. The test app reports detected issues to the user and can store links to bug reports(if publically available) and the driver version which has the bug fixed(if any). That test app should be a native Linux / MacOS app, not an application running in wine to exclude wine bugs. If that idea is not accepted, I can set up a git repositority for collecting individual driver tests so we have them archived somewhere at least. Bugs are not limited to 3D drivers of course, some kernel versions are known to have issues too, so the whole proposal is not limited to 3D stuff.

1 0

Road to 1.0 (graphics driver architecture)
by Rolf Kalbermatter March 25, 2007

March 25, 2007

Alexandre Julliard wrote: >I'm also hoping we can make some progress on the x11drv factorisation >before the freeze, so that we don't need to change the interface too >much to add the quartz driver later on, we'll see how that goes. Have you some specific ideas about what you want to do in that area? While the current apporach certainly works fine as far as invoking the DC specific functions without a lot of checking about the type of DC that is involved and therefore has a straightforward interface in GDI32 I think the matching of the actual driver interface with the actual GDI functions adds a lot of overhead into the driver itself that could much more easily be done once in GDI and left out of the driver completely. However changing the driver interface to match the let's say W2K driver would be quite a bit of work although it would seem to me at least an idea. Coming up with yet a different Wine specific interface would first require some architectural design work too but maybe you have done something in that direction already. Rolf Kalbermatter

2 1

Another win32 implementation: hiweedlayer?
by Dan Kegel March 25, 2007

March 25, 2007

http://hiweed.com/node/798 offers "hiweedlayer" for download. It is supposedly a Windows layer like Wine. Running strings on their single executable, I see messages like %s is being traced! location has changed! abnormal behavior! shell has changed! %s has expired! Please contact your provider which look like they're from this little bit of malware: http://forums.fedoraforum.org/archive/index.php/t-25441.html but perhaps they're just trying to keep people from reverse-engineering their code (or finding out that they have Wine code inside?). Using google language tools to translate the page, http://translate.google.com/translate?u=http%3A%2F%2Fhiweed.com%2Fnode%2F79… it looks like somebody already asked them if they were related to wine, but they didn't really answer. Can somebody fluent in Chinese make contact with them and see what their story is with regard to wine? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

4 4

Re: Game road to 1.0
by Alessandro Pignotti March 25, 2007

March 25, 2007

Hi, I'm actually working on DirectPlay implmentation, i'm first fixing a bit of thing around dplayx, so that we can use native dpwsockx (the dplay service provider) with builtin dplayx. After that i'm going to reimplement dpwsockx from scratch using the info from Kai Blins work on the protocol. Regards, Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

1 0

Re: WineD3D: Handle WINED3DSPSM_DZ and WINED3DSPSM_DW in texcrd in arb shaders
by Ivan Gyurdiev March 25, 2007

March 25, 2007

> From b1df18be85d1ca6a9904be05420f975f6933b030 Mon Sep 17 00:00:00 2001 > From: Stefan Doesinger <stefan(a)codeweavers.com> > Date: Fri, 23 Mar 2007 19:03:58 +0100 > Subject: [PATCH] WineD3D: Handle WINED3DSPSM_DZ and WINED3DSPSM_DW in texcrd in arb shaders > Isn't there a function to handle modifiers? "get_modifier_line"...

4 6

Re: [2/3] WineD3D: Implement bem shader instruction
by H. Verbeet March 25, 2007

March 25, 2007

On 25/03/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > With the glsl suggestions from Henri :-) > >+ shader_addline(arg->buffer, "(%s.xy + bumpenvmat * %s.xy)%s);\n", >+ src0_param.reg_name, src1_param.reg_name, dst_mask); MSDN states that the source parameters can have swizzles and modifiers. Unless, you can prove that's not true, the code should become: void pshader_glsl_bem(SHADER_OPCODE_ARG* arg) { glsl_src_param_t src0_param, src1_param; shader_glsl_append)dst(arg->buffer, arg); shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], WINED3DSP_WRITEMASK_0|WINED3DSP_WRITEMASK_1, &src0_param); shader_glsl_add_src_param(arg, arg->src[1], arg->src_addr[1], WINED3DSP_WRITEMASK_0|WINED3DSP_WRITEMASK_1, &src1_param); shader_addline(arg->buffer, "%s + bumpenvmat * %s);\n", src0_param.param_str, src1_param.param_str); } Normally you would have to take the destination write mask into account as well, but for this instruction it's always .xy.

1 0

Fwd: DirectDrawRenderer - opengl non power of 2 windows
by Nathan Williams March 24, 2007

March 24, 2007

Oh sorry, my misunderstanding! It is called from: flush_to_framebuffer_drawpixels http://source.winehq.org/git/wine.git/?a=blob;f=dlls/wined3d/surface.c;hb=H… On 3/25/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Am Samstag 24 März 2007 23:59 schrieb Nathan Williams: > > It crashes at: > > dlls/wined3d/surface.c > > d3dfmt_convert_surface: > > 1593 *dest++ = table[color][0]; > Yes, but from where is this called? d3dfmt_convert_surface: gets a height > parameter, and this parameter is incorrect. > -- Nathan

1 0

DirectDrawRenderer - opengl non power of 2 windows
by Nathan Williams March 24, 2007

March 24, 2007

I'm working on fixing the menus in carmageddon and I have a question. I have set the DirectDrawRenderer to opengl and it all crashes (where it works under gdi, just displays incorrectly). Now I traced the problem down to: dlls/wined3d/surface.c d3dfmt_convert_surface The loop at: http://source.winehq.org/git/wine.git/?a=blob;f=dlls/wined3d/surface.c;h=1f… loops over the surface height and width, the only problem is that the surface height appears to be scaled up to the next power of 2. As carmageddon runs in 320x200 the loop tries to iterate over 320x256 and subsequently crashes with a page fault in winedbg. Is there anyway to get the original window's dimensions and perhaps feed that to the function & hence loop, instead? Or should I just accept that carmageddon will forever be restricted to the gdi renderer? :P -- Nathan

2 5

re: SoC Idea: Improve bultin WordPad
by Dan Kegel March 24, 2007

March 24, 2007

Alex wrote: >> > closest I have gotten is some patches for Wine's WordPad implementation. >> >> Granted, it's less sexy than games, but you could learn more about C and >> Wine by building on that experience. There are lots of small and easy >> improvements that can be done get Wordpad up to par with native. Then come >> back next year to fix the games! > >That i s a good idea. :) > >I think I will go for it, unless anyone has objections to it. Sounds good to me. Suggestion: spend a day or two filing bugs or enhancement requests now for a bunch of things you'd like to fix / improve in wordpad. (I might even suggest broadening your proposal to include notepad; maybe there are a couple low-hanging fruit there.) - Dan

3 2

re; [Resend][Corrected] gdi32:widenpath partial implementation
by Dan Kegel March 24, 2007

March 24, 2007

I think it might help to a) create a bug in bugzilla with a link to Navigation, and a screenshot of the problem, and a recipe to reproduce b) think about how to implement a conformance test. Even a simple one might help. These suggestions were already made back in http://www.winehq.org/pipermail/wine-devel/2007-January/053457.html - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

SoC idea: Get Mono working well enough to run simple apps
by Dan Kegel March 24, 2007

March 24, 2007

There are lots of little bits, some pretty basic, which Wine is missing before it can support mixed assemblies in Mono. For instance, http://bugs.winehq.org/show_bug.cgi?id=7098 says that we're missing an implementation of mscoree.dll.CorBindToRuntimeEx. This would probably be a fine area for an SoC project.

2 1

Wine SoC idea: get your favorite IDE working
by Dan Kegel March 24, 2007

March 24, 2007

As the CEO of a famous operating system company once said, "I have four words for you: developers, Developers, DEVELOPERS, DEVELOPERS!" ( http://www.youtube.com/watch?v=KMU0tzLwhbE ) Attracting more developers (not of wine, but of their own apps) to Linux by getting their IDEs running on Wine would be great for wine, as developers are more likely than the average user to file bug reports or (dare we hope) fix bugs. So it would be good to get popular IDEs working on Wine. Newer Microsoft IDEs like Visual Studio 2005 are a challenge, Visual Studio 2005 express requires BITS (which is a SoC project in itself, http://bugs.winehq.org/show_bug.cgi?id=5054) Some IDEs run fairly well if you install DCOM98, in which case you would write conformance tests exposing the problems in our COM implementation so Rob can fix them :-) Older IDEs like Visual C++ 6 and Visual Basic 6 are in this category. cf. http://bugs.winehq.org/show_bug.cgi?id=4931 http://bugs.winehq.org/show_bug.cgi?id=5321 And then there's Eclipse, Delphi, Turbo C++, IntelliJ, Powerbuilder, Access, Visual Fox Pro, and many others. There are also specialized IDEs like AVRStudio (an IDE for embedded developers) which people want to run in Wine (see http://bugs.winehq.org/show_bug.cgi?id=5312) Picking one or two of these and focusing on getting its problems solved might be very useful. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Fwd: "Out of Tree" DLLs
by Kai Blin March 24, 2007

March 24, 2007

Hi folks, Tim asked me about this on IRC today, and I didn't have any good idea about it, so I'll just forward it to you people. Cheers, Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

2 1

Re: WineD3D: Implement bem shader instruction
by H. Verbeet March 24, 2007

March 24, 2007

On 24/03/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ shader_glsl_get_write_mask(arg->dst, dst_mask); >+ shader_glsl_add_src_param(arg, arg->src[0], arg->src_addr[0], WINED3DSP_WRITEMASK_ALL, &src0_param); >+ shader_glsl_add_src_param(arg, arg->src[1], arg->src_addr[1], WINED3DSP_WRITEMASK_0|WINED3DSP_WRITEMASK_1, &src1_param); >+ >+ shader_glsl_append_dst(arg->buffer, arg); >+ shader_addline(arg->buffer, "(%s + vec4(bumpenvmat * %s.rg, 0.0, 0.0))%s);\n", >+ src0_param.reg_name, src1_param.reg_name, dst_mask); >+} Please use xyzw consistently for components. Mixing xyzw with rgba and stuv only obfuscates things. Also, the vec4 contructor is unecessary, you should use proper swizzles instead.

1 0

RE: xcopy / cmd question (lack of real exe in system32)
by Alexander.Farber＠nokia.com March 24, 2007

March 24, 2007

Hello Jason, I'm just curious: xcopy.exe is an external program in Windows, but you want to make it a builtin command in Wine? Regards Alex > -----Original Message----- > [mailto:wine-patches-bounces(a)winehq.org] On Behalf Of ext Ann > & Jason Edmeades > > If I now run "wine xcopy", then it works (and gives a basic > error for now), > but it I run "wine cmd", then "xcopy" I get file not found. > As far as I can > tell, cmd will only search the path for such a program and > fails to find it. > > Should I add it to the fake dlls, which I think would cause a > file to be > created in system32, or how should cmd handle this situation > as xcopy.exe.so > isn't available on the path.

4 4

SoC Idea: Improve video support
by Alexander Nicolaysen Sørnes March 24, 2007

March 24, 2007

I really want to participate in Google's Summer of Code, but I realize I don't have much time left to find a suitable project. What I am thinking of is to improve Wine's capability of playing videos in games, first by fixing mciavi so it can play the Worms 2 intro films (bug 4256), and then hopefully progessing to fixing bugs in quartz/devenum, like crashes in Worms Armageddon or playback in WMP9. Is this too ambitious considering that I don't really have much experience with C and Wine? The closest I have gotten is some patches for Wine's WordPad implementation. Regards, Alexander N. Sørnes

3 3

Re: Winebot
by Remco March 24, 2007

March 24, 2007

Will winebot be a win32 app or a linux app? Making it a win32 app and developing it on Windows would probably reveal more Wine bugs. ____________________________________________________________________________________ Looking for earth-friendly autos? Browse Top Cars by "Green Rating" at Yahoo! Autos' Green Center. http://autos.yahoo.com/green_center/

2 1

Re: netapi32: [2/5] Implement NetUserAdd with a dummy user database.
by Dmitry Timoshkov March 24, 2007

March 24, 2007

"Kai Blin" <kai.blin(a)gmail.com> wrote: > + if(!su) > + { > + status = NERR_InternalError; > + goto user_add_error; > + } > + > + if(lstrlenW(ui->usri1_name) > LM20_UNLEN) > + { > + status = NERR_BadUsername; > + goto user_add_error; > + } > + > + /*FIXME: do other checks for a valid username */ > + lstrcpyW(su->user_name, ui->usri1_name); > + > + if(lstrlenW(ui->usri1_password) > PWLEN) > + { > + /* Always return PasswordTooShort on invalid passwords. */ > + status = NERR_PasswordTooShort; > + goto user_add_error; > + } 'break' would work just fine instead of 'goto' in all these places. -- Dmitry.

1 0

Re: netapi32/test: [1/5] Test the username and password length limits.
by Dmitry Timoshkov March 24, 2007

March 24, 2007

"Kai Blin" <kai.blin(a)gmail.com> wrote: > + usri.usri1_name = (LPWSTR) sTooLongName; > + usri.usri1_password = (LPWSTR) sTestUserOldPass; Just drop the 'const' modifier for the declared strings, don't use casts. There was a lot of efforts lately put into fixing Wine to compile cleanly with -Wcast-qual turned on, please fix the code while you are at it. -- Dmitry.

1 0

SoC idea: Tablet PC support (was: pressure sensitive tablet support)
by Dan Kegel March 24, 2007

March 24, 2007

On 3/21/07, Dan Kegel <dank(a)kegel.com> wrote: > While looking around for a project idea, I noticed that people > are starting to ask for pressure sensitive tablet support in > Photoshop on Wine. Seems like it could be a fun project > for some Summer of Code student. Update: wintab32 is already implemented in Wine, but there's a new API being pushed by Microsoft for Tablet PC applications. So the idea is instead "Get Tablet PC applications working on Wine", focusing on Tablet PC apps that offer pressure sensitivity, say. (I thought that FIrefox's GeckoTip extension used the new tablet PC APIs, but after looking at the source, I'm not so sure... I'm sure there are lots of good demo apps somewhere.) This assumes that Tablet PC apps don't yet work on Wine. I haven't tried... the place to start is probably to get the Tablet PC SDK (a free download if you have Windows) and start playing with it. - Dan

2 1