March 2007 - Wine-Devel - list.winehq.org

re: Resend: Add d3drmdef.h header file - try 3
by Dan Kegel March 20, 2007

March 20, 2007

Vijay wrote: >Resend. Please let me why this one has been dropped. I'd guess it's because there's no code in the tree that needs it yet, and no tests for it? - Dan

5 8

Re: winex11.drv: GetDeviceCaps(hdc, NUMCOLORS) must return 1 (not -1) if more than 256 colors. Bug 7757
by James Hawkins March 20, 2007

March 20, 2007

On 3/18/07, Daniel Mario Vega <dv5a(a)dc.uba.ar> wrote: > --- > dlls/winex11.drv/init.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/winex11.drv/init.c b/dlls/winex11.drv/init.c > index cf23866..a60174d 100644 > --- a/dlls/winex11.drv/init.c > +++ b/dlls/winex11.drv/init.c > @@ -213,8 +213,8 @@ INT X11DRV_GetDeviceCaps( X11DRV_PDEVICE *physDev, INT cap ) > case NUMCOLORS: > /* MSDN: Number of entries in the device's color table, if the device has > * a color depth of no more than 8 bits per pixel.For devices with greater > - * color depths, -1 is returned. */ > - return (screen_depth > 8) ? -1 : (1 << screen_depth); > + * color depths, 1 is returned. */ > + return (screen_depth > 8) ? 1 : (1 << screen_depth); > case PDEVICESIZE: > return sizeof(X11DRV_PDEVICE); > case CURVECAPS: > -- > 1.4.4.4 > Please add a test case. -- James Hawkins

1 0

Being rude to users considered harmful
by Dan Kegel March 20, 2007

March 20, 2007

Now, I'm as much of a BOFH as anybody else. Maybe more. But when I see a Wine developer telling users things like "For me all VB apps have to go to /dev/null without exceptions!" or "It's a minor problem - leave with it or fix it yourself!" I feel quite sad. Can we agree to be a bit more civil with the people who file bugs in bugzilla? Thanks... - Dan

4 3

Menu builder fix found
by Tom Spear March 20, 2007

March 20, 2007

http://bugs.winehq.org/show_bug.cgi?id=7802 Basically all that should be done (and I dont know why this isnt done anyways) is to have wine (or more likely wineprefixcreate) make ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu and ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu/Programs .... Then also make winecfg _not_ default to creating ~/.wine/dosdevices/c:/windows/profiles/(user)/Desktop as a symlink to ~/Desktop.. This can be verified by starting with a clean .wine dir and clean ~/.wine/dosdevices/c: and running wineprefixcreate .. Then run winecfg and make sure to uncheck the Link to box for the Desktop shell folder in the Desktop Integration tab and apply the change. Then manually make ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu and ~/.wine/dosdevices/c:/windows/profiles/(user)/Start\ Menu/Programs Then get the winrar installer and run it. Check all of the shortcut creation boxes after the install is finished. Then check the above mentioned folders. While I'm at it though I should mention that I have seen several installers fail if they can't find ~/.wine/dosdevices/c:/windows/system32 because for some reason wine doesn't create it either, not even as a symlink. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

RSTs from winehq.org
by Juan Lang March 20, 2007

March 20, 2007

Anyone else getting lots of TCP resets from winehq.org since the maintenance? I don't see this at work - or, my connection there is too fast connection for them to appear - but at home, I have to have a great deal of patience to browse the site, as it takes repeated reloads to get a successful page load. Just curious if anyone else is similarly bedeviled. --Juan ____________________________________________________________________________________ Now that's room service! Choose from over 150,000 hotels in 45,000 destinations on Yahoo! Travel to find your fit. http://farechase.yahoo.com/promo-generic-14795097

4 7

Re: Moved detection of float texture formats higher up so they are checked before
by H. Verbeet March 20, 2007

March 20, 2007

On 20/03/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > > the base formats. This is required to get the Blobs Direct3D demo to start. > --- > dlls/wined3d/directx.c | 33 +++++++++++++++------------------ > 1 files changed, 15 insertions(+), 18 deletions(-) > This looks questionable. By lack of a description in the patch, I'll assume it fails because it's checking with render target usage. If that's the case, you should fix that block, not move the float formats check up.

1 0

re: On bugs and docs
by Dan Kegel March 19, 2007

March 19, 2007

Tom wrote: > Basically my idea was to make several tasklists to link to 1434 (bugs >like dinput9, d3d8, etc), and then link individual games to each of >those, so that someone working on games, and in specific on dinput9 >for example could easily find bugs related to dinput 9 without having >to do a query. But now I am worried that I am overstepping my bounds >by trying to do so. Does anyone _else_ object to this idea? I do worry that that'll be a bit too spammy, given how bugzilla works. I'd say "Ask the directX maintainers what they suggest." Maybe they're happy with the way things are, or maybe they'll describe a different problem you can help with. - Dan

1 0

Re: Resend: Add d3drmdef.h header file - try 3
by Francois Gouget March 19, 2007

March 19, 2007

On Mon, 19 Mar 2007, Vijay Kiran Kamuju wrote: [...] > Add minimalistic d3drmdef.h [...] Something I just noticed: +#include "d3dtypes.h" This should be: #include <d3dtypes.h> If I remember correctly it's important in the public headers for compiling Winelib in some circumstances. (I'm not saying this is why it's been dropped before) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ tcA thgirypoC muinelliM latigiD eht detaloiv tsuj evah uoY

1 0

WineHQ maintainance
by Jeremy Newman March 19, 2007

March 19, 2007

WineHQ will be offline starting at 13:00 CST. It could be offline for up to an hour, hopefully not longer. I will be replacing the system board at this time. All email will be queued at the backup MX during the downtime. -newman

1 0

appdb trouble?
by Dan Kegel March 19, 2007

March 19, 2007

I tried submitting a few real apps, with real test data, to the appdb recently, but they haven't shown up. For instance, haoi. (See http://bugs.winehq.org/show_bug.cgi?id=7690) Does the appdb not like me? I'm flying blind because my email filters are a bit screwy, and automatic email from appdb to dank(a)kegel.com is dropped. (I've *got* to fix that sometime...) Thanks, Dan

3 2

Re: MikoÅ,aj Zalewski : user32: tests:Using DefWindowProcA with RegisterClassW works under Windows.
by Dmitry Timoshkov March 19, 2007

March 19, 2007

"Alexandre Julliard" <julliard(a)wine.codeweavers.com> wrote: > Author: Mikolaj Zalewski <mikolaj(a)zalewski.pl> > Date: Sun Mar 18 13:02:04 2007 +0100 > > user32: tests: Using DefWindowProcA with RegisterClassW works under Windows. The test doesn't pass here under XP: class.c:602: Test failed: Wrong ANSI wndproc: FFFF0367 vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: FFFF036B vs 00403B14 class.c:602: Test failed: Wrong ANSI wndproc: FFFF0367 vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: FFFF036B vs 00403B14 class.c:617: Test failed: Wrong Unicode wndproc: 00403B14 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: 00403B14 vs 00403ACC class.c:602: Test failed: Wrong ANSI wndproc: 00403ACC vs 00403B14 class.c:604: Test failed: Wrong ANSI wndproc: 00403ACC vs 00403B14 class.c:617: Test failed: Wrong Unicode wndproc: FFFF0367 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: FFFF036B vs 00403ACC class.c:617: Test failed: Wrong Unicode wndproc: FFFF0367 vs 00403ACC class.c:619: Test failed: Wrong Unicode wndproc: FFFF036B vs 00403ACC class: 590 tests executed (0 marked as todo, 12 failures), 0 skipped. -- Dmitry.

2 1

Prompts on what to do next after an install
by Tom Spear March 19, 2007

March 19, 2007

I just came across another idea that might be nice, and would be trivial to accomplish After running ./configure the configure script tells you to run make depends && make After that, there is nothing telling you what to do.. Obviously most users can figure out to run make install, but it would be nice to have a prompt to say "Now it is time to install wine by running 'make install' as root" Then after that is complete, and this is where I always forget, a prompt to run wineprefixcreate and winecfg would be nice, because that seems to cause several duplicate and unnecessary bugs to be filed. Obviously the user should read documentation, but once you have read it you generally dont tend to read it again, and might forget something. I forget to run both wineprefixcreate and winecfg nearly every time I do a clean reinstall of wine because it isnt part of a normal build routine for most linux apps to have to do this.. I could write up patches for this but I'm taking off for the weekend and wont have access to my linux machine till monday morning, and also I dont know enough about automake and autoconf to be able to write that stuff in. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 3

Re: [ws2_32] in some cases send should block until the entire buffer is sent
by Alexandre Julliard March 19, 2007

March 19, 2007

"Damjan Jovanovic" <damjan.jov(a)gmail.com> writes: > + } > + else > + skip("CreateThread failed, error %d\n", GetLastError()); > + closesocket(dst); > + } > + else > + skip("accept failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("connect failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("listen failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("getsockname failed, error %d\n", WSAGetLastError()); > + } > + else > + skip("bind failed, error %d\n", WSAGetLastError()); > + closesocket(server); > + } > + else > + skip("creating socket failed, error %d\n", WSAGetLastError()); > + closesocket(src); > + } > + else > + skip("creating socket failed, error %d\n", WSAGetLastError()); This isn't an appropriate use of skip(), these things are not supposed to fail, and if they do something is broken. You should use ok() here. And please avoid the ugly nested ifs, use return or goto end. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: netapi32: Add test for adding/deleting users.
by Robert Shearman March 19, 2007

March 19, 2007

Kai Blin wrote: > + ret = pNetUserAdd(NULL, 1, (LPBYTE)&usri, NULL); > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Insufficient permissions to add users. Skipping test.\n"); > + return; > + } > + if(ret == NERR_UserExists) > + { > + skip("User already exists, skipping test to not mess up the system\n"); > + return; > + } > + > + ok(ret == NERR_Success, "Adding user failed with error 0x%08x\n", ret); > + if(ret != NERR_Success) > + { > + skip("As adding the user failed, skip the change password and userdel " > + "tests\n"); > + return; > + } > The skip here is pointless. The test failure will already signal that something unexpected happened. > + > + ret = pNetUserChangePassword(NULL, sTestUserName, sTestUserOldPass, > + sTestUserNewPass); > + > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Insufficient permissions to change password, skipping test.\n"); > + } > + else > + { > + todo_wine ok(ret == NERR_Success, "Changing the password failed.\n"); > + } > + > + ret = pNetUserDel(NULL, sTestUserName); > + > + if(ret == ERROR_ACCESS_DENIED) > + { > + skip("Failed to delete user. You need to manually delete the user.\n"); > + } > + else > + { > + todo_wine ok(ret == NERR_Success, "Deleting the user failed.\n"); > + } > +} > I think it is reasonable to assume that if the user add the rights to add a user then they will have the rights to change the password and to delete it, so the skip statements seem unnecessary. -- Rob Shearman

1 0

GSoC Idea
by Cye Stoner March 19, 2007

March 19, 2007

Hello, My name is Cye Stoner. I was considering submitting the development of a WinePluginApi (as described at http://wiki.winehq.org/WinePluginApi) to Google's Summer of Code this year. I was also hoping that anybody able to mentor me on this project would contact me regarding the proposal, so that I can have a bit of an idea what I'd be getting myself into. mike at plan99.net submitted the idea in april of 2005, but I don't know if he would still be the one most useful in the area. Thank you for your time, Cye

2 1

Re: wined3d: Fix struct size calculation in EnumTextureFormats
by Stefan Dösinger March 19, 2007

March 19, 2007

Am Samstag 17 März 2007 23:22 schrieb A C Hurst: > Fixes the calculation of a struct size in > IDirect3DDeviceImpl_2_EnumTextureFormats, and fixes bug 7061. > > >>From 3f08264567229ff6a23b2cf311a18ee013c86152 Mon Sep 17 00:00:00 2001 > > From: ahurst <ahurst(a)hurstmachine.(none)> > Date: Sat, 17 Mar 2007 22:17:18 +0000 > Subject: Fis struct size calculation in EnumTextureFormats Looks OK to me :-)

3 2

more winetricks
by Dan Kegel March 19, 2007

March 19, 2007

For the record, I consider the need for winetricks a bug in wine. Someday we'll figure out how to make apps install properly without it. In the meantime, I've uploaded a new version to http://kegel.com/wine/winetricks And, as befits such an advanced tool, I'm keeping a revision history in the highly advanced "rcs" revision control system (that's a joke, btw). Here's the history so far: revision 1.4 date: 2007/03/19 00:54:01; author: dank; state: Exp; lines: +30 -3 Add mdac2.8. Echo a message when finished. Obey WINEPREFIXCREATE. ---------------------------- revision 1.3 date: 2007/03/19 00:44:03; author: dank; state: Exp; lines: +40 -20 Bring back and shorten wsh56 variants Make -q quieter Make default a bit chattier Override odbc32 and odbccp32 when installing mdac Make error checking advisory for now Avoid bash-specific "if foo; then" ---------------------------- revision 1.2 date: 2007/03/19 00:40:38; author: dank; state: Exp; lines: +33 -9 Added error checking, gdiplus -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Failure of Wine to quit when a program ends.
by gslink March 18, 2007

March 18, 2007

Recently my customer replaced her version of Wine with the current version. One of the programs running there, DeScribe, appears to quit normally but doesn't terminate. It continues to be in the background using no cpu time. To get rid of it requires killing the program with System Monitor as there is no evidence on the screen that the program is running. This appears to be a regression in Wine which has happened in the last nine months. Has anyone else had this happen with any other program? I am trying to track the exact problem and knowing that other programs behave this way would help.

1 0

Hey all!!
by Stephan Rose March 18, 2007

March 18, 2007

Ok guys, something's gotta change. I gotta stop logging into MS Sloth to play Supreme Commander ;) So that said, what can I do, where can I help? =) To give a little info on my background, I've been programming for roughly 10 years now...everything ranging from embedded & microcontroller stuff (PIC / ARM) to high end MS Sloth Applications. Familiar with DirectX, OpenGL, C/C++, C#, x86/ARM/PIC Assembly... I am of course unfamiliar with the whole wine source code. I did look over the rather daunting to-do list and wouldn't even know where to start. =) So I figured I'd send an e-mail out and see if anyone has any good suggestions. =) I'd really love to help with this. I for one think it's a great project and XP has really got to stop taking up one of my precious hard drives... Thanks =) Stephan Rose

3 2

Thanks everyone!
by Stephan Rose March 18, 2007

March 18, 2007

Thank you very much for your e-mails and suggestions everyone, I highly appreciate it. =) I am actually playing with debugging Supreme Commander right now a little bit and one thing popped into my eyes instantly. The problem that is occurring at the moment is that the installer won't even fully go through. So I am not even at the point of trying to install it yet. It'll go very far but near the end it will die with an error 87 from Install Shield. The very first thing that popped into my eyes though when running the installer was this: fixme:process:IsWow64Process (0xffffffff 0x34d90c) stub! That gets called literally hundreds of times. That makes seeing other error messages difficult for one as it just drowns them out and also slows the installer to a crawl. What I am wondering though is this, is running under Wow64 something that is ever actually going to happen within wine? Because if it's not, then the function actually already does everything it will ever need to do as far as I can tell by reading the documentation for it on MSDN.com For the time being, I commented the fixme line out in the code so that I can actually see other messages more easily and get to the failure point of the installer much quicker. Stephan

2 1

Re: wined3d: Replace inline static with static inline
by Ivan Gyurdiev March 17, 2007

March 17, 2007

Why should "inline static" be replaced with "static inline". Does it improve compatibility with certain compilers? Also, does wine aim to be compliant with ANSI, C99, or somewhere in between (-gnu89)?

2 1

Bug [219] questions
by Vitaliy Margolen March 17, 2007

March 17, 2007

I think people still having lots and lots of questions about why safedisc support is still not in Wine: > ------- Additional Comments From Speeddymon 2007-16-03 14:37 ------- > I think the problem (as is with most times a safedisc patch has been written) is > that the patch is either way too hacky, or is made by reverse engineering the > safedisc dll's from windows.. Most likely Ivan did not reverse the dll's as I > know he would not want to poison the tree, so my bet is that it is just too big > of a hack for Alexandre to commit, combined with the fact that it is nearly > impossible to break something like this up into smaller patches without > completely breaking everything. Can we get the "official" view on this? I'm tired of answering this sort of questions myself not knowing the exact reasoning behind. I know that there were plenty of "hacks" but there were number of reasonable pieces that could have been committed. Allowing other people continue work and improving upon. Also can we close that bug as LATER since Alexandre commented it will not be fixed until after 1.0? Vitaliy.

2 2

re: Hey all!!!!
by Dan Kegel March 17, 2007

March 17, 2007

Stepha wrote: >To give a little info on my background, I've been programming for >roughly 10 years now...everything ranging from embedded & >microcontroller stuff (PIC / ARM) to high end MS Sloth Applications. > >Familiar with DirectX, OpenGL, C/C++, C#, x86/ARM/PIC Assembly... > >I am of course unfamiliar with the whole wine source code. >I did look over the rather daunting to-do list and wouldn't >even know where to start. =) I would suggest starting by doing a couple weeks of bug triage. See http://kegel.com/wine/qa/ Then, while still doing bug triage, start writing conformance tests to expose some of the bugs you're seeing. Getting conformance tests committed to the WineHQ tree is a good rite of passage :-) Then, once you have the hang of that, pick one of the bugs you've written a good conformance test for, and try to fix it. Have fun & stay in touch! - Dan

1 0

Re: [2/3] comctl32: Never draw item text with OPAQUE.
by Felix Nawothnig March 17, 2007

March 17, 2007

(CCing wine-devel again) Dimi Paun wrote: >>Problem is that DrawText() for the subitems will also use the >>background color - which is wrong. > Why is it wrong? Because the "background color" isn't the background color of the list. And it's definitly not the text bkclr in gdi-context either - I hacked together an app to prove that: http://flexo.popuserv.org/test.c Now it seems getting rid of the OPAQUE completly is wrong, but for different reasons. > It seems to me that this is a bit of a problem: > > 3783 if (nSubItem == 0 || (cdmode & CDRF_NOTIFYITEMDRAW)) > 3784 prepaint_setup(infoPtr, hdc, &nmlvcd); > 3785 > 3786 /* in full row select, subitems, will just use main item's colors */ > 3787 if (nSubItem && uView == LVS_REPORT && (infoPtr->dwLvExStyle & LVS_EX_FULLROWSELECT)) > 3788 nmlvcd.clrTextBk = CLR_NONE; > > I guess the call to prepaint_setup should come _after_ the if > with FULLROWSELECT, no? Depends. Right now this code does nothing (and I was going to remove it anyway) - the only place where clrTextBk is read from is in prepaint_setup() - but prepaint_setup() is not called for subitems (and the CLR_NONE override is only done for subitems). > Also, I can't remember, but there was a reason why prepain_setup > was called just for the main item, why did you changed that? Because subitems can use different colors (see test app) and prepaint_setup() is where the colors are set up... Note that I don't change the notifications being passed or anything of their context (with the exception of the GDI context in the postpaint notification - but the GDI context should be saved & restored in between anyway, see the failing test I commited a few days ago) so I can't imagine how this could break anything. Felix

2 2

Re: This patch fixes bugzilla bug number 1001
by Dmitry Timoshkov March 17, 2007

March 17, 2007

"Giles Cameron" <giles(a)gilesfreeserv.com> wrote: > +#define STATUS_DISCONNECTED ((NTSTATUS) 0x00000037) > +#define STATUS_NONEXISTENT_NET_NAME ((NTSTATUS) 0x00000037) > +#define STATUS_ENDPOINT_CLOSED ((NTSTATUS) 0x00000037) These defines don't look like proper status values, where did you find them from? -- Dmitry.

2 1