March 2007 - Wine-Devel - list.winehq.org

Re: comctl32: register all the controls in DllMain (fixes bug #7641)
by Felix Nawothnig March 15, 2007

March 15, 2007

Mikołaj Zalewski wrote: > comctl32 version 5.82 (at least the one that comes with a fully patched > Windows XP) and 6.0 register all the controls in DllMain. > InitCommonControlsEx is just a dummy function. Could it be that 6.0 only registers those controls listed using window class dependencies in the manifest file? If what you say about 5.82 is true your patch is correct though ofcourse. Felix

2 1

Help with debug
by Phil Lodwick March 15, 2007

March 15, 2007

Hi, I have been debugging a problem today and am running low on batteries. I am hoping somebody can look at the attached snippet of log and point me in the right direction. >From what I can tell, there is a DLL called snoopy.dll that does a whole bunch of allocs and reallocs and then tries to reference a NULL pointer which causes an unhandled exception. The code goes through a loop and does not always crash on the same iteration, but it always seems to crash at the same address. This code does not crash on Windows. Just getting lucky? Unfortunately I do not have the sources to this code, so it makes life a little more difficult. Any good ideas for my next step in debugging? Thanks, Phil

2 1

Re: Submitting winetricks to winehq tree?
by Dan Kegel March 15, 2007

March 15, 2007

Carl-Daniel wrote: > Sorry if this has been answered before, but is winetricks a newer > version of winetools? No. Winetricks (http://www.kegel.com/wine/winetricks ) is a single 11KB shell script. It's a tiny command line tool that only knows how to install Microsoft redistributable libraries (and fonts), and set a registry key or two. For instance, if you're trying to install or run an application, but it fails with "import_dll Library MSVBVM60.DLL not found", you can fix it with $ winetricks vbrun60 Or if you're trying to install an app, but it fails with "Sorry, this application requires IE6", you can fix it without really installing IE6 by setting the right registry key. Winetricks makes this easy; just do $ winetricks fakeie6 etc. etc. Essentially, Winetricks just automates things one would normally have to look up in the Wine wiki, and it does it in the simplest possible way. Winetools ( http://www.von-thadden.de/Joachim/WineTools/ ) can do some of that, but it's really a different beast. It's a set of 150 or so files with a fancy GUI. Each of the files is a recipe for installing a particular Windows application. It is aimed at people who just want to run apps and not understand things. It is bad because, instead of working to improve Wine to make apps easy to install, it papers over the problems. And then there's Wine-Doors ( http://www.wine-doors.org ), which is like Winetools with delusions of grandeur. They seem to want to reinvent apt-get for no particular reason, and as far as I can tell, they intend to have a central server from which you can download copies of e.g. Photoshop with it. This doesn't seem legal, offhand, but I can't find their mailing list archive to see if anyone has asked them about this fine point. IMHO both Winetools and Wine Doors are mostly harmful, but they do have a real benefit for users. Winetricks is a bit like the non-harmful 1% of Winetools. If we don't provide something like Winetricks, more people might be driven to Winetools, and it'd be nice to prevent that. - Dan

2 1

Re: [2/3] kernel32: GlobalMemoryStatusEx: return the size of physicalmemory + swapsize in ullTotalPageFile/ullAvailPageFile
by Dmitry Timoshkov March 14, 2007

March 14, 2007

"Fabian Bieler" <der.fabe(a)gmx.net> wrote: > - /* Project2k refuses to start if it sees less than 1Mb of free swap */ > - if (lpmemex->ullTotalPageFile < lpmemex->ullTotalPhys) > - lpmemex->ullTotalPageFile = lpmemex->ullTotalPhys; > - if (lpmemex->ullAvailPageFile < lpmemex->ullAvailPhys) > - lpmemex->ullAvailPageFile = lpmemex->ullAvailPhys; > + /* Win98 returns only the swapsize in ullTotalPageFile/ullAvailPageFile, > + WinXP returns the size of physical memory + swapsize; > + mimic the behavior of XP: > + */ > + lpmemex->ullTotalPageFile += lpmemex->ullTotalPhys; > + lpmemex->ullAvailPageFile += lpmemex->ullAvailPhys; Why did you remove a comment about Project2k? It helps to understand what are the constrains of the API, and helps to avoid chasing the same bug once again. -- Dmitry.

1 0

Submitting winetricks to winehq tree?
by Dan Kegel March 14, 2007

March 14, 2007

I haven't been villified yet, so let me try harder. Should winetricks be committed to the winehq tree? It would be handy for people triaging Wine bugs to see if e.g. native dcom, odbc, or corefonts hide a bug. I've uploaded a new version to http://kegel.com/wine/winetricks Mainly it adds a -q option to make all the installers quiet, but it also includes lots of little improvements sent in by Detlef and Saulius. Here's the new usage message: Usage: winetricks [options] package [package] ... This script can help you prepare your system for Windows applications that mistakenly assume all users' systems have all the needed redistributable runtime libraries or fonts. Options: -q quiet. You must have already agreed to the EULAs. -v Verbose Packages: art2kmin Access 2000 runtime. License required! corefonts Install MS Times, Arial fonts dcom98 Install native DCOM, override the Wine implementation fakeie6 Set registry to claim IE6sp1 is installed mdac27 Microsoft ODBC drivers, etc. mfc40 mono1.1 mono 1.1.13-gtksharp-2.8.2 mono1.2 mono 1.2.3.1-gtksharp-2.8.3 vbvm50 Visual Basic 5 runtime vbrun60 Visual Basic 6 runtime vcrun6 vc6redist from VS6sp4, including mfc42 wsh51 Windows Scripting Host 5.1

5 4

Re: Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.
by Eric Pouech March 14, 2007

March 14, 2007

Robert Shearman a écrit : > > The old behaviour can be turned back on by setting the V environment > variable to "1" (e.g. make V=1). a couple of more comments (mostly not yet converted rules): - the MAKEDEP rule in Make.rules.in isn't handled yet (suggestion [DEPEND] $SRC(DIR)) - most of exec rule in tools/*/Makefile.in miss the MAKERULE stuff - ditto in loader (and the version-stamp could be handled too) - in dlls/Makedlls.rules.in, all lib/def/.a stuff isn't handled is there any reason why the Linking... rule has a different format than the others ? now I wish we could also get rid of the message for recursive calls to make A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: [advapi32/tests 1/2] Use GetModuleHandle and skip
by Francois Gouget March 14, 2007

March 14, 2007

On Tue, 13 Mar 2007, Paul Vriens wrote: [...] > as advapi32 is already linked to, we can use GetModuleHandle. - if (!(module = LoadLibrary( "advapi32.dll" ))) return; + if (!(module = GetModuleHandleA( "advapi32.dll" ))) return; Well, since we're already linked to advapi32.dll, there's no need to check that GetModuleHandleA() does not return NULL. Plus if we were to check we should use skip(). -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ May your Tongue stick to the Roof of your Mouth with the Force of a Thousand Caramels.

2 1

A SoC proposal for discussion: PE Packers
by Julien March 14, 2007

March 14, 2007

Hello all, I didn't find a webpage on the wiki about SoC'07. However, I would like to suggest a SoC proposal for your comments. It seems to me that there are many bugs floating in bugzilla that are related to PE packers. Because applications just crash due to being packed, this seems a requirement for Wine 1.0. For a SoC, it would be very interesting if one student takes the mission of fixing bugs related to PE packers such as: - Shrinker (#2608, #2619) - Neolite (seems ok see #4709) - Aspack (#6129) - Armadillo (#219) This would require to define the list of PE packers to support and which versions (as anti debugging tricks may differ depending of the version). Best, Julien

2 1

Re: Add very basic initial tests for d3drm
by Dmitry Timoshkov March 14, 2007

March 14, 2007

"Vijay Kiran Kamuju" <infyquest(a)gmail.com> wrote: > +START_TEST(vector) > +{ > + init_function_pointers(); > + > + VectorTest(); > + QuaternionTest(); What happens if init_function_pointers() failed? -- Dmitry.

2 1

Re: Alexandre Julliard : ntdll: Add a wrapper to call the thread entry point for broken apps.
by Ken Thomases March 14, 2007

March 14, 2007

On Mar 14, 2007, at 7:25 AM, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 7744443febb04213cf014b007a83744a66544d6c > URL: http://source.winehq.org/git/wine.git/? > a=commit;h=7744443febb04213cf014b007a83744a66544d6c > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Wed Mar 14 12:28:38 2007 +0100 > > ntdll: Add a wrapper to call the thread entry point for broken apps. > > --- > > dlls/ntdll/thread.c | 25 ++++++++++++++++++++++--- > 1 files changed, 22 insertions(+), 3 deletions(-) > > diff --git a/dlls/ntdll/thread.c b/dlls/ntdll/thread.c > index 9656331..d0871a1 100644 > --- a/dlls/ntdll/thread.c > +++ b/dlls/ntdll/thread.c > @@ -349,6 +349,26 @@ static PUNHANDLED_EXCEPTION_FILTER > get_unhandled_exception_filter(void) > return unhandled_exception_filter; > } > > +#ifdef __i386__ > +/* wrapper for apps that don't declare the thread function > correctly */ > +extern DWORD call_thread_entry_point( PRTL_THREAD_START_ROUTINE > entry, void *arg ); > +__ASM_GLOBAL_FUNC(call_thread_entry_point, > + "pushl %ebp\n\t" > + "movl %esp,%ebp\n\t" > + "subl $4,%esp\n\t" > + "pushl 12(%ebp)\n\t" > + "movl 8(%ebp),%eax\n\t" > + "call *%eax\n\t" > + "leave\n\t" > + "ret" ); > +#else > +static inline DWORD call_thread_entry_point > ( PRTL_THREAD_START_ROUTINE entry, void *arg ) > +{ > + LPTHREAD_START_ROUTINE func = (LPTHREAD_START_ROUTINE)rtl_func; Should the above have "entry" instead of "rtl_func"? > + return func( arg ); > +} > +#endif > + > / > ********************************************************************** > * > * call_thread_func > * > @@ -356,16 +376,15 @@ static PUNHANDLED_EXCEPTION_FILTER > get_unhandled_exception_filter(void) > */ > static void DECLSPEC_NORETURN call_thread_func > ( PRTL_THREAD_START_ROUTINE rtl_func, void *arg ) > { > - LPTHREAD_START_ROUTINE func = (LPTHREAD_START_ROUTINE)rtl_func; > DWORD exit_code; > BOOL last; > > MODULE_DllThreadAttach( NULL ); > > if (TRACE_ON(relay)) > - DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", > GetCurrentThreadId(), func, arg ); > + DPRINTF( "%04x:Starting thread proc %p (arg=%p)\n", > GetCurrentThreadId(), rtl_func, arg ); > > - exit_code = func( arg ); > + exit_code = call_thread_entry_point( rtl_func, arg ); > > /* send the exit code to the server */ > SERVER_START_REQ( terminate_thread ) > > >

2 1

DirectX 10 start as a SoC project?
by Kovács András March 13, 2007

March 13, 2007

Hi, I think, that start working on Dx10 is a great opportunity to learn about wined3d, and Microsoft's new platform. I would like to apply, because i want to contribute to open source projects, and i'm really interested in wine, especially in wined3d. I have some patches in the tree, and I really would like to work on together. Best Regards, Andras kovacs -- ------------------ andras NetClub Lamarr csevego.net andras(a)csevego.net ------------------

4 3

HtmlHelp status, winecfg and SoC proposal
by Jacek Caban March 13, 2007

March 13, 2007

Hello. As you may have noticed, I've been working on HtmlHelp lately. Currently it should generally work, but still there is a lot to do. HTML should be correctly displayed and content tab should work. I was thinking about making more use of it in Wine. I think winecfg could benefit from it. We could easily add context help to winecfg using HtmlHelp API. Even just integrating a part of Wine User's Guide would be a good start. The main problem is building chm file (that is the file format of HtmlHelp). Microsoft has a HtmlHelp compiler (hhc) for it. We'd need something similar in Wine. AFAIK there is no good open source replacement. HtmlHelp maker (hhc, see [1]) doesn't create internal files (parts of chm that describes stuff like index or default topic) and it's GPLed so it's useless for Wine (unless author would relicense it for us). I think it would be a good project for Google Summer of Code. The task would be to write a hhc replacement and add a help option to winecfg. hhc replacement (say whhc) would have to be a plain UNIX tool (it means a bit of code duplication with itss.dll, just like we do in widl) so we could use it during compilation. I think its difficulty is good for SoC. Compressing code may be integrated from some other project. The remaining parts are code of parser of files describing chm and a little winecfg hacking. What do you think? Jacek [1] http://savannah.nongnu.org/projects/hhm

4 5

Re: wined3d: Allow SetCursorProperties on existing cursor
by Stefan Dösinger March 13, 2007

March 13, 2007

Am Dienstag 13 März 2007 03:44 schrieb Erich Hoover: > Real Name: > Erich Hoover > Changelog: > wined3d: Allow SetCursorProperties on existing cursor Looks good to me, except one cosmetic issue: if(pCursorBitmap) { + WINED3DLOCKED_RECT rect; +......... /* MSDN: Cursor must be A8R8G8B8 */ You are adding trailing whitespaces here. I think git or AJs filters filter them out, but they tend causing merging problems for me if my patches contain some of them.

1 0

My plans for SOC
by Maarten Lankhorst March 13, 2007

March 13, 2007

For the summer of code I'm planning to improve the dsound code and alsa code, to make alsa finally better then OSS, in a way that has a will get accepted into the wine tree, for that I'm thinking of improving on the following fronts: Winealsa: - Add mixer device and aux controls - Implement dsound capture - Seperate the initialisation of the directsound code from the waveout code, to allow creation of multiple dmix devices. - Try to configure alsa to allow arbitrarily big buffers, working around the alsa problem that only up to a certain amount can be allocated for buffers, certain programs (for example winamp) may require more. - Remove the queuing thread and use Lock() and Unlock() instead. - Make it run so well, people wouldn't want to use OSS any more. Both dsound/winealsa: - Allow proper usage of Lock() and Unlock() for sound drivers, it's not used properly or even tested in current dsound code. - Rework some of the dsound code, to allow mixing to be done in winealsa, and fix possible errors that can be caused by it. - Improve the dsound software mixer code to allow mixing and (if possible) be less prone to buffer underruns. The challenge is to get this working right, without too much of an impact hit. I also will have to work around alsa limitations: I cannot make buffers arbitrarily big, while in windows they can be. It seems no 2 programs use dsound in the same way, so I will have to test with various different programs to get everything working. I'll try to get in contact with alsa-devel first, if there is a way to change buffer size to something arbitrary, it is worth it in the long run to use that method. A manual fix seems to be close everything using alsa, then echo 256 > /proc/asound/card0/pcm0p/sub0/prealloc, but I am hoping there is an easier way to fix it, in either case I am afraid I will have to put some memory buffer code in winealsa as fallback. If there's still some time left, I'll also try to get some 3d sound code in, using some openal code, the license seems to be lgpl compatible, or I will try to get support for multiple (4, 5.1 ?) speakers working, it depends a little on how fast I can get this to work in a nice shape. Looking for feedback. Cheers, Maarten

4 3

re: Want to be a Wine mentor for Google Summer of Code 2007?
by Dan Kegel March 13, 2007

March 13, 2007

Jeremy wrote: > Say, we (the Wine project) seem to be increasingly leaning on you > to run Wine's SoC program. In the early days, we had a committee, > and people helping, and stuff. These days, I know that I am guilty > of thinking that you're on it, so I can safely ignore it; I fear > that a bunch of others of us may be doing the same. > > Are we letting you down? Do you need help? I'm fine this year, but considering how I missed the deadline (we were saved by LH's kindness), it would probably be a good idea to pick somebody else to be admin next year. The committee should probably just be the mentors plus you and Alexandre (if you/he are interested). - Dan

2 1

RE: some emails not arriving to wine-patches (was CMD.EXE resubmits)
by Ann & Jason Edmeades March 13, 2007

March 13, 2007

As an FYI I sent the same patchset to another email account (not on my ISP, just one of the free ones) and they all got through 4 times. It would start to point to the wine-patches side of things, but I have never seen anyone else have problems Note I am not seeing any rejection emails either Jason

3 2

Re: [0/9] CMD.EXE resubmits
by Alexander Nicolaysen Sørnes March 13, 2007

March 13, 2007

Tirsdag 13 mars 2007 22:03, skrev Ann & Jason Edmeades: > Resubmitting the patchset from yesterday having fixed up the > mallocs/reallocs/frees to HeapAllocs/HeapReAllocs/HeapFrees, and resolved > conflicts with those already committed. > > Note: I have been experimenting from sending the emails directly from "git > send-email", and this will be the first ones sent that way, so if there are > any problems please let me know > > Jason There does not seem to be a patch attached. Alexander N. Sørnes

2 2

Issue with GetTokenInformation?
by Paul Vriens March 13, 2007

March 13, 2007

Hi, As I'm still trying to get Process Explorer running perfectly, I've noticed that the usernames for the processes are not correct. The attached patch shows the issue. I'm not sure if this test-patch should go to wine-patches as I'm not sure my test is correct (or in the correct place). It succeeds on W2K3. Maybe someone more knowledgeable about the Token stuff could have a look? Cheers, Paul

1 0

Re: Makefiles: Be less verbose when performing make rules by only printing the command being executed and the source and/or target file.
by Eric Pouech March 13, 2007

March 13, 2007

Robert Shearman a écrit : > > The old behaviour can be turned back on by setting the VERBOSE > environment variable to "yes". > .s.o: > $(AS) -o $@ $< > > $(MODULE): $(OBJS) Makefile.in > - $(RM) $@ > - $(AR) $@ $(OBJS) > - $(RANLIB) $@ > + @$(RM) $@ > + @$(MAKERULE) '[AR] $@' $(AR) $@ $(OBJS) > + @$(MAKERULE) '[RANLIB] $@' $(RANLIB) $@ > we'll miss the echo for the $(RM) command in verbose mode IMO, we should use here something like @$(MAKERULE) '' $(RM)... and handle the empty $1 in makerule A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

1 0

Re: localspl: add Polish translation
by Jacek Caban March 13, 2007

March 13, 2007

Hi Mikołaj, Mikołaj Zalewski wrote: > + IDS_NOTHINGTOCONFIG "Ten port nie ma opcji, kt�re mo�na by skonfigurowa�" > +} > It doesn't sound good to me. How about "Ten port nie ma opcji do skonfigurowania" or just remove "by" from your version? Jacek

1 0

Re: shell32: update Polish translation
by Jacek Caban March 13, 2007

March 13, 2007

Hi Mikołaj, Mikołaj Zalewski wrote: > - IDS_OVERWRITEFOLDER_TEXT "This folder already contains a folder named '%1'.\n\n"\ > - "If the files in the destination folder have the same names as files in the\n"\ > - "selected folder they will be replaced. Do you still want to move or copy\n"\ > - "the folder?" > + IDS_OVERWRITEFOLDER_TEXT "Ten folder ju� zawiera folder o nazwie '%1'.\n\n"\ > + "Je�eli w docelowym folderze wyst�pi� pliki o takich zamych nazwach jak\n"\ > This is a typo, it should be "samych nazwach". Jacek

1 0

Re: wordpad: update Polish translation
by Jacek Caban March 13, 2007

March 13, 2007

Hi Mikołaj, Mikołaj Zalewski wrote: > + > +STRINGTABLE DISCARDABLE > +BEGIN > + STRING_RICHTEXT_FILES_RTF, "Tekst sformatowany - RTF (*.rtf)" > + STRING_TEXT_FILES_TXT, "Document tekstowy (*.txt)" This is a typo, it should be "Dokument". Jacek

1 0

Re: const cleanup round 1
by Eric Pouech March 13, 2007

March 13, 2007

Mike Schaadt a écrit : > string.c: > strtolW and strtoulW - constify the endptr value. This is just an > output value to indicate where in the array we stoped processing. > Change causes this to be the same type as the first value. Reduces > number of cast-qual warnings by 6. > > lnk.c: > dump_pidl > [line 176] - switched to const. Value is never modified in > the function. Removes a cast-qual warning. > > symbol.c: > symbol_clean_string - this function is modifying the string. This > should most definitly *not* be a const parameter. It's not even > logically const as the the intent of the function is to make the type > string Wine-friendly. That requires modifications to that string. > > ------------------------------------------------------------------------ > > diff --git a/include/wine/unicode.h b/include/wine/unicode.h > index 83a7d52..4e2caa5 100644 > --- a/include/wine/unicode.h > +++ b/include/wine/unicode.h > @@ -96,8 +96,8 @@ extern int strcmpiW( const WCHAR *str1, > extern int strncmpiW( const WCHAR *str1, const WCHAR *str2, int n ); > extern int memicmpW( const WCHAR *str1, const WCHAR *str2, int n ); > extern WCHAR *strstrW( const WCHAR *str, const WCHAR *sub ); > -extern long int strtolW( const WCHAR *nptr, WCHAR **endptr, int base ); > -extern unsigned long int strtoulW( const WCHAR *nptr, WCHAR **endptr, int base ); > +extern long int strtolW( const WCHAR *nptr, const WCHAR **endptr, int base ); > +extern unsigned long int strtoulW( const WCHAR *nptr, const WCHAR **endptr, int base ); > this is wrong as you want to be able to write code as: WCHAR* str; WCHAR* p; int val = strtolW(str, &p, 10); *p = '\0'; which your modification forbids (ANSI strtol doesn't have the const modifier for endptr) the rest of the patch looks ok -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

2 2

Re: Add casts to tools/makedep.c
by Dmitry Timoshkov March 13, 2007

March 13, 2007

"Gerald Pfeifer" <gerald(a)pfeifer.com> wrote: > I accidently ended up building Wine using a C++ compiler the other day, > and came across the following. > - char *p = xmalloc (size); > + char *p = (char*) xmalloc (size); That's a problem of C++ not Wine if it can't cope with casting void * to another pointer type. Polluting the whole source with useless casts buys us nothing. -- Dmitry.

2 1

Re: winedbg: Support longer thread names
by Eric Pouech March 13, 2007

March 13, 2007

Erich Hoover a écrit : > Real Name: > Erich Hoover > Description: > The thread name length in winedbg is currently restricted to 9 > characters, this is not nearly long enough for debugging threads in > the Supreme Commander demo and results in character corruption on the > terminal. Since this particular application names one of the threads > with the map path (Map loader /maps/scmp_019/scmp_019.scmap), a > significant increase in the number of characters is necessary. This > patch ups the allowed thread name length to 100 characters and > null-terminates the string in case an application exceeds that > threshold value. > Changelog: > winedbg: Support longer thread names in that case, it would be better to dynamically allocate the string (and to create it by default at 5 bytes for the %04x value) furthermore, you need to change the comment in debugger.h in THREADNAME_INFO structure about the name's length, as it seems VC7 removed the restriction to 8 characters that existed in VC6 A+

2 2