March 2007 - Wine-Devel - list.winehq.org

Work legalities
by Juan Lang March 7, 2007

March 7, 2007

> I'm worried about the copyright of any external work I do, so I need a > little advice. > > What do I need from my employer to clear me to work on wine? > Is something verbal ok, or should I get it in writing? In the US, if you do the Wine work outside of your workplace, on your own time and with your own equipment, it should be okay. IANAL, but see e.g.: http://www.supnik.com/reid.htm --Juan

1 0

A Survey on Defect Management Practices in Free/Open Source Software
by anugupta＠pu.ac.in March 7, 2007

March 7, 2007

Dear Wine Contributors, I seek help from designers, developers, testers,defect fixers,project managers or playing any other key role in Free/Open Source software development or maintenence in carrying out a study to identify practices and problems of defect management in various Free/Open Source Software projects. The insights gained from the study can further help us to extract publicly accessible defect data and determine impact of defect management practices on software quality. Please spend a few minutes of your precious time to fill up the Questionnaire. The most of the questions follow multiple choice formats and are quite easy to answer. To have the Online Questionnaire, please visit: http://anu.puchd.ac.in/phpESP/public/survey.php?name=FOSS_Defect_Survey (You can also copy and paste this link into your browser, and hit the 'Return' key.) I hope you will find all the questions interesting and thought-provoking. Your answers will be kept anonymous.The data thus collected will only be used for research purpose.It would be nice if you may further refer this mail to others actively engaged with Free/Open Source Software development. If you have any query or suggestions then feel free to contact. Thank You With regards, Anu Gupta Senior Lecturer Department of Computer Science and Applications, Panjab University, Chandigarh. INDIA In case of any problem in accessing/using the above mentioned link please contact: E-mail: anugupta(a)pu.ac.in anugupta98(a)gmail.com

1 0

[winealsa] Mind buffer loops when pausing
by Chris Bandy March 7, 2007

March 7, 2007

This patch should fix the incorrect handling of WaveHdr loops when pausing. Like the non-loop case written before, this sums the buffer lengths between dwPlayedTotal and dwWrittenTotal to calculate the new dwPartialOffset. Instead of blindly moving from one buffer to the next, however, this traverses the list using BeginWaveHdr and PlayPtrNext. This has added benefit of correctly initializing all pointers and counters for playback. It looks correct on paper, but I don't seem to have any applications that even attempt to pause. Can anyone suggest an application to test this with? All feedback welcome. Note: this branch in the function is a 'software' pause. To test you may need to override the check for ALSA's hardware pause at line 418 (snd_pcm_hw_params_can_pause) -- Chris diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 6a8a435..4ac50c6 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -319,9 +319,9 @@ static DWORD wodPlayer_NotifyCompletions(WINE_WAVEDEV* wwo, BOOL force) * * wodPlayer helper. Resets current output stream. */ -static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) +static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) { - int err; + int err; TRACE("(%p)\n", wwo); /* flush all possible output */ @@ -329,7 +329,7 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) wodUpdatePlayedTotal(wwo, NULL); /* updates current notify list */ - wodPlayer_NotifyCompletions(wwo, FALSE); + wodPlayer_NotifyCompletions(wwo, reset); if ( (err = snd_pcm_drop(wwo->pcm)) < 0) { FIXME("flush: %s\n", snd_strerror(err)); @@ -345,9 +345,6 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) DWORD param; HANDLE ev; - /* remove any buffer */ - wodPlayer_NotifyCompletions(wwo, TRUE); - wwo->lpPlayPtr = wwo->lpQueuePtr = wwo->lpLoopPtr = NULL; wwo->state = WINE_WS_STOPPED; wwo->dwPlayedTotal = wwo->dwWrittenTotal = 0; @@ -368,32 +365,34 @@ static void wodPlayer_Reset(WINE_WAVEDEV* wwo, BOOL reset) ((LPWAVEHDR)param)->dwFlags &= ~WHDR_INQUEUE; ((LPWAVEHDR)param)->dwFlags |= WHDR_DONE; - wodNotifyClient(wwo, WOM_DONE, param, 0); + wodNotifyClient(wwo, WOM_DONE, param, 0); } ALSA_ResetRingMessage(&wwo->msgRing); LeaveCriticalSection(&wwo->msgRing.msg_crst); } else { - if (wwo->lpLoopPtr) { - /* complicated case, not handled yet (could imply modifying the loop counter */ - FIXME("Pausing while in loop isn't correctly handled yet, except strange results\n"); - wwo->lpPlayPtr = wwo->lpLoopPtr; - wwo->dwPartialOffset = 0; - wwo->dwWrittenTotal = wwo->dwPlayedTotal; /* this is wrong !!! */ - } else { - LPWAVEHDR ptr; - DWORD sz = wwo->dwPartialOffset; + DWORD diff = wwo->dwWrittenTotal - wwo->dwPlayedTotal; + DWORD sz; + + /* no pointers or counters need to change */ + if (diff <= wwo->dwPartialOffset) + wwo->dwPartialOffset -= diff; + else { + wwo->lpLoopPtr = NULL; + wodPlayer_BeginWaveHdr(wwo, wwo->lpQueuePtr); - /* reset all the data as if we had written only up to lpPlayedTotal bytes */ - /* compute the max size playable from lpQueuePtr */ - for (ptr = wwo->lpQueuePtr; ptr != wwo->lpPlayPtr; ptr = ptr->lpNext) { - sz += ptr->dwBufferLength; + diff -= wwo->dwPartialOffset; + sz = wwo->lpPlayPtr->dwBufferLength; + + while (sz < diff) { + wodPlayer_PlayPtrNext(wwo); + sz += wwo->lpPlayPtr->dwBufferLength; } - /* because the reset lpPlayPtr will be lpQueuePtr */ - if (wwo->dwWrittenTotal > wwo->dwPlayedTotal + sz) ERR("grin\n"); - wwo->dwPartialOffset = sz - (wwo->dwWrittenTotal - wwo->dwPlayedTotal); - wwo->dwWrittenTotal = wwo->dwPlayedTotal; - wwo->lpPlayPtr = wwo->lpQueuePtr; + + wwo->dwPartialOffset = sz - diff; + wodPlayer_BeginWaveHdr(wwo, wwo->lpQueuePtr); } + + wwo->dwWrittenTotal = wwo->dwPlayedTotal; wwo->state = WINE_WS_PAUSED; } }

1 0

Re: [3/4] WineD3D: Blit the offscreen texture into the drawable if needed
by Stefan Dösinger March 7, 2007

March 7, 2007

Am Mittwoch 07 März 2007 02:43 schrieb Stefan Dösinger: Do not apply this patch yet. Cube textures aren't that easy

1 0

App DB TOP-10 issue
by speedator＠gmx.de March 7, 2007

March 7, 2007

Hi, I want to annotate that there are apps/games twice in the Platinum List(Diablo II Lord of Destruction 1.x , Outlaws All versions) even thrice(if you add Diablo II 1.x and LoD up for such a list). Btw: Why are Outlaws and IDA Pro "top"? Doesn't seem they are so popular, nvm.

2 1

Re: [PATCH] DirectPlay should keep track of the current number of players
by Kai Blin March 7, 2007

March 7, 2007

On Tuesday 06 March 2007 23:25, Alessandro Pignotti wrote: > Hi everyone, > this patch fixes the behaviour of dplayx that was not adding new player to > its counter. I don't see a patch. Did you attach it? Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: comctl32: Implement LVS_EX_DOUBLEBUFFER
by Dimi Paun March 7, 2007

March 7, 2007

On Tue, March 6, 2007 16:27, Felix Nawothnig wrote: > Tested with utorrent - completly removes the flickering from #7344. > In case you're wondering about the change in EraseBkgnd() - this is how > native behaves, they recreate the double buffer on each refresh so we > need to move the erase. Please tell me if I broke anything. It looks good, but you don't cleanup the new DC if the bitmap creation fails. -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Re: [localspl/tests] Remove tempfile after running the tests
by Detlef Riekenberg March 6, 2007

March 6, 2007

On Di, 2007-03-06 at 18:47 +0100, Paul Vriens wrote: > We had a leftover file in the temp directory. > > Changelog > Remove tempfile after running the tests Ignore my prev. mail. I looked always in "c:\temp" and found the files in "c:\tmp" :-( Sorry for the noise. -- By by ... Detlef

1 0

Re: [localspl/tests] Remove tempfile after running the tests
by Detlef Riekenberg March 6, 2007

March 6, 2007

On Di, 2007-03-06 at 18:47 +0100, Paul Vriens wrote: > + > + /* Cleanup our temporary file */ > + DeleteFileW(tempfileW); Where / when did you see an undeleted File for this test? localspl_test.exe does not create a temporary file yet. -- By by ... Detlef

1 0

dll that just forward
by Luis Carlos Busquets Pérez March 6, 2007

March 6, 2007

Concerning dlls dpnaddr.dll dpnlobby.dll They both are dlls with just one function and that it is forwarded to dpnet.dll. I understand that this is just for compatibility reasons. If we add to the git tree these two spec files dlls/dpnaddr/dpnaddr.spec: stdcall DirectPlay8AddressCreate( ptr ptr ptr ) dpnet.DirectPlay8AddressCreate dlls/dpnlobby/dpnlobby.spec: stdcall DirectPlay8Create(ptr ptr ptr) dpnet.DirectPlay8Create Shouldn't these do to have both dlls implemented natively in wine? Do we need to add anymore code for dll functions which are just forwarded in windows?

2 1