April 2007 - Wine-Devel - list.winehq.org

re: Contributing money to WINE?
by Dan Kegel April 6, 2007

April 6, 2007

Tim wrote: >I find myself in a similar dilemma... What if a few of us banded >together and put a bounty on a feature / app, or contracted >codeweavers to implement it? I think that would be great. Assuming >we can agree on something we'd like to fund, it would be a little more >targeted than just voting in CW's appdb. Problem is, most of the things you might want to have fixed are pretty expensive. Let's say a bug takes ten days to fix. Assuming $100/hr (which is not far off for contract development), that's $8K right there. Lots of folks have thought about how to solve the problem, but dealing with money is complicated. It'd be better for you to donate time triaging bugs, IMHO. ( http://kegel.com/wine/qa/ ) Just reproduce one bugzilla entry a day for a week, and document what you find, and we'd be very happy!

2 1

Re: [resend] notepad: Improve printing considerably
by Alexandre Julliard April 6, 2007

April 6, 2007

"Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> writes: > Changelog > programs/notepad/dialog.c > programs/notepad/main.c > programs/notepad/main.h > Improve printing considerably That's not a very useful log message... Could you please describe a bit how it is improved? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: notepad: Improve printing considerably
by Dmitry Timoshkov April 6, 2007

April 6, 2007

"Rolf Kalbermatter" <r.kalbermatter(a)hccnet.nl> wrote: > +#include <tchar.h> What is this for? According to the Alexandre's comments we should convert all the Wine builtin apps to unicode intead of promoting usage of TCHAR that leads to a lot of trouble in multibyte locales, besides it looks like tchar.h is not used at all. -- Dmitry.

2 1

Using signals to turn logging on and off
by Dan Kegel April 6, 2007

April 6, 2007

I tried the patch in the wiki to control logging with f12, but it wasn't quite satisfying, because only one process has the keyboard, so you can only turn one process' logging on and off. This isn't so great if the process you're interested in never has the keyboard. (Like com servers started up during installers.) So I played around with using unix signals instead. And rather than having a signal toggle the enable status, I used one signal for enable and another for disable. The feature is only turned on if you set the WINEDEBUGSIG environment var. Problem is, all I can do is turn logging off; turning it on doesn't work for some reason. Feh. Can somebody spot what I did wrong? It's at http://kegel.com/wine/debugsig.patch It was monkey-see-monkey-do code, to some extent, so I wouldn't be surprised if there's an obvious problem. Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: notepad: Use the more explicitly UNICODE character type.
by Dmitry Timoshkov April 6, 2007

April 6, 2007

"Byeong-Sik Jeon" <wjsqudtlr(a)gmail.com> wrote: > Changelog: > Use the more explicitly UNICODE character type. Then you have to simultaneously explicitly start using unicode Win32 APIs. I'd suggest you to start with the application that presumably doesn't work properly in multibyte locales and which you already started to look at - regedit, and leave notepad alone until there are real problems discovered. -- Dmitry.

2 1

re: kernel32: Implement ReplaceFileA/ReplaceFileW (revised, resubmit)
by Dan Kegel April 6, 2007

April 6, 2007

Kudos for your persistance. I hope this makes it in soon. I see two remaining problems: + /* + * This case should never occur, we've already checked permissions earlier + * and we are holding the file handle open. + */ + ERR("Replacement file may not be deleted!\n"); You need to handle this case better; it happens in real life sometimes that the filesystem lies when it tells you you can write. It should be a WARN, and you need to return the proper error code. Are you quite sure you need to do any file copying? Wouldn't a series of renames be more efficient? - Dan

2 1

Re: [2/2] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltOverride
by H. Verbeet April 5, 2007

April 5, 2007

On 05/04/07, Fabian Bieler <der.fabe(a)gmx.net> wrote: > > > From b369a9384beb831dfae6460418d861f30a9cef3e Mon Sep 17 00:00:00 2001 > From: Fabian Bieler <der.fabe(a)gmx.net> > Date: Thu, 5 Apr 2007 21:52:44 +0200 > Subject: [PATCH] wined3d: Use GL_EXT_framebuffer_blit for framebuffer->texture blits in BltOverride > This doesn't work for the general case, ie blitting any surface to another surface. I've got a more complete patch for this in my tree.

1 1

Why double translation on keydown?
by Shachar Shemesh April 5, 2007

April 5, 2007

Hi all, The current code for keyboard translation goes something like this, if I understood it correctly: * An X11 event arrives with the physical keycode for the key pressed. * Said code is translated into a VKey based on the current keyboard (fair enough) * Keycode is translated into a, well, keycode for Windows. 99% of the cases this is the same one, as it's the same PC keyboard as ever. * The vkey and translated keycode are sent as WM_KEYDOWN or WM_SYSKEYDOWN events. * In all probability, the process calls TranslateMessage * TranslateMessage calls (indirectly) X11DRV_ToUnicodeEx * X11DRV_ToUnicodeEx takes the virtual key, looks it up (using a for loop!!!!) in the same table consulted before to find out what the original X11 keycode was. * That vkey is passed, after some manipulation, to XKeysymToKeycode to produce a keycode * Said keycode is passed to XLookupString to get an actual key for it This process seems, to me, overly long and inefficient. It requires building fairly complex lookup tables for both vkey and Windows keycode. I fail to see what is gained. Why not use the following process instead: * An X11 event arrives * Use the native keycode as the keycode. * Translate the vkey as before. * Send WM_(SYS)KEYDOWN as before * In X11DRV_ToUnicodeEx: * Use the keycode to lookup with key using XLookupString I fail to see why the forward and backwards translation is good for. Explanation? Shachar

2 3

Re: notepad: Fix the wrong '&' operator use.
by Felix Nawothnig April 5, 2007

April 5, 2007

Byeong-Sik Jeon wrote: > FormatMessage( > FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM, > NULL, error, 0, > - (LPTSTR) &lpMsgBuf, 0, NULL); > + lpMsgBuf, 0, NULL); This patch is wrong. When FORMAT_MESSAGE_ALLOCATE_BUFFER is used FormatMessage() takes a pointer to a pointer.

2 1

Re: [RESEND] regedit: Convert from WCHAR size to maximum required TCHAR size.
by Detlef Riekenberg April 5, 2007

April 5, 2007

On Mi, 2007-04-04 at 10:36 +0900, Byeong-Sik Jeon wrote: > > + /* convert from WCHAR size to maximum required TCHAR size */ > + max_val_name_len *= sizeof(WCHAR) / sizeof(TCHAR); > + > valName = HeapAlloc(GetProcessHeap(), 0, max_val_name_len * > sizeof(TCHAR)); > valBuf = HeapAlloc(GetProcessHeap(), 0, max_val_size); > if (RegQueryValueEx(hKey, NULL, NULL, &valType, valBuf, &valSize) > == ERROR_FILE_NOT_FOUND) { This looks wrong to me: TCHAR is WCHAR, when compiled with UNICODE, otherwise TCHAR is CHAR The code does already handle the different character-size in HeapAlloc for varName. When the app must handle the case, that sizeof(string) can be > "strlen(string) + sizeof(0)", then we should convert the app to use UNICODE everywhere. For the last quoted line, valSize is not initialized! (RegQueryInfoKey wrote the result to max_val_size) Just checked Coverity: not detected -- By by ... Detlef

5 15