May 2007 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

Re: hhctrl.ocx: Parse HTML entities in the table of contents.
by Alexandre Julliard April 15, 2008

April 15, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > + p++; > + if ((*p == 'X') || (*p == 'x')) > + { > + /* hexadecimal entity */ > + while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') || > + (*p >= 'A' && *p <= 'F')) > + p++; > + ch = strtolW(start + 2, NULL, 16); > + } This is still broken. > + if (p - start - 1 <= sizeof(char_refs[0].name)) > + { > + for (i = 0; i < sizeof(char_refs)/sizeof(char_refs[0]); i++) > + if (!strncmpW(char_refs[i].name, start + 1, p - start - 1)) > + break; > + } This is still broken too. -- Alexandre Julliard julliard(a)winehq.org

2 1

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

Work legalities
by Nathan Williams Dec. 11, 2007

Dec. 11, 2007

Hey everyone, I have been planning to do some work on wine for a while now, but after I started working I got myself a new programming job. I'm worried about the copyright of any external work I do, so I need a little advice. What do I need from my employer to clear me to work on wine? Is something verbal ok, or should I get it in writing? -- Nathan

10 12

PulseAudio driver
by Stéphan Kochen July 18, 2007

July 18, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello everyone, I've been working on a PulseAudio driver for Wine for a couple of days now. It was suggested I should drop a note on to wine-devel, so here I am. :) I also cc'd pulseaudio-discuss. (And subscribed to both.) I personally use PulseAudio for everything on my desktop already, but support in Wine was lacking. PulseAudio provides lots of compatibility with other APIs, like OSS, ALSA and ESD. I only managed to get OSS emulation working to a reasonable extent with Wine. I decided it would be a fun project to write a native PulseAudio driver instead. Right now I'm trying to get very basic output working, without real support for DirectSound. Using the winmm_test.exe.so testcase from Wine I already managed to produce beeps using my driver, which is pretty cool for just a couple of days work. :) If anyone feels like a chat, I read both these lists now and will try to respond. I can also be found on Freenode in #winehackers and #pulseaudio as 'stephank'. - -- Stéphan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGEOThcFUq0gzqDwQRAr5mAKCn2PenC5f8iUKEywPe2c8J6s3bogCdH6qv 3JCaQX5OIBwMV9znBXYKJh4= =gQT3 -----END PGP SIGNATURE-----

2 1

Re: rsaenh: AcquireContext can have multiple flags defined at the same time
by Mounir IDRASSI June 11, 2007

June 11, 2007

Hi, Your patch is wrong: the flags CRYPT_NEWKEYSET and CRYPT_VERIFYCONTEXT can't be mixed and if they are set together like in your patch AcquireContext should return NTE_BAD_FLAGS. You can check that using the MS implementation under windows. It's also clearly stated in MSDN that CRYPT_VERIFYCONTEXT is reserved for non persistent operations which is not the case when you create a new container. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Maarten Lankhorst wrote: > According to msdn a combination of flags are set, since I'm not sure > which combo's are valid I put up a FIXME. > > ------------------------------------------------------------------------ > >

2 3

Re: gdiplus: added stub implementation of gdiplus.dll
by Mounir IDRASSI June 8, 2007

June 8, 2007

Hi, You also have to modify other files in order to integrate your stub implementation to the wine build chain: Makefile.in, configure and configure.ac in the wine root directory, Makefile.in in the "dlls" directory. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Evan Stade wrote: > Changelog: > * added stub implementation of gdiplus.dll (3 files) > > dlls/gdiplus/Makefile.in | 16 + > dlls/gdiplus/gdiplus.c | 45 +++ > dlls/gdiplus/gdiplus.spec | 609 > +++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 670 insertions(+), 0 deletions(-)

6 7

Re: ADVAPI32: Start test for service tests
by James Hawkins June 5, 2007

June 5, 2007

On 5/20/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > Changelog > dlls/advapi32/tests/Makefile.in > dlls/advapi32/tests/service.c > Start test for service tests > License: X11/LGPL > > This test will crash without the previous patch > "Return error on NULL service name to GetServiceDisplayNameA/W" > > Rolf Kalbermatter > + ok(size <= 1, "size should be <= 1 was %d!", size); This is a bad test. According to msdn, GetServiceDisplayName does not modify lpcchBuffer on error, so size should be exactly 0. +static BOOL test_service_info(SC_HANDLE hscm) test functions are void, not BOOL. You're never going to do anything but return, and there's no value to check by the caller. + ok(size, "size should be returned!"); And what is the size? Tests are supposed to be exact. If our implementation is incorrect, and we return size as 39491, that's certainly not correct, but this test won't fail when it should. +static BOOL test_service_enum(SC_HANDLE hscm) +{ + return 0; +} Please don't add dead code. -- James Hawkins

3 4

GDI+: headers and one test
by Evan Stade June 1, 2007

June 1, 2007

Changelog: *Added public GDI+ headers in include/ *Added private GDI+ headers in dlls/gdiplus *Added small implementation of GDI+ pens in dlls/gdiplus/pen.c *Added (first) GDI+ test dlls/gdiplus/Makefile.in | 3 + dlls/gdiplus/gdip_defines.h | 43 +++++++++++++++++++ dlls/gdiplus/gdip_enumerations.h | 57 ++++++++++++++++++++++++++ dlls/gdiplus/gdiplus.c | 27 ++++++++++++ dlls/gdiplus/gdiplus.spec | 8 ++-- dlls/gdiplus/gdiplus_private.h | 43 +++++++++++++++++++ dlls/gdiplus/pen.c | 84 ++++++++++++++++++++++++++++++++++++++ dlls/gdiplus/pen.h | 30 ++++++++++++++ dlls/gdiplus/tests/Makefile.in | 13 ++++++ dlls/gdiplus/tests/pen.c | 44 ++++++++++++++++++++ include/Gdiplus.h | 10 +++++ include/GdiplusEnums.h | 39 ++++++++++++++++++ include/GdiplusFlat.h | 23 ++++++++++ include/GdiplusGpStubs.h | 10 +++++ include/GdiplusInit.h | 26 ++++++++++++ include/GdiplusTypes.h | 7 +++ 16 files changed, 462 insertions(+), 5 deletions(-) -Evan Stade

6 5

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.
by Alexandre Julliard June 1, 2007

June 1, 2007

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -212,8 +213,10 @@ static BOOL load_wine_gecko(PRUnichar *gre_path) > if(res != ERROR_SUCCESS || type != REG_SZ) > return FALSE; > > - if(TRACE_ON(mshtml)) > - check_version(gre_path); > + /* We may consider message box here */ > + if(ERR_ON(mshtml) && !check_version(gre_path)) > + MESSAGE("Found a version of Wine Gecko package that is not dedicated " > + "to your Wine version. Reinstalation is recommended.\n"); If you want to check versions, there needs to be a way to specify in the URL which version you want to download, and old versions need to be kept available. The target CPU should also be part of the URL so we can support multiple platforms. -- Alexandre Julliard julliard(a)winehq.org

2 5

Bug triage, or spam?
by Tom Spear June 1, 2007

June 1, 2007

Hi all, I just have a quick question.. I got a message from someone last night asking me to stop closing bugs because I'm spamming the list, however I also received a message from someone a couple of nights ago thanking me for doing bug triage.. Which is it, and if it is both, then what draws the line between triage and spam, and how do I close stale bugs without it being considered spam? -- Thanks Tom

6 17

The ddraw tests don't compile with Visual C++ 2005.
by Francois Gouget June 1, 2007

June 1, 2007

Visual C++ 2005 does not like the way we compute the infinity and NaN values. I've tried replacing the current divisions by zero with arithmetic on FLT_MAX (at least for the infinity calculations), but it did not like that either. Does anyone know how to make these calculations portable? How does one get at these values on Windows? diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c [...] light.dvAttenuation0 = -1.0 / 0.0; /* -INFINITY */ [...] light.dvAttenuation0 = 1.0 / 0.0; /* +INFINITY */ [...] light.dvAttenuation0 = 0.0 / 0.0; /* NaN */ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

4 4

FPS tool for wine
by Tomas.Zijdemans＠student.uib.no June 1, 2007

June 1, 2007

The largest gaming site in Norway recently did an extensive review of gaming on Linux, but Wine was left out of the benchmark because "no FPS tool exists for Wine". Surely this can't be true?

10 11

Re:wine.inf: Create fake dll for iexplore.exe.
by Louis. Lenders May 31, 2007

May 31, 2007

>wine.inf: Create fake dll for >iexplore.exe. >Vitaliy Margolen wine-patches at kievinfo.com >Thu May 24 08:50:10 CDT 2007 >Some older programs check if IE is installed looking for c:\Program >Files\Internet Explorer\iexplore.exe --- tools/wine.inf | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

2 1

Re: [d3drm/tests] d3drm is removed from Windows Vista
by H. Verbeet May 31, 2007

May 31, 2007

On 11/05/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > d3drm is removed from Windows Vista and thus we have to check if it can be loaded. > I suppose that implies that any application using d3drm won't work on Vista?

3 2

re: Whitespace changes in an indentation patch, is it acceptable?
by Dan Kegel May 31, 2007

May 31, 2007

Tom wrote: >Hi all, just curious, in my work on uninstaller, I am writing my >patches to where when indentation is changed, due to adding a for >loop, it is done in a separate patch file. I was wondering if it is >acceptable to make whitespace changes to other parts of the file in >that same patch. In general, mixing large whitespace changes with small functional changes make it hard to code review the functional change. But either way can be fine, it just depends on the situation. Now that you've fixed a couple bugs in your uninstall patch, I think you should post the very simplest form of it possible, without any other change mixed in. In this case, I think that means you should do the whitespace changes in a second patch. - Dan

3 2

Whitespace changes in an indentation patch, is it acceptable?
by Tom Spear May 31, 2007

May 31, 2007

Hi all, just curious, in my work on uninstaller, I am writing my patches to where when indentation is changed, due to adding a for loop, it is done in a separate patch file. I was wondering if it is acceptable to make whitespace changes to other parts of the file in that same patch.. For example, there is: int somevariable; do something; (there are 2 spaces in the blank line). Would it be acceptable to remove those spaces in a patch that changes the following code (which is introduced by the first patch in the series): for blah { do something; for something else { do another thing; } } to: for blah { do something; for something else { do another thing; } } or should I just leave those extra whitespaces in the blank line alone? -- Thanks Tom

1 0

winefile/explorer hardcoded? HKEY_CLASSES_ROOT\Folder\shell\open\command ignored
by RusH May 30, 2007

May 30, 2007

Repost from wine-users(no answer there). Winefile seems to be hardcoded when it comes to opening folders. No matter what I do it always pops up. I tried deleting HKEY_CLASSES_ROOT\Folder and nothing changed. What can I do to convince wine to open folders with /usr/bin/nautilus ? I allready made it open ordinary files with gnome-open. Should I made a bug report? Are DDE registry keys for folder opening only a prop? -- Who logs in to gdm? Not I, said the duck.

2 1

Re: (try 2) ws2_32: getsockname should fail for unbound sockets
by Dmitry Timoshkov May 30, 2007

May 30, 2007

"Damjan Jovanovic" <damjan.jov(a)gmail.com> wrote: > + case AF_INET6: > + { > + static const struct sockaddr_in6 emptyAddr; > + const struct sockaddr_in6 *in6 = (struct sockaddr_in6*) uaddr; > + return in6->sin6_port || memcmp(&in6->sin6_addr, &emptyAddr.sin6_addr, sizeof(struct in6_addr)); > + } > + case AF_INET: > + { > + static const struct sockaddr_in emptyAddr; > + const struct sockaddr_in *in = (struct sockaddr_in*) uaddr; > + return in->sin_port || memcmp(&in->sin_addr, &emptyAddr.sin_addr, sizeof(struct in_addr)); > + } You should add 'const' to the casting if the target you create is 'const'. -- Dmitry.

1 0

Re: headers, two tests
by Dmitry Timoshkov May 30, 2007

May 30, 2007

This time it's just the nit picks, I see no serious problems. "Evan Stade" <estade(a)gmail.com> wrote: > +void WINGDIPAPI GdipFree(void* ptr) > +{ > + if(ptr) > + HeapFree(GetProcessHeap(), 0, ptr); > +} There is no need to check a pointer for NULL before HeapFree call, there is even a janitorial project in Wine to remove such checks. > +static void test_constructor_destructor(void) > +{ > + GpStatus status; > + GpGraphics *pen; > + > + status = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel, &pen); GdipCreatePen1 takes a pointer to GpPen in the last parameter, not GpGraphics. > + expect(Ok, status); > + ok(pen, "Expected pen to be initialized"); If you are testing returned pen pointer for NULL, you need to initialize it to NULL before the call. -- Dmitry.

1 0

Re: crypt32: implement CryptSIPLoad (resend)
by Juan Lang May 30, 2007

May 30, 2007

Hi Paul, > Please correct me if I'm wrong but aren't you filling pSipDispatch > with the function pointers of the given dll (as indicated by the GUID) > instead of the function pointers of crypt32 (as the tests show it > should)? I am. I couldn't find any reason that the behavior needs to be that way, so I do this until such time as a reason can be found. The tests don't fail, as you check the function pointers from msisip.dll, which isn't present on wine. If you know a good reason native does it that way (or an app that depends on it,) by all means enlighten me. The implementation I sent allows native wintrust to get a bit further. --Juan ____________________________________________________________________________________ Get your own web address. Have a HUGE year through Yahoo! Small Business. http://smallbusiness.yahoo.com/domains/?p=BESTDEAL

2 1

Pretty Build System (Take 3)
by Robert Shearman May 30, 2007

May 30, 2007

Hi, Attached is a patch that reduces the verbosity of the build system by printing the build commands in one of two formats: COMMAND output_file or COMMAND input_file -> output_file I hope it meets Alexandre's requirements of not reducing portability of Wine to other platforms (including Windows). -- Rob Shearman

3 5

Looking for Dev to help with BSD Port
by Kris Moore May 30, 2007

May 30, 2007

Hey all! We're looking for a Wine dev to assist us with some porting issues over to PC-BSD / FreeBSD. We've recently begun to embrace making packages with wine embedded, making the process of loading windows programs a snap. The end user only needs to double-click, insert their CD, and click next a few times. This allowed us to make some packages for programs such as PhotoShop & Dreamweaver which even a non-linux/BSD user could install. We really want to expand these packages, to include things such as games, and others, but there are a few problems with running Wine on BSD at the moment. If anybody is willing to help us out with this, please let me know! Here's a list of some of the porting issues were aware of: http://wiki.freebsd.org/Wine Thanks! -- Kris Moore PC-BSD Software http://www.pcbsd.com

1 0

Ownerdraw listview font patch...
by Markus Gömmel May 30, 2007

May 30, 2007

Hi, one of our windows application is using an OWNERDRAW_FIXED listview. With the current version of Wine I mentioned that when the listview is loosing its focus, the selected item will be repainted in a wrong front (System 12 instead of my MS Shell Dlg 11)... after the focus comes back, the item is redrawn again, now with correct font settings again. After searching for a while my idea is that the LISTVIEW_ShowFocusRect function is missing a SelectObject call to the font stored in the item-structure for this particular listview item. So the hdc transfered over WM_DRAWITEM to the application contains the wrong font. I created the attached patch, which looks like this: --- snipp --- diff -u -u -r1.485 listview.c --- dlls/comctl32/listview.c 25 May 2007 19:46:02 -0000 1.485 +++ dlls/comctl32/listview.c 30 May 2007 12:28:44 -0000 @@ -1770,6 +1770,9 @@ { DRAWITEMSTRUCT dis; LVITEMW item; + + HFONT hFont = infoPtr->hFont ? infoPtr->hFont : infoPtr->hDefaultFont; + HFONT hOldFont = SelectObject(hdc, hFont); item.iItem = infoPtr->nFocusedItem; item.iSubItem = 0; @@ -1788,6 +1791,8 @@ dis.itemData = item.lParam; SendMessageW(infoPtr->hwndNotify, WM_DRAWITEM, dis.CtlID, (LPARAM)&dis); + + SelectObject(hdc, hOldFont); } else { --- snipp --- Before sending this to wine.patches, I wanted to ask if anyone here can tell me if the above is ok or total bullshit. Thanks and regards Markus

2 1

Re: Implement the WriteEnvironmentStrings standard action
by Dmitry Timoshkov May 30, 2007

May 30, 2007

"James Hawkins" <truiken(a)gmail.com> wrote: > + HKEY env, root = HKEY_CURRENT_USER; ... > + if (flags & ENV_MOD_MACHINE) > + root = HKEY_LOCAL_MACHINE; It looks like root is not used. -- Dmitry.

2 1

Re: crypt32: implement CryptSIPLoad (resend)
by Paul Vriens May 30, 2007

May 30, 2007

On 5/30/07, Juan Lang <juan_lang(a)yahoo.com> wrote: > Hi, I fixed the test failures - anything wrong with it this time? > > ChangeLog: implement CryptSIPLoad > > Thanks, > --Juan > Hi Juan, Please correct me if I'm wrong but aren't you filling pSipDispatch with the function pointers of the given dll (as indicated by the GUID) instead of the function pointers of crypt32 (as the tests show it should)? Cheers, Paul.

1 0

Call for Ubuntu-wine admin
by Tomas.Zijdemans＠student.uib.no May 30, 2007

May 30, 2007

If someone is interested in leading the Ubuntu-wine team, please contact me.

4 3

Re: [ws2_32] getsockname should fail on unbound socket
by Kai Blin May 30, 2007

May 30, 2007

On Wednesday 30 May 2007 07:56:31 Damjan Jovanovic wrote: > + case AF_INET: { > + const struct sockaddr_in *in = (struct sockaddr_in*) uaddr; > + return in->sin_port != 0; > + } Talking to Alexandre about this in IRC, he wanted me to check for all-null returns, so you probably should check if the IP address is 0.0.0.0 (or :: for IPv6), too. Also, I had the impression that the Wine convention was that case block braces go onto a new line, too. You might want to consider that for the switch you addded. Thanks for doing the work for me otherwise :) Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

1 0

Fedora Packages
by Andreas Bierfert May 30, 2007

May 30, 2007

Hi, here is some news/status update on the fedora packages: As people have been complaining about the link on the winehq webpage I have taken the time to make a summary page[1] on the fedora wiki which is easier for me to maintain and keep up-to-date and is probably more helpful. I would request that the link in the download section is changed to that page. I have good news for users of RHEL/Centos: After collaborating with some other maintainers from the fedora project I finally got all dependencies for wine into the EPEL[2] repository (which is something like Fedora Extras but for RHEL/Centos). This means that there now is a wine version for users of RHEL/Centos 5 (it may take a couple of hours or a day till it is published to the repository and all mirrors have synced it). It will probably take a couple of days but I finished testing these changes for RHEL/Centos 4 as well so there should also be a version out soon. Comments and suggestions are (like always) very much welcome. Regards, Andreas [1] - http://fedoraproject.org/wiki/AndreasBierfert/Wine [2] - http://fedoraproject.org/wiki/EPEL -- Andreas Bierfert | http://awbsworld.de | GPG: C58CF1CB andreas.bierfert(a)lowlatency.de | http://lowlatency.de | signed/encrypted phone: +49 2402 102373 | cell: +49 173 5803043 | mail preferred

1 1

c++ code
by Evan Stade May 29, 2007

May 29, 2007

Hi I want to write conformance tests for gdiplus and that requires the use of c++. Even if I were to focus on the gdi+ flat api, the windows SDK headers for that have c++ code in them, also eventually when the gdi+ c++ wrappers are written on top of the flat api then we will need to be able to compile c++ in the wine environment. What do I have to do to be able to write these tests? -Evan Stade

4 8

Re: Pretty Build System (Take 3)
by Kirill K. Smirnov May 29, 2007

May 29, 2007

You probably forget to run 'autoconf'. I can see nice messages like: $ autoconf ... $ ./configure ... $ make depend ... $ make ... CC extrachunk.o CC factory.o CC getframe.o CC icmstream.o CC regsvr.o CC tmpfile.o >I get the following (on Slackware 11) while running the make depend >portion of ./configure && make depend && make && sudo make install: >make[1]: Entering directory `/home/speeddy/wine-git/tools' >../tools/makedep -C. -S.. -T.. -I/usr/include/freetype2 bin2res.c >fnt2bdf.c fnt2fon.c make_ctests.c makedep.c relpath.c sfnt2fnt.c >make[1]: Leaving directory `/home/speeddy/wine-git/tools' >make[1]: Entering directory `/home/speeddy/wine-git/tools' >make[1]: `makedep' is up to date. >make[1]: Leaving directory `/home/speeddy/wine-git/tools' >make[1]: Entering directory `/home/speeddy/wine-git/dlls' >make[2]: Entering directory `/home/speeddy/wine-git/dlls/acledit' >../../tools/makedep -C. -S../.. -T../.. main.c >make[2]: Leaving directory `/home/speeddy/wine-git/dlls/acledit' >make[2]: Entering directory `/home/speeddy/wine-git/dlls/acledit' >make[2]: MAKERULE_MAKEDEP@: Command not found >make[2]: *** [depend] Error 127 >make[2]: Leaving directory `/home/speeddy/wine-git/dlls/acledit' >make[1]: *** [acledit/__depend__] Error 2 >make[1]: Leaving directory `/home/speeddy/wine-git/dlls' >make: *** [dlls/__depend__] Error 2

1 0

Re: wininet: Add a new NETCON_query_data_available function.
by Stefan Leichter May 29, 2007

May 29, 2007

Am Monday 28 May 2007 12:16 schrieb Robert Shearman: > Use it to implement the behaviour where InternetReadFileExA does a > synchronous request if the data is available and asynchronous otherwise. > --- > configure.ac | 1 + > dlls/wininet/internet.c | 49 > +++++++++++++++++++++++++++-------------- > dlls/wininet/internet.h | 1 + > dlls/wininet/netconnection.c | 35 ++++++++++++++++++++++++++++++ > 4 files changed, 69 insertions(+), 17 deletions(-) Hello, your patch broke the compilation for me. Bye Stefan make[2]: Entering directory `/usr/src/wine/wine-build/dlls/wininet' gcc -c -I../../../wine-git/dlls/wininet -I. -I../../../wine-git/include -I../../include -D__WINESRC__ -D_WINX32_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o netconnection.o ../../../wine-git/dlls/wininet/netconnection.c ../../../wine-git/dlls/wininet/netconnection.c: In function ‘NETCON_query_data_available’: ../../../wine-git/dlls/wininet/netconnection.c:585: error: ‘WININET_NETCONNECTION’ has no member named ‘peek_msg’ ../../../wine-git/dlls/wininet/netconnection.c:586: error: ‘WININET_NETCONNECTION’ has no member named ‘peek_len’ make[2]: *** [netconnection.o] Fehler 1 make[2]: Leaving directory `/usr/src/wine/wine-build/dlls/wininet'

1 0

Happy SOC'ing all.
by Maarten Lankhorst May 29, 2007

May 29, 2007

For all other students joining SummerOfCode, I think it's a good idea if we have a public place where we can see each other's changes. I set up my own fork, sound.git at http://repo.or.cz/w/wine.git - if others want to do the same I encourage them to do so, it's easy when you figure out how to git push. Since soc now officially started (according to date, in holland anyway), I just want to say: - Happy coding - Good luck all Cheers, Maarten

4 4

Crosscompile (mingw) failure with msxml3 tests
by Paul Vriens May 29, 2007

May 29, 2007

Hi, I just wanted to report the current failures when crosscompiling the msxml3 tests with mingw (and thus no new winetest executable): xmldoc.cross.o:xmldoc.c:(.text+0x1a9): undefined reference to `_IID_IXMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x1c0): undefined reference to `_CLSID_XMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x149d): undefined reference to `_IID_IXMLDocument' xmldoc.cross.o:xmldoc.c:(.text+0x14b4): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x22): undefined reference to `_IID_IXMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x39): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x1425): undefined reference to `_IID_IXMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x143c): undefined reference to `_CLSID_XMLDocument' xmlelem.cross.o:xmlelem.c:(.text+0x1c46): undefined reference to `_IID_IXMLElement' xmlelem.cross.o:xmlelem.c:(.text+0x1f0f): undefined reference to `_IID_IXMLElement' collect2: ld returned 1 exit status make: *** [msxml3_crosstest.exe] Error 1 These started to happen after the addition of some patches made by James Hawkins (Add tests for [IXMLElement|IXMLDocument]) on May 26th. Cheers, Paul.

1 0

uninstaller: Shorten variable name length.. Whats wrong?
by Tom Spear May 29, 2007

May 29, 2007

Just curious to know if there was something wrong with this patch, or if maybe it wasnt committed due to being a cosmetic change? If it's the latter, I'll just resend the other 2 parts of the patch (2and 3 of 3) against the code the way it is instead of changing the lines.. On 5/23/07, Tom Spear <speeddymon(a)gmail.com> wrote: > This patch shortens the length of some lines in > FetchUninstallInformation, as suggested by Peter Beutner > > -- > Thanks > > Tom > > -- Thanks Tom

1 0

[wiki] Child pages mess up the logo-location
by Paul Vriens May 29, 2007

May 29, 2007

Hi, Every now and then I check for the 'Recent Changes' on the wiki. The following page caught my attention: http://wiki.winehq.org/MaartenLankhorst/SOC2007 This page is actually named "MaartenLankhorst/SOC2007" and is a child of the 'MaartenLankhorst' page. This page messes up the logo in the top-left corner. When looking at the properties of the logo it shows 'http://wiki.winehq.org/MaartenLankhorst/logo.png' instead of the correct 'http://wiki.winehq.org/logo.png'. The same logic is true for http://wiki.winehq.org/MacOSX/FAQs (and probably others). Just thought I mention it. Cheers, Paul.

1 0

Start of an opengl-based gdi driver
by Stefan Dösinger May 29, 2007

May 29, 2007

Hi, One of our remaining fundamental d3d problems is the slowness of IDirectDrawSurface7::GetDC(and d3d9). This call allows performing gdi operations on surfaces. Currently this is handled through downloading the opengl surface, performing the gdi operation, and uploading it again. This is slow, especially on render targets. On textures this is rarely used, and wined3d can better cache the texture. Most applications use it to render text text on the back buffer. Applications I have are the d3d7 sdk demos, Empire Earth, Prince of Persia 3D, Age of Empires 2. Sometimes it is also used to load textures with a BitBlt. I have discussed two ways of solving this issue with alexandre. One was to tell the X server to perform the calls in opengl(EXT_texture_from_pixmap looked promissing), the other one was writing an opengl gdi driver in wined3d. The X server approach failed because there is just no API to get that handled, and EXT_texture_from_pixmap explicitly doesn't do that job, and even if there is a hacky way driver support will be bad. So I spent the last days to check how an implementation in wined3d would work - and here it is. So far this driver handles only ExtTextOutW, and I only successfully used it with the directx sdk samples. ExtTextOut uses a Helper device context(normal gdi) to get the glyphs with GetGlyphOutline, loads it into an opengl texture(GL_ALPHA) and records 256 display lists to draw textured quads. So far no unicode support, no custom pens, but custom fonts work. I have 2 screenshots of a dx7 sdk demo with classic getdc and the opengl driver(radeon M9, 1.6 ghz pentium M, 512 mb ram). There seems to be some parameter missing, the text is slightly displaced. Tex.gif(attached) is the created font texture(warning, white text on transparent background). http://stud4.tuwien.ac.at/~e0526822/gl.png http://stud4.tuwien.ac.at/~e0526822/gdi.png One problem of this approach is that the driver has to handle everything. However, I keep a DIB section of the size of the surface, and if I encounter some unsupported call I can print a FIXME, download from gl and call the dib section to do the job. After ReleaseDC the surface code has to upload it again. Its the slow old behavior, so we don't gain anything for unsupported calls, but its no loss either. So far most forward functions are missing, so the DIB driver refuses to initialize itself - Edit CreateDC in dlls/wined3d/gdi.c to activate it. ExtTextOut has an example how the forwarding looks like. A big problem I still have are operations that involve 2 device contexts. Prince of Persia 3D(good test case for custom fonts) calls StretchBlit from/to my gl dc. So in X11drv one of the physdevs is a WineD3DSurfaceImpl * instead of a WINEX11DRV_PHSYDEV * - not good. So far I haven't found a way to let x11drv access my surface data, or enforce that my function is called, fetch the hdc from the x11 phsydev and call my fallback dc, or request the device's content from x11drv and handle the blit myself.

2 3

Start of an opengl-based gdi driver
by Stefan Dösinger May 28, 2007

May 28, 2007

Hi, One of our remaining fundamental d3d problems is the slowness of IDirectDrawSurface7::GetDC(and d3d9). This call allows performing gdi operations on surfaces. Currently this is handled through downloading the opengl surface, performing the gdi operation, and uploading it again. This is slow, especially on render targets. On textures this is rarely used, and wined3d can better cache the texture. Most applications use it to render text text on the back buffer. Applications I have are the d3d7 sdk demos, Empire Earth, Prince of Persia 3D, Age of Empires 2. Sometimes it is also used to load textures with a BitBlt. I have discussed two ways of solving this issue with alexandre. One was to tell the X server to perform the calls in opengl(EXT_texture_from_pixmap looked promissing), the other one was writing an opengl gdi driver in wined3d. The X server approach failed because there is just no API to get that handled, and EXT_texture_from_pixmap explicitly doesn't do that job, and even if there is a hacky way driver support will be bad. So I spent the last days to check how an implementation in wined3d would work - and here it is. So far this driver handles only ExtTextOutW, and I only successfully used it with the directx sdk samples. ExtTextOut uses a Helper device context(normal gdi) to get the glyphs with GetGlyphOutline, loads it into an opengl texture(GL_ALPHA) and records 256 display lists to draw textured quads. So far no unicode support, no custom pens, but custom fonts work. Attached are 2 screenshots of a dx7 sdk demo with classic getdc and the opengl driver(radeon M9, 1.6 ghz pentium M, 512 mb ram). There seems to be some parameter missing, the text is slightly displaced. Tex.gif is the created font texture(warning, white text on transparent background) One problem of this approach is that the driver has to handle everything. However, I keep a DIB section of the size of the surface, and if I encounter some unsupported call I can print a FIXME, download from gl and call the dib section to do the job. After ReleaseDC the surface code has to upload it again. Its the slow old behavior, so we don't gain anything for unsupported calls, but its no loss either. So far most forward functions are missing, so the DIB driver refuses to initialize itself - Edit CreateDC in dlls/wined3d/gdi.c to activate it. ExtTextOut has an example how the forwarding looks like. A big problem I still have are operations that involve 2 device contexts. Prince of Persia 3D(good test case for custom fonts) calls StretchBlit from/to my gl dc. So in X11drv one of the physdevs is a WineD3DSurfaceImpl * instead of a WINEX11DRV_PHSYDEV * - not good. So far I haven't found a way to let x11drv access my surface data, or enforce that my function is called, fetch the hdc from the x11 phsydev and call my fallback dc, or request the device's content from x11drv and handle the blit myself.

1 0

New Gecko package
by Luke Bratch May 28, 2007

May 28, 2007

> I'm interested in > regressions, so just a simple test if app that worked before still works > will be fine. I've given it a test, and found the following: - When setting that URL in HKCU\Software\Wine\MSHTML, it will download but fail to install. - Extracting it to install it manually works, as do the scroll bars (which work fine) - It crashes after submitting more than one form on websites. For instance searching for something on Google, then searching again will cause a crash. This is with the latest git - wine-0.9.37-118-g2970076 ___________________________________________________________ Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for your free account today http://uk.rd.yahoo.com/evt=44106/*http://uk.docs.yahoo.com/mail/winter07.ht…

2 6

New Gecko package
by Jacek Caban May 28, 2007

May 28, 2007

Hi all, It's time to update our Gecko package. I've prepared a new one. I'd like to avoid any regression, esp. ones that would require changing the package again. That's why I'd like to do a good test. I'm interested in regressions, so just a simple test if app that worked before still works will be fine. To do so download: http://gerwazy.lo3.wroc.pl/~jcaban/wine/wine_gecko.tar.bz2 1) if you already have installed Gecko, simply extract the package and replace c:\windows\wine_gecko with it. 2) otherwise extract the package and set GeckoPath variable of HKCU\Software\Winde\MSHTML registry key to its location. Then run an app and check if it still works. Note that you have to use current Git, older Wine is not compatible with the new Gecko. Expected visible difference should be: - Working scrollbars (still not perfect, they will be visible even if app sets it to not be, but it's better than before - I will work on it later) - Pages that require plugins will render like there was no plugin instead of offering downloading one (that doesn't work anyway) >From technical point of view this version differs much from previous one. Previous version was just a SeaMonkey with manually removed and changed some files. This one is my built from source (I will create a page on wiki about how to do so). It's based on XUL Runner 1.8.1.3, which has the same source as Firefox 2.0.0.3. After testing it, I will change Gecko installer a bit to be able to deal with different Gecko versions for different Wine version and upload it to SourceForge. Thanks, Jacek

4 8

winmm: PlaySound SND_ASYNC fix
by Vedran Rodic May 28, 2007

May 28, 2007

Hi, this patch is still not applied though I've submitted it last Wednesday. I guess it's not obviously clear that it is correct, so I'm asking for a review here. I've peronally tested it with alsa and oss sound backends. It specifically fixes one series of Croatian child educational games named "Suncica". Detailed info: Applications expect PlaySound() not to block when called with SND_ASYNC flag. However, if a sound is currently playing, there is a real chance of PlaySound() blocking for up to 1/3 of a second (size of the playsound buffer), because of a sound buffer waiting to be played. This patch adds a hWave field in the WINE_PLAYSOUND internal struct in winemm.h so that MULTIMEDIA_PlaySound() function can call waveOutReset when a sound is already playing to quickly remove it from the sound system. Another scenario is when application wants to quickly stop a currently playing sound at a specific time. Blocking behaviour isn't necessarily a problem for such applications, but playing the sound for additional 300 miliseconds could be. ChangeLog entry: Vedran Rodic <vrodic(a)gmail.com> - fix PlaySound so it doesn't block when another sound is already playing. Thanks

1 0

Re: ddraw/tests: Fix compilation with Visual C++ 2005.
by Stefan Dösinger May 27, 2007

May 27, 2007

> - light.dvAttenuation0 = 0.0 / 0.0; /* NaN */ > + light.dvAttenuation0 = zero / zero; /* NaN */ Are you sure the compiler doesn't optimize that away to 1.0 ?

2 1

Re: setupapi/tests: There is no strncascmp() on Windows. So we must use msvcrt's _strnicmp() function instead.
by Dmitry Timoshkov May 27, 2007

May 27, 2007

"Francois Gouget" <fgouget(a)free.fr> wrote: > There are other alternatives: > * we could have an #ifdef _MSC_VER to switch between strncasecmp() and > _strnicmp(). > * we could reimplement _strnicmp(). > * or maybe the test could be modified to not need this function at all? 4. use a kernel32 export lstrcmpiA P.S. Even in Wine code strncasecmp/strcasecmp should be deprecated since it uses wrong locale. -- Dmitry.

1 1

how to compile test cases?
by RusH May 27, 2007

May 27, 2007

rasz(a)capek:/media/hdc6/home/rasz/source/wine/dlls/ws2_32$ make test make: Nothing to be done for `test'. rasz(a)capek:/media/hdc6/home/rasz/source/wine/dlls/ws2_32$ make crosstest make: Nothing to be done for `crosstest'. I want to build only ws2_32 tests, preferably using mingw. -- Who logs in to gdm? Not I, said the duck.

2 1

Re: wined3d: Implement support for gamma corrected (sRGB) texture loading
by H. Verbeet May 27, 2007

May 27, 2007

On 27/05/07, Phil Costin <philcostin(a)hotmail.com> wrote: > Hi, > > This patch has been a long time in the making. The following test was used > during the creation of the patch: > > http://ati.amd.com/developer/samples/dx9/sRGBTest.html > If it's not too much trouble, a proper wine test would be nice. The changes to surface_upload_data and surface_download_data look like they should be separate changes. In cubetexture.c, and similar code in texture.c and volume.c: > + } else if (GL_SUPPORT(EXT_TEXTURE_SRGB) && This->baseTexture.bindCount > 0) { > + currentSrgbMode = This->resource.wineD3DDevice->stateBlock->samplerState[This->baseTexture.sampler][WINED3DSAMP_SRGBTEXTURE]; > + srgbModeChanged = (This->baseTexture.srgbWhenLoaded != currentSrgbMode); > + This->baseTexture.srgbWhenLoaded = currentSrgbMode; You've got "device" here, no need to use "This->resource.wineD3DDevice" sRGBmode looks a bit awkward as a variable name, I'd rather see something like srgb_mode, but I guess that's more a personal preference. It would also probably be better to submit/commit this right after a release instead of right before one.

2 1

[PATCH 4/4] dpnhupnp: Implement IDirectPlayNatHelper stub
by Vijay Kiran Kamuju May 27, 2007

May 27, 2007

Hi, It seems there is a problem with the fake dll entry for dpnhupnp.dll in wine.inf @@ -2129,6 +2129,7 @@ HKLM,%CurrentVersion%\Telephony\Country List\998,"SameAreaRule",,"G" 11,,dmusic.dll,1 11,,dplayx.dll,1 11,,dpnet.dll,1 +11,,dpnhupnp,1 11,,dsound.dll,1 11,,dswave.dll,1 11,,dxdiagn.dll,1 The ebtry should have been 11,,dpnhupnp.dll,1 Correct and resend Thanks, VJ

1 0

Wine does not compile
by martin pilka May 27, 2007

May 27, 2007

Hello, I just tried to compile Wine on Ubuntu 6.06 and Ubuntu 7.04 (both updated). On both machines, I got following error: make[2]: Entering directory `/home/mpilka/cxtest/wine/dlls/msxml3' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o attribute.o attribute.c In file included from attribute.c:32: msxml_private.h:67: error: expected declaration specifiers or ‘...’ before ‘xmlNodePtr’ msxml_private.h:68: error: expected declaration specifiers or ‘...’ before ‘xmlNodePtr’ make[2]: *** [attribute.o] Error 1 make[2]: Leaving directory `/home/mpilka/cxtest/wine/dlls/msxml3' make[1]: *** [msxml3] Error 2 make[1]: Leaving directory `/home/mpilka/cxtest/wine/dlls' make: *** [dlls] Error 2 Just wanted to let you know that, Martin

2 2

Ok, NOW is it time to delete wineinstall?
by Scott Ritchie May 26, 2007

May 26, 2007

A couple of years back we had a discussion about this. Does anyone still use Wineinstall? What advantage does it have over ./configure && make && make install ? I'm asking because today I found a user who managed to somehow accidentally compile Wine from source: http://ubuntuforums.org/showthread.php?t=454815 Thanks, Scott Ritchie

1 0

Re: some doubts about sendind patches - is text/plain way good?
by Kirill K. Smirnov May 26, 2007

May 26, 2007

>You might want to try the following: Select the patch from >http://thread.gmane.org/gmane.comp.emulators.wine.patches/ , >select the link after "Direct link" on the bottom, append "/raw" >without quotation marks after the URL. Now you can save the file >at that URL as is and use it with patch, it will ignore the headers. It works! Cool! (but a little complicated ;-) Thanks a lot for hint! -- Kirill

1 0

Re: [PATCH 3/6] CMD.EXE: Handle command line as Unicode
by Dmitry Timoshkov May 26, 2007

May 26, 2007

"Jason Edmeades" <us(a)edmeades.me.uk> wrote: > int main (int argc, char *argv[]) > { > + LPWSTR *argvW = NULL; > + int args; > + WCHAR *cmdW = NULL; If you will start using wmain() instead of main() you get unicode args for free, and that will help to avoid changing the command line parsing code. -- Dmitry.

2 3

Re: some doubts about sendind patches - is text/plain way good?
by Kirill K. Smirnov May 26, 2007

May 26, 2007

В сообщении от 26 мая 2007 21:24 вы написали: > I'll double check later, but are you sure? > > When I said I hadn't changed the patches, I meant the contents, but I had > done a git fetch, git rebase origin on the branch (and resolved the german > resource conflict) before resubmitting I got the following messages: patching file programs/cmd/Cs.rc patching file programs/cmd/De.rc Hunk #1 FAILED at 263. 1 out of 1 hunk FAILED -- saving rejects to file programs/cmd/De.rc.rej patching file programs/cmd/En.rc patching file programs/cmd/Es.rc patching file programs/cmd/Fr.rc patching file programs/cmd/Ja.rc patching file programs/cmd/Ko.rc Hunk #1 FAILED at 235. 1 out of 1 hunk FAILED -- saving rejects to file programs/cmd/Ko.rc.rej patching file programs/cmd/Nl.rc patching file programs/cmd/No.rc patching file programs/cmd/Pl.rc patching file programs/cmd/Pt.rc patching file programs/cmd/Ru.rc patching file programs/cmd/Si.rc ... I noticed that German translations patch failed, checked git log, saw that translation has been updated and panic. ;-) I rechecked patch - it is ok, not outdated, but I still cannot apply it. Why? I have only one consideration. As I noticed, patches are sent with different MIME types. In wine-patches mailing list different types are handled differently - if text/plain then attach is embedded into body, if not text/plain (usually text/x-patch) then attach is available via special URL link. I do not receive mail from wine-patches mail list. Thus, to get the patch sent with MIME text/plain I use select/copy/paste/save technique. If patch is not text/plain, I just use "save link target" option in browser. That patch was sent with MIME type text/plain, so I had to copy/paste it. When I tried to save it via kwrite it complained about problems with UTF8 characters, but I did not pay attention and went on. While patching I got messages I wrote before. I've tried VIM as an editor to save too. It does not complain but file I get is still unusable. This make me think, that idea to sent patches with text/plain MIME type (as recommended at http://winehq.org/site/docs/winedev-guide/style-notes) is not a really good way. Also there may be an encoding problem - while sending patches kmail (MUA I use) asks me what enconding to use (7bit, 8bit, base-64). I always set 8-bit. Now I am in doubts if I follow a right way. Any comments? -- Kirill P.S. sorry for rising up nonsence with Jason's patch. It is looks correct, I cannot say more. ;-)

2 1

CMD.EXE patchset 1->6
by Ann & Jason Edmeades May 26, 2007

May 26, 2007

Apologies if this set arrives multiple times - I sent it all on Friday, and the mailing list only shows 1,2 and 4. I sent then again tonight separately, and immediately 3 went missing... FYI I had this problem before the last hardware upgrade on winehq, and it appeared fixed since then. I'll start copying a gmail account in future to confirm what I am seeing, but last time some emails got delayed about a month in transit and eventually appeared, but ONLY when winehq was involved, gmail, hotmail, my own email addr etc all got immediate copies... Regards, Jason

4 6

Re: [PATCH 4/6] CMD.EXE: Convert cmd into unicode
by Detlef Riekenberg May 26, 2007

May 26, 2007

On Di, 2007-05-08 at 00:11 +0100, Jason Edmeades wrote: > Apologies for the size of this patch - I tried 3 or 4 ways of converting > chunks to unicode and always ended up duplicating huge bits of code and > having problems keeping track of duplicated variables that in the end I > did the lot in one go. You need TCHAR and friends to reduce the Patch-Size (char => TCHAR when you did char => WCHAR) And do not forget "* sizeof(TCHAR)" when calculating the required size for allocations (HeapAlloc) -- By by ... Detlef

2 1

Re: [AppDB] Add apidb_footer to browse downloadable page
by Alexander Nicolaysen Sørnes May 26, 2007

May 26, 2007

Lørdag 26 mai 2007 19:02, skrev Chris Morgan: > On 5/26/07, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > > Lørdag 26 mai 2007 18:53, skrev Chris Morgan: > > > We should move that page to a class and integrate it in with the > > > objectManager stuff. Its a pretty simple page. > > > > > > Chris > > > > I agree > > I meant instead of applying this patch we should move it to use the > objectManager stuff ;-) > > Chris Oh, so it was a trick question, then? :D I'll just move it over and adapt it to the objectManager's page browsing framework later. Alexander

1 0

Re: 64-bit compilation broken today
by Clinton Stimpson May 26, 2007

May 26, 2007

>> The confusing thing to me is that I *do* have the libxml2-dev package >> installed, and see no errors about a missing header... >> >> If it didn't recognize the xmlNodePtr type, shouldn't it have choked on >> line 52 first? >> >> -J >> >> >> Bryan DeGrendel wrote: >> >>> A couple of libxml2 externs were recently added to >>> dlls/msxml3/msxml_private.h Both functions have a xmlNodePtr as a >>> parameter, which is defined in the libxml2 header. However, both >>> externs were added outside msxml_private.h's libxml2 preprocessor >>> check, so I believe it causes a compilation error if you don't have >>> the libxml header. I have sent a patch which should fix it. >>> >>> Bryan DeGrendel >>> >>> On 5/25/07, *Evil Jay* <wine(a)eternaldusk.com >>> <mailto:wine(a)eternaldusk.com>> wrote: >>> >>> This might already be known, but sometime in the last eight hours >>> or so, >>> git seems to have broken: >>> >>> gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ >>> -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe >>> -fno-strict-aliasing >>> -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g >>> -O2 -o >>> attribute.o attribute.c >>> In file included from attribute.c:32: >>> msxml_private.h:67: error: expected declaration specifiers or '...' >>> before 'xmlNodePtr' >>> msxml_private.h:68: error: expected declaration specifiers or '...' >>> before 'xmlNodePtr' >>> make[2]: *** [attribute.o] Error 1 >>> make[2]: Leaving directory `/data/install/wine/dlls/msxml3' >>> make[1]: *** [msxml3] Error 2 >>> make[1]: Leaving directory `/data/install/wine/dlls' >>> make: *** [dlls] Error 2 > I also have the libxml2-dev package installed, however HAVE_LIBXML2 was not > defined. Therefore lines 28-60 were not compiled. I suspect this is the > same quirk in your case. > > Bryan DeGrendel > I had the same compile error until I installed the libxml2-devel.i386 package. I had libxml2-devel.x86_64 already installed. Clint

2 1

[PATCH 1/6] CMD.EXE: Move english constants into NLS files
by Kirill K. Smirnov May 26, 2007

May 26, 2007

Hi Jason, Since German and Korean resource have been updated, this patch is a little outdated and cannot be applied. Please, rediff. Other patches may be outdated too. -- Kirill

2 1

No release today?
by Scott Ritchie May 26, 2007

May 26, 2007

I heard a rumor in IRC that there wasn't going to be a release today. Seems to be true. Alexandre, in the future could you please send out an email to wine-devel when you know there won't be a release? I scheduled my day partially around building the upcoming 0.9.38 packages, but that didn't happen. Thanks, Scott Ritchie

3 4

Re: hnetcfg: [resend 3] 1/5 add spec file for hnetcfg
by Detlef Riekenberg May 26, 2007

May 26, 2007

On Sa, 2007-05-26 at 19:37 +1000, Jeff Latimer wrote: > --- > dlls/hnetcfg/hnetcfg.spec | 44 > ++++++++++++++++++++++++++++++++++++++++++++ I suggest, that you read and follow this Hints: http://wiki.winehq.org/Developers-Hints#head-30a7f7f51ce0e42b4141749c9832ba… Thanks -- By by ... Detlef

1 0

[dmaxwell@coverity.com: Re: database full for "Wine" project?]
by Marcus Meissner May 26, 2007

May 26, 2007

Hi, If you have a Coverity Wine account... This is for our information. Ciao, Marcus ----- Forwarded message from David Maxwell <dmaxwell(a)coverity.com> ----- Date: Sat, 26 May 2007 08:31:13 -0400 From: David Maxwell <dmaxwell(a)coverity.com> To: Marcus Meissner <marcus(a)jet.franken.de> Subject: Re: database full for "Wine" project? On Sat, May 26, 2007 at 07:50:10AM +0200, Marcus Meissner wrote: > Hi David, > > I just tried to change a CID in the Wine project > and it results in this error message: > > [ERROR:db.c:226]: database is full: The database is full. > > Ciao, Marcus Hi Marcus, Sorry about that - it's a diskspace issue again. I'm moving Wine over to the new web hosting provider now. It will take a while for the copy, and I won't have Internet again until later on today. The new URL will be: http://scan2.coverity.com:7479/ I'll send an email when the move is complete. Could you let the other Wine developers know about the move and the new URL? Thanks. -- David Maxwell Coverity Open Source Strategist http://scan.coverity.com/ ----- End forwarded message -----

1 0

Alarming number of users getting hardlocks with Wine
by Scott Ritchie May 25, 2007

May 25, 2007

Reading the Ubuntu forums, I've noticed quite a few reports from users complaining about Wine deadlocking their system - keyboard unresponsive, with no solution but to restart the entire computer. Sometimes users report this problem after running ANY Wine process - even winecfg. I'm not sure what's causing the issue. At first I thought it was a hardware thing (perhaps ATI's infamously terribly drivers), but would that still prevent winecfg from working? Wine is a user-level process, it shouldn't be able to cause a hardlock under any circumstances, right? Anyone else seen these kinds of reports? Thanks, Scott Ritchie

9 9

Re: [PATCH 4/4] secur32: Fix NTLM's InitializeSecurityContextA/W to be flexible with the index of the token buffer in both the input and output buffer descriptions.
by Kai Blin May 25, 2007

May 25, 2007

On Thursday 24 May 2007 21:04:47 Robert Shearman wrote: > This patch allows native rpcrt4.dll to use NTLM authentication. Nice :) And it looks like it wasn't that much work to fix my code ;) > TRACE("pInput->pBuffers[0].cbBuffer is: %ld\n", > - pInput->pBuffers[0].cbBuffer); > + pInput->pBuffers[input_token_idx].cbBuffer); > ret = SEC_E_INVALID_TOKEN; If you change the index of the token buffer, could you please fix the trace accordingly? > + WARN("no SECBUFFER_TOKEN buffer could be found\n"); > + ret = SEC_E_BUFFER_TOO_SMALL; > + goto isc_end; > } Is that intentional? According to the developer's guide, "[y]ou should report a warning when something unwanted happens, and the function cannot deal with the condition." This is something the calling application screwed up, so I think a TRACE should be sufficient. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

1 1

Compiling tests standalone on windows
by Dan Kegel May 25, 2007

May 25, 2007

(This is more for my own notekeeping, but maybe it'll be of interest to somebody else.) Sometimes it's nice to build a test with visual C++ on Windows without any makefiles or projects. You just have to get a command prompt that has run vcvars32.bat, e.g. by doing Start / All Programs / Visual C++ 2005 Express Edition / Visual Studio Tools / VS 2005 Command Prompt and then do e.g. cd wine-git\dlls\gdi32\tests cl -DSTANDALONE -D_X86_ -I../../../include pen.c gdi32.lib But for some reason today that didn't work for me; cl couldn't find gdi32.lib unless I gave an absolute path, which made no sense (since the same path was already in LIB). To try to track this down, I wrote a tiny batch file to reproduce everything: set PSDK=C:\Program Files\Microsoft Platform SDK set VS8=C:\Program Files\Microsoft Visual Studio 8 set LIB=%VS8%\VC\LIB;%VS8%\SDK\v2.0\lib;%PSDK%\Lib set INCLUDE=%VS8%\VC\INCLUDE;%PSDK%\Include set PATH=%VS8%\VC\BIN;%VS8%\Common7\IDE;%PATH% cd \dank\wine-git\dlls\gdi32\tests cl -DSTANDALONE -D_X86_ -I../../../include pen.c gdi32.lib Oddly enough, that worked fine. I dunno why the problem went away.

1 0

Re: New winetricks: add support for Red Hat's liberation fonts
by Dan Kegel May 25, 2007

May 25, 2007

On 5/24/07, Brian Vincent <brian.vincent(a)gmail.com> wrote: > I haven't even looked at that stuff at all, but does Wine have any > fonts worth contributing to that cause? (Marlett?) Red Hat's Liberation font is a single-source thing done by a pro, so probably not. > Is it worth > creating a link within winecfg to download and install these somehow? > Good fonts can really help the user experience with Wine. No, it would be better to have Wine install the fonts by default once they are proven useful, I think. I added them to winetricks so people could experiment with them (slightly) more easily. - Dan

4 5

Re: RegDeleteTree [10]
by James Hawkins May 25, 2007

May 25, 2007

On 5/25/07, Stefan Leichter <Stefan.Leichter(a)camline.com> wrote: > Am Friday 25 May 2007 00:48 schrieb Juan Lang: > > Hi Stefan, > > > > + /* Find how many subkeys there are */ > > > > This comment is incorrect. > > > > You have also reintroduced tabs in this patch - please don't do that. > > --Juan > ChangeLog > ------------- > added implementation of RegDeleteTreeA/W > + if (lpszSubKey) { + ret = RegDeleteKeyW(hKey, lpszSubKey); + } else { + while (TRUE) { + dwSize = dwMaxLen; + if (RegEnumValueW(hKey, 0, lpszName, &dwSize, + NULL, NULL, NULL, NULL)) break; + + ret = RegDeleteValueW(hKey, lpszName); + if (ret) goto cleanup; + } + } Please stick with the style of the rest of the file, e.g., opening braces on the next line. There is one short function that uses the style you're using, but we don't need to be adding even more variety to the style. -- James Hawkins

2 1

Re: credui: Add stub for CredUIReadSSOCredW
by James Hawkins May 25, 2007

May 25, 2007

On 5/25/07, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > According to wine's headers, the *A version isn't in there, so not > adding a stub for it. > You forgot to attach the patch. -- James Hawkins

1 0

bugzilla component needed
by James Hawkins May 25, 2007

May 25, 2007

Hey Tony, Can we get a wine-advapi32 component? Thanks, James Hawkins

2 1

Re: crypt32: remove wrong test and parameter check
by Detlef Riekenberg May 25, 2007

May 25, 2007

On Do, 2007-05-24 at 16:45 -0700, Juan Lang wrote: > --Juan No Patch was found in this Message. -- By by ... Detlef

1 0

"Submitted Bug Link rejected" notification is kinda useless
by RusH May 25, 2007

May 25, 2007

Here is my problem : On 5/25/07, AppDB <appdb-noreply(a)winehq.org> wrote: > > Submitted Bug Link rejected > ------------------------------------------------------- > The Bug Link you submitted for eMule 0.46c has been rejected. > We appreciate your help in making the Application Database better for all users. > > Best regards. > The AppDB team > http://appdb.winehq.org/ > > > If you don't want to receive any other e-mail, please change your preferences: > http://appdb.winehq.org/preferences.php as you can see this automatically generated notification is useless, it tells me that one of Bug Links has been deleted, but doesnt tell me which one, and why :( This is bad for people that submit bug links. Now the other end of the equation - Im the maintainer of uTorrent on appdb and had to delete a bug link. Someone submitted a link to a weird bug, there was no mention about utorrent in that bug and I couldnt reproduce it. My actions should be -ask submitter about more details -delete link filling the REASON field with question to submitter about more details but there is no "submitter" field in "Known bugs" list, there is also no "reason" field when I delete bugs. In that particular case I digged up the email from AppDB with info "Link between Bug xxxx and utorrent 1.7 submitted by blabla" and googled for the blabla person, fortunately I was able to find his email and write him a message, but it would be far more user friendly and productive to be able to just do that from the appdb admin form (mail/message bug submitters/ state reason for deletion) -- Who logs in to gdm? Not I, said the duck.

3 2

About Parallel Port Driver
by Zhongli Xu May 25, 2007

May 25, 2007

Hi all, I have a .sys driver for parallel port communication. But it seems wine didn't support loading the driver. My windows program has to be configured as XP version. And directly accessing to parallel port is not allowed on the XP host, therefore _outp() and _inp() are useless. Is there any solution to this problem? Best Regards, Milo Xu

1 0

Re: RegDeleteTree [9]
by Juan Lang May 24, 2007

May 24, 2007

Hi Stefan, + /* Find how many subkeys there are */ This comment is incorrect. You have also reintroduced tabs in this patch - please don't do that. --Juan ____________________________________________________________________________________Pinpoint customers who are looking for what you sell. http://searchmarketing.yahoo.com/

1 0

GIT access fails
by Kirill K. Smirnov May 24, 2007

May 24, 2007

> Did you happen to update curl/libcurl? No, I did not update anything for a few weeks. Git stopped to work a couple of days ago. Should I update curl? My version is 7.15.3.

1 0

GIT access fails
by Kirill K. Smirnov May 24, 2007

May 24, 2007

Hi, Something strange happened to git - fetch fails if uses git:// protocol. In tcpdump I can see my machine and wine.codeweavers.com chating. Thus connection is OK. When I changed protocol to http:// in .git/remotes/origin, I managed to update local git repo. This is very strange - git:// does not work, but http:// does! I did not update git utility on my system. git version is 1.4.2.1. No firewalls too. Any ideas? Thanks, -- Kirill

2 1

problems regression testing/compiling wine
by EA Durbin May 24, 2007

May 24, 2007

I'm having problems regression testing between 0.9.15 and 0.9.37. On 3+ bisects I keep getting the following error and wine won't compile. /home/eric/wine/dlls/winex11.drv/palette.c:866: undefined reference to `GDI_ReleaseObj' palette.o:/home/eric/wine/dlls/winex11.drv/palette.c:881: more undefined references to `GDI_ReleaseObj' follow palette.o: In function `X11DRV_RealizePalette': /home/eric/wine/dlls/winex11.drv/palette.c:1251: undefined reference to `GDI_GetObjPtr' /home/eric/wine/dlls/winex11.drv/palette.c:1253: undefined reference to `GDI_ReleaseObj' collect2: ld returned 1 exit status winegcc: gcc failed. make[2]: *** [winex11.drv.so] Error 2 make[2]: Leaving directory `/home/eric/wine/dlls/winex11.drv' make[1]: *** [winex11.drv] Error 2 make[1]: Leaving directory `/home/eric/wine/dlls' make: *** [dlls] Error 2 _________________________________________________________________ More photos, more messages, more storageget 2GB with Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

5 7

Status regarding the recent Appdb vandalism
by Jan Zerebecki May 24, 2007

May 24, 2007

Please do _only_ address replies to this email to wine-devel(a)winehq.org ! Remove all other recipients from To and Cc ! Work is currently underway to restore the state of the Appdb to the backup of May 22 07:00 CST. This morning ( TZ +0200 ) someone used the account "Molle Bestefich" to vandalize the Appdb. He was also seen on IRC and on the wiki. His IP was identified on all three, logs are available. See towards the end of this mail for IRC log snippet and whois on his IP. Please contact me first if you intend to contact abuse or police personal regarding this, so we don't cause headaches or duplicate work. We do not yet know how this person got access to Molle Bestefich his account. I received 4454 emails about deletes or other actions by the account "Molle Bestefich". Send between "Date: Tue, 22 May 2007 21:43:46 -0500" and "Date: Tue, 22 May 2007 22:18:55 -0500". (2 mails sent by the Appdb in that date range were legit actions.) I don't know if these are all, because admin-accounts were explicitly deleted and thus the notification to them stopped. The following applications where mentioned in these notification emails: Adobe Illustrator Battlefield 1942 Battlefield 2 Battlefield 2142 Call of Duty 2 Call of Duty Checkpoint Firewall-1 Policy editor Command & Conquer 3: Tiberium Wars Counter-Strike: Source Day of Defeat: Source Deus Ex Diablo II EVE Online F.E.A.R.: First Encounter Assault Recon Final Fantasy XI Online Guild Wars IDA Pro Photoshop S.T.A.L.K.E.R. : Shadow of Chernobyl Soldat Steam Supreme Commander The Elder Scrolls IV: Oblivion Trillian World of Warcraft PunkBuster Rune Igowin Age of Empires Age of Mythology Black & White Brothers in Arms Flash FlatOut .NET Framework Lotus Notes Some notifcations didn't contain a application of version, here the Message-Id-s of some examples (this is probably a bug in the Appdb code): screen shot Message-Id: <E1HqgpS-0008Ay-OM(a)wine.codeweavers.com> test result Message-Id: <E1Hqgs7-0001iH-S7(a)wine.codeweavers.com> monitor Message-Id: <E1HqgsD-0001mW-It(a)wine.codeweavers.com> bug Message-Id: <E1HqhDT-0003xe-GS(a)wine.codeweavers.com> One message about a rejected bug link seemed like these type of message don't contain any information: Message-Id: <E1Hqh5W-0000QE-UG(a)wine.codeweavers.com> On IRC from the #winehq channel: Mai 23 05:27:14 --> noerrorsfound_ (n=nicholas(a)h10.66.119.64.ip.alltel.net) has joined #winehq [unrelated stuff deleted] Mai 23 06:21:37 --- noerrorsfound_ is now known as molle-molle-moll Mai 23 06:21:41 <molle-molle-moll> molle molle molle Mai 23 06:21:42 <molle-molle-moll> molle Mai 23 06:21:51 <molle-molle-moll> molle Mai 23 06:22:03 <molle-molle-moll> mole string Mai 23 06:22:18 <molle-molle-moll> hello give thank Mai 23 06:22:18 <-- Amorphous has kicked molle-molle-moll from #winehq (Amorphous) /whois output: [06:22:38] --- [molle-molle-moll] (n=nicholas(a)h10.66.119.64.ip.alltel.net) : Nicholas [06:22:38] --- [whoismolle-molle-moll] irc.freenode.net :http://freenode.net/ [06:22:38] --- [molle-molle-moll] End of WHOIS list. 2007-05-23T06:50:15+0200 $ whois 64.119.66.10 OrgName: Windstream Communications Inc OrgID: WINDS-6 Address: 4001 Rodney Parham Rd City: Little Rock StateProv: AR PostalCode: 72212 Country: US NetRange: 64.119.64.0 - 64.119.79.255 CIDR: 64.119.64.0/20 NetName: WINDSTREAM-COMMUNICATIONS NetHandle: NET-64-119-64-0-1 Parent: NET-64-0-0-0-0 NetType: Direct Allocation NameServer: NS1-AUTH.WINDSTREAM.NET NameServer: NS2-AUTH.WINDSTREAM.NET NameServer: NS3-AUTH.WINDSTREAM.NET NameServer: NS4-AUTH.WINDSTREAM.NET Comment: ADDRESSES WITHIN THIS BLOCK ARE NON-PORTABLE RegDate: 2001-08-24 Updated: 2007-02-26 OrgAbuseHandle: WINDS1-ARIN OrgAbuseName: Windstream Abuse OrgAbusePhone: +1-888-292-3827 OrgAbuseEmail: abuse(a)windstream.net OrgTechHandle: WINDS-ARIN OrgTechName: Windstream Communications Inc OrgTechPhone: +1-800-990-4449 OrgTechEmail: ipadmin(a)windstream.net # ARIN WHOIS database, last updated 2007-05-22 19:10 # Enter ? for additional hints on searching ARIN's WHOIS database.

5 4

Re: wininet: Pass -1 into WideCharToMultiByte instead of calling lstrlenW on the string to slightly reduce code size.
by Alexandre Julliard May 24, 2007

May 24, 2007

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -504,8 +504,8 @@ static BOOL HTTP_DoAuthorization( LPWININETHTTPREQW lpwhr, LPCWSTR pszAuthValue > > if (is_basic_auth_value(pszAuthValue)) > { > - int userlen = WideCharToMultiByte(CP_UTF8, 0, domain_and_username, lstrlenW(domain_and_username), NULL, 0, NULL, NULL); > - int passlen = WideCharToMultiByte(CP_UTF8, 0, password, lstrlenW(password), NULL, 0, NULL, NULL); > + int userlen = WideCharToMultiByte(CP_UTF8, 0, domain_and_username, -1, NULL, 0, NULL, NULL); > + int passlen = WideCharToMultiByte(CP_UTF8, 0, password, -1, NULL, 0, NULL, NULL); This won't work, -1 is not equivalent to lstrlenW. -- Alexandre Julliard julliard(a)winehq.org

1 0

New winetricks: add support for Red Hat's liberation fonts
by Dan Kegel May 24, 2007

May 24, 2007

As requested by Mark Cox, I've added a verb to winetricks to install Red Hat's Liberation fonts (http://www.redhat.com/promo/fonts/) -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Re: winscard: add pcsc-lite helpers for upcoming implementation (try 2)
by Alexandre Julliard May 24, 2007

May 24, 2007

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > +/* > + * pcsc-lite functions pointers > + */ > +typedef LONG (*SCardEstablishContextPtr)(DWORD dwScope,LPCVOID pvReserved1, > + LPCVOID pvReserved2, LPSCARDCONTEXT phContext); > +typedef LONG (*SCardReleaseContextPtr)(SCARDCONTEXT hContext); > +typedef LONG (*SCardIsValidContextPtr)(SCARDCONTEXT hContext); > +typedef LONG (*SCardSetTimeoutPtr)(SCARDCONTEXT hContext, DWORD dwTimeout); > +typedef LONG (*SCardConnectPtr)(SCARDCONTEXT hContext,LPCSTR szReader,DWORD dwShareMode, > + DWORD dwPreferredProtocols,LPSCARDHANDLE phCard, LPDWORD pdwActiveProtocol); > +typedef LONG (*SCardReconnectPtr)(SCARDHANDLE hCard,DWORD dwShareMode, > + DWORD dwPreferredProtocols,DWORD dwInitialization, LPDWORD pdwActiveProtocol); > +typedef LONG (*SCardDisconnectPtr)(SCARDHANDLE hCard, DWORD dwDisposition); > +typedef LONG (*SCardBeginTransactionPtr)(SCARDHANDLE hCard); > +typedef LONG (*SCardEndTransactionPtr)(SCARDHANDLE hCard, DWORD dwDisposition); > +typedef LONG (*SCardCancelTransactionPtr)(SCARDHANDLE hCard); > +typedef LONG (*SCardStatusPtr)(SCARDHANDLE hCard,LPSTR mszReaderNames, LPDWORD pcchReaderLen, > + LPDWORD pdwState,LPDWORD pdwProtocol,BYTE* pbAtr,LPDWORD pcbAtrLen); > +typedef LONG (*SCardGetStatusChangePtr)(SCARDCONTEXT hContext,DWORD dwTimeout, > + LPSCARD_READERSTATEA rgReaderStates, DWORD cReaders); > +typedef LONG (*SCardControlPtr)(SCARDHANDLE hCard, DWORD dwControlCode, LPCVOID pbSendBuffer, > + DWORD cbSendLength,LPVOID pbRecvBuffer, DWORD cbRecvLength, LPDWORD lpBytesReturned); > +typedef LONG (*SCardTransmitPtr)(SCARDHANDLE hCard,LPCSCARD_IO_REQUEST pioSendPci, > + const BYTE* pbSendBuffer, DWORD cbSendLength, > + LPSCARD_IO_REQUEST pioRecvPci, BYTE* pbRecvBuffer, LPDWORD pcbRecvLength); > +typedef LONG (*SCardListReaderGroupsPtr)(SCARDCONTEXT hContext,LPSTR mszGroups, LPDWORD pcchGroups); > +typedef LONG (*SCardListReadersPtr)(SCARDCONTEXT hContext,LPCSTR mszGroups, > + LPSTR mszReaders, LPDWORD pcchReaders); > +typedef LONG (*SCardCancelPtr)(SCARDCONTEXT hContext); > +typedef LONG (*SCardGetAttribPtr)(SCARDHANDLE hCard, DWORD dwAttrId,BYTE* pbAttr, LPDWORD pcbAttrLen); > +typedef LONG (*SCardSetAttribPtr)(SCARDHANDLE hCard, DWORD dwAttrId,const BYTE* pbAttr, DWORD cbAttrLen); I don't think the pcsc-lite library is guaranteed to be binary compatible with the Windows definitions. You'll need to include the correct headers and convert data types between Windows and Unix definitions. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: FWD: Updated/add many Chinese simplified resource
by Detlef Riekenberg May 24, 2007

May 24, 2007

On Mi, 2007-05-23 at 02:17 +0800, Lobster DB wrote: > may i can't mailto: wine-patches(a)winehq.org It was automatic filtered for manual review, because the Mail/Attachment is to large. To get the Patches in the Tree, they must be much smaller! > change all *Zh.rc which is Chinese simplified resource to *Cn.rc > keep some *Zh.rc which is Chinese traditional > user32: user32_Zh.rc slipted for Chinese simplified (user32_Cn.rc) and > Chinese traditional (user32_Zh.rc) > comctl32: update Chinese simplified resource > comdlg32: update Chinese simplified resource > notepad: update Chinese simplified resource > progman: update Chinese simplified resource > user32: update Chinese simplified resource > winefile: update Chinese simplified resource > winhelp: update Chinese simplified resource > credui: add add Chinese simplified resource > clock: add Chinese simplified resource > regedit: add Chinese simplified resource > uninstaller: add Chinese simplified resource > winecfg: add Chinese simplified resource > winemine: add Chinese simplified resource A Changelog, that does not fit in the Subject is the main Hint, that the Patch needs to be split. I Suggest one Patch per DLL. When you need to rename a File, please do not update more than very, very few Tanslations in that Patch. The best way is to send a seperate Patch for the rename. As an Example for multiple Language-Versions in one File, you can read "Pt.rc" for winmine. After a short Talk with Alexandre, we think, that both versions (Traditional and Simplified) can go in a single File. About the encoding (from Alexandre): utf-8 is better, but that really depends on what's most convenient for you. Another Hint: Try the easy translations (Single Chinese Translation) first; wait with the difficult translations, until the easy Patches are in the tree. Thanks for your Help. -- By by ... Detlef

3 3

re: winscard: add pcsc-lite helpers for upcoming implementation
by Dan Kegel May 24, 2007

May 24, 2007

James wrote: > This would be a lot cleaner as: > > if (!(liteSCardEstablishContext = (SCardEstablishContextPtr) > wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr))) > { > ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); > goto error; > } I think in C you can skip the cast from void *, can't you? e.g. liteSCardEstablishContext = wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr)); if (!liteSCardEstablishContext) { ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); goto error; } -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: winscard: add pcsc-lite helpers for upcoming implementation
by Juan Lang May 23, 2007

May 23, 2007

+BOOL InitializePCSCLite(void) You don't use the return value: @@ -42,9 +43,11 @@ BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { DisableThreadLibraryCalls(hinstDLL); WINSCARD_hModule = hinstDLL; + InitializePCSCLite(); break; } I suspect it's safer not to fail loading winscard if PCSC-Lite isn't available. Instead, the functions such as SCardListCards should probably return empty lists. But knowing to do so relies on knowing that PCSC-Lite couldn't be initialized, so the return value shouldn't be thrown away. Or, remove the return value, and have every function check the function pointers it needs. --Juan ____________________________________________________________________________________Sick sense of humor? Visit Yahoo! TV's Comedy with an Edge to see what's on, when. http://tv.yahoo.com/collections/222

2 1

Re: help: test subprogram can't be console app
by Misha Koshelev May 23, 2007

May 23, 2007

Ok, never mind. I found a way to fool the Windows shell into allowing me to actually execute the appropriate console app while at the same time picking up the DDE string in a separate server (fail connection when it tries to connect first time in the DDE server in the process calling ShellExecute, then succeed the next time after it has launched the app, thus getting both the command line params and the DDE string; yay) Misha

1 0

Re: winscard: add pcsc-lite helpers for upcoming implementation
by James Hawkins May 23, 2007

May 23, 2007

On 5/23/07, Mounir IDRASSI <mounir.idrassi(a)idrix.fr> wrote: > Hi, > This patch adds helper variables and functions that exposes pcsc-lite > functionalities for the use of the upcoming implementation. > + /* loading entry points*/ + bSuccess = TRUE; + if (bSuccess && + !(liteSCardEstablishContext = (SCardEstablishContextPtr) wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr)))) + { + bSuccess = FALSE; + ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); + } This would be a lot cleaner as: if (!(liteSCardEstablishContext = (SCardEstablishContextPtr) wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr))) { ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); goto error; } .... return TRUE; error: wine_dlclose(g_pcscliteHandle,NULL,0); g_pcscliteHandle = NULL; return FALSE; } -- James Hawkins

1 0

help: test subprogram can't be console app
by Misha Koshelev May 23, 2007

May 23, 2007

Hi all, So I have run into a weird problem. I was writing a conformance test for ShellExecute logic of when to use DDE and a little about how it uses it, as currently the logic is incorrect and fails for some apps, e.g., Vector NTI (the fix is pretty easy, but I'd like to make a nice conformance test to go with it). Anyhow, shlexec.c conformance tests in shell32 have a nice framework where the test program itself is associated with an extension, and I just extended that to also allow a DDE execute and save the results. It didn't seem to work (FILENOTFOUND error) except when the program was already running, and then it worked fine. Just to see what was going on, I made a very simple program (attached) and used the following simple compile script to make 2 versions, one a console program and one a regular windows program (with the -mwindows switch). The -mwindows one allows DDE-based ShellExecute (or just "start" command) opening just fine, whereas withotu -mwindows the shell complains right away that the file trying to be started is not found. So it looks like I need to somehow start a non-console test program from within a test, any ideas on this? Thanks Misha --- Script: i386-mingw32-gcc -o console.exe -lshell32 -lole32 -loleaut32 -lshlwapi -luser32 -lgdi32 -ladvapi32 -lkernel32 -luuid -I. -I../../../include console.c i386-mingw32-gcc -o gui.exe -lshell32 -lole32 -loleaut32 -lshlwapi -luser32 -lgdi32 -ladvapi32 -lkernel32 -luuid -I. -I../../../include console.c -mwindows

1 0

Hello all
by Matthew Larsen May 23, 2007

May 23, 2007

Hello all, I just joined up to the mailing list so thought I would say hello to everyone :-) I am a student studying Computer Science at Manchester University (UK) and am interested in helping the development of Wine. I decided the first step was to hop on the mailing lists and see whats going on! I have experience in writing basic Operating Systems (In ARM Assembler, as well as making ARM's work with FPGA's if your interested) and knowledge of fundamental OS functions so I hope they will come in useful at some stage. Also got a good grasp of C/C++, UNIX and Windows / Windows Server. My motivation with joining Wine was primarily to one-day get Counterstrike:Source working properly. Secondary is the fact I am fed-up completely with Windows but unfortunately have apps that are not supported in Linux / Unix and would like to get them ported onto Wine. Hope to get talking with you all soon, Regards, -- Matthew G Larsen > mat.larsen(a)gmail.com > +44(0)7739 785 249

2 1

tests: show summary and last executed test in case of a crash
by Peter Oberndorfer May 23, 2007

May 23, 2007

Some tests on http://test.winehq.org/data/ seem to crash silently. This patch might be useful for debugging such crashes. It prints out the last ok/trace that was executed before the crash, the exception address and the type of the crash. It also print out the summary that is normally printed at the end of the test instead of exiting silently[1]. On wine it still executes winedbg for better debugging after dumping out the info. My concern now is that it requires a change to the parser which accepts the test reports, so those crashes are not lost. And don't know much about this parser. Suggestions, ideas anyone? Greetings Peter [1] example output: file.c:1228:FileSize: 0 file.c:1229:Unknown2[0]: 0 Test crashed at B7D0DF47 with error c0000005 Last test before crash: file.c:1239 file: 19 tests executed (0 marked as todo, 3 failures), 0 skipped. wine: Unhandled page fault on write access to 0x00001234 at address 0xb7d0df47 (thread 0009), starting debugger... Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b ...

2 2

Re: Bugzilla outcome?
by Robert Shearman May 23, 2007

May 23, 2007

Tom Spear wrote: > Just curious to see if anything was ever done with the offer to > upgrade bugzilla? > > On a side note, it would be nice if there was a crash keyword to make > finding crashes easier Searching for "Unhandled exception" is too hard? -- Rob Shearman

5 8

Re: crypt32: implement CryptSIPLoad (resend)
by Alexandre Julliard May 23, 2007

May 23, 2007

Juan Lang <juan_lang(a)yahoo.com> writes: > Hi, any problems with this one? It's causing test failures: ../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok rsaenh.c:64: Test failed: 0, 00000057 rsaenh.c:68: Test failed: 00000057 make: *** [rsaenh.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 3

RE: Application deletion!
by EA Durbin May 23, 2007

May 23, 2007

Someone using Molle Bestefich's account has been attacking the AppDB. I've lost my AppDB admin privileges as well as a bunch of things are being deleted. >From: James Bond <tehstealth(a)yahoo.com> >To: appdb(a)winehq.org >Subject: Application deletion! >Date: Wed, 23 May 2007 04:40:49 -0700 (PDT) > >I'm sorry, I do not know who to contact for this, but the 2 apps I've been >maintaining Soldat, and Battlefield 2 have BOTH been completely deleted! >At first it was Soldat, and I thought maybe since it was a small game made >by a lone developer, it was removed. I e-mailed the person resposnible, toa >ask why. But I just got another mass spam of e-mails this morning saying >this and that were deleted from Battlefield 2, a very popular game! I think >something is wrong. Molle Bestefich (molle.bestefich(a)gmail.com) is the one >whose deleted all of that stuff. What is going on? > >-Brian > > > >____________________________________________________________________________________Ready >for the edge of your seat? >Check out tonight's top picks on Yahoo! TV. >http://tv.yahoo.com/ _________________________________________________________________ More photos, more messages, more storageget 2GB with Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

2 1

Re: RegDeleteTree [8]
by Alexandre Julliard May 23, 2007

May 23, 2007

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + /* Recursively delete all the subkeys */ > + for (i = 0; i < dwKeyCount; i++) { > + dwSize = dwMaxLen; > + ret = RegEnumKeyExW(hSubKey, 0, lpszName, &dwSize, NULL, > + NULL, NULL, NULL); There's no reason to use the key count, you should enum until you get an error, it's more reliable. > + for (i = 0; i < dwValCount; i++) { > + dwSize = dwMaxLen; > + ret = RegEnumValueW(hKey, 0, lpszName, &dwSize, NULL, NULL, NULL, NULL); Same here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] DDraw: Hold the dll lock in IDirectDrawSurfaceX methods
by Alexandre Julliard May 23, 2007

May 23, 2007

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > @@ -810,8 +841,12 @@ IDirectDrawSurfaceImpl_AddAttachedSurface(IDirectDrawSurfaceImpl *This, > { > TRACE("(%p)->(%p)\n", This, Surf); > > + EnterCriticalSection(&ddraw_cs); > if(Surf == This) > + { > + LeaveCriticalSection(&ddraw_cs); > return DDERR_CANNOTATTACHSURFACE; /* unchecked */ > + } Parameter checks can be done outside the section, it simplifies the code. There are many more such cases in the patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] check return code of ICreateDevEnum_CreateClassEnumerator
by Alexandre Julliard May 23, 2007

May 23, 2007

Marcus Meissner <marcus(a)jet.franken.de> writes: > diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c > index 6adce61..841b130 100644 > --- a/dlls/quartz/filtermapper.c > +++ b/dlls/quartz/filtermapper.c > @@ -966,6 +966,9 @@ static HRESULT WINAPI FilterMapper2_Enum > if (SUCCEEDED(hr)) > hr = ICreateDevEnum_CreateClassEnumerator(pCreateDevEnum, &CLSID_ActiveMovieCategories, &pEnumCat, 0); > > + if (!SUCCEEDED(hr)) > + return hr; You are potentially leaking an object here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] basetsd.h: Fix a typo in the parameter name
by Marcus Meissner May 23, 2007

May 23, 2007

On Wed, May 23, 2007 at 04:35:33PM +0900, Dmitry Timoshkov wrote: > Hello, > > Changelog: > basetsd.h: Fix a typo in the parameter name. > > --- > include/basetsd.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index e0d04f6..fe3639f 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -219,7 +219,7 @@ typedef unsigned short UHALF_PTR, *PUHALF_PTR; > #define HandleToULong(h) ((ULONG)(ULONG_PTR)(h)) > #define HandleToLong(h) ((LONG)(LONG_PTR)(h)) > #define ULongToHandle(ul) ((HANDLE)(ULONG_PTR)(ul)) > -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) > +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I do not think this is right. Ciao, Marcus

2 1

[1/5] basetsd.h: Fix a typo in the parameter name
by Vijay Kiran Kamuju May 23, 2007

May 23, 2007

Hi I think this patch is not correct. -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I dont see 'l' defined or sent to this macro any where. Thanks, VJ

3 2

APPDB ROGE USER
by Vitaliy Margolen May 22, 2007

May 22, 2007

ANYONE WITH appdb admin rights check into IRC!!!

1 0

Re: winscard: small stub implementation of winscard dll (Try 2)
by Mounir IDRASSI May 22, 2007

May 22, 2007

Hi Alexandre, You are completely right...these variables are definitely useless!! I don't remember when I coded that but it must have been very late at night! Anyway, I'll purge them from the patch. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Alexandre Julliard wrote: > Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: >> Thank you for your comments Alexandre. >> Concerning the SCARD_PCI_xxx , I implemented them as variables instead >> of defines because it's impossible using winelib to link against the >> exported variables g_rgSCardXXX (please see my discussion with Eric >> Pouech about that). Well, I should create variables with other names to >> achieve the same goal. >> > Linking against SCARD_PCI_xxx would be just as impossible, so I still > don't understand why you need any extra variables. Could you give an > example? >

1 0

Re: RegDeleteTree [7] [resend]
by Laurent Vromman May 22, 2007

May 22, 2007

There is a few tabs in the file : Here (line 92), first blank character : + &dwValCount, NULL, NULL, NULL, NULL); Here (line 103) + } Laurent > Hello, > > any comment on the current version of this patch? > > ChangeLog > ------------- > added implementation of RegDeleteTreeA/W > >

2 2

Re: Bugzilla outcome?
by Tom Spear May 22, 2007

May 22, 2007

I sent this to the wrong list before, sorry for that.. Just curious to see if anything was ever done with the offer to upgrade bugzilla? On a side note, it would be nice if there was a crash keyword to make finding crashes easier -- Thanks Tom

1 0

Re: winscard: small stub implementation of winscard dll (Try 2)
by Alexandre Julliard May 22, 2007

May 22, 2007

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > +BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("%p,%x,%p\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) > + { > + case DLL_PROCESS_ATTACH: > + { > + DisableThreadLibraryCalls(hinstDLL); > + WINSCARD_hModule = hinstDLL; > + /* initialize protocol requests pointers */ > + SCARD_PCI_T0 = &g_rgSCardT0Pci; > + SCARD_PCI_T1 = &g_rgSCardT1Pci; > + SCARD_PCI_RAW = &g_rgSCardRawPci; AFAICT these are supposed to be macros, not variables. Also your indentation is messed up. -- Alexandre Julliard julliard(a)winehq.org

1 0