May 2007 - Wine-Devel - list.winehq.org

Internet explorer not detected
by Louis Lenders May 12, 2007

May 12, 2007

Hi, i tried help this dude on IRC channel getting an application to run called MegaSpoof. Even after creating fake registry key it kept complaining about missing Internet Explorer. After looking through the +relay log i found this: 000d:Call KERNEL32.CreateProcessW(00000000,0034f428 L"c:\\Program Files\\Internet Explorer\\iexplore.exe -Embedding",0000000 0,00000000,00000000,00000000,00000000,00000000,0034f7d8,0034f828) ret=77f1d75f 000d:Ret KERNEL32.CreateProcessW() retval=00000000 ret=77f1d75f In current wine a simple "wine "c:\Program Files\Internet Explorer\iexplore.exe"" just fails , because we don't have that directory. After manually creating it , and copy iexplore.exe.so to /Program Files/Internet Explorer/iexplore.exe, the application didn't complain anymore, and got further. Question: do we need to mimic windows behaviour, and create that directory + put wine's iexplore in it, or is the policy that in this case we just have to download MS ie6, and install that (as the application suggested)

5 5

Re: check for This->clipper before unreferencing in dlls/ddraw/surface.c
by Stefan Dösinger May 12, 2007

May 12, 2007

Am Samstag 12 Mai 2007 15:00 schrieb Vincent Fourmond: > (IDirectDrawSurfaceImpl_SetClipper): fixes segfault at HMMIV startup. > --- > ChangeLog | 6 ++++++ > dlls/ddraw/surface.c | 5 +++-- > 2 files changed, 9 insertions(+), 2 deletions(-) Now that wined3d stores the clipper, the surface->clipper member should be removed and GetClipper and SetClipper should use wined3dsurface::getclipper and Setclipper(like setpalette and getpalette does). also you do not have to modify the ChangeLog file, git does that automatically when AJ commits the patch. Also please stick to the formating of the rest of the file / function. Here you used tabs instead of spaces for indention.

2 1

Re: PATCH - implement LockWorkStation using xdg-screensaver
by Steven Edwards May 12, 2007

May 12, 2007

Hi Hans, On 5/12/07, Hans Leidekker <hans(a)it.vu.nl> wrote: > How about the following patch? I added an option --lock to wineboot > which does an execvp using the Unix search path. LockWorkStation > then calls CreateProcess on "wineboot --lock", analogous to what > ExitWindowsEx does. Thanks a lot. I just checked and LockWorkStation now properly handles the call from ProcessExplorer. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: PATCH - implement LockWorkStation using xdg-screensaver
by Steven Edwards May 12, 2007

May 12, 2007

Hi Hans, On 5/12/07, Hans Leidekker <hans(a)it.vu.nl> wrote: > How about the following patch? I added an option --lock to wineboot > which does an execvp using the Unix search path. LockWorkStation > then calls CreateProcess on "wineboot --lock", analogous to what > ExitWindowsEx does. > > When running in a virtual desktop we should probably give precedence > to a Windows screensaver. > > Changelog > Implement LockWorkStation using xdg-screensaver. Your patch seems like a much better method to me. I'll merge in to my tree and test with Process Explorer tonight. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [PATCH] no wined3ddevice - no surface
by Stefan Dösinger May 12, 2007

May 12, 2007

Am Samstag 12 Mai 2007 16:20 schrieb Marcus Meissner: > Hi, > > If wineD3DDevice is not set, than do return > failure (and do not reference NULL ifaces). Actually the ddraw object shouldn't be createable in the first place without a wined3d device object. Or do you want to modify ddraw to do something without wined3d?

2 1

include: Include local not system sql.h header
by Andrew Talbot May 12, 2007

May 12, 2007

I have just sent in a patch to use Wine's sql.h instead of the system one, because I noticed that the latter includes <sqltypes.h>, which appears to redefine DWORD as unsigned long, based on its reckoning that the size of a long integer is four bytes on default platforms, whereas - with _MSC_VER undefined - DWORD is an unsigned int. However, I now see that Wine's sql.h includes sqltypes.h, too. So my patch may be unnecessary or wrong, but should odbcinst.h preceed its inclusion of sql.h with some sort of definition of SIZEOF_LONG to prevent this redefinition? Please advise. Thanks, -- Andy.

1 1

Re: PATCH - implement LockWorkStation using xdg-screensaver
by Marcus Meissner May 12, 2007

May 12, 2007

On Sat, May 12, 2007 at 06:13:42AM -0400, Steven Edwards wrote: > Hi, > This patch was an attempt to implemented LockWorkStation using > xdg-screensaver. It works for my simple test app that calls the > function but my real world application Process Explorer ends up > hanging now rather than crashing and still does not properly lock the > workstation. I am not quite sure why. Perhaps someone else is > interested in this to help improve wine usability. Also I guess I > should use HeapAlloc rather than malloc. > > -- > Steven Edwards > > "There is one thing stronger than all the armies in the world, and > that is an idea whose time has come." - Victor Hugo > From 8e7001c9e3309492c881e9c1f717f26e3e379dfb Mon Sep 17 00:00:00 2001 > From: Steven Edwards <winehacker(a)gmail.com> > Date: Sat, 12 May 2007 05:49:52 -0400 > Subject: [PATCH] Implemented LockWorkStation using xdg-screensaver > > + * LockWorkStation (USER32.@) > + */ > +BOOL WINAPI LockWorkStation(void) > +{ > + /* Use xdg-screensaver */ > + static const char screensaver[] = "/usr/bin/xdg-screensaver"; > + static const char lock_command[] = "lock"; > + char **argv; > + > + FILE *f = fopen( screensaver, "r" ); > + if (!f) > + { > + FIXME_(graphics)( "no support for xdg-screensaver detected\n"); > + return 0; > + } You should use either stat/lstat or just check for failure from execve. > + argv = xmalloc(sizeof(lock_command)); > + memcpy( argv[1] , lock_command, sizeof(lock_command)); This is not going to work. char *argv[2]; argv[0] = "/usr/bin/xdg-screensaver"; argv[1] = "lock"; argv[2] = NULL; > + execv( screensaver, argv ); And actually you cannot use execve(), since it replaces the current process with the new one. Use system("/usr/bin/xdg-screensaver lock") or CreateProcess(). Ciao, Marcus

1 0

Fast events
by Maarten Lankhorst May 12, 2007

May 12, 2007

Hi all, Since I'm trying to improve on winmm's timing scheduling, the best improvement I can find is getting rid of the wineserver calls, they add a huge delay to the timer and that is bad for something that should sleep all the time to get better scheduling. I tried sending in a patch that used linux sockets but it was rejected. Similar patches already do exist: winealsa and wineoss use them, some other sound drivers might use them too. Instead of duplicating that code everywhere I think it's better to add a generic implementation of it that can very easily be changed back to a win32 implementation. What are your thoughts on this? Maarten fevent patch attached. >From 5e5cb0a326f51dc2edef245fcaab4a071f9e0c42 Mon Sep 17 00:00:00 2001 From: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> Date: Sat, 12 May 2007 15:19:45 +0200 Subject: [PATCH] wine headers: introduce fevent interface --- include/wine/fevent.h | 145 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 145 insertions(+), 0 deletions(-) diff --git a/include/wine/fevent.h b/include/wine/fevent.h new file mode 100644 index 0000000..e80391d --- /dev/null +++ b/include/wine/fevent.h @@ -0,0 +1,145 @@ +/* + * Fast event interface + * Use this for when default wineserver calls are extremely bad for time critical usages + * This is also REALLY *ONLY* useful in case of 1 thread doing a 'WaitForSingleObject' + * else weird effects might occur. If someone wants to use this in any other way, results + * are undetermined. + * + * Copyright (C) 2007 Maarten Lankhorst + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#ifndef __WINESRC__ +#error This should only be used internally +#endif + +#ifndef __WINE_WINE_FEVENT_H +#define __WINE_WINE_FEVENT_H + +#if (defined(HAVE_POLL_H) || defined(HAVE_SYS_POLL_H)) && !defined(WINE_FEVENT_USE_EVENT) + +#ifdef HAVE_POLL_H +#include <poll.h> +#endif +#ifdef HAVE_SYS_POLL_H +#include <sys/poll.h> +#endif + +#include <errno.h> + +WINE_DECLARE_DEBUG_CHANNEL(fevent); + +struct TAGfevent { + int fd[2]; + DWORD manreset; +}; + +typedef struct TAGfevent *FEVENT; + +static void reset_fd(FEVENT fev) +{ + char readme; + struct pollfd pfd; + pfd.fd = fev->fd[0]; + pfd.events = POLLIN; + while (poll(&pfd, 1, 0) > 0) + read(fev->fd[0], &readme, sizeof(readme)); +} + +static void set_fd(FEVENT fev) +{ + char foo = 'A'; + + write(fev->fd[1], &foo, sizeof(foo)); +} + +static FEVENT create_fd(LPSECURITY_ATTRIBUTES lpEventAttributes, BOOL bManualReset, BOOL bInitialState, LPCWSTR lpName) +{ + FEVENT fev = HeapAlloc(GetProcessHeap(), 0, sizeof(*fev)); + + if (!fev) + goto err; + + if (lpEventAttributes || lpName) + FIXME_(fevent)("FEVENTS are meant to be internal and shouldn't have security attributes or a name\n"); + + if (pipe(fev->fd) < 0) + { + fev->fd[0] = fev->fd[1] = -1; + goto err; + } + fev->manreset = bManualReset; + if (bInitialState) + set_fd(fev); + return fev; + + err: + if (fev) + { + close(fev->fd[0]); + close(fev->fd[1]); + HeapFree(GetProcessHeap(), 0, fev); + } + return NULL; +} + +static void close_fd(FEVENT fev) +{ + close(fev->fd[0]); + close(fev->fd[1]); + fev->fd[0] = fev->fd[1] = -1; + HeapFree(GetProcessHeap(), 0, fev); +} + +static DWORD poll_fd(FEVENT fev, DWORD timeout) +{ + int err; + struct pollfd pfd; + pfd.fd = fev->fd[0]; + pfd.events = POLLIN; + + while ((err = poll(&pfd, 1, (int)timeout)) == -1) + if (errno != EAGAIN && errno != EINTR) + break; + switch (err) + { + case 0: return WAIT_TIMEOUT; + case -1: return WAIT_FAILED; + default: + if (!fev->manreset) + reset_fd(fev); + return WAIT_OBJECT_0; + } +} + +#define RESETEVENT reset_fd +#define SETEVENT set_fd +#define CREATEEVENT create_fd +#define CLOSEEVENT close_fd +#define WAITEVENT poll_fd + +#else + +#define FEVENT HANDLE +#define RESETEVENT ResetEvent +#define SETEVENT SetEvent +#define CREATEEVENT CreateEventW +#define CLOSEEVENT CloseHandle +#define WAITEVENT WaitForSingleObject + +#endif + +#endif /* __WINE_WINE_FEVENT_H */ -- 1.4.4.2

1 0

Re: PATCH - implement LockWorkStation using xdg-screensaver
by Stefan Dösinger May 12, 2007

May 12, 2007

Am Samstag 12 Mai 2007 12:13 schrieb Steven Edwards: > Hi, > This patch was an attempt to implemented LockWorkStation using > xdg-screensaver. It works for my simple test app that calls the > function but my real world application Process Explorer ends up > hanging now rather than crashing and still does not properly lock the > workstation. I am not quite sure why. Perhaps someone else is > interested in this to help improve wine usability. Also I guess I > should use HeapAlloc rather than malloc. Yeah, you should use HeapAlloc, and perhaps remove the xmalloc() wrapper :-) . If you test for the existence of xdg-screensaver that way you should close the opened file afterwards. If I remember correctly execvp would check $PATH for the file, so you don't have to hardcode /usr/bin/xdg-screensaver, but I think some "winescreensaver" program simmilar to winebrowser which is configureable via a registry setting would be even better. Also you should return TRUE and FALSE instead of 1 and 0.

1 0

Re: [PATCH] initialize pSurface, since we process it on failure
by Stefan Dösinger May 12, 2007

May 12, 2007

Am Samstag 12 Mai 2007 11:39 schrieb Marcus Meissner: > Hi, > > Not sure if we should perhaps not do the ICOM CAST magic on a failing > CreateSurface call here. > > But initializing pSurface to NULL also helps. The ICOM_CAST thing should set the output to NULL of the surface returned by ddraw7_CreateSurface is NULL, but ddraw7 doesn't always set it to NULL. I wanted to write a test for this because some calls leave the output pointer untouched if they fail and some set it to NULL. AJ also says we should replace transgamings com casting macros with inline functions.

1 0

Current behavior of netapi32-access tests on W2K3 and Vista
by Paul Vriens May 12, 2007

May 12, 2007

Hi, Not so long ago some tests where added for NetUserAdd and friends. While browsing I found that I have about 6 testuser home directories on W2K3 and 4 on Vista (which is the amount of tests I ran on those platforms). Bottom-line is that NetUserDel doesn't delete the home-directory on W2K3 and Vista (which is a good thing) but has no option to delete it explicitly (which is a bad thing IMHO). Any idea how to cleanup after these tests? Just remove the home directory? Cheers, Paul.

2 1

mandriva rpm wine 0.9.37
by marco May 11, 2007

May 11, 2007

As I have still no way to upload the mandriva wine rpm to the official winehq download server. I put it on my own website. So mandriva users you can download the latest wine binaries here: http://www.xs4all.nl/~meijer2/wine/ kind regard, Marco

1 0

Re: [PATCH] Uninstaller: Use a define'd length instead of a magic number
by James Hawkins May 11, 2007

May 11, 2007

On 5/10/07, Tom Spear <speeddymon(a)gmail.com> wrote: > MAX_STRING_LEN is defined in resource.h at 255. According to > http://msdn2.microsoft.com/en-us/library/ms724872.aspx the limit for > the length of a subkey name is 255. > > >> Please let me know if I should make a new define instead of using > MAX_STRING_LEN. > Yes, you should make a new define. MAX_STRING_LEN is the maximum length for a string from the resource file, which is totally unrelated to the limit for the length of a subkey name. -- James Hawkins

8 8

re: kernel32: Implement most of CopyFileEx
by Dan Kegel May 11, 2007

May 11, 2007

Nice to see somebody filling in the gaps like this. A few nits based on a superficial reading: CopyFileA leaks a string. (I know, it did before your change, too.) copy_file_open_dest's interface comment has the wrong name. + for(i = 0; i < sizeof(flags) / sizeof(flags[0]); i++) + { + if(for_write) { Please use the same whitespace conventions as in the rest of the file (in particular, leave a space after keywords like for and if). + if ((h1 = copy_file_open_source(source, copyFlags & COPY_FILE_OPEN_SOURCE_FOR_WRITE)) == INVALID_HANDLE_VALUE) That line's too long... try to keep them under 80 chars. + // FIXME: total_file_size should include the sum of all streams Use C comments, not C++ comments. + DWORD result = progressRoutine(total_file_size, total_bytes_transferred, stream_size, stream_bytes_transferred, + stream_number, CALLBACK_STREAM_SWITCH, h1, h2, appData); Another instance of line longer than 80 chars. (You have several.) You don't have a conformance test, nor was there one for CopyFile. Maybe you should consider writing one, and making sure it passes both on Wine and Windows. Say, what app is this for? - Dan

4 5

Re: wined3d: Add hardware cursor support.
by Stefan Dösinger May 11, 2007

May 11, 2007

Am Freitag 11 Mai 2007 02:34 schrieb Andrew Riedi: > I made a test to figure out the exact Windows behavior, and Stefand helped > me out in telling me what to test. This code behaves how it should. I > will send the test in later once I have cleaned it up. > > changelog: wined3d: Add hardware cursor support. > + if (This->hardwareCursor) DestroyCursor(This->hardwareCursor); > + if (This->haveHardwareCursor) This->haveHardwareCursor = FALSE; Is there a specific reason to test if This->haveHardwareCursor is true before setting it to false? Or would a plain This->haveHardwareCursor = FALSE work too? Otherwise looked fine to me

1 0

Re: [8/8] DDraw: Make IDirectDrawImpl thread safe
by Alexandre Julliard May 11, 2007

May 11, 2007

Stefan Dösinger <stefan(a)codeweavers.com> writes: > @@ -2731,9 +2792,13 @@ IDirectDrawImpl_EnumSurfaces(IDirectDraw7 *iface, > desc = surf->surface_desc; > IDirectDrawSurface7_AddRef(ICOM_INTERFACE(surf, IDirectDrawSurface7)); > if(Callback( ICOM_INTERFACE(surf, IDirectDrawSurface7), &desc, Context) != DDENUMRET_OK) > + { > + DDOBJ_UNLOCK(This); > return DD_OK; > + } It don't think you can call an arbitrary callback function with the lock held. -- Alexandre Julliard julliard(a)winehq.org

2 1

sprintfW formatting in lib\wine\string.c
by Ann & Jason Edmeades May 11, 2007

May 11, 2007

Whilst trying to convert cmd to Unicode, I've stumbled across a problem which I either need to work around or fix, and I am not sure which. WCHAR h[] = {'h','e','l','l','o','\0'}; WCHAR fmt[] = {':', '%', '1', '0','s',':','\0'}; char test[255]; WCHAR result[255]; sprintf(test, "'%10s'", "hello"); sprintfW(result, fmt, h); WINE_FIXME("%s vs %s\n", test, wine_dbgstr_w(result)); Gives: fixme:cmd:WCMD_list_directory ' hello' vs L":hello:" ie sprintf of %10s means right justified field of 10 characters sprintfW of %10s gives left justified field of n characters (I haven't tried if the string is > 10, as I don't care...) Basically, the format strings in cmd rely on the padding behaviour. Is this a bug in sprintfW which needs fixing, or should I work around it? Unfortunately, looking in the code to lib\wine\string.c, it just copies the field and ignores justification or min/max width precisions for strings, and as it is used all over the place there's also a concern of what would be changed by fixing it. Any suggestions for a workable alternative? Jason

2 1

Re: Adds NET START to net.exe
by Alexandre Julliard May 11, 2007

May 11, 2007

"Tim Schwartz" <tim(a)sanityinternet.com> writes: > + if(!strcasecmp(argv[1], "start")) > + { > + if(argc < 3) > + { > + printf("Specify service name to start.\n"); > + return TRUE; > + } > + > + if(!net_service(NET_START, argv[2])) > + { > + return TRUE; > + } > + return FALSE; > + } > + > + return FALSE; The previous version was better here, TRUE and FALSE are not appropriate return values for main(), it's supposed to return an error code not a boolean. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: crypt32: implement CryptSIPLoad (try 3)
by Paul Vriens May 11, 2007

May 11, 2007

Juan Lang wrote: > - todo_wine > - { > - ok ( ret, "Expected CryptSIPLoad to succeed\n"); > - /* This error will always be there as native searches for the function DllCanUnloadNow > - * in WINTRUST.DLL (in this case). This function is not available in WINTRUST.DLL. > - * For now there's no need to implement this is Wine as I doubt any program will rely on > - * this last error when the call succeeded. > - */ > - ok ( GetLastError() == ERROR_PROC_NOT_FOUND, > - "Expected ERROR_PROC_NOT_FOUND, got 0x%08x\n", GetLastError()); > - ok( sdi.pfGet != (pCryptSIPGetSignedDataMsg)0xdeadbeef, "Expected a function pointer to be loaded.\n"); > - } > + ok ( ret, "Expected CryptSIPLoad to succeed\n"); > + ok( sdi.pfGet != (pCryptSIPGetSignedDataMsg)0xdeadbeef, "Expected a function pointer to be loaded.\n"); > > /* The function addresses returned by CryptSIPLoad are actually the addresses of > * crypt32's own functions. A function calling these addresses will end up first > @@ -348,18 +337,8 @@ static void test_SIPLoad(void) > sdi.cbSize = sizeof(SIP_DISPATCH_INFO); > sdi.pfGet = (pCryptSIPGetSignedDataMsg)0xdeadbeef; > ret = CryptSIPLoad(&unknown2, 0, &sdi); > - todo_wine > - { > - ok ( ret, "Expected CryptSIPLoad to succeed\n"); > - /* This call on it's own would have resulted in a ERROR_PROC_NOT_FOUND, but the previous > - * call to CryptSIPLoad already loaded wintrust.dll. As this information is cached, > - * CryptSIPLoad will not try to search for the already mentioned DllCanUnloadNow. > - */ > - } > - ok ( GetLastError() == 0xdeadbeef, > - "Expected 0xdeadbeef, got 0x%08x\n", GetLastError()); > - todo_wine > - ok( sdi.pfGet != (pCryptSIPGetSignedDataMsg)0xdeadbeef, "Expected a function pointer to be loaded.\n"); > + ok ( ret, "Expected CryptSIPLoad to succeed\n"); > + ok( sdi.pfGet != (pCryptSIPGetSignedDataMsg)0xdeadbeef, "Expected a function pointer to be loaded.\n"); > > /* All OK, but other SIP */ > SetLastError(0xdeadbeef); > > > ------------------------------------------------------------------------ > > Hi Juan, Why did you remove all the comments from the test? It does explain (a little bit) how native does get to this specific lasterror. I agree that the lasterror is not very valuable. I've spent quite some time figuring this stuff out and it seems that (at least to my perception) information gets lost. Cheers, Paul.

1 0

Re: [4/8] WineD3D: Destroying the resource frees all private data
by H. Verbeet May 10, 2007

May 10, 2007

On 10/05/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > - } > + }; Any particular reason for this change? > + if (Flags & WINED3DSPD_IUNKNOWN) { > + if(SizeOfData != 4) { > + WARN("IUnknown data with size %d, returning WINED3DERR_INVALIDCALL\n", SizeOfData); > + return WINED3DERR_INVALIDCALL; This looks rather questionable to me. Are you making an assumption about the size of a pointer here or is 4 some magic constant? > - list_add_tail(&This->resource.privateData, &data->entry); > - return WINED3D_OK; > - ... > + list_init(&data->entry); > + list_add_tail(&This->resource.privateData, &data->entry); > > return WINED3D_OK; Is the added list_init() intentional here? Looks redundant to me, if you're doing a list_add_tail() right afterwards anyway.

2 1

Re: [PATCH 2/2] msi: automation: Implement Installer::RegistryValue.
by Alexandre Julliard May 10, 2007

May 10, 2007

Misha Koshelev <mk144210(a)bcm.edu> writes: > + case VT_BSTR: /* Return value of specified key if it exists */ > + if (ret == ERROR_SUCCESS) > + { > + ret = RegQueryValueExW(hkey, V_BSTR(&varg2), NULL, NULL, NULL, &dwSize); > + if (ret == ERROR_SUCCESS) > + { > + szString = msi_alloc(dwSize); > + if (szString) > + { > + LPWSTR szNewString = NULL; > + DWORD dwType, dwNewSize = 0; > + int idx; > + > + ret = RegQueryValueExW(hkey, V_BSTR(&varg2), NULL, &dwType, (LPBYTE)szString, &dwSize); > + switch (dwType) > + { > + /* Registry strings may not be null terminated */ > + case REG_MULTI_SZ: > + idx = (dwSize/sizeof(WCHAR))-1; > + while (idx >= 0 && !szString[idx]) idx--; > + for (; idx >= 0; idx--) > + if (!szString[idx]) szString[idx] = '\n'; > [...] This stuff clearly needs to be split out into a few helper functions. -- Alexandre Julliard julliard(a)winehq.org

2 1

[5/8] WineD3D: Implement DDBLT_DEPTHFILL on the active depth stencil target
by Stefan Dösinger May 10, 2007

May 10, 2007

1 1

re: blizzard conference
by Dan Kegel May 10, 2007

May 10, 2007

Hey, that's only an hour away, maybe I / Lei / Nigel can drop by. But what's the "itchy /etc/hosts bug"? Is that http://bugs.winehq.org/show_bug.cgi?id=7929 ? - Dan

8 12

Re: [5/5] widl: Remove var_t's ptr_level field and start write_pointers
by Dan Hipschman May 10, 2007

May 10, 2007

On Thu, May 10, 2007 at 10:39:31AM -0700, Duane Clark wrote: > Dan Hipschman wrote: > >Well, I sent this quite a while ago and it hasn't shown up on the list yet. > >It's probably too big, so here's a link to the patch instead of inlining > >it. > > > > Patches over 80KB will go to a queue for moderation. I am the only one > moderating, so just be patient. I'll get around to it eventually. OK, I didn't know that and assumed it just got nuked. It appears to have just shown up on the list. :-) Thanks

1 0

Re: [3/5] widl: Simplify make_safearray
by Robert Shearman May 10, 2007

May 10, 2007

Dan Hipschman wrote: > This patch just simplifies the make_safearray function. It didn't need > to be that complicated. I tested the generated headers and typelibs > with this patch applied (well, I do that with every patch in this series), > and this doesn't change anything. > Is dlls/oleaut32/tests/tmarshal.tlb identical compared to before this patch is applied? If not, you won't get test failures in Wine, but you will when running tests in Windows. -- Rob Shearman

2 1