May 2007 - Wine-Devel - list.winehq.org

Re: [1/5] wined3d: Unload vertex weight data in case of EXT_VERTEX_WEIGHTING as well
by Stefan Dösinger May 9, 2007

May 9, 2007

Am Mittwoch 09 Mai 2007 19:07 schrieb H. Verbeet: > This set applies on top of Stefan's > > Changelog: > - Unload vertex weight data in case of EXT_VERTEX_WEIGHTING as well Actually I was thinking about removing the whole (disabled) vertex weighting code since I didn't find any card supporting this extension.

1 0

Re: [msi/tests] Properly cleanup after each test
by James Hawkins May 9, 2007

May 9, 2007

On 5/8/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > All files in the destination directory (usually 'Program Files') are cleaned up, > but sometimes not the files/directories in the temp directory. We have to make > sure we have a clean start for every test. > > I've also changed a filename from 'path' to a clearer one (me thinks). > - CHAR path[MAX_PATH]; + CHAR msifile2[MAX_PATH]; CreateDirectoryA("msitest", NULL); CreateDirectoryA("msitest\\msitest", NULL); @@ -1451,9 +1460,9 @@ static void test_concurrentinstall(void) create_database(msifile, ci_tables, sizeof(ci_tables) / sizeof(msi_table)); - lstrcpyA(path, CURR_DIR); - lstrcatA(path, "\\msitest\\concurrent.msi"); - create_database(path, ci2_tables, sizeof(ci2_tables) / sizeof(msi_table)); + lstrcpyA(msifile2, CURR_DIR); + lstrcatA(msifile2, "\\msitest\\concurrent.msi"); + create_database(msifile2, ci2_tables, sizeof(ci2_tables) / sizeof(msi_table)); Please don't change the names of variables. I chose the generic name of path (which is used throught Wine), because that's exactly what the variable contains throughout the functions. Also, msifile2 is a poor choice of a variable name. Thanks, James Hawkins

2 1

Re: [PATCH] Uninstaller: Change hardcoded value for maximum subkey name length to a const.
by Dan Hipschman May 9, 2007

May 9, 2007

On Tue, May 08, 2007 at 11:19:16AM -0500, Tom Spear wrote: > static const DWORD MAXSUBKEYNAMELEN = 255; > WCHAR subKeyName[MAXSUBKEYNAMELEN + 1]; I'm not sure what version of C wine is strictly trying to conform to, but it's usually best to go with the lowest common denominator. This is not C89. The const keyword doesn't actually make the variable constant (I know it's not the greatest feature of C). The array size won't be evaluated until runtime, so technically this is a variable length array which weren't added until C99. You can make it C89 simply by using #define instead of declaring it as a variable.

2 1

Re: crypt32: remove hardcoded value AT_SIGNATURE from CertContext_SetKeyProvInfo
by Alexandre Julliard May 9, 2007

May 9, 2007

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > Hi, > This patch removed a hardcoded value (AT_SIGNATURE) from > CertContext_SetKeyProvInfo. It also corrects a corresponding test. Like I said, the test currently passes on Windows, so you can't simply change it. Tests are supposed to reflect the behavior of Windows, not of Wine. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 3/3] winex11: Use TINN algorithm to speed up colour lookups. (try 2)
by Dmitry Timoshkov May 9, 2007

May 9, 2007

"Vitaly Budovski" <vbudovski(a)gmail.com> wrote: >> Now that you got rid of sqrt calls usage of float numbers internally >> doesn't look justified (to me) anymore. >> > > Only because in this instance it is used with integer data. It doesn't > need to be limited to just integer values. Besides, what would be gained > by changing it to integers as you suggest? What would be gained is an additional speed. Since this code is supposed to be used to handle palette/color data there is no need to use floats at all. -- Dmitry.

5 8

Re: rsaenh: add support for mandatory parameters to RSAENH_CPGetProvParam
by Alexandre Julliard May 9, 2007

May 9, 2007

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > This patch adds support for mandatory parameters in > RSAENH_CPGetProvParam. It also adds tests for them. > The mandatory parameters are: PP_UNIQUE_CONTAINER, PP_PROVTYPE, > PP_KEYSPEC, PP_KEYSET_TYPE, PP_KEYSTORAGE. Thanks for resending, but unfortunately this breaks make test: ../../../tools/runtest -q -P wine -M crypt32.dll -T ../../.. -p crypt32_test.exe.so cert.c && touch cert.ok cert.c:1215: Test failed: Expected AT_SIGNATURE, got 3 make: *** [cert.ok] Error 1 I know you sent a patch for that test, but since it currently succeeds on Windows the change can't be right. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 05/27] [Kernel32]: ActCtx: now storing path info for app & config in manifest
by Alexandre Julliard May 9, 2007

May 9, 2007

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > HeapFree(GetProcessHeap(), 0, actctx->assemblies); > - actctx->magic = 0; > + HeapFree(GetProcessHeap(), 0, (void*)actctx->config.info); > + HeapFree(GetProcessHeap(), 0, (void*)actctx->app.info); Please don't cast off const, we are trying to get rid of these warnings. If the strings need to be freed then they cannot be const. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 03/27] [Kernel32]: ActCtx: added basic structures for storing assembly information
by Alexandre Julliard May 9, 2007

May 9, 2007

Eric Pouech <eric.pouech(a)wanadoo.fr> writes: > +static struct assembly* add_assembly(struct actctx* actctx, enum assembly_type at) > +{ > + struct assembly* assembly; > + > + if (!actctx->num_assemblies) > + actctx->assemblies = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(struct assembly)); > + else > + actctx->assemblies = HeapReAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, > + actctx->assemblies, > + (actctx->num_assemblies + 1) * sizeof(struct assembly)); Growable arrays should be grown by a multiple of the current size. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: hnetcfg: [1:10]Define icftype.idl
by Alexandre Julliard May 9, 2007

May 9, 2007

Jeff Latimer <lats(a)yless4u.com.au> writes: > +typedef enum NET_FW_PROFILE_TYPE_ > +{ > + NET_FW_PROFILE_DOMAIN = 1, > + NET_FW_PROFILE_STANDARD = 2, > + NET_FW_PROFILE_CURRENT = 3, > + NET_FW_PROFILE_TYPE_MAX = 4 > +} NET_FW_PROFILE_TYPE; > + > +typedef enum NET_FW_IP_VERSION_ > +{ > + NET_FW_IP_VERSION_V4 = 1, > + NET_FW_IP_VERSION_V6 = 2, > + NET_FW_IP_VERSION_ANY = 3, > + NET_FW_IP_VERSION_MAX = 4 > +} NET_FW_IP_VERSION; There's no reason to initialize the enum values explicitly, particularly since all your values are wrong... -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: rsaenh: fix bug in RSAENH_CPGetProvParam (corrected again)
by Alexandre Julliard May 9, 2007

May 9, 2007

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > From: Mounir IDRASSI <mounir.idrassi(a)idrix.fr> > Date: Wed, 9 May 2007 03:33:45 +0200 > Subject: rsaenh: fix bug in RSAENH_CPGetProvParam Could you please provide a more meaningful subject line to describe your patch? "fix bug" applies to just about every commit... -- Alexandre Julliard julliard(a)winehq.org

1 0