May 2007 - Wine-Devel - list.winehq.org

Re: dbghelp[2]: Speed up vector_add. Remove no longer needed pool_realloc.
by Detlef Riekenberg May 7, 2007

May 7, 2007

On Mo, 2007-05-07 at 05:46 +0200, Markus Amsler wrote: > + /* Don't even try to resize memory. Memory gain would be > minimal > + but speed hit significant with big vecotrs. * I have no Idea about the code, but found this Typo: vecotrs => vectors -- By by ... Detlef

1 0

Re: crypt32: fix a wrong test
by Laurent Vromman May 7, 2007

May 7, 2007

> - ok(info->dwKeySpec == AT_SIGNATURE, > + ok(info->dwKeySpec == (AT_SIGNATURE|AT_KEYEXCHANGE), > "Expected AT_SIGNATURE, got %d\n", info->dwKeySpec); It could be a good idea to correct the error text "Expected AT_SIGNATURE" to add AT_KEYEXCHANGE in it. Laurent Vromman On Mon, 07 May 2007 16:05:35 +0200, Mounir IDRASSI <mounir.idrassi(a)idrix.fr> wrote: > Hi, > This patch corrects a test in crypt32 that was incorrectly written to > accommodate the bug in rsaenh dll we corrected in our previous patch. > > Mounir IDRASSI > IDRIX - Cryptography and IT Security Experts > http://www.idrix.fr > > >

1 0

crypt32: fix a wrong test
by Mounir IDRASSI May 7, 2007

May 7, 2007

Hi, In the tests of the crypt32 dll, a test was written in a way that accommodates the bug we have corrected previously in the patch for rsaenh dll. The attached small patch corrects the value expected from this test to be consistent with the correct output. Cheers, Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr >From b2059ab820a37ef3129cd52c4a4048c9081d3bb9 Mon Sep 17 00:00:00 2001 From: Mounir IDRASSI <mounir.idrassi(a)idrix.fr> Date: Mon, 7 May 2007 15:33:36 +0200 Subject: crypt32: fix a wrong test --- dlls/crypt32/tests/cert.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/dlls/crypt32/tests/cert.c b/dlls/crypt32/tests/cert.c index 345c9f5..bec65de 100644 --- a/dlls/crypt32/tests/cert.c +++ b/dlls/crypt32/tests/cert.c @@ -1212,7 +1212,7 @@ static void testCreateSelfSignCert(void) "Unexpected key container\n"); ok(!lstrcmpW(info->pwszProvName, MS_DEF_PROV_W), "Unexpected provider\n"); - ok(info->dwKeySpec == AT_SIGNATURE, + ok(info->dwKeySpec == (AT_SIGNATURE|AT_KEYEXCHANGE), "Expected AT_SIGNATURE, got %d\n", info->dwKeySpec); } HeapFree(GetProcessHeap(), 0, info); -- 1.4.4.2

1 0

[try 2] Move console input/output codepages to server - what's wrong?
by Kirill K. Smirnov May 7, 2007

May 7, 2007

Hi, A week ago I've sent a patch which fixes console input/output codepages handling. http://www.winehq.org/pipermail/wine-patches/2007-April/038429.html It is still not applied, so please, explain, what is wrong with it? It even fixes 2 tests: $wine kernel32_test.exe.so process before: process: 510 tests executed (0 marked as todo, 6 failures), 0 skipped. after: process: 510 tests executed (0 marked as todo, 4 failures), 0 skipped. Thanks, -- Kirill

1 1

Can we catch access violation exceptions in tests?
by Mikołaj Zalewski May 7, 2007

May 7, 2007

I'm trying to write a tests for invalid cbSize in Shell_NotifyIcon. The behaviour under Windows XP is to assume in such a case that the size is NOTIFYICONDATA_V1_SIZE. AFAIK Shell_NotifyIcon doesn't provide a way to read icon data to check that the data introduced after Win95 is not modified. So I'm using VirtualAlloc+VirtualProtect to make Shell_NotifyIcon fail if it tries to access this data. I'd like to catch the exception to make a tests fail if something goes wrong instead of crashing the testsuite. However __try doesn't work under gcc and using wine/exception.h gives an unresolved symbol '__wine_handle_exception'. Is it possible to catch exceptions in tests? Mikolaj Zalewski

3 2

Re: Implements NET START to control system services
by Dmitry Timoshkov May 7, 2007

May 7, 2007

"Tim Schwartz" <tim(a)sanityinternet.com> wrote: > #include <stdio.h> > #include <string.h> > +#include <windows.h> > + > +int net_service(char *operation, char *service_name); It's better to properly arrange the code to avoid forward declarations. > +int net_service(char *operation, char *service_name) > +{ > + SC_HANDLE SCManager, serviceHandle; > + int result = 0; > + char service_display_name[4096]; service_display_name should be queried and dynamically allocated. > + > + SCManager = OpenSCManager(NULL, NULL, SC_MANAGER_ALL_ACCESS); > + if(!SCManager) > + { > + printf("Couldn't get handle to SCManager.\n"); > + return 0; > + } > + serviceHandle = OpenService(SCManager, service_name, > SC_MANAGER_ALL_ACCESS); > + if(!serviceHandle) > + { > + printf("Couldn't get handle to service.\n"); > + return 0; > + } You are leaking SCManager handle here. > + > + if(!GetServiceDisplayName(SCManager, service_name, > service_display_name, NULL)) Are you sure that last parameter can be NULL here? MSDN seems to disagree. Also did you test your code under Windows? This kind of application can be and should be IMO developed/tested in Windows. > + if(!strcasecmp(operation, "start")) > + { > + printf("The %s service is starting.\n", service_display_name); > + result = StartService(serviceHandle,0,NULL); > + CloseServiceHandle(serviceHandle); > + if(!result) printf("The %s service failed to start.\n", > service_display_name); > + else printf("The %s service was started successfully.\n", > service_display_name); > + return result; > + } > + > + return 0; > } You are leaking the SCManager handle here as well, and both serviceHandle and SCManager are leaked if operation is not "start". Also the patch was wrapped by your mailer. -- Dmitry.

1 0

Re: [New]: Added wrapper dll for ct-api (CardTerminal API)
by Steven Edwards May 7, 2007

May 7, 2007

I forgot to mention the inclusion of config.h and port.h should come before other headers in your source. Thanks Steven On 5/6/07, Christian Eggers <ceggers(a)gmx.de> wrote: > Hello, > > this wrapper dll permits access to chipcard readers which provides a ct-api (CardTerminal > API). > -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: [New]: Added wrapper dll for ct-api (CardTerminal API)
by Steven Edwards May 6, 2007

May 6, 2007

On 5/6/07, Christian Eggers <ceggers(a)gmx.de> wrote: > Hello, > > this wrapper dll permits access to chipcard readers which provides a ct-api (CardTerminal It looks really good. A couple of quick comments for future patches. Please use a standard LGPL license header in your patch for the header, don't use C++ comments and you don't have to add a Changelog entry. Alexandre's patch tools automatically adds it from your email/changeset. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: msi [3/4]: Set the text limit of the edit control if the limit isgiven
by Dmitry Timoshkov May 6, 2007

May 6, 2007

"James Hawkins" <truiken(a)gmail.com> wrote: > + text = MSI_RecordGetString( rec, 10 ); > + if ( text ) > + { > + begin = strchrW( text, '{' ); > + end = strchrW( text, '}' ); Perhaps it would be cleaner to use end = strchrW( begin, '}' ); -- Dmitry.

1 0

Re: Fix keyboard focus issues
by Dmitry Timoshkov May 6, 2007

May 6, 2007

"Bernhard Rosenkraenzer" <bero(a)arklinux.org> wrote: > The attached patch fixes bug #1798 (also known as 6986, 4042, 2819, 2149, and > 2926) -- some fullscreen applications not getting focus correctly. As I already pointed out in the bug using window/screen width in comparisons should allow to avoid that -1/+1 shift in left/top coordinate. -- Dmitry.

1 0