May 2007 - Wine-Devel - list.winehq.org

Re: some doubts about sendind patches - is text/plain way good?
by Kirill K. Smirnov May 26, 2007

May 26, 2007

>You might want to try the following: Select the patch from >http://thread.gmane.org/gmane.comp.emulators.wine.patches/ , >select the link after "Direct link" on the bottom, append "/raw" >without quotation marks after the URL. Now you can save the file >at that URL as is and use it with patch, it will ignore the headers. It works! Cool! (but a little complicated ;-) Thanks a lot for hint! -- Kirill

1 0

Re: [PATCH 3/6] CMD.EXE: Handle command line as Unicode
by Dmitry Timoshkov May 26, 2007

May 26, 2007

"Jason Edmeades" <us(a)edmeades.me.uk> wrote: > int main (int argc, char *argv[]) > { > + LPWSTR *argvW = NULL; > + int args; > + WCHAR *cmdW = NULL; If you will start using wmain() instead of main() you get unicode args for free, and that will help to avoid changing the command line parsing code. -- Dmitry.

2 3

Re: some doubts about sendind patches - is text/plain way good?
by Kirill K. Smirnov May 26, 2007

May 26, 2007

В сообщении от 26 мая 2007 21:24 вы написали: > I'll double check later, but are you sure? > > When I said I hadn't changed the patches, I meant the contents, but I had > done a git fetch, git rebase origin on the branch (and resolved the german > resource conflict) before resubmitting I got the following messages: patching file programs/cmd/Cs.rc patching file programs/cmd/De.rc Hunk #1 FAILED at 263. 1 out of 1 hunk FAILED -- saving rejects to file programs/cmd/De.rc.rej patching file programs/cmd/En.rc patching file programs/cmd/Es.rc patching file programs/cmd/Fr.rc patching file programs/cmd/Ja.rc patching file programs/cmd/Ko.rc Hunk #1 FAILED at 235. 1 out of 1 hunk FAILED -- saving rejects to file programs/cmd/Ko.rc.rej patching file programs/cmd/Nl.rc patching file programs/cmd/No.rc patching file programs/cmd/Pl.rc patching file programs/cmd/Pt.rc patching file programs/cmd/Ru.rc patching file programs/cmd/Si.rc ... I noticed that German translations patch failed, checked git log, saw that translation has been updated and panic. ;-) I rechecked patch - it is ok, not outdated, but I still cannot apply it. Why? I have only one consideration. As I noticed, patches are sent with different MIME types. In wine-patches mailing list different types are handled differently - if text/plain then attach is embedded into body, if not text/plain (usually text/x-patch) then attach is available via special URL link. I do not receive mail from wine-patches mail list. Thus, to get the patch sent with MIME text/plain I use select/copy/paste/save technique. If patch is not text/plain, I just use "save link target" option in browser. That patch was sent with MIME type text/plain, so I had to copy/paste it. When I tried to save it via kwrite it complained about problems with UTF8 characters, but I did not pay attention and went on. While patching I got messages I wrote before. I've tried VIM as an editor to save too. It does not complain but file I get is still unusable. This make me think, that idea to sent patches with text/plain MIME type (as recommended at http://winehq.org/site/docs/winedev-guide/style-notes) is not a really good way. Also there may be an encoding problem - while sending patches kmail (MUA I use) asks me what enconding to use (7bit, 8bit, base-64). I always set 8-bit. Now I am in doubts if I follow a right way. Any comments? -- Kirill P.S. sorry for rising up nonsence with Jason's patch. It is looks correct, I cannot say more. ;-)

2 1

CMD.EXE patchset 1->6
by Ann & Jason Edmeades May 26, 2007

May 26, 2007

Apologies if this set arrives multiple times - I sent it all on Friday, and the mailing list only shows 1,2 and 4. I sent then again tonight separately, and immediately 3 went missing... FYI I had this problem before the last hardware upgrade on winehq, and it appeared fixed since then. I'll start copying a gmail account in future to confirm what I am seeing, but last time some emails got delayed about a month in transit and eventually appeared, but ONLY when winehq was involved, gmail, hotmail, my own email addr etc all got immediate copies... Regards, Jason

4 6

Re: [PATCH 4/6] CMD.EXE: Convert cmd into unicode
by Detlef Riekenberg May 26, 2007

May 26, 2007

On Di, 2007-05-08 at 00:11 +0100, Jason Edmeades wrote: > Apologies for the size of this patch - I tried 3 or 4 ways of converting > chunks to unicode and always ended up duplicating huge bits of code and > having problems keeping track of duplicated variables that in the end I > did the lot in one go. You need TCHAR and friends to reduce the Patch-Size (char => TCHAR when you did char => WCHAR) And do not forget "* sizeof(TCHAR)" when calculating the required size for allocations (HeapAlloc) -- By by ... Detlef

2 1

Re: [AppDB] Add apidb_footer to browse downloadable page
by Alexander Nicolaysen Sørnes May 26, 2007

May 26, 2007

Lørdag 26 mai 2007 19:02, skrev Chris Morgan: > On 5/26/07, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > > Lørdag 26 mai 2007 18:53, skrev Chris Morgan: > > > We should move that page to a class and integrate it in with the > > > objectManager stuff. Its a pretty simple page. > > > > > > Chris > > > > I agree > > I meant instead of applying this patch we should move it to use the > objectManager stuff ;-) > > Chris Oh, so it was a trick question, then? :D I'll just move it over and adapt it to the objectManager's page browsing framework later. Alexander

1 0

Re: 64-bit compilation broken today
by Clinton Stimpson May 26, 2007

May 26, 2007

>> The confusing thing to me is that I *do* have the libxml2-dev package >> installed, and see no errors about a missing header... >> >> If it didn't recognize the xmlNodePtr type, shouldn't it have choked on >> line 52 first? >> >> -J >> >> >> Bryan DeGrendel wrote: >> >>> A couple of libxml2 externs were recently added to >>> dlls/msxml3/msxml_private.h Both functions have a xmlNodePtr as a >>> parameter, which is defined in the libxml2 header. However, both >>> externs were added outside msxml_private.h's libxml2 preprocessor >>> check, so I believe it causes a compilation error if you don't have >>> the libxml header. I have sent a patch which should fix it. >>> >>> Bryan DeGrendel >>> >>> On 5/25/07, *Evil Jay* <wine(a)eternaldusk.com >>> <mailto:wine(a)eternaldusk.com>> wrote: >>> >>> This might already be known, but sometime in the last eight hours >>> or so, >>> git seems to have broken: >>> >>> gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ >>> -DCOM_NO_WINDOWS_H -D_REENTRANT -fPIC -Wall -pipe >>> -fno-strict-aliasing >>> -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g >>> -O2 -o >>> attribute.o attribute.c >>> In file included from attribute.c:32: >>> msxml_private.h:67: error: expected declaration specifiers or '...' >>> before 'xmlNodePtr' >>> msxml_private.h:68: error: expected declaration specifiers or '...' >>> before 'xmlNodePtr' >>> make[2]: *** [attribute.o] Error 1 >>> make[2]: Leaving directory `/data/install/wine/dlls/msxml3' >>> make[1]: *** [msxml3] Error 2 >>> make[1]: Leaving directory `/data/install/wine/dlls' >>> make: *** [dlls] Error 2 > I also have the libxml2-dev package installed, however HAVE_LIBXML2 was not > defined. Therefore lines 28-60 were not compiled. I suspect this is the > same quirk in your case. > > Bryan DeGrendel > I had the same compile error until I installed the libxml2-devel.i386 package. I had libxml2-devel.x86_64 already installed. Clint

2 1

[PATCH 1/6] CMD.EXE: Move english constants into NLS files
by Kirill K. Smirnov May 26, 2007

May 26, 2007

Hi Jason, Since German and Korean resource have been updated, this patch is a little outdated and cannot be applied. Please, rediff. Other patches may be outdated too. -- Kirill

2 1

No release today?
by Scott Ritchie May 26, 2007

May 26, 2007

I heard a rumor in IRC that there wasn't going to be a release today. Seems to be true. Alexandre, in the future could you please send out an email to wine-devel when you know there won't be a release? I scheduled my day partially around building the upcoming 0.9.38 packages, but that didn't happen. Thanks, Scott Ritchie

3 4

Re: hnetcfg: [resend 3] 1/5 add spec file for hnetcfg
by Detlef Riekenberg May 26, 2007

May 26, 2007

On Sa, 2007-05-26 at 19:37 +1000, Jeff Latimer wrote: > --- > dlls/hnetcfg/hnetcfg.spec | 44 > ++++++++++++++++++++++++++++++++++++++++++++ I suggest, that you read and follow this Hints: http://wiki.winehq.org/Developers-Hints#head-30a7f7f51ce0e42b4141749c9832ba… Thanks -- By by ... Detlef

1 0