June 2007 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

Re: hhctrl.ocx: Parse HTML entities in the table of contents.
by Alexandre Julliard April 15, 2008

April 15, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > + p++; > + if ((*p == 'X') || (*p == 'x')) > + { > + /* hexadecimal entity */ > + while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') || > + (*p >= 'A' && *p <= 'F')) > + p++; > + ch = strtolW(start + 2, NULL, 16); > + } This is still broken. > + if (p - start - 1 <= sizeof(char_refs[0].name)) > + { > + for (i = 0; i < sizeof(char_refs)/sizeof(char_refs[0]); i++) > + if (!strncmpW(char_refs[i].name, start + 1, p - start - 1)) > + break; > + } This is still broken too. -- Alexandre Julliard julliard(a)winehq.org

2 1

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

Direct3D Game test framework
by Stefan Dösinger Dec. 21, 2007

Dec. 21, 2007

Hi, Now that we're facing Direct3D 9 feature completion soon - VTF support coming in from Henri, High order patches and thread safety from me - the d3d work will change a bit soon. Instead of adding new features we'll debug games and improve performance. It would be good if we had some automated testing framework to support the process :-) Unfortunately this isn't easy. Games do not render exactly, so verifying that a game doesn't show any visual regressions automatically may be more effort than reward. Here I think we'll have to rely on users testing the games regularly and testing regressions. I am more concerned about the performance thing. It is very easy to make some performance improvement that does more harm than good. Also benchmarks take quite some time and are affected by many external parameters. So I'd like some automated and controlled performance testing environment. Instead of building one from scratch it would be cool if we could reuse existing software. cxtest comes to my mind(www.cxtest.org). It is a test suit built by codeweavers for running regression tests on Windows apps. It can remote control applications using keyboard input and compares screenshots to reference ones. It could be used to start benchmarks automatically. A plus here is that some machines run nightly tests. However, those are VMs, so no 3D acceleration. A problem is also reading back the results. Does anyone know some applications for doing that? Windows or Linux apps, commercial or open source ones(prefered, though). Then we need benchmarking apps. Here regular Windows benchmarks come to my mind(3DMarkXYZW), games with benchmark facilities(hl2, ut, ...). We can record tests, get a reference performance counter from windows and run nightly tests(or manually started tests). A problem we're facing is reading back the results. Taking screenshots and running OCR on them is error prone, we need a way to get the numbers from the benchmarks, not an image of the numbers. Now we need a concrete collection of benchmarks. A mixture of popular Benchmarks like 3DMark would be good, and some more cientific benchmarks. So far I have: 3DMark: Popular benchmark for testing the overall performance, doesn't give very detailed results though. Controlling: Standard windows controls, keyboard events should do the job Result readback: Can write results to a file, but must take care about the licensing. Not everything is free, most likely a license is needed. Half-Life 2: Nice facility of recordable timedemos. Can record average game demos, but also demos which stress specific features. Controlling: Command line parameters Result readback: Can be asked to copy the console into the clipboard UT2004: Popular engine. Has a Linux port, but many mods only ship the d3d renderer. Controlling: Unknown Result readback: unknown. DirectX sdk demos, nvidia / ati demos: Stress specific rendering features. Good for testing performance(with vsync removed), or a bad idea? Controlling, Readback: Source code is available and can be modified. License, especially possible benchmark clauses? Other suggestions? Another nice-to-have thing would be a game independent profiling method, simmilar to the +fps debug channel, just more detailed. Some games do not have built-in benchmarking, it would still be nice to use them. That means facing some new problems? How to tell loading from in-game rendering? How to remove control those games in a repeatable way, especially if there are some random elements in the game? More detailed data from wined3d could also be used to draw nice graphs for other benchmarks :-) We'll need some hardware diversity too. It would be nice if the tests worked on Linux and MacOS, and a variety of hardware was used. I want at least nvidia, ati and intel gpu's, older and newer ones. I could also revive my ATI mach64 :-) Any other comments or suggestions? I think once I'm done with the current exam season and my patch backlog is in I will retire from direct wined3d development for a few days / weeks to set up a testing environment, then start fixing games.

10 40

Work legalities
by Nathan Williams Dec. 11, 2007

Dec. 11, 2007

Hey everyone, I have been planning to do some work on wine for a while now, but after I started working I got myself a new programming job. I'm worried about the copyright of any external work I do, so I need a little advice. What do I need from my employer to clear me to work on wine? Is something verbal ok, or should I get it in writing? -- Nathan

10 12

re: Direct3D Game test framework
by Dan Kegel July 24, 2007

July 24, 2007

Vit Hrachovy wrote: > Stefan Dösinger wrote: > > [Any suggestions for a good app test framework?] > > I'm personally using AutoHotkey(http://www.autohotkey.com) as an > automatic testing framework backend. It's a Windows application, so it > can be run through Wine itself and it's sandboxed from X11. I second Vit's recommendation. We're using Autohotkey scripts in our test framework http://code.google.com/p/yawt/ and I've been meaning to work with Vit to get his scripts incorporated into our framework. (We've been distracted getting the next release of Picasa out, sorry.) - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

9 13

PulseAudio driver
by Stéphan Kochen July 18, 2007

July 18, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello everyone, I've been working on a PulseAudio driver for Wine for a couple of days now. It was suggested I should drop a note on to wine-devel, so here I am. :) I also cc'd pulseaudio-discuss. (And subscribed to both.) I personally use PulseAudio for everything on my desktop already, but support in Wine was lacking. PulseAudio provides lots of compatibility with other APIs, like OSS, ALSA and ESD. I only managed to get OSS emulation working to a reasonable extent with Wine. I decided it would be a fun project to write a native PulseAudio driver instead. Right now I'm trying to get very basic output working, without real support for DirectSound. Using the winmm_test.exe.so testcase from Wine I already managed to produce beeps using my driver, which is pretty cool for just a couple of days work. :) If anyone feels like a chat, I read both these lists now and will try to respond. I can also be found on Freenode in #winehackers and #pulseaudio as 'stephank'. - -- Stéphan -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFGEOThcFUq0gzqDwQRAr5mAKCn2PenC5f8iUKEywPe2c8J6s3bogCdH6qv 3JCaQX5OIBwMV9znBXYKJh4= =gQT3 -----END PGP SIGNATURE-----

2 1

About stdlib.h system()
by Zhongli Xu July 5, 2007

July 5, 2007

Hi all, I tried to call another .exe file in my own exe file by using the system() API. But the return value of system() is -1 and errno is set to ENOENT. It indicates that the another exe file is not found. So I copy the another exe to the fake directory: C:\windoes\system32, since wine always find the exe file there. And I also set the environment variable "System" and "Path" in the key HOST_CURRENT_USER/Environment thru regedit. But still, wine couldn't find the another exe. Any help is welcomed. Milo Xu

4 4

How to make your machine crash when running Wine
by gslink July 4, 2007

July 4, 2007

If you are using the Nvidia drivers posted on the Nvidia web site then you MUST reinstall these drivers whenever you update ANY of the X-server software. If you replace the kernel you will be forced to reinstall the drivers but just replacing the X-server or the open GL code does not do this. Not reinstalling drivers when video code is replaced usually causes problems. It seems like every time RH updates any video code but does not upgrade the kernel at the same time there are complaints that Wine causes machines to crash. This is the reason.

4 3

illegal characters in file names
by Lei Zhang July 3, 2007

July 3, 2007

Hi, I noticed a mismatch between the list of illegal characters in file names between Wine and Windows. On Wine the list of characters is: /:<>| and on Windows, it is: \/:*?"<>| Is this intentional or something we should fix? - Lei

6 7

request to change appdb message
by Louis. Lenders July 3, 2007

July 3, 2007

Hi, since a few weeks the following message is displayed when you try to submit test results into appdb: Please DO NOT include crash or Wine debug output. Instead report the crash as a bug in the Wine bugzilla at http://bugs.winehq.org. We ask that you use bugzilla because developers do not monitor the AppDB for bugs. I'm not that happy with this message for a few reasons: 1. Most testers will not attach this to a bug, either because there isn't an entry for the app in bugzilla, or they don't bother to do so. 2. There are crashes like these that users attach: wine app.exe err:module:import_dll Library MSVBVM60.DLL (which is needed by L"C:\\app.exe") not found err:module:LdrInitializeThunk Main exe initialization for L"C:\\app.exe" failed, status c0000135 We don't want users to attach these things in bugzilla, we'd rather point them what to do in the email-field. If users don't attach crashes anymore to the testresults , i cannot by no means see anymore if a testresult is valid or not. I'd rather see something like: Please DO include crash or Wine debug output here, and report the crash as a bug in the Wine bugzilla at http://bugs.winehq.org. Any comments? --------------------------------- Yahoo! Answers - Get better answers from someone who knows. Tryit now.

6 12

Crosscompile failures for gdiplus
by Paul Vriens July 2, 2007

July 2, 2007

Hi, Ever since gdiplus tests (roughly 2 weeks ago) got added to Wine we have crosscompile failures: i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -Wcast-qual -o brush.cross.o brush.c brush.c:1: warning: -fPIC ignored for target (all code is position independent) i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -Wcast-qual -o pen.cross.o pen.c pen.c:1: warning: -fPIC ignored for target (all code is position independent) ../../../tools/make_ctests -o testlist.c brush.c pen.c i386-mingw32-gcc -c -I. -I. -I../../../include -I../../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -Wcast-qual -o testlist.cross.o testlist.c testlist.c:1: warning: -fPIC ignored for target (all code is position independent) i386-mingw32-gcc brush.cross.o pen.cross.o testlist.cross.o -o gdiplus_crosstest.exe -lgdiplus -lkernel32 /usr/local/lib/gcc/i386-mingw32/3.4.5/../../../../i386-mingw32/bin/ld: cannot find -lgdiplus collect2: ld returned 1 exit status make: *** [gdiplus_crosstest.exe] Error 1 Does anybody feel up to fixing MingW so we will have a new winetest executable soon? No new one since June 12 on http://www.astro.gla.ac.uk/users/paulm/WRT/CrossBuilt/ . Cheers, Paul.

3 2

Re: mshtml: Implement HTMLDocument_QueryInterface for IHTMLDOMNode, IHTMLElement and IHTMLElement2.
by Jacek Caban July 1, 2007

July 1, 2007

Hi, I've just sent a test showing that native doesn't implement these interfaces so we shouldn't either. It's strange because IDL declaration says something else. And BTW. your patch violates COM QueryInterface rules (not that MS always respects these rules...). Thanks, Jacek

2 4

The: "Wine Status - ChangeLog"
by Tomas.Zijdemans＠student.uib.no June 30, 2007

June 30, 2007

This page has been dead since October 1. Since I'm not producing code for the Wine project, this is an area I'd like to contribute to. (I'm already taking screenshots of the API status page to see what happens from release to release :)) Is there some WineHQ folks here that would be willing to give me accsess? Regards.

3 2

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]
by Koshelev, Misha Vladislavo June 30, 2007

June 30, 2007

On 6/27/07, Evan Stade <estade at gmail.com> wrote: > Hi, > > [try2] The patch I sent yesterday was not properly todo_wined. Also, > this test is a bit more extensive (about twice as many points drawn). > It uses various point-type combination (even non-sensical ones such as > PT_LINETO | PT_MOVETO) to test the exact logic of PolyDraw with an > open path. > > changelog: > * added polydraw test to path testing (5 more todo_wines) > > dlls/gdi32/tests/path.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 70 insertions(+), 0 deletions(-) > > -- > Evan Stade > > Also, I'd add a PT_MOVETO into your first PolyDraw call so you can tell whether PT_CLOSEFIGURE adds a PT_MOVETO to orig_pos or lastmove, as the current version does not differentiate this. Misha

3 2

Announcing WineConf 2007
by Mike Hearn June 29, 2007

June 29, 2007

Yes, it's true! The moment you've all been waiting for! On 6th/7th October, once more Wine hackers from around the world will meet to eat, drink, make merry, and discuss the finer details of reimplementing the Windows API. This year it's Googles turn to host it, and it'll be at the engineering office in Zurich. You too can chill out with these awesome froods by signing up for the wineconf mailing list, and surfing over to: http://wiki.winehq.org/WineConf2007 ... which is currently a bit sparse but will populate nearer the time. Fascinating talks! Interesting people! Hackfests galore ... and maybe even fondue! 6th/7th October. Be there or be square.

2 1

Re: Add combobox in winecfg:theme.c
by Vitaly Lipatov June 29, 2007

June 29, 2007

В сообщении от 16 июня 2007 Yaroslav Skorokhodov написал(a): > Changelog > Add combobox for select base font size There was improvement allows select size of the base font (dpi actually) in LogPixel registry entry. It is useful thing (default font size is too small on 17" monitors). What's wrong with the patch? http://www.winehq.org/pipermail/wine-patches/2007-June/040496.html -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

1 0

Something wrong with my two patches?
by Markus Gömmel June 29, 2007

June 29, 2007

On 21 and 22 June I submitted two small patches (for comctl32/datetime.c and user32/msgbox.c). Both should be ok, but definitly the first one (datetime.c)... Something wrong with them or only some normal delay in putting them into git? My last small patch went into git within 2 days... Only a question Thanks and regards Markus Gömmel m.goemmel(a)compulab.de

2 1

make test in winsock segfaulting after patch 4c5b55a0f8...
by Kai Blin June 29, 2007

June 29, 2007

The following commit breaks the winsock test for me. commit 4c5b55a0f82e83793814a21eadec8b50d48751f3 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Mon Jun 4 18:16:48 2007 +0200 server: Run async I/O APCs from the SIGUSR1 handler. I have attached the backtrace. This is currently stopping me from confirming if my WSAStringToAddress patch is correct. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 1

WinXP winsock test broken by commit e39dca6af6c87a30ab1d907c0468de2602a6e442
by Kai Blin June 29, 2007

June 29, 2007

The tests added in patch commit e39dca6af6c87a30ab1d907c0468de2602a6e442 Author: Damjan Jovanovic <damjan.jov(a)gmail.com> Date: Thu Mar 22 08:03:28 2007 +0200 ws2_32: WSASendTo should always re-enable the FD_WRITE event. break the ws2_32 sock.c tests on WinXP SP2. sock.c:1832: Test failed: WaitForSingleObject failed, error 258 I'm afraid I don't really know what's going wrong there. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

3 2

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]
by Misha Koshelev June 29, 2007

June 29, 2007

On 6/27/07, Evan Stade <estade at gmail.com> wrote: > Hi, > > [try2] The patch I sent yesterday was not properly todo_wined. Also, > this test is a bit more extensive (about twice as many points drawn). > It uses various point-type combination (even non-sensical ones such as > PT_LINETO | PT_MOVETO) to test the exact logic of PolyDraw with an > open path. > > changelog: > * added polydraw test to path testing (5 more todo_wines) > > dlls/gdi32/tests/path.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 70 insertions(+), 0 deletions(-) > > -- > Evan Stade > > Also, the attached (much shorter) diff makes all your tests conform on wine for me. I am a little confused as to where the non-open-path part of your PolyDraw patch came from (maybe I am missing something). Misha

1 0

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]
by Misha Koshelev June 29, 2007

June 29, 2007

On 6/27/07, Evan Stade <estade at gmail.com> wrote: > Hi, > > [try2] The patch I sent yesterday was not properly todo_wined. Also, > this test is a bit more extensive (about twice as many points drawn). > It uses various point-type combination (even non-sensical ones such as > PT_LINETO | PT_MOVETO) to test the exact logic of PolyDraw with an > open path. > > changelog: > * added polydraw test to path testing (5 more todo_wines) > > dlls/gdi32/tests/path.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 70 insertions(+), 0 deletions(-) > > -- > Evan Stade > > Well I am obviously not Alexandre but I'll hazard a guess. I don't think my advice/style comments which I sent yesterday kept the patch out, but the second patch definitely looks like it might have kept the patchset out. Specifically, a gem from gdi_private.h: /* It should not be necessary to access the contents of the GdiPath * structure directly; if you find that the exported functions don't * allow you to do what you want, then please place a new exported * function that does this job in path.c. */ Now I would almost be willing to bet money on the fact that Alexandre would want you to split your second patch up into a PATH_PolyDraw and your non-path case, then the PolyDraw in painting.c would go something like: if(PATH_IsPathOpen(dc->path)) ret = PATH_PolyDraw(dc, ...); else if(dc->funcs->pPolyDraw) ret = dc->funcs->pPolyDraw(dc->physDev, ...); else { /* Stuff to do in case of no open path */ } GDI_ReleaseObj(hdc); return ret; --- Misha p.s. Also your BYTE polydraw_tps should be static (minor point). p.p.s. Just to satisfy my anal retentiveness, and to make the test patch look nicer, if you end up resubmitting anyway you might as well put this in (note I changed some of your 1's to 2's because technically a 2 means an entry is completely skipped in wine, and a 1 means it is present in wine but does not quite match, although in this case either one will get you a successful todo_wine so it doesn't really matter): static const path_test_t polydraw_path[] = { {300, 300, PT_MOVETO, 0, 0}, /* 0 */ {150, 200, PT_LINETO, 0, 0}, /* 1 */ {200, 150, PT_LINETO | PT_CLOSEFIGURE, 0, 0}, /* 2 */ {300, 300, PT_MOVETO, 0, 1}, /* 3 */ {300, 300, PT_LINETO, 0, 0}, /* 4 */ {400, 300, PT_LINETO, 0, 0}, /* 5 */ {400, 350, PT_LINETO, 0, 0}, /* 6 */ {50, 100, PT_MOVETO, 0, 0}, /* 7 */ {100, 50, PT_LINETO, 0, 0}, /* 8 */ {400, 250, PT_LINETO, 0, 0}, /* 9 */ {500, 300, PT_LINETO, 0, 0}, /* 10 */ {500, 350, PT_LINETO, 0, 0}, /* 11 */ {350, 400, PT_MOVETO, 0, 2}, /* 12 */ {600, 200, PT_LINETO, 0, 2}, /* 13 */ {500, 150, PT_LINETO, 0, 0}, /* 14 */ {500, 350, PT_MOVETO, 0, 2}, /* 15 */ {500, 150, PT_LINETO, 0, 2}, /* 16 */ {100, 200, PT_LINETO, 0, 0}, /* 17 */ {400, 150, PT_LINETO, 0, 0}, /* 18 */ {400, 350, PT_LINETO, 0, 0}}; /* 19 */

1 0

Re: msi [1/10]: Implement MsiSourceListGetInfoA
by James Hawkins June 29, 2007

June 29, 2007

On 6/28/07, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > Correctly handled pcchValue. > > Changelog: > * Implement MsiSourceListGetInfoA. > Please disregard this series. -- James Hawkins

1 0

shelllink patches
by Misha Koshelev June 29, 2007

June 29, 2007

Btw, in case it was not clear from the patches themselves, without these patches out shelllinks for non-executables currently point to the application that is assigned to open them (e.g., notepad), rather than to the actual file as on native. Misha

1 0

Re: msi 1: Implement MsiSourceListGetInfoA [try2]
by Alexandre Julliard June 28, 2007

June 28, 2007

"James Hawkins" <truiken(a)gmail.com> writes: > + ret = MsiSourceListGetInfoW(product, usersid, dwContext, dwOptions, > + property, value, pcchValue); > + if (ret == ERROR_SUCCESS) > + WideCharToMultiByte(CP_ACP, 0, value, -1, szValue, *pcchValue, NULL, NULL); The handling of pcchValue is wrong, you need a separate variable for the W size, and you need to set *pcchValue to the correct A size. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]
by Evan Stade June 28, 2007

June 28, 2007

On 6/27/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > [try2] The patch I sent yesterday was not properly todo_wined. Also, > this test is a bit more extensive (about twice as many points drawn). > It uses various point-type combination (even non-sensical ones such as > PT_LINETO | PT_MOVETO) to test the exact logic of PolyDraw with an > open path. > > changelog: > * added polydraw test to path testing (5 more todo_wines) > > dlls/gdi32/tests/path.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 70 insertions(+), 0 deletions(-) > > -- > Evan Stade > > sorry for the post on wine-patches. How can I improve this test? -- Evan Stade

1 0

Re: wincrypt: add missing defines
by Mounir IDRASSI June 28, 2007

June 28, 2007

You forgot the attachement... Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Juan Lang wrote: > --Juan > > > > ____________________________________________________________________________________ > Choose the right car based on your needs. Check out Yahoo! Autos new Car Finder tool. > http://autos.yahoo.com/carfinder/ > > > > >

2 1

Wine networking broke on Debian Sid
by Ben Hodgetts (Enverex) June 28, 2007

June 28, 2007

Just to make this clear before starting this is a Sid issue (as far as I can tell) not a Wine issue. Anyway, to the point. Networking is broken on Debian Sid and has been for at least a week. I can't find out what has changed in Sid for it to stop working but basically anyone running Wine on Sid wont be able to use any form of network access. Firefox wont work, games wont be able to access servers or anything else, Gecko wont work, etc. This is using GIT, not the distros own packages. I tried using the x86_64 package for Ubuntu 7.04 (because no x86_64 package exists for Debian) and Wine acted exactly the same way with a clean .wine so it's not related to any build time issues. I reset to 0.9.34 in GIT and built that to make sure it wasn't anything that has changed in Wine itself and the issue continued, so it's not something that's changed in Wine. Although using an earlier version of Wine gives a "Winehq.com could not be found, please check the address and try again". Current Wine (or rather Gecko) doesn't bother giving you an error message. Could this be the work of the removal of an unspoken Wine dependency or something more sinister? All native apps still work perfectly which is what makes this such a hard thing to track down. I just thought I'd throw this out there in-case any of you are using Sid and wondering what the the hell happened to Wine. Log attached for completeness. Ben H.

1 0

Re: cabinent: add a comment about parm passing
by James Hawkins June 28, 2007

June 28, 2007

On 6/27/07, Jeff Latimer <lats(a)yless4u.com.au> wrote: > Coverity CID 43 Forward_Null is false. This adds a comment explaining > the NULL pass is ok. > Why do we need a comment for that? -- James Hawkins

3 2

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]
by Misha Koshelev June 28, 2007

June 28, 2007

> +static const path_test_t polydraw_path[] = { > + {300, 300, 6, 0, 0}, /*0*/ > + {150, 200, 2, 0, 0}, /*1*/ > + {200, 150, 3, 0, 0}, /*2*/ > + {300, 300, 6, 0, 1}, /*3*/ > + {300, 300, 2, 0, 0}, /*4*/ > + {400, 300, 2, 0, 0}, /*5*/ > + {400, 350, 2, 0, 0}, /*6*/ > + {50, 100, 6, 0, 0}, /*7*/ > + {100, 50, 2, 0, 0}, /*8*/ > + {400, 250, 2, 0, 0}, /*9*/ > + {500, 300, 2, 0, 0}, /*10*/ > + {500, 350, 2, 0, 0}, /*11*/ > + {350, 400, 6, 0, 1}, /*12*/ > + {600, 200, 2, 0, 1}, /*13*/ > + {500, 150, 2, 0, 1}, /*14*/ > + {500, 350, 6, 0, 0}, /*15*/ > + {500, 150, 2, 0, 0}, /*16*/ > + {100, 200, 2, 0, 0}, /*17*/ > + {400, 150, 2, 0, 0}, /*18*/ > + {400, 350, 2, 0, 0} /*19*/ > + }; This is not major, but just thought I'd point out that if you do a set WINETEST_DEBUG=3 on Windows and then call ok_path in your test (you can just do a 0 size when you first make the test for this), you'll get the following output, which seems like it would be both faster to produce and nicer-looking (get the actual PT_'s rather than a number): static const path_test_t polydraw_path[] = { {300, 300, PT_MOVETO, 0, 0}, /* 0 */ {150, 200, PT_LINETO, 0, 0}, /* 1 */ {200, 150, PT_LINETO | PT_CLOSEFIGURE, 0, 0}, /* 2 */ {300, 300, PT_MOVETO, 0, 0}, /* 3 */ {300, 300, PT_LINETO, 0, 0}, /* 4 */ {400, 300, PT_LINETO, 0, 0}, /* 5 */ {400, 350, PT_LINETO, 0, 0}, /* 6 */ {50, 100, PT_MOVETO, 0, 0}, /* 7 */ {100, 50, PT_LINETO, 0, 0}, /* 8 */ {400, 250, PT_LINETO, 0, 0}, /* 9 */ {500, 300, PT_LINETO, 0, 0}, /* 10 */ {500, 350, PT_LINETO, 0, 0}, /* 11 */ {350, 400, PT_MOVETO, 0, 0}, /* 12 */ {600, 200, PT_LINETO, 0, 0}, /* 13 */ {500, 150, PT_LINETO, 0, 0}, /* 14 */ {500, 350, PT_MOVETO, 0, 0}, /* 15 */ {500, 150, PT_LINETO, 0, 0}, /* 16 */ {100, 200, PT_LINETO, 0, 0}, /* 17 */ {400, 150, PT_LINETO, 0, 0}, /* 18 */ {400, 350, PT_LINETO, 0, 0}}; /* 19 */ Hope this helps. Misha

1 0

mozilla control download problems?
by Dan Kegel June 27, 2007

June 27, 2007

Say, I just saw a repeatable mozilla download failure. Here's a summary of the tcpdump log. Is this a known problem? - Dan

2 1

Re: Problem with patch "dsound: Simplify mixing by removing remixing support, and fix its waveout breakage"
by Maarten Lankhorst June 27, 2007

June 27, 2007

Chris Rankin schreef: > Hi, > > This patch has killed the sound on World of Warcraft. Instead, I now get silence and a stream of > errors like this: > Don't #if 0 out the code there Change it to something like this: if (pmix > This->buflen) WARN("Mixing further ahead then buffer is long\n");

2 1

Re: Worms world party install - 0x80040706 object reference not set
by James Hawkins June 27, 2007

June 27, 2007

On 6/27/07, Peter <swjawa(a)gmail.com> wrote: > 2007/6/27, James Hawkins <truiken(a)gmail.com>: > > On 6/27/07, Peter <swjawa(a)gmail.com> wrote: > > > When I try to install worms world party I get a message when 6%: > > > Unhandled Exception [_] [X] > > > Error Number: 0x80040706 > > > Description: Object reference not set > > > > > > Setup will now terminate > > > [OK] > > > > > > http://consumer.installshield.com/kb.asp?id=q110641 > > > This site says to update InstallShield engine, but that's the solution > > > for windows. > > > > > > > Why would it not be the solution for Wine? > > > > -- > > James Hawkins > > > Yes it works now. > Thanks. > Please reply-all so everyone can know the results. -- James Hawkins

1 0

RE: [advapi32/service #2] Don't rely blindly on type
by Rolf Kalbermatter June 27, 2007

June 27, 2007

Hi Paul, >On Wine, type is unchanged in a failure case for RegQueryValueExW. This means the >previous code relied on the returned type of the previous last succeeded call, huh? You are right that there is a problem with the existing code at some places. But changing - if( ( r == ERROR_SUCCESS ) || ( type == REG_DWORD ) ) + if( ( r == ERROR_SUCCESS ) && ( type == REG_DWORD ) ) should be enough. Since the funtion returned with success the type must be valid now. Rolf Kalbermatter

1 0

Worms world party install - 0x80040706 object reference not set
by Peter June 27, 2007

June 27, 2007

When I try to install worms world party I get a message when 6%: Unhandled Exception [_] [X] Error Number: 0x80040706 Description: Object reference not set Setup will now terminate [OK] http://consumer.installshield.com/kb.asp?id=q110641 This site says to update InstallShield engine, but that's the solution for windows.

4 3

Move of the Bugzilla CVS to Git
by Jan Zerebecki June 27, 2007

June 27, 2007

I hereby announce that with the upgrade of Bugzilla we will use Git for what the "bugzilla" cvs module is currently used (if nothing unforeseen prevents this). This can be seen as a test for also moving our other remaining CVS modules. Anyone who has a problem with this should speak up now. Btw. the idea is to upgrade the server to "Sarge" shortly before the Bugzilla upgrade. Jan

5 5

Re: user32,wined3d: move refresh rate fallback to catch all cases
by Erik Inge Bolsø June 27, 2007

June 27, 2007

On 25/06/07, H. Verbeet wrote: >On 24/06/07, Erik Inge Bolsø <knan-wine at anduin.net> wrote: >> --- >> dlls/user32/sysparams.c | 13 ++++++++++++- >> dlls/wined3d/device.c | 10 +--------- >> 2 files changed, 13 insertions(+), 10 deletions(-) >> >What was the reason for writing this? See the comments on http://appdb.winehq.org/appview.php?iVersionId=5618 ... essentially, I have a game that's hardcoded to request 1024x768x50hz, which is not available on my monitor, and the existing fallback to any available refresh rate in wined3d didn't catch it. Haven't traced the exact sequence of calls - but figured that since there was an existing refresh rate fallback coded, I'd move that a step instead of duplicating. I can try to trace it down and duplicate the fallback, if that would be a preferable solution. -- Erik

3 2

Re: user32:painting.c Add comment to function.[try2]
by Robert Shearman June 27, 2007

June 27, 2007

Anatoly Lyutin wrote: > /*********************************************************************** > * LockWindowUpdate (USER32.@) > + * > + * Enables or disables choosen window. > This isn't quite correct. LockWindowUpdate prevents or allows painting to the window. It doesn't prevent user input, which is what "disable" suggests (c.f. EnableWindow). -- Rob Shearman

1 0

Re: [advapi32/tests] Add some service related tests
by Paul Vriens June 27, 2007

June 27, 2007

On 6/26/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > While playing with native crypt32/wintrust I added a service (CryptSvc) to the > registry (seems needed for native and XP+). With a full trace I get some crashes > which made me start to write some tests for services. (Rolf Kalbermatter was > already busy with services stuff, but said he doesn't have the time currently). > > Changelog > Add some service related tests > > Cheers, > > Paul. > Ignore this one. I'll come up with something else as I've started fixing things first. Cheers, Paul.

1 1

Re: [PATCH try2 2/2] winemenubuilder: Wait for application icons to be created instead of adding a RunOnce entry that may never run.
by Hans Leidekker June 27, 2007

June 27, 2007

On Wednesday 27 June 2007, Misha Koshelev wrote: + /* Now watch the directory for our path to be created */ + if ((*handles = FindFirstChangeNotificationW(dir, subtree, FILE_NOTIFY_CHANGE_FILE_NAME)) == + INVALID_HANDLE_VALUE) I'm not sure if file change notifications are the right solution here but since they are only supported on Linux you should at least keep the run once key as a fallback strategy. -Hans

4 3

Re: [3/3] gdi32: improved PolyDraw
by Alexandre Julliard June 27, 2007

June 27, 2007

"Evan Stade" <estade(a)gmail.com> writes: > + for( i = dc->path.numEntriesUsed-1; i >= 0; i-- ){ > + if(dc->path.pFlags[i] == PT_MOVETO){ > + lastmove = dc->path.pPoints[i]; > + break; > + } > + } > + if(i < 0){ > + lastmove.x = 0; > + lastmove.y = 0; > + } This can't work, i is unsigned. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi [2/6]: Add the IWineMsiRemotePackage interface
by Alexandre Julliard June 27, 2007

June 27, 2007

"James Hawkins" <truiken(a)gmail.com> writes: > +interface IWineMsiRemotePackage : IUnknown > +{ > + HRESULT SetMsiHandle( [in] ULONG_PTR handle ); > + HRESULT GetActiveDatabase( [out] ULONG_PTR handle ); > + HRESULT GetProperty( [in] BSTR *property, [out] BSTR *value, [out] ULONG_PTR size ); Why are you using ULONG_PTR instead of the proper pointer types for out parameters? -- Alexandre Julliard julliard(a)winehq.org

1 0

GDI/GDI+ creating paths
by Evan Stade June 27, 2007

June 27, 2007

Hi, I was talking with Julliard about the implementation of paths in GDI+. He suggested that the right way to do it was to build paths directly (i.e. not calling into GDI). I'm not sure why calling into GDI is undesirable. There are several reasons I'd like to use GDI paths: * GDI and GDI+ paths seem to behave exactly the same way * this implementation of GDI+ calls into GDI for drawing, so it seems natural to rely on GDI to create paths as well. * unless we take rendering completely out of the hands of GDI, we need GDI to draw paths for us because of line joins. It seems strange to me to draw shapes and draw paths with GDI, but not to create paths with GDI. * path.c in gdi32 is 2000 lines, and re-implementing it seems overkill I don't see any drawbacks of calling into GDI to make paths, other than a slight performance decrease introduced by an extra level of indirection. Can anyone suggest another reason why this approach is flawed? -- Evan Stade

2 2

Re: [SPAM] Problem with patch "dsound: Simplify mixing by removing remixing support, and fix its waveout breakage"
by Alex Villacís Lasso June 27, 2007

June 27, 2007

Chris Rankin escribió: > Hi, > > This patch has killed the sound on World of Warcraft. Instead, I now get silence and a stream of > errors like this: > > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > > The following change makes the sound work again without error messages, but there is still a brief > burst of sound/noise before the music starts properly: > > $ cvswine diff dlls/dsound/buffer.c > Index: dlls/dsound/buffer.c > =================================================================== > RCS file: /home/wine/wine/dlls/dsound/buffer.c,v > retrieving revision 1.70 > diff -u -r1.70 buffer.c > --- dlls/dsound/buffer.c 22 Jun 2007 12:37:22 -0000 1.70 > +++ dlls/dsound/buffer.c 25 Jun 2007 19:08:34 -0000 > @@ -442,15 +442,15 @@ > pmix *= This->pwfx->nBlockAlign; > > TRACE("this back-offset=%d\n", pmix); > - > +#if 0 > /* sanity */ > if(pmix > This->buflen){ > ERR("Bad length in CalcPlayPosition!\n"); > return 0; > } > - > +#endif > /* subtract from our last mixed position */ > - if (bplay < pmix) bplay += This->buflen; /* wraparound */ > + while (bplay < pmix) bplay += This->buflen; /* wraparound */ > bplay -= pmix; > > /* check for lead-in */ > > > Cheers, > Chris > > > > > > > ___________________________________________________________ > New Yahoo! Mail is the ultimate force in competitive emailing. Find out more at the Yahoo! Mail Championships. Plus: play games and win prizes. > http://uk.rd.yahoo.com/evt=44106/*http://mail.yahoo.net/uk > > You might try the patch with the title "DSOUND: recover from mismatch between time spanned by primary buffer being longer than the one spanned by secondary buffer", which I sent along with some other patches today. It looks somewhat similar to the one you sent. Alex Villacís Lasso -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Writing tests in Wine.
by Anatoly Lyutin June 26, 2007

June 26, 2007

Hi all! When I analyzed Wine test codes today I do not understand how to interpret result of tests.That is why I refer to community. I can not find any full documentation for writing tests at WineHq. I have some points which I do not understand: 1. Why some tests are running in Win not fall if expected and obtained messages are not coincide. ex (user32:msg:test_mdi_messages:Win2k3): msg.c:2716:mdi frame: 00090362, 0086, 00000000, 00000000 msg.c:2716:mdi frame: 00090362, 0002, 00000000, 00000000 msg.c:2716:mdi frame: 00090362, 0082, 00000000, 00000000 msg.c:3302:expected 0004 - actual 0004 msg.c:3302:expected 0046 - actual 0046 msg.c:3302:expected 8003 - actual 0047 msg.c:3302:expected 0086 - actual 0047 msg.c:3302:expected 0047 - actual 0047 msg.c:3302:expected 0086 - actual 0086 msg.c:3302:expected 0006 - actual 0002 msg.c:3302:expected 001c - actual 0002 msg.c:3302:expected 8003 - actual 0002 msg.c:3302:expected 8001 - actual 0002 msg.c:3302:expected 0002 - actual 0002 msg.c:3302:expected 0082 - actual 0082 Why does not this fail?(ok_sequence(WmDestroyMDIframeSeq, "Destroy MDI frame window", FALSE);) 2. How I can write test for different OS Windows? Some tests run successfully in win2k3 but fail in XP, that is why this test can not be validated by HQ. 3.What does it mean :{ HCBT_SETFOCUS, hook }? What does this hook in some tests make fail in Win2k3 if it was included? Thank you for attention. -- Best regards Anatoly Lyutin.

2 1

Re: winefile: Use the msvcrt provided _tsplitpath instead of reimplementing it.
by Alexandre Julliard June 26, 2007

June 26, 2007

Michael Stefaniuc <mstefani(a)redhat.de> writes: > Actually i wanted to just remove the wide character constants out of > splitpath.c but then i have seen that the file can be removed completely. > I checked the history but didn't find a clue why a separate > implementation might have been usefull. splitpath.c appeared with the > initial import of the winefile source code. Winefile cannot import msvcrt because it has support for accessing Unix files too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: please help me with filling a bug concerning WM_ERASEBKGND
by Juan Lang June 26, 2007

June 26, 2007

Hi, if you've done a reasonable job searching for a dup and haven't found one, go ahead and file a new bug. Bugs can be closed or linked where appropriate. > is this http://bugs.winehq.org/show_bug.cgi?id=6006 ? > Il try to compile latest git with patches from that bug before filling > new one. I think these may very well be related, but (IMO) they should be different bugs. A bug should describe the problem, not the fix. If a patch for one fixes the other, great! --Juan ____________________________________________________________________________________ Got a little couch potato? Check out fun summer activities for kids. http://search.yahoo.com/search?fr=oni_on_mail&p=summer+activities+for+kids&…

1 0

Slackware 11: After Wine update applications crash if WINEDEBUG not set
by Victor June 26, 2007

June 26, 2007

Hello! I didn't get an answer for this in wine-user, so I've decided to ask this question here. After upgrading wine (from 0.9.37 to 0.9.38 or from 0.9.38 to 0.9.39 - I'm not sure) many graphical applications started crashing if WINEDEBUG+=all or WINEDEBUG+=relay not set. Among those applications are Postal 1, Kiosaky's Cashflow 101, .kkreiger and probably more. I'm not sure if this is a bug in Wine or a problem in my system, because uninstalling and downgrading (even to 0.9.34) didn't help - problem now exists in other versions as well. Applications crash in a "windows way" - with access violation at address 0x7XXXXXXX. Here is a beginning of output produced by trying to start .kkreiger (avaliable at http://www.theprodukkt.com/) --begin-- Unhandled page fault on read access to 0xffffffff at address 0x7d66c9ce (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0xffffffff in 32-bit code ?0x7d66c9ce). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7d66c9ce ESP:0033e8a8 EBP:00009f80 EFLAGS:00210246( - 00 -RIZP1) EAX:0033e8c8 EBX:7d68a000 ECX:00000000 EDX:00000000 ESI:01000000 EDI:00001f80 Stack dump: 0x0033e8a8: 0033e8c8 00000000 00000000 b7fd6ff8 0x0033e8b8: 7d72aaa9 7d72aaa9 0033ec18 00001f80 0x0033e8c8: 00000000 00000000 00000000 00000000 0x0033e8d8: 00000000 00000000 00000000 00000000 0x0033e8e8: 00000000 00000000 00000000 00000000 0x0033e8f8: 00000000 00000000 00000000 00000000 Backtrace: =>1 0x7d66c9ce (0x00009f80) 2 0x00000000 (0x00000000) 0x7d66c9ce: --end-- But it works fine if started as WINEDEBUG=+relay wine wine pno001.exe &>/dev/null This application worked fine before and didn't need those flags. Kyosaky's Cashflow 101 crashes with a windows message box which says "Unhandled exceptionL c0000005 At address: 7ce2f9ce". but works fine if started with WINEDEBUG=+relay same thing with Postal 1. There are also problems with an Alien vs Predator 2 game and some other apps that enumerate D3D display modes: if program has a listbox where videomodes can be selected, this box will contain no strings (alien vs. predator, ragnarok online, some other apps), if WINEDEBUG+=all is not set. Can these problems be connected with those crashes? System configuration: Slackware 11 linux with 2.6.17.13 kernel on AMD Sempron 2800+ processor with GeForce 7100GS and 512Mb ram. Any pointers how can I figure out what's wrong? Thanks. With best regards, Victor Eremin.

2 3

re: How to make your machine crash when running Wine
by Dan Kegel June 26, 2007

June 26, 2007

There's a similar discussion going on here: http://www.linuxforums.org/forum/wine/96022-wine-hard-system-freeze-new-pos… --- snip --- i had the same problem. I use wine with Ubuntu Daper on Core T7200 Duo Laptop. I moved from the kernel 2.6.15-28-386 to 2.6.15-28-686 and wine starts to freeze. * moving from nvidia to vesa-driver -> no luck * set Hyperthreading-kernelswitch ht=on to ht=off -> no luck After moving back to 2.6.15-28-386 it worked again. The workaround ist to use the 386-kernel. (Linux version 2.6.15-28-386 (buildd(a)terranova) (gcc version 4.0.3 (Ubuntu 4.0.3-1ubuntu5)) #1 PREEMPT Thu May 10 09:45:43 UTC 2007) PS: I used wine_0.9.39~winehq0~ubuntu~6.06-1_i386.deb and wine_0.9.9-0ubuntu2_i386.deb --- snip ---

1 0

Using Rx Controls (Delphi) [resend]
by Anatoly Lyutin June 26, 2007

June 26, 2007

-- Best regards Anatoly Lyutin.

1 0

Re: msi [1/6]: Add support for remote handles
by Alexandre Julliard June 26, 2007

June 26, 2007

"James Hawkins" <truiken(a)gmail.com> writes: > @@ -215,18 +282,28 @@ UINT WINAPI MsiCloseHandle(MSIHANDLE han > > EnterCriticalSection( &MSI_handle_cs ); > > - info = msihandle2msiinfo(handle, 0); > - if( !info ) > - goto out; > - > - if( info->magic != MSIHANDLE_MAGIC ) > + unk = msi_get_remote( handle ); > + if (unk) > + IUnknown_Release( unk ); > + else > { It seems to me you are leaking the object here, the handle entry holds a ref to it too. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: About stdlib.h system()
by Kirill K. Smirnov June 26, 2007

June 26, 2007

I've tried MSVC 6.0 and MSVC 2003. All the same - it works. Please, check your sources. I have no idea where the bug can be. > Yes, the mingw-gcc case works. > But I use the Visual C++ 7.0 to compile. It still fails. > > On 6/26/07, Kirill K. Smirnov <lich(a)math.spbu.ru> wrote: > > Hi, > > > > I've tried to reproduce, but failed: > > > > a.c: > > #include <stdio.h> > > #include <stdlib.h> > > > > int main(void) > > { > > system("qqq.exe"); > > return 0; > > } > > > > > > $ mingw-gcc -mconsole -mno-cygwin a.c > > $ wine a.exe > > > > It works. > > > > $ mingw-gcc a.c > > $ wine a.exe > > > > It works too. > > > > Executable qqq.exe exists in ~/.wine/drive_c/windows directory. > > > > -- > > Kirill

1 0

About stdlib.h system()
by Kirill K. Smirnov June 26, 2007

June 26, 2007

Hi, I've tried to reproduce, but failed: a.c: #include <stdio.h> #include <stdlib.h> int main(void) { system("qqq.exe"); return 0; } $ mingw-gcc -mconsole -mno-cygwin a.c $ wine a.exe It works. $ mingw-gcc a.c $ wine a.exe It works too. Executable qqq.exe exists in ~/.wine/drive_c/windows directory. -- Kirill

2 1

please help me with filling a bug concerning WM_ERASEBKGND
by RusH June 26, 2007

June 26, 2007

searching bugzilla for WM_ERASEBKGND returns lots of bugs, but I have no idea if mine is there http://bugs.winehq.org/buglist.cgi?query_format=&short_desc_type=allwordssu… The bug is weird. Running uTorrent (latest beta ) http://download.utorrent.com/beta/utorrent-1.7-beta-2899.uncompressed.exe with wine set to emulate XP is fine, but when you set it to Windows 98 or lower wine stops sending WM_ERASEBKGND (or/and breaks WM_PAINT). background surfaces are not repainted and remain black. is this http://bugs.winehq.org/show_bug.cgi?id=6006 ? Il try to compile latest git with patches from that bug before filling new one. -- Who logs in to gdm? Not I, said the duck.

1 0

user32 patch unaccepted
by Clinton Stimpson June 26, 2007

June 26, 2007

Was there anything wrong with this patch, that it didn't get accepted? <http://www.winehq.org/pipermail/wine-patches/2007-March/037272.html> It limits update regions to the nearest clipping parent window. Thanks Clinton Stimpson

1 0

Re: gdi32: Multi-character character constants aren't portable as their behaviour is compiler dependent according to the C standard. Found by sparse.
by James Hawkins June 25, 2007

June 25, 2007

On 6/25/07, Michael Stefaniuc <mstefani(a)redhat.de> wrote: > I have no way to test this patch as i don't have a Mac. > > bye > michael > --- > dlls/gdi32/freetype.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 424fb3d..bcf16ae 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -590,6 +590,7 @@ static char **expand_mac_font(const char *path) > unsigned short *num_faces_ptr, num_faces, face; > AsscEntry *assoc; > Handle fond; > + ResType fond_res = 0x464f4e44 /* 'FOND' */; > > fond = Get1IndResource('FOND', idx); > if(!fond) break; Did you mean to replace 'FOND' in the Get1IndResource call with fond_res? > @@ -605,6 +606,7 @@ static char **expand_mac_font(const char *path) > for(face = 0; face < num_faces; face++, assoc++) > { > Handle sfnt; > + ResType sfnt_res = 0x73666e74 /* 'sfnt' */ > unsigned short size, font_id; > char *output; > > @@ -617,7 +619,7 @@ static char **expand_mac_font(const char *path) > } > > TRACE("trying to load sfnt id %04x\n", font_id); > - sfnt = GetResource('sfnt', font_id); > + sfnt = GetResource(sfnt_res, font_id); > if(!sfnt) > { > TRACE("can't get sfnt resource %04x\n", font_id); > -- > 1.5.0.6 > -- James Hawkins

1 0

re: WIDL: Implement support for explicit user handles
by Dan Kegel June 25, 2007

June 25, 2007

Eric wrote: > This patch implements support for explicit user handles. Say, could you add a test for that? I think Dan H. usually adds tests to rpcrt4 whenever he adds a feature to widl. cf. http://source.winehq.org/git/?p=wine.git&a=search&st=author&s=dsh - Dan

1 0

Re: [5/5] WineD3D: Implement mipmap auto generation
by Stefan Dösinger June 25, 2007

June 25, 2007

Am Montag, 25. Juni 2007 14:42 schrieb Stefan Dösinger: > I have no application that needs this, so this is an untested per-msdn > implementation. Do not apply this patch yet. It's missing some check in LoadTexture to not upload sublevels manually if autogen is on

1 0

Re: [3/5] WineD3D: rsq and rcp use the .w component if no swizzle is given
by H. Verbeet June 25, 2007

June 25, 2007

On 25/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + 0x0009fffe, 0x58443344, 0x68532038, /* No idea about that stuff, */ > + 0x72656461, 0x73734120, 0x6c626d65, /* vsa.exe generated it */ > + 0x56207265, 0x69737265, 0x30206e6f, /* And without it windows complains*/ > + 0x0031392e, That looks pretty bad, imo.

2 1

Re: mshtml #14: Added more QueryInterface tests.
by Detlef Riekenberg June 25, 2007

June 25, 2007

On So, 2007-06-24 at 21:10 +0200, Jacek Caban wrote: > + ok(qi == NULL, "runnable=%p, ezpected NULL\n", qi) The Patch is in the Tree, but I suggest to change: "ezpected" to "expected" in several Places. Thanks, with greetings from Copy and Paste -- By by ... Detlef

2 1

Making the wiki FAQ live
by Scott Ritchie June 25, 2007

June 25, 2007

So, about a month ago we discussed the idea of replacing the documentation FAQ with one based in the wiki. Nothing was done, but the general consensus seemed to be to wait and see if the wiki approach worked out better. Since that time, the Wiki FAQ has been updated by 7 people other than myself. We've removed most of the cruft, and taken the FAQ from an unhelpful mess to something a user actually should read. Meanwhile, the original FAQ has been unchanged. It's not done, but I think it's time to take it live and make the wiki FAQ our official FAQ, and then remove the old one from the documentation build. Based on the past month alone, I think it's fairly safe to say that it's easier to maintain, update, and keep relevant this way. I've already sent a patch for lostwages to wine-devel. Thanks, Scott Ritchie

3 3

re: VST wrapper
by Dan Kegel June 25, 2007

June 25, 2007

Hi N8, > [How can I write a shared library that uses Wine and > can be called from a non-winelib app?] This is a somewhat frequently asked question. As Stephan explained, wine's code requires that the process have been set up somewhat specially. This is taken care of by the sources in the loader subdirectory. In a perfect world, some of that code would move into the operating system's process loader... then one could mix and match win32 and unix calls more easily. Anyway, knowing about the code in that directory is key to understanding why what you ask is hard, and in finding a workaround. - Dan

2 1

Re: [3/5] WineD3D: rsq and rcp use the .w component if no swizzle is given
by Frank Richter June 25, 2007

June 25, 2007

On 25.06.2007 16:03, H. Verbeet wrote: > On 25/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: >> + 0x0009fffe, 0x58443344, 0x68532038, /* No >> idea about that stuff, */ >> + 0x72656461, 0x73734120, 0x6c626d65, /* >> vsa.exe generated it */ >> + 0x56207265, 0x69737265, 0x30206e6f, /* And >> without it windows complains*/ >> + 0x0031392e, > That looks pretty bad, imo. FWIW, that comment reads "D3DX8 Shader Assembler Version 0.91". -f.r.

1 0

configure:2479: error: C compiler cannot create executables
by jens＠jens June 25, 2007

June 25, 2007

This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by Wine configure 0.9.39, which was generated by GNU Autoconf 2.61. Invocation command line was $ ./configure --prefix=/opt/wine --with-x ## --------- ## ## Platform. ## ## --------- ## hostname = jens uname -m = x86_64 uname -r = 2.6.20-15-generic uname -s = Linux uname -v = #2 SMP Sun Apr 15 06:17:24 UTC 2007 /usr/bin/uname -p = unknown /bin/uname -X = unknown /bin/arch = x86_64 /usr/bin/arch -k = unknown /usr/convex/getsysinfo = unknown /usr/bin/hostinfo = unknown /bin/machine = unknown /usr/bin/oslevel = unknown /bin/universe = unknown PATH: /usr/local/sbin PATH: /usr/local/bin PATH: /usr/sbin PATH: /usr/bin PATH: /sbin PATH: /bin PATH: /usr/games ## ----------- ## ## Core tests. ## ## ----------- ## configure:1888: checking build system type configure:1906: result: x86_64-unknown-linux-gnu configure:1928: checking host system type configure:1943: result: x86_64-unknown-linux-gnu configure:2008: checking whether make sets $(MAKE) configure:2029: result: yes configure:2086: checking for gcc configure:2113: result: gcc -m32 configure:2351: checking for C compiler version configure:2358: gcc -m32 --version >&5 gcc (GCC) 4.1.2 (Ubuntu 4.1.2-0ubuntu4) Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. configure:2361: $? = 0 configure:2368: gcc -m32 -v >&5 Using built-in specs. Target: x86_64-linux-gnu Configured with: ../src/configure -v --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --program-suffix=-4.1 --enable-__cxa_atexit --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-checking=release x86_64-linux-gnu Thread model: posix gcc version 4.1.2 (Ubuntu 4.1.2-0ubuntu4) configure:2371: $? = 0 configure:2378: gcc -m32 -V >&5 gcc: '-V' must come at the start of the command line configure:2381: $? = 1 configure:2404: checking for C compiler default output file name configure:2431: gcc -m32 /usr/lib32 conftest.c >&5 /usr/bin/ld: /usr/lib32: No such file: File format not recognized collect2: ld returned 1 exit status configure:2434: $? = 1 configure:2472: result: configure: failed program was: | /* confdefs.h. */ | #define PACKAGE_NAME "Wine" | #define PACKAGE_TARNAME "wine" | #define PACKAGE_VERSION "0.9.39" | #define PACKAGE_STRING "Wine 0.9.39" | #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" | /* end confdefs.h. */ | | int | main () | { | | ; | return 0; | } configure:2479: error: C compiler cannot create executables See `config.log' for more details. ## ---------------- ## ## Cache variables. ## ## ---------------- ## ac_cv_build=x86_64-unknown-linux-gnu ac_cv_env_CCC_set= ac_cv_env_CCC_value= ac_cv_env_CC_set= ac_cv_env_CC_value= ac_cv_env_CFLAGS_set= ac_cv_env_CFLAGS_value= ac_cv_env_CPPFLAGS_set= ac_cv_env_CPPFLAGS_value= ac_cv_env_CPP_set= ac_cv_env_CPP_value= ac_cv_env_CXXFLAGS_set= ac_cv_env_CXXFLAGS_value= ac_cv_env_CXX_set= ac_cv_env_CXX_value= ac_cv_env_LDFLAGS_set=set ac_cv_env_LDFLAGS_value=/usr/lib32 ac_cv_env_LIBS_set= ac_cv_env_LIBS_value= ac_cv_env_XMKMF_set= ac_cv_env_XMKMF_value= ac_cv_env_build_alias_set= ac_cv_env_build_alias_value= ac_cv_env_host_alias_set= ac_cv_env_host_alias_value= ac_cv_env_target_alias_set= ac_cv_env_target_alias_value= ac_cv_host=x86_64-unknown-linux-gnu ac_cv_prog_ac_ct_CC='gcc -m32' ac_cv_prog_make_make_set=yes ## ----------------- ## ## Output variables. ## ## ----------------- ## ALSALIBS='' AR='' AS='as --32' AUDIOIOLIBS='' BISON='' BUILTINFLAG='' CARBONLIB='' CC='gcc -m32' CFLAGS='' COREAUDIO='' COREFOUNDATIONLIB='' CPP='' CPPBIN='' CPPFLAGS='' CROSSCC='' CROSSTEST='' CROSSWINDRES='' CRTLIBS='' CXX='' CXXFLAGS='' DEFS='' DEPENDENCIES='' DISKARBITRATIONLIB='' DLLEXT='' DLLFLAGS='' DLLTOOL='' DLLWRAP='' ECHO_C='' ECHO_N='-n' ECHO_T='' EGREP='' ESDCONFIG='' ESDINCL='' ESDLIBS='' EXEEXT='' EXTRACFLAGS='' EXTRA_BINARIES='' FLEX='' FONTFORGE='' FONTSSUBDIRS='' FREETYPEINCL='' FREETYPELIBS='' GLU32FILES='' GPHOTO2INCL='' GPHOTO2LIBS='' GREP='' HALINCL='' ICULIBS='' IMPLIBEXT='' INSTALL_DATA='' INSTALL_PROGRAM='' INSTALL_SCRIPT='' IOKITLIB='' LCMSLIBS='' LD='ld -m elf_i386' LDAPLIBS='' LDCONFIG='' LDD='' LDDLLFLAGS='' LDEXECFLAGS='' LDFLAGS='/usr/lib32' LDPATH='' LDSHARED='' LIBDL='' LIBEXT='' LIBOBJS='' LIBPOLL='' LIBPTHREAD='' LIBS='' LIBWINE_LDFLAGS='' LINT='' LINTFLAGS='' LN='' LN_S='' LTLIBOBJS='' MAIN_BINARY='' MINGWAR='' NASLIBS='' OBJEXT='' OPENGLFILES='' OPENGL_LIBS='' PACKAGE_BUGREPORT='wine-devel(a)winehq.org' PACKAGE_NAME='Wine' PACKAGE_STRING='Wine 0.9.39' PACKAGE_TARNAME='wine' PACKAGE_VERSION='0.9.39' PATH_SEPARATOR=':' PKG_CONFIG='' PRELINK='' QUARTZFILES='' RANLIB='' RESOLVLIBS='' SANEINCL='' SET_MAKE='' SHELL='/bin/bash' SOCKETLIBS='' STRIP='' TOOLSDIR='' WIN16_FILES='$(WIN16_FILES)' WIN16_INSTALL='$(WIN16_INSTALL)' WINDRES='' XFILES='' XLIB='' XMKMF='' XML2INCL='' XML2LIBS='' XSLTINCL='' XSLTLIBS='' X_CFLAGS='' X_EXTRA_LIBS='' X_LIBS='' X_PRE_LIBS='' ac_ct_AS='' ac_ct_CC='gcc -m32' ac_ct_CXX='' bindir='${exec_prefix}/bin' build='x86_64-unknown-linux-gnu' build_alias='' build_cpu='x86_64' build_os='linux-gnu' build_vendor='unknown' datadir='${datarootdir}' datarootdir='${prefix}/share' docdir='${datarootdir}/doc/${PACKAGE_TARNAME}' dvidir='${docdir}' exec_prefix='NONE' ft_devel2='' ft_devel='' gphoto2_devel='' gphoto2port_devel='' host='x86_64-unknown-linux-gnu' host_alias='' host_cpu='i386' host_os='linux-gnu' host_vendor='unknown' htmldir='${docdir}' includedir='${prefix}/include' infodir='${datarootdir}/info' libdir='${exec_prefix}/lib' libexecdir='${exec_prefix}/libexec' localedir='${datarootdir}/locale' localstatedir='${prefix}/var' mandir='${datarootdir}/man' oldincludedir='/usr/include' pdfdir='${docdir}' prefix='/opt/wine' program_transform_name='s,x,x,' psdir='${docdir}' sane_devel='' sbindir='${exec_prefix}/sbin' sharedstatedir='${prefix}/com' sysconfdir='${prefix}/etc' target_alias='' ## ------------------- ## ## File substitutions. ## ## ------------------- ## MAKE_DLL_RULES='' MAKE_IMPLIB_RULES='' MAKE_PROG_RULES='' MAKE_RULES='' MAKE_TEST_RULES='' ## ----------- ## ## confdefs.h. ## ## ----------- ## #define PACKAGE_NAME "Wine" #define PACKAGE_TARNAME "wine" #define PACKAGE_VERSION "0.9.39" #define PACKAGE_STRING "Wine 0.9.39" #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" configure: exit 77

3 2

Re: [Bug 8787] Manhunt: Video goes all black and haywire after intro movies.
by James Hawkins June 25, 2007

June 25, 2007

On 6/24/07, joe b <goce_jeb(a)yahoo.com> wrote: > Game will not install under wine though. That's why I had to install under > the windows partition. > > You can't file a bug report for a game you run from a Windows partition. It's not supported by Wine, mostly because we can't reproduce any bugs this way. If you can't install the game in Wine, then please open a bug report for that. -- James Hawkins

1 0

Re: user32,wined3d: move refresh rate fallback to catch all cases
by H. Verbeet June 25, 2007

June 25, 2007

On 24/06/07, Erik Inge Bolsø <knan-wine(a)anduin.net> wrote: > --- > dlls/user32/sysparams.c | 13 ++++++++++++- > dlls/wined3d/device.c | 10 +--------- > 2 files changed, 13 insertions(+), 10 deletions(-) > What was the reason for writing this?

1 0

Re: mshtml: Implement HTMLElement_get_children.
by Jacek Caban June 25, 2007

June 25, 2007

Hi, > + elem_vector buf = {NULL, 0, 8}; > + > + TRACE("(%p)->(%p)\n", This, p); > + > + buf.buf = mshtml_alloc(buf.size*sizeof(HTMLElement**)); elem_vector is a self-resizable table, but in this case you know the size while creating it from nsIDOMNodeList::GetLength. I'd suggest to use it here during creation of buf to avoid useless memory reallocations. Thanks, Jacek

2 1

Re: WIDL: Implement support for explicit user handles
by Robert Shearman June 25, 2007

June 25, 2007

Eric Kohl wrote: > This patch implements support for explicit user handles. Looks good, but one small nit-pick: Microsoft calls these "generic" handles instead of user handles. It would be good if you could rename the relevant bits to match this. Thanks, -- Rob Shearman

1 0

VST wrapper
by Nathaniel Gray June 25, 2007

June 25, 2007

Hi, I'm interested in the goal of using Windows VST/VSTi audio plugins on my Intel Mac in OS X. I found the fst project, did some porting, and managed to get a few VSTs to work, which had me pretty stoked. Thanks to the FST folks and the Wine team for making this possible! On the other hand, I'd rather have the option of running the plugins in-process with my DAW software instead of as separate processes connected by JACK. I can imagine a super-thin layer of code that just translates calls between the plugin and the host and allows the plugin to access the Win32 API. In case I'm being unclear, here's how it breaks down. There's a host application that's native OS X and knows nothing about Wine. I'd like to write a plugin that, when it's loaded, will load a windows dll. The host will call into the plugin, which will call into the dll. The dll will make upcalls to the plugin, which will in turn call up to the host. The dll will probably be running a windows gui as well and making calls to various windows APIs. So is this possible? I'm pretty new to Wine and Windows programming so forgive me if the answer to this question is obvious. I've seen plenty of examples of how to build and run .exes that are windows programs from the ground up, but I've never seen wine used as part of a plugin. If it's possible, can you point me to any examples? What are the relevant parts of Wine I should look at? Thanks, -n8 -- >>>-- Nathaniel Gray -- Caltech Computer Science ------> >>>-- Mojave Project -- http://mojave.cs.caltech.edu -->

2 1

Re: VST wrapper
by Nathaniel Gray June 25, 2007

June 25, 2007

By the way, please CC me with replies. I'm not set up to receive mail from the list. Thanks, -n8 -- >>>-- Nathaniel Gray -- Caltech Computer Science ------> >>>-- Mojave Project -- http://mojave.cs.caltech.edu -->

2 1

fix for wine < 0.9.24 segfault on startup
by Damjan Jovanovic June 25, 2007

June 25, 2007

Hi On Ubuntu 7.04, versions of wine before around 0.9.24 die on startup with an undebuggable segmentation fault. After this bug stopped me from doing 2 regression tests, I decided to reverse regression test for the fix to the bug, and I found that the patch at http://www.winehq.org/pipermail/wine-cvs/2006-November/027508.html allows earlier versions of wine to run successfully. Thought this might be helpful to others Damjan

1 0

WIDL: Implement support for explicit user handles
by Eric Kohl June 24, 2007

June 24, 2007

This patch implements support for explicit user handles. Regards Eric Kohl ChangeLog: Implement support for explicit user handles. diff --git a/tools/widl/client.c b/tools/widl/client.c index 86ead20..6a84e94 100644 --- a/tools/widl/client.c +++ b/tools/widl/client.c @@ -89,12 +89,14 @@ static void write_function_stubs(type_t *iface, unsigned int *proc_offset) { const var_t *def = func->def; const var_t* explicit_handle_var; + const var_t* explicit_user_handle_var; /* check for a defined binding handle */ explicit_handle_var = get_explicit_handle_var(func); + explicit_user_handle_var = get_explicit_user_handle_var(func); if (explicit_handle) { - if (!explicit_handle_var) + if (!explicit_handle_var && !explicit_user_handle_var) { error("%s() does not define an explicit binding handle!\n", def->name); return; @@ -102,7 +104,7 @@ static void write_function_stubs(type_t *iface, unsigned int *proc_offset) } else if (implicit_handle) { - if (explicit_handle_var) + if (explicit_handle_var || explicit_user_handle_var) { error("%s() must not define a binding handle!\n", def->name); return; @@ -167,6 +169,19 @@ static void write_function_stubs(type_t *iface, unsigned int *proc_offset) print_client("_Handle = %s;\n", explicit_handle_var->name); fprintf(client, "\n"); } + else if (explicit_user_handle_var) + { + print_client("_Handle = %s_bind(%s);\n", + explicit_user_handle_var->type->name, + explicit_user_handle_var->name); + print_client("if (_Handle == 0)\n"); + print_client("{\n"); + indent++; + print_client("RpcRaiseException(RPC_S_INVALID_BINDING);\n"); + indent--; + print_client("}\n"); + fprintf(client, "\n"); + } write_remoting_arguments(client, indent, func, PASS_IN, PHASE_BUFFERSIZE); @@ -240,6 +255,19 @@ static void write_function_stubs(type_t *iface, unsigned int *proc_offset) print_client("NdrFreeBuffer((PMIDL_STUB_MESSAGE)&_StubMsg);\n"); + if (explicit_user_handle_var) + { + fprintf(client, "\n"); + print_client("if (_Handle)\n"); + print_client("{\n"); + indent++; + print_client("%s_unbind(%s, _Handle);\n", + explicit_user_handle_var->type->name, + explicit_user_handle_var->name); + indent--; + print_client("}\n"); + } + indent--; print_client("}\n"); print_client("RpcEndFinally\n"); diff --git a/tools/widl/header.c b/tools/widl/header.c index 6f2da32..1119542 100644 --- a/tools/widl/header.c +++ b/tools/widl/header.c @@ -463,6 +463,21 @@ const var_t* get_explicit_handle_var(const func_t* func) return NULL; } +const var_t* get_explicit_user_handle_var(const func_t* func) +{ + const var_t* var; + + if (!func->args) + return NULL; + + LIST_FOR_EACH_ENTRY( var, func->args, const var_t, entry ) + if ((var->type->type != RPC_FC_BIND_PRIMITIVE) && + is_attr(var->type->attrs, ATTR_HANDLE)) + return var; + + return NULL; +} + int has_out_arg_or_return(const func_t *func) { const var_t *var; @@ -480,6 +495,40 @@ int has_out_arg_or_return(const func_t *func) return 0; } +static struct list user_handle_list = LIST_INIT(user_handle_list); + +struct user_handle +{ + struct list entry; + char name[1]; +}; + +void add_user_handle(type_t *type) +{ + struct user_handle *uh; + + if (is_attr(type->attrs, ATTR_HANDLE)) + { + uh = (struct user_handle *)xmalloc(sizeof(struct user_handle) + strlen(type->name)); + if (uh) + { + strcpy(uh->name, type->name); + list_add_tail(&user_handle_list, &uh->entry); + } + } +} + +void write_user_handles(void) +{ + const struct user_handle *uh; + + LIST_FOR_EACH_ENTRY(uh, &user_handle_list, struct user_handle, entry) + { + fprintf(header, "handle_t __RPC_USER %s_bind(%s);\n", uh->name, uh->name); + fprintf(header, "void __RPC_USER %s_unbind(%s, handle_t);\n", uh->name, uh->name); + } +} + /********** INTERFACES **********/ @@ -710,6 +759,7 @@ static void write_function_protos(const type_t *iface) const char *implicit_handle = get_attrp(iface->attrs, ATTR_IMPLICIT_HANDLE); int explicit_handle = is_attr(iface->attrs, ATTR_EXPLICIT_HANDLE); const var_t* explicit_handle_var; + const var_t* explicit_user_handle_var; const func_t *cur; int prefixes_differ = strcmp(prefix_client, prefix_server); @@ -720,13 +770,19 @@ static void write_function_protos(const type_t *iface) /* check for a defined binding handle */ explicit_handle_var = get_explicit_handle_var(cur); - if (explicit_handle) { - if (!explicit_handle_var) { + explicit_user_handle_var = get_explicit_user_handle_var(cur); + if (explicit_handle) + { + if (!explicit_handle_var && !explicit_user_handle_var) + { error("%s() does not define an explicit binding handle!\n", def->name); return; } - } else if (implicit_handle) { - if (explicit_handle_var) { + } + else if (implicit_handle) + { + if (explicit_handle_var || explicit_user_handle_var) + { error("%s() must not define a binding handle!\n", def->name); return; } diff --git a/tools/widl/header.h b/tools/widl/header.h index 54655a2..7a6508b 100644 --- a/tools/widl/header.h +++ b/tools/widl/header.h @@ -53,9 +53,12 @@ extern void write_externdef(const var_t *v); extern void write_library(const char *name, const attr_list_t *attr); extern void write_user_types(void); extern const var_t* get_explicit_handle_var(const func_t* func); +extern const var_t* get_explicit_user_handle_var(const func_t* func); extern int has_out_arg_or_return(const func_t *func); extern void write_guid(FILE *f, const char *guid_prefix, const char *name, const UUID *uuid); +extern void add_user_handle(type_t *type); +extern void write_user_handles(void); static inline int last_ptr(const type_t *type) { diff --git a/tools/widl/parser.y b/tools/widl/parser.y index 4933c43..a6df42d 100644 --- a/tools/widl/parser.y +++ b/tools/widl/parser.y @@ -1932,7 +1932,10 @@ static void process_typedefs(pident_list_t *pidents) type_t *type = find_type(var->name, 0); if (! parse_only && do_header) + { write_typedef(type); + add_user_handle(type); + } if (in_typelib && type->attrs) add_typelib_entry(type); diff --git a/tools/widl/server.c b/tools/widl/server.c index fd94c9a..2e261e5 100644 --- a/tools/widl/server.c +++ b/tools/widl/server.c @@ -61,6 +61,7 @@ static void write_function_stubs(type_t *iface, unsigned int *proc_offset) const func_t *func; const var_t *var; const var_t* explicit_handle_var; + const var_t* explicit_user_handle_var; if (!iface->funcs) return; LIST_FOR_EACH_ENTRY( func, iface->funcs, const func_t, entry ) @@ -69,9 +70,10 @@ static void write_function_stubs(type_t *iface, unsigned int *proc_offset) /* check for a defined binding handle */ explicit_handle_var = get_explicit_handle_var(func); + explicit_user_handle_var = get_explicit_user_handle_var(func); if (explicit_handle) { - if (!explicit_handle_var) + if (!explicit_handle_var && !explicit_user_handle_var) { error("%s() does not define an explicit binding handle!\n", def->name); return; @@ -79,7 +81,7 @@ static void write_function_stubs(type_t *iface, unsigned int *proc_offset) } else if (implicit_handle) { - if (explicit_handle_var) + if (explicit_handle_var || explicit_user_handle_var) { error("%s() must not define a binding handle!\n", def->name); return; diff --git a/tools/widl/widl.c b/tools/widl/widl.c index 21657b6..0af449d 100644 --- a/tools/widl/widl.c +++ b/tools/widl/widl.c @@ -409,6 +409,7 @@ int main(int argc,char *argv[]) if(do_header) { fprintf(header, "/* Begin additional prototypes for all interfaces */\n"); fprintf(header, "\n"); + write_user_handles(); write_user_types(); fprintf(header, "\n"); fprintf(header, "/* End additional prototypes */\n");

1 0

wine menus
by Damjan Jovanovic June 24, 2007

June 24, 2007

Hi At the moment, wine builds fd.o menus by calling winemenubuilder and wineshelllink when shell32's IPersistFile_fnSave is invoked. This both misses menus copied directly into the menu directory without calling IPersistFile_fnSave, and provides no way to remove the menus when the app is uninstalled. Wine also keeps .lnk files in ~/.wine/drive_c/windows/profiles/<user>/Start Menu/ just like Windows does, and those .lnk files seem like a much better representation of the menus that should appear on the system, because they are also deleted when an app is uninstalled. Is it possible to add a new utility, or patch an existing utility like wineboot, to synchronize between wine's .lnk files in the windows directory and the fd.o menus, instead of using winemenubuilder/wineshelllink? Would a patch that does that be okay? Thank you Damjan

7 9

Re: msi: Fix use of uninitialized variable (Coverity) (Try 3)
by James Hawkins June 24, 2007

June 24, 2007

On 6/23/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > [Reverting to "Plan A":] > This patch should fix Coverity bug CID-562. Additionally, I have pinpointed > another suspected use-before-initialization bug, for future consideration. > > -- Andy. > --- > Changelog: > msi: Fix use of uninitialized variable (Coverity). > > diff -urN a/dlls/msi/action.c b/dlls/msi/action.c > --- a/dlls/msi/action.c 2007-06-18 17:52:27.000000000 +0100 > +++ b/dlls/msi/action.c 2007-06-23 22:19:03.000000000 +0100 > @@ -4668,7 +4668,7 @@ > > res = env_set_flags(&name, &deformatted, &flags); > if (res != ERROR_SUCCESS) > - goto done; > + goto done2; > > value = deformatted; > > @@ -4676,8 +4676,14 @@ > root = HKEY_LOCAL_MACHINE; > > res = RegOpenKeyExW(root, environment, 0, KEY_ALL_ACCESS, &env); > + /* > + * FIXME: RegCloseKey() should not be called with an invalid handle. > + * So should we simply "goto done2" here, if res != EXIT_SUCCESS, > + * or does RegOpenKeyEx() have any failure modes in which "env" does > + * get initialized? > + */ > if (res != ERROR_SUCCESS) > - goto done; > + goto done1; > > if (flags & ENV_ACT_REMOVE) > FIXME("Not removing environment variable on uninstall!\n"); > @@ -4686,14 +4692,14 @@ > res = RegQueryValueExW(env, name, NULL, &type, NULL, &size); > if ((res != ERROR_SUCCESS && res != ERROR_FILE_NOT_FOUND) || > (res == ERROR_SUCCESS && type != REG_SZ)) > - goto done; > + goto done1; > > if (res != ERROR_FILE_NOT_FOUND) > { > if (flags & ENV_ACT_SETABSENT) > { > res = ERROR_SUCCESS; > - goto done; > + goto done1; > } > > data = msi_alloc(size); > @@ -4705,12 +4711,12 @@ > > res = RegQueryValueExW(env, name, NULL, &type, (LPVOID)data, &size); > if (res != ERROR_SUCCESS) > - goto done; > + goto done1; > > if (flags & ENV_ACT_REMOVEMATCH && (!value || !lstrcmpW(data, value))) > { > res = RegDeleteKeyW(env, name); > - goto done; > + goto done1; > } > > size = (lstrlenW(value) + 1 + size) * sizeof(WCHAR); > @@ -4719,7 +4725,7 @@ > if (!newval) > { > res = ERROR_OUTOFMEMORY; > - goto done; > + goto done1; > } > > if (!(flags & ENV_MOD_MASK)) > @@ -4749,7 +4755,7 @@ > if (!newval) > { > res = ERROR_OUTOFMEMORY; > - goto done; > + goto done1; > } > > lstrcpyW(newval, value); > @@ -4758,8 +4764,9 @@ > TRACE("setting %s to %s\n", debugstr_w(name), debugstr_w(newval)); > res = RegSetValueExW(env, name, 0, type, (LPVOID)newval, size); > > -done: > +done1: > RegCloseKey(env); > +done2: > msi_free(deformatted); > msi_free(data); > msi_free(newval); > This is uglier than the other patch. The only change needed in this entire function is to set env to NULL initially. There's nothing wrong with calling RegCloseKey(NULL-var) and it's done everywhere in the code base. -- James Hawkins

1 0

Re: msi: Fix use of uninitialized variable (Coverity) (Try 2)
by James Hawkins June 24, 2007

June 24, 2007

On 6/23/07, Andrew Talbot <Andrew.Talbot(a)talbotville.com> wrote: > This patch should fix Coverity bug CID-562. > > -- Andy. > --- > Changelog: > msi: Fix use of uninitialized variable (Coverity). > > diff -urN a/dlls/msi/action.c b/dlls/msi/action.c > --- a/dlls/msi/action.c 2007-06-18 17:52:27.000000000 +0100 > +++ b/dlls/msi/action.c 2007-06-23 17:08:55.000000000 +0100 > @@ -4648,7 +4648,7 @@ > LPWSTR deformatted, ptr; > DWORD flags, type, size; > LONG res; > - HKEY env, root = HKEY_CURRENT_USER; > + HKEY env = NULL, root = HKEY_CURRENT_USER; > > static const WCHAR environment[] = > {'S','y','s','t','e','m','\\', > @@ -4759,7 +4759,7 @@ > res = RegSetValueExW(env, name, 0, type, (LPVOID)newval, size); > > done: > - RegCloseKey(env); > + if (env) RegCloseKey(env); > msi_free(deformatted); > msi_free(data); > msi_free(newval); > Please don't check env for NULL; RegCloseKey will just fail harmlessly if env is NULL. We spent a lot of time removing such checks. -- James Hawkins

4 3

Bugzilla mails and people replying to wine-bugs@winehq.com
by Tom Spear June 23, 2007

June 23, 2007

Just curious how trivial it would be to add a note to the bugzilla mail template saying to post replies to comments in the bug? Something like the following: A bug you are watching, Bug #(bug number), has a new comment. To reply to this comment, click (bug link). Then the rest of the email as it currently appears. I'm asking because I have received several replies to the list recently, and once wine reaches 1.0, I'm sure many more people will join the list and do the same. I don't want comments to be lost due to them not being posted in the proper place, as everyone's input on a bug is important. -- Thanks Tom

3 3

Wine on SkyOS
by Tom Wickline June 23, 2007

June 23, 2007

Hello All, Looks as if SkyOS will soon support Wine! Internals - Many kernel updates like LDT support (required by Wine), updated signal handling, pthread support, and overall additional POSIX compatibility enhancements. http://www.skyos.org/?q=node/605 Tom

3 2

Re: msi: Fix use of uninitialized variable (Coverity)
by Paul Vriens June 23, 2007

June 23, 2007

Andrew Talbot wrote: > This patch should fix Coverity bug CID-562. Additionally, I have pinpointed > another suspected use-before-initialization bug, for future consideration. > > -- Andy. > --- > Changelog: > msi: Fix use of uninitialized variable (Coverity). > Wouldn't it be easier to set env to NULL when declaring it and do a: if (env) RegCloseKey(env); Cheers, Paul.

2 1

RegOpenKeyExW() Question
by Andrew Talbot June 23, 2007

June 23, 2007

Hi, I want to patch msi:action.c:ITERATE_WriteEnvironmentString() so that it only calls RegCloseKey(env), in the cleanup, if "env" has been initialized (to fix Coverity report CID-562). I can bypass the call to RegCloseKey() for any early exit that occurs prior to calling RegOpenKeyExW(), and I can include the call to RegCloseKey() for exits that occur after a successful call to RegOpenKeyExW(). However, the problem, for me, is what to do if the call to RegOpenKeyExW() fails: does the occurrence of this initialization depend on the reason for failure. In other words, do I need something like the following code to cater for the reason failure occurred? res = RegOpenKeyExW(root, environment, 0, KEY_ALL_ACCESS, &env); if (res != ERROR_SUCCESS) if (res == ERROR_INVALID_HANDLE || res == RtlNtStatusToDosError(STATUS_BUFFER_OVERFLOW || res == RtlNtStatusToDosError(STATUS_INVALID_PARAMETER)) goto done2; else goto done1; ... done1: RegCloseKey(env); done2: ... Or will the following code suffice? res = RegOpenKeyExW(root, environment, 0, KEY_ALL_ACCESS, &env); if (res != ERROR_SUCCESS) goto done2; ... done1: RegCloseKey(env); done2: ... Thanks, -- Andy.

2 2

gdiplus: graphics tests [try2]
by Misha Koshelev June 22, 2007

June 22, 2007

> Am Freitag, 15. Juni 2007 22:02 schrieb Jan Zerebecki: > > On Fri, Jun 15, 2007 at 01:36:09PM +0200, Alexandre Julliard wrote: > > > "Evan Stade" <estade at gmail.com> writes: > > > > +static const INT drawline_bmp1[192] = > > > > +{0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xf > > > >fffffff, > > > > > > I don't think we want to do that sort of thing. We can't guarantee > > > that the results will be exact pixel for pixel, and we don't really > > > care. And even if we did, hardcoding the image in the source this way > > > is unmaintainable. > > > > > > If you want to check the results, you should write an app that draws > > > various things and check it visually against Windows, but I don't > > > think that's something that can be part of the regression test suite. > > May I suggest something like enclosing your gdiplus function calls in a regression test in a BeginPath(hdc) and EndPath(hdc) and then using GetPath to check that the paths created by your functions conform to those on native (you can take a look at what I am using right now in dlls/gdi/tests/path.c and some expansions here http://www.winehq.org/pipermail/wine-patches/2007-June/040679.html) I have found that it seems to be a good way to test at least the gdi functions without having to compare the visual result pixel by pixel while still being able to test the basic drawing primitives that are being used (btw you have to give the x&y coords +/- 1 or 2 when checking them b/c of floating point rounding diffs). The only downside for using this kind of framework would be that if anything changes in gdi32's path implementation it would affect your tests, but I think no matter what you do for a graphics regression tests for gdiplus changes in gdi32 would affect it. Just wanted to throw the idea out as I think a good conformance test is worth its weight in gold. Misha

2 2

Re: winealsa.drv: Fix missing unlock on the error path. Found by Smatch.
by Maarten Lankhorst June 22, 2007

June 22, 2007

That fix is correct, This->pcm is only ever changed inside the critical section Thanks, Maarten 2007/6/22, Michael Stefaniuc <mstefani(a)redhat.de>: > Maarten, > > is this the right fix or can the lock be moved below the > if (!This->pcm) > check? > > bye > michael > --- > dlls/winealsa.drv/dsoutput.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/winealsa.drv/dsoutput.c b/dlls/winealsa.drv/dsoutput.c > index 57b8968..9fc5020 100644 > --- a/dlls/winealsa.drv/dsoutput.c > +++ b/dlls/winealsa.drv/dsoutput.c > @@ -459,6 +459,7 @@ static HRESULT WINAPI IDsDriverBufferImpl_GetPosition(PIDSDRIVERBUFFER iface, > if (!This->pcm) > { > FIXME("Bad pointer for pcm: %p\n", This->pcm); > + LeaveCriticalSection(&This->pcm_crst); > return DSERR_GENERIC; > } > > -- > 1.5.0.6 >

1 0

Failing assertion in dsound test, please confirm
by Alex Villacís Lasso June 22, 2007

June 22, 2007

I am experiencing a failing assertion in a dsound test. Could you please confirm if it is just me (and then it would be a configuration issue), or if anybody else is experiencing failing assertions: [alex(a)srv64 tests]$ WINETEST_INTERACTIVE=1 wine dsound_test.exe.so dsound ALSA lib conf.c:3939:(snd_config_expand) Unknown parameters 0 ALSA lib control.c:910:(snd_ctl_open_noupdate) Invalid CTL default:0 fixme:wave:ALSA_AddCaptureDevice Add support for DSCapture dsound.c:973:DLL Version: 5.3.1.904 dsound.c:180:Testing IDirectSound fixme:dsalsa:SetFormat Your alsa dmix period size is excessively high, unfortunately this is alsa default, try decreasing it to 512 or 256 (but double the amount of periods) if possible fixme:ole:CoCreateInstance no instance created for interface {11ab3ec0-25ec-11d1-a4d8-00c04fc28aca} of class {47d4d946-62e8-11cf-93bc-444553540000}, hres is 0x80004002 err:ole:CoGetClassObject class {11ab3ec0-25ec-11d1-a4d8-00c04fc28aca} not registered err:ole:CoGetClassObject no class object {11ab3ec0-25ec-11d1-a4d8-00c04fc28aca} could be created for context 0x1 dsound.c:938:*** Testing Primary Sound Driver - winealsa.drv *** dsound.c:475:Playing a 5 seconds reference tone at the current volume. dsound.c:478:(the current volume is -4651 according to DirectSound) dsound.c:480:All subsequent tones should be identical to this one. dsound.c:481:Listen for stutter, changes in pitch, volume, etc. ds3d.c:400:Requested format tag=0x0001 11025x16x2 avg.B/s=44100 align=4 ds3d.c:403:Got tag=0x0001 48000x16x2 avg.B/s=192000 align=4 ds3d.c:453: Playing 5 second 440Hz tone at 48000x16x2 dsound.c:582:Requested primary format tag=0x0001 8000x8x1 avg.B/s=8000 align=1 dsound.c:586:Got tag=0x0001 48000x8x1 avg.B/s=48000 align=1 dsound.c:607: Testing a primary buffer at 48000x8x1 with a secondary buffer at 11025x16x2 ds3d.c:453: Playing 1 second 440Hz tone at 11025x16x2 dsound.c:582:Requested primary format tag=0x0001 8000x8x2 avg.B/s=16000 align=2 dsound.c:586:Got tag=0x0001 48000x8x2 avg.B/s=96000 align=2 dsound.c:607: Testing a primary buffer at 48000x8x2 with a secondary buffer at 11025x16x2 ds3d.c:453: Playing 1 second 440Hz tone at 11025x16x2 dsound.c:582:Requested primary format tag=0x0001 8000x16x1 avg.B/s=16000 align=2 dsound.c:586:Got tag=0x0001 48000x16x1 avg.B/s=96000 align=2 dsound.c:607: Testing a primary buffer at 48000x16x1 with a secondary buffer at 11025x16x2 ds3d.c:453: Playing 1 second 440Hz tone at 11025x16x2 dsound.c:582:Requested primary format tag=0x0001 8000x16x2 avg.B/s=32000 align=4 dsound.c:586:Got tag=0x0001 48000x16x2 avg.B/s=192000 align=4 dsound.c:607: Testing a primary buffer at 48000x16x2 with a secondary buffer at 11025x16x2 ds3d.c:453: Playing 1 second 440Hz tone at 11025x16x2 mixer.c:823: DSOUND_PerformMix: La declaración `device->playpos < device->buflen' no se cumple. wine: Assertion failed at address 0x600007f2 (thread 000f), starting debugger... dsound.c:582:Requested primary format tag=0x0001 11025x8x1 avg.B/s=11025 align=1 dsound.c:586:Got tag=0x0001 48000x8x1 avg.B/s=48000 align=1 dsound.c:607: Testing a primary buffer at 48000x8x1 with a secondary buffer at 11025x16x2 Unhandled exception: assertion failed in 32-bit code (0x600007f2). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:600007f2 ESP:7ed516cc EBP:7ed516d8 EFLAGS:00000202( - 00 - - I1) EAX:00000000 EBX:00002cd3 ECX:00002cd5 EDX:00000006 ESI:7ed51778 EDI:60298ff4 Stack dump: 0x7ed516cc: 60171fa0 60298ff4 7ed52b90 7ed51804 0x7ed516dc: 601738b1 00000006 7ed51778 00000000 0x7ed516ec: 00000068 7cae1278 00000000 00000000 0x7ed516fc: 601ae37d 7ed5173c 7cae1278 7cae12dc 0x7ed5170c: 7ed51814 60298ff4 00000062 7cae1278 0x7ed5171c: 7ed517e8 601a7d3b 7cae1278 00000062 Backtrace: =>1 0x600007f2 (0x7ed516d8) 2 0x601738b1 (0x7ed51804) 3 0x6016b3ce (0x7ed51848) 4 0x608bdfe8 DSOUND_timer+0x2108(timerID=0x1, msg=0x0, dwUser=0x167688, dw1=0x0, dw2=0x0) [/home/alex/install/wine-0.9.39-build/dlls/dsound/mixer.c:554] in dsound (0x7ed519b8) 5 0x60910b96 TIME_MMSysTimeThread+0x2e6(arg=0x0) [/home/alex/install/wine-0.9.39-build/dlls/winmm/time.c:181] in winmm (0x7ed51a18) 6 0x7bc5d19e call_thread_entry_point+0xe() in ntdll (0x7ed51a28) 7 0x7bc5de72 call_thread_func+0x42(rtl_func=<register EDI not in topmost frame>, arg=<register ESI not in topmost frame>) [/home/alex/install/wine-0.9.39-build/dlls/ntdll/thread.c:404] in ntdll (0x7ed51ac8) 8 0x7bc5e10f in ntdll (+0x4e10f) (0x7ed523c8) 9 0x601362fb (0x7ed524b8) 10 0x6021993e (0x00000000) 0x600007f2: ret Modules: Module Address Debug info Name (66 modules) ELF 24d000- 2bd000 Deferred libgl.so.1 ELF 24d000- 2bd000 Deferred libgl.so.1 ELF 43e000- 45b000 Deferred ld-linux.so.2 ELF 45d000- 5b1000 Deferred libc.so.6 ELF 5b3000- 5dc000 Deferred libm.so.6 ELF 5de000- 5e3000 Deferred libdl.so.2 ELF 5fa000- 612000 Deferred libpthread.so.0 ELF 614000- 619000 Deferred libxxf86vm.so.1 ELF 640000- 645000 Deferred libxfixes.so.3 ELF 6b5000- 6bb000 Deferred libxdmcp.so.6 ELF 6bd000- 7bf000 Deferred libx11.so.6 ELF 802000- 805000 Deferred libxau.so.6 ELF 80c000- 81c000 Deferred libxext.so.6 ELF 8aa000- 8cb000 Deferred libexpat.so.0 ELF 926000- 92f000 Deferred libxrender.so.1 ELF a84000- a8e000 Deferred libxcursor.so.1 ELF a98000- b22000 Deferred libfreetype.so.6 ELF b24000- b53000 Deferred libfontconfig.so.1 ELF bbb000- bc6000 Deferred libdrm.so.2 ELF cef000- cf6000 Deferred libxrandr.so.2 ELF dfa000- dfd000 Deferred libxinerama.so.1 ELF 5cf0000- 5dce000 Deferred libasound.so.2 ELF 65f6000- 65ff000 Deferred libsm.so.6 ELF 6601000- 661b000 Deferred libice.so.6 ELF 6001d000-60131000 Deferred libwine.so.1 ELF 602cb000-6032b000 Deferred dsound_test<elf> \-PE 602e0000-6032b000 \ dsound_test ELF 6032b000-60371000 Deferred advapi32<elf> \-PE 60340000-60371000 \ advapi32 ELF 60371000-604ab000 Deferred user32<elf> \-PE 60390000-604ab000 \ user32 ELF 604ab000-60541000 Deferred gdi32<elf> \-PE 604c0000-60541000 \ gdi32 ELF 60541000-60597000 Deferred rpcrt4<elf> \-PE 60550000-60597000 \ rpcrt4 ELF 60597000-605b5000 Deferred iphlpapi<elf> \-PE 605a0000-605b5000 \ iphlpapi ELF 605c9000-605e2000 Deferred version<elf> \-PE 605d0000-605e2000 \ version ELF 60892000-608db000 Dwarf dsound<elf> \-PE 608a0000-608db000 \ dsound ELF 608db000-60968000 Dwarf winmm<elf> \-PE 608f0000-60968000 \ winmm ELF 60a46000-60a5e000 Deferred msacm32<elf> \-PE 60a50000-60a5e000 \ msacm32 ELF 60a5e000-60a84000 Deferred msacm32<elf> \-PE 60a70000-60a84000 \ msacm32 ELF 61d5f000-61d74000 Deferred midimap<elf> \-PE 61d70000-61d74000 \ midimap ELF 6a741000-6a74d000 Deferred libnss_files.so.2 ELF 6d8a4000-6d8d6000 Deferred winealsa<elf> \-PE 6d8b0000-6d8d6000 \ winealsa ELF 7525e000-752ec000 Deferred winex11<elf> \-PE 75270000-752ec000 \ winex11 ELF 757d6000-757ea000 Deferred lz32<elf> \-PE 757e0000-757ea000 \ lz32 ELF 77861000-7787e000 Deferred imm32<elf> \-PE 77870000-7787e000 \ imm32 ELF 79cd4000-79cd7000 Deferred iso8859-1.so ELF 79d6e000-79e0b000 Deferred ole32<elf> \-PE 79d80000-79e0b000 \ ole32 ELF 7b800000-7b924000 Deferred kernel32<elf> \-PE 7b820000-7b924000 \ kernel32 ELF 7bc00000-7bc96000 Dwarf ntdll<elf> \-PE 7bc10000-7bc96000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> Threads: process tid prio (all id:s are in hex) 00000010 00000012 0 00000011 0 0000000d (D) Z:\home\alex\install\wine-0.9.39-build\dlls\dsound\tests\dsound_test.exe 0000000f 15 <== 0000000e 0 -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: How to make your machine crash when running Wine
by gslink June 22, 2007

June 22, 2007

Most of the people here are probably smarter than to fall into this trap but I recently had several customers who did. Most of the time openGL just refuses to run but a couple of months ago RH did put out an update to some of the X code that did cause the machine to crash with Wine if you didn't replace the Nvidia driver. The customers were running some things under Wine that used hardware acceleration. If they had used hardware acceleration outside of Wine the machine would have crashed too. This is not a Wine problem but it is likely to be a source of regular complaints.

1 0

Re: dpnhpast: Add stub for DirectPlayNATHelpCreate
by Detlef Riekenberg June 22, 2007

June 22, 2007

On Fr, 2007-06-22 at 04:39 +0200, Alexander Nicolaysen Sørnes wrote: > +HRESULT WINAPI DirectPlayNATHelpCreate(const LPGUID pIId, void ** > ppvInterface) > { > - /* @stub in .spec */ > + FIXME("stub"); > + return E_FAIL; > } > -#endif The FIXME is missing the newline and it would be useful to dump the Parameters in the FIXME. -- By by ... Detlef

1 0

Re: [3/7] gdiplus: GdipReAlloc
by Alexandre Julliard June 22, 2007

June 22, 2007

"Evan Stade" <estade(a)gmail.com> writes: > This is only declared privately because it is not a function provided > by the dll. It follows the exported-function naming scheme however, > because it's a counterpart to GdipFree and GdipAlloc. Please don't do that, it's confusing. If there's no GdipReAlloc just use HeapReAlloc directly. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: [1/2] oleaut32: add PNG loading [try2]
by Dan Kegel June 22, 2007

June 22, 2007

Alexandre wrote: >> How can I improve this patch such that it will be accepted? > >The biggest problem is that the libpng versioning scheme is broken, so >we can't find the proper soname. This will need some more configure >magic. Looking at http://www.libpng.org/pub/png/libpng.html and http://www.linux-foundation.org/en/LibPng and /usr/include/png.h I get the impression that the libpng versioning scheme was cleaned up for the 1.2 series over four years ago. So perhaps we could just change configure.ac to check PNG_LIBPNG_VER_MAJOR and make sure it's exactly 1, and check PNG_LIBPNG_VER_MINOR and make sure it's 2 or greater. That would let us avoid the old broken libpng's, wouldn't it? - Dan

2 1

Re: [PATCH try2 4/4] gdi32: Call pMoveTo if available when emulating ArcTo/PolylineTo/PolyBezierTo.
by Alexandre Julliard June 22, 2007

June 22, 2007

Misha Koshelev <mk144210(a)bcm.edu> writes: > This sends proper position information to the GDI driver when we are emulating these functions. I don't think I agree with this one. If the driver needs to update the position then it should implement ArcTo etc. since it may need to distinguish that from an explicit MoveTo. Or if the generic implementation is really good enough in all cases then we shouldn't export a driver entry point at all. -- Alexandre Julliard julliard(a)winehq.org

3 3

Re: PATCH - implement LockWorkStation using xdg-screensaver on Linux
by Hans Leidekker June 21, 2007

June 21, 2007

On Tuesday 19 June 2007 20:08:50 Steven Edwards wrote: > Patch by Hans Leidekker It's your idea so you should get the credit. I was just helping out with the implementation. > This could be expanded for other platforms that use xdg stuff by > changing the #ifdef. I added the #ifdef to also deal with the MacOS > case. There will allways be Linux distributions that don't install the xdg tools by default, and it's not inconceivable that they will be supported on MacOS one day. So I think it's better to just try to run xdg-screensaver, warn when it fails, but ignore the error. From reading MSDN this is consistent with the semantics of LockWorkStation. I also think it's better to not lock the entire desktop when Wine runs in a virtual desktop. I remember looking for a way to know whether we are running in desktop mode and found this snippet from PaintDesktop(): HWND hwnd = GetDesktopWindow(); /* check for an owning thread; otherwise don't paint anything (non-desktop mode) */ if (GetWindowThreadProcessId( hwnd, NULL )) ... I copied it but somehow it didn't work for me. -Hans

5 5

re: NULL ptr dereferences found with Calysto static checker
by Dan Kegel June 21, 2007

June 21, 2007

Domagoj wrote: > I've ran my static checker Calysto on Wine v0.9.35 and got > 78 bug reports:... > If you are interested in the reports, please: > 1) read > http://www.cs.ubc.ca/~babic/index_calysto_community.htm > 2) if the conditions are acceptable, let me know where to > send the reports. The conditions look very minimal, we should be fine with them. A check once a month should be fine. Just send the results to wine-devel(a)winehq.org. (There's some chance we'll ask you to switch to sending them somewhere else, but that will do initially.) For the moment just put the calysto.org link in the mail. Once it's clear the results are useful, somebody will link to calysto at least from our wiki. Say, whatever happened to Coverity's scans of Wine? I just logged in to the Wine results at http://scan.coverity.com, and the last scan seems to have been last July. Did they set up a new, private site for us? Paul V., do you know? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

9 11

Coverity status
by Paul Vriens June 21, 2007

June 21, 2007

Hi, I've been in contact with Coverity. People currently listed as Wine contacts are: - Jan Zerebecki - Paul Vriens The main page is changed so it reflects the new scan site http://scan2.coverity.com:7479 and there has just been a new run! Coverity is very busy setting up some proper communication channels and some means for the contacts to do some kind of user administration (limited of course). Apart from that a lot of the current manual tasks will be automated (like the counters on the page where Wine is listed http://scan.coverity.com/rung1.html) Cheers, Paul.

1 0

Re: winmm: Specify the arguments of the function in the function pointer
by Alexandre Julliard June 21, 2007

June 21, 2007

Michael Stefaniuc <mstefani(a)redhat.de> writes: > @@ -114,10 +114,10 @@ static BOOL MMDRV_GetDescription32(const char* fname, char* buf, int buflen) > DWORD dw; > BOOL ret = FALSE; > UINT u; > - FARPROC pGetFileVersionInfoSizeA; > - FARPROC pGetFileVersionInfoA; > - FARPROC pVerQueryValueA; > - HMODULE hmodule = 0; > + DWORD (WINAPI *pGetFileVersionInfoSizeA)(LPCSTR,LPDWORD); > + BOOL (WINAPI *pGetFileVersionInfoA)(LPCSTR,DWORD,DWORD,LPVOID); > + BOOL (WINAPI *pVerQueryValueA)(LPCVOID,LPCSTR,LPVOID*,UINT*); > + HMODULE hmodule = 0; It may have been done that way because local WINAPI pointers crash on old versions of gcc. But that whole function should probably be removed, dumping version info doesn't belong in winmm. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] oleaut32: add PNG loading [try2]
by Evan Stade June 21, 2007

June 21, 2007

On 6/19/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > Try2: This time the rowsize is correctly aligned (on 4-byte > boundaries) and palette-mode PNGs are allowed as well as RGB-mode > PNGs. > > Changelog: > *added support to decode some PNG files > *added check for png.h / dynamic loading of libpng.so > > configure.ac | 2 > dlls/oleaut32/olepicture.c | 205 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 207 insertions(+), 0 deletions(-) > > -- > Evan Stade > > Hi, How can I improve this patch such that it will be accepted? -- Evan Stade

2 1

Re: shell32: Make SHGetDesktopFolder use a cached instance of IShellFolder
by Alexandre Julliard June 21, 2007

June 21, 2007

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + sf = LocalAlloc( LMEM_ZEROINIT, sizeof (IGenericSFImpl) ); > + if (!sf) > + return E_OUTOFMEMORY; > + > + if (InterlockedCompareExchangePointer((void *)&cached_sf, sf, NULL) != NULL) > + LocalFree( sf ); /* some other thread already been here */ > + else > + { > + sf->ref = 0; > + sf->lpVtbl = &vt_MCFldr_ShellFolder2; > + sf->pidlRoot = _ILCreateDesktop(); /* my qualified pidl */ > + sf->sPathTarget = SHAlloc( (lstrlenW(szMyPath) + 1)*sizeof(WCHAR) ); > + lstrcpyW( sf->sPathTarget, szMyPath ); > + } > + } You need to initialize the object completely before storing it as cached entry. -- Alexandre Julliard julliard(a)winehq.org

1 0

ntdll: Constify some variables (1 of 2)
by Andrew Talbot June 21, 2007

June 21, 2007

Please ignore this patch. Thanks, -- Andy.

1 0

Re: [kernel32][tests] Add test for GetShortPathNameW
by Dmitry Timoshkov June 21, 2007

June 21, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > + WCHAR PROG_FILES_DIR[MAX_PATH]; Looks like that this variable is not used anywhere. > static DWORD (WINAPI *pGetLongPathNameA)(LPCSTR,LPSTR,DWORD); > static DWORD (WINAPI *pGetLongPathNameW)(LPWSTR,LPWSTR,DWORD); > +static DWORD (WINAPI *pGetShortPathNameW)(LPWSTR,LPWSTR,DWORD); I don't see where pGetShortPathNameW is initialized. > + file = CreateFileW(short_path, GENERIC_READ|GENERIC_WRITE, 0, > + NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + ok(file != INVALID_HANDLE_VALUE, "File was not created.\n"); > + ret = WriteFile(file, "test", strlen("test"), NULL, NULL); > + ok(ret, "Can not open file!!\n"); The error message in ok() is not correct. > + CloseHandle(file); > + ret = DeleteFileW(short_path); > + ok(ret, "Can not delete file.\n"); > + GetTempPathW(MAX_PATH, path); > + lstrcatW(path, src); > + lstrcatW(path, backSlash); > + ret = RemoveDirectoryW(path); 'path' at this point already contains what you need, calling GetTempPathW and friends is not needed, and that would simplify the code a bit. > +static void test_GetShortPathNameW(void) > +{ > + WCHAR empty[MAX_PATH]; > + WCHAR pathE[] = {'p','a','t','h','t','e','s','t',0}; > + WCHAR pathRL[] = {0x0414,0x043B,0x0438,0x043D,0x043D,0x043E,0x0435,0x0418,0x043C,0x044F,0}; /* Long Russian name > */ > + WCHAR pathRS[] = {0x0418,0x043C,0x044F,0}; /* Short Russian name */ Do you really need the test to use cyrillic characters? That won't work if underlying unix locale is not russian regardless what you set the thread locale to. > + /* Not present in all windows versions */ > + if(pGetShortPathNameW) > + { > + SetLastError(0xdeadbeef); > + length = pGetShortPathNameW(NULL,NULL,0); > + if(GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > + { > + skip("GetShortPathNameW is not implemented\n"); > + return; > + } Indentation inside of 'if(pGetShortPathNameW)' is completely messed up. -- Dmitry.

2 2

Re: [kernel32][tests] Add test for GetShortPathNameW
by Detlef Riekenberg June 20, 2007

June 20, 2007

On Di, 2007-06-19 at 13:18 +0400, Anatoly Lyutin wrote: > + { > + SetLastError(0xdeadbeef); > + length = pGetShortPathNameW(NULL,NULL,0); > + if(GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > + { > + skip("GetShortPathNameW is not implemented\n"); > + return; Your indention looks wired -- By by ... Detlef

1 0

NULL ptr dereferences found with Calysto static checker
by Domagoj Babic June 20, 2007

June 20, 2007

Hi, I've ran my static checker Calysto on Wine v0.9.35 and got 78 bug reports: makedep: 1 sfnt2fnt: 4 winebuild: 6 winedump: 2 winegcc: 5 libwine: 60 If you are interested in the reports, please: 1) read http://www.cs.ubc.ca/~babic/index_calysto_community.htm 2) if the conditions are acceptable, let me know where to send the reports. Kind regards, -- Domagoj Babic http://www.domagoj.info/ http://www.calysto.org/

1 0

On stuttering audio in quartz/DirectShow
by Alex Villacís Lasso June 20, 2007

June 20, 2007

Upon checking the source code of dlls/quartz I found out about the method SetSyncSource defined in the IBaseFilter interface: dsoundrender.c:static HRESULT WINAPI DSoundRender_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) filesource.c:static HRESULT WINAPI AsyncReader_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) filtergraph.c:static HRESULT WINAPI MediaFilter_SetSyncSource(IMediaFilter *iface, IReferenceClock *pClock) parser.c:static HRESULT WINAPI Parser_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) transform.c:static HRESULT WINAPI TransformFilter_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) videorenderer.c:static HRESULT WINAPI VideoRenderer_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) In particular, I see the following two things about sync sources: 1) I see no effort on part of filtergraph.c to add a sync source when simply asked to render a file 2) Even if it did, current implementation of videorenderer.c does nothing with its sync source So I have a couple of questions: 1) Am I right to assume that a sync source might be used to synchronize and (if necessary) drop frames at the videorenderer in order to maintain synchronization and avoid stuttering? 2) Could the sttutering really be solved by implementing the using and passing of a synchronization source (systemclock.c) in file rendering? If so, then the migration to DirectDraw would become just an optimization to increase the frame rate. Alex Villacís Lasso -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1