June 2007 - Wine-Devel - list.winehq.org

shelllink patches
by Misha Koshelev June 29, 2007

June 29, 2007

Btw, in case it was not clear from the patches themselves, without these patches out shelllinks for non-executables currently point to the application that is assigned to open them (e.g., notepad), rather than to the actual file as on native. Misha

1 0

Re: msi 1: Implement MsiSourceListGetInfoA [try2]
by Alexandre Julliard June 28, 2007

June 28, 2007

"James Hawkins" <truiken(a)gmail.com> writes: > + ret = MsiSourceListGetInfoW(product, usersid, dwContext, dwOptions, > + property, value, pcchValue); > + if (ret == ERROR_SUCCESS) > + WideCharToMultiByte(CP_ACP, 0, value, -1, szValue, *pcchValue, NULL, NULL); The handling of pcchValue is wrong, you need a separate variable for the W size, and you need to set *pcchValue to the correct A size. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]
by Evan Stade June 28, 2007

June 28, 2007

On 6/27/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > [try2] The patch I sent yesterday was not properly todo_wined. Also, > this test is a bit more extensive (about twice as many points drawn). > It uses various point-type combination (even non-sensical ones such as > PT_LINETO | PT_MOVETO) to test the exact logic of PolyDraw with an > open path. > > changelog: > * added polydraw test to path testing (5 more todo_wines) > > dlls/gdi32/tests/path.c | 70 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 70 insertions(+), 0 deletions(-) > > -- > Evan Stade > > sorry for the post on wine-patches. How can I improve this test? -- Evan Stade

1 0

Re: wincrypt: add missing defines
by Mounir IDRASSI June 28, 2007

June 28, 2007

You forgot the attachement... Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Juan Lang wrote: > --Juan > > > > ____________________________________________________________________________________ > Choose the right car based on your needs. Check out Yahoo! Autos new Car Finder tool. > http://autos.yahoo.com/carfinder/ > > > > >

2 1

Wine networking broke on Debian Sid
by Ben Hodgetts (Enverex) June 28, 2007

June 28, 2007

Just to make this clear before starting this is a Sid issue (as far as I can tell) not a Wine issue. Anyway, to the point. Networking is broken on Debian Sid and has been for at least a week. I can't find out what has changed in Sid for it to stop working but basically anyone running Wine on Sid wont be able to use any form of network access. Firefox wont work, games wont be able to access servers or anything else, Gecko wont work, etc. This is using GIT, not the distros own packages. I tried using the x86_64 package for Ubuntu 7.04 (because no x86_64 package exists for Debian) and Wine acted exactly the same way with a clean .wine so it's not related to any build time issues. I reset to 0.9.34 in GIT and built that to make sure it wasn't anything that has changed in Wine itself and the issue continued, so it's not something that's changed in Wine. Although using an earlier version of Wine gives a "Winehq.com could not be found, please check the address and try again". Current Wine (or rather Gecko) doesn't bother giving you an error message. Could this be the work of the removal of an unspoken Wine dependency or something more sinister? All native apps still work perfectly which is what makes this such a hard thing to track down. I just thought I'd throw this out there in-case any of you are using Sid and wondering what the the hell happened to Wine. Log attached for completeness. Ben H.

1 0

Re: cabinent: add a comment about parm passing
by James Hawkins June 28, 2007

June 28, 2007

On 6/27/07, Jeff Latimer <lats(a)yless4u.com.au> wrote: > Coverity CID 43 Forward_Null is false. This adds a comment explaining > the NULL pass is ok. > Why do we need a comment for that? -- James Hawkins

3 2

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]
by Misha Koshelev June 28, 2007

June 28, 2007

> +static const path_test_t polydraw_path[] = { > + {300, 300, 6, 0, 0}, /*0*/ > + {150, 200, 2, 0, 0}, /*1*/ > + {200, 150, 3, 0, 0}, /*2*/ > + {300, 300, 6, 0, 1}, /*3*/ > + {300, 300, 2, 0, 0}, /*4*/ > + {400, 300, 2, 0, 0}, /*5*/ > + {400, 350, 2, 0, 0}, /*6*/ > + {50, 100, 6, 0, 0}, /*7*/ > + {100, 50, 2, 0, 0}, /*8*/ > + {400, 250, 2, 0, 0}, /*9*/ > + {500, 300, 2, 0, 0}, /*10*/ > + {500, 350, 2, 0, 0}, /*11*/ > + {350, 400, 6, 0, 1}, /*12*/ > + {600, 200, 2, 0, 1}, /*13*/ > + {500, 150, 2, 0, 1}, /*14*/ > + {500, 350, 6, 0, 0}, /*15*/ > + {500, 150, 2, 0, 0}, /*16*/ > + {100, 200, 2, 0, 0}, /*17*/ > + {400, 150, 2, 0, 0}, /*18*/ > + {400, 350, 2, 0, 0} /*19*/ > + }; This is not major, but just thought I'd point out that if you do a set WINETEST_DEBUG=3 on Windows and then call ok_path in your test (you can just do a 0 size when you first make the test for this), you'll get the following output, which seems like it would be both faster to produce and nicer-looking (get the actual PT_'s rather than a number): static const path_test_t polydraw_path[] = { {300, 300, PT_MOVETO, 0, 0}, /* 0 */ {150, 200, PT_LINETO, 0, 0}, /* 1 */ {200, 150, PT_LINETO | PT_CLOSEFIGURE, 0, 0}, /* 2 */ {300, 300, PT_MOVETO, 0, 0}, /* 3 */ {300, 300, PT_LINETO, 0, 0}, /* 4 */ {400, 300, PT_LINETO, 0, 0}, /* 5 */ {400, 350, PT_LINETO, 0, 0}, /* 6 */ {50, 100, PT_MOVETO, 0, 0}, /* 7 */ {100, 50, PT_LINETO, 0, 0}, /* 8 */ {400, 250, PT_LINETO, 0, 0}, /* 9 */ {500, 300, PT_LINETO, 0, 0}, /* 10 */ {500, 350, PT_LINETO, 0, 0}, /* 11 */ {350, 400, PT_MOVETO, 0, 0}, /* 12 */ {600, 200, PT_LINETO, 0, 0}, /* 13 */ {500, 150, PT_LINETO, 0, 0}, /* 14 */ {500, 350, PT_MOVETO, 0, 0}, /* 15 */ {500, 150, PT_LINETO, 0, 0}, /* 16 */ {100, 200, PT_LINETO, 0, 0}, /* 17 */ {400, 150, PT_LINETO, 0, 0}, /* 18 */ {400, 350, PT_LINETO, 0, 0}}; /* 19 */ Hope this helps. Misha

1 0

mozilla control download problems?
by Dan Kegel June 27, 2007

June 27, 2007

Say, I just saw a repeatable mozilla download failure. Here's a summary of the tcpdump log. Is this a known problem? - Dan

2 1

Re: Problem with patch "dsound: Simplify mixing by removing remixing support, and fix its waveout breakage"
by Maarten Lankhorst June 27, 2007

June 27, 2007

Chris Rankin schreef: > Hi, > > This patch has killed the sound on World of Warcraft. Instead, I now get silence and a stream of > errors like this: > Don't #if 0 out the code there Change it to something like this: if (pmix > This->buflen) WARN("Mixing further ahead then buffer is long\n");

2 1

Re: Worms world party install - 0x80040706 object reference not set
by James Hawkins June 27, 2007

June 27, 2007

On 6/27/07, Peter <swjawa(a)gmail.com> wrote: > 2007/6/27, James Hawkins <truiken(a)gmail.com>: > > On 6/27/07, Peter <swjawa(a)gmail.com> wrote: > > > When I try to install worms world party I get a message when 6%: > > > Unhandled Exception [_] [X] > > > Error Number: 0x80040706 > > > Description: Object reference not set > > > > > > Setup will now terminate > > > [OK] > > > > > > http://consumer.installshield.com/kb.asp?id=q110641 > > > This site says to update InstallShield engine, but that's the solution > > > for windows. > > > > > > > Why would it not be the solution for Wine? > > > > -- > > James Hawkins > > > Yes it works now. > Thanks. > Please reply-all so everyone can know the results. -- James Hawkins

1 0

RE: [advapi32/service #2] Don't rely blindly on type
by Rolf Kalbermatter June 27, 2007

June 27, 2007

Hi Paul, >On Wine, type is unchanged in a failure case for RegQueryValueExW. This means the >previous code relied on the returned type of the previous last succeeded call, huh? You are right that there is a problem with the existing code at some places. But changing - if( ( r == ERROR_SUCCESS ) || ( type == REG_DWORD ) ) + if( ( r == ERROR_SUCCESS ) && ( type == REG_DWORD ) ) should be enough. Since the funtion returned with success the type must be valid now. Rolf Kalbermatter

1 0

Worms world party install - 0x80040706 object reference not set
by Peter June 27, 2007

June 27, 2007

When I try to install worms world party I get a message when 6%: Unhandled Exception [_] [X] Error Number: 0x80040706 Description: Object reference not set Setup will now terminate [OK] http://consumer.installshield.com/kb.asp?id=q110641 This site says to update InstallShield engine, but that's the solution for windows.

4 3

Move of the Bugzilla CVS to Git
by Jan Zerebecki June 27, 2007

June 27, 2007

I hereby announce that with the upgrade of Bugzilla we will use Git for what the "bugzilla" cvs module is currently used (if nothing unforeseen prevents this). This can be seen as a test for also moving our other remaining CVS modules. Anyone who has a problem with this should speak up now. Btw. the idea is to upgrade the server to "Sarge" shortly before the Bugzilla upgrade. Jan

5 5

Re: user32,wined3d: move refresh rate fallback to catch all cases
by Erik Inge Bolsø June 27, 2007

June 27, 2007

On 25/06/07, H. Verbeet wrote: >On 24/06/07, Erik Inge Bolsø <knan-wine at anduin.net> wrote: >> --- >> dlls/user32/sysparams.c | 13 ++++++++++++- >> dlls/wined3d/device.c | 10 +--------- >> 2 files changed, 13 insertions(+), 10 deletions(-) >> >What was the reason for writing this? See the comments on http://appdb.winehq.org/appview.php?iVersionId=5618 ... essentially, I have a game that's hardcoded to request 1024x768x50hz, which is not available on my monitor, and the existing fallback to any available refresh rate in wined3d didn't catch it. Haven't traced the exact sequence of calls - but figured that since there was an existing refresh rate fallback coded, I'd move that a step instead of duplicating. I can try to trace it down and duplicate the fallback, if that would be a preferable solution. -- Erik

3 2

Re: user32:painting.c Add comment to function.[try2]
by Robert Shearman June 27, 2007

June 27, 2007

Anatoly Lyutin wrote: > /*********************************************************************** > * LockWindowUpdate (USER32.@) > + * > + * Enables or disables choosen window. > This isn't quite correct. LockWindowUpdate prevents or allows painting to the window. It doesn't prevent user input, which is what "disable" suggests (c.f. EnableWindow). -- Rob Shearman

1 0

Re: [advapi32/tests] Add some service related tests
by Paul Vriens June 27, 2007

June 27, 2007

On 6/26/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > While playing with native crypt32/wintrust I added a service (CryptSvc) to the > registry (seems needed for native and XP+). With a full trace I get some crashes > which made me start to write some tests for services. (Rolf Kalbermatter was > already busy with services stuff, but said he doesn't have the time currently). > > Changelog > Add some service related tests > > Cheers, > > Paul. > Ignore this one. I'll come up with something else as I've started fixing things first. Cheers, Paul.

1 1

Re: [PATCH try2 2/2] winemenubuilder: Wait for application icons to be created instead of adding a RunOnce entry that may never run.
by Hans Leidekker June 27, 2007

June 27, 2007

On Wednesday 27 June 2007, Misha Koshelev wrote: + /* Now watch the directory for our path to be created */ + if ((*handles = FindFirstChangeNotificationW(dir, subtree, FILE_NOTIFY_CHANGE_FILE_NAME)) == + INVALID_HANDLE_VALUE) I'm not sure if file change notifications are the right solution here but since they are only supported on Linux you should at least keep the run once key as a fallback strategy. -Hans

4 3

Re: [3/3] gdi32: improved PolyDraw
by Alexandre Julliard June 27, 2007

June 27, 2007

"Evan Stade" <estade(a)gmail.com> writes: > + for( i = dc->path.numEntriesUsed-1; i >= 0; i-- ){ > + if(dc->path.pFlags[i] == PT_MOVETO){ > + lastmove = dc->path.pPoints[i]; > + break; > + } > + } > + if(i < 0){ > + lastmove.x = 0; > + lastmove.y = 0; > + } This can't work, i is unsigned. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msi [2/6]: Add the IWineMsiRemotePackage interface
by Alexandre Julliard June 27, 2007

June 27, 2007

"James Hawkins" <truiken(a)gmail.com> writes: > +interface IWineMsiRemotePackage : IUnknown > +{ > + HRESULT SetMsiHandle( [in] ULONG_PTR handle ); > + HRESULT GetActiveDatabase( [out] ULONG_PTR handle ); > + HRESULT GetProperty( [in] BSTR *property, [out] BSTR *value, [out] ULONG_PTR size ); Why are you using ULONG_PTR instead of the proper pointer types for out parameters? -- Alexandre Julliard julliard(a)winehq.org

1 0

GDI/GDI+ creating paths
by Evan Stade June 27, 2007

June 27, 2007

Hi, I was talking with Julliard about the implementation of paths in GDI+. He suggested that the right way to do it was to build paths directly (i.e. not calling into GDI). I'm not sure why calling into GDI is undesirable. There are several reasons I'd like to use GDI paths: * GDI and GDI+ paths seem to behave exactly the same way * this implementation of GDI+ calls into GDI for drawing, so it seems natural to rely on GDI to create paths as well. * unless we take rendering completely out of the hands of GDI, we need GDI to draw paths for us because of line joins. It seems strange to me to draw shapes and draw paths with GDI, but not to create paths with GDI. * path.c in gdi32 is 2000 lines, and re-implementing it seems overkill I don't see any drawbacks of calling into GDI to make paths, other than a slight performance decrease introduced by an extra level of indirection. Can anyone suggest another reason why this approach is flawed? -- Evan Stade

2 2

Re: [SPAM] Problem with patch "dsound: Simplify mixing by removing remixing support, and fix its waveout breakage"
by Alex Villacís Lasso June 27, 2007

June 27, 2007

Chris Rankin escribió: > Hi, > > This patch has killed the sound on World of Warcraft. Instead, I now get silence and a stream of > errors like this: > > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > err:dsound:DSOUND_CalcPlayPosition Bad length in CalcPlayPosition! > > The following change makes the sound work again without error messages, but there is still a brief > burst of sound/noise before the music starts properly: > > $ cvswine diff dlls/dsound/buffer.c > Index: dlls/dsound/buffer.c > =================================================================== > RCS file: /home/wine/wine/dlls/dsound/buffer.c,v > retrieving revision 1.70 > diff -u -r1.70 buffer.c > --- dlls/dsound/buffer.c 22 Jun 2007 12:37:22 -0000 1.70 > +++ dlls/dsound/buffer.c 25 Jun 2007 19:08:34 -0000 > @@ -442,15 +442,15 @@ > pmix *= This->pwfx->nBlockAlign; > > TRACE("this back-offset=%d\n", pmix); > - > +#if 0 > /* sanity */ > if(pmix > This->buflen){ > ERR("Bad length in CalcPlayPosition!\n"); > return 0; > } > - > +#endif > /* subtract from our last mixed position */ > - if (bplay < pmix) bplay += This->buflen; /* wraparound */ > + while (bplay < pmix) bplay += This->buflen; /* wraparound */ > bplay -= pmix; > > /* check for lead-in */ > > > Cheers, > Chris > > > > > > > ___________________________________________________________ > New Yahoo! Mail is the ultimate force in competitive emailing. Find out more at the Yahoo! Mail Championships. Plus: play games and win prizes. > http://uk.rd.yahoo.com/evt=44106/*http://mail.yahoo.net/uk > > You might try the patch with the title "DSOUND: recover from mismatch between time spanned by primary buffer being longer than the one spanned by secondary buffer", which I sent along with some other patches today. It looks somewhat similar to the one you sent. Alex Villacís Lasso -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Writing tests in Wine.
by Anatoly Lyutin June 26, 2007

June 26, 2007

Hi all! When I analyzed Wine test codes today I do not understand how to interpret result of tests.That is why I refer to community. I can not find any full documentation for writing tests at WineHq. I have some points which I do not understand: 1. Why some tests are running in Win not fall if expected and obtained messages are not coincide. ex (user32:msg:test_mdi_messages:Win2k3): msg.c:2716:mdi frame: 00090362, 0086, 00000000, 00000000 msg.c:2716:mdi frame: 00090362, 0002, 00000000, 00000000 msg.c:2716:mdi frame: 00090362, 0082, 00000000, 00000000 msg.c:3302:expected 0004 - actual 0004 msg.c:3302:expected 0046 - actual 0046 msg.c:3302:expected 8003 - actual 0047 msg.c:3302:expected 0086 - actual 0047 msg.c:3302:expected 0047 - actual 0047 msg.c:3302:expected 0086 - actual 0086 msg.c:3302:expected 0006 - actual 0002 msg.c:3302:expected 001c - actual 0002 msg.c:3302:expected 8003 - actual 0002 msg.c:3302:expected 8001 - actual 0002 msg.c:3302:expected 0002 - actual 0002 msg.c:3302:expected 0082 - actual 0082 Why does not this fail?(ok_sequence(WmDestroyMDIframeSeq, "Destroy MDI frame window", FALSE);) 2. How I can write test for different OS Windows? Some tests run successfully in win2k3 but fail in XP, that is why this test can not be validated by HQ. 3.What does it mean :{ HCBT_SETFOCUS, hook }? What does this hook in some tests make fail in Win2k3 if it was included? Thank you for attention. -- Best regards Anatoly Lyutin.

2 1

Re: winefile: Use the msvcrt provided _tsplitpath instead of reimplementing it.
by Alexandre Julliard June 26, 2007

June 26, 2007

Michael Stefaniuc <mstefani(a)redhat.de> writes: > Actually i wanted to just remove the wide character constants out of > splitpath.c but then i have seen that the file can be removed completely. > I checked the history but didn't find a clue why a separate > implementation might have been usefull. splitpath.c appeared with the > initial import of the winefile source code. Winefile cannot import msvcrt because it has support for accessing Unix files too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: please help me with filling a bug concerning WM_ERASEBKGND
by Juan Lang June 26, 2007

June 26, 2007

Hi, if you've done a reasonable job searching for a dup and haven't found one, go ahead and file a new bug. Bugs can be closed or linked where appropriate. > is this http://bugs.winehq.org/show_bug.cgi?id=6006 ? > Il try to compile latest git with patches from that bug before filling > new one. I think these may very well be related, but (IMO) they should be different bugs. A bug should describe the problem, not the fix. If a patch for one fixes the other, great! --Juan ____________________________________________________________________________________ Got a little couch potato? Check out fun summer activities for kids. http://search.yahoo.com/search?fr=oni_on_mail&p=summer+activities+for+kids&…

1 0

Slackware 11: After Wine update applications crash if WINEDEBUG not set
by Victor June 26, 2007

June 26, 2007

Hello! I didn't get an answer for this in wine-user, so I've decided to ask this question here. After upgrading wine (from 0.9.37 to 0.9.38 or from 0.9.38 to 0.9.39 - I'm not sure) many graphical applications started crashing if WINEDEBUG+=all or WINEDEBUG+=relay not set. Among those applications are Postal 1, Kiosaky's Cashflow 101, .kkreiger and probably more. I'm not sure if this is a bug in Wine or a problem in my system, because uninstalling and downgrading (even to 0.9.34) didn't help - problem now exists in other versions as well. Applications crash in a "windows way" - with access violation at address 0x7XXXXXXX. Here is a beginning of output produced by trying to start .kkreiger (avaliable at http://www.theprodukkt.com/) --begin-- Unhandled page fault on read access to 0xffffffff at address 0x7d66c9ce (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0xffffffff in 32-bit code ?0x7d66c9ce). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:7d66c9ce ESP:0033e8a8 EBP:00009f80 EFLAGS:00210246( - 00 -RIZP1) EAX:0033e8c8 EBX:7d68a000 ECX:00000000 EDX:00000000 ESI:01000000 EDI:00001f80 Stack dump: 0x0033e8a8: 0033e8c8 00000000 00000000 b7fd6ff8 0x0033e8b8: 7d72aaa9 7d72aaa9 0033ec18 00001f80 0x0033e8c8: 00000000 00000000 00000000 00000000 0x0033e8d8: 00000000 00000000 00000000 00000000 0x0033e8e8: 00000000 00000000 00000000 00000000 0x0033e8f8: 00000000 00000000 00000000 00000000 Backtrace: =>1 0x7d66c9ce (0x00009f80) 2 0x00000000 (0x00000000) 0x7d66c9ce: --end-- But it works fine if started as WINEDEBUG=+relay wine wine pno001.exe &>/dev/null This application worked fine before and didn't need those flags. Kyosaky's Cashflow 101 crashes with a windows message box which says "Unhandled exceptionL c0000005 At address: 7ce2f9ce". but works fine if started with WINEDEBUG=+relay same thing with Postal 1. There are also problems with an Alien vs Predator 2 game and some other apps that enumerate D3D display modes: if program has a listbox where videomodes can be selected, this box will contain no strings (alien vs. predator, ragnarok online, some other apps), if WINEDEBUG+=all is not set. Can these problems be connected with those crashes? System configuration: Slackware 11 linux with 2.6.17.13 kernel on AMD Sempron 2800+ processor with GeForce 7100GS and 512Mb ram. Any pointers how can I figure out what's wrong? Thanks. With best regards, Victor Eremin.

2 3