June 2007 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] gdi32: Set current position properly after ArcTo.
by Alexandre Julliard June 20, 2007

June 20, 2007

Misha Koshelev <mk144210(a)bcm.edu> writes: > + if (!PATH_IsPathOpen(dc->path)) > { > - angle = atan2( > - ((yend-ycenter)/height), > - ((xend-xcenter)/width)); > - MoveToEx(hdc, GDI_ROUND(xcenter+(cos(angle)*xradius)), > - GDI_ROUND(ycenter+(sin(angle)*yradius)), NULL); > + if (result && dc->funcs->pMoveTo) result = dc->funcs->pMoveTo(dc->physDev,end.x,end.y); It would be cleaner to add a PATH_ArcTo function instead of having multiple PATH_IsPathOpen checks in the generic function. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: OpenFile16 and similar functions
by Dan Kegel June 20, 2007

June 20, 2007

On 6/20/07, Jakob Eriksson <jakob(a)vmlinux.org> wrote: > Are not the tests still EXE-s called by winetest? Then the current > winetest will work OK. Except that winetest.h might not compile in 16 bit mode, and our build system doesn't handle 16 bit binaries, and gcc/ld can't build 16 bit NE executables, and you can't mix 16 and 32 bit easily so we'd need a winetest16, yes. :-) > Though we would benefit from having a crosscompiler to 8086 Windows EXEs. Yeah, I haven't checked yet whether openwatcom's linux version can build 16 bit NE executables. Sure would be cool! - Dan

2 1

re: OpenFile16 and similar functions
by Dan Kegel June 20, 2007

June 20, 2007

Anatoly asked: > How can I write a test for this function or build program use it? I think writing good win16 tests requires a 16 bit linker. Fortunately, OpenWatcom has one, and works on Wine. It's amazingly easy to install it and build one of its demo apps: $ wget http://ftp.openwatcom.org/ftp/open-watcom-c-win32-1.6.exe $ wine open-watcom-c-win32-1.6.exe $ wineboot $ cd .wine/drive_c/WATCOM/samples/win/alarm/win16 $ wine wmake $ wine alarm This builds an honest-to-goodness win16 binary that works on XP (possibly with one warning dialog you have to ignore). Unfortuately, Wine doesn't currently run these win16 apps properly; they hang with err:ntdll:RtlpWaitForCriticalSection section 0x7b91f300 "syslevel.c: Win16Mutex" wait timed out in thread 000b, blocked by 000c, retrying (60 sec) This is embarassing. These are the "hello, world" of 16 bit windows apps, and current wine (well, wine-0.9.37-g3739b5f) can't run them... I haven't looked to see if older wine runs these 16 bit demo apps properly.

2 3

OpenFile16 and similar functions
by Anatoly Lyutin June 19, 2007

June 19, 2007

Hi all! How can I write a test for this function or build program use it? I do not understand how I can do this uses Wine? Thank you for attention! =) -- Best regards Anatoly Lyutin.

1 0

Re: [4/5] D3D8: Convert FVFs to vertex declarations
by H. Verbeet June 19, 2007

June 19, 2007

On 19/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + if (hr != S_OK) return NULL; Any reason for not simply using FAILED(hr) there? > + object->decls = HeapAlloc(GetProcessHeap(), 0, 0); Is that useful?

3 4

Compiling Wine on Fedora 7 64-bit (opengl fails)
by Paul Vriens June 19, 2007

June 19, 2007

Hi, I'm a total newbie to the 64-bit world (just built a system this weekend) and now I'm trying to get Wine compiled. It fails with (the first failure that is): LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -foversion.res version.rc ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./opengl32.spec opengl_ext.o opengl_norm.o wgl.o version.res -o opengl32.dll.so -luser32 -lgdi32 -ladvapi32 -lkernel32 -lntdll -L/usr/lib64 -lSM -lICE -lXxf86vm -lXext -lX11 -lGL ../../libs/port/libwine_port.a /usr/bin/ld: skipping incompatible /usr/lib64/libSM.so when searching for -lSM /usr/bin/ld: skipping incompatible /usr/lib64/libICE.so when searching for -lICE /usr/bin/ld: skipping incompatible /usr/lib64/libXxf86vm.so when searching for -lXxf86vm /usr/bin/ld: skipping incompatible /usr/lib64/libXext.so when searching for -lXext /usr/bin/ld: skipping incompatible /usr/lib64/libX11.so when searching for -lX11 /usr/bin/ld: skipping incompatible /usr/lib64/libGL.so when searching for -lGL /usr/bin/ld: skipping incompatible /usr/lib64/libm.so when searching for -lm /usr/bin/ld: skipping incompatible /usr/lib64/libm.a when searching for -lm /usr/bin/ld: skipping incompatible /usr/lib64/libc.so when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.a when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.so when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.a when searching for -lc wgl.o: In function `wglUseFontOutlines_common': wgl.c:(.text+0xec6): undefined reference to `gluNewTess' wgl.c:(.text+0xeec): undefined reference to `gluTessCallback' wgl.c:(.text+0xf09): undefined reference to `gluTessCallback' wgl.c:(.text+0xf26): undefined reference to `gluTessCallback' wgl.c:(.text+0x13b9): undefined reference to `gluTessBeginPolygon' wgl.c:(.text+0x1432): undefined reference to `gluTessBeginContour' wgl.c:(.text+0x146e): undefined reference to `gluTessVertex' wgl.c:(.text+0x1563): undefined reference to `gluTessVertex' wgl.c:(.text+0x167f): undefined reference to `gluTessVertex' wgl.c:(.text+0x16ca): undefined reference to `gluTessVertex' wgl.c:(.text+0x174b): undefined reference to `gluTessEndContour' wgl.c:(.text+0x178b): undefined reference to `gluTessEndContour' wgl.c:(.text+0x17b9): undefined reference to `gluTessEndPolygon' wgl.c:(.text+0x18a0): undefined reference to `gluDeleteTess' collect2: ld returned 1 exit status winegcc: gcc failed. make: *** [opengl32.dll.so] Error 2 Any suggestions where to start looking or how to approach this. I had a look at the Wiki to no avail. I've tested with and without the NVIDIA drivers. I also have another F7 box, 32-bit, that works fine. Cheers, Paul.

3 3

Re: [2/5] WineD3D: Remove the FVF codepath from drawprim
by H. Verbeet June 19, 2007

June 19, 2007

Not specific to this patch, but will you remove the fvf field from the stateblock as well?

2 3

Re: QUARTZ: Patch 1 - Fix video rendering sizing/positioning bugs
by Alexandre Julliard June 19, 2007

June 19, 2007

a_villacis(a)palosanto.com writes: > + case WM_SIZE: > + TRACE("WM_SIZE %d %d\n", LOWORD(lParam), HIWORD(lParam)); > + SetWindowPos(hwnd, NULL, pVideoRenderer->WindowPos.left, pVideoRenderer->WindowPos.top, LOWORD(lParam), HIWORD(lParam), SWP_NOZORDER); Why do you want to resize a window that has just been resized? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [AppDB] Increase menu text size
by Alex Waite June 19, 2007

June 19, 2007

Alexander Nicolaysen Sørnes wrote: > This should make it easier for people to notice the menu options. From 10px > to 11px. > > > Regards, > > Alexander N. Sørnes > > > ------------------------------------------------------------------------ > > I agree with increasing text size here, but we should keep in mind a few things. Setting text size in pixels is no longer the cool thing to do. W3C feels that it is best to use the "x-small, small, medium, etc" values since they respect user settings and accessibility the most. An alternative which gives more control but isn't quite as proper is to use em instead of px. Either is better than using pixels. Also, this text size should be changed on all pages because the menu text size in the AppDB is now larger than the text in the menu on the front page. I am part of a large project at my work where I have had to learn quite a bit about web accessibility and best practices. Contrary to popular (and lazy) belief, most of it actually makes it easier in the end to write and maintain a large website. Plus the site is accessible to more users. ---Alex

2 1

Re: [4/5] WineD3D: Emulate tracking of multiple material properties
by H. Verbeet June 19, 2007

June 19, 2007

On 19/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + if(!This->stateBlock->vertexShader) { > Testing for a vertex shader like that doesn't take into account the selected vs mode (ie, could be disabled) or transformed vertices. You should probably be using use_vs() instead.

1 0

Re: [3/5] WineD3D: Do not attempt to load texture coords for unsupported stages
by H. Verbeet June 19, 2007

June 19, 2007

I remember discussing this patch, but in retrospect I'm not sure this fix is completely correct. When a pixel shader is used with fixed function vertex processing, more than GL_LIMITS(textures) texture coordinates can be used.

1 0

Re: winex11 - Fix X11DRV_DIB_GetImageBits() when target bitmaps are larger than fetched area
by Alexandre Julliard June 19, 2007

June 19, 2007

Peter Dons Tychsen <donpedro(a)tdcadsl.dk> writes: > #ifdef HAVE_LIBXXSHM > - if (descr->image && descr->useShm) > + > + if(descr->image && descr->useShm) > + { > + XGetGeometry(gdi_display, descr->drawable, &root, &x, &y, &width, > &height, &border_width, &depth); > + TRACE("XGetGeometry(), width=%i, heigth=%i\n", width, height); > + } > + > + /* We must not call XShmGetImage() with a bitmap which is bigger > than the avilable area. > + If we do, XShmGetImage() will fail (X exception), as it checks > for this internally. */ > + if((descr->image && descr->useShm) && (bmpImage->width <= (width - > descr->xSrc)) > + && (bmpImage->height <= (height - descr->ySrc))) > { > int saveRed, saveGreen, saveBlue; The patch is wrapped, and you don't want to use XGetGeometry, this incurs a server round-trip. -- Alexandre Julliard julliard(a)winehq.org

1 0

Adds NET STOP to net.exe
by Kirill K. Smirnov June 19, 2007

June 19, 2007

Hi, Tim. Please, proceed bug #8554. Thanks, -- Kirill

1 0

Re: winex11.drv: send WM_MOUSEACTIVATE before closing a window (try 3)
by Dmitry Timoshkov June 19, 2007

June 19, 2007

"Lei Zhang" <thestig(a)google.com> wrote: > On Windows, clicking the close button of a nonactive window generates > a WM_MOUSEACTIVATE notification. Applications with custom window > procedures can then choose to ignore the close button if they wished > to by returning MA_ACTIVATEANDEAT / MA_NOACTIVATEANDEAT. I'm not sure what you mean by "applications with custom window procedures" because all (even simple ones) window procs in applications are custom, and they are free to handle/ignore any message they like, for instance WM_CLOSE or WM_SYSCOMMAND/SC_CLOSE. We already send WM_MOUSEACTIVATE message on a take focus X11 event, so I don't see a point in duplicating it. On the other hand if a WM doesn't activate a window when a user clicks on window's caption (where the close button usually placed) then it's a WM bug and we can do nothing to fix it. -- Dmitry.

2 4

Remove font set when calling XCreateIC?
by Nigel Liang June 19, 2007

June 19, 2007

Hi, This patch removes a call to XCreateFontSet which was causing wine to be very slow in some Chinese locale settings. The server side font calls are supposed to be deprecated anyway as Dan pointed out in his comment here: http://bugs.winehq.org/show_bug.cgi?id=5309 According to the Xlib programming manual, if a font set is not specified when calling XCreateIC, the default is determined by the input method. But it seems that this used to be a required field, so I am not sure if this will break any old input methods out there. Any ideas on how I could better test this before submitting? Thanks! -Nigel

1 0

Re: msi: Fix the conditions to determine which files to remove
by James Hawkins June 18, 2007

June 18, 2007

On 6/18/07, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > This fixes an error with a test Windows Installer Patch that I'm > trying to get working. > > Changelog: > * Fix the conditions to determine which files to remove. > Ignore this for right now. There's something else that needs to be fixed first. -- James Hawkins

1 0

Re: ntoskrnl.exe: Add a stub implementation of KeInitializeTimer
by James Hawkins June 18, 2007

June 18, 2007

On 6/18/07, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > The Fahrenheit installer calls this function. KTIMER is defined in > ketypes.h in the ddk, but that file doesn't exist for us yet, and I > followed the example of others and defined it in wdm.h (where most of > the types in ketypes.h were defined instead). > Nevermind my comments about the headers. osronline says it's defined in wdm.h, so this patch is still good to go. -- James Hawkins

1 0

Sorry, Opera is not yet supported by Xinha.
by RusH June 18, 2007

June 18, 2007

Bugzilla uses this new toy, but the script loads it even after it detects Opera = it eats the text in edit fields sometimes and I cant process Test Results. Could it load itselfe only when not detecting Opera? -- Who logs in to gdm? Not I, said the duck.

1 0

Winelib should have dir.h and some consts
by Jérôme Gardou June 18, 2007

June 18, 2007

I try to compile a small program which use msvcrt headers, and it appeared that, in winelib there is no dir.h (which may be redirected to dirent.h ?) and that consts like MAXPATH, MAXDRIVE and others are not defined. Should it be done ? Is it planned to be ? ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

2 1

Re: [Wine] Sending changes to winelib ?
by Scott Ritchie June 18, 2007

June 18, 2007

The wine-devel mailing list is best for this type of development question. Thanks, Scott Ritchie On Sun, 2007-06-17 at 12:49 +0200, Jérôme Gardou wrote: > I have a little program coded for windows, and I want to compile it using > winegcc. > > Unfortunately, some functions are not implemented in winelib, and I have to > tweak some files. So, How do I submit those changes ? I found nothing on the > WineHQ site. > > SO, if someone knows where to redirect me, I can do it alone! > > > > > > ___________________________________________________________________________ > Yahoo! Mail rinvente le mail ! Dcouvrez le nouveau Yahoo! Mail et son interface rvolutionnaire. > http://fr.mail.yahoo.com > > > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users

1 0

Re: cmd.exe: Fix FOR so it works as 'well' as before.
by Detlef Riekenberg June 18, 2007

June 18, 2007

Hi Jason. The Patch is already in the tree, but I have a question: + * + * Execute a command, and any && or bracketed follow on to the command. The + * first command to be executed may not be at the front of the + * commands->thiscommand string (eg. it may point after a DO or ELSE + * Returns TRUE if something like exit or goto has aborted all processing + */ +void WCMD_part_execute(CMD_LIST **cmdList, WCHAR *firstcmd, WCHAR *variable, + WCHAR *value, BOOL isIF, BOOL conditionTRUE) { + The comment missed a closing bracked somewhere. How does the "Returns TRUE" match the declaration ("void")? Thanks -- By by ... Detlef

1 0

Building Wine with the lsb sdk, take 2
by Dan Kegel June 18, 2007

June 18, 2007

At the Linux Summit, a bunch of us decided it'd be a good idea to try out lsbcc on more real-world packages, so I tried wine again tonight. My previous try was described here: http://www.winehq.org/pipermail/wine-devel/2006-August/050554.html This time I used Feisty Fawn's lsb build env packages: sudo apt-get install lsb-build-cc3 This installed lsbcc (well, lsbcc3, anyway; looks like that's a debianism that isn't mentioned in the official lsb doc). And instead of making configure aware of lsbcc3, I created the file ~/bin/gcc containing #!/bin/sh exec lsbcc3 "$@" (Yes, the first line is needed, make fails without it.) and did chmod +x ~/bin/gcc and added ~/bin early in my PATH. Then I did configure etc. Finally, I still had to use a few of the same magic incantations explained in my last message on the subject when building: LSBCC_SHAREDLIBS=wine export LSBCC_SHAREDLIBS make LDFLAGS=-ldl CFLAGS="-g -O2 \"-DRTLD_DEFAULT=((void *)0)\" -DMAP_FILE=0" The first real problem I ran into was that freetype wasn't found. This turned out to be http://bugs.linuxbase.org/show_bug.cgi?id=1577 and I just ignored it for now. The second real problem I ran into was /home/dank/wine-git/server/ptrace.c:103: undefined reference to `ptrace' Last mention I've seen of ptrace in lsb was http://lists.debian.org/lsb-spec/2001/02/msg00038.html and I guess it never made it in. I've filed this as http://bugs.linuxbase.org/show_bug.cgi?id=1664 - Dan

3 2

Re: hnetcfg: Resend Stub implementation of the dll
by Alexandre Julliard June 18, 2007

June 18, 2007

Jeff Latimer <lats(a)yless4u.com.au> writes: > --- /dev/null > +++ b/dlls/hnetcfg/Makefile.in > @@ -0,0 +1,14 @@ > +TOPSRCDIR = ../.. > +TOPOBJDIR = ../.. > +SRCDIR = . > + > +MODULE = hnetcfg.dll > +IMPORTS = kernel32 > +IMPORTLIB = libhnetcfg.$(IMPLIBEXT) > + > +C_SRCS = \ > + hnetcfg.c > + > +(a)MAKE_DLL_RULES@ > + > +(a)DEPENDENCIES@ # everything below this line is overwritten by make depend That's not a valid Makefile.in. -- Alexandre Julliard julliard(a)winehq.org

1 0

debugging help
by Damjan Jovanovic June 18, 2007

June 18, 2007

Hi I've been looking at bug 4437, where a game demo works perfectly with the native MSVCRT.DLL but dies on startup with the builtin due to a division by zero. The builtin doesn't have any fixmes, warnings or errors. Comparing builtin +relay and native +snoop traces shows the divide by zero doesn't happen with the native, everything else looks the same. A +msvcrt log is 200000 lines long but there is nothing obviously wrong either, a +all,+relay log shows nothing useful before the crash - the last function called before the crash is a simple printf without any %'s, which produces the same results on native and builtin. Disassembling around the crash shows a long chain of calculations that dies on the fated idivl. So it looks like a nasty delayed-effect bug. I'd welcome any new ideas, and I also have a few questions. Does +relay catch all function calls? Because some functions like sscanf only appear in +snoop, not in +relay. And is there a way for a builtin DLL to LoadLibrary() the native DLL of the same name and call functions in it? It would be very useful in narrowing down the bug. Thank you Damjan

2 1

Re: QUARTZ: Patch 1 - Fix video rendering sizing/positioning bugs
by Stefan Dösinger June 18, 2007

June 18, 2007

> --- wine-0.9.39-cvs/dlls/quartz/videorenderer.c 2007-05-17 10:25:02.000000000 -0500 > +++ wine-0.9.39-cvs-patch/dlls/quartz/videorenderer.c 2007-06-17 00:47:15.000000000 -0500 You should really use git. It may be some effort to learn, but it makes your life, and Alexandre's much easier in the long run.

1 0