June 2007 - Wine-Devel - list.winehq.org

Re: cmd:Ru:Update Russian translation.[try2][fixed]
by Kirill K. Smirnov June 7, 2007

June 7, 2007

> I think original phrase "Файл, ассоциированный с > расширением %s,отсутствует\n" is better (but there is a typo in it - > missing space after second ","). And word "ассоциированный" do sounds like > Russian (and has frequent use in books and speech), and I like it more than > less familiar (to me) word "сопоставление". So I think word "сопоставление" > maybe only good choice if Wine already using it instead of word > "ассоциированный" (I'm not sure about this because I'm using English > interface with Wine). (Just a note: Russian is my native language). > Anyway, in my opinion such discussion "what synonym is better" is > pointless because it is just a matter of personal taste. I do not mean "ассоциированный" и "сопоставление" synonyms. Prase "Файл, ассоциированный с расширением %s, отсутствует" is invalid. File never is associated with extension. Program is associated. And not "File" is absent, but "File association" - "Сопоставление файлов" ("сопоставление расширений файлов соответствующим программам"). I do not have anything against synonym "ассоциированный". -- Kirill

2 1

Adding support for both wine_gecko and Mozilla ActiveX.
by Andrew Riedi June 7, 2007

June 7, 2007

A lot of users would enjoy an option between installing wine_gecko and Mozilla ActiveX. Would it be very difficult to add a little dialogue box or registry key to toggle between the two? Is there a better way? If it is too difficult or will slow down work on eg. MSHTML and the like, don't worry about it. Anyhow, regardless of response, thanks for your work. :) -- Andrew Riedi

1 0

Re: wined3d [2/5]: Extend the D3DFMT table to include gamma corrected formats
by Stefan Dösinger June 6, 2007

June 6, 2007

Am Donnerstag, 7. Juni 2007 01:05 schrieb Phil Costin: > Extend the D3DFMT table to include gamma corrected formats. This patch(and 3 and 4) look good to me on a quick check.

1 0

Re: wined3d [1/5]: Add GL_EXT_texture_sRGB constants and corresponding CheckDeviceFormat query
by Stefan Dösinger June 6, 2007

June 6, 2007

Am Donnerstag, 7. Juni 2007 01:03 schrieb Phil Costin: > Adds necessary GL constants and allows the application to query whether a > particular texture format is compatible with sample-time texture > linearization. Ideally you shouldn't enable the srgb formats in this patch already, but rather in 4/5, but since the current code returns WINED3D_OK this is an unimportant detail.

1 0

Re: d3d9/tests [5/5]: Test CheckDeviceFormat returns correctly for D3DUSAGE_QUERY_SRGBREAD queries
by Stefan Dösinger June 6, 2007

June 6, 2007

Am Donnerstag, 7. Juni 2007 01:16 schrieb Phil Costin: > Test CheckDeviceFormat returns correctly for D3DUSAGE_QUERY_SRGBREAD > queries. This test will fail on any card that doesn't support sRGB at all. What would be more useful is to find out what assertion hl2 makes, ie if D3DFMT_X8R8G8B8 is supported, then D3DFMT_L8 and D3DFMT_A8L8 are supported too. No idea how this really looks like. Another idea would be to set up a table of formats that are found supported on some cards, and complain if a format that is known NOT to be supported(like Q8W8V8U8) is found supported - see the query test for an example.

1 0

wined3d: Void functions should not return a value
by Andrew Talbot June 6, 2007

June 6, 2007

Please note: I set the indentation of some amended lines to match that in the majority of the surrounding functions. -- Andy.

1 0

Re: cmd:builtints.c Fix convert from lower case to upper case
by Juan Lang June 6, 2007

June 6, 2007

This appears to be missing the patch. --Juan ____________________________________________________________________________________ Need a vacation? Get great deals to amazing places on Yahoo! Travel. http://travel.yahoo.com/

1 0

Re: [patch 2] mshtml: Added support for coexisting different Gecko versions installation.
by Alexandre Julliard June 6, 2007

June 6, 2007

Jacek Caban <jacek(a)codeweavers.com> writes: > - /* @@ Wine registry key: HKCU\Software\Wine\MSHTML */ > - res = RegOpenKeyW(HKEY_CURRENT_USER, wszMshtmlKey, &hkey); > + memcpy(mshtml_key, wszMshtmlKey, sizeof(wszMshtmlKey)); > + MultiByteToWideChar(CP_ACP, 0, GECKO_VERSION, -1, > + mshtml_key+sizeof(wszMshtmlKey)/sizeof(WCHAR), -1); Please pass the correct dest buffer size, not -1. > + GetEnvironmentVariableA("windir", install_dir, sizeof(install_dir)); GetWindowsDirectory is preferable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING
by James Hawkins June 5, 2007

June 5, 2007

On 6/5/07, Jens Nestler <jn(a)nessi-online.de> wrote: > http://bugs.winehq.org/show_bug.cgi?id=8551 > > Hello, > > please find attached the patch for the bug mentioned above. > > Jens Nestler > The bug also has a test case that needs to be integrated into the Wine test suite and submitted to wine-patches. -- James Hawkins

1 0

Re: OpenGL 2.3 to 3.0
by Matthew Clark June 5, 2007

June 5, 2007

Ah this makes perfect sense and is exactly what I was looking for, thank you for your response! My limited understanding from the article was that 2.3 was simply cleanup and putting some extensions in the official API that have been in drivers for a while just not in the official API and then 3.0 is where the real change will be, BUT that it will only activate the 3.0 functionality if it's on supporting hardware(i.e. DX10 cards). Please correct me if my understanding is incorrect and again I think we all realize this is all in the future and is just fun to talk about^_^ Thanks for all THE fish, -Matt PS Yes I am an idiot some times =P > > Stefan Dösinger wrote: >> We are waiting for the final API before deciding if we like it or not. But >> from what I've read so far the changes make sense. >> >> My concern is backwards compatiblity. For dx 1 to dx9 we will still need the >> old apis. For one part because the new api may not offer fixed function >> functionality, but more importantly because old cards will most likely not >> see any driver updates. >> >> If the interface is vastly different we'll need 2 d3d implementations, one >> wrapping to old gl and one for the new version. An idea would be to just >> leave dx1 to 9 with gl 2.0 and write dx10 only for opengl 3.0. >> >> If the new API allows it however, we want to keep the wine code unified. This >> could happen by simply duplicating very specific functions which are >> different, and then select them at creation time by choosing a different >> virtual function table. If we need an if condition for every opengl call we >> do it would be pointless to keep everything in one lib. >> >> But we need to know the final opengl 3.0 API to decide what to do. >> > >

2 1

OpenGL 2.3 to 3.0
by Matthew Clark June 5, 2007

June 5, 2007

I was reading the other day about the 2.3 and 3.0 versions of the OpenGL API coming out this year( http://www.theinquirer.net/default.aspx?article=39846 ) and the first thought I had was wine and DX10. I was wondering what you guys thought about this, are you excited(as I am)? are you hesitant? Knowing OpenGL it shouldn't be hard at all to port the code over, but are there plans already or are the plans to wait till it's in our faces to worry about it? Sorry for the tangent but I was just curious to hear what you guys had to say about this.^_^ Thanks for all fish, -Matt

2 1

Re: OpenGL 2.3 to 3.0
by Stefan Dösinger June 5, 2007

June 5, 2007

Am Dienstag, 5. Juni 2007 22:17 schrieb Matthew Clark: > Ah this makes perfect sense and is exactly what I was looking for, thank > you for your response! My limited understanding from the article was > that 2.3 was simply cleanup and putting some extensions in the official > API that have been in drivers for a while just not in the official API > and then 3.0 is where the real change will be, BUT that it will only > activate the 3.0 functionality if it's on supporting hardware(i.e. DX10 > cards). Please correct me if my understanding is incorrect and again I > think we all realize this is all in the future and is just fun to talk > about^_^ They're takling more about codenames rather than 2.3 and 3.0, but I don't know the names currently. 2.3 will have all the functionality of 3.0 and be fully backwards compatible. This means you can use very old things together with the very new stuff. The drawback will be that you don't get the performance improvements of 3.0. This is somehow like d3d9. with d3d9.dll you can use the new d3d9 features, those will work on d3d9 cards only. But you can also use d3d9.dll to write an app that uses only dx7(or even earlier) level features, and those apps will run on dx7 cards - an example for that is the Source engine in hl2. 3.0 will be the complete rewrite. You'll have 3.0 only on cards that support it, and afaik you can't use the 3.0 API to program older cards(like a geforce 2 that doesn't even support shaders). This is what happened in d3d10 too. The advantage of the api cleanup is that you get rid of all the legacy stuff. The API is cleaner, drivers are simpler. The code is smaller and runs faster. If you look at wined3d you'll see that it is full of stuff to support even oldest cards(theoretically, in theory unsuccessful). Even though the state management keeps the most of the code sleeping until the app actually uses this features it makes everything more complex. A performance penalty is maybe the GL_EXTCALL stuff, which we use to be able to link against old opengl libs. Calling an address inserted by the dynamic linker at load time would be cheaper than finding a function pointer in a table and calling it.

2 1

Re: widl: Fix the is_array_type function.
by Dan Hipschman June 5, 2007

June 5, 2007

On Tue, Jun 05, 2007 at 07:50:42PM +0100, Robert Shearman wrote: > > Previously, an array of pointers wouldn't be detected by this function. > --- > tools/widl/header.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/tools/widl/header.h b/tools/widl/header.h > index 57ae6b4..2165db7 100644 > --- a/tools/widl/header.h > +++ b/tools/widl/header.h > @@ -69,7 +69,7 @@ static inline int is_string_type(const a > static inline int is_array_type(const attr_list_t *attrs, const type_t *type, const array_dims_t *array) > { > return ((last_ptr(type) && !array && is_attr(attrs, ATTR_SIZEIS)) || > - (!is_ptr(type) && array)); > + array); > } > > #endif This and your next patch are in the same area as the one I just sent in yesterday. Actually, my patch completely removes this function. Can you try doing whatever you're working on with my last patch applied and see if that fixes your problems? Generating the format string for arrays of pointers is going to required a little more work because FIXED_REPEAT, etc. isn't implemented yet. My last patch set: http://winehq.org/pipermail/wine-patches/2007-June/040007.html http://winehq.org/pipermail/wine-patches/2007-June/040008.html Thanks, Dan

2 2

Re: ADVAPI32: Start test for service tests
by James Hawkins June 5, 2007

June 5, 2007

On 5/20/07, Rolf Kalbermatter <r.kalbermatter(a)hccnet.nl> wrote: > Changelog > dlls/advapi32/tests/Makefile.in > dlls/advapi32/tests/service.c > Start test for service tests > License: X11/LGPL > > This test will crash without the previous patch > "Return error on NULL service name to GetServiceDisplayNameA/W" > > Rolf Kalbermatter > + ok(size <= 1, "size should be <= 1 was %d!", size); This is a bad test. According to msdn, GetServiceDisplayName does not modify lpcchBuffer on error, so size should be exactly 0. +static BOOL test_service_info(SC_HANDLE hscm) test functions are void, not BOOL. You're never going to do anything but return, and there's no value to check by the caller. + ok(size, "size should be returned!"); And what is the size? Tests are supposed to be exact. If our implementation is incorrect, and we return size as 39491, that's certainly not correct, but this test won't fail when it should. +static BOOL test_service_enum(SC_HANDLE hscm) +{ + return 0; +} Please don't add dead code. -- James Hawkins

3 4

Re: wintrust: implement WintrustGetRegPolicyFlags and WintrustSetRegPolicyFlags
by Saulius Krasuckas June 5, 2007

June 5, 2007

* On Mon, 14 May 2007, Juan Lang wrote: > > +static const WCHAR Software_Publishing[] = { > + 'S','o','f','t','w','a','r','e','\\', > + 'M','i','c','r','o','s','o','f','t','\\', > + 'W','i','n','d','o','w','s','\\', > + 'C','u','r','r','e','n','t','V','e','r','s','i','o','n','\\', > + 'W','i','n','t','r','u','s','t','\\', > + 'T','r','u','s','t',' ','P','r','o','v','i','d','e','r','s','\\', > + 'S','o','f','t','w','a','r','e',' ', > + 'P','u','b','l','i','s','h','i','n','g',0 }; > +static const WCHAR State[] = { 'S','t','a','t','e',0 }; > + > /*********************************************************************** > * WintrustGetRegPolicyFlags (WINTRUST.@) > */ > void WINAPI WintrustGetRegPolicyFlags( DWORD* pdwPolicyFlags ) > { > - FIXME("%p\n", pdwPolicyFlags); > + HKEY key; > + LONG r; > + > + TRACE("%p\n", pdwPolicyFlags); > + > *pdwPolicyFlags = 0; > + r = RegCreateKeyExW(HKEY_CURRENT_USER, Software_Publishing, 0, NULL, 0, > + KEY_READ, NULL, &key, NULL); > + if (!r) > + { > + DWORD size = sizeof(DWORD); > + > + r = RegQueryValueExW(key, State, NULL, NULL, (LPBYTE)pdwPolicyFlags, > + &size); > + RegCloseKey(key); This function tries to open Software_Publishing key. And creates it, if the key didn't exist, I suppose. It is absent in a clean $WINEPREFIX. Hence 4 test failures: $ wine dlls/wintrust/tests/wintrust_test.exe.so register register.c:327: Test failed: RegOpenKeyEx failed: 2 register.c:331: Test failed: RegQueryValueEx failed: 6 register.c:334: Test failed: Didn't get expected flags register.c:341: Test failed: Didn't get expected flags register: 43 tests executed (0 marked as todo, 4 failures), 0 skipped. During next run failures are gone, and I get this difference between two registry dumps: +[HKEY_USERS\S-1-5-4\Software\Microsoft\Windows\CurrentVersion\Wintrust] + +[HKEY_USERS\S-1-5-4\Software\Microsoft\Windows\CurrentVersion\Wintrust\Trust Providers] + +[HKEY_USERS\S-1-5-4\Software\Microsoft\Windows\CurrentVersion\Wintrust\Trust Providers\Software Publishing] +"State"=dword:00023c00 So this key should be registered during wineprefix run at some point, right?

2 3

re: Question about tracing a direct pointer call (CryptSIPLoad related)
by Dan Kegel June 5, 2007

June 5, 2007

Hook the function that returns those pointers, and have your hooked function return hooked function pointers. It's not easy, but I think it would work.

1 0

Question about tracing a direct pointer call (CryptSIPLoad related)
by Paul Vriens June 5, 2007

June 5, 2007

Hi, I'm currently (still) busy with trying to find out how certain crypt32/wintrust functions behave. One of the functions CryptSIPLoad returns a set of function pointers that maybe are called directly by an application/dll. These direct calls however don't show up in a 'normal' trace. Is there a way to see this direct pointer call with a trace or do I need to start using the debugger? The problem with tracing/debugging this is that there's a lot of calls from wintrust to crypt32 and back again. This means it's hard to put in any traces as a lot of stuff is still stubbed. It would be nice btw (and I don't know if there's more demand for this) to have a function override instead of the whole dll. I know that could be tricky but in some circumstances would help a lot in tracing/debugging. Cheers, Paul.

1 0

Re: Support for iFilter API
by Juan Lang June 4, 2007

June 4, 2007

Hi Stefan, I finally had a look at this. It looks like filter.h (where the iFilter API is defined) is generated from some IDL source. So you'd want to create your own definition of the .idl file, and generate filter.h using widl. That said, the iFilter interface is only used (in Windows) by the indexing service, which wine currently doesn't implement. So I'm not sure* it really belongs in the wine source. *Caveat: this assumes that wine is mostly about running Windows programs these days, and less about building Windows programs. --Juan ____________________________________________________________________________________ Need Mail bonding? Go to the Yahoo! Mail Q&A for great tips from Yahoo! Answers users. http://answers.yahoo.com/dir/?link=list&sid=396546091

1 0

mandriva rpm wine 0.9.38
by marco June 4, 2007

June 4, 2007

As I have still no way to upload the mandriva wine rpm to the official winehq download server. So mandriva users you can download the latest wine binaries here: http://www.xs4all.nl/~meijer2/wine/ kind regard, Marco

2 1

3DMark2001 crashes with wine-0.9.38
by Juergen Wiezorek June 4, 2007

June 4, 2007

I have just compiled & installed the new wine version on my Fedora Core 5 system (kernel-2.6.20-1.2316-1.fc5) and found that the 3DMark2001 test suite now crashes upon startup, see below enclosure. This has so far never happened with any wine-0.9.x version I've had installed. -- Juergen Wieczorek Hamburg / Germany

2 1

Re: winebrowser: Add DDE support and use DDE by default for shell/open.
by Dmitry Timoshkov June 4, 2007

June 4, 2007

"Misha Koshelev" <mk144210(a)bcm.edu> wrote: > --- a/tools/wine.inf > +++ b/tools/wine.inf > @@ -134,8 +134,14 @@ HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1" > HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1" > HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1" > HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1" > -HKCR,http\shell\open\command,,2,"winebrowser" > -HKCR,https\shell\open\command,,2,"winebrowser" > +HKCR,http\shell\open\command,,2,"winebrowser /dde" > +HKCR,http\shell\open\ddeexec,,2,"""%1""" > +HKCR,http\shell\open\ddeexec\Application,,2,"WineBrowser" > +HKCR,http\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" > +HKCR,https\shell\open\command,,2,"winebrowser /dde" > +HKCR,https\shell\open\ddeexec,,2,"""%1""" > +HKCR,https\shell\open\ddeexec\Application,,2,"WineBrowser" > +HKCR,https\shell\open\ddeexec\Topic,,2,"WWW_OpenURL" Why are you making DDE the default way for the ShellExecute command? That's not the case in the default Windows install. Also please make sure that the items of the Help menu in Picasa still work after your changes, as it was broken several times after attempts to change default registry setup or ShellExecute behaviour. -- Dmitry.

2 4

git is to overwhelming
by RusH June 4, 2007

June 4, 2007

Maybe im just to stupid for it :( I want to use git to download most current source, try my patches, then to again download most current source. I cant do it. wiki.winehq.org/GitWine doesnt help at all. For example I had wine-0.9.37 fetched, added few patches, compiled it, installed locally, all was fun and games, Now I want to bring my local tree to current level, but cant. I did : rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git fetch remote: Generating pack... [.....cut.....] 100% (1/1) done * refs/tags/wine-0.9.38: storing tag 'wine-0.9.38' of git://source.winehq.org/git/wine tag: d3ce69c rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ dlls/winecoreaudio.drv/mixer.c: needs update dlls/ws2_32/tests/sock.c: needs update rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git fetch rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git rebase origin dlls/winecoreaudio.drv/mixer.c: needs update dlls/ws2_32/tests/sock.c: needs update rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ dlls/winecoreaudio.drv/mixer.c: needs update dlls/ws2_32/tests/sock.c: needs update rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git checkout -f rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ dlls/winecoreaudio.drv/mixer.c: needs update rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git reset --hard origin rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ ANNOUNCE: needs update ChangeLog: needs update VERSION: needs update configure: needs update rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git fetch rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git checkout -f rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git diff rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git reset HEAD^ dlls/user32/tests/menu.c: needs update rasz(a)capek:/media/hdc6/home/rasz/source/wine$ git fetch ; git rebase origin dlls/user32/tests/menu.c: needs update and so on and so forth .... my head hurts and i dont understand, why cant it be done with one command? -- Who logs in to gdm? Not I, said the duck.

5 7

Re: Wine fails to start browser
by Misha Koshelev June 3, 2007

June 3, 2007

> Koshelev, Misha Vladislavo <mk144210 <at> bcm.tmc.edu> writes: > > > If I have time, I may look into how hard it would be to add DDE for > winebrowser (I don't think it should be too bad, but I'll have to check). > > Misha > > > > > Cool! looking forward to that than ;) > > > Actually, I already got something that works, just need to clean it up, add fixes to automatically generate the necessary registry subkeys, and I'll send it in at some point. I had to change winebrowser to not be a console app (although it still writes to stderr so for all intents it kinda is) for the DDE stuff to work properly from ShellExecuteW, but it still seems to work fine on the command line both when passing arguments and when using DDE with wine start (except now if you just call winebrowser you have to wait 5 secs for it to print out a usage as it tries to wait for a DDE, but I don't think there is any way to avoid a delay in seeing the usage statement and both do DDE... unless we add some kind of extra command line parameter for the DDE stuff I guess which I will look into). Misha

1 0

Re: Wine fails to start browser
by Koshelev, Misha Vladislavo June 3, 2007

June 3, 2007

> Hi, i noticed some kind of regression in current git, for example when i try to start > http://fe.trymedia.com/dm/infogrames/30m_default/t_20em/FreddiKelp.exe , a download manager for the game. With current git i get this: > > Usage: winebrowser URL > > > > That's it, whereas in wine-0.9.34, it opens my firefox fine, at the correct page , and starts to download the game. > > The only solution i found now is again add "%1" to the key HKEY_CLASSES_ROOT\http\shell\open\command\winebrowser, but that "fix' was not acceptable in wine, me was told a few weeks ago. I saw some patches from Misha Koshelev that might be related to this, maybe changing the key is acceptable now, or anyone know another fix? Thx > Never mind, I found more info here: http://bugs.winehq.org/show_bug.cgi?id=7953 I checked on an XP installation with IE and the key there does _not_ have %1 but it has ddeexec subkeys which means it is using DDE to communicate. If I have time, I may look into how hard it would be to add DDE for winebrowser (I don't think it should be too bad, but I'll have to check). Misha

2 1

Re: Wine fails to start browser
by Misha Koshelev June 3, 2007

June 3, 2007

> Hi, i noticed some kind of regression in current git, for example when i try to start > http://fe.trymedia.com/dm/infogrames/30m_default/t_20em/FreddiKelp.exe , a download manager for the game. With current git i get this: > > Usage: winebrowser URL > > > > That's it, whereas in wine-0.9.34, it opens my firefox fine, at the correct page , and starts to download the game. > > The only solution i found now is again add "%1" to the key HKEY_CLASSES_ROOT\http\shell\open\command\winebrowser, but that "fix' was not acceptable in wine, me was told a few weeks ago. I saw some patches from Misha Koshelev that might be related to this, maybe changing the key is acceptable now, or anyone know another fix? Thx > Well, according to my conformance tests, Windows does not add "%1" by default (see dlls/shell32/tests/shlexec.c, line 1057), so I think this would need to be there in the registry if you want it to start the command line key. Do you remember exactly why people were saying this is bad? Perhaps this had to do with the specific way you were proposing to add this? Thanks Misha

1 0