June 2007 - Wine-Devel - list.winehq.org

Re: [PATCH 1/3] gdi32: Set current position properly after ArcTo.
by Alexandre Julliard June 20, 2007

June 20, 2007

Misha Koshelev <mk144210(a)bcm.edu> writes: > + if (!PATH_IsPathOpen(dc->path)) > { > - angle = atan2( > - ((yend-ycenter)/height), > - ((xend-xcenter)/width)); > - MoveToEx(hdc, GDI_ROUND(xcenter+(cos(angle)*xradius)), > - GDI_ROUND(ycenter+(sin(angle)*yradius)), NULL); > + if (result && dc->funcs->pMoveTo) result = dc->funcs->pMoveTo(dc->physDev,end.x,end.y); It would be cleaner to add a PATH_ArcTo function instead of having multiple PATH_IsPathOpen checks in the generic function. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: OpenFile16 and similar functions
by Dan Kegel June 20, 2007

June 20, 2007

On 6/20/07, Jakob Eriksson <jakob(a)vmlinux.org> wrote: > Are not the tests still EXE-s called by winetest? Then the current > winetest will work OK. Except that winetest.h might not compile in 16 bit mode, and our build system doesn't handle 16 bit binaries, and gcc/ld can't build 16 bit NE executables, and you can't mix 16 and 32 bit easily so we'd need a winetest16, yes. :-) > Though we would benefit from having a crosscompiler to 8086 Windows EXEs. Yeah, I haven't checked yet whether openwatcom's linux version can build 16 bit NE executables. Sure would be cool! - Dan

2 1

re: OpenFile16 and similar functions
by Dan Kegel June 20, 2007

June 20, 2007

Anatoly asked: > How can I write a test for this function or build program use it? I think writing good win16 tests requires a 16 bit linker. Fortunately, OpenWatcom has one, and works on Wine. It's amazingly easy to install it and build one of its demo apps: $ wget http://ftp.openwatcom.org/ftp/open-watcom-c-win32-1.6.exe $ wine open-watcom-c-win32-1.6.exe $ wineboot $ cd .wine/drive_c/WATCOM/samples/win/alarm/win16 $ wine wmake $ wine alarm This builds an honest-to-goodness win16 binary that works on XP (possibly with one warning dialog you have to ignore). Unfortuately, Wine doesn't currently run these win16 apps properly; they hang with err:ntdll:RtlpWaitForCriticalSection section 0x7b91f300 "syslevel.c: Win16Mutex" wait timed out in thread 000b, blocked by 000c, retrying (60 sec) This is embarassing. These are the "hello, world" of 16 bit windows apps, and current wine (well, wine-0.9.37-g3739b5f) can't run them... I haven't looked to see if older wine runs these 16 bit demo apps properly.

2 3

OpenFile16 and similar functions
by Anatoly Lyutin June 19, 2007

June 19, 2007

Hi all! How can I write a test for this function or build program use it? I do not understand how I can do this uses Wine? Thank you for attention! =) -- Best regards Anatoly Lyutin.

1 0

Re: [4/5] D3D8: Convert FVFs to vertex declarations
by H. Verbeet June 19, 2007

June 19, 2007

On 19/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + if (hr != S_OK) return NULL; Any reason for not simply using FAILED(hr) there? > + object->decls = HeapAlloc(GetProcessHeap(), 0, 0); Is that useful?

3 4

Compiling Wine on Fedora 7 64-bit (opengl fails)
by Paul Vriens June 19, 2007

June 19, 2007

Hi, I'm a total newbie to the 64-bit world (just built a system this weekend) and now I'm trying to get Wine compiled. It fails with (the first failure that is): LD_LIBRARY_PATH="../../libs/wine:$LD_LIBRARY_PATH" ../../tools/wrc/wrc --nostdinc -I. -I. -I../../include -I../../include -D__WINESRC__ -foversion.res version.rc ../../tools/winegcc/winegcc -B../../tools/winebuild -shared ./opengl32.spec opengl_ext.o opengl_norm.o wgl.o version.res -o opengl32.dll.so -luser32 -lgdi32 -ladvapi32 -lkernel32 -lntdll -L/usr/lib64 -lSM -lICE -lXxf86vm -lXext -lX11 -lGL ../../libs/port/libwine_port.a /usr/bin/ld: skipping incompatible /usr/lib64/libSM.so when searching for -lSM /usr/bin/ld: skipping incompatible /usr/lib64/libICE.so when searching for -lICE /usr/bin/ld: skipping incompatible /usr/lib64/libXxf86vm.so when searching for -lXxf86vm /usr/bin/ld: skipping incompatible /usr/lib64/libXext.so when searching for -lXext /usr/bin/ld: skipping incompatible /usr/lib64/libX11.so when searching for -lX11 /usr/bin/ld: skipping incompatible /usr/lib64/libGL.so when searching for -lGL /usr/bin/ld: skipping incompatible /usr/lib64/libm.so when searching for -lm /usr/bin/ld: skipping incompatible /usr/lib64/libm.a when searching for -lm /usr/bin/ld: skipping incompatible /usr/lib64/libc.so when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.a when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.so when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib64/libc.a when searching for -lc wgl.o: In function `wglUseFontOutlines_common': wgl.c:(.text+0xec6): undefined reference to `gluNewTess' wgl.c:(.text+0xeec): undefined reference to `gluTessCallback' wgl.c:(.text+0xf09): undefined reference to `gluTessCallback' wgl.c:(.text+0xf26): undefined reference to `gluTessCallback' wgl.c:(.text+0x13b9): undefined reference to `gluTessBeginPolygon' wgl.c:(.text+0x1432): undefined reference to `gluTessBeginContour' wgl.c:(.text+0x146e): undefined reference to `gluTessVertex' wgl.c:(.text+0x1563): undefined reference to `gluTessVertex' wgl.c:(.text+0x167f): undefined reference to `gluTessVertex' wgl.c:(.text+0x16ca): undefined reference to `gluTessVertex' wgl.c:(.text+0x174b): undefined reference to `gluTessEndContour' wgl.c:(.text+0x178b): undefined reference to `gluTessEndContour' wgl.c:(.text+0x17b9): undefined reference to `gluTessEndPolygon' wgl.c:(.text+0x18a0): undefined reference to `gluDeleteTess' collect2: ld returned 1 exit status winegcc: gcc failed. make: *** [opengl32.dll.so] Error 2 Any suggestions where to start looking or how to approach this. I had a look at the Wiki to no avail. I've tested with and without the NVIDIA drivers. I also have another F7 box, 32-bit, that works fine. Cheers, Paul.

3 3

Re: [2/5] WineD3D: Remove the FVF codepath from drawprim
by H. Verbeet June 19, 2007

June 19, 2007

Not specific to this patch, but will you remove the fvf field from the stateblock as well?

2 3

Re: QUARTZ: Patch 1 - Fix video rendering sizing/positioning bugs
by Alexandre Julliard June 19, 2007

June 19, 2007

a_villacis(a)palosanto.com writes: > + case WM_SIZE: > + TRACE("WM_SIZE %d %d\n", LOWORD(lParam), HIWORD(lParam)); > + SetWindowPos(hwnd, NULL, pVideoRenderer->WindowPos.left, pVideoRenderer->WindowPos.top, LOWORD(lParam), HIWORD(lParam), SWP_NOZORDER); Why do you want to resize a window that has just been resized? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [AppDB] Increase menu text size
by Alex Waite June 19, 2007

June 19, 2007

Alexander Nicolaysen Sørnes wrote: > This should make it easier for people to notice the menu options. From 10px > to 11px. > > > Regards, > > Alexander N. Sørnes > > > ------------------------------------------------------------------------ > > I agree with increasing text size here, but we should keep in mind a few things. Setting text size in pixels is no longer the cool thing to do. W3C feels that it is best to use the "x-small, small, medium, etc" values since they respect user settings and accessibility the most. An alternative which gives more control but isn't quite as proper is to use em instead of px. Either is better than using pixels. Also, this text size should be changed on all pages because the menu text size in the AppDB is now larger than the text in the menu on the front page. I am part of a large project at my work where I have had to learn quite a bit about web accessibility and best practices. Contrary to popular (and lazy) belief, most of it actually makes it easier in the end to write and maintain a large website. Plus the site is accessible to more users. ---Alex

2 1

Re: [4/5] WineD3D: Emulate tracking of multiple material properties
by H. Verbeet June 19, 2007

June 19, 2007

On 19/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > + if(!This->stateBlock->vertexShader) { > Testing for a vertex shader like that doesn't take into account the selected vs mode (ie, could be disabled) or transformed vertices. You should probably be using use_vs() instead.

1 0

Re: [3/5] WineD3D: Do not attempt to load texture coords for unsupported stages
by H. Verbeet June 19, 2007

June 19, 2007

I remember discussing this patch, but in retrospect I'm not sure this fix is completely correct. When a pixel shader is used with fixed function vertex processing, more than GL_LIMITS(textures) texture coordinates can be used.

1 0

Re: winex11 - Fix X11DRV_DIB_GetImageBits() when target bitmaps are larger than fetched area
by Alexandre Julliard June 19, 2007

June 19, 2007

Peter Dons Tychsen <donpedro(a)tdcadsl.dk> writes: > #ifdef HAVE_LIBXXSHM > - if (descr->image && descr->useShm) > + > + if(descr->image && descr->useShm) > + { > + XGetGeometry(gdi_display, descr->drawable, &root, &x, &y, &width, > &height, &border_width, &depth); > + TRACE("XGetGeometry(), width=%i, heigth=%i\n", width, height); > + } > + > + /* We must not call XShmGetImage() with a bitmap which is bigger > than the avilable area. > + If we do, XShmGetImage() will fail (X exception), as it checks > for this internally. */ > + if((descr->image && descr->useShm) && (bmpImage->width <= (width - > descr->xSrc)) > + && (bmpImage->height <= (height - descr->ySrc))) > { > int saveRed, saveGreen, saveBlue; The patch is wrapped, and you don't want to use XGetGeometry, this incurs a server round-trip. -- Alexandre Julliard julliard(a)winehq.org

1 0

Adds NET STOP to net.exe
by Kirill K. Smirnov June 19, 2007

June 19, 2007

Hi, Tim. Please, proceed bug #8554. Thanks, -- Kirill

1 0

Re: winex11.drv: send WM_MOUSEACTIVATE before closing a window (try 3)
by Dmitry Timoshkov June 19, 2007

June 19, 2007

"Lei Zhang" <thestig(a)google.com> wrote: > On Windows, clicking the close button of a nonactive window generates > a WM_MOUSEACTIVATE notification. Applications with custom window > procedures can then choose to ignore the close button if they wished > to by returning MA_ACTIVATEANDEAT / MA_NOACTIVATEANDEAT. I'm not sure what you mean by "applications with custom window procedures" because all (even simple ones) window procs in applications are custom, and they are free to handle/ignore any message they like, for instance WM_CLOSE or WM_SYSCOMMAND/SC_CLOSE. We already send WM_MOUSEACTIVATE message on a take focus X11 event, so I don't see a point in duplicating it. On the other hand if a WM doesn't activate a window when a user clicks on window's caption (where the close button usually placed) then it's a WM bug and we can do nothing to fix it. -- Dmitry.

2 4

Remove font set when calling XCreateIC?
by Nigel Liang June 19, 2007

June 19, 2007

Hi, This patch removes a call to XCreateFontSet which was causing wine to be very slow in some Chinese locale settings. The server side font calls are supposed to be deprecated anyway as Dan pointed out in his comment here: http://bugs.winehq.org/show_bug.cgi?id=5309 According to the Xlib programming manual, if a font set is not specified when calling XCreateIC, the default is determined by the input method. But it seems that this used to be a required field, so I am not sure if this will break any old input methods out there. Any ideas on how I could better test this before submitting? Thanks! -Nigel

1 0

Re: msi: Fix the conditions to determine which files to remove
by James Hawkins June 18, 2007

June 18, 2007

On 6/18/07, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > This fixes an error with a test Windows Installer Patch that I'm > trying to get working. > > Changelog: > * Fix the conditions to determine which files to remove. > Ignore this for right now. There's something else that needs to be fixed first. -- James Hawkins

1 0

Re: ntoskrnl.exe: Add a stub implementation of KeInitializeTimer
by James Hawkins June 18, 2007

June 18, 2007

On 6/18/07, James Hawkins <truiken(a)gmail.com> wrote: > Hi, > > The Fahrenheit installer calls this function. KTIMER is defined in > ketypes.h in the ddk, but that file doesn't exist for us yet, and I > followed the example of others and defined it in wdm.h (where most of > the types in ketypes.h were defined instead). > Nevermind my comments about the headers. osronline says it's defined in wdm.h, so this patch is still good to go. -- James Hawkins

1 0

Sorry, Opera is not yet supported by Xinha.
by RusH June 18, 2007

June 18, 2007

Bugzilla uses this new toy, but the script loads it even after it detects Opera = it eats the text in edit fields sometimes and I cant process Test Results. Could it load itselfe only when not detecting Opera? -- Who logs in to gdm? Not I, said the duck.

1 0

Winelib should have dir.h and some consts
by Jérôme Gardou June 18, 2007

June 18, 2007

I try to compile a small program which use msvcrt headers, and it appeared that, in winelib there is no dir.h (which may be redirected to dirent.h ?) and that consts like MAXPATH, MAXDRIVE and others are not defined. Should it be done ? Is it planned to be ? ___________________________________________________________________________ Yahoo! Mail r�invente le mail ! D�couvrez le nouveau Yahoo! Mail et son interface r�volutionnaire. http://fr.mail.yahoo.com

2 1

Re: [Wine] Sending changes to winelib ?
by Scott Ritchie June 18, 2007

June 18, 2007

The wine-devel mailing list is best for this type of development question. Thanks, Scott Ritchie On Sun, 2007-06-17 at 12:49 +0200, Jérôme Gardou wrote: > I have a little program coded for windows, and I want to compile it using > winegcc. > > Unfortunately, some functions are not implemented in winelib, and I have to > tweak some files. So, How do I submit those changes ? I found nothing on the > WineHQ site. > > SO, if someone knows where to redirect me, I can do it alone! > > > > > > ___________________________________________________________________________ > Yahoo! Mail rinvente le mail ! Dcouvrez le nouveau Yahoo! Mail et son interface rvolutionnaire. > http://fr.mail.yahoo.com > > > _______________________________________________ > wine-users mailing list > wine-users(a)winehq.org > http://www.winehq.org/mailman/listinfo/wine-users

1 0

Re: cmd.exe: Fix FOR so it works as 'well' as before.
by Detlef Riekenberg June 18, 2007

June 18, 2007

Hi Jason. The Patch is already in the tree, but I have a question: + * + * Execute a command, and any && or bracketed follow on to the command. The + * first command to be executed may not be at the front of the + * commands->thiscommand string (eg. it may point after a DO or ELSE + * Returns TRUE if something like exit or goto has aborted all processing + */ +void WCMD_part_execute(CMD_LIST **cmdList, WCHAR *firstcmd, WCHAR *variable, + WCHAR *value, BOOL isIF, BOOL conditionTRUE) { + The comment missed a closing bracked somewhere. How does the "Returns TRUE" match the declaration ("void")? Thanks -- By by ... Detlef

1 0

Building Wine with the lsb sdk, take 2
by Dan Kegel June 18, 2007

June 18, 2007

At the Linux Summit, a bunch of us decided it'd be a good idea to try out lsbcc on more real-world packages, so I tried wine again tonight. My previous try was described here: http://www.winehq.org/pipermail/wine-devel/2006-August/050554.html This time I used Feisty Fawn's lsb build env packages: sudo apt-get install lsb-build-cc3 This installed lsbcc (well, lsbcc3, anyway; looks like that's a debianism that isn't mentioned in the official lsb doc). And instead of making configure aware of lsbcc3, I created the file ~/bin/gcc containing #!/bin/sh exec lsbcc3 "$@" (Yes, the first line is needed, make fails without it.) and did chmod +x ~/bin/gcc and added ~/bin early in my PATH. Then I did configure etc. Finally, I still had to use a few of the same magic incantations explained in my last message on the subject when building: LSBCC_SHAREDLIBS=wine export LSBCC_SHAREDLIBS make LDFLAGS=-ldl CFLAGS="-g -O2 \"-DRTLD_DEFAULT=((void *)0)\" -DMAP_FILE=0" The first real problem I ran into was that freetype wasn't found. This turned out to be http://bugs.linuxbase.org/show_bug.cgi?id=1577 and I just ignored it for now. The second real problem I ran into was /home/dank/wine-git/server/ptrace.c:103: undefined reference to `ptrace' Last mention I've seen of ptrace in lsb was http://lists.debian.org/lsb-spec/2001/02/msg00038.html and I guess it never made it in. I've filed this as http://bugs.linuxbase.org/show_bug.cgi?id=1664 - Dan

3 2

Re: hnetcfg: Resend Stub implementation of the dll
by Alexandre Julliard June 18, 2007

June 18, 2007

Jeff Latimer <lats(a)yless4u.com.au> writes: > --- /dev/null > +++ b/dlls/hnetcfg/Makefile.in > @@ -0,0 +1,14 @@ > +TOPSRCDIR = ../.. > +TOPOBJDIR = ../.. > +SRCDIR = . > + > +MODULE = hnetcfg.dll > +IMPORTS = kernel32 > +IMPORTLIB = libhnetcfg.$(IMPLIBEXT) > + > +C_SRCS = \ > + hnetcfg.c > + > +(a)MAKE_DLL_RULES@ > + > +(a)DEPENDENCIES@ # everything below this line is overwritten by make depend That's not a valid Makefile.in. -- Alexandre Julliard julliard(a)winehq.org

1 0

debugging help
by Damjan Jovanovic June 18, 2007

June 18, 2007

Hi I've been looking at bug 4437, where a game demo works perfectly with the native MSVCRT.DLL but dies on startup with the builtin due to a division by zero. The builtin doesn't have any fixmes, warnings or errors. Comparing builtin +relay and native +snoop traces shows the divide by zero doesn't happen with the native, everything else looks the same. A +msvcrt log is 200000 lines long but there is nothing obviously wrong either, a +all,+relay log shows nothing useful before the crash - the last function called before the crash is a simple printf without any %'s, which produces the same results on native and builtin. Disassembling around the crash shows a long chain of calculations that dies on the fated idivl. So it looks like a nasty delayed-effect bug. I'd welcome any new ideas, and I also have a few questions. Does +relay catch all function calls? Because some functions like sscanf only appear in +snoop, not in +relay. And is there a way for a builtin DLL to LoadLibrary() the native DLL of the same name and call functions in it? It would be very useful in narrowing down the bug. Thank you Damjan

2 1

Re: QUARTZ: Patch 1 - Fix video rendering sizing/positioning bugs
by Stefan Dösinger June 18, 2007

June 18, 2007

> --- wine-0.9.39-cvs/dlls/quartz/videorenderer.c 2007-05-17 10:25:02.000000000 -0500 > +++ wine-0.9.39-cvs-patch/dlls/quartz/videorenderer.c 2007-06-17 00:47:15.000000000 -0500 You should really use git. It may be some effort to learn, but it makes your life, and Alexandre's much easier in the long run.

1 0

Re: QUARTZ: Patch 2 - Move blitting operation to message thread and handle WM_PAINT
by Chris Robinson June 17, 2007

June 17, 2007

I have no direct comment on the patch (it's not really my area), but there's something I'd like to bring up. On Sunday 17 June 2007 01:51:56 pm a_villacis(a)palosanto.com wrote: > This patch moves the blitting code into the message thread. This is a setup > patch for the DirectDraw rewrite, but can be applied on its own after the > first patch. I'm all for changing the video renderer away from GDI, however I think it'd be better to move it to Direct3D or WGL instead of DDraw. I'm quite sure native quartz uses Direct3D when available, given that DDraw has been deprecated ever since DX7. Also, using native quartz's video renderer causes wined3d debug output for me, and as Stefan says, DDraw currently defaults to GDI so it wouldn't have come from that.

1 0

Re: dinput: Handle multiple keyboard and mouse devices. Get rid of the message window. [resend]
by Vitaliy Margolen June 17, 2007

June 17, 2007

Please don't apply this patch. I will need to change few more things that will affect parts of this patch. Vitaliy. Vitaliy Margolen wrote: > Please use this one instead. The other patch had accidentally escaped debug > statements. > > Fixes bug 7129. > > The whole idea here is to set/release hook only once for keyboard/mouse. > Then if we have more then one device, just call their hook handlers from > the single > top level handler. > > Also, since we don't really check the return status from setting the > hook itself > get rid of the message window. Just notify the thread it needs to > recheck device > lists and set/remove hooks. > > --- > dlls/dinput/dinput_main.c | 234 > +++++++++++++++++++++++++----------------- > dlls/dinput/dinput_private.h | 3 +- > dlls/dinput/keyboard.c | 54 ++-------- > dlls/dinput/mouse.c | 28 +----- > 4 files changed, 156 insertions(+), 163 deletions(-) > > > ------------------------------------------------------------------------ > >

1 0

re: vxd loading is broken last months
by Dan Kegel June 17, 2007

June 17, 2007

Vitaly Lipatov wrote: > INT21_CreateMagicDeviceHandle in winedos/int21.c uses the same dummy file > magic with open file with unix path from wine_get_server_dir(). > I guess we could use NtCreateFile on unix path before. > Now we need select correct place for such dummy files inside wine disk tree... Yeah. Evan has been sitting on a patch to fix this for a week now. Evan, I'd say it's time to post your minimal test and the fix, even if things are broken. - Dan

4 3

GDI+ programs
by Evan Stade June 16, 2007

June 16, 2007

Hi, I want to make some real applications work with the built-in wine GDI+. Does anyone know of some programs that use GDI+ that would be good for guiding my development? thanks, Evan Stade

5 4

vxd loading is broken last months
by Vitaly Lipatov June 16, 2007

June 16, 2007

CreateFile is not success with somename.vxd (somename.vxd.so exists in /usr/lib/wine) As known open_vxd_handle( LPCWSTR name ) in kernel32/vxd.c have to open dummy file in the wineserver directory. It try use NtCreateFile for open Unix path /tmp/.wine/... and get failure. What part have to be fixed? NtCreateFile or open_vxd_handle? -- Lav Vitaly Lipatov Saint-Petersburg, Etersoft www.etersoft.ru GNU! ALT Linux Team! WINE! LaTeX! LyX!

2 2

cmd.exe console question
by Ann & Jason Edmeades June 15, 2007

June 15, 2007

Out of interest, is there any way to get (read here 'write code for') the wine's cmd.exe better integrated in the window you launch it from when it is not in wineconsole mode. For example, I would love to see cls clear the screen (I suppose I could just launch 'clear'!), or command retrieval work (and, but by far the lowest priority, colo(u)rs). I *know* you can do it with wineconsole with user and curses backend, but in a 'normal' shell window the shell itself manages it, and is there any programming interface to that? One problem I can perceive is I cant tell between output being redirected to a file, or output being redirected to the shell window (neither query the console attributes) Jason

1 0

Re: [PATCH 2/2] dinput: Handle multiple keyboard and mouse devices.
by Detlef Riekenberg June 15, 2007

June 15, 2007

On So, 2007-06-10 at 19:20 -0600, Vitaliy Margolen wrote: > Should fix bug 7129. > > The whole idea here is to set/release hook only once for keyboard/mouse. > Then if we have more then one device, just call their hook handlers from the single > top level handler. > --- > dlls/dinput/dinput_main.c | 82 ++++++++++++++++++++++++++++++++++++++--- > dlls/dinput/dinput_private.h | 4 ++- > dlls/dinput/keyboard.c | 54 ++++++--------------------- > dlls/dinput/mouse.c | 28 ++------------ > 4 files changed, 95 insertions(+), 73 deletions(-) Works the same as native dinput. Thanks a lot. The sensitive high-speed Mouse-Accellerator for the RMB is also present with native dinput. I will add a new bug for that regression. Any Ideas, where to search? ("dlls/" or "dlls/winex11.drv/") As additional hint, the moving direction is most times fixed: When i start moving up/right (45*) while the RMB id pressed, then the app still see 45* when I move the mouse in a different direction (down or left as examples). Looks like a value is not reset. -- By by ... Detlef

1 0

Re: gdiplus: graphics tests [try2]
by Alexandre Julliard June 15, 2007

June 15, 2007

"Evan Stade" <estade(a)gmail.com> writes: > +static const INT drawline_bmp1[192] = > +{0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, I don't think we want to do that sort of thing. We can't guarantee that the results will be exact pixel for pixel, and we don't really care. And even if we did, hardcoding the image in the source this way is unmaintainable. If you want to check the results, you should write an app that draws various things and check it visually against Windows, but I don't think that's something that can be part of the regression test suite. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [3/5] widl: Add tests for encapsulated unions
by Dan Hipschman June 15, 2007

June 15, 2007

On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote: > + if (strcmp(winetest_platform, "wine") != 0) /* crashes wine */ > + { > + eu.t = ENCU_I; > + eu.tagged_union.i = 7; > + ok(square_encu(&eu) == 49.0, "RPC square_encu\n"); > + > + eu.t = ENCU_F; > + eu.tagged_union.f = 3.0; > + ok(square_encu(&eu) == 9.0, "RPC square_encu\n"); > + } Hi. So, I realize the usual way to handle tests that crash wine (besides fixing the bug that causes the crash), is to "if (0)" or comment the test out, as in ntdll/tests/reg.c, or rpcrt4/tests/ndr_marshall.c, but this patch tests more than wine, it also tests widl, and it's therefore not just documentation. If I "if (0)" the test out (or worse, it doesn't get accepted), I'm going to have to edit the test each time I run it on windows to re-add the encapsulated union test so I can verify that the widl output stubs still work on windows. One solution is to do something like this: #ifndef TESTS_THAT_CRASH_WINE # define TESTS_THAT_CRASH_WINE 0 #endif ... if (TESTS_THAT_CRASH_WINE) { eu.t = ENCU_I; eu.tagged_union.i = 7; ok(square_encu(&eu) == 49.0, "RPC square_encu\n"); eu.t = ENCU_F; eu.tagged_union.f = 3.0; ok(square_encu(&eu) == 9.0, "RPC square_encu\n"); } So at least I can just compile with -DTESTS_THAT_CRASH_WINE=1 on windows, which is easy to stick in a batch file or something. Otherwise, I'm stuck maintaining a patch that has to be applied before each compile. Plus, it means I'm the only one who's probably testing encapsulated unions on windows, so it's only getting tested on one platform. Any chance something like the original patch can get into wine?

2 1

Liberation
by Louis. Lenders June 15, 2007

June 15, 2007

Hi, this is mainly a follow up to the thread here http://www.winehq.org/pipermail/wine-devel/2007-May/057092.html , to give it a new boost.... Question is, are there any plans to include Liberation fonts in wine? I gave it a good testing last two weeks, that is, i converted the fonts with Hans' Leidekkers script , from link above, and tested the "Arial-compatible" font quite a bit, with several applications. It all seems to work great, no issues / problems found. Several applications would be very happy , if this were to be included in wine. Any comments? Some of the tested apps: xchat --> just aborts silently without arial font Book worms adventures --> pops up a crash window without arial font d3d9-samples from DirectX 9.0 SDK --> Don't show any text without arial font + a lot more that just look prettier with arial font. --------------------------------- Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for your freeaccount today.

7 10

gdiplus no longer available in Vista?
by Paul Vriens June 15, 2007

June 15, 2007

Hi, I had a look but wasn't able to find gdiplus.dll on my Vista box. This most likely means our test has to be re-written. I'll wait with that till the cross-compiling of the gdiplus tests is fixed. Cheers, Paul.

2 1

Problem with the Ubuntu 7.04 (Feisty) package (again)
by Ben Hodgetts (Enverex) June 15, 2007

June 15, 2007

We've had a few people report issues with the Ubuntu Feisty .38 package in the WineHQ repo lately (http://wine.budgetdedicated.com/archive/ubuntu/feisty/wine_0.9.38~winehq0~u…) the specific issue being that the fonts are all missing on most things, in other places only the first few letters may be shown. Originally I thought this was something to do with them lacking fonts but in each case telling them to install the .37 package instead fixed the issue meaning it's more likely to be a problem with the .38 package. Any ideas Scott? Ben H.

1 0

Re: [3/5] widl: Add tests for encapsulated unions
by Dan Hipschman June 15, 2007

June 15, 2007

On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote: > > This adds a test for encapsulated unions, but it crashes wine. The exact Hmm, now that I reread this, I think I said this wrong. The test does crash wine, but I wrote my patch so that it doesn't run on wine. So, doing "make check" in dlls/rpcrt4/tests will *not* crash wine, it just won't run the encapsulated union tests. The encapsulated union tests *will* run, and succeed, on windows, however. I felt this was best because that way all of widl's output can still continue to be tested on windows, and everything that can be tested in wine without crashing still will be.

1 0

Re: Uninstaller
by Misha Koshelev June 14, 2007

June 14, 2007

First of all, of course I am not Alexandre. But I have to say I think I agree with James on this, with regards to submitting just one patch with the correct spacing. I can see how seeing one patch without any spacing changes keeps the diff very simple (I am assuming this is why you submitted your patches in this way), but at the same time I would assume that if Alexandre really wants to see what changed in this way after applying the one patch you will send with correct spacing, he can just type: git-diff -b and see something very similar to your patch #1 (ignores whitespace, same effect). Other than that, I did not see anything obviously wrong with the patch upon a quick look. If you don't hear from anyone else on wine-devel, I would suggest resubmitting as one patch with correct indentation as James suggested. If you don't see it committed after a while (maybe a week or so, maybe longer) I would either get in touch with the list again or try to get in touch with Alexandre to see if he has any specific comments. Hope that helps. Misha

3 4

Re: include/uxtheme.h : enum THEMESIZE
by Michael Stefaniuc June 14, 2007

June 14, 2007

Nicolas (dyalog.com) wrote: > according to MSDN, include/uxtheme.h should define an "enum THEMESIZE", > which is typedefed to "THEME_SIZE", > rather than typedef the enum {} to "THEMESIZE" as it is currently. > http://msdn2.microsoft.com/en-us/library/ms649970.aspx > > note that dlls/uxtheme/draw.c uses this definition so must also be patched. Please merge those 2 changes into one patch as one without the other make the Wine source to not compile anymore. And please use unified diff format; the draw.c.patch isn't a unified diff. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0

Re: user32: improve cut/copy/paste behavior of password edit boxes
by Vitaly Lipatov June 14, 2007

June 14, 2007

В сообщении от 14 июня 2007 Lei Zhang написал(a): > Hi, > > This patch prevents cutting/copying text from edit boxes with the > ES_PASSWORD style. It also corrects the paste behavior of password Why we need prevent it? > edit boxes when the clipboard is empty. -- Vitaly Lipatov, ALT Linux Team Russia, Saint-Petersburg, www.etersoft.ru

2 1

Re: Juan Lang : comdlg32: Initialize file dialog controls before creating dialog.
by Lei Zhang June 14, 2007

June 14, 2007

Hi Juan, With this patch, the bottom of file dialogs are cut off such that the file type dropdown and the cancel button can barely be seen. - Lei On 6/7/07, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 13f18ee7593364a2a685fed2bdfa814431906f0c > URL: http://source.winehq.org/git/wine.git/?a=commit;h=13f18ee7593364a2a685fed2b… > > Author: Juan Lang <juan_lang(a)yahoo.com> > Date: Thu Jun 7 12:27:11 2007 -0700 > > comdlg32: Initialize file dialog controls before creating dialog. > > --- > > dlls/comdlg32/filedlg.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/comdlg32/filedlg.c b/dlls/comdlg32/filedlg.c > index f63e64f..5409b91 100644 > --- a/dlls/comdlg32/filedlg.c > +++ b/dlls/comdlg32/filedlg.c > @@ -1037,11 +1037,11 @@ INT_PTR CALLBACK FileOpenDlgProc95(HWND hwnd, UINT uMsg, WPARAM wParam, LPARAM l > so it will be easily accessible through a GetPropA(...) */ > SetPropA(hwnd, FileOpenDlgInfosStr, (HANDLE) fodInfos); > > + FILEDLG95_InitControls(hwnd); > + > fodInfos->DlgInfos.hwndCustomDlg = > CreateTemplateDialog((FileOpenDlgInfos *)lParam, hwnd); > > - FILEDLG95_InitControls(hwnd); > - > if (fodInfos->DlgInfos.hwndCustomDlg) > { > RECT rc; > > > >

2 2

Re: [3/5] WineD3D: Present does not clear the depth stencil
by H. Verbeet June 14, 2007

June 14, 2007

On 14/06/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > The patch removes the clearing from Present, except for the DISCARD swap effect if the d3d trace channel is on. It sounds a bit questionable to have different behaviour depending on the debug channel.

2 2

Re: [crypt32/tests 2/2] Vista uses a different error code (RESEND)
by Dmitry Timoshkov June 14, 2007

June 14, 2007

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > ret = CryptSIPRetrieveSubjectGuid(tempfileW, NULL, &subject); > ok ( !ret, "Expected CryptSIPRetrieveSubjectGuid to fail\n"); > ok ( GetLastError() == ERROR_FILE_INVALID || > + GetLastError() == ERROR_INVALID_PARAMETER /* Vista */ || > GetLastError() == S_OK /* Win98 */, > - "Expected ERROR_FILE_INVALID or S_OK, got 0x%08x\n", GetLastError()); > + "Expected ERROR_FILE_INVALID, ERROR_INVALID_PARAMETER or S_OK, got 0x%08x\n", GetLastError()); S_OK is an OLE error, ERROR_SUCCESS is correct name in this case. It's not your fault at all, but since you are fixing this code it would be nice to fix it as well. -- Dmitry.

2 1

Re: Fixed the WriteEnvironmentStrings action [try2]
by Dmitry Timoshkov June 14, 2007

June 14, 2007

"James Hawkins" <truiken(a)gmail.com> wrote: > + while (*cptr && (*cptr == '=' || *cptr == '+' || > + *cptr == '-' || *cptr == '!' || *cptr == '*')) > + { > + switch (*cptr) > + { > + case '=': > + *flags |= ENV_ACT_SETALWAYS; > + break; > + case '+': > + *flags |= ENV_ACT_SETABSENT; > + break; > + case '-': > + *flags |= ENV_ACT_REMOVE; > + break; > + case '!': > + *flags |= ENV_ACT_REMOVEMATCH; > + break; > + case '*': > + *flags |= ENV_MOD_MACHINE; > + break; > + default: > + ERR("Unknown Environment flag: %c\n", *cptr); > + return ERROR_FUNCTION_FAILED; > + } > + > + cptr++; > + (*name)++; > + } A simple 'goto' in the 'default:' case, or using while (*cptr) { if (*cptr == '=') else if (*cptr == '+') { } else if (...) { } else break; } would help to avoid double comparisons and simplify the code. -- Dmitry.

1 0

Re: patch for winefile.
by Dmitry Timoshkov June 14, 2007

June 14, 2007

"Ivan Sinitsin" <ivan(a)etersoft.ru> wrote: > + static const WCHAR sFont[] = {'M','i','c','r','o','s','o','f','t',' ','S','a','n','s',' ','S','e','r','i','f','\0'}; > + HDC hdc = GetDC(0); ... > + if( RegQueryValueEx( hKey, reg_font_facename, NULL, &type, > + (LPBYTE) &logfont.lfFaceName, &sizeW) != ERROR_SUCCESS ) > + strcpyW(logfont.lfFaceName,sFont); It's not very useful to use by default the font that is not available on any Linux installation by default. I'd suggest to use GetStockObject(DEFAULT_GUI_FONT) instead. And you are leaking an hdc. > + LOGFONT logfont; > > wi.cbSize = sizeof( WINDOWINFO ); > GetWindowInfo(Globals.hMainWnd, &wi); > width = wi.rcWindow.right - wi.rcWindow.left; > height = wi.rcWindow.bottom - wi.rcWindow.top; > + GetObject((HGDIOBJ)Globals.hfont, sizeof(logfont), (LPVOID)&logfont); This cast is not needed. -- Dmitry.

1 0

Uninstaller
by Tom Spear June 14, 2007

June 14, 2007

It's been a while since I brought anything up on this, so I figured I'd ask what was wrong with the last set of patches I sent.. The patches are at [1] and [2], the discussion generated by them are at [3], [4], [5], and [6]... Summary, I did everything I was told in private by a developer (who isn't alexandre, i know), and I got told by another developer, who also isn't alexandre, to fix some things that the first developer said didn't need fixing.. So should I fix those things, or is there some other reason it wasn't committed? [1] http://www.winehq.org/pipermail/wine-patches/2007-June/039911.html [2] http://www.winehq.org/pipermail/wine-patches/2007-June/039912.html [3] http://www.winehq.org/pipermail/wine-devel/2007-June/057253.html [4] http://www.winehq.org/pipermail/wine-devel/2007-June/057254.html [5] http://www.winehq.org/pipermail/wine-devel/2007-June/057255.html [6] http://www.winehq.org/pipermail/wine-devel/2007-June/057258.html Someone please let me know what is wrong (I'd love to hear from The Man, if he has time to take a look), but anyone's responses are welcome (hopefully I get more than 2 reponses this time lol).... -- Thanks Tom

1 0

Re: [GDI+: 7/7] implemented GdipDrawImage
by Evan Stade June 14, 2007

June 14, 2007

On 6/13/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > changelog: > *implemented GdipDrawImage > > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/graphics.c | 28 ++++++++++++++++++++++++++++ > include/gdiplusflat.h | 1 + > 3 files changed, 30 insertions(+), 1 deletions(-) > > -Evan Stade > > ignore this patch

1 0

msi: Fixed the WriteEnvironmentStrings action
by Misha Koshelev June 14, 2007

June 14, 2007

> + res = RegQueryValueExW(env, name, NULL, &type, NULL, &size); > + if (res != ERROR_FILE_NOT_FOUND || (res == ERROR_SUCCESS && type != REG_SZ)) > + goto done; Hate to point this out but isn't this the exact same error I made in my first (and second) patch from last night? I think it should be: if ((res != ERROR_FILE_NOT_FOUND && res != ERROR_SUCCESS) || (res == ERROR_SUCCESS && type != REG_SZ)) goto done; In your statement, if res is ERROR_SUCCESS it will always goto done no matter what the value of type, because ERROR_SUCCESS != ERROR_FILE_NOT_FOUND. Guess logic errors in if statements are contagious :) Misha

1 0

Re: msi: Do not use type value if call to RegQueryValueEx failed.
by James Hawkins June 13, 2007

June 13, 2007

On 6/12/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > This is necessary (bug not sufficient, see my comment in the bug report that I am about > to post) to fix bug 8678. > > It is also clearly correct, as checking the type "returned" by RegQueryValueEx when it fails > makes no sense. > size = 0; res = RegQueryValueExW(env, var, NULL, &type, NULL, &size); - if ((res != ERROR_MORE_DATA && res != ERROR_FILE_NOT_FOUND) || type != REG_SZ) + if ((res != ERROR_MORE_DATA && res != ERROR_FILE_NOT_FOUND) || + (res == ERROR_SUCCESS && type != REG_SZ)) { RegCloseKey(env); return res; This is wrong. If res == ERROR_SUCCESS, then the first condition evaluates to TRUE and we fall through to exit, but then again, res will never be ERROR_SUCCESS after that particular call. Either way, I have a patch ready to send in that fixes the entire action. -- James Hawkins

3 2