June 2007 - Wine-Devel - list.winehq.org

re: NULL ptr dereferences found with Calysto static checker
by Dan Kegel June 21, 2007

June 21, 2007

Domagoj wrote: > I've ran my static checker Calysto on Wine v0.9.35 and got > 78 bug reports:... > If you are interested in the reports, please: > 1) read > http://www.cs.ubc.ca/~babic/index_calysto_community.htm > 2) if the conditions are acceptable, let me know where to > send the reports. The conditions look very minimal, we should be fine with them. A check once a month should be fine. Just send the results to wine-devel(a)winehq.org. (There's some chance we'll ask you to switch to sending them somewhere else, but that will do initially.) For the moment just put the calysto.org link in the mail. Once it's clear the results are useful, somebody will link to calysto at least from our wiki. Say, whatever happened to Coverity's scans of Wine? I just logged in to the Wine results at http://scan.coverity.com, and the last scan seems to have been last July. Did they set up a new, private site for us? Paul V., do you know? - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

9 11

Coverity status
by Paul Vriens June 21, 2007

June 21, 2007

Hi, I've been in contact with Coverity. People currently listed as Wine contacts are: - Jan Zerebecki - Paul Vriens The main page is changed so it reflects the new scan site http://scan2.coverity.com:7479 and there has just been a new run! Coverity is very busy setting up some proper communication channels and some means for the contacts to do some kind of user administration (limited of course). Apart from that a lot of the current manual tasks will be automated (like the counters on the page where Wine is listed http://scan.coverity.com/rung1.html) Cheers, Paul.

1 0

Re: winmm: Specify the arguments of the function in the function pointer
by Alexandre Julliard June 21, 2007

June 21, 2007

Michael Stefaniuc <mstefani(a)redhat.de> writes: > @@ -114,10 +114,10 @@ static BOOL MMDRV_GetDescription32(const char* fname, char* buf, int buflen) > DWORD dw; > BOOL ret = FALSE; > UINT u; > - FARPROC pGetFileVersionInfoSizeA; > - FARPROC pGetFileVersionInfoA; > - FARPROC pVerQueryValueA; > - HMODULE hmodule = 0; > + DWORD (WINAPI *pGetFileVersionInfoSizeA)(LPCSTR,LPDWORD); > + BOOL (WINAPI *pGetFileVersionInfoA)(LPCSTR,DWORD,DWORD,LPVOID); > + BOOL (WINAPI *pVerQueryValueA)(LPCVOID,LPCSTR,LPVOID*,UINT*); > + HMODULE hmodule = 0; It may have been done that way because local WINAPI pointers crash on old versions of gcc. But that whole function should probably be removed, dumping version info doesn't belong in winmm. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/2] oleaut32: add PNG loading [try2]
by Evan Stade June 21, 2007

June 21, 2007

On 6/19/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > Try2: This time the rowsize is correctly aligned (on 4-byte > boundaries) and palette-mode PNGs are allowed as well as RGB-mode > PNGs. > > Changelog: > *added support to decode some PNG files > *added check for png.h / dynamic loading of libpng.so > > configure.ac | 2 > dlls/oleaut32/olepicture.c | 205 ++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 207 insertions(+), 0 deletions(-) > > -- > Evan Stade > > Hi, How can I improve this patch such that it will be accepted? -- Evan Stade

2 1

Re: shell32: Make SHGetDesktopFolder use a cached instance of IShellFolder
by Alexandre Julliard June 21, 2007

June 21, 2007

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > + sf = LocalAlloc( LMEM_ZEROINIT, sizeof (IGenericSFImpl) ); > + if (!sf) > + return E_OUTOFMEMORY; > + > + if (InterlockedCompareExchangePointer((void *)&cached_sf, sf, NULL) != NULL) > + LocalFree( sf ); /* some other thread already been here */ > + else > + { > + sf->ref = 0; > + sf->lpVtbl = &vt_MCFldr_ShellFolder2; > + sf->pidlRoot = _ILCreateDesktop(); /* my qualified pidl */ > + sf->sPathTarget = SHAlloc( (lstrlenW(szMyPath) + 1)*sizeof(WCHAR) ); > + lstrcpyW( sf->sPathTarget, szMyPath ); > + } > + } You need to initialize the object completely before storing it as cached entry. -- Alexandre Julliard julliard(a)winehq.org

1 0

ntdll: Constify some variables (1 of 2)
by Andrew Talbot June 21, 2007

June 21, 2007

Please ignore this patch. Thanks, -- Andy.

1 0

Re: [kernel32][tests] Add test for GetShortPathNameW
by Dmitry Timoshkov June 21, 2007

June 21, 2007

"Anatoly Lyutin" <vostok(a)etersoft.ru> wrote: > + WCHAR PROG_FILES_DIR[MAX_PATH]; Looks like that this variable is not used anywhere. > static DWORD (WINAPI *pGetLongPathNameA)(LPCSTR,LPSTR,DWORD); > static DWORD (WINAPI *pGetLongPathNameW)(LPWSTR,LPWSTR,DWORD); > +static DWORD (WINAPI *pGetShortPathNameW)(LPWSTR,LPWSTR,DWORD); I don't see where pGetShortPathNameW is initialized. > + file = CreateFileW(short_path, GENERIC_READ|GENERIC_WRITE, 0, > + NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + ok(file != INVALID_HANDLE_VALUE, "File was not created.\n"); > + ret = WriteFile(file, "test", strlen("test"), NULL, NULL); > + ok(ret, "Can not open file!!\n"); The error message in ok() is not correct. > + CloseHandle(file); > + ret = DeleteFileW(short_path); > + ok(ret, "Can not delete file.\n"); > + GetTempPathW(MAX_PATH, path); > + lstrcatW(path, src); > + lstrcatW(path, backSlash); > + ret = RemoveDirectoryW(path); 'path' at this point already contains what you need, calling GetTempPathW and friends is not needed, and that would simplify the code a bit. > +static void test_GetShortPathNameW(void) > +{ > + WCHAR empty[MAX_PATH]; > + WCHAR pathE[] = {'p','a','t','h','t','e','s','t',0}; > + WCHAR pathRL[] = {0x0414,0x043B,0x0438,0x043D,0x043D,0x043E,0x0435,0x0418,0x043C,0x044F,0}; /* Long Russian name > */ > + WCHAR pathRS[] = {0x0418,0x043C,0x044F,0}; /* Short Russian name */ Do you really need the test to use cyrillic characters? That won't work if underlying unix locale is not russian regardless what you set the thread locale to. > + /* Not present in all windows versions */ > + if(pGetShortPathNameW) > + { > + SetLastError(0xdeadbeef); > + length = pGetShortPathNameW(NULL,NULL,0); > + if(GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > + { > + skip("GetShortPathNameW is not implemented\n"); > + return; > + } Indentation inside of 'if(pGetShortPathNameW)' is completely messed up. -- Dmitry.

2 2

Re: [kernel32][tests] Add test for GetShortPathNameW
by Detlef Riekenberg June 20, 2007

June 20, 2007

On Di, 2007-06-19 at 13:18 +0400, Anatoly Lyutin wrote: > + { > + SetLastError(0xdeadbeef); > + length = pGetShortPathNameW(NULL,NULL,0); > + if(GetLastError() == ERROR_CALL_NOT_IMPLEMENTED) > + { > + skip("GetShortPathNameW is not implemented\n"); > + return; Your indention looks wired -- By by ... Detlef

1 0

NULL ptr dereferences found with Calysto static checker
by Domagoj Babic June 20, 2007

June 20, 2007

Hi, I've ran my static checker Calysto on Wine v0.9.35 and got 78 bug reports: makedep: 1 sfnt2fnt: 4 winebuild: 6 winedump: 2 winegcc: 5 libwine: 60 If you are interested in the reports, please: 1) read http://www.cs.ubc.ca/~babic/index_calysto_community.htm 2) if the conditions are acceptable, let me know where to send the reports. Kind regards, -- Domagoj Babic http://www.domagoj.info/ http://www.calysto.org/

1 0

On stuttering audio in quartz/DirectShow
by Alex Villacís Lasso June 20, 2007

June 20, 2007

Upon checking the source code of dlls/quartz I found out about the method SetSyncSource defined in the IBaseFilter interface: dsoundrender.c:static HRESULT WINAPI DSoundRender_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) filesource.c:static HRESULT WINAPI AsyncReader_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) filtergraph.c:static HRESULT WINAPI MediaFilter_SetSyncSource(IMediaFilter *iface, IReferenceClock *pClock) parser.c:static HRESULT WINAPI Parser_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) transform.c:static HRESULT WINAPI TransformFilter_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) videorenderer.c:static HRESULT WINAPI VideoRenderer_SetSyncSource(IBaseFilter * iface, IReferenceClock *pClock) In particular, I see the following two things about sync sources: 1) I see no effort on part of filtergraph.c to add a sync source when simply asked to render a file 2) Even if it did, current implementation of videorenderer.c does nothing with its sync source So I have a couple of questions: 1) Am I right to assume that a sync source might be used to synchronize and (if necessary) drop frames at the videorenderer in order to maintain synchronization and avoid stuttering? 2) Could the sttutering really be solved by implementing the using and passing of a synchronization source (systemclock.c) in file rendering? If so, then the migration to DirectDraw would become just an optimization to increase the frame rate. Alex Villacís Lasso -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1