June 2007 - Wine-Devel - list.winehq.org

cmd.exe console question
by Ann & Jason Edmeades June 15, 2007

June 15, 2007

Out of interest, is there any way to get (read here 'write code for') the wine's cmd.exe better integrated in the window you launch it from when it is not in wineconsole mode. For example, I would love to see cls clear the screen (I suppose I could just launch 'clear'!), or command retrieval work (and, but by far the lowest priority, colo(u)rs). I *know* you can do it with wineconsole with user and curses backend, but in a 'normal' shell window the shell itself manages it, and is there any programming interface to that? One problem I can perceive is I cant tell between output being redirected to a file, or output being redirected to the shell window (neither query the console attributes) Jason

1 0

Re: [PATCH 2/2] dinput: Handle multiple keyboard and mouse devices.
by Detlef Riekenberg June 15, 2007

June 15, 2007

On So, 2007-06-10 at 19:20 -0600, Vitaliy Margolen wrote: > Should fix bug 7129. > > The whole idea here is to set/release hook only once for keyboard/mouse. > Then if we have more then one device, just call their hook handlers from the single > top level handler. > --- > dlls/dinput/dinput_main.c | 82 ++++++++++++++++++++++++++++++++++++++--- > dlls/dinput/dinput_private.h | 4 ++- > dlls/dinput/keyboard.c | 54 ++++++--------------------- > dlls/dinput/mouse.c | 28 ++------------ > 4 files changed, 95 insertions(+), 73 deletions(-) Works the same as native dinput. Thanks a lot. The sensitive high-speed Mouse-Accellerator for the RMB is also present with native dinput. I will add a new bug for that regression. Any Ideas, where to search? ("dlls/" or "dlls/winex11.drv/") As additional hint, the moving direction is most times fixed: When i start moving up/right (45*) while the RMB id pressed, then the app still see 45* when I move the mouse in a different direction (down or left as examples). Looks like a value is not reset. -- By by ... Detlef

1 0

Re: gdiplus: graphics tests [try2]
by Alexandre Julliard June 15, 2007

June 15, 2007

"Evan Stade" <estade(a)gmail.com> writes: > +static const INT drawline_bmp1[192] = > +{0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, > + 0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff,0xffffffff, I don't think we want to do that sort of thing. We can't guarantee that the results will be exact pixel for pixel, and we don't really care. And even if we did, hardcoding the image in the source this way is unmaintainable. If you want to check the results, you should write an app that draws various things and check it visually against Windows, but I don't think that's something that can be part of the regression test suite. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [3/5] widl: Add tests for encapsulated unions
by Dan Hipschman June 15, 2007

June 15, 2007

On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote: > + if (strcmp(winetest_platform, "wine") != 0) /* crashes wine */ > + { > + eu.t = ENCU_I; > + eu.tagged_union.i = 7; > + ok(square_encu(&eu) == 49.0, "RPC square_encu\n"); > + > + eu.t = ENCU_F; > + eu.tagged_union.f = 3.0; > + ok(square_encu(&eu) == 9.0, "RPC square_encu\n"); > + } Hi. So, I realize the usual way to handle tests that crash wine (besides fixing the bug that causes the crash), is to "if (0)" or comment the test out, as in ntdll/tests/reg.c, or rpcrt4/tests/ndr_marshall.c, but this patch tests more than wine, it also tests widl, and it's therefore not just documentation. If I "if (0)" the test out (or worse, it doesn't get accepted), I'm going to have to edit the test each time I run it on windows to re-add the encapsulated union test so I can verify that the widl output stubs still work on windows. One solution is to do something like this: #ifndef TESTS_THAT_CRASH_WINE # define TESTS_THAT_CRASH_WINE 0 #endif ... if (TESTS_THAT_CRASH_WINE) { eu.t = ENCU_I; eu.tagged_union.i = 7; ok(square_encu(&eu) == 49.0, "RPC square_encu\n"); eu.t = ENCU_F; eu.tagged_union.f = 3.0; ok(square_encu(&eu) == 9.0, "RPC square_encu\n"); } So at least I can just compile with -DTESTS_THAT_CRASH_WINE=1 on windows, which is easy to stick in a batch file or something. Otherwise, I'm stuck maintaining a patch that has to be applied before each compile. Plus, it means I'm the only one who's probably testing encapsulated unions on windows, so it's only getting tested on one platform. Any chance something like the original patch can get into wine?

2 1

Liberation
by Louis. Lenders June 15, 2007

June 15, 2007

Hi, this is mainly a follow up to the thread here http://www.winehq.org/pipermail/wine-devel/2007-May/057092.html , to give it a new boost.... Question is, are there any plans to include Liberation fonts in wine? I gave it a good testing last two weeks, that is, i converted the fonts with Hans' Leidekkers script , from link above, and tested the "Arial-compatible" font quite a bit, with several applications. It all seems to work great, no issues / problems found. Several applications would be very happy , if this were to be included in wine. Any comments? Some of the tested apps: xchat --> just aborts silently without arial font Book worms adventures --> pops up a crash window without arial font d3d9-samples from DirectX 9.0 SDK --> Don't show any text without arial font + a lot more that just look prettier with arial font. --------------------------------- Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for your freeaccount today.

7 10

gdiplus no longer available in Vista?
by Paul Vriens June 15, 2007

June 15, 2007

Hi, I had a look but wasn't able to find gdiplus.dll on my Vista box. This most likely means our test has to be re-written. I'll wait with that till the cross-compiling of the gdiplus tests is fixed. Cheers, Paul.

2 1

Problem with the Ubuntu 7.04 (Feisty) package (again)
by Ben Hodgetts (Enverex) June 15, 2007

June 15, 2007

We've had a few people report issues with the Ubuntu Feisty .38 package in the WineHQ repo lately (http://wine.budgetdedicated.com/archive/ubuntu/feisty/wine_0.9.38~winehq0~u…) the specific issue being that the fonts are all missing on most things, in other places only the first few letters may be shown. Originally I thought this was something to do with them lacking fonts but in each case telling them to install the .37 package instead fixed the issue meaning it's more likely to be a problem with the .38 package. Any ideas Scott? Ben H.

1 0

Re: [3/5] widl: Add tests for encapsulated unions
by Dan Hipschman June 15, 2007

June 15, 2007

On Thu, Jun 14, 2007 at 06:28:41PM -0700, Dan Hipschman wrote: > > This adds a test for encapsulated unions, but it crashes wine. The exact Hmm, now that I reread this, I think I said this wrong. The test does crash wine, but I wrote my patch so that it doesn't run on wine. So, doing "make check" in dlls/rpcrt4/tests will *not* crash wine, it just won't run the encapsulated union tests. The encapsulated union tests *will* run, and succeed, on windows, however. I felt this was best because that way all of widl's output can still continue to be tested on windows, and everything that can be tested in wine without crashing still will be.

1 0

Re: Uninstaller
by Misha Koshelev June 14, 2007

June 14, 2007

First of all, of course I am not Alexandre. But I have to say I think I agree with James on this, with regards to submitting just one patch with the correct spacing. I can see how seeing one patch without any spacing changes keeps the diff very simple (I am assuming this is why you submitted your patches in this way), but at the same time I would assume that if Alexandre really wants to see what changed in this way after applying the one patch you will send with correct spacing, he can just type: git-diff -b and see something very similar to your patch #1 (ignores whitespace, same effect). Other than that, I did not see anything obviously wrong with the patch upon a quick look. If you don't hear from anyone else on wine-devel, I would suggest resubmitting as one patch with correct indentation as James suggested. If you don't see it committed after a while (maybe a week or so, maybe longer) I would either get in touch with the list again or try to get in touch with Alexandre to see if he has any specific comments. Hope that helps. Misha

3 4

Re: include/uxtheme.h : enum THEMESIZE
by Michael Stefaniuc June 14, 2007

June 14, 2007

Nicolas (dyalog.com) wrote: > according to MSDN, include/uxtheme.h should define an "enum THEMESIZE", > which is typedefed to "THEME_SIZE", > rather than typedef the enum {} to "THEMESIZE" as it is currently. > http://msdn2.microsoft.com/en-us/library/ms649970.aspx > > note that dlls/uxtheme/draw.c uses this definition so must also be patched. Please merge those 2 changes into one patch as one without the other make the Wine source to not compile anymore. And please use unified diff format; the draw.c.patch isn't a unified diff. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 Red Hat GmbH Email: mstefani(a)redhat.com Hauptstaetterstr. 58 http://www.redhat.de/ D-70178 Stuttgart

1 0