August 2007 - Wine-Devel - list.winehq.org

Can we please have at least a minimal coding style ?
by Tomas Carnecky Aug. 6, 2007

Aug. 6, 2007

This type of construct seems popular in the wine source: while (isspace(*GL_Extensions)) GL_Extensions++; Start = GL_Extensions; Or even worse (I've seen this in winex11.drv, and it took me quite a long time until I understood it - it was part of a larger block with a lot these constructs): if (cond) do_sth(); do_sth_else(); This indentation is so utterly stupid, it makes my brain hurt (I'm sure I'm not the only one)!! I don't know what AJs stance is on code readability and I know that there are no official coding style guidelines, but can we please avoid this? Can we agree on a set of fundamental style rules? To make peer-reviewing patches easier? And for people not familiar with the code easier to understand it? Please? tom

5 4

Some details about SHDoDragDrop
by Timo Kunze Aug. 6, 2007

Aug. 6, 2007

Hi, currently Wine's SHDoDragDrop is a stub and the comment states that it probably is equivalent to DoDragDrop. That's not quite true. In one of my programs I passed a NULL drop source accidentally and to my surprise it worked. So SHDoDragDrop creates an IDropSource object for you if you don't pass one. I've also found out, that on Vista SHDoDragDrop does the drag-image generation for you if you pass a NULL hWnd to SHDoDragDrop. While the hWnd thing works only if the dragged data object describes shell items, the IDropSource thing works for any dragged data. HTH Timo -- www.TimoSoft-Software.de - Unicode controls for VB6 "Those who sacrifice freedom for safety deserve neither."

1 0

Re: winecfg: values list should be NULL-terminated.
by Paul Chitescu Aug. 6, 2007

Aug. 6, 2007

Great, thanks! Paul On Mon, 6 Aug 2007, Kirill K. Smirnov wrote: > This fixes winecfg crash caused by recent winecfg changes.

1 0

Re: wine.inf: Remove RelayFromExclude. It hides the real call traces which makes nearly useless relay logs. [resend]
by Alexandre Julliard Aug. 6, 2007

Aug. 6, 2007

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > Resend. Anything wrong with this patch? > > After this change went in, it became impossible to see what functions was > being called where and how inside Wine to understand what is happening. If > any one looks at the bugzilla and all of the reported +relay logs they are > 100% useless in determining the real cause of the problem. It wasn't the > case before without RelayFromExclude. In most cases it makes the trace much more readable and manageable. If you want to know what's going on inside Wine code there are better debug channels to use than relay. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32 - set_active_window uses SendMessage instead of PostMessage for WM_ACTIVATEAPP messages.
by Vitaliy Margolen Aug. 5, 2007

Aug. 5, 2007

Peter Dons Tychsen wrote: > Hello Wine. > > On original Windows, the messages WM_ACTIVATEAPP are sent using > PostMessage() and not SendMessage() like in the current Wine > implementation. > > I have thoroughly verified that this is the case on Windows-XP (that it > uses PostMessage()). > > This error can lead to fatal focusing problems, as some programs call > more focus related functions when they receive this message. This leads > to recursive calls into set_active_calls. It does not crash, but leads > to unexpected results such as lost focus for mouse and keyboard. > > This fixes the focus for the game "Wild Metal" if you switch focus from > the game to the desktop, and then back again. > > http://www.rockstargames.com/classics/ > > Cheers, > > /Pedro > > This patch makes 45 msg.c tests in user32 fail for me. Could you double check your findings? Also when you say "thoroughly verified" have you used Wine tests or your own program? Vitaliy

4 9

Re: wined3d: Use a safer, more compliant method to parse extension strings
by Vitaliy Margolen Aug. 5, 2007

Aug. 5, 2007

Chris Robinson wrote: > > + > + /* End */ > + {NULL, 0} > }; [..] > - for (i = 0; i < (sizeof(EXTENSION_MAP) / sizeof(*EXTENSION_MAP)); ++i) { > + for (i = 0; EXTENSION_MAP[i].extension_string; ++i) { What was the reason for this change? It's a static const array why do you want to treat it as a dynamically sized one? Vitaliy.

2 1

Re: [1/5] D3D9: Deal with failing surface creation
by H. Verbeet Aug. 5, 2007

Aug. 5, 2007

On 03/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + ok(SUCCEEDED(hr) || hr == D3DERR_INVALIDCALL, "IDirect3DDevice9_CreateTexture: %s\n", DXGetErrorString9(hr)); Same comment as for yesterday's test (even though that one apparently made it in), I don't think that's a useful test. As the patch comment says, the point of the test isn't to test CreateTexture behaviour.

2 1

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice
by Vitaliy Margolen Aug. 5, 2007

Aug. 5, 2007

Peter Dons Tychsen wrote: > OK. Please review this diff: > > I will re-submit it if you like it. > > /Pedro Alright looks good now (you might want to remove the extra white space your patch adds - git complains about those). Just left to make the same change to the other joystick interface :) BTW don't forget to cc: the wine-devel list when you replying. Vitaliy.

3 11

[winetest] Show missing tests in single/group results
by Paul Vriens Aug. 5, 2007

Aug. 5, 2007

Hi, Before sending this to wine-patches I would like people to have a look first. I've added as many screenshots as I thought where needed to show the changes (so sorry in advance for the flood of pictures). This patch makes sure that missing tests are shown in the test results, both when there is only one system in a group (f.e. Win98) or multiple systems in a group. 'single_test_before' shows that currently we have a single '.' where a test is missing (without a link obviously or explanation). 'main_summary_before' shows the same '.' but now we have 2 systems in the group. This means there is a link to the group overview. 'group_overview_before' shows nothing for these particular tests (gdiplus). Now with the new output: 'single_test_after' still show the '.' but now it's marked todo (and a skip border as these tests are skipped). 'failing_test_single_onmouseover' shows at least some explanation. 'main_summary_after' is still the same with this new version (there is a link to the group overview). 'group_overview_after' shows that now the group overview correctly shows the missing tests and 'failing_test_onmouseover' shows some explanation. Remember that this is still without winetest producing output about missing dll's. Next patches will: - add a missing dll as one of the reasons for missing tests - add some better clue's on the main summary for multiple systems in a group (not a single '.' but maybe the same 'failed and skipped'). One of the thoughts I had was to replace the '.' with a '?' in case of missing tests for an unknown reason but I'm not sure about that yet. Comments/remarks etc.. are welcome. I'd also like to hear about other idea's for this page to make it useful for everybody. Apart from the fact that we probably should have more exposure to the fact that we have such a page/tool. We saw an immediate rise (slowed down again) in test results as soon as winetest was mentioned on 'http://tweakers.net/meuktracker/15817/Wine-0.9.42.html' (in Dutch). There it was also mentioned that some machines crashed because of the tests etc.. (maybe a wine-winetest component on bugzilla could help with that which we could reference on the main test.winehq.org/data/*/index.html page). Cheers, Paul.

1 0

Re: [PATCH] winecfg: Fix crash caused by calling set_reg_key with NULL value
by Evan Stade Aug. 4, 2007

Aug. 4, 2007

On 8/3/07, Nigel Liang <ncliang(a)gmail.com> wrote: > diff --git a/programs/winecfg/winecfg.c b/programs/winecfg/winecfg.c > index 84dd4c8..05f322c 100644 > --- a/programs/winecfg/winecfg.c > +++ b/programs/winecfg/winecfg.c > @@ -468,11 +468,15 @@ void set_reg_key(HKEY root, const char * > > wpath = HeapAlloc(GetProcessHeap(), 0, (strlen(path)+1)*sizeof(WCHAR)); > wname = HeapAlloc(GetProcessHeap(), 0, (strlen(name)+1)*sizeof(WCHAR)); > - wvalue = HeapAlloc(GetProcessHeap(), 0, (strlen(value)+1)*sizeof(WCHAR)); > > MultiByteToWideChar(CP_ACP, 0, path, -1, wpath, strlen(path)+1); > MultiByteToWideChar(CP_ACP, 0, name, -1, wname, strlen(name)+1); > - MultiByteToWideChar(CP_ACP, 0, value, -1, wvalue, strlen(value)+1); > + > + if (value) > + { > + wvalue = HeapAlloc(GetProcessHeap(), 0, (strlen(value)+1)*sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, value, -1, wvalue, strlen(value)+1); > + } > > set_reg_key_ex(root, wpath, wname, wvalue, REG_SZ); > > -- > 1.4.1 > > > > You need to initialize wvalue to NULL -- Evan Stade

2 2

Sent a patch twice
by Rene Kok Aug. 4, 2007

Aug. 4, 2007

I never submitted a patch before. It wasn't a patch I created just resubmitting it. However I accidentally sent it to the wine-patches mailing list twice. The first time I wasn't subscribed, which I prefer not to because the huge amount of mail I'll get when I do :-) I subscribed and sent it again and now it's in there twice, oops! Anyway hope it's ok.

2 1

Re: mshtml: Remove const in front of REFIID as that is a macro that already starts with const.
by Andrew Talbot Aug. 4, 2007

Aug. 4, 2007

Michael Stefaniuc wrote: > Jacek, > > I'm not sure about this patch. gcc 3.1.1 produced a warning about a > double const. The rules of what is const depending on where in the > declaration it is placed are mind bongling (especially at 1am) and I > don't know what the intention was here so please review. > > -static const REFIID tid_ids[] = { > +static REFIID tid_ids[] = { > &IID_IHTMLWindow2 > }; > It would be easier if one were obliged to always put const (and volatile) qualifiers to the right of what they qualify, then the whole declaration would read from right to left. Thus, here, char const * const *p; p is a pointer to a constant pointer to a constant char. The almost-universally adopted convention of putting the left-most qualifer on the left of the type it qualifies, as in const char *ch; rather than the equivalent char const *ch; rather spoils this flow. Here, static const REFIID tid_ids[]; could be rewritten static REFIID const tid_ids[]; And REFIID in a C setting is defined as: const GUID * __MIDL_CONST (where __MIDL_CONST is "const", if rpcproxy.h has not been included). So, in case anyone is still awake and interested: static const REFIID tid_ids[]; is equivalent to static const GUID *const const tid_ids[]; (Note the erroneous double const.) or static GUID const *const const tid_ids[]; as I would prefer to put it. So, to conclude, you don't want the extra const, and it may not have been the const you thought it was, either. :) -- Andy.

1 1

Bug introduced in 0.9.42 in printer dialog
by Christian Pradelli Aug. 4, 2007

Aug. 4, 2007

A bug was introduced in version 0.9.42, that makes printer dialogs to not work. When you press Accept button in the printer dialog the I receive the followin error: fixme:commdlg:PRINTDLG_UpdatePrintDlgA No lpdm ptr? fixme:commdlg:PRINTDLG_WMCommandA Update printdlg was not successful! Should I post to bugzilla? Regards Christian c_pradelli(a)yahoo.com

2 1

Re: [PATCH] wined3d: Pass correct coord parameter to texture*DProj functions
by H. Verbeet Aug. 4, 2007

Aug. 4, 2007

On 04/08/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > --- > dlls/wined3d/glsl_shader.c | 9 +++++++++ > 1 files changed, 9 insertions(+), 0 deletions(-) > This patch is plain wrong. The caller of shader_glsl_get_sample_function() is responsible for correctly adding the correct component for projected lookups, since that isn't always the "next" component, but in fact depends on the instruction that does the sampling. Of course if the author of this patch had actually read the source for the callers of shader_glsl_get_sample_function() (pshader_glsl_tex() in particular...) or alternatively had been familiar with D3D shader assembly, he would have known that. It does make me wonder though, particularly given the lack of any explanation for the patch, if this is actually supposed to fix anything?

1 0

Re: netapi32: Add lmuseflg.h and include it from lmuse.h.
by Kai Blin Aug. 4, 2007

Aug. 4, 2007

On Saturday 04 August 2007 03:20:00 Francois Gouget wrote: > +/* > + * Copyright (C) the Wine project I think you need a year in the copyright statement. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: Nigel Liang : winecfg: Read/write registry in unicode.
by James Hawkins Aug. 3, 2007

Aug. 3, 2007

On 8/3/07, Alexandre Julliard <julliard(a)wine.codeweavers.com> wrote: > Module: wine > Branch: master > Commit: 2d5a89bab087d09f3e3876e29ae32a2e863273fe > URL: http://source.winehq.org/git/wine.git/?a=commit;h=2d5a89bab087d09f3e3876e29… > > Author: Nigel Liang <ncliang(a)gmail.com> > Date: Thu Aug 2 16:33:24 2007 -0700 > > winecfg: Read/write registry in unicode. > This patch breaks setting the windows version in winecfg (and I assume everything else that uses the registry): jhawkins(a)sphere2:~$ winecfg wine: Unhandled page fault on read access to 0x00000000 at address 0x7e5859d7 (thread 0010), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x7e5859d7). Register dump: CS:0023 SS:002b DS:002b ES:002b FS:0063 GS:006b EIP:7e5859d7 ESP:0033e2f0 EBP:0033e328 EFLAGS:00010246( - 00 -RIZP1) EAX:00000000 EBX:7e58d9e4 ECX:ffffffff EDX:00000000 ESI:7e587b60 EDI:00000000 Stack dump: 0x0033e2f0: 00110000 00000000 0000001c 0000000b 0x0033e300: 0016cdf8 0000000b 00000054 001727f8 0x0033e310: 0000001c 00172858 0016cdf8 7e58d9e4 0x0033e320: 7e587b60 7e587ac2 0033efd8 7e578877 0x0033e330: 80000002 7e587b60 7e587ab4 00000000 0x0033e340: 00000001 00000073 0033e398 7e1d19a7 Backtrace: =>1 0x7e5859d7 set_reg_key+0x8f(root=0x80000002, path=0x7e587b60, name=0x7e587ab4, value=0x0) [/home/jhawkins/wine/programs/winecfg/winecfg.c:471] in winecfg (0x0033e328) -- James Hawkins

2 1

Re: gdi32: don't print fixme more than once
by Robert Shearman Aug. 3, 2007

Aug. 3, 2007

Evan Stade wrote: > diff --git a/dlls/gdi32/enhmetafile.c b/dlls/gdi32/enhmetafile.c > index 9e7684b..2b4d03f 100644 > --- a/dlls/gdi32/enhmetafile.c > +++ b/dlls/gdi32/enhmetafile.c > @@ -1172,6 +1172,7 @@ BOOL WINAPI PlayEnhMetaFileRecord( > > case EMR_EXTSELECTCLIPRGN: > { > + static int extselectcliprgn_cases; > #if 0 > const EMREXTSELECTCLIPRGN lpRgn = (const EMREXTSELECTCLIPRGN *)mr; > HRGN hRgn = ExtCreateRegion(NULL, lpRgn->cbRgnData, (RGNDATA *)lpRgn->RgnData); > @@ -1180,7 +1181,8 @@ #if 0 > /* ExtSelectClipRgn created a copy of the region */ > DeleteObject(hRgn); > #endif > - FIXME("ExtSelectClipRgn\n"); > + if(!(extselectcliprgn_cases++)) > + FIXME("ExtSelectClipRgn\n"); > break; > } > It would be better to re-enable this code, remove the fixme and fix whatever bug caused it to be disabled in the first place than to not show the fixme as often. -- Rob Shearman

1 0

Re: [4/5] WineD3D: WINED3DSAMP_MAXMIPLEVEL fixes
by H. Verbeet Aug. 3, 2007

Aug. 3, 2007

You are now executing that code multiple times.

2 1

Re: Lostwages : contributing.diff
by Jeremy White Aug. 3, 2007

Aug. 3, 2007

Hi Tom, Thanks for thinking of this; I think James would appreciate it if he wasn't listed by name, though. Otherwise, though, it looks great. Cheers, Jeremy Tom Wickline wrote: > Hello, > > I'm CC: Jeremy White in on this patch, if possible I would like to ask > for his approval on the patch before its committed. > > About the patch: > I Changed the mailing address of the WPF to point to the Software > Freedom Conservancy, and added some info about it being a 501(c)(3) > organization. > > Cheers, > > Tom > > Changelog: update WPF information and mailing address > > > ------------------------------------------------------------------------ > > Index: en/contributing.template > =================================================================== > RCS file: /home/wine/lostwages/templates/en/contributing.template,v > retrieving revision 1.33 > diff -u -r1.33 contributing.template > --- en/contributing.template 21 Jun 2007 20:21:46 -0000 1.33 > +++ en/contributing.template 31 Jul 2007 02:55:13 -0000 > @@ -363,8 +363,17 @@ > <h3 id="wpf">Wine Party Fund</h3> > > <p>The purpose of the Wine Party Fund is to show appreciation to Wine > - developers by collecting funds for developer meetings, such as future Wine > - Conferences, or in some cases to purchase documentation.</p> > +developers by collecting funds for developer meetings, such as future > +Wine Conferences, or in some cases to purchase documentation.</p> > + > +<p>The organization that currently manages our donations is the > +<a href="http://conservancy.softwarefreedom.org/">Software Freedom > +Conservancy</a>. If you have any questions or are otherwise in need > +of further assistance please visit the SFC site.</p> > + > +<p>The Software Freedom Conservancy is a 501(c)(3) organization, and > +donations made through it are fully tax-deductible to the extent > +permitted by law.</p> > <p><strong>Ways to contribute:</strong></p> > <form action="https://www.paypal.com/cgi-bin/webscr" method="post"> > <div> > @@ -379,13 +388,12 @@ > <p>We also have a SourceForge PayPal account > <a href="http://sourceforge.net/donate/index.php?group_id=6241">sourceforge.net</a></p> > > -<p>You can also send cash, checks or international money order in US funds to:</p> > -<address>The Wine Party Fund > -c/o Jeremy White > -CodeWeavers > -2356 University Ave. West > -Suite 420 > -St. Paul, MN 55114</address> > +<p>You can also send cash, cheque or international money order in US funds to:</p> > +<address>Wine Project > +c/o James Vasille > +Software Freedom Conservancy > +1995 Broadway FL 17 > +New York, NY 10023-5882</address> > <p>Purchase books or music from <a href="http://www.amazon.com/exec/obidos/redirect-home/winehq"> > Amazon.com</a> or <a href="http://www.cdnow.com/from=sr-1093221">CDnow</a> (Use > these specific links only, so that the Wine Party Fund gets the credit.)</p>

1 0

[Fwd: [winetest] New gather script]
by Paul Vriens Aug. 3, 2007

Aug. 3, 2007

Hi, Forgot to include wine-devel. -------- Original Message -------- Subject: [winetest] New gather script Hi Ferenc, Could you have a look at the new 'gather' script? (you're the original author after all). The new winetest (when committed of course) executable will report when a test is missing because of a failing dll. I've severely changed/mutilated 'gather' so: - it finds these missing dll tests and marks them - doesn't add these to the overall list of tests - goes through the whole list of tests to find out if (and why) tests are missing - it now shows also complete failing tests (for the group) in the group overview - add some extra onMouseOver on both group and single tests. - make sure we always show missing tests in the group overview. The new variables: $test->{dllmissing}->{$dll} (shows if a system/test is missing a dll) $group->{dllmissing}->{$unit} (tells if at least one system in the group is missing this dll, used for having a nice onMouseOver in the Main Summary) $group->{testmissing}->{$testname} (tells if at least one system in the group has a missing test for an unknown reason, needed to cope with the same onMouseOver as mentioned above). I'll split it up in smaller chunks when sent to wine-patches. Cheers, Paul. Index: gather =================================================================== RCS file: /home/wine/tools/winetest/gather,v retrieving revision 1.20 diff -u -r1.20 gather --- gather 13 Mar 2007 16:10:46 -0000 1.20 +++ gather 3 Aug 2007 07:28:36 -0000 @@ -96,9 +96,19 @@ my ($digest, $unit, $test, $count, $todo, $error, $skipped, $source, $rev) = split; my $testname = "$unit:$test"; + if ($test =~ /_dll_missing/) { + # Mark this dll as being missing on one or more systems + + # For this run on this system + $testref->{dllmissing}->{$unit} = "This dll is missing on this system"; + # For the whole group + $group->{dllmissing}->{$unit} = "This dll is missing for some tests"; + } + else { + $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") + unless exists $alltests{$testname}; + } $testref->{results}->{$testname} = [$count, $todo, $error, $skipped]; - $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") - unless exists $alltests{$testname}; if ($count ne "failed") { if (defined $group->{extrema}->{$testname}) { my $extrema = $group->{extrema}->{$testname}; @@ -117,6 +127,28 @@ push @{$group->{tests}}, $testref; } +# Find missing tests and/or missing dlls and mark them +foreach my $group (@groups) { + next unless exists $group->{tests}; + foreach my $testname (sort keys %alltests) { + foreach my $test (@{$group->{tests}}) { + if (!exists $test->{results}->{$testname}) { + # The test is missing, try to find the reason + my ($dll,$subtest) = split(/:/, $testname); + if (exists $test->{dllmissing}->{$dll}) { + $test->{results}->{$testname} = [-1, -1, -1, -1]; + $group->{digest}->{$testname} = "differ"; + } + else { + $test->{results}->{$testname} = [-2, -2, -2, -2]; + $group->{digests}->{$testname} = "differ"; + $group->{testmissing}->{$testname} = $testname; + } + } + } + } +} + # Write out the tables my ($header); # same in thead and tfoot @@ -197,28 +229,42 @@ # Output a single cell of a test sub singletest { my ($test, $testname, $groupname) = @_; - - if (!exists $test->{results}->{$testname}) { - print OUT " <td class=\"note\">.</td>\n"; + my $file = "$test->{dir}/$testname.txt"; + my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; + if ($count eq "failed") { + # test run failed + my $msg = $todo eq "-"?"crash": + $todo == 258?"timeout":"failed"; + my $fail = -r "$datadir/$build/$file"?"<a href=\"$file\">$msg</a>":$msg; + print OUT " <td class=\"note\">$fail</td>\n"; + } elsif ($count == -1) { + # dll missing + my ($dll, $subtest) = split(/:/, $testname); + print OUT <<"EOF"; + <td class="skip_pass"><a + title="No tests run as $dll.dll is not present on this system" + onMouseOver="No tests run as $dll.dll is not present on this system" + >0</a></td> +EOF + } elsif ($count == -2) { + # test missing + print OUT <<"EOF"; + <td class="skip_fail"><a + title="No tests run for an unknown reason" + onMouseOver="No tests run for an unknown reason" + >0</a></td> +EOF } else { - my $file = "$test->{dir}/$testname.txt"; - my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; - if ($count eq "failed") { - my $msg = $todo eq "-"?"crash": - $todo == 258?"timeout":"failed"; - my $fail = -r "$datadir/$build/$file"?"<a href=\"$file\">$msg</a>":$msg; - print OUT " <td class=\"note\">$fail</td>\n"; - } else { - my $class = $error?"fail":"pass"; - my $skip = $skipped?"skip_":""; - print OUT <<"EOF"; + # test has run + my $class = $error?"fail":"pass"; + my $skip = $skipped?"skip_":""; + print OUT <<"EOF"; <td class="$skip$class"><a href="$file" title="$count tests, $todo TODO, $error errors, $skipped skipped" onMouseOver="refresh('$testname','$groupname $test->{tag}',$count,$todo,$error,$skipped);" >$error</a></td> EOF - } } } @@ -236,6 +282,7 @@ } else { my $href = "href=\"#$group->{name}\""; if (exists $group->{extrema}->{$testname}) { + # At least one system in this group has run this test. my ($min,$max) = @{$group->{extrema}->{$testname}}; my $class = $min==0?($max==0?"pass":"mixed"):"fail"; my $title = $min==0?"":" title=\"Best: $min\""; @@ -246,7 +293,23 @@ >$max</a></td> EOF } else { - print OUT " <td class=\"note\"><a $href>.</a></td>\n"; + my ($dll, $subtest) = split(/:/, $testname); + if ($group->{testmissing}->{$testname}) { + # At least one system in the group has a missing test (but + # not because of a missing dll). + print OUT " <td class=\"fail\"><a $href>.</a></td>\n"; + } elsif (exists $group->{dllmissing}->{$dll}) { + # All systems in the group have a missing dll related to this test. + print OUT <<"EOF"; + <td class="pass"><a $href + title="No tests run as $dll.dll is not present on all $group->{name} systems" + onMouseOver="No tests run as $dll.dll is not present on all $group->{name} systems" + >0</a></td> +EOF + } else { + # All systems in this group failed to correctly run the test. + print OUT " <td class=\"fail\"><a $href>.</a></td>\n"; + } } } }

1 0

msvcrt40.dll
by luis.busquets＠ilidium.com Aug. 3, 2007

Aug. 3, 2007

Dear all, In relation to the file msvcrt40.dll File Version 5.1.2600.2180 Product Version 5.1.2600.2180 This file has been transformed and forwards all of its calls to either msvcrt.dll or msvcirt.dll The forwards to msvcrt.dll are set in the current wine msvcr40.spec but the rest of the functions, which should be forwarded to msvcirt, are stub. Nevertheless, msvcirt.dll is not currently one of the files to be ported, i.e., dlls/msvcirt does not exist. My questions are: 1. Can we add the forward to all the rest of the functions in the msvcrt40.dll spec file to msvcirt.dll? 2. Should we first add a wine port of msvcirt.dll? Luis

2 1

[PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.
by Misha Koshelev Aug. 2, 2007

Aug. 2, 2007

> Hi Misha, > > Misha Koshelev wrote: > > This simplifies the code a bit by getting rid of an enum and a corresponding variable in the IBinding > > implementation, as we can successfully use the bscf values that are passed to report_data to get all > > the information. > > > > Additionally, the original implementation was somewhat incorrect at least for the case of the Http protocol > > as far as sending OnStopBinding > > This patch is already accepted, but unfortunately it's wrong. Tests > changed in the attached patch succeed on native urlmon.dll and fail on > current Wine. Probably only BSCF_LASTDATANOTIFICATION flag should be > used. Other OnProgress callbacks should be called depending on the real > binding state, not the one reported by protocol handler. > > Jacek >

1 0

Re: wine3d3: Check the destination recangle when for FastBlt().
by Stefan Dösinger Aug. 2, 2007

Aug. 2, 2007

Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen: > Hello Wine! > > I have fixed a small bug in FastBlt(), which caused Wine to crash if the > application tried to do FastBlt() to a surface using a bad destination > setup. The problem is already fixed in normal Blt(), but was broken for > FastBlt(). > > This fixes a crash for the little game "Treasure Mole Winter Vacations": This check should be in ddraw, not wined3d. ddraw, d3d8 and d3d9 have different ideas about such checks, that's why the check was moved from WineD3D to the client libs. Originally it was in LockRect, and when it was moved the check was lost in Blt and BltFast. There should be a check in ddraw already, maybe it is not sufficient. Also please write a test case to verify that the fix is correct(look at dlls/ddraw/tests/dsurface.c). This will also prevent the problem from coming back. Treasure Mole broke after the ddraw rewrite because exactly this check was missing. I implemented it in LockRect, like in old ddraw, but I forgot to write a test for BltFast. Then a d3d9 game was broken because d3d9 LockRect behaved differently, a test was written for Lock(Rect) in ddraw, d3d8 and d3d9, and the range check moved to ddraw, d3d8 and d3d9 to be able to implement different checking in each version. Since I forgot to write a test when I originally fixed Treasure Mole the bug could creep back in again :-(

2 4

Re: [PATCH 2/5] urlmon: Use BSCF_ values passed to report_data to keep track of download state.
by Jacek Caban Aug. 2, 2007

Aug. 2, 2007

Hi Misha, Misha Koshelev wrote: > This simplifies the code a bit by getting rid of an enum and a corresponding variable in the IBinding > implementation, as we can successfully use the bscf values that are passed to report_data to get all > the information. > > Additionally, the original implementation was somewhat incorrect at least for the case of the Http protocol > as far as sending OnStopBinding This patch is already accepted, but unfortunately it's wrong. Tests changed in the attached patch succeed on native urlmon.dll and fail on current Wine. Probably only BSCF_LASTDATANOTIFICATION flag should be used. Other OnProgress callbacks should be called depending on the real binding state, not the one reported by protocol handler. Jacek diff --git a/dlls/urlmon/tests/url.c b/dlls/urlmon/tests/url.c index 187fb03..dcae846 100644 --- a/dlls/urlmon/tests/url.c +++ b/dlls/urlmon/tests/url.c @@ -255,6 +255,7 @@ static HRESULT WINAPI Protocol_Start(IInternetProtocol *iface, LPCWSTR szUrl, SET_EXPECT(OnDataAvailable); SET_EXPECT(OnStopBinding); + bscf = BSCF_LASTDATANOTIFICATION; hres = IInternetProtocolSink_ReportData(pOIProtSink, bscf, 13, 13); ok(hres == S_OK, "ReportData failed: %08x\n", hres);

1 0

Re: WGL: GetPixelFormat fix for offscreen formats
by Tomas Carnecky Aug. 2, 2007

Aug. 2, 2007

from the patch: return physDev->current_pf; + TRACE("(%p): returns %d\n", physDev, physDev->current_pf); } What's the purpose of that TRACE() ? tom

2 1

Is there a process for reviewing a bugzilla staffer?
by Whit Blauvelt Aug. 2, 2007

Aug. 2, 2007

Hi, Is there a formal process for reviewing an arguably incompetent bugzilla staffer? Obviously it wouldn't be to submit their name as a bug. But is there any defined administrative layer that concerns itself with people on that level who are dragging on the project? I looked around a bit for information on this. Sorry if it's posted somewhere and I missed it. Thanks, Whit

6 10

Re: [1/5] DDraw: Some drivers return DDERR_INVALIDPARAMS if DXTn surfaces aren't supported
by H. Verbeet Aug. 2, 2007

Aug. 2, 2007

On 02/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ ok(hr == DD_OK || hr == DDERR_NOTEXTUREHW || DDERR_INVALIDPARAMS, That doesn't do what you want it to do. If the return value is irrelevant though, what's the point of the test?

2 3

RE: Is there a process for reviewing a bugzilla staffer?
by EA Durbin Aug. 2, 2007

Aug. 2, 2007

I don't think we need to be rude and poke fun at new wine users by pointing out their mistakes to everyone. He may someday prove to be a valuable asset to the project, or may be driven off from contributing altogether because a dev/admin had to point out his errors for "entertainment" purposes. I don't see being rude to new users "entertainment", it comes across as being kind of a bully and deters people from contributing. We're all linux/wine newbs at some point, and telling them their posts are useless information instead of trying to help them in a friendly fashion is going to end up driving them away from the project.> Date: Wed, 1 Aug 2007 21:09:13 -0600> From: wine-devel(a)kievinfo.com> To: wine-devel(a)winehq.org> Subject: Re: Is there a process for reviewing a bugzilla staffer?> > Whit Blauvelt wrote:> > Hi,> > > > Is there a formal process for reviewing an arguably incompetent bugzilla> > staffer? Obviously it wouldn't be to submit their name as a bug. But is> > there any defined administrative layer that concerns itself with people on> > that level who are dragging on the project?> > > > I looked around a bit for information on this. Sorry if it's posted> > somewhere and I missed it.> > > > Thanks,> > Whit> > > > To spare everyone time and to skip directly to an entertainment see bug > 9147: http://bugs.winehq.org/show_bug.cgi?id=9147> > Vitaliy.> > > _________________________________________________________________ See what you’re getting into…before you go there. http://newlivehotmail.com

1 0

Re: [5/5] D3D9: Check for volume texture support before running the volume test
by H. Verbeet Aug. 2, 2007

Aug. 2, 2007

On 02/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if(!(caps.TextureCaps & D3DPTEXTURECAPS_CUBEMAP)) { That doesn't check for volume textures.

2 1

dwarf2_parse_udt_type Unhandled Tag type 0x16
by Robert Reif Aug. 2, 2007

Aug. 2, 2007

I get tons of these sometimes when a program crashes: fixme:dbghelp_dwarf:dwarf2_parse_udt_type Unhandled Tag type 0x16 at ctx(0x34ec70,L"kernel32<elf>"), for debug_info(abbrev:0x17ab04,symt:0xe24ee4) which makes debugging difficult.

1 0

re: OT: Everyone at minnesota ok?
by Dan Kegel Aug. 2, 2007

Aug. 2, 2007

I checked with Jeremy six hours ago and he said he hadn't heard of any of his folks being involved, whew. I've driven over that bridge a lot myself, and my father in law drove over it an hour before the collapse. There's a video of the collapse at http://edition.cnn.com/2007/US/08/02/bridge.collapse/

1 0

Re: mshtml #2: Make get_typeinfo thread safe.
by Alexandre Julliard Aug. 2, 2007

Aug. 2, 2007

Jacek Caban <jacek(a)codeweavers.com> writes: > } > + > + tl = InterlockedExchangePointer((void**)&typelib, tl); > + > + if(tl) > + ITypeLib_Release(tl); That's not thread-safe. You need to use InterlockedCompareExchangePointer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (no subject)
by Maarten Lankhorst Aug. 2, 2007

Aug. 2, 2007

Hello Vitaly, Vitaly Lipatov schreef: > If disk directory in dosdevices is not a link, QueryDosDevice fails on the > drive. > > Changelog: > Check QueryDosDevice return code Please add a shortlog in the message subject next time, so that I know what the patch does and what component it changes without reading the message. Cheers, Maarten

1 0

OT: Everyone at minnesota ok?
by Shachar Shemesh Aug. 2, 2007

Aug. 2, 2007

For those who have not head, there was a lethal bridge collapse and there are several casualties. Codeweavers is located near there. Just wanted to make sure everyone is ok. Shachar

1 0

Re: dinput: fix joystick axis remapping
by Vitaliy Margolen Aug. 1, 2007

Aug. 1, 2007

Erik Inge Bolsø wrote: > Without this, joystick axis remapping from the Wine registry, > as documented on http://wiki.winehq.org/UsefulRegistryKeys, > does not work in Star Wars Galaxies. > --- > - inst_id = DIDFT_MAKEINSTANCE(jse.number) | (number < 8 ? DIDFT_ABSAXIS : DIDFT_POV); > + inst_id = DIDFT_MAKEINSTANCE(number) | (number < 8 ? DIDFT_ABSAXIS : DIDFT_POV); Nice catch! Indeed it does fix the problem. Vitaliy.

1 0

(win16) simple CreateBitmapIndirect() fails on Windows? 2nd try
by Jennifer Lai Aug. 1, 2007

Aug. 1, 2007

Hi, As I was writing tests for win16, I encountered the problem that even the simplest case of CreateBitmapIndirect fails on Windows? However, it succeeds with desired properties set on Wine. I used Open Watcom as well as MS Visual C++ Version 1.52 to compile these win16 tests. OpenWatcom can be downloaded for free here: http://www.openwatcom.org/index.php/Download The following commands are used to compile the test using Open Watcom. wcc -D_X86_ -DSTANDALONE bitmapIndirect.c -i=C:\WATCOM\h\win;C:\WATCOM\h -w4 -e25 -zq -od -d2 -bt=windows wlink file bitmapIndirect.obj This seems very mysterious to me. I'd really appreciate for any comments. Jennifer

2 1

(win16) simple CreateBitmapIndirect() fails on Windows?
by Jennifer Lai Aug. 1, 2007

Aug. 1, 2007

Hi, As I was writing tests for win16, I encountered the problem that even the simplest case of CreateBitmapIndirect fails on Windows? However, it succeeds with desired properties set on Wine. I used Open Watcom as well as MS Visual C++ Version 1.52 to compile these win16 tests. OpenWatcom can be downloaded for free here: http://www.openwatcom.org/index.php/Download The following commands are used to compile the test using Open Watcom. wcc -D_X86_ -DSTANDALONE bitmapIndirect.c -i=C:\WATCOM\h\win;C:\WATCOM\h -w4 -e25 -zq -od -d2 -bt=windows wlink file bitmapIndirect.obj This seems very mysterious to me. I'd really appreciate for any comments. Jennifer

1 0

Re: WGL: fix wglChoosePixelFormatARB behavior [attempt 2]
by Roderick Colenbrander Aug. 1, 2007

Aug. 1, 2007

Don't apply this one yet as noted by Chris Robinson it isn't fully correct yet. Roderick On Wednesday 01 August 2007 22:22, Roderick Colenbrander wrote: > Hi, > > According to the specs wglChoosePixelFormatARB returns the number of > matching pixelformats. This number can be different than the size of the > return buffer which is given by nFormats. > > Unfortunately glXChooseFBConfig doesn't return all formats when NULL is > passed for the attributes. This is due to some default settings not being 0 > or 'Don't care'. This required changes to ConvertAttribWGLtoGLX. > > Regards, > Roderick Colenbrander

1 0

EVE Regression?
by Stephan Rose Aug. 1, 2007

Aug. 1, 2007

Starting with wine 0.9.42 I continuously get the following error trying to start EVE: fixme:d3d_draw:drawPrimitive Using software emulation because not all material properties could be tracked And I just get a black screen for the login screen and it'll just sit there forever like that. The error keeps being reported over and over until I close the window. Everything worked very well with 0.9.41 Any thoughts? Anything I can do? Thanks, Stephan

2 1

Re: WGL: fix wglChoosePixelFormatARB behavior
by Roderick Colenbrander Aug. 1, 2007

Aug. 1, 2007

Ignore this patch. I'll write a better version. Roderick On Wednesday 01 August 2007 19:54, Roderick Colenbrander wrote: > Hi, > > According to the specs wglChoosePixelFormatARB returns the number of > matching pixelformats. This number can be different than the size of the > return buffer which is given by nFormats. > > This bug wasn't bad before but that was because we only offered 1 > pixelformat for onscreen and offscreen rendering. > > Regards, > Roderick Colenbrander

1 0

Re: mshtml #2: Added HTMLWindow's IDispatch methods implementation.
by Robert Shearman Aug. 1, 2007

Aug. 1, 2007

Jacek Caban wrote: > static HRESULT WINAPI HTMLWindow2_item(IHTMLWindow2 *iface, VARIANT *pvarIndex, VARIANT *pvarResult) > diff --git a/dlls/mshtml/main.c b/dlls/mshtml/main.c > index 3f8131c..41f32eb 100644 > --- a/dlls/mshtml/main.c > +++ b/dlls/mshtml/main.c > @@ -51,10 +51,52 @@ DWORD mshtml_tls = 0; > > static HINSTANCE shdoclc = NULL; > > +static ITypeLib *typelib; > +static ITypeInfo *typeinfos[LAST_tid]; > + > +static const REFIID tid_ids[] = { > + &IID_IHTMLWindow2 > +}; > + > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + hres = LoadRegTypeLib(&LIBID_MSHTML, 4, 0, LOCALE_SYSTEM_DEFAULT, &typelib); > This isn't thread-safe. > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + } > + > + if(!typeinfos[tid]) { > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], typeinfos+tid); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + } > Why not just use the IID instead of an enumeration here? I know you're trying to cache the typeinfo here, but the current implementation of typelibs makes ITypeLib_GetTypeInfoOfGuid very cheap. > + > + *typeinfo = typeinfos[tid]; > + return S_OK; > +} > + > static void thread_detach(void) > { > - thread_data_t *thread_data = get_thread_data(FALSE); > + thread_data_t *thread_data; > + > + if(typelib) { > + unsigned i; > + > + for(i=0; i < sizeof(typeinfos)/sizeof(*typeinfos); i++) > + if(typeinfos[i]) > + ITypeInfo_Release(typeinfos[i]); > + > + ITypeLib_Release(typelib); > + } > Why are you doing this from DLL_THREAD_DETACH and not DLL_PROCESS_DETACH? -- Rob Shearman

2 1

New winetest skipping test for nonexistent dll's
by Paul Vriens Aug. 1, 2007

Aug. 1, 2007

Hi, I've been busy trying to come up with a solution and attached you will find 2 patches. One for 'winetest that will make sure we have specific output for dll's that are not on the system. I have made the output as close to normal test output as possible, so we don't have to patch dissect (the tool that dissects the reports). One for 'gather', the tool that translates the reports into a nice html page. There will be (in contrast with the other skip's) no visibility in the group reports yet. I'll have to figure out how to do that nicely. For now I'm assuming that if one system doesn't have a dll, all the others (same platform) don't have it at well (I know bad assumption and it will be dealt with in next revisions). (I do have another version of 'gather' which deals with the group reports but shows the whole test for all systems (same platform of course) if one or more systems have a missing dll). If we pursue this then we probably also need to change old tests as that will mean we can strip a lot of code from the tests. Comments/remarks etc.. are welcome. Cheers, Paul. diff --git a/programs/winetest/main.c b/programs/winetest/main.c index f743ffc..3c4846d 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -433,6 +433,24 @@ extract_test_proc (HMODULE hModule, LPCTSTR lpszType, LPTSTR lpszName, LONG_PTR lParam) { const char *tempdir = (const char *)lParam; + char dllname[MAX_PATH]; + HMODULE dll; + + /* Check if the main dll is present on this system */ + strcpy(dllname, lpszName); + *strstr(dllname, "_TEST.EXE") = 0; + + dll = LoadLibrary(dllname); + if (!dll) { + /* Here we add some information to the results file + * that indicates that the dll is not present + * on this platform. + */ + report (R_WARNING, "dll : %s is not present", dllname); + return TRUE; + } + FreeLibrary(dll); + get_subtests( tempdir, &wine_tests[nr_of_files], lpszName ); nr_of_tests += wine_tests[nr_of_files].subtest_count; nr_of_files++; Index: gather =================================================================== RCS file: /home/wine/tools/winetest/gather,v retrieving revision 1.20 diff -u -r1.20 gather --- gather 13 Mar 2007 16:10:46 -0000 1.20 +++ gather 1 Aug 2007 16:27:19 -0000 @@ -96,6 +96,9 @@ my ($digest, $unit, $test, $count, $todo, $error, $skipped, $source, $rev) = split; my $testname = "$unit:$test"; + if ($test =~ /_dll_missing/) { + $testref->{dll}->{$unit} = "missing"; + } $testref->{results}->{$testname} = [$count, $todo, $error, $skipped]; $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") unless exists $alltests{$testname}; @@ -199,7 +202,18 @@ my ($test, $testname, $groupname) = @_; if (!exists $test->{results}->{$testname}) { - print OUT " <td class=\"note\">.</td>\n"; + my ($unit1, $test1) = split(/:/, $testname); + my $dll = $test->{dll}->{$unit1}; + if ((defined $dll) && ($dll eq "missing")) { + print OUT <<"EOF"; + <td class="skip_pass"><a + title="No tests run as $unit1.dll is not present on this system" + onMouseOver="No tests run as $unit1.dll is not present on this system" + >0</a></td> +EOF + } else { + print OUT " <td class=\"note\">.</td>\n"; + } } else { my $file = "$test->{dir}/$testname.txt"; my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; @@ -223,6 +237,8 @@ } foreach my $testname (sort keys %alltests) { + next unless $testname !~ /_dll_missing/; + print OUT <<"EOF"; <tr> <td class="test"> @@ -290,6 +306,7 @@ <tbody onDblClick="clone();"> EOF foreach my $testname (sort keys %alltests) { # skip identical + next unless $testname !~ /_dll_missing/; my $digest = $group->{digests}->{$testname}; next unless defined $digest && $digest eq "differ"; print OUT <<"EOF";

2 1

Re: Add winhttp.dll.
by Vijay Kiran Kamuju Aug. 1, 2007

Aug. 1, 2007

Hi Jacek, I think you can use the header I sent a while back to wine-patches for this. http://www.winehq.org/pipermail/wine-patches/2005-September/020901.html The original patch: http://www.winehq.org/pipermail/wine-patches/attachments/20050923/790dfab2/… This might require some re-work. It was rejected at that time, when I wanted to add winhttp.dll It might be of some help to you. Thanks, VJ

2 1

RPC questions
by Kai Blin Aug. 1, 2007

Aug. 1, 2007

Hi folks, I will be getting into working on RPC soonish, and some of that I'd like to use for Wine. However, I don't know my way around that code so far, what would be a good starting point to tackle this? My goal is to set up a daemon that will take care of remote named pipes over smb and all of that stuff, while all that Wine needs to do is to access this daemon talking DCE-RPC. As we probably don't need to link anything, we will be able to use that daemon for other jobs, like doing netapi32 calls, etc. Where would I get started for this? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.
by Paul Vriens Aug. 1, 2007

Aug. 1, 2007

Hans Leidekker wrote: > These APIs were introduced with Vista. > > -Hans > > Changelog > Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime. > > > ------------------------------------------------------------------------ > > Hi Hans, I was going through some test failures (already sent a patch for missing defines). It appears that a lot of the used strings, like "System Up Time" is depending on the locale. Some Dutch tests show "Systeem ingeschakeld" instead. Any idea how to fix that? Another thing is that "pdh.dll" is not by default present on NT4 and below so the tests have to be changed to cope with that as well. Should I have a go at that? Cheers, Paul.

3 10

32bit winelib builds in x86_64
by Michael Ost Aug. 1, 2007

Aug. 1, 2007

What's the command for building a 32bit winelib .dll.so and .exe.so with wineg++ in an x86_64 environment? I am used to doing dlls with: $ wineg++ -shared DLL.spec -o DLL.dll.so ... and exes with: $ wineg++ -o APP.exe.so ... Seems I need to use "-m32" for g++, "--32" for as, and "-m elf_i386" for ld. But with all the nested calls of wineg++ and winebuild I can't figure out how to get those options passed in everywhere they are needed. Any hints? Cheers... Michael Ost

2 1

Re: Implement LockWorkstation using xdg-screensaver from explorer
by Alexandre Julliard Aug. 1, 2007

Aug. 1, 2007

"Steven Edwards" <winehacker(a)gmail.com> writes: > This time in explorer.... > > With this patch, Process Explorer no longer crashes when locking the > workstation from within the application. If xdg-screensaver is not > present on the system, explorer simply returns in which case > LockWorkstion thinks it still succeeded. I still like the idea of > having our own screensaver for Desktop mode and running that when > LockWorkstation is called. If this is accepted then I will either add > a check for desktop mode to avoid the call to xdg-screensaver or write > a wine scr that only runs in Desktop mode. To be able to do that you need to send the request to the existing explorer process, not start a new one. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [4/4] winex11.drv: draw custom dashes [try2]
by Evan Stade July 31, 2007

July 31, 2007

On 7/30/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > [try2] > * matched braces style of rest of file > * spread code out to make it more readable > * simplified use of gdi_to_x11_dashes > > dlls/winex11.drv/graphics.c | 3 + > dlls/winex11.drv/pen.c | 123 +++++++++++++++++++++++++++++++++++++++++-- > dlls/winex11.drv/x11drv.h | 1 > 3 files changed, 120 insertions(+), 7 deletions(-) > > -- > Evan Stade > > I am not sure how to make this patch more amenable. The gdi_to_x11_dashes function is indeed a bit unwieldy but it doesn't have all that simple a task. Does anyone have some suggestions on how to make it more acceptable? -- Evan Stade

1 0