August 2007 - Wine-Devel - list.winehq.org

Is there a process for reviewing a bugzilla staffer?
by Whit Blauvelt Aug. 2, 2007

Aug. 2, 2007

Hi, Is there a formal process for reviewing an arguably incompetent bugzilla staffer? Obviously it wouldn't be to submit their name as a bug. But is there any defined administrative layer that concerns itself with people on that level who are dragging on the project? I looked around a bit for information on this. Sorry if it's posted somewhere and I missed it. Thanks, Whit

6 10

Re: [1/5] DDraw: Some drivers return DDERR_INVALIDPARAMS if DXTn surfaces aren't supported
by H. Verbeet Aug. 2, 2007

Aug. 2, 2007

On 02/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: >+ ok(hr == DD_OK || hr == DDERR_NOTEXTUREHW || DDERR_INVALIDPARAMS, That doesn't do what you want it to do. If the return value is irrelevant though, what's the point of the test?

2 3

RE: Is there a process for reviewing a bugzilla staffer?
by EA Durbin Aug. 2, 2007

Aug. 2, 2007

I don't think we need to be rude and poke fun at new wine users by pointing out their mistakes to everyone. He may someday prove to be a valuable asset to the project, or may be driven off from contributing altogether because a dev/admin had to point out his errors for "entertainment" purposes. I don't see being rude to new users "entertainment", it comes across as being kind of a bully and deters people from contributing. We're all linux/wine newbs at some point, and telling them their posts are useless information instead of trying to help them in a friendly fashion is going to end up driving them away from the project.> Date: Wed, 1 Aug 2007 21:09:13 -0600> From: wine-devel(a)kievinfo.com> To: wine-devel(a)winehq.org> Subject: Re: Is there a process for reviewing a bugzilla staffer?> > Whit Blauvelt wrote:> > Hi,> > > > Is there a formal process for reviewing an arguably incompetent bugzilla> > staffer? Obviously it wouldn't be to submit their name as a bug. But is> > there any defined administrative layer that concerns itself with people on> > that level who are dragging on the project?> > > > I looked around a bit for information on this. Sorry if it's posted> > somewhere and I missed it.> > > > Thanks,> > Whit> > > > To spare everyone time and to skip directly to an entertainment see bug > 9147: http://bugs.winehq.org/show_bug.cgi?id=9147> > Vitaliy.> > > _________________________________________________________________ See what you’re getting into…before you go there. http://newlivehotmail.com

1 0

Re: [5/5] D3D9: Check for volume texture support before running the volume test
by H. Verbeet Aug. 2, 2007

Aug. 2, 2007

On 02/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + if(!(caps.TextureCaps & D3DPTEXTURECAPS_CUBEMAP)) { That doesn't check for volume textures.

2 1

dwarf2_parse_udt_type Unhandled Tag type 0x16
by Robert Reif Aug. 2, 2007

Aug. 2, 2007

I get tons of these sometimes when a program crashes: fixme:dbghelp_dwarf:dwarf2_parse_udt_type Unhandled Tag type 0x16 at ctx(0x34ec70,L"kernel32<elf>"), for debug_info(abbrev:0x17ab04,symt:0xe24ee4) which makes debugging difficult.

1 0

re: OT: Everyone at minnesota ok?
by Dan Kegel Aug. 2, 2007

Aug. 2, 2007

I checked with Jeremy six hours ago and he said he hadn't heard of any of his folks being involved, whew. I've driven over that bridge a lot myself, and my father in law drove over it an hour before the collapse. There's a video of the collapse at http://edition.cnn.com/2007/US/08/02/bridge.collapse/

1 0

Re: mshtml #2: Make get_typeinfo thread safe.
by Alexandre Julliard Aug. 2, 2007

Aug. 2, 2007

Jacek Caban <jacek(a)codeweavers.com> writes: > } > + > + tl = InterlockedExchangePointer((void**)&typelib, tl); > + > + if(tl) > + ITypeLib_Release(tl); That's not thread-safe. You need to use InterlockedCompareExchangePointer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (no subject)
by Maarten Lankhorst Aug. 2, 2007

Aug. 2, 2007

Hello Vitaly, Vitaly Lipatov schreef: > If disk directory in dosdevices is not a link, QueryDosDevice fails on the > drive. > > Changelog: > Check QueryDosDevice return code Please add a shortlog in the message subject next time, so that I know what the patch does and what component it changes without reading the message. Cheers, Maarten

1 0

OT: Everyone at minnesota ok?
by Shachar Shemesh Aug. 2, 2007

Aug. 2, 2007

For those who have not head, there was a lethal bridge collapse and there are several casualties. Codeweavers is located near there. Just wanted to make sure everyone is ok. Shachar

1 0

Re: dinput: fix joystick axis remapping
by Vitaliy Margolen Aug. 1, 2007

Aug. 1, 2007

Erik Inge Bolsø wrote: > Without this, joystick axis remapping from the Wine registry, > as documented on http://wiki.winehq.org/UsefulRegistryKeys, > does not work in Star Wars Galaxies. > --- > - inst_id = DIDFT_MAKEINSTANCE(jse.number) | (number < 8 ? DIDFT_ABSAXIS : DIDFT_POV); > + inst_id = DIDFT_MAKEINSTANCE(number) | (number < 8 ? DIDFT_ABSAXIS : DIDFT_POV); Nice catch! Indeed it does fix the problem. Vitaliy.

1 0

(win16) simple CreateBitmapIndirect() fails on Windows? 2nd try
by Jennifer Lai Aug. 1, 2007

Aug. 1, 2007

Hi, As I was writing tests for win16, I encountered the problem that even the simplest case of CreateBitmapIndirect fails on Windows? However, it succeeds with desired properties set on Wine. I used Open Watcom as well as MS Visual C++ Version 1.52 to compile these win16 tests. OpenWatcom can be downloaded for free here: http://www.openwatcom.org/index.php/Download The following commands are used to compile the test using Open Watcom. wcc -D_X86_ -DSTANDALONE bitmapIndirect.c -i=C:\WATCOM\h\win;C:\WATCOM\h -w4 -e25 -zq -od -d2 -bt=windows wlink file bitmapIndirect.obj This seems very mysterious to me. I'd really appreciate for any comments. Jennifer

2 1

(win16) simple CreateBitmapIndirect() fails on Windows?
by Jennifer Lai Aug. 1, 2007

Aug. 1, 2007

Hi, As I was writing tests for win16, I encountered the problem that even the simplest case of CreateBitmapIndirect fails on Windows? However, it succeeds with desired properties set on Wine. I used Open Watcom as well as MS Visual C++ Version 1.52 to compile these win16 tests. OpenWatcom can be downloaded for free here: http://www.openwatcom.org/index.php/Download The following commands are used to compile the test using Open Watcom. wcc -D_X86_ -DSTANDALONE bitmapIndirect.c -i=C:\WATCOM\h\win;C:\WATCOM\h -w4 -e25 -zq -od -d2 -bt=windows wlink file bitmapIndirect.obj This seems very mysterious to me. I'd really appreciate for any comments. Jennifer

1 0

Re: WGL: fix wglChoosePixelFormatARB behavior [attempt 2]
by Roderick Colenbrander Aug. 1, 2007

Aug. 1, 2007

Don't apply this one yet as noted by Chris Robinson it isn't fully correct yet. Roderick On Wednesday 01 August 2007 22:22, Roderick Colenbrander wrote: > Hi, > > According to the specs wglChoosePixelFormatARB returns the number of > matching pixelformats. This number can be different than the size of the > return buffer which is given by nFormats. > > Unfortunately glXChooseFBConfig doesn't return all formats when NULL is > passed for the attributes. This is due to some default settings not being 0 > or 'Don't care'. This required changes to ConvertAttribWGLtoGLX. > > Regards, > Roderick Colenbrander

1 0

EVE Regression?
by Stephan Rose Aug. 1, 2007

Aug. 1, 2007

Starting with wine 0.9.42 I continuously get the following error trying to start EVE: fixme:d3d_draw:drawPrimitive Using software emulation because not all material properties could be tracked And I just get a black screen for the login screen and it'll just sit there forever like that. The error keeps being reported over and over until I close the window. Everything worked very well with 0.9.41 Any thoughts? Anything I can do? Thanks, Stephan

2 1

Re: WGL: fix wglChoosePixelFormatARB behavior
by Roderick Colenbrander Aug. 1, 2007

Aug. 1, 2007

Ignore this patch. I'll write a better version. Roderick On Wednesday 01 August 2007 19:54, Roderick Colenbrander wrote: > Hi, > > According to the specs wglChoosePixelFormatARB returns the number of > matching pixelformats. This number can be different than the size of the > return buffer which is given by nFormats. > > This bug wasn't bad before but that was because we only offered 1 > pixelformat for onscreen and offscreen rendering. > > Regards, > Roderick Colenbrander

1 0

Re: mshtml #2: Added HTMLWindow's IDispatch methods implementation.
by Robert Shearman Aug. 1, 2007

Aug. 1, 2007

Jacek Caban wrote: > static HRESULT WINAPI HTMLWindow2_item(IHTMLWindow2 *iface, VARIANT *pvarIndex, VARIANT *pvarResult) > diff --git a/dlls/mshtml/main.c b/dlls/mshtml/main.c > index 3f8131c..41f32eb 100644 > --- a/dlls/mshtml/main.c > +++ b/dlls/mshtml/main.c > @@ -51,10 +51,52 @@ DWORD mshtml_tls = 0; > > static HINSTANCE shdoclc = NULL; > > +static ITypeLib *typelib; > +static ITypeInfo *typeinfos[LAST_tid]; > + > +static const REFIID tid_ids[] = { > + &IID_IHTMLWindow2 > +}; > + > +HRESULT get_typeinfo(enum tid_t tid, ITypeInfo **typeinfo) > +{ > + HRESULT hres; > + > + if(!typelib) { > + hres = LoadRegTypeLib(&LIBID_MSHTML, 4, 0, LOCALE_SYSTEM_DEFAULT, &typelib); > This isn't thread-safe. > + if(FAILED(hres)) { > + ERR("LoadRegTypeLib failed: %08x\n", hres); > + return hres; > + } > + } > + > + if(!typeinfos[tid]) { > + hres = ITypeLib_GetTypeInfoOfGuid(typelib, tid_ids[tid], typeinfos+tid); > + if(FAILED(hres)) { > + ERR("GetTypeInfoOfGuid failed: %08x\n", hres); > + return hres; > + } > + } > Why not just use the IID instead of an enumeration here? I know you're trying to cache the typeinfo here, but the current implementation of typelibs makes ITypeLib_GetTypeInfoOfGuid very cheap. > + > + *typeinfo = typeinfos[tid]; > + return S_OK; > +} > + > static void thread_detach(void) > { > - thread_data_t *thread_data = get_thread_data(FALSE); > + thread_data_t *thread_data; > + > + if(typelib) { > + unsigned i; > + > + for(i=0; i < sizeof(typeinfos)/sizeof(*typeinfos); i++) > + if(typeinfos[i]) > + ITypeInfo_Release(typeinfos[i]); > + > + ITypeLib_Release(typelib); > + } > Why are you doing this from DLL_THREAD_DETACH and not DLL_PROCESS_DETACH? -- Rob Shearman

2 1

New winetest skipping test for nonexistent dll's
by Paul Vriens Aug. 1, 2007

Aug. 1, 2007

Hi, I've been busy trying to come up with a solution and attached you will find 2 patches. One for 'winetest that will make sure we have specific output for dll's that are not on the system. I have made the output as close to normal test output as possible, so we don't have to patch dissect (the tool that dissects the reports). One for 'gather', the tool that translates the reports into a nice html page. There will be (in contrast with the other skip's) no visibility in the group reports yet. I'll have to figure out how to do that nicely. For now I'm assuming that if one system doesn't have a dll, all the others (same platform) don't have it at well (I know bad assumption and it will be dealt with in next revisions). (I do have another version of 'gather' which deals with the group reports but shows the whole test for all systems (same platform of course) if one or more systems have a missing dll). If we pursue this then we probably also need to change old tests as that will mean we can strip a lot of code from the tests. Comments/remarks etc.. are welcome. Cheers, Paul. diff --git a/programs/winetest/main.c b/programs/winetest/main.c index f743ffc..3c4846d 100644 --- a/programs/winetest/main.c +++ b/programs/winetest/main.c @@ -433,6 +433,24 @@ extract_test_proc (HMODULE hModule, LPCTSTR lpszType, LPTSTR lpszName, LONG_PTR lParam) { const char *tempdir = (const char *)lParam; + char dllname[MAX_PATH]; + HMODULE dll; + + /* Check if the main dll is present on this system */ + strcpy(dllname, lpszName); + *strstr(dllname, "_TEST.EXE") = 0; + + dll = LoadLibrary(dllname); + if (!dll) { + /* Here we add some information to the results file + * that indicates that the dll is not present + * on this platform. + */ + report (R_WARNING, "dll : %s is not present", dllname); + return TRUE; + } + FreeLibrary(dll); + get_subtests( tempdir, &wine_tests[nr_of_files], lpszName ); nr_of_tests += wine_tests[nr_of_files].subtest_count; nr_of_files++; Index: gather =================================================================== RCS file: /home/wine/tools/winetest/gather,v retrieving revision 1.20 diff -u -r1.20 gather --- gather 13 Mar 2007 16:10:46 -0000 1.20 +++ gather 1 Aug 2007 16:27:19 -0000 @@ -96,6 +96,9 @@ my ($digest, $unit, $test, $count, $todo, $error, $skipped, $source, $rev) = split; my $testname = "$unit:$test"; + if ($test =~ /_dll_missing/) { + $testref->{dll}->{$unit} = "missing"; + } $testref->{results}->{$testname} = [$count, $todo, $error, $skipped]; $alltests{$testname} = "http://cvs.winehq.org/cvsweb/wine/$source" . ($rev ne "-"?"#rev$rev":"") unless exists $alltests{$testname}; @@ -199,7 +202,18 @@ my ($test, $testname, $groupname) = @_; if (!exists $test->{results}->{$testname}) { - print OUT " <td class=\"note\">.</td>\n"; + my ($unit1, $test1) = split(/:/, $testname); + my $dll = $test->{dll}->{$unit1}; + if ((defined $dll) && ($dll eq "missing")) { + print OUT <<"EOF"; + <td class="skip_pass"><a + title="No tests run as $unit1.dll is not present on this system" + onMouseOver="No tests run as $unit1.dll is not present on this system" + >0</a></td> +EOF + } else { + print OUT " <td class=\"note\">.</td>\n"; + } } else { my $file = "$test->{dir}/$testname.txt"; my ($count, $todo, $error, $skipped) = @{$test->{results}->{$testname}}; @@ -223,6 +237,8 @@ } foreach my $testname (sort keys %alltests) { + next unless $testname !~ /_dll_missing/; + print OUT <<"EOF"; <tr> <td class="test"> @@ -290,6 +306,7 @@ <tbody onDblClick="clone();"> EOF foreach my $testname (sort keys %alltests) { # skip identical + next unless $testname !~ /_dll_missing/; my $digest = $group->{digests}->{$testname}; next unless defined $digest && $digest eq "differ"; print OUT <<"EOF";

2 1

Re: Add winhttp.dll.
by Vijay Kiran Kamuju Aug. 1, 2007

Aug. 1, 2007

Hi Jacek, I think you can use the header I sent a while back to wine-patches for this. http://www.winehq.org/pipermail/wine-patches/2005-September/020901.html The original patch: http://www.winehq.org/pipermail/wine-patches/attachments/20050923/790dfab2/… This might require some re-work. It was rejected at that time, when I wanted to add winhttp.dll It might be of some help to you. Thanks, VJ

2 1

RPC questions
by Kai Blin Aug. 1, 2007

Aug. 1, 2007

Hi folks, I will be getting into working on RPC soonish, and some of that I'd like to use for Wine. However, I don't know my way around that code so far, what would be a good starting point to tackle this? My goal is to set up a daemon that will take care of remote named pipes over smb and all of that stuff, while all that Wine needs to do is to access this daemon talking DCE-RPC. As we probably don't need to link anything, we will be able to use that daemon for other jobs, like doing netapi32 calls, etc. Where would I get started for this? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.
by Paul Vriens Aug. 1, 2007

Aug. 1, 2007

Hans Leidekker wrote: > These APIs were introduced with Vista. > > -Hans > > Changelog > Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime. > > > ------------------------------------------------------------------------ > > Hi Hans, I was going through some test failures (already sent a patch for missing defines). It appears that a lot of the used strings, like "System Up Time" is depending on the locale. Some Dutch tests show "Systeem ingeschakeld" instead. Any idea how to fix that? Another thing is that "pdh.dll" is not by default present on NT4 and below so the tests have to be changed to cope with that as well. Should I have a go at that? Cheers, Paul.

3 10

32bit winelib builds in x86_64
by Michael Ost Aug. 1, 2007

Aug. 1, 2007

What's the command for building a 32bit winelib .dll.so and .exe.so with wineg++ in an x86_64 environment? I am used to doing dlls with: $ wineg++ -shared DLL.spec -o DLL.dll.so ... and exes with: $ wineg++ -o APP.exe.so ... Seems I need to use "-m32" for g++, "--32" for as, and "-m elf_i386" for ld. But with all the nested calls of wineg++ and winebuild I can't figure out how to get those options passed in everywhere they are needed. Any hints? Cheers... Michael Ost

2 1

Re: Implement LockWorkstation using xdg-screensaver from explorer
by Alexandre Julliard Aug. 1, 2007

Aug. 1, 2007

"Steven Edwards" <winehacker(a)gmail.com> writes: > This time in explorer.... > > With this patch, Process Explorer no longer crashes when locking the > workstation from within the application. If xdg-screensaver is not > present on the system, explorer simply returns in which case > LockWorkstion thinks it still succeeded. I still like the idea of > having our own screensaver for Desktop mode and running that when > LockWorkstation is called. If this is accepted then I will either add > a check for desktop mode to avoid the call to xdg-screensaver or write > a wine scr that only runs in Desktop mode. To be able to do that you need to send the request to the existing explorer process, not start a new one. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [4/4] winex11.drv: draw custom dashes [try2]
by Evan Stade July 31, 2007

July 31, 2007

On 7/30/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > [try2] > * matched braces style of rest of file > * spread code out to make it more readable > * simplified use of gdi_to_x11_dashes > > dlls/winex11.drv/graphics.c | 3 + > dlls/winex11.drv/pen.c | 123 +++++++++++++++++++++++++++++++++++++++++-- > dlls/winex11.drv/x11drv.h | 1 > 3 files changed, 120 insertions(+), 7 deletions(-) > > -- > Evan Stade > > I am not sure how to make this patch more amenable. The gdi_to_x11_dashes function is indeed a bit unwieldy but it doesn't have all that simple a task. Does anyone have some suggestions on how to make it more acceptable? -- Evan Stade

1 0