August 2007 - Wine-Devel - list.winehq.org

dinput compile error
by Robert Reif Aug. 20, 2007

Aug. 20, 2007

make[2]: Entering directory `/home/wine/wine/dlls/dinput' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wwrite-strings -Wpointer-arith -g -O2 -o joystick_linuxinput.o joystick_linuxinput.c joystick_linuxinput.c:153: field `axes' has incomplete type joystick_linuxinput.c:154: confused by earlier errors, bailing out make[2]: *** [joystick_linuxinput.o] Error 1 make[2]: Leaving directory `/home/wine/wine/dlls/dinput' It seems struct input_absinfo is not defined.

3 3

Re: [4/5] D3D9: Some caps fixes
by H. Verbeet Aug. 20, 2007

Aug. 20, 2007

On 20/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > /* Some functionality is implemented in d3d9.dll, not wined3d.dll. Add the needed caps */ > pCaps->DevCaps2 |= D3DDEVCAPS2_CAN_STRETCHRECT_FROM_TEXTURES; You should move that to filter_caps() as well, or at the very least add it to IDirect3DDevice9Impl_GetDeviceCaps().

2 1

Re: winefile: Save font settings for registry
by Michael Stefaniuc Aug. 20, 2007

Aug. 20, 2007

Ivan Sinitsin wrote: > this is corrected patch for winefile. You want to use the explicit RegQueryValueExW and RegSetValueExW functions. bye michael > > This patch adds an opportunity to keep adjustments of a font between sessions, > if menu "Save settings on exit" is checked. > > > Changelog: > this patch add opportunity to save font option to the regestry, and load font > option from regestry in the winefile program > > > > ------------------------------------------------------------------------ > > Index: programs/winefile/winefile.c > =================================================================== > RCS file: /home/wine/wine/programs/winefile/winefile.c,v > retrieving revision 1.75 > diff -u -p -u -r1.75 winefile.c > --- programs/winefile/winefile.c 25 Oct 2006 18:31:13 -0000 1.75 > +++ programs/winefile/winefile.c 14 Jun 2007 07:22:19 -0000 > @@ -66,6 +66,20 @@ static const WCHAR reg_start_x[] = { 's' > static const WCHAR reg_start_y[] = { 's','t','a','r','t','Y','\0'}; > static const WCHAR reg_width[] = { 'w','i','d','t','h','\0'}; > static const WCHAR reg_height[] = { 'h','e','i','g','h','t','\0'}; > +static const WCHAR reg_font_height[] = { 'f','o','n','t','_','h','e','i','g','h','t','\0'}; > +static const WCHAR reg_font_width[] = { 'f','o','n','t','_','w','i','d','t','h','\0'}; > +static const WCHAR reg_font_escapement[] = { 'f','o','n','t','_','E','s','c','a','p','e','m','e','n','t','\0'}; > +static const WCHAR reg_font_orientation[] = { 'f','o','n','t','_','O','r','i','e','n','t','a','t','i','o','n','\0'}; > +static const WCHAR reg_font_weight[] = { 'f','o','n','t','_','W','e','i','g','h','t','\0'}; > +static const WCHAR reg_font_italic[] = { 'f','o','n','t','_','I','t','a','l','i','c','\0'}; > +static const WCHAR reg_font_underline[] = { 'f','o','n','t','_','U','n','d','e','r','l','i','n','e','\0'}; > +static const WCHAR reg_font_strikeout[] = { 'f','o','n','t','_','S','t','r','i','k','e','O','u','t','\0'}; > +static const WCHAR reg_font_charset[] = { 'f','o','n','t','_','C','h','a','r','S','e','t','\0'}; > +static const WCHAR reg_font_outprecision[] = { 'f','o','n','t','_','O','u','t','P','r','e','c','i','s','i','o','n','\0'}; > +static const WCHAR reg_font_clipprecision[] = { 'f','o','n','t','_','C','l','i','p','P','r','e','c','i','s','i','o','n','\0'}; > +static const WCHAR reg_font_quality[] = { 'f','o','n','t','_','Q','u','a','l','i','t','y','\0'}; > +static const WCHAR reg_font_pitchandfamily[] = { 'f','o','n','t','_','P','i','t','c','h','A','n','d','F','a','m','i','l','y','\0'}; > +static const WCHAR reg_font_facename[] = { 'f','o','n','t','_','F','a','c','e','N','a','m','e','\0'}; > > enum ENTRY_TYPE { > ET_WINDOWS, > @@ -1588,15 +1602,20 @@ static void get_path(Entry* dir, PTSTR p > > static windowOptions load_registry_settings(void) > { > - DWORD size; > + DWORD size, sizeW; > DWORD type; > HKEY hKey; > windowOptions opts; > + LOGFONT logfont; > + HFONT hFont; > > RegOpenKeyEx( HKEY_CURRENT_USER, registry_key, > 0, KEY_QUERY_VALUE, &hKey ); > > + hFont=GetStockObject(DEFAULT_GUI_FONT); > + GetObject(hFont,sizeof(logfont),&logfont); > size = sizeof(DWORD); > + sizeW = sizeof(logfont.lfFaceName); > > if( RegQueryValueEx( hKey, reg_start_x, NULL, &type, > (LPBYTE) &opts.start_x, &size ) != ERROR_SUCCESS ) > @@ -1614,8 +1633,51 @@ static windowOptions load_registry_setti > (LPBYTE) &opts.height, &size ) != ERROR_SUCCESS ) > opts.height = CW_USEDEFAULT; > > + RegQueryValueEx( hKey, reg_font_height, NULL, &type, > + (LPBYTE) &logfont.lfHeight, &size ); > + > + RegQueryValueEx( hKey, reg_font_width, NULL, &type, > + (LPBYTE) &logfont.lfWidth, &size ); > + > + RegQueryValueEx( hKey, reg_font_escapement, NULL, &type, > + (LPBYTE) &logfont.lfEscapement, &size ); > + > + RegQueryValueEx( hKey, reg_font_orientation, NULL, &type, > + (LPBYTE) &logfont.lfOrientation, &size ); > + > + RegQueryValueEx( hKey, reg_font_weight, NULL, &type, > + (LPBYTE) &logfont.lfWeight, &size ); > + > + RegQueryValueEx( hKey, reg_font_italic, NULL, &type, > + (LPBYTE) &logfont.lfItalic, &size ); > + > + RegQueryValueEx( hKey, reg_font_underline, NULL, &type, > + (LPBYTE) &logfont.lfUnderline, &size ); > + > + RegQueryValueEx( hKey, reg_font_strikeout, NULL, &type, > + (LPBYTE) &logfont.lfStrikeOut, &size ); > + > + RegQueryValueEx( hKey, reg_font_charset, NULL, &type, > + (LPBYTE) &logfont.lfCharSet, &size ); > + > + RegQueryValueEx( hKey, reg_font_outprecision, NULL, &type, > + (LPBYTE) &logfont.lfOutPrecision, &size ); > + > + RegQueryValueEx( hKey, reg_font_clipprecision, NULL, &type, > + (LPBYTE) &logfont.lfClipPrecision, &size ); > + > + RegQueryValueEx( hKey, reg_font_quality, NULL, &type, > + (LPBYTE) &logfont.lfQuality, &size ); > + > + RegQueryValueEx( hKey, reg_font_pitchandfamily, NULL, &type, > + (LPBYTE) &logfont.lfPitchAndFamily, &size ); > + > + RegQueryValueEx( hKey, reg_font_facename, NULL, &type, > + (LPBYTE) &logfont.lfFaceName, &sizeW); > + > RegCloseKey( hKey ); > > + Globals.hfont = CreateFontIndirect(&logfont); > return opts; > } > > @@ -1624,11 +1686,13 @@ static void save_registry_settings(void) > WINDOWINFO wi; > HKEY hKey; > INT width, height; > + LOGFONT logfont; > > wi.cbSize = sizeof( WINDOWINFO ); > GetWindowInfo(Globals.hMainWnd, &wi); > width = wi.rcWindow.right - wi.rcWindow.left; > height = wi.rcWindow.bottom - wi.rcWindow.top; > + GetObject(Globals.hfont, sizeof(logfont), &logfont); > > if ( RegOpenKeyEx( HKEY_CURRENT_USER, registry_key, > 0, KEY_SET_VALUE, &hKey ) != ERROR_SUCCESS ) > @@ -1651,6 +1715,34 @@ static void save_registry_settings(void) > (LPBYTE) &width, sizeof(DWORD) ); > RegSetValueEx( hKey, reg_height, 0, REG_DWORD, > (LPBYTE) &height, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_height, 0, REG_DWORD, > + (LPBYTE) &logfont.lfHeight, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_width, 0, REG_DWORD, > + (LPBYTE) &logfont.lfWidth, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_escapement, 0, REG_DWORD, > + (LPBYTE) &logfont.lfEscapement, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_orientation, 0, REG_DWORD, > + (LPBYTE) &logfont.lfOrientation, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_weight, 0, REG_DWORD, > + (LPBYTE) &logfont.lfWeight, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_italic, 0, REG_DWORD, > + (LPBYTE) &logfont.lfItalic, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_underline, 0, REG_DWORD, > + (LPBYTE) &logfont.lfUnderline, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_strikeout, 0, REG_DWORD, > + (LPBYTE) &logfont.lfStrikeOut, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_charset, 0, REG_DWORD, > + (LPBYTE) &logfont.lfCharSet, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_outprecision, 0, REG_DWORD, > + (LPBYTE) &logfont.lfOutPrecision, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_clipprecision, 0, REG_DWORD, > + (LPBYTE) &logfont.lfClipPrecision, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_quality, 0, REG_DWORD, > + (LPBYTE) &logfont.lfQuality, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_pitchandfamily, 0, REG_DWORD, > + (LPBYTE) &logfont.lfPitchAndFamily, sizeof(DWORD) ); > + RegSetValueEx( hKey, reg_font_facename, 0, REG_SZ, > + (LPBYTE) &logfont.lfFaceName,(strlenW(&logfont.lfFaceName) + 1)*sizeof(WCHAR)); > > /* TODO: Save more settings here (List vs. Detailed View, etc.) */ > RegCloseKey( hKey ); > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111

1 0

Re: comctl resource diff
by Maarten Lankhorst Aug. 20, 2007

Aug. 20, 2007

Dj Apal [GR] schreef: > Hope this is the one you want. PLease commit it! > > TIA! > ------------------------------------------------------------------------ > > --- ./dlls/comctl32/rsrc.rc 2007-08-20 19:52:26.000000000 +0300 > +++ ./dlls/comctl32/rsrc1.rc 2007-08-20 19:50:03.000000000 +0300 > @@ -1196,6 +1196,7 @@ IDI_TT_ERROR_SM ICON LOADONCALL DISCARDA > #include "comctl_Cn.rc" > #include "comctl_Cs.rc" > #include "comctl_De.rc" > +#include "comctl_El.rc" > #include "comctl_En.rc" > #include "comctl_Eo.rc" > #include "comctl_Es.rc" > I'm missing a comctl_El.rc here?

1 0

Fixing wrong prototypes in a header
by Juan Lang Aug. 20, 2007

Aug. 20, 2007

Some of the function prototypes in wintrust.h have the wrong calling convention. The trouble is, PSDK gets them wrong too. So calling the functions, as declared in the PSDK header, results in a crash in Windows. Casting them to function pointers with the correct calling convention succeeds. Should I leave the prototypes incorrect in wintrust.h to match the PSDK, or should I fix them to make them more convenient for me to use? Thanks, --Juan

2 2

Re: winmm: Change default driver order to be alsa,coreaudio,oss - try2
by Vitaliy Margolen Aug. 20, 2007

Aug. 20, 2007

Maarten Lankhorst wrote: > Forgot to remove the strlen check. > Isn't this a bit premature? ALSA still does not support proper sound capture, working mixer, and not stable enough on some configurations. Vitaliy

2 8

Re: setupapi: if needed create directories for fake dlls
by Alexandre Julliard Aug. 20, 2007

Aug. 20, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > @@ -302,9 +302,28 @@ BOOL create_fake_dll( const WCHAR *name, > else > { > h = CreateFileW( name, GENERIC_WRITE, 0, NULL, CREATE_NEW, 0, NULL ); > + > + if (h == INVALID_HANDLE_VALUE && GetLastError() == ERROR_PATH_NOT_FOUND) > + { > + WCHAR *pathel; > + > + /* create the directory/directories */ > + pathel = strchrW(name, '\\'); > + while (pathel != NULL) > + { > + *pathel = 0; You shouldn't write to the name, it's a const pointer, even if strchrW hides the warning. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] handle builtin regedit.exe.so
by Alexandre Julliard Aug. 20, 2007

Aug. 20, 2007

Marcus Meissner <marcus(a)jet.franken.de> writes: > On my system it tries to load /usr/lib/wine/regedit.exe.so > (via symlink) and this fails. We stopped using symlinks a long time ago, it sounds like your .wine dir is out of date. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comdlg32: printdlg: Fix number display in PrintDlgW()
by Alexandre Julliard Aug. 20, 2007

Aug. 20, 2007

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > vsprintfW and friends do not support float numbers, so we have to format an > initial string with printf() and then print it to a wide string with > vsprintfW()'s %hs format. For a simply conversion to Unicode MultiByteToWideChar is a better choice. -- Alexandre Julliard julliard(a)winehq.org

1 0

Dyne:bolic binary module
by Robert Shoemaker Aug. 20, 2007

Aug. 20, 2007

I was wondering what the steps would be to put my binary build for the i686 Dyne:bolic distro on the releases page, it was no small task getting it to compile.

2 1

Direct3D 10 design considerations
by Stefan Dösinger Aug. 20, 2007

Aug. 20, 2007

Hi, In the past days there was a bit of discussion about the implementation design of our future d3d10 implementation. The major question was wether we should make a clean start over with opengl 3.0, or extend wined3d for d3d10. A few facts: *) D3D10 is a clean restart without any backwards compatiblity, so is gl3. The fixed function pipeline was removed in both. *) The D3D10 interface is a present. Many of the nasty things in d3d9 have gone. SRGB textures are a pixel format property now. Sampler states are a texture property, not a device setting. Offscreen-rendering is more fbo like. *) WineD3D contains a huge set of functionality of d3d10 already. D3D10 is an evolutionary step, not a revolution. I estimate that 80% of the functionality that is of our interest already existed in d3d9. Code reuse, especially of the shader code and texture management, is desireable. *) GL3 isn't out yet. When will we have a gl3 implementation on all platforms and drivers? *) If we split, we do not have to take care for old opengl implementations and missing extensions. For d3d10 we could just require gl3, period. Of course that will only work satisfiably for the user if there are gl3 implementations everywhere. So we have two ways: 1) Do the same Microsoft did, and do a fresh start. Some code, like the shader code, could be copied over and forked. This is propably the fastest way, but it leaves us with 2 different d3d implementation. The d3d10 implementation on the other hand would be free of old junk. It would make it hard to run d3d10 on gl2+extensions, and even more harder to implement d3d9- on gl3. 2) Extend wined3d. We could use the inheritance scheme like in old ddraw, where the non-rendering functionality was implemented in a base object, and the renderer specific things(DGA / User / 3D) was implemented in objects derived from the base objects. This was a nice thing, but it made the code next to unreadable IMHO because of a huge number of objects and unintuitive interactions(DGA code calling User stuff, common code calling callbacks that are set in 5 places in the code, 5 different surface types). WineD3D already has the attachment points for such an abstraction. We have COM vtables and state management callbacks. Implementing d3d10 properly in wined3d is most likely more work than a restart is, but it would allow us to reuse some code. What we would have to do is this: *) Make sampler states work like in opengl. D3D7-9 takes care for updating the per texture states based on the device states. This will require some code to be moved from wined3d to d3d7-9 and duplicated in the 3 libs, most notable sampler state tracking in stateblocks. *) Move the srgb flag -> format matching from wined3d to d3d9. Before this can be done, wined3d has to be changed from D3DFORMAT to DXGI_FORMAT style. *) Clearly separate gl-specific code from non-gl-specific code in surface, texture, cubetexture, volumetexture, indexbuffer and vertexbuffer. Then split them in a base object and a derived gl2 object. Add a gl3 object implementing the gl-specific stuff in gl3. Make sure there is no gl specific buffer/texture stuff in the device(like CreateVBO & *) Add a 2nd state table and callback functions for gl3. GL3 will have different state linkings. Most of the states can stay unimplemented unless we want to run d3d9 with gl3. D3D10 is much simpler here because the fixed function pipeline was removed. *) Do something about the context manager. Multithreading has changed in d3d10, and it may change in gl3. Offscreen rendering in d3d10 can require fbos(no point in d3d10 offscreen rendering without them), this has much less hassles than the back buffer or pbuffer orm. Context management will most likely be much simpler in d3d10+gl3. Andras tells me that he has the d3d10 stubs(no rendering yet) done now, and he is writing some tests currently, then he will send stubs and tests in. Which way do you think should we go?

5 9

Re: dsound: Handle failing of IDsDriver_CreateSoundBuffer better
by Vitaliy Margolen Aug. 20, 2007

Aug. 20, 2007

Maarten Lankhorst wrote: > There, now hush. :p > > Does 'Hardware Acceleration to Emulation' silently, without requiring of > the user to do something. > > > - ERR("Could not map sound device for direct access (%s)\n", strerror(errno)); > - ERR("Please run winecfg, open \"Audio\" page and set\n" > - "\"Hardware Acceleration\" to \"Emulation\".\n"); > + WARN("Could not map sound device for direct access (%s)\n", strerror(errno)); > return DSERR_GENERIC; And this really fixes the bug, doesn't just hide the error message? If it fixed, then there should be no messages at all. I really do not want to have people opening bugs because something crashes/sound doesn't work, etc. Vitaliy

2 1

Re: Greek resource file for comctl final
by Paul Vriens Aug. 19, 2007

Aug. 19, 2007

Dj Apal [GR] wrote: > OK changed the copyright and added the diff file for the rsrc.rc file so as > to be included. > > Thnx for noticing that! > > I think that we are OK now. Sorry for all this mess but it was my first time > posting a patch! > > > > ------------------------------------------------------------------------ > > Your 'greek_comctl' patch is in 'diff -up' format. The 'rsrc.diff' patch should also be in that format (and done from the root of your Wine source directory). Cheers, Paul.

1 0

choppy anim
by Skrzynka Aug. 18, 2007

Aug. 18, 2007

Hi, I'm trying to get some game (Settlers 3) to work on Wine (updated sources recently from git). If possible, I'd like to ask for some clues for a start: 1) the issue is choppy animation - the frame rate is abt 1/sec while the cpu load is low. However there are random periods when there seem to be about few frames per second (and cpu is laoded 100%). I tried measuring the time between call and return of DLL functions in relay.c. The only thing that looked suspiciously was WaitForSingle|MultipleObjects having times like 200-500ms. I also tried adding some delay to WaitForVerticalBlank in ddraw.c but also to no effect. Where should I start looking for the problem - some events or callbacks code? which? 2) when I run it from within winedbg i get lots of exceptions (no matter if app was started from winedbg or it was attached later) and no matter what combination of pass/continue I do, the app crashed with some msg box about exception or structured exception. Any pointers to docs on this? Any suggestions will help greatly. Thanks & regards Piotr -- ----- AlphaNet - najtaniej w sieci! -------- Odnowienia domen w rewelacyjnych cenach! .pl - 65 zl, .com.pl - 50 zl, reg - 20 zl http://www.domeny.alpha.pl --------------------------------------------

1 0

Re: #winehq admin abuse
by Abel Chiaro Aug. 18, 2007

Aug. 18, 2007

Tom Wickline <twickline(a)gmail.com> wrote: > I gladly take the side of vitamin on this issue. I believe he is a > valuable member of the FOSS community, he has contributed many patches > to this and other OSS projects. And in HIS free time he volunteers on > the #winehq IRC channel to help people who want to accept his help... > He tried to help YOU and YOU refused to try what he ask YOU to do!! > YOU kept asking the same stupid *shit* over and over and over until > you got on his last nerve. He cant help someone who doesn't want to > help them self. > > Also, it doesn't look to me like he cussed anyone out! but I guess I > just cussed YOU as I used the poo word in this reply. :D I beg your pardon if I got this wrong, but I seems to me that Jonathan is *Pie-rate* rather than carretto. While carretto did ask the same thing over and over until vitamin gave him the download link, Pie-rate only asked once (timestamp: 09:43:50 PM), to which vitamin replied with his "oh well". I don't want to take any sides here — especially because I refrain from going to support channels exactly to avoid such situations —, but I have to say that vitamin's behavior in that discussion is definitely less than polite. However, I do think that Jonathan made the issue a bit bigger than it actually is. Ah, yes, regarding cussing around, I recall reading vitamin saying "F***" to Pie-rate twice, all the while not cussing *carretto* out. Anyway, being civil does no harm. My 2¢. - Pedro.

5 5

Re: Greek resource file for comctl final
by Maarten Lankhorst Aug. 18, 2007

Aug. 18, 2007

Dj Apal [GR] schreef: > > OK changed the copyright and added the diff file for the rsrc.rc file > so as to be included. > > Thnx for noticing that! > > I think that we are OK now. Sorry for all this mess but it was my > first time posting a patch! Just curious, are files supposed to have dos line terminators? It seems to me like your file has it. Cheers, Maarten

1 0

re: [patch] Garbage code in text string display
by Dan Kegel Aug. 18, 2007

Aug. 18, 2007

Xin Guan wrote: > This patch solves the problem that many MBCS programs display garbage code > for text strings. Because most windows programmers do not handle charsets > properly, we have to force DEFAULT_CHARSET in here. Can you give a simple example of such a program (preferably downloadable)? Can you add a conformance test showing that your patch is correct? - Dan

1 0

Re: Greek resource patch for comctl [third attempt, last I hope!!]
by Paul Vriens Aug. 18, 2007

Aug. 18, 2007

Dj Apal [GR] wrote: > Hope this is what u want us to send! ;) used --> diff -up /dev/null ... etc etc > > > > ------------------------------------------------------------------------ > > Hi, Just a few remarks. The copyright says 'Eric Kohl' is that correct? You also need to add this resource file to 'rsrc.rc' in that same directory otherwise it will never be picked up. Cheers, Paul.

1 0

Re: bugs 9062,9325
by Stefan Dösinger Aug. 17, 2007

Aug. 17, 2007

Am Freitag, 17. August 2007 15:39 schrieb Martin Vanek: > I have posted some minor bugs in combobox a week ago (ID=9062, with a > source text example and pictures documenting what's wrong). I am not an expert on user32 stuff, but generally you should send one patch per mail. If you have 2 patches, just send 2 mails. If you have written a test application, you may want to include it in dlls/user32/tests/ to proove the correctness of your patches and prevent the issue from coming back.

1 0

Re: [PATCH 3/6] winealsa: Implement IDsCaptureDriverImpl_Open
by Tomas Carnecky Aug. 17, 2007

Aug. 17, 2007

Maarten Lankhorst wrote: > Sanity check to see if device can be opened or not Is alloca() not allowed in wine? (asking because you allocate hw_params on the stack, but it's freed if the function exits, so it's only used inside this one function). tom

2 2

Re: check_sharing disregards requested access
by Alexandre Julliard Aug. 17, 2007

Aug. 17, 2007

"James Keane" <james.keane(a)gmail.com> writes: > check_access will now fail because the second caller is not honoring > FILE_SHARE_WRITE. but that shouldn't be neccesary as they are not > planning on writing anyways. The second caller won't, but the first one will, so you need FILE_SHARE_WRITE access. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: A script for automatic regression testing
by Dan Kegel Aug. 17, 2007

Aug. 17, 2007

Martin wrote: > Regarding your script interface, I think it should accept these parameters: > * GIT_ID_1 - bisection start > * GIT_ID_2 - bisection end Sure, and/or dates and/or releases. * PNGs - list of PNG files which describe "bug hit" cases; No. The script should not invoke autohotkey, either. IMHO, it should instead factor out any knowledge about how to test for the bug into a user-supplied shell script. The script would be run once Wine is built, would check for the specific bug being searched for, and its exit status would be zero for success (no bug) and nonzero for failure (the bug was found). So using Mikolaj's script would require you to write a tiny shell script that invoked autohotkey on a script, or maybe just ran an installer and checked for the existance of a file, or something to do with PNG's, whatever you want. http://delta.tigris.org works this way; it calls the shell script "the oracle". - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

1 0

Legal issues for contribution code into Wine
by Dmitry Morovkov Aug. 17, 2007

Aug. 17, 2007

Hello, I'm a (mostly windows, but with some linux skills) programmer from russia who is interested in helping developing Wine, but due to all the mess I read about the legal issues I want to ask first. What is Wine's position regarding people who had seen the windows source code? I tried to search for this topic, and, found this: http://www.gnu.org/prep/standards/html_node/Reading-Non_002dFree-Code.html After reading this, it looks like it's ok if someone have seen the windows source code, and provided he is not going to directly copy unmodified source code (what a stupid idea!), nor refer to it, he would be considered as a good/trusted person? Please clarify this to me. Regards, Dmitry Morovkov.

3 2

Re: Issue(s) when running winetest on Windows
by Kirill K. Smirnov Aug. 17, 2007

Aug. 17, 2007

>file: 2 tests executed (0 marked as todo, 0 failures), 0 skipped. >file: 373 tests executed (0 marked as todo, 0 failures), 0 skipped. These lines are displayed via printf (include/wine/test.h: 391). > msvcrt:file done (0) And this via xprintf (programs/winetest/main.c: 420), which is wrapper over write syscall. If you need these line be output in appropriate way, try to add fflush(stdout) in proper place (into run_test function in include/wine/test.h, I suppose). -- Kirill

4 6

About WritePrivateProfileString and file operations
by Zhongli Xu Aug. 16, 2007

Aug. 16, 2007

Hi all, I run some tests about mixed using WritePrivateProfileString and stand file operations Codes look like this: GetPrivateProfileString(keyname, value); fopen(); fprintf("# comments"); fclose(); WritePrivateProfileString(keyname, newvalue); What I found in the file is that either WritePrivateProfileString operation succeeded(newvalue has been written) or fprintf succeeded("#comments" shows up in the file). On windows hosts, there is no such problem. Any suggestion or idea is welcomed. Thanks. Milo

3 2