August 2007 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

Re: hhctrl.ocx: Parse HTML entities in the table of contents.
by Alexandre Julliard April 15, 2008

April 15, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > + p++; > + if ((*p == 'X') || (*p == 'x')) > + { > + /* hexadecimal entity */ > + while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') || > + (*p >= 'A' && *p <= 'F')) > + p++; > + ch = strtolW(start + 2, NULL, 16); > + } This is still broken. > + if (p - start - 1 <= sizeof(char_refs[0].name)) > + { > + for (i = 0; i < sizeof(char_refs)/sizeof(char_refs[0]); i++) > + if (!strncmpW(char_refs[i].name, start + 1, p - start - 1)) > + break; > + } This is still broken too. -- Alexandre Julliard julliard(a)winehq.org

2 1

The status of the wintab dll
by Robert North Dec. 24, 2007

Dec. 24, 2007

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I think after the 10 or more patches to the Wintab dll that I submitted last month, I should say something about it's status... And of course thank Alexandre for applying those patches. P.S. I won't be available from the 15th for about a week or so. So, if you have any questions, I'm afraid you might have to be patient. Hope this is of interest to someone -Rob. ******Applications: Current status*********** ***In Painter 5 *Cursor pressure works. (Therefore is usable by most) *Cursor orientation is a little odd: The orientation maths needs to be re-done. *No eraser. Haven't yet cracked what enables the eraser. *Doesn't work in desktop mode: Need to map to desktop coordinates. *Repeats windows bugs where cursor looses pressure/orientation info almost bug for bug (Is this a feature? ;-) *Cannot detect pressure/orientation int the "Brush Tracking" window: The tablet context is attached to the main window, so no events get to the popup, even if they overlap. This is not how windows wintab functions. ***In Photoshop 6. *Can only get tablet data in desktop mode: This is because the tablet context is attached to the desktop. Which generates/receives no wine events outside desktop mode. * Eraser and pen pressure working. *But* to get them working, you must have 3 XInput devices listed in your XF86Config file, They need to be the last entries in the "ServerLayout" section and the following order: eraser, tablet mouse. This is a far from ideal way of specifying the devices Wintab should use :-/ I'll document this if someone can point me to a good place to put the docs. *******To Do************* 1. Look at X11 errors. There appear to be some errors that deny some users the ability to access Wintab enabled apps. (I think I know how to fix this) 2. Improve orientation data. Orientation comes in as X-Y coords (Implicit Z), and has to leave as spherical coords. This calculation needs to be re-done. 3. When tablet context is on top, let it read XInput events from all the app's top-level windows. (This simulates the fact that the context is usually designed to cover the whole screen) 4. When tablet context is attached to desktop, read XInput events from all the app's top-level windows. 5. Tests ~ --My current philosophy on tests is... ~ Use Photoshop & Painter, any formal tests ~ can be written if anyone else gets involved in patching Wintab, to avoid regressions, and conflict. **********Long term to do (Anyone interested?):********* There's a lot of work that could be done here, but what gets done and who does it probably depends upon whether anyone finds an app that needs these features. I'd love to implement these, but realistically, I don't foresee doing this unless someone hires me to do so ;) 1. Improve configuration of wintab. Wintab could probably do with some information entered into the config file, to avoid the user having to hack their Xfree86cfg file. 2. Handle Z-Order of context properly. This entails *sharing Z-Order between apps. *Working out exactly what role windows have in determining tablet context z-orders. *Allow tablet contexts that don't cover the whole screen/tablet. *Handle inter-application clipping of tablet contexts *Allow all application's windows to receive tablet events when tablet context is on top 3. Implement non-system tablet contexts (Where system cursor not moved by pen or mouse) 4. Unicodify 5. Implement various wintab extensions. 6. Implement wintab manager functions. 7. Tests. *********Unknowns********* 1. How are wintab contexts are raised lowered? Contexts have their own z-order independent of windows, and their own viewport concept, based upon the tablet's coordinate system, not that of the OS. It appears that entering, or clicking on the window the tablet context is attached to will raise/lower the context. But I haven't done much testing on this. In particular, what happens if more than one app request their tablet context is attached to the desktop? 2. How Painter detects the eraser. Have 3 possibilities i. Windows can detect an eraser, and sends specific messages. (I'm sure I've seen this, but can't work out where!) ii. Only works if tablet and cursors are named correctly. (Probably linked to wacom tablets only). iii. I've missed something 3. Requirements of other applications -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2-rc1-SuSE (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCC8zI2vfwxdLxwWYRAsisAJ4q2gAYTgRc6f9wDI+Ruv943eDxOQCfcl3s /ZKMUGwQOuw/SIIbOkIUbd0= =R4M7 -----END PGP SIGNATURE-----

2 1

Direct3D Game test framework
by Stefan Dösinger Dec. 21, 2007

Dec. 21, 2007

Hi, Now that we're facing Direct3D 9 feature completion soon - VTF support coming in from Henri, High order patches and thread safety from me - the d3d work will change a bit soon. Instead of adding new features we'll debug games and improve performance. It would be good if we had some automated testing framework to support the process :-) Unfortunately this isn't easy. Games do not render exactly, so verifying that a game doesn't show any visual regressions automatically may be more effort than reward. Here I think we'll have to rely on users testing the games regularly and testing regressions. I am more concerned about the performance thing. It is very easy to make some performance improvement that does more harm than good. Also benchmarks take quite some time and are affected by many external parameters. So I'd like some automated and controlled performance testing environment. Instead of building one from scratch it would be cool if we could reuse existing software. cxtest comes to my mind(www.cxtest.org). It is a test suit built by codeweavers for running regression tests on Windows apps. It can remote control applications using keyboard input and compares screenshots to reference ones. It could be used to start benchmarks automatically. A plus here is that some machines run nightly tests. However, those are VMs, so no 3D acceleration. A problem is also reading back the results. Does anyone know some applications for doing that? Windows or Linux apps, commercial or open source ones(prefered, though). Then we need benchmarking apps. Here regular Windows benchmarks come to my mind(3DMarkXYZW), games with benchmark facilities(hl2, ut, ...). We can record tests, get a reference performance counter from windows and run nightly tests(or manually started tests). A problem we're facing is reading back the results. Taking screenshots and running OCR on them is error prone, we need a way to get the numbers from the benchmarks, not an image of the numbers. Now we need a concrete collection of benchmarks. A mixture of popular Benchmarks like 3DMark would be good, and some more cientific benchmarks. So far I have: 3DMark: Popular benchmark for testing the overall performance, doesn't give very detailed results though. Controlling: Standard windows controls, keyboard events should do the job Result readback: Can write results to a file, but must take care about the licensing. Not everything is free, most likely a license is needed. Half-Life 2: Nice facility of recordable timedemos. Can record average game demos, but also demos which stress specific features. Controlling: Command line parameters Result readback: Can be asked to copy the console into the clipboard UT2004: Popular engine. Has a Linux port, but many mods only ship the d3d renderer. Controlling: Unknown Result readback: unknown. DirectX sdk demos, nvidia / ati demos: Stress specific rendering features. Good for testing performance(with vsync removed), or a bad idea? Controlling, Readback: Source code is available and can be modified. License, especially possible benchmark clauses? Other suggestions? Another nice-to-have thing would be a game independent profiling method, simmilar to the +fps debug channel, just more detailed. Some games do not have built-in benchmarking, it would still be nice to use them. That means facing some new problems? How to tell loading from in-game rendering? How to remove control those games in a repeatable way, especially if there are some random elements in the game? More detailed data from wined3d could also be used to draw nice graphs for other benchmarks :-) We'll need some hardware diversity too. It would be nice if the tests worked on Linux and MacOS, and a variety of hardware was used. I want at least nvidia, ati and intel gpu's, older and newer ones. I could also revive my ATI mach64 :-) Any other comments or suggestions? I think once I'm done with the current exam season and my patch backlog is in I will retire from direct wined3d development for a few days / weeks to set up a testing environment, then start fixing games.

10 40

Work legalities
by Nathan Williams Dec. 11, 2007

Dec. 11, 2007

Hey everyone, I have been planning to do some work on wine for a while now, but after I started working I got myself a new programming job. I'm worried about the copyright of any external work I do, so I need a little advice. What do I need from my employer to clear me to work on wine? Is something verbal ok, or should I get it in writing? -- Nathan

10 12

Will ROS and WINE still be steady be synchronized ?
by theUser BL Sept. 20, 2007

Sept. 20, 2007

Hi! I have also ask the question in a mail in the ROS-Mailinglist -- until now there comes now answer. http://www.reactos.org/archives/public/ros-dev/2007-August/009718.html Will ReactOS and WINE still be steady synchronized? ROS have for example an other Notepad.exe and an other Wordpad.exe The WineMINE have on ROS the colors of the original Windows WinMine. And the cards.dll have other cards. AT first it used the cards of http://nifty.stanford.edu/2004/EstellCardGame/ But after the comment of http://www.reactos.org/archives/public/ros-dev/2007-July/009625.html it used the cards at http://sourceforge.net/projects/macsolitairex WINE on the other side used since the beginning of its cards.dll the Microsoft copyrighted cards, which are also part of MS-Windows. So, for me it seems, that ROS and WINE goes two different ways since some time without syncronizing the source-codes, which can be used for both projects. Is that true? And if yes: Why? Greatings theuserbl _________________________________________________________________ Sie suchen E-Mails, Dokumente oder Fotos? Die neue MSN Suche Toolbar mit Windows-Desktopsuche liefert in sekundenschnelle Ergebnisse. Jetzt neu! http://desktop.msn.de/ Jetzt gratis downloaden!

4 4

AppDB entries
by speedator＠gmx.de Sept. 11, 2007

Sept. 11, 2007

Hi, sometimes app-entries (like Acrobat Reader) are for series of applications and versions for the single applications. Sometimes there are app-entries(like Age of Empires) for single applications in a series and version-entries for patches, betas, demos etc.. And sometimes it is a mixture. What about making this more clear? Do we need entries for the whole series? I think it is important for overview. So what about a new structure like "application / version / derived from version(subversion)"? Julian

3 2

Hmm. Cider and the LGPL
by Dan Kegel Sept. 3, 2007

Sept. 3, 2007

http://www.linux-community.de/story?storyid=23294 and http://www.macnews.de/news/102145.html mention that some users are using Cider from one game to run a second game on the Mac. The game vendors are upset, and are saying they'll do something to make that harder. There is some question about whether Cider includes LGPL components of Wine, and whether there are any violations lurking there. I imagine our friends at Cedega would instinctively avoid such infringement, but accidents might happen. It'll be interesting to see if anybody finds a real problem. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

6 7

Re: [5/5] WineD3D: texkill ignores the .w only in ps 1.x
by Tomas Carnecky Sept. 1, 2007

Sept. 1, 2007

+ + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xff00ff00, 0.0, 0); + ok(hr == D3D_OK, "IDirect3DDevice9_CreatePixelShader returned %s\n", DXGetErrorString9(hr)); Is that worth changing? tom

2 1

Re: [4/5] WineD3D: Implement texldb
by H. Verbeet Aug. 31, 2007

Aug. 31, 2007

On 31/08/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Not as much a comment on this patch, but rather something I just thought of and I'll otherwise probably forget: our d3d9types.h doesn't contain definitions for D3DSI_TEXLD_PROJECT and D3DSI_TEXLD_BIAS, so we should add those.

1 0

Re: [2/5] WineD3D: Fix the z range
by Stefan Dösinger Aug. 31, 2007

Aug. 31, 2007

Am Freitag, 31. August 2007 17:20 schrieb Stefan Dösinger: Do not apply this patch yet, it breaks half life 2. There's something about the minZ and maxZ values in the viewport that we have to take into account.

1 1

Re: [3/5] WineD3D: Fix texdepth instruction
by Alexandre Julliard Aug. 31, 2007

Aug. 31, 2007

Stefan Dösinger <stefan(a)codeweavers.com> writes: > The DCT pixel shader test spotted a problem with texdepth. The test > included in this patch demonstrates texdepth's undocumented clamping > behavior, and > verifies the documented r5.r == 0.0 special case. This doesn't work for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:2281: Test failed: Pixel 158(25% - 2 pixel) has color 00ffffff, expected 0x000000ff visual.c:2303: Test failed: Pixel 318(50% - 2 pixel) has color 00ffff00, expected 0x000000ff visual.c:2344: Test failed: Pixel 318(50% - 2 pixel) has color 0000ff00, expected 0x000000ff make: *** [visual.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: winex11.drv[1/4]: wintab: restructure WTInfoA to dump a category by dumping field by field (resend)
by Alexandre Julliard Aug. 31, 2007

Aug. 31, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > I see that my patch to skip non-pressure-sensitive devices didn't > get it. I will try to look into it next week while now I'll resend the > Unicode patches that are easier. Here the first patch could be > controversial as I use a lot of macros. But that allows me not to use > long parameter lists. It's ugly. I don't see why you'd need long parameter lists at all, simply adding a current offset in CopyTabletData should be enough. Also, always going through all the cases even when a specific index is specified is not nice. And the winex11 function should always return Unicode, the A translation can be done in the generic code. -- Alexandre Julliard julliard(a)winehq.org

1 0

Vacation
by Alexandre Julliard Aug. 31, 2007

Aug. 31, 2007

Hi folks, I'll be on vacation all of next week, so there won't be any commits. If you need to synchronize development with others in the meantime, I encourage you to create a tree on repo.or.cz. The 0.9.45 release will also be delayed by a week, so it will be on Sept 14th. Have fun while I'm gone... -- Alexandre Julliard julliard(a)winehq.org

1 0

RegDeleteTree and older versions of windows?
by Maarten Lankhorst Aug. 31, 2007

Aug. 31, 2007

Now that most functions get replaced with RegDeleteTree, I'm wondering if it is possible to link against that function statically for mingw/msvc dlls, so wine dlls can be still be used on win9x and windows nt and win2k. The problem is I don't know what the best solution would be to make sure the function makes it in, in case of mingw. I think it would be best to add it to include/wine/regdeltree.h and then include it from all dlls that need it, and probably from dlls/advapi32/registry.c as well, so code duplication is avoided. Something along the lines of: #if defined(__MINGW32__) || defined(__MSVC__) || defined(EXPORTREGDELTREE) (insert regdeltree functions here) #endif I'm open for suggestions though, since I really can't come up with any good ways to make sure wine dlls will keep working for older versions of windows. Cheers, Maarten

2 1

Re: winex11.drv: fix memory leak in create_cursor (found by Smatch)
by James Hawkins Aug. 31, 2007

Aug. 31, 2007

On 8/31/07, Lionel_Debroux <lionel_debroux(a)yahoo.fr> wrote: > create_cursor leaks some heap memory in an error path. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > I'm almost sure that the other potential memory leak detected by Smatch, > in the same function, is NOTABUG. Indeed, bitMask32 is conditionally > freed at line 850, if the number of bits per pixel (ptr->bBitsPerPixel) > is 32 - which is the condition which led to bitMask32 being allocated, > at line 639. > > 2007-08-31 Lionel Debroux <lionel_debroux(a)yahoo.fr> > * dlls/winex11.drv/mouse.c: > winex11.drv: Fix memory leak in create_cursor (found by Smatch) > > >From d62a874a6d399546940a97fc3d800a692c08b362 Mon Sep 17 00:00:00 2001 > From: Lionel Debroux <lionel_debroux(a)yahoo.fr> > Date: Fri, 31 Aug 2007 08:16:36 +0200 > Subject: winex11.drv: fix memory leak in create_cursor (found by Smatch). > > --- > dlls/winex11.drv/mouse.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/dlls/winex11.drv/mouse.c b/dlls/winex11.drv/mouse.c > index 86dad89..d8bf30a 100644 > --- a/dlls/winex11.drv/mouse.c > +++ b/dlls/winex11.drv/mouse.c > @@ -763,6 +763,8 @@ static Cursor create_cursor( Display *display, CURSORICONINFO *ptr ) > pixmapBits = XCreateBitmapFromData( display, root_window, (char *)pXorBits, xmax, ymax ); > if (!pixmapBits) > { > + if (bitMask32) > + HeapFree( GetProcessHeap(), 0, bitMask32 ); > XFreePixmap( display, pixmapAll ); > You shouldn't be checking bitMask32 for NULL before freeing it. -- James Hawkins

1 0

Re: crypt32(1/17): Greatly expand certificate chain tests
by Alexandre Julliard Aug. 31, 2007

Aug. 31, 2007

"Juan Lang" <juan.lang(a)gmail.com> writes: > In case the big version doesn't get through in time, here's a gzipped version. It fails for me: ../../../tools/runtest -q -P wine -M crypt32.dll -T ../../.. -p crypt32_test.exe.so chain.c && touch chain.ok chain.c:1187: Test failed: Chain 12: CertGetCertificateChain failed: 80092004 make[2]: *** [chain.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] WineD3D: Fix texdp3tex in glsl
by H. Verbeet Aug. 31, 2007

Aug. 31, 2007

On 30/08/2007, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > The preferred way to do that is to use shader_glsl_get_sample_function(). Also note that previously the docs just said "The result is used to sample the texture at texture stage m by performing a 1D lookup." The addition of using 0.0 to extend the vector is apparently recent.

2 2

Re: [PATCH] user32: edit control should respond to ctrl + z
by Dmitry Timoshkov Aug. 30, 2007

Aug. 30, 2007

"Lei Zhang" <thestig(a)google.com> wrote: > This lets users hit ctrl + z in edit dialogs. A test case is included. > This should fixed bug 9525. > + /* select all, cut (ctrl-x), undo (ctrl-z) */ > + SendMessage(hwEdit, EM_SETSEL, 0, -1); > + SendMessage(hwEdit, WM_CHAR, 24, 0); > + SendMessage(hwEdit, WM_CHAR, 26, 0); I'd suggest to add checks to make sure that every message you send above really worked. -- Dmitry.

2 1

Re: winex11.drv/wintab32[5/6]: implement WTInfoW
by John Klehm Aug. 30, 2007

Aug. 30, 2007

You forgot the patch. On 8/30/07, Mikolaj Zalewski <mikolajz(a)google.com> wrote: > Now we allow to query the Unicode data > > >

1 0

Re: winex11.drv[2/6]: wintab: skip non-pressure-sensitive devices for wintab32
by John Klehm Aug. 30, 2007

Aug. 30, 2007

You forgot the patch. On 8/30/07, Mikolaj Zalewski <mikolajz(a)google.com> wrote: > Another problem I had was that the laptop touchpad was detected as a > tablet. This may confuse Windows applications, as on Windows it isn't. > Also it confuses Wine because we support only one tablet - we assume > that each cursors have the same resolution. > > Is there a good way to select the correct devices as do we have to add > heuristics like the one in this patch? This patch ignored devices that > don't have the pressure axis. I assume that the WM_MOUSEDOWN gives > enough information so there is little loss that it can't be accessed > with wintab32. > > >

1 0

.NET support
by Jakob Eriksson Aug. 30, 2007

Aug. 30, 2007

Now that GDIplus is shaping up, is there a chance of implementing .forms support in mono with it? regards, Jakob

3 9

Fwd: Re: winmm: Change default driver order to be alsa, coreaudio, oss - try2
by Kuba Ober Aug. 30, 2007

Aug. 30, 2007

---------- Forwarded Message ---------- Subject: Re: winmm: Change default driver order to be alsa,coreaudio,oss - try2 Date: Tuesday 21 August 2007 From: Kuba Ober <kuba(a)mareimbrium.org> To: wine-devel(a)winehq.org On Sunday 19 August 2007, Vitaliy Margolen wrote: > Maarten Lankhorst wrote: > > Forgot to remove the strlen check. > > Isn't this a bit premature? ALSA still does not support proper sound > capture, working mixer, and not stable enough on some configurations. In fact, for whatever it's worth, on some machines running either CentOS5 or FC6, for me alsa is completely broken (choppy sound output from linux alsa applications, etc). :( Cheers, Kuba -------------------------------------------------------

1 0

Re: try2:patch for sysparams.c
by L. Rahyen Aug. 30, 2007

Aug. 30, 2007

On Thursday August 30 2007 07:03, you wrote: > Hello, > > I have corrected a patch. Now font in the menu and a font in winecfg > coincides. Your patch still doesn't work correctly. With 120 DPI setting font size in winecfg and notepad menu is different (menu' font is bigger; no so big as before but still bigger). As I have said, in Windows font size is the same in whole system if I change DPI setting and this is (correct) behavior of current WINE too. Please note that your patch behaves even worse at higher DPI resolutions. For example if I set: "LogPixels"=dword:00000096 ...In system.reg then menu font is of ridiculosly big size. In winecfg I have normal font size suitable for my display resolution. In fact, dword:00000096 setting this is what I use in both WINE and Windows (in Windows I can just use "Custom..." menu; in WINE winecfg isn't yet sophisticated enough). In short: if DPI setting changes then font size should change in linear fashion at the same rate for all fonts. Also please explain what exactly you are trying to fix with your patch (what application)? Are you sure that Windows behaves in the same way as you proposing? Test case probably would be nice thing. Sorry, but purpose of your patch is unclear to me. In your changelog field you tell that "This patch does a font for the menu, statusbar and messages dependent from logpixels" but as far as I know WINE already have correct behavior and respects the LogPixels value (it already sets correct size in menu, status bar and other GUI elements). This is why I'm asking you for an real-world example (with real-world application) of what you are trying to fix. P.S. Don't forget to reply to wine-devel so others can see the discussion.

3 4

Re: dsound: Disable thread calls and increase refcount in dllmain
by Dmitry Timoshkov Aug. 30, 2007

Aug. 30, 2007

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Seems native directsound keeps itself loaded by calling LoadLibrary when > attaching. A simple testcase I wrote confirms that at least for xp, by > not crashing. After seeing this, I decided to write my own test, and can confirm now that this patch looks correct: after a successful LoadLibrary("dsound.dll") FreeLibrary needs to be called 2 times before it starts to return FALSE. Just for fun I tested other dlls as well (GetModuleHandle returns 0 for all of them before the LoadLibrary call): user32 requires 4 FreeLibrary calls after LoadLibrary, dinput - 1, mfc42 - 1, advapi32 - 1, comctl32 - 1. I'm attaching the program I used for testing. > + GetModuleFileNameW(hInstDLL, modname, sizeof(modname)/sizeof(*modname)); > + LoadLibraryW(modname); Probably simple LoadLibrary("dsound.dll") should be enough. -- Dmitry.

3 2

Re: winex11.drv: Support GdiAlphaBlend with blendfn.AlphaFormat == 0 (2nd try, fixes bug #9262)
by Alexandre Julliard Aug. 30, 2007

Aug. 30, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > I'm not sure if I understood how it's supposed to look like. Is > something like this good? It adds an 'if' in the inner loop, but it's > an 'if' that is easy to predict and this version makes less memory > reads so maybe it will be better. You should put the if outside the loops, and keep the existing fast case with the memcpys and add a separate slower way for when alpha needs patching. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: getting started...
by Dan Kegel Aug. 30, 2007

Aug. 30, 2007

Ed wrote: >I'm brand new to the list and would like to get a Windows application that >I wrote (uCon) to work with wine/winelib. I've submitted it to the application >database. I've tried it on Wine and it *almost* works, so I'd like to pursue >this further by building uCon with Winelib (as is recommended somewhere >in the documentation). Egads. Where does it recommend that? Using winelib is a terrible idea unless you really need it (e.g. on non-x86 platforms, it's your only option). The downside is that your app suddenly becomes very fragile with respect to user updates of wine; they need a synchronized version of your app that matches their version of Wine. I've seen this happen, and it's not pretty. Also, this means double the QA and release trouble. The Right Thing To Do IMHO is just make your app and wine work better together, not use winelib. So your next move is to file bugs in http://bugs.winehq.org describing how your app doesn't work with wine, and work with us to solve them. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 7

Re: [2/5] WineD3D: Clear unused channels on R32F and R16F textures on readback
by H. Verbeet Aug. 29, 2007

Aug. 29, 2007

On 29/08/2007, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Can you even use those formats as render target on any cards?

2 1

Re: notepad: Add program icon
by Pedro Araújo Aug. 29, 2007

Aug. 29, 2007

On 8/27/07, Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> wrote: > notepad: Add program icon > > And now for the usual Wine oath: :) > I swear under pain of treason that the icon is my own work. > > .png attached if anyone wants to look at it. It's really not all that pretty. > > Alexander N. Sørnes I had this quick and dirty (okay, *very* dirty) mockup lying around for a while (not at all a very long while) and thought somebody might find some use for it... just in case. Ah, yeah, I too "swear under pain of treason" that I did it myself. :-) (I still have the original svg here if anyone wants it) - Pedro.

2 1

Re: try2:patch for sysparams.c
by L. Rahyen Aug. 29, 2007

Aug. 29, 2007

On Wednesday August 29 2007 09:15, Ivan Sinitsin wrote: > Has corrected "logpixels=72" to " logpixels = 96 " and has changed the > indentation > > This patch adds an opportunity for fonts of the menu, statusbar and > messages to increase depending on logpixels. > > > Changelog: > This patch does a font for the menu,statusbar and messages dependent from > logpixels. With your patch applied to current GIT head I have too large fonts in all menus even in notepad if for example I have set logpixels to 120 dpi using winecfg. "Too large" means MUCH larger than in, for example, winecfg itself (you need to restart the program to see the effect). See atached snapshot to see how notepad looks like with your patch if I set 120 dpi in winecfg. Font size is ridiculously big! For testing I have used clean WINE with your patch only and clean WINEPREFIX. In Windows and current WINE without your patch in clean WINEPREFIX all fonts are of same size no matter what DPI I set in LogPixels or winecfg and this is correct behavior. What application you are trying to fix?

1 0

Re: winex11.drv[2/2]: Support GdiAlphaBlend with blendfn.AlphaFormat == 0 (fixes bug #9262)
by Alexandre Julliard Aug. 29, 2007

Aug. 29, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > @@ -1600,6 +1603,16 @@ #endif > for(; y >= y2; y--) { > memcpy(dstbits, (char *)dib.dsBm.bmBits + y * dib.dsBm.bmWidthBytes + xSrc * 4, > widthSrc * 4); > + if (!(blendfn.AlphaFormat & AC_SRC_ALPHA)) > + { > + int i; > + RGBQUAD *quad = (RGBQUAD *)dstbits; > + for (i = 0; i < widthSrc; i++) > + { > + quad->rgbReserved = blendfn.SourceConstantAlpha; > + quad++; > + } > + } It would be nicer to have a separate loop for that case, and do everything in one go instead of patching up the values after the copy. Also RGBQUAD is meant for color tables, it's not an appropriate type for the bitmap data itself. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32: static controls should have a clipping region set while sending the WM_CTLCOLORSTATIC (3rd try, with testcase, fixes bug #9195)
by Alexandre Julliard Aug. 29, 2007

Aug. 29, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Is there something wrong with this patch? You should use IntersectClipRect or ExtSelectClipRgn to avoid intermediate copies. Also GetClipRgn doesn't return a region code so checking it against NULLREGION is wrong. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: patch for sysparam.c
by Paul Vriens Aug. 29, 2007

Aug. 29, 2007

Ivan Sinitsin wrote: > This patch adds an opportunity for fonts of the menu, statusbar and messages > to increase depending on logpixels. > > > Changelog: > This patch does a font for the menu,statusbar and messages dependent from > logpixels. > > > ------------------------------------------------------------------------ > > With the latest release winecfg can set this value. The default there is 96 and the range is 96..120. How does that relate to the 72 in your code? : +if (!RegQueryValueExW( myhKey, log_pixels, NULL, &type, + (LPBYTE) &logpixels, &size )==ERROR_SUCCESS) + logpixels=72; Cheers, Paul.

1 0

Re: patch for sysparam.c
by Robert Shearman Aug. 29, 2007

Aug. 29, 2007

Ivan Sinitsin wrote: > This patch adds an opportunity for fonts of the menu, statusbar and messages > to increase depending on logpixels. > > > +size=sizeof(DWORD); > +RegOpenKeyExW( HKEY_LOCAL_MACHINE, registry_key, > + 0, KEY_QUERY_VALUE, &myhKey ); > +if (!RegQueryValueExW( myhKey, log_pixels, NULL, &type, > + (LPBYTE) &logpixels, &size )==ERROR_SUCCESS) > + logpixels=72; > +ncm.lfMenuFont.lfHeight=-MulDiv(ncm.lfMenuFont.lfHeight,logpixels,72); > +RegCloseKey( myhKey ); You're missing some indentation here. -- Rob Shearman

1 0

Re: [PATCH] Support for animated cursors
by H. Verbeet Aug. 28, 2007

Aug. 28, 2007

On 28/08/07, Trent Waddington <trent.waddington(a)gmail.com> wrote: > On 8/28/07, H. Verbeet <hverbeet(a)gmail.com> wrote: > > You should use the timing and frame sequence info from the .ani. > > Also, Xcursor actually supports proper animated cursors, so it would > > be better to handle the animation in winex11.drv > > Can you please direct me to some example code of defining and using an > animated cursor with Xcursor? > http://repo.or.cz/w/wine/hacks.git?a=blob;f=dlls/winex11.drv/mouse.c;h=b344… should be a decent start. > > As explained in the comment at the top of cursoricon.c, you can't do > > that, because it will break win16 applications. > > Umm.. what comment would that be? This one: > * Cursors and icons are stored in a global heap block, with the > * following layout: > * > * CURSORICONINFO info; > * BYTE[] ANDbits; > * BYTE[] XORbits; > * > * The bits structures are in the format of a device-dependent bitmap. > * > * This layout is very sub-optimal, as the bitmap bits are stored in > * the X client instead of in the server like other bitmaps; however, > * some programs (notably Paint Brush) expect to be able to manipulate > * the bits directly :-( > Should I replace hNext with a CURSORICONINFO *? This is what I had > initially.. or should I be using something else? Or should I just > make it an BYTE bFrames and append multiple data blocks to the end of > the CURSORICONINFO struct? > Well, what it comes down to is that you can't change the cursor memory layout for win16 applications at all, which complicates things a bit.

3 12

[PATCH] the function called is cdecl, not WINAPI
by Juan Lang Aug. 28, 2007

Aug. 28, 2007

Hi Marcus, > the function called is cdecl, not WINAPI No it isn't. It's declared that way, but it's wrong. Calling it that way in Windows crashes. That's why I sent this patch: http://www.winehq.org/pipermail/wine-cvs/2007-August/035682.html --Juan

2 2

Re: winex11.drv: test for out-of-bound src coordinates in GdiAlphaBlend (fixed, with testcase, fixes bug #7428)
by Alexandre Julliard Aug. 28, 2007

Aug. 28, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > The previous version didn't take into account that dib.dsBmih.biHeight > can be negative. You should check for negative widthSrc/heightSrc too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: msvcrt: tests: some values of _mbctype are dependent on the version of Windows
by Alexandre Julliard Aug. 28, 2007

Aug. 28, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > @@ -144,10 +144,18 @@ static int result_cp_949_mbctype[] = { 0 > static int result_cp_950_mbctype[] = { 0x0,65, 0x8,1, 0x18,26, 0x8,6, 0x28,26, 0x8,4, > 0x0,2, 0x4,32, 0xc,94, 0,1 }; > > +/* these characters may differ on different Windows versions */ > +static int fuzzy_cp_1252_mbctype[] = {142, 158, 170, 181, 186, -2}; > +static int fuzzy_cp_1250_mbctype[] = {131, 141, 142, 143, 157, 158, 159, 163, 165, 170, 175, 179, 181, 185, 186, 188, 190, 191, -2}; > +static int fuzzy_cp_932_mbctype[] = { -2 }; > +static int fuzzy_cp_936_mbctype[] = { -2 }; > +static int fuzzy_cp_949_mbctype[] = { -2 }; > +static int fuzzy_cp_950_mbctype[] = { -2 }; What this shows is that the exact values don't matter, and that apps are very unlikely to depend on them. This also means that having slightly different tables in Wine is not a problem, so I'd suggest to not try to test every single char, but just pick a few that are the same on all platforms. -- Alexandre Julliard julliard(a)winehq.org

1 0

Old versions of Photoshop Elements tryout?
by Dan Kegel Aug. 27, 2007

Aug. 27, 2007

Hi all, I have a copy of Photoshop Elements 1.0, and can easily download a tryout of Photoshop Elements 5, but I don't know where to get trial versions of 2 through 4. Anyone know? Thanks, Dan

2 3

Re: 0001-Basic-starting-point-for-implementing-d3dx9_yz.dll.patch
by Detlef Riekenberg Aug. 27, 2007

Aug. 27, 2007

On Mo, 2007-08-27 at 14:13 +0200, Martijn Berger wrote: > > --- > .gitignore | 1 + > Makefile.in | 1 + > configure.ac | 1 + > dlls/Makefile.in | 1 + > dlls/d3dx9/Makefile.in | 15 +++++++++++++++ > 5 files changed, 19 insertions(+), 0 deletions(-) > --- /dev/null > +++ b/dlls/d3dx9/Makefile.in > @@ -0,0 +1,15 @@ > +TOPSRCDIR = @top_srcdir@ > +TOPOBJDIR = ../.. > +SRCDIR = @srcdir@ > +VPATH = @srcdir@ > +MODULE = d3dx9.dll > +IMPORTS = wined3d kernel32 > + > +C_SRCS = \ > + d3dx9_main.c > + > +RC_SRCS = version.rc This will not work: Your Makefile.in referenced "version.rc" and "d3dx9_main.c", but this files are missing in this Patch. You should never autogenerated modifications in any Patch: http://wiki.winehq.org/Developers-Hints#head-30a7f7f51ce0e42b4141749c9832ba… -- By by ... Detlef

1 0

DIB Driver code available
by Jesse Allen Aug. 27, 2007

Aug. 27, 2007

Hi, I have my DIB driver code available on a public git host now: http://repo.or.cz/w/wine/dibdrv.git I'm going to briefly describe it. The dib driver (or engine) is a gdi driver. It is loaded into a dc when an application selects a dib, and overrides the existing driver. The magic takes place in SelectBitmap. Safe interaction is provided in gdi32 in four patches. If the winedib.drv.so library is available, then gdi will use the dib driver for drawing into the selected dib. If winedib.drv.so is not available, then gdi will continue using winex11 for example just as before. So these four patches can be safely integrated with the main tree if that is decided to be done. The rest of the code is the driver itself. It can handle all the standard uncompressed dib formats. It can convert between formats, and it can Get/SetDIBits/Blt. Get/SetPixel is implemented too. No other drawing code is done yet, so only simple GDI apps work. I've tested several apps and I'll list my results. notepad -- no regressions found winefile -- visual artifacts, but usable bmp loading -- works fine for what has been tested pixel setting -- works fine for every supported format opengl app -- Tribes 1 -- no regressions found d3d app -- Star Wars Battlefront -- no regressions found ddraw app -- Diablo shareware -- no regressions found ddraw app -- Diablo prerelease -- discovered one visual artifact These are the deficiencies in current code (non-stubs): No RLE support Missing raster operations in *Blt Get/SetDIBits does not conform exactly yet Bottom-up DIB's not tested for (and probably broken) DIB_PAL_COLORS not tested for No stretching No forwarding calls back to original driver* *For forwarding back the calls, what I think can be done is use the hbitmap handle originally given, convert it to a DDB, select it, and make the same gdi call again which will then go to the actual device. I do probably need to make sure the dibdrv's physdev persists and doesn't get deleted during this ;) (probably something in Create/Delete DC) Performance Originally I was going to state not to expect there really to be any performance improvements. I feel that there are optimizations possible that I have not done, but I left room for. My first concern was correct pixel by pixel operation. So I thought not to expect anything but last night I discovered this, so I might as well share. I have written a program that performs Get/SetPixel to test the various formats. There are 13 total tests, and the program produces 52 MB of output. Just for fun I ran my program without the dib driver and found it took a very long time (I was thinking it hung up at first since it took so long!): timed with winex11.drv real 0m53.903s user 0m19.807s sys 0m5.869s So I tried it with my driver: timed with winedib.drv real 0m3.924s user 0m3.537s sys 0m0.191s Indeed, my tests show that there is a 50 second difference with GDI Get/SetPixel. If anyone wants to try my app, I'll send it to them :) Still, I wouldn't expect *your* app to seem much different (or work at all :P) So will all the interested parties take a look at the driver and I'd sure appreciate feedback on the direction this is going, so we move towards finishing this project beyond the summer of code. :) Jesse

3 7

Re: 0002-Basic-d3dx9-stub.patch
by H. Verbeet Aug. 27, 2007

Aug. 27, 2007

On 27/08/07, Martijn Berger <martijn.berger(a)gmail.com> wrote: > +WINE_DEFAULT_DEBUG_CHANNEL(d3d10); That's not a good idea. Also, since the dll isn't actually called d3dx9.dll, how do you intend to handle the different versions? (Arguably these dlls are outside Wine's scope, since they're not installed as part of the OS, and should be installed by the application that is using them.)

2 1

getting started...
by Ed Sutter Aug. 27, 2007

Aug. 27, 2007

Hi, I'm brand new to the list and would like to get a Windows application that I wrote (uCon) to work with wine/winelib. I've submitted it to the application database. I've tried it on Wine and it *almost* works, so I'd like to pursue this further by building uCon with Winelib (as is recommended somewhere in the documentation). That being said, I'm a bit confused... The winelib users guide mentions "winemaker", but doesn't point to where I get it. It doesn't appear to come with the Wine package (as expected); however, aside from the entire Wine source tree, I don't see anything else to download. Do I need/want the entire Wine source tree if my next step is to attempt to build my application using Winelib? Thanks in advance Ed BTW... I'm going to be doing this on a RH9 linux box.

2 3

[PATCH] Support for animated cursors
by Trent Waddington Aug. 27, 2007

Aug. 27, 2007

Test program at: http://rtfm.insomnia.org/~qg/animatedcursor.exe Probably doesn't support all the possible animated cursors supported under windows, and correct timing of animation hasn't been attempted. Trent

3 2

Re: wintrust(4/5): Test and implement SoftpubLoadMessage (with patch)
by Alexandre Julliard Aug. 27, 2007

Aug. 27, 2007

"Juan Lang" <juan.lang(a)gmail.com> writes: > + ret = data->pPDSip->pSip->pfGet(data->pPDSip->psSipSubjectInfo, > + &data->dwEncoding, 0, &size, buf); > + if (ret) > + { > + data->hMsg = CryptMsgOpenToDecode(data->dwEncoding, 0, 0, data->hProv, > + NULL, NULL); > + if (data->hMsg) > + ret = CryptMsgUpdate(data->hMsg, buf, size, TRUE); > + } > + > + if (!ret || !data->hMsg) > + err = GetLastError(); > + data->psPfns->pfnFree(buf); > + return err; That style of coding is dangerous, it assumes that all the error paths of the called functions will set last error properly. It's better to return a success/failure boolean and fetch the last error only when the actual error is needed, not as an error indication. -- Alexandre Julliard julliard(a)winehq.org

1 0

[git] Playing with gitstat (can we change date for the tags?)
by Paul Vriens Aug. 27, 2007

Aug. 27, 2007

Hi, I was just playing with gitstat (http://tree.celinuxforum.org/gitstat/) to see if it give some nice graphs for Wine as well (on my local box). I can see all the tags but for some reason a lot of tags (from wine-0.0.2 to wine-0.7 and after that wine-940201 to wine-980927, so basically every tag before Alexandre's "Initial revision") have nearly the same tagger/author date (around November 30th 2005). This messes up the ordering of the tags. Is there something I can do about this? (man git-tag tells me one shouldn't change tags afterwards). (I've changed the necessary perl-script to only include the tags that are correct so I do have some output). -- Cheers, Paul.

2 1

Re: Imm32: Update position of default IME window
by Alexandre Julliard Aug. 27, 2007

Aug. 27, 2007

Aric Stewart <aric(a)codeweavers.com> writes: > + > + /* make sure we are on the desktop */ > + GetClientRect(GetDesktopWindow(),&desk_rect); You have to use GetMonitorInfo to support multi-monitor setups correctly. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [patch] Garbage code in text string display
by Guan Xin Aug. 27, 2007

Aug. 27, 2007

On 8/23/07, Juan Lang <juan.lang(a)gmail.com> wrote: > You may generally post source to wine-devel if it's short and to the > point. Please don't post a binary. Acturally, this bug is obvious as I have pointed it out. No source is needed for demonstration. Also I always programmed with Borland's AFX when I used Windows. So my source is unlikely to compile under WINE or MSVC. Recently I have no Windows machine and cannot learn Windows API programming to write those tests. > Right to the first point, which is why we write tests that pass on > Windows, and fix Wine to match the tests. This obviates the need to > look at Windows source. You must be mistaken. Tests that fail when WINE is not patched and pass when patched do not prove correctness of the midification. They only increase the possibility of its correctness. I am sorry I never learnt computer science and misunderstood your requisition. Here is an analogy to show what you are doing: in order to find out how to turn off the light, a computer scientist tried to place a piece of wire into the outlet and made a short-circuit. He succeeded. His `test case' never failed as far as he lived. The computer scientist electrocuted himself.

2 2