August 2007 - Wine-Devel - list.winehq.org

Problem with dlls/winex11.drv/opengl.c, revision 1.104
by Chris Rankin Aug. 14, 2007

Aug. 14, 2007

Hi, With the update of dlls/winex11.drv/opengl.c from revision 1.103 to 1.104, World of Warcraft no longer starts in OpenGL mode. WoW complains that my graphics card does not have "dual-TMU support". (I have a Radeon R200 with Mesa 7.1) Cheers, Chris ____________________________________________________ Which email service gives you unlimited storage? http://uk.mail.yahoo.com

2 1

[oleaut32/tests] Error when running tests on Wine, anyone?
by Paul Vriens Aug. 14, 2007

Aug. 14, 2007

Hi, Can somebody confirm if all oleaut32 tests run correctly on Wine. I'm trying to change LoadLibrary to GetModuleHandle and though it was my failure, but current GIT fails for me: ../../../tools/runtest -v -P wine -M oleaut32.dll -T ../../.. -p oleaut32_test.exe.so vartest.c && touch vartest.ok fixme:variant:VarMod Could not convert left type 4096 to 20? rc == 0x80020008 fixme:variant:VarMod Could not convert left type 8192 to 20? rc == 0x80020008 fixme:variant:VarMod Could not convert left type 16384 to 20? rc == 0x80020008 vartest.c:3128: Test failed: got VT_DATE(-1.5) expected VT_DATE(-1.4) vartest.c:3129: Test failed: got VT_R8(-1.5) expected VT_R8(-1.4) vartest: 1031879 tests executed (0 marked as todo, 2 failures), 0 skipped. make: *** [vartest.ok] Error 2 Cheers, Paul.

6 11

Our wiki software is ugly
by Scott Ritchie Aug. 13, 2007

Aug. 13, 2007

Our wiki software needs a major update, especially as we start to expect users to actually read it. For instance, look at the FAQ page: Then, click on edit and see how it should look. From what I can tell, there are a few obvious errors: 1) The wiki software is completely ignoring line breaks. I could hit return 4 times and the HTML rendered would be on subsequent lines, without a break or paragraph tag between them. 2) For some completely strange reason, if you make a list item that includes a link then the entire list item will be in a smaller font. This makes for extremely weird and inconsistent lists when a link to another wiki page is included in some, but not all, of the items. 3) Header text is almost impossible to figure out right, and there is absolutely no standard of what we should do. Is there a reason we chose the software we did? Would it be too hard to migrate to something else, or at least fix the display bugs? Thanks, Scott Ritchie

3 4

Fonts (+liberation again...)
by Louis. Lenders Aug. 13, 2007

Aug. 13, 2007

Hi , a few weeks ago posted something about if liberation fonts could be included in wine. There didn't seem to be one view of how to do that. Of course 'winetricks liberation' is great, but i'd like to see something that works out of the box on a fresh .wine. Attached is a patch, that generates Arial.ttf from liberation font (just like winetricks) but this is an attempt to get it included in wine's source. To summarize, i added a file arial.ttf2sfd that changes a liberation font into "arial.sfd", change appropriate family/font name, and then generate the arial.ttf. All is done by fonforge. Of course this patch lacks checking for presence of liberation, and has ugly hard-coded path for the liberation-font, but that could be worked on later on. Simple question: Could something like this be included in the source, otherwise i'm not gonna spend any time improving it. Any hints welcomed. Regards, louis --------------------------------- Yahoo! Answers - Get better answers from someone who knows. Tryit now. diff --git a/Make.rules.in b/Make.rules.in index a32b276..257598e 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -126,7 +126,7 @@ LINTS = $(C_SRCS:.c=.ln) # Implicit rules -.SUFFIXES: .mc .rc .mc.rc .res .res.o .spec .spec.o .idl .tlb .h .y .l .tab.c .tab.h .yy.c .ok .sfd .ttf .man.in .man _c.c _i.c _p.c _s.c +.SUFFIXES: .mc .rc .mc.rc .res .res.o .spec .spec.o .idl .tlb .h .y .l .tab.c .tab.h .yy.c .ok .sfd .ttf .ttf2sfd .man.in .man _c.c _i.c _p.c _s.c .c.o: $(CC) -c $(ALLCFLAGS) -o $@ $< @@ -179,6 +179,9 @@ LINTS = $(C_SRCS:.c=.ln) .c.ok: $(RUNTEST) $(RUNTESTFLAGS) $< && touch $@ +.ttf2sfd.sfd: + $(FONTFORGE) -script $(TOPSRCDIR)/fonts/$< $< $@ + .sfd.ttf: $(FONTFORGE) -script $(TOPSRCDIR)/fonts/genttf.ff $< $@ diff --git a/configure b/configure diff --git a/dlls/gdi32/dc.c b/dlls/gdi32/dc.c diff --git a/dlls/shell32/shell32_En.rc b/dlls/shell32/shell32_En.rc diff --git a/dlls/shell32/shellpath.c b/dlls/shell32/shellpath.c diff --git a/dlls/shell32/shresdef.h b/dlls/shell32/shresdef.h diff --git a/dlls/user32/sysparams.c b/dlls/user32/sysparams.c diff --git a/fonts/Makefile.in b/fonts/Makefile.in index 2a69d6a..35d1e71 100644 --- a/fonts/Makefile.in +++ b/fonts/Makefile.in @@ -47,11 +47,16 @@ BITMAP_FONTS = \ vgas1257.fon \ vgas874.fon +TTF2SFD = \ + arial.sfd + TRUETYPE_FONTS = \ - marlett.ttf + marlett.ttf \ + arial.ttf FONTS = \ $(BITMAP_FONTS) \ + $(TTF2SFD) \ $(TRUETYPE_FONTS) all: $(FONTS) diff --git a/fonts/arial.ttf2sfd b/fonts/arial.ttf2sfd new file mode 100644 index 0000000..2ce704e --- /dev/null +++ b/fonts/arial.ttf2sfd @@ -0,0 +1,3 @@ +Open("/usr/share/fonts/liberation/LiberationSans-Regular.ttf"); +SetFontNames("ArialMT", "Arial", "Arial"); +Generate($2); diff --git a/include/setupapi.h b/include/setupapi.h diff --git a/tools/wine.inf b/tools/wine.inf

3 2

Re: WineD3D: add opengl 1.2/1.3 constanst to wined3d_gl.h
by Roderick Colenbrander Aug. 13, 2007

Aug. 13, 2007

Skip this patch for now as it barely reduces the patch size. The real patch adds much, much more constants and that has to be merged in one go (or it can be done earlier if you want to have it behind the ifdef). Tell me what you prefer :) Roderick On Monday 13 August 2007 20:06, Roderick Colenbrander wrote: > Hi, > > Add opengl 1.2 / 1.3 constants to wined3d_gl.h because gl.h on windows is > still 1.1. Further the defines are behind an ifdef for now because most > linux headers do define them and haven't placed them behind some version > check. > > Once all changes are done the ifdef will be removed. I add it now to > prevent large patches. > > Regards, > Roderick Colenbrander

1 0

[winetest] Show missing tests in single/group results
by Paul Vriens Aug. 13, 2007

Aug. 13, 2007

Hi, (I've just remembered that there is a limit on the email size, so I'm doing it a bit differently now. The other email, including the screenshots, will probably come through as well) Before sending this to wine-patches I would like people to have a look first. This patch makes sure that missing tests are shown in the test results, both when there is only one system in a group (f.e. Win98) or multiple systems in a group. On 'http://www.xs4all.nl/~pvriens/200708031000.old.single/' you can see the current state of the test results. When a test is missing a '.' is shown (this is of course different from a missing test where we don't have results at all but that's shown as a '.' as well). On 'http://www.xs4all.nl/~pvriens/200708031000.old.group/' you can see the current state when a group of systems is involved. When tests are missing for a group, a '.' is shown with a link to the group overview. There is however no missing test output in the group overview (for example gdiplus and pdh) 'http://www.xs4all.nl/~pvriens/200708031000.new.single/' shows the new results page for single tests. Instead of a single '.' there is a failure shown (red box) and a skip border (as these tests have not run). There is still a '.' which could maybe better be a '?'. There is also a 'onMouseOver' hint when you go over the '.'. 'http://www.xs4all.nl/~pvriens/200708031000.new.group/' shows the new results when a group is involved. The main summary is still the same as in the old one, but the group results now also show the missing tests (see gdiplus and pdh again). Again there is a 'onMouseOver' hint in the group results. Remember that this is still without winetest producing output about missing dll's. Next patches will: - add a missing dll as one of the reasons for missing tests - add some better clue's on the main summary for multiple systems in a group (not a single '.' but maybe the same 'failed and skipped'). As said, one of the thoughts I had was to replace the '.' with a '?' in case of missing tests for an unknown reason but I'm not sure about that yet. Comments/remarks etc.. are welcome. I'd also like to hear about other idea's for this page to make it useful for everybody. Apart from the fact that we probably should have more exposure to the fact that we have such a page/tool. We saw an immediate rise (slowed down again) in test results as soon as winetest was mentioned on 'http://tweakers.net/meuktracker/15817/Wine-0.9.42.html' (in Dutch). There it was also mentioned that some machines crashed because of the tests etc.. (maybe a wine-winetest component on bugzilla could help with that which we could reference on the main test.winehq.org/data/*/index.html pages). Cheers, Paul.

4 5

Re: wined3d: Activate context before applying fbo state.
by H. Verbeet Aug. 13, 2007

Aug. 13, 2007

On 13/08/07, Vitaliy Margolen <wine-patches(a)kievinfo.com> wrote: > Fixes bugs 9293 and 9269. > --- > dlls/wined3d/device.c | 7 ++----- > 1 files changed, 2 insertions(+), 5 deletions(-) > Looks ok to me, fwiw.

1 0

win16 tests
by Jennifer Lai Aug. 13, 2007

Aug. 13, 2007

Hi, I've collected and fixed some win16 tests. Since they are not going to be included in the wine tree, I've placed them under http://www.cs.ucla.edu/~jlai/win16test/ In order to build these tests, Open Watcom was used. The tar ball also includes the scripts of installing Open Watcom, building the tests, and running them. Details are described in the README. More tests will be added in the future, and comments are greatly appreciated. Thank you, Jennifer Lai

2 1

Allow building of ddraw.dll / ddrawex.dll on MingW
by Roderick Colenbrander Aug. 13, 2007

Aug. 13, 2007

Allow building of ddraw/ddrawex on mingw. By default the dxguid from mingw is used which doesn't work for us as it is outdated. Regards, Roderick Colenbrander

4 4

Re: WGL: proper stereo / double buffering support for ChoosePixelFormat
by Chris Robinson Aug. 12, 2007

Aug. 12, 2007

On Sunday 12 August 2007 05:44:31 am Roderick Colenbrander wrote: > pglXGetFBConfigAttrib(gdi_display, fmt->fbconfig, > GLX_DOUBLEBUFFER, &value); > - if (value) dwFlags |= PFD_DOUBLEBUFFER; > - if (!(ppfd->dwFlags & PFD_DOUBLEBUFFER_DONTCARE) && > ((ppfd->dwFlags^dwFlags) & PFD_DOUBLEBUFFER)) > - { > - TRACE("dbl buffer mismatch for iPixelFormat=%d\n", i+1); > + if( (value & PFD_DOUBLEBUFFER) && (ppfd->dwFlags && > PFD_DOUBLEBUFFER) ) { This change doesn't look quite right. 'value' will be set to true or false, it won't have the PFD_DOUBLEBUFFER flag set coming from a GLX function. And checking the ppfd->dwFlags should use a single &, not a double &&. Also, even with those fixes, it'll only attempt to match when the doublebuffer flag is set on both the fbconfig and the wanted pixel format, not if it's unset on both, or if it's supposed to be ignored. As well, the check will preempt the other fields if a doublebuffer match was already found. Same with the stereo flag.

1 0

Re: schannel status and crypt32 blockage
by Juan Lang Aug. 12, 2007

Aug. 12, 2007

Hi Yuval, > [Should I repost on-list?] Yeah, let's talk about this in the open. > I've created a test that connects to https://wiki.winehq.org, and > found the following: Excellent! Glad it's getting some attention. > - It fails in rsaenh due to OPAQUEKEYBLOB not supported in CPExportKey > and CPImportKey, with CALG_RC4 and CALG_SCHANNEL_MAC_KEY. I've > implemented some hack (can't pass through AJ), and it continues. Interesting. I haven't tried this case, but it doesn't look (from looking at rsaenh) like this should be too tough. Send the hack, and I'll try to take a look when I get a chance. > - I can't get a testcase for EncryptMessage/DecryptMessage that works > on Windows, so I can't tell how far have I got. I don't know what I do > wrong. Okay. You might ask again on-list with some code, there are a couple people here (e.g. Kai) that are more knowledgeable about secur32. > I've also tried googletalk. > - It fails immediately after CertGetCertificateChain reports it is a > stub. Right. I have a partially done implementation of that lying around somewhere that I can send you if you like. It may not work right away, I'm not positive CertGetIssuerCertificateFromStore is right just yet. I'm planning to work on that very soon, most likely next week, so if you can wait that long I should have something. > I'd like to note that native crypt32 is not an option (not even > temporary, such as schannel), as it tries to use keysvc. So basically > I'm blocked. Okay. > Are you planning on implementing Cert*CertificateChain soon? Yes :) > What about rsaenh, is it in the scope of your work? Not exactly. I'm just trying to get iTunes to start. But I'd probably take a look anyway ;) Cheers, --Juan ____________________________________________________________________________________ Pinpoint customers who are looking for what you sell. http://searchmarketing.yahoo.com/

1 0

wininet: Don't peek data in InternetQueryDataAvailable if there is no more to be expected.
by Misha Koshelev Aug. 11, 2007

Aug. 11, 2007

I am going to send a more complete try2 patchset tomorrow (the patch as given is correct but there are some more problems with InternetQueryDataAvailable that need to be fixed, like the fact that it actually doesn't return ERROR_NO_MORE_FILES when all HTTP data has been retrieved). Misha

1 0

landfill.bugzilla.org?
by Dan Kegel Aug. 11, 2007

Aug. 11, 2007

Why are all our new bugs cc'd to bugbot(a)landfill.bugzilla.org? I suspect that's a default that needs to be removed...

3 2

re: Our wiki software is ugly
by Dan Kegel Aug. 11, 2007

Aug. 11, 2007

Scott wrote: > ... > 3) Header text is almost impossible to figure out right, and there is > absolutely no standard of what we should do. [The amazing diversity in wiki syntaxes in the world makes me want to puke. Why not just use HTML syntax directly? It's at least well-defined.] Yeah, it's frustrating and looks bad. But at least the server is well-run :-) - Dan

1 0

Re: WineD3D: Use the proper depth stencil format
by Chris Robinson Aug. 10, 2007

Aug. 10, 2007

On Friday 10 August 2007 10:33:31 am Roderick Colenbrander wrote: > Hi, > > This patch lets WineD3D use the proper depth stencil format. The format is > retrieved from the WINED3DPRESENT_PARAMS. The proper format can improves > performance on platforms like Windows which offer more onscreen > pixelformats. > > Regards, > Roderick Colenbrander Isn't it normal to pass structs as a pointer, properly const-ified?

1 0

Thank you to Max Kanat -Alexander and Everything Solved
by Jeremy White Aug. 10, 2007

Aug. 10, 2007

Say, I wanted to note that the Bugzilla upgrade is being done, by and large, due to the very professional and helpful efforts of Max Kanat of Everything Solved (www.everythingsolved.com) I don't know that I've ever seen Jeremy Newman *happy* about Bugzilla, it's rather freaky <grin>. So, thanks! Cheers, Jeremy p.s. Yes, there are still kinks and issues with bugzilla; folks are working furiously on #winehackers to iron out the worst of them right now.

2 1

win16 tests
by Jennifer Lai Aug. 10, 2007

Aug. 10, 2007

Hi, I've collected and fixed some win16 tests. Since they are not going to be included in the wine tree, I've placed them under http://www.cs.ucla.edu/~jlai/win16test/ <http://www.cs.ucla.edu/%7Ejlai/win16test/> In order to build these tests, Open Watcom was used. The tar ball also includes the scripts of installing Open Watcom, building the tests, and running them. Details are described in the README. More tests will be added in the future, and comments are greatly appreciated. Thank you, Jennifer Lai

1 0

Bugzilla Downtime
by Jeremy Newman Aug. 10, 2007

Aug. 10, 2007

Bugzilla will be going offline starting at 10:00 CST. We are performing upgrades to the site. The rest of WineHQ.org should be un-effected by this upgrade.

1 1

[MSI/tests] ConvertSidToStringSid not available on win98/NT4
by Paul Vriens Aug. 10, 2007

Aug. 10, 2007

Hi, ConvertSidToStringSid (advapi32) is not available on win98/NT4 so the msi tests (all of them) do not run on those platforms currently. I could use skip but that basically would mean no MsiQueryProductState, MsiQueryFeatureState and MsiQueryComponentState tests. Another thing is to copy over the ConvertSidToStringSid implementation from advapi32 to the relevant tests. Any other ideas (or better yet, solutions)? Cheers, Paul.

4 5

Re: [2/2] winex11: Don't use context-specific info when initializing
by Roderick Colenbrander Aug. 10, 2007

Aug. 10, 2007

I would like to keep this GL_RENDERER/GL_VENDOR stuff around although it might not be 100% correct in all cases (on some cards there's indeed a difference between direct and indirect rendering). To be correct also add similar code to the glx context creation code. Roderick On Friday 10 August 2007 11:29, Chris Robinson wrote: > Doesn't make much sense to use info from a temporary context when the > context the app eventually sets may be different (such is the case for > direct vs. indirect rendering on certain drivers, or multiple > screens/output devices).

1 0

[programs] add winerun for starting programs from wine.desktop
by Kirill K. Smirnov Aug. 10, 2007

Aug. 10, 2007

>+/* >+ * Wordpad implementation >+ * >+ * Copyright 2007 by Damjan Jovanovic >+ * It is not wordpad, is it? >+ ok = CreateProcessW(exePath, NULL, NULL, NULL, FALSE, 0, NULL, currentDirectory, >+ &startupInfo, &processInfo); This code does not run console apps correctly (use CREATE_NEW_CONSOLE flag). -- Kirill

1 0

Re: [2/2] winex11: Don't use context-specific info when initializing
by Christoph Frick Aug. 10, 2007

Aug. 10, 2007

On Fri, Aug 10, 2007 at 02:29:49AM -0700, Chris Robinson wrote: @@ -137,7 +132,7 @@ typedef struct wine_glpbuffer { } Wine_GLPBuffer; static Wine_GLContext *context_list; -static struct WineGLInfo WineGLInfo = { 0 }; +static struct WineGLInfo WineGLInfo; static int use_render_texture_emulation = 1; static int use_render_texture_ati = 0; static int swap_interval = 1; why is this changed? its a Good Thing to have global structs initialized so they fail earlier under abuse. -- cu

2 1

Re: [1/2] winex11: NV_texture_rectangle and NV_vertex_array_range do not have WGL extension names
by Roderick Colenbrander Aug. 10, 2007

Aug. 10, 2007

Both are 'fake' WGL extensions. I agree that no string should be displayed in either case and that we don't need a check for NV_texture_rectangle. The loading of the NV vertex array range stuff depending on the presence of the GL extension of which it is part is fine. Yes, GL extensions are context dependend but relying on glXGetProcAddress is even more evil (as it doesn't have to return NULL). Upto now I haven't seen problems with this. On Friday 10 August 2007 11:15, Chris Robinson wrote: > This patch and the next are designed to remove the need for > context-specific information taken from a temporary context. For this one, > the aforementioned extensions don't have WGL extension names. Their > respective specs and a recent nvidia card/driver's WGL extension output > confirms this.

1 0

Re: winex11: added missing sync_current_drawable calls
by Kai Blin Aug. 9, 2007

Aug. 9, 2007

On Thursday 09 August 2007 15:59:59 plams wrote: > Here's a patch to fix a regression since 0.9.28 (in response to bug > 9029). OpenGL scissoring had apparently been wrapped in commit > 715d0e84097cb2dc07369c4e1cec8cf8a41e9035 but it seems that it made it > possible to make a glDisable(GL_SCISSOR_TEST) call that would leave GL > in some pseudo-state where the scissor test was STILL active (and vice > versa for glEnable) until e.g. a wglMakeCurrent or wglViewport call > was made. This patch should fix that (and thus resolve bug 9029). You need to provide your real name for the change log, otherwise your patch can't be accepted. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

re: ANNOUNCE: Wine/Mono Regression Test Suite
by Dan Kegel Aug. 9, 2007

Aug. 9, 2007

Matt wrote: > ...I've found that running the mono regression test suite has > given me a better idea of how to approach debugging mono/wine. > ... > http://mhjones.org/wine/wine-tests/wine-test-reader.tar.gz I downloaded this and had a look just now. The instructions still refer to the deprecated 1.1 branch of mono, and I hear to run on wine, one needs something newer than the latest released version of mono. So I tried building mono from the trunk. My dapper system was missing some things mono seems to need, so I expanded on the script in the readme a bit, and came up with #!/bin/sh set -xe MONOBUILDDIR=/data/dkegel/mono-cvs mcs --version || sudo apt-get install mono-devel libtool --version || sudo apt-get install libtool automake-1.9 --version || sudo apt-get install automake1.9 automake --version | grep 1.9 || sudo update-alternatives --set automake /usr/bin/automake-1.9 mkdir -p $MONOBUILDDIR cd $MONOBUILDDIR svn co svn://anonsvn.mono-project.com/source/trunk/mono cd mono ./autogen.sh --build i486-linux-gnu make This goes well for a while, but fails with /bin/sh: line 1: cd: ../../mcs: No such file or directory if test -w ../../mcs; then :; else chmod -R +w ../../mcs; fi chmod: cannot access `../../mcs': No such file or directory make[2]: *** [all-local] Error 1 make[2]: Leaving directory `/usr/local/google/bigdata/dkegel/mono-cvs/mono/runtime' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/usr/local/google/bigdata/dkegel/mono-cvs/mono' make: *** [all] Error 2 Can you update your README to show how to build some flavor of mono-1.2 that runs under Wine? Thanks, Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: Wine Kernel Handle Support Module
by Michael Ost Aug. 9, 2007

Aug. 9, 2007

>>> I know there is some discussion of what should be put in the kernel >>> module, so I am asking for advice on what to implement... ie. just >>> handles, everything wineserver does, etc. >> The first question is: >> Why do you want to do that and what specifically do >> you want to achieve? > > A small step towards less overhead in client <-> server calls? One _big_ vote for putting thread sync primitives --- events, semaphores, mutexes and critical sections --- in. We had to build a custom Wine to get acceptable realtime performance (thanks, Ulrich!). The client <-> server were causing high priority threads to block on low priority ones. I guess a test case would be something that shows how a high priority thread blocking on a sync primitive, while some low priority thread is doing some unrelated server heavy stuff, like lots of graphics updates. Cheers... mo

1 0

[SNMPAPI] How to fix the tests for win98 and NT4?
by Paul Vriens Aug. 9, 2007

Aug. 9, 2007

Hi, There are several functions in the util.c test that are not available on win98 and NT4. That can be dealt with easily. Almost all tests with a NULL parameter crash on win98/NT4. I know that a few weeks back we talked about ignoring win98 if it would mean skipping a lot of tests, but now NT4 is involved as well. I could introduce a variable of course that's set when we are on NT4 or lower (because of the missing functions) and don't run the 'NULL' tests. Any ideas, comments? Cheers, Paul.

2 1

Re: exporting file associations for linux desktops
by Misha Koshelev Aug. 9, 2007

Aug. 9, 2007

> To register those verbs for Linux desktops, some sort of command-line > wrapper around ShellExecute would be needed. I think this is a good > idea anyway. Does Windows have anything like that? Is it worth it for > me to try writing something like that based on winelib? Well this is exactly the start program which is already implemented. In fact I thought about this problem myself a bit, the problems with start right now for this purpose (starting wine associated files from linux) are: 1. start currently doesn't understand a simple UNIX path, easily fixed by prepending a Z: (assuming this is the drive the user has mapped to the UNIX root dir) 2. there is no standalone winestart program, and at least from my experimentation with Right Click->Open File With... on GNOME (or whatever the menu item is called), it won't let you put in "wine start" or wine start or the sort. What I actually do right now is use this shell script (I almost started working on this problem but then since the shell script was so easy I decided to focus on other things, but am still very interested in seeing it solved): #!/bin/sh wine start Z:$* And just associating it with my file type (well the problem with doing what I am doing is I am just associating it with a file .gb which I guess GNOME puts into some kind of text/plain type, so anything that is a text file ends up being opened with notepad on wine instead of gedit... I am too lazy to make it any more complex on my computer for now). Anyway, just though this info might help if you were not already aware, as the start program is definitely this wrapper around ShellExecute that already exists. One possibility would be to extend it to handle UNIX paths and then have it compiled and installed as a standalone winestart - like the other wine standalone programs we install, another is just to have the shell script somewhat like above installed (dangerous as Z: may not be mapped to the root so this would have to figured out) - I believe wineshelllink which is installed is a shell script, or maybe even go the route of letting the wine binary itself ShellExecute things (haven't really looked at it/thought this out in detail). Anyway, just my two cents. Thanks for thinking about/hopefully working on this. Misha > > > -- > Vincent Povirk

4 6

[Winetest] Possible removal of LoadLibrary and friends in the conformance tests
by Paul Vriens Aug. 9, 2007

Aug. 9, 2007

Hi, With the current version of winetest, conformance tests for which the main dll is not available will not run anymore. This will be reported on test.winehq.org. We will be seeing the new approach as of 12:00 GMT when the new winetest.exe is available and the first tests come in. Several tests currently check for the existence of the dll via LoadLibrary and do a lot of GetProcAddress calls to retrieve function pointers. This should not be needed anymore in most cases. The tests that come to mind: d3d8 d3d9 d3drm gdiplus localspl localui pdh uxtheme and there are (and will be in the future) others. My plan, and this is open for discussion of course, is to: 1. Add the main dll back as part of the IMPORTS in the Makefile.in files 2. Change LoadLibrary to GetModuleHandle and still use GetProcAddress to catch unexported functions (for a short period). We do need to reporting missing functions. 3. Remove GetModuleHandle and/or GetProcAddress's if possible and make more use of 'skip' if needed. This will be a lengthy process so if there are volunteers, please step up. Eventhough this is some considerable amount of work to be done, in the end the code will be cleaner (and several lines shorter). Comments/remarks ? Cheers, Paul.

5 8

Re: WineD3D: better pixelformat selection code
by H. Verbeet Aug. 9, 2007

Aug. 9, 2007

On 09/08/07, Roderick Colenbrander <thunderbird2k(a)gmx.net> wrote: > Hi, > > This code lets WineD3D use the pixelformat of the D3D device. The code helps > on Windows where OpenGL offers multiple pixelformats. > The stencil column is probably useful for determining if we need an stencil attachment for FBOs as well. >+int count_bits(int mask) >+{ >+ int i, count=0; >+ for(i=0; i<32; i++) >+ { >+ if(mask & (1<<i)) >+ count++; >+ } >+ return count; >+} The "classical" way to do that would be something like this: unsigned int count_bits(unsigned int mask) { unsigned int count; for (count = 0; mask; ++count) { mask &= mask - 1; } return count; } Ie, simply mask out the set bits one by one until none are set, rather than looping over all of them.

1 0

Re: user32: CallWindowProc[AW] for mismatched built-in winprocs should take into account if the window is Unicode (with testcase, fixes bug #9198)
by Dmitry Timoshkov Aug. 8, 2007

Aug. 8, 2007

"Mikolaj Zalewski" <mikolaj(a)zalewski.pl> wrote: > --- a/dlls/user32/tests/class.c > +++ b/dlls/user32/tests/class.c > @@ -32,6 +32,7 @@ > #include "winreg.h" > #include "wingdi.h" > #include "winuser.h" > +#include <commctrl.h> /* for WC_EDITW */ Besides using braces instead of quotes to match existing style it's not really nice to include commctrl.h in a user32 (more lower level) test. It shouldn't be too hard to add "Edit" in WCHAR notation. > /*********************************************************************** > */ > static void ClassTest(HINSTANCE hInstance, BOOL global) > @@ -560,7 +566,12 @@ static void test_defwndproc() > { > static const char classA[] = "deftest"; > static const WCHAR classW[] = {'d','e','f','t','e','s','t',0}; > + WCHAR unistring[] = {0x142, 0x40e, 0x3b4, 0}; /* a string that would be destoryed by a W->A->W conversion */ Any other string should work just fine. In the current form the test will fail for some locales. > diff --git a/dlls/user32/winproc.c b/dlls/user32/winproc.c > index 27b31a1..4feb3d5 100644 > --- a/dlls/user32/winproc.c > +++ b/dlls/user32/winproc.c > @@ -2257,7 +2257,17 @@ LRESULT WINAPI CallWindowProcA( > > if (!func) return 0; > > - if (!(proc = handle_to_proc( func )) && !(proc = find_builtin_proc( func ))) > + /* for built-in procs we do as if the second item was a thunk */ > + if ((proc = find_builtin_proc( func )) != NULL) > + { > + if (func == proc->procA || !IsWindowUnicode( hwnd )) > + call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > + else > + call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > + return result; > + } > + > + if (!(proc = handle_to_proc( func ))) > call_window_proc( hwnd, msg, wParam, lParam, &result, func ); > else if (proc->procA) > call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > @@ -2281,8 +2291,18 @@ LRESULT WINAPI CallWindowProcW( WNDPROC func, HWND hwnd, UINT msg, > LRESULT result; > > if (!func) return 0; > + > + /* for built-in procs we do as if the second item was a thunk */ > + if ((proc = find_builtin_proc( func )) != NULL) > + { > + if (func == proc->procW || IsWindowUnicode( hwnd )) > + call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > + else > + call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > + return result; > + } > > - if (!(proc = handle_to_proc( func )) && !(proc = find_builtin_proc( func ))) > + if (!(proc = handle_to_proc( func ))) > call_window_proc( hwnd, msg, wParam, lParam, &result, func ); > else if (proc->procW) > call_window_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > @@ -2340,7 +2360,17 @@ INT_PTR WINPROC_CallDlgProcA( DLGPROC func, HWND hwnd, UINT msg, WPARAM wParam, > > if (!func) return 0; > > - if (!(proc = handle_to_proc( func )) && !(proc = find_builtin_proc( func ))) > + /* for built-in procs we do as if the second item was a thunk */ > + if ((proc = find_builtin_proc( func )) != NULL) > + { > + if (func == proc->procA || !IsWindowUnicode( hwnd )) > + call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > + else > + call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > + return result; > + } > + > + if (!(proc = handle_to_proc( func ))) > ret = call_dialog_proc( hwnd, msg, wParam, lParam, &result, func ); > else if (proc->procA) > ret = call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > @@ -2368,8 +2398,18 @@ INT_PTR WINPROC_CallDlgProcW( DLGPROC func, HWND hwnd, UINT msg, WPARAM wParam, > INT_PTR ret; > > if (!func) return 0; > + > + /* for built-in procs we do as if the second item was a thunk */ > + if ((proc = find_builtin_proc( func )) != NULL) > + { > + if (func == proc->procW || IsWindowUnicode( hwnd )) > + call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procW ); > + else > + call_dialog_proc( hwnd, msg, wParam, lParam, &result, proc->procA ); > + return result; > + } Please use spaces instead of tabs to match current formatting. -- Dmitry.

2 1

Wine Kernel Handle Support Module
by James Keane Aug. 8, 2007

Aug. 8, 2007

I have been working on something that might be useful for kernel integration. It is a way for wine to create its own interrupt, so that a wine server/kernel/handle/whatever function could be called from userspace with a simple INT 0xwhatever. Just as linux uses int 0x80. The only problem I could see with this technique is that it directly modifies the IDT, which only exists on i386/amd64 architectures, so that means we would have to find something else. I am not sure if this is the direction that some people want to take, because I am sure this modification of the IDT would be considered improper by kernel types but come on, I mean i386 has something like 200 software interrupts and linux uses only one. As it stands now, I have code that works perfectly with amd64 processors and just need to implement the actual wine system calls for handles or whatever it is. i386 support is a stones throw away, I just need to setup a virtual machine. I know there is some discussion of what should be put in the kernel module, so I am asking for advice on what to implement... ie. just handles, everything wineserver does, etc.

4 3

exporting file associations for linux desktops
by Vincent Povirk Aug. 8, 2007

Aug. 8, 2007

This was something I thought we wanted for wine for a long time, but I can't find any literature suggesting that's the case. So I'll just explain it here. As it is right now, we have a filetype/association system in Wine's registry, and we have a completely separate one in most Linux desktops. They do not talk to each other. Wine's system relies primarily on extensions because that's what Windows does, but the Linux system works based on MIME Types. I would like to see this gap bridged in one direction by exporting the information in Wine's registry in a simplified format and converting it to something useful for Linux desktops. From what I've seen so far, this looks surprisingly simple. On the Linux end, MIME Types can be registered as described at http://www.freedesktop.org/wiki/Specifications/AddingMIMETutor (only using ~/.local/share instead of /usr/local/share). fd.org doesn't seem to have a standard for registering actions so that would need to be desktop-specific, but I don't expect any major problems from that. The Windows registry does appear to contain some MIME Types, but they're spotty and unreliable. I'm told, though, that most desktops can cope with things like application/x-extension-html even when text/html exists. Generating types like that is probably the way to go. From there, it's a simple matter to get a list of verbs that apply to files with each extension. To register those verbs for Linux desktops, some sort of command-line wrapper around ShellExecute would be needed. I think this is a good idea anyway. Does Windows have anything like that? Is it worth it for me to try writing something like that based on winelib? Also, what's the best way to design this if I want to see it added to Wine? I know how I'd do it as a set of external programs, but I'd rather avoid that. Attached is a simple python script I wrote that prints all of the information I think is necessary to be exported from Wine's registry. I know python is the worst thing I could use if I want something in Wine, but it should be good enough that I can try to import the information on the Linux end before spending too much time on something that may or may not ultimately be useful. -- Vincent Povirk

2 1

Wine components: gdiplus
by Evan Stade Aug. 8, 2007

Aug. 8, 2007

Hi, Could we add gdiplus to the bugzilla components list? thanks. -- Evan Stade

1 0

Re: Rob Shearman : secur32: Split the NTLM credential and context handles into separate objects.
by Kai Blin Aug. 8, 2007

Aug. 8, 2007

On Wednesday 08 August 2007 15:59:23 Alexandre Julliard wrote: > > secur32: Split the NTLM credential and context handles into separate > objects. > > This prevents races with two threads using the helper object at the same > time on two different context handles, eliminates the need to free the > credential handle after freeing the context handles and also prevents a Rob, thanks for cleaning up the mess. This looks more sane now. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: user32: CallWindowProc[AW] for mismatched built-in winprocs should take into account if the window is Unicode (with testcase, fixes bug #9198)
by Alexandre Julliard Aug. 8, 2007

Aug. 8, 2007

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > + hwnd = CreateWindowExW(0, classW, NULL, WS_OVERLAPPEDWINDOW, > + CW_USEDEFAULT, CW_USEDEFAULT, 680, 260, NULL, NULL, GetModuleHandleA(NULL), 0); > + ok(IsWindowUnicode(hwnd), "\n"); > + SetWindowLongPtrW(hwnd, GWLP_WNDPROC, (LONG_PTR)pDefWindowProcA); > + ok(IsWindowUnicode(hwnd), "\n"); > + ok(GetWindowLongPtrW(hwnd, GWLP_WNDPROC) == (LONG_PTR)pDefWindowProcW, "\n"); > + ok(GetWindowLongPtrA(hwnd, GWLP_WNDPROC) == (LONG_PTR)pDefWindowProcA, "\n"); > + SetWindowLongPtrA(hwnd, GWL_WNDPROC, (LONG_PTR)ClassTest_WndProc); > + ok(IsWindowUnicode(hwnd) == FALSE, "\n"); Please use meaningful error messages in the ok() calls. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Wine Kernel Handle Support Module
by Dan Kegel Aug. 8, 2007

Aug. 8, 2007

keane wrote: > I am not sure if this is the direction that some people want to take, > because I am sure this modification of the IDT would be considered > improper by kernel types but come on, I mean i386 has something like > 200 software interrupts and linux uses only one. Do not anger the kernel gods, for they will not take your patch. You are putting the cart before the horse, If you want to use a kernel module, please figure out why first, and work on solving that problem using standard kernel idioms. Linus has said that he would take a patch to add support for win32 system calls if it solved a real problem. Albert Calahan mentioned a few possible benefits in a thread seven years ago: http://marc.info/?l=linux-kernel&m=96954760832002&w=2 You might dig around in that thread for ideas. - Dan

1 0

Re: programs/wineconsole: Correctly display chars 00..1F and 7F [try 2]
by Kirill K. Smirnov Aug. 8, 2007

Aug. 8, 2007

Hi, Alexandre, > > > > Is there something wrong with my patch? Did I miss something important? > > I'm not at all convinced that the conversion has to happen at that > point. Do you have a test app that demonstrates this? I've written test application, which writes control chars and performs readback for comparision. It's behaviour heavily depends on console font: 1) True Type (lucida). Control chars are displayed as square boxes, ReadConsoleOutputCharacters[A|W] return codes [0..31]. 2) Raster (fixedsys). Control chars are correctly displayed as glyphs, ReadConsoleOutputCharacterA returns codes [0..31], ReadConsoleOutputCharacterW returns unicode glyphes. It seems I stumbled upon the same strange insane console behaviour I observed while working upon console codepages. (http://www.winehq.org/pipermail/wine-devel/2007-May/056511.html) Since wine renders fonts in his specific way (freetype, AFAIK), I propose the following: 1) Display control characters as glyphes. (like fixedsys). 2) ReadConsoleOutputCharacter[A|W] both should return characters without any corrupting - if I wrote [0..31] I expect [0..31], if I wrote unicode glyphes, I expect unicode glyphes to be returned. (like TrueType) My patch assumes this behaviour. Of course, I wanted to write proper wine test case, but it is impossible due to different default console fonts under Windows - test will fail. -- Kirill

1 0

Re: [kernel32/tests 2/2] Skip all tests if one W-function can't be found
by Paul Vriens Aug. 8, 2007

Aug. 8, 2007

On 8/7/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > (Should be applied after "[kernel32/tests] Changed skip message"). > > There are to many W-functions called so skip everything if the first function is > not implemented. This makes the test not crash on win95/win98. > > Changelog > Skip all tests if one W-function can't be found > > Cheers, > > Paul > > > Don't use this one. I'll sent an easier fix. The "[kernel32/tests] Changed skip message" can still be applied though. Cheers, Paul.

1 0

Re: WineD3D: move fake context code over to WGL
by Alexandre Julliard Aug. 8, 2007

Aug. 8, 2007

Roderick Colenbrander <thunderbird2k(a)gmx.net> writes: > Subject: [PATCH] Move WineD3D_CreateFakeGLContext and friends over > to WGL. For this we need a HDC and one received from lets say > GetDC(0) won't do. Further this HDC needs CS_OWNDC set. For this > reason we need our own window class. Why does it need CS_OWNDC? That sounds like a bug. -- Alexandre Julliard julliard(a)winehq.org

3 2

[Winetest] Status update (rsabase and secur32)
by Paul Vriens Aug. 7, 2007

Aug. 7, 2007

Hi, The new winetest is running fine and new reports are produced (http://test.winehq.org/data/200708071000/) I have seen at least 2 things so far that I need some info on. rsabase.dll is not available on for example w2k3 and vista but the tests ran in the past. secur32.dll is not available on for example NT4 but the current tests check if security.dll is available instead. What should we do to cater for the above: - we could move for example rsabase tests to rsaenh (we forward everything to rsaenh as well) and something similar for secur32. - we could implement an exception list in winetest for these particular cases. Remarks/Comments? Cheers, Paul.

3 3

Missing library - faultrep.
by Peter Dons Tychsen Aug. 7, 2007

Aug. 7, 2007

Hello. Wine is missing the library "faultrep". The library comes with Windows, and is used by apps for error reporting. Most apps don't really need it (unless something goes wrong), but simply require the DLL to be present. To start with i just wanted to add the DLL to Wine. I tried to submit a patch for this missing lib, but got zero response. Probably because there was something wrong with my commit. Any guess on what was wrong? /Pedro

2 4

Patch: VarWeekdayName
by Jiří Paleček Aug. 7, 2007

Aug. 7, 2007

Hello, I want to ask, is anything wrong with this patch? http://www.winehq.org/pipermail/wine-patches/2007-July/041434.html I'm asking because I have other patches, but don't know if it is worthwhile to send them. Regards Jiri Palecek

8 21

Re: [winecfg] Show version again in About box
by Dmitry Timoshkov Aug. 7, 2007

Aug. 7, 2007

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > 'Wine 0.9.42' looks so much nicer than 'PACKAGE_STRING'. Thanks for catching this. Although a comment explaining why config.h is needed while there is no visible usage of #ifdef HAVE_xxx macros would be nice. -- Dmitry.

1 0

Re: [2/6] gdiplus: added GdipCreateBitmapFromFile
by Alexandre Julliard Aug. 7, 2007

Aug. 7, 2007

"Evan Stade" <estade(a)gmail.com> writes: > + CloseHandle(file); > + > + if(CreateStreamOnHGlobal(buff, TRUE, &stream) != S_OK){ > + ERR("could not make stream\n"); > + GdipFree(buff); > + return GenericError; > + } You should create a stream on the file directly instead of reading it in first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/6] gdiplus: added GdipBitmapLockBits/GdipBitmapUnlockBits
by Alexandre Julliard Aug. 7, 2007

Aug. 7, 2007

"Evan Stade" <estade(a)gmail.com> writes: > + bm_is_selected = (BOOL) hdc; That's ugly, you should use something like (hdc != 0) instead. > + stride = bmi.bmiHeader.biWidth * bitspp / 8; > + stride += stride % 4; This doesn't do what you want. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: #1 winhttp: Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet.
by Robert Shearman Aug. 6, 2007

Aug. 6, 2007

Hans Leidekker wrote: > Forward WinHttpTime{From, To}SystemTime to their counterparts in wininet. > We shouldn't be implementing winhttp on top of wininet as there are functions such as WinHttpSetCredentials (http://msdn2.microsoft.com/en-us/library/Aa384112.aspx) that can't be implemented on top of wininet functions. There are also issues with different error codes being returned as well as different callbacks (http://msdn2.microsoft.com/en-us/library/aa383917.aspx) -- Rob Shearman

5 7

FW: [Bug 2520] menu bar problem
by Ann & Jason Edmeades Aug. 6, 2007

Aug. 6, 2007

>Vitaliy >Jason, please don't forget to cc wine-bugs when you reassign the bug. Yeah, sorry... Its late here :-) Out of interest, why don't we fix bugzilla to always enforce that userid (ie if it gets removed, it automatically gets inserted back). I'm sure I'm not the only one who forgets to do it sometimes? Jason

1 0

Re: [WINE] WIDL regression between 0.9.38 and 0.9.39
by Dan Hipschman Aug. 6, 2007

Aug. 6, 2007

On Mon, Aug 06, 2007 at 04:24:39PM +0200, Herv? Poussineau wrote: > Hi Dan, > > I'm using Wine IDL compiler to compile some .idl files, and I found a > regression in WIDL between 0.9.38 and 0.9.39. > As you are the one who mostly changed WIDL between these releases, I'm > sending you this email ;) > > My .idl file looks like this one: > > [ > uuid (00112233-4455-6677-8899-AABBCCDDEEFF), > version(1.0), > pointer_default(unique) > #ifndef __midl > ,explicit_handle > #endif > ] > interface MyInterface > { > unsigned long GetRoot(handle_t BindingHandle, > [out, string, size_is(Length)] wchar_t > *RootString, > [in] unsigned long Length); > } > > Of course, Microsoft MIDL accepts to compile this file, so WIDL should too. > WIDL 0.9.38 was working, but WIDL 0.9.39 gives the following error: > error: write_string_tfs: Unimplemented for type 0x1b of name: RootString > > Type 0x1b is RPC_FC_CARRAY, but write_string_tfs function only supports > RPC_FC_BYTE, RPC_FC_CHAR and RPC_FC_WCHAR. > > Any idea how to fix it, or am I forced to keep WIDL 0.9.38? > > Thanks in advance, > > Hervé Hi Hervé. Thanks for the bug report. The code related to this problem was being worked on quite a bit recently, so I don't doubt there may be a regression. I may be a bit slow to look at this since I'm in the middle of working on something else at the moment, hence I'm CC-ing the list so other people can see that the problem exists. Dan

1 0

Re: [PATCH] msi: correct buffer overrun in msi_get_deferred_action().
by James Hawkins Aug. 6, 2007

Aug. 6, 2007

On 8/5/07, William Waghorn <willw(a)litany.me.uk> wrote: > --- > dlls/msi/custom.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c > index 390113e..17f581c 100644 > --- a/dlls/msi/custom.c > +++ b/dlls/msi/custom.c > @@ -153,7 +153,7 @@ static LPWSTR msi_get_deferred_action(LPCWSTR > action, LPCWSTR actiondata, > return strdupW(action); > > len = lstrlenW(action) + lstrlenW(actiondata) + > - lstrlenW(usersid) + lstrlenW(prodcode) + 5; > + lstrlenW(usersid) + lstrlenW(prodcode) + 9; > deferred = msi_alloc(len * sizeof(WCHAR)); > > sprintfW(deferred, format, actiondata, usersid, prodcode, action); > This has been properly fixed in git. -- James Hawkins

1 0