September 2007 - Wine-Devel

Re: winex11.drv[1/4]: fix two bugs in WTInfoA
by Alexandre Julliard Sept. 19, 2007

Sept. 19, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Two bugs I've found working on previous implentations > From b233532f7adc140c4e36fb2288581fe0ff181935 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 17 Sep 2007 11:54:41 -0700 > Subject: [PATCH] winex11.drv: fix two bugs in WTInfoA Please write a better description of the changes, "fix bug" can apply to just about any commit (and in general, if you have two bugs to fix there should be two patches...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: A first implentation of services.exe
by Robert Shearman Sept. 18, 2007

Sept. 18, 2007

Mikolaj Zalewski wrote: > I don't want this patch to get committed but to maybe get some > comments. If the patch will be considered to be ok I can send it as > three smaller patches. It implements the basic infrastructure for > services.exe - a process that maintains the services database and > states. I think this can be useful in the long run. Absolutely. > This patch > currently doesn't implement anything useful - it connects to > services.exe in OpenSCManager and disconnect in CloseServiceHandle and > validating the database name is now done in services.exe but if this > approach is good I will add more functionality. > It looks good to me, but I'm a bit worried that you'll come across bugs/unimplemented features in widl when you start adding more calls. > Is there a way to check if a RPC connection over a named pipe was > closed by the client (probably we should close all it's handles in > such a case)? Yes, you can do this using context handles, but unfortunately we're lacking support for these on the RPC server side and in widl. > Also this program show a bug in our rpcrt4 - if we pass > NULL as a [in,unique,string] parameter rpcrt4 will crash because of a > strlen on it in NdrConformantStringBufferSize. To see it one can > remove the workaround in OpenSCManager and do a `make test`. That sounds like a bug in widl to me, and I'll take a look. > Macros > like RET_IF_ERROR should be removed from the final version or can they > stay? Definitely should be removed. > diff --git a/include/wine/svcctl_shared.h b/include/wine/svcctl_shared.h > new file mode 100644 > index 0000000..5687ddc > --- /dev/null > +++ b/include/wine/svcctl_shared.h > @@ -0,0 +1,35 @@ > +/* > + * SVCCTL (services.exe RPC interface) shared constants > + * > + * Copyright (C) 2007 Google (Mikolaj Zalewski) > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __WINE_SVCCTL_SHARED_H > +#define __WINE_SVCCTL_SHARED_H > + > +#include <stdarg.h> > +#include <windef.h> > +#include <winbase.h> > + > +#define SVCCTL_TRANSPORT {'n','c','a','c','n','_','n','p',0} > +#define SVCCTL_ENDPOINT {'\\','p','i','p','e','\\','s','v','c','c','t','l',0} > + > +/* Not the Windows event name - if needed the true one can be found in Inside Windows */ > +#define SVCCTL_STARTED_EVENT (const WCHAR[]){'S','v','c','c','t','l','S','t','a','r','t','e','d',0} > + > + > +#endif /* __WINE_RPCSS_SHARED_H */ > We shouldn't need another file for this. You can put this same stuff in svcctl.idl using cpp_quote. > +DWORD RPC_MainLoop() Make sure to fully specify the parameters for functions with no parameters by declaring them as "(void)". -- Rob Shearman

1 0

Want to contact Mike McCormack
by Stefan Ensslen Sept. 18, 2007

Sept. 18, 2007

Dear Sirs, I wanted to contact Mike McCormack from the WinE developer team, but my email to mike(a)codeweavers.com bounced. If you could send me his new email address, I'd be very happy. The question I wanted to ask Mr. McCormack is the following: Dear Mike, I have found your code for generating proxy/stub-code at www.winehq.org. I wanted to ask where you have found a documentation of the functions used in this code (for example NdrProxyInitialize, NdrProxySendReceive, and so on). The MSDN doesn't provide any _valuable_ documentation for this function, so you surely have another source of documentation. Thanks in advance, Stefan Ensslen -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

2 1

AppDB down - too many SQL connections?
by Alexander Nicolaysen Sørnes Sept. 18, 2007

Sept. 18, 2007

Hello, I am unable to access the database now because of too many MySQL connections. Does anyone have a log file to indicate whether this is some sort of attack, or whether we just have too many legitimate users? Alexander N. Sørnes

2 1

make crosstest is missing -lcabinet
by Pedro Araújo Sept. 18, 2007

Sept. 18, 2007

Hi all, I've been trying to cross-compile the Wine tests, but I keep getting this error: $ ./configure && make crosstest [SNIP] i586-mingw32msvc-gcc advpack.cross.o files.cross.o install.cross.o testlist.cross.o -o advpack_crosstest.exe -lcabinet -luser32 -ladvapi32 -lkernel32 /usr/lib/gcc/i586-mingw32msvc/3.4.5/../../../../i586-mingw32msvc/bin/ld: cannot find -lcabinet collect2: ld returned 1 exit status make[2]: *** [advpack_crosstest.exe] Error 1 make[2]: Leaving directory `/.../dlls/advpack/tests' make[1]: *** [advpack/tests/__crosstest__] Error 2 make[1]: Leaving directory `/.../dlls' make: *** [dlls/__crosstest__] Error 2 Am I missing anything? Thanks in advance. -- - Pedro.

2 2

Problem with TCP Option 0x00000008
by Christian Mahnke Sept. 18, 2007

Sept. 18, 2007

Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x00000008" after the loading of native rpcltccm.dll. To work around this i've compiled a modified wine 0.9.44 with an empty case statement for 0x00000008 in socket.c. It doesn't help much, the program just fails a bit later. The TCP Option 0x00000008 is defined as TCP_ATMARK in ws2_ipdef.h in the Windows SDK. Does anyone know how this should be mapped ? Cheers, Christian

4 6

compile wine from sources - strange messages
by Andrey Gavrilin Sept. 18, 2007

Sept. 18, 2007

Hello. I wish to compile wine from sources. Has received such message. The distribution: Ubuntu 7.04. What headers files does not suffice? PS I used the program the translator from Russian to English. configure: WARNING: jack/jack.h: present but cannot be compiled configure: WARNING: jack/jack.h: check for missing prerequisite headers? configure: WARNING: jack/jack.h: see the Autoconf documentation configure: WARNING: jack/jack.h: section "Present But Cannot Be Compiled" configure: WARNING: jack/jack.h: proceeding with the preprocessor's result configure: WARNING: jack/jack.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## configure: WARNING: pthread.h: present but cannot be compiled configure: WARNING: pthread.h: check for missing prerequisite headers? configure: WARNING: pthread.h: see the Autoconf documentation configure: WARNING: pthread.h: section "Present But Cannot Be Compiled" configure: WARNING: pthread.h: proceeding with the preprocessor's result configure: WARNING: pthread.h: in the future, the compiler will take precedence

2 1

Re: kernel32: Don't crash accessing an invalid handle in GlobalSize
by Robert Shearman Sept. 18, 2007

Sept. 18, 2007

James Hawkins wrote: > + if (IsBadReadPtr(pintern, 1)) > + { > + SetLastError(ERROR_INVALID_HANDLE); > + return 0; > + } > + > if(pintern->Magic==MAGIC_GLOBAL_USED) > { > if (!pintern->Pointer) /* handle case of GlobalAlloc( ??,0) */ It would be better to wrap the Magic access with an exception handler rather than use IsBadReadPtr. -- Rob Shearman

1 0

Re: fix for bug 9665
by James Hawkins Sept. 17, 2007

Sept. 17, 2007

On 9/17/07, Martin <martin.marsan(a)gmail.com> wrote: > > > 2007-09-17 Martin Sand <deadlock(a)start.no> > > * dlls/ddraw/direct3d.c: > ddraw: fixes a bug which prevents Kings Quest 8 from starting(bug 9665) > A good changelog entry details what you changed, not what apps are fixed by a change. -- James Hawkins

2 1

Re: fix for bug 9665
by Stefan Dösinger Sept. 17, 2007

Sept. 17, 2007

Am Montag, 17. September 2007 20:45:04 schrieb Martin: I doubt this fix is correct, as explained in bug 9665 a few minutes ago. It should fail the d3d test too

1 0

[AppDB] Bug: Let objectManager delete bug links
by Alexander Nicolaysen Sørnes Sept. 17, 2007

Sept. 17, 2007

Bug: Let objectManager delete bug links Regards, Alexander N. Sørnes

1 0

Re: user32: better fix how to handle GetWindowLongPtr[AW](..., GWLP_WNDPROC) for builtin winprocs [resend]
by Alexandre Julliard Sept. 17, 2007

Sept. 17, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Is there something wrong with this patch? > From 50eacd2465df53e5cfc15458ff5ab80f0cc07e7e Mon Sep 17 00:00:00 2001 > From: Mikolaj Zalewski <mikolaj(a)zalewski.pl> > Date: Mon, 10 Sep 2007 14:03:49 -0700 > Subject: [PATCH] user32: better fix how to handle GetWindowLongPtr[AW](..., GWLP_WNDPROC) for builtin winprocs There are several other places where winprocs are returned, like SetWindowLong or GetClassLong. You probably have to handle them too, or at least write test cases for them. -- Alexandre Julliard julliard(a)winehq.org

1 0

An enumeration of network resources
by Konstantin Kondratyuk Sept. 17, 2007

Sept. 17, 2007

Hello! I try to organize an enumeration of network resources by means of functions WNetOpenEnum and WNetEnumResource. Function WNetOpenEnumW contains a line: " ret = providerTable->table[index].openEnum( dwScope, dwType, dwUsage, lpNet, &handle); " which addresses to function in dll. The information about loaded dll is absent in the wine registry. Whether it means, what there are no preparations of DLL's for work with a network (similar ntlanman.dll in Windows)? -- Best regards, Konstantin Kondratyuk.

2 1

Re: msi(1/3): Don't crash if rec is NULL
by James Hawkins Sept. 17, 2007

Sept. 17, 2007

On 9/14/07, Juan Lang <juan.lang(a)gmail.com> wrote: > This series of patches is in response to Jeremy's troubles with > iTunes. They may or may not fix the installer for him, but they > prevent potential crashes. > --Juan > MSI_FormatRecordW is an internal function and we should be crashing if rec is NULL. -- James Hawkins

3 5

old dos/windows program crashing
by Joris Huizer Sept. 17, 2007

Sept. 17, 2007

Hello, I have a program, that I got like ages ago. It effectively is an atari emulator for dos, by the name "pacifist", but I originally got it installed under windows ME. It has an old atari-basic program "installed" in it, (a simple game) written by a friend in it, which I wanted to play. I decided to try to get it to run again under Linux. The website it came from originally doesn't seem to have the program available for download anymore - so I just copied the files from the windows ME disc. I obviously tried WINE then, but it didn't work, however, dosbox works with it (though slow, obviously) so I know I'm not missing required files (though, perhaps, registry settings - not sure how likely that is, though) Anyway. This isn't such a big deal, though I'd like to look at what's going on in WINE, and possibly fix it - though I need help here. This program is, among things, a "PMODE W/DOS Extender" - so that means it probably does some obscure real-mode/protected-mode stuff. Console output is as follows, Warning: unprotecting memory to allow real-mode calls. NULL pointer accesses will no longer be caught. err:int:__wine_emulate_instruction mov cr0,eax at 0x00000544 err:int:DOSVM_Int33Handler int33: unknown/not implemented parameters: int33: AX 0015, BX 0003, CX 11f7, DX 1165, SI 0055, DI 03ac, DS 11df, ES 11e7 fixme:int:DOSVM_Int10Handler Select vertical resolution - not supported fixme:int:DOSVM_Int10Handler Load ROM 8x8 Double Dot Patterns - Not Supported fixme:int31:DOSVM_Int31Handler physical address mapping (0x00000000) - unimplemented wine: Unhandled page fault on read access to 0xffffffff at address 0x101f:0x0003ed71 (thread 002d), starting debugger... fixme:dbghelp:addr_to_linear Failed to linearize address 08f0:00000002 (mode 0) fixme:dbghelp:addr_to_linear Failed to linearize address 08f0:00000000 (mode 0) Also I attached the visual display the "winevdm" shows as the program crashes. (It seems it crashes somewhere in generated code in kernel32.dll - in DPMI_PendingEventCheck() - written by the winebuild tool) I know some things about real-mode code, but not too much. Could you give me pointers on what to look at next? BTW, please CC me, I'm not on the mailing list currently. Thanks, Joris ____________________________________________________________________________________ Check out the hottest 2008 models today at Yahoo! Autos. http://autos.yahoo.com/new_cars.html

3 4

AppDB: cannot submit a screenshot even when logged in
by Vit Hrachovy Sept. 16, 2007

Sept. 16, 2007

Hello everybody, I may missed something, but I cannot submit a screenshot to the application I maintain in AppDB and I'm logged in. There's always a nasty 'Log in to submit screenshots' instead of Submit button. Is it planned downtime? Regards Vit P.S. It's http://appdb.winehq.org/screenshots.php?iAppId=4025

2 2

DirectDraw opengl renderer
by Alexander Nicolaysen Sørnes Sept. 16, 2007

Sept. 16, 2007

Hello everyone, I know this has been discussed before (and not that long ago), but I think I have some wonderful new information to add to the debate of whether or not to add an option for this in winecfg. As I understand it, there is still a long time before the opengl renderer will become the default one. With Wine 0.9.45, some bugs were fixed allowing the opengl renderer to be used for C&C Tiberian Sun, and I must say the speed improvements are dramatic! Without any FPS tools I would definitely say performance has increased by several hundred per cent. Now the game is so fast I may have to turn down the game speed setting. :) If you move the mouse it still slows down, though, as it does with the gdi renderer. Anyway, I think this should apply to several other games as well (and I will test more). But I was wondering is this is enough to add an option in winecfg? Alexander N. Sørnes

3 3

Re: RICHED20: additional tests plus RFC
by Alexander Nicolaysen Sørnes Sept. 16, 2007

Sept. 16, 2007

On Sunday 16. September 2007 04:34:17 a_villacis(a)palosanto.com wrote: > I am tracking down a richedit bug in FACETS (bug #1713). > > Apparently, the OCX control used by this app expects a particular > SendMessage() > with the message EM_SETCHARFORMAT to return 1. Currently builtin returns 0 > unconditionally, making this app bail out with "Invalid property value". By > changing the return value to 1 unconditionally, the app gets "fixed", but > this > is not a proper solution, since other apps might break with this change. > > This patch adds additional testing of EM_SETCHARFORMAT. All todo_wine's > succeed > in an installation of WinXP SP2. Please confirm this is so for all of you. > > There are two code blocks commented out. The first one makes the app crash > on WinXP, and is listed for completeness. The other one was supposed to > test what > happens when the riched20 control receives a blanked-out CHARFORMAT2 > structure. > However this triggers an assertion in Wine at style.c line 63. WinXP > doesn't bat an eye, and possibly ignores these structure values. Unless > somebody objects, I will shortly send a patch that replaces the assertion > with a NULL return in style.c, plus a NULL check in editor.c . > > There are more riched20 tests that fail in WinXP SP2, unrelated to > EM_SETCHARFORMAT, but I would like confirmation that (1) somebody else sees > failing tests in native Windows, not just me, and (2) this patch does not > introduce any new failing tests in native Windows. > > Changelog: > * Add additional tests for EM_SETCHARFORMAT message of riched20 control Hey, great to see some work on EM_SETCHARFORMAT. If you're interested, Wine has a builtin WordPad (just type 'wine wordpad') which exposes some problems. Try to select a font in the font list when no text is selected, for instance. Alexander N. Sørnes

1 0

Re: [PATCH 2/7] gdi: Implement BiDi classification of characters
by Steven Edwards Sept. 16, 2007

Sept. 16, 2007

Hi Maarten, Could you configure your git scripts to output different filenames when generating patches? Somehow they get managed for me in my gmail inbox. It makes it quite a pain for me to review. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

6 10

Re: patches to make wine compile on osx
by Roderick Colenbrander Sept. 16, 2007

Sept. 16, 2007

Hi Daniel, A few comments regarding the patches. First of all you should use a single patch file for each patch (this makes tracking patches easier). Now over to the patches. Regarding wineosxtypeerrors.patch: - 'GLenum' should be 'unsigned int' instead of int. I don't understand why the casts are needed as it should just get the type info from gl.h. I think that using '%u' for unsigned data could fix most of your problems. Regarding wineosxglexterrors.patch: - Same comment regarding unsigned int data. (make this a separate patch) - GL_TEXTURE_RECTANGLE_NV should be handled in include/wine/wgl.h, strange that I didn't receive compile failures for linux about it .. perhaps it is already in the mesa headers. (make this a separate patch) Anyway I would define GL_TEXTURE_RECTANGLE_NV like this: #ifndef GL_NV_texture_rectangle #define GL_TEXTURE_RECTANGLE_NV 0x84F5 #define GL_TEXTURE_BINDING_RECTANGLE_NV 0x84F6 #define GL_PROXY_TEXTURE_RECTANGLE_NV 0x84F7 #define GL_MAX_RECTANGLE_TEXTURE_SIZE_NV 0x84F8 #endif The extension is fully compatible with GL_ARB_texture_rectangle which osx should have and GL_EXT_texture_rectangle is likely the same. (the constants between the ARB and NV one are also the same, I expect the same for EXT and ARB) Regards, Roderick Colenbrander

1 0

Dfw5 draws graphs black (regression)
by Willi Mann Sept. 15, 2007

Sept. 15, 2007

Hi! Derive 5 no longer draws graphs in color. It should look like that: http://wserver.wm1.at/~willi/wine/dfw.png With current versions, it draw the blue graph in black. I could track it down to this commit (between 0.9.25 and 0.9.26): http://wserver.wm1.at/~willi/wine/wine_dfw.diff.txt (In fact, these are two commits, but the intermediate version does not compile) Please let me know if I can do anything to help fixing this bug. Willi Please CC: me on replies.

2 2

Re: add shell32.755
by Maarten Lankhorst Sept. 15, 2007

Sept. 15, 2007

Louis. Lenders schreef: > Hi, i'm sending in 2 patches from Anastasius Focht for review, and > hopefully for inclusion in git. Otherwise they might get "lost" and > forgotten. > > They're helpful for testing apps with native comdlg32.dll. So although > they do not really fix any real life app (not that i know of I'm missing a few tests to see if this behavior is actually what it should be like in windows. You should always add them to implementations of new functions. Cheers, Maarten

1 0

Re: fnt2fon: janitorial IgnoredReturnValues (1/5)
by Alexandre Julliard Sept. 14, 2007

Sept. 14, 2007

Lionel_Debroux <lionel_debroux(a)yahoo.fr> writes: > tools/fnt2fon is flagged in the janitorial page "IgnoredReturnValues". > This page is outdated, but its content is still valid for fnt2fon, which > ignores a number of return values. I don't think that's worth fixing, the warnings are essentially useless, it just makes the code uglier. There may be a few legitimate errors in there, like checking the fopen() result, and those could be fixed; but please don't add checking to every call that gcc complains about. -- Alexandre Julliard julliard(a)winehq.org

2 2

Problem with TCP Option 0x00000008
by Christian Mahnke Sept. 14, 2007

Sept. 14, 2007

Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x00000008" after the loading of native rpcltccm.dll. To work around this i've compiled a modified wine 0.9.44 with an empty case statement for 0x00000008 in socket.c. It doesn't help much, the program just fails a bit later. The TCP Option 0x00000008 is defined as TCP_ATMARK in ws2_ipdef.h in the Windows SDK. Does anyone know how this should be mapped ? Cheers, Christian

1 0

Re: winex11.drv/wintab32[1/5]: store categories field-by-field (resend)
by Alexandre Julliard Sept. 14, 2007

Sept. 14, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > /*********************************************************************** > * X11DRV_WTInfoA (X11DRV.@) > + * > + * NOTES > + * If cchOnlyCountString is not NULL and the data is a string then no > + * data is stored in the output buffer but only the string length is > + * returned in *cchOnlyCountString (and is >= 1 as contains at least a NUL > + * character). It have no effect on non-string data. > + * > + * Apart from the cchOnlyCountString parameter this function differs from the > + * WTInfo[AW] as for nIndex == 0 it returns the number of items in the > + * category. It's wintab32.dll that concatenates the data > + * > + * It is valid to call WTInfoA with lpOutput == NULL, as per standard. > + * lpOutput == NULL signifies the user only wishes to find the size of > + * the data. > */ > -UINT X11DRV_WTInfoA(UINT wCategory, UINT nIndex, LPVOID lpOutput) > +UINT X11DRV_WTInfoA(UINT wCategory, UINT nIndex, LPVOID lpOutput, DWORD *cchOnlyCountString) You shouldn't change the prototype. Driver functions should follow the signature of the corresponding APIs as far as possible. -- Alexandre Julliard julliard(a)winehq.org

2 2

carbon poker under wine
by Trent Waddington Sept. 14, 2007

Sept. 14, 2007

On 9/13/07, Eric Andersen <xxxx(a)xxx.com> wrote: > I was wondering if you could possibly throw me some pointers for > getting Carbon Poker working under wine. > > For the record I'm using ubuntu feisty and wine 0.9.44. I'll forward this to wine-devel, as someone else might want it. Well, first thing you should try is building wine from the git tree. This is painful and annoying because Linus is stupid and ugly but there's been a lot of fixes to the crypt32 stuff recently, and you'll need that: git clone git://source.winehq.org/git/wine.git wine cd wine ; ./configure ; make etc. You can try what I'm doing with your current version first, as it has some of this crypt32 stuff.. so it might work. I downloaded CarbonPoker.exe from the website, ran it with wine and it complains that I don't have flash8 and then just sits there and does nothing. I don't know what it is doing, so I just went downloaded Flash: wget http://fpdownload.macromedia.com/get/flashplayer/current/install_flash_play… ./wine install_flash_player.exe That installs happily. So, running CarbonPoker.exe again.. ./wine CarbonPoker.exe err:ole:COMPOBJ_DllList_Add couldn't load in-process dll L"C:\\windows\\system32\\Macromed\\Flash\\Flash9b.ocx" Uhhh, ok. Having a look in that dir I see a Flash9.ocx but no Flash9b.ocx, what the hell? cd ~/.wine/drive_c/windows/system32/Macromed/Flash/ ln -s Flash9.ocx Flash9b.ocx cd - ./wine CarbonPoker.exe and now it is happy and starts "Installing software..." which actually means it is updating the stub.. which it then runs, and starts "Installing software..." again.. You can ignore the "HTML rendering is currently disabled" where the installer would usually be telling you about the great benefits you get from playing Carbon Poker. Eventually this finishes. The installer goes away.. and after waiting and waiting, I get bored and hit CTRL-C. Fine, let's just run it then: ./wine ~/.wine/drive_c/Program\ Files/CarbonPoker/Poker.exe I get a "It appears the software has generated a bug. You can optionally submit it with comments about what you were doing at..." and as much as I'd like to do that with something like "doesn't work under wine" I'm going to press Cancel. Now we're in the login screen and it's asking me how I'd like to login, etc. So it looks like it is running! Just to check, I'm closing it and running it again.. yep, I'm in the login screen again. It's running. Hmm, I have a login for this game around here somewhere.. putting in my email address and pressing "Forgot Password" gives me this error: wine: Call from 0x7ee53f40 to unimplemented function urlmon.dll.HlinkSimpleNavigateToMoniker, aborting That isn't much help. And that crashed it, so running it again.. Sidenote: http://www.carbonpoker.com/pass.html is not secure.. ever heard of "denial of service" guys? Anyway, got some login details. Logged in, I see spam. Click on "Poker Tables". Up some come. Click on the first non-full one and "Join Table". And yes, I can join the table and sit down. I'm playing Poker. Yah. Trent

1 1

First song purchased on iTunes 7 with Wine...
by Dan Kegel Sept. 13, 2007

Sept. 13, 2007

For the record, I just bought "Autobahn" by Kraftwerk for $0.99 from the iTunes store using iTunes 7 on today's wine from git. It's playing now while I type this message. (OK, the music skips sometimes when I type or adjust the volume or move the mouse or scratch my nose... but hey, at least it's a start!) Thanks, Juan! - Dan

3 4

Re: [2/2] WGL: Sync pixmap after glFlush/glFinish, not before every GL call
by Alexandre Julliard Sept. 13, 2007

Sept. 13, 2007

Chris Robinson <chris.kcat(a)gmail.com> writes: > From 95214f29672566796564db30ab7f61a2462e4e50 Mon Sep 17 00:00:00 2001 > From: Chris Robinson <chris.kcat(a)gmail.com> > Date: Wed, 12 Sep 2007 06:42:05 -0700 > Subject: [PATCH] WGL: Sync pixmap after glFlush/glFinish, not before every GL call The goal is to sync the pixmap before we start drawing to it, so doing it at glFlush time is too late. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: avifil32: Fix some memory leaks
by Paul Vriens Sept. 13, 2007

Sept. 13, 2007

Andrew Talbot wrote: > Changelog: > avifil32: Fix some memory leaks. > > > - if (mmioSeek(This->paf->hmmio, This->paf->dwNextFramePos, SEEK_SET) == -1) > - return AVIERR_FILEWRITE; > - if (mmioCreateChunk(This->paf->hmmio, &ck, 0) != S_OK) > - return AVIERR_FILEWRITE; > - if (mmioWrite(This->paf->hmmio, (HPSTR)lppc, ck.cksize) != ck.cksize) > - return AVIERR_FILEWRITE; > - if (mmioAscend(This->paf->hmmio, &ck, 0) != S_OK) > + if (mmioSeek(This->paf->hmmio, This->paf->dwNextFramePos, SEEK_SET) == -1 || > + mmioCreateChunk(This->paf->hmmio, &ck, 0) != S_OK || > + mmioWrite(This->paf->hmmio, (HPSTR)lppc, ck.cksize) != ck.cksize || > + mmioAscend(This->paf->hmmio, &ck, 0) != S_OK) > + { Doesn't this mean that every one of those 4 mmio-calls are executed? In the previous logic we would bail out after one failure. -- Cheers, Paul.

3 3

Re: wineprefixcreate: Make sure the path returned by GetTempPath() during the $WINEPREFIX creation will be writable.
by Alexandre Julliard Sept. 13, 2007

Sept. 13, 2007

Francois Gouget <fgouget(a)codeweavers.com> writes: > mshtml.dll (and probably many others) use GetTempPath() during the > self-registration process. But at that point the Windows environment > variables, and in particular $TMP and $TEMP, have not been set yet, > especially not in the currently running process. So when mshtml.dll > calls GetTempPath(), that function returns the current directory, which > obviously is no good if that directory is not writable (like '/' for > instance). So this patch makes 'c:\windows\temp' the current directory, > which we know will be writable (and the chdir() should have no other > side effect in this script). Actually GetTempPath is not supposed to use the current directory, I committed a fix. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32[2/4]: implement AddFontMemResourceEx (based on a patch of Byeong-Sik Jeon, helps with bug #5865) (resend)
by Alexandre Julliard Sept. 13, 2007

Sept. 13, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index c516736..efc044b 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -3214,8 +3214,18 @@ BOOL WINAPI RemoveFontResourceW( LPCWSTR > */ > HANDLE WINAPI AddFontMemResourceEx( PVOID pbFont, DWORD cbFont, PVOID pdv, DWORD *pcFonts) > { > - FIXME("(%p,%08x,%p,%p): stub\n", pbFont, cbFont, pdv, pcFonts); > - return NULL; > + PVOID pFontCopy = HeapAlloc(GetProcessHeap(), 0, cbFont); > + HANDLE ret; > + > + TRACE("Copying %d bytes of data from %p to %p\n", cbFont, pbFont, pFontCopy); > + memcpy(pFontCopy, pbFont, cbFont); > + ret = WineEngAddFontMemResourceEx(pFontCopy, cbFont, pdv, pcFonts); > + if (ret == NULL) > + { > + TRACE("Font create failed - freeing %p\n", pFontCopy); > + HeapFree(GetProcessHeap(), 0, pFontCopy); > + } > + return ret; > } The memory copy should be done in WineEngAddFontMemResourceEx since that's where the data is managed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] WineD3D: Pixel shader 1.x constants are clamped to [-1;1]
by Alexandre Julliard Sept. 13, 2007

Sept. 13, 2007

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > It is hard to judge if this patch will fix anything. A problem is that > clamping the constants on loading makes constants loading more expensive. > Luckilly though there aren't many ps 1.x constants(8 max). It is hard to say > if there are any games that use constants > 1.0, but incorrect constant > loading can have many bad effects. This one fails make test for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:3068: Test failed: quad 1 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3070: Test failed: quad 2 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3073: Test failed: quad 3 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3077: Test failed: quad 4 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3207: Test failed: quad 1 has color 007f7f00, expected 0x00808000 visual.c:3209: Test failed: quad 2 has color 007f7f00, expected 0x00808000 visual.c:3211: Test failed: quad 3 has color 007f7f00, expected 0x00808000 visual.c:3214: Test failed: quad 4 has color 00bfbf7f, expected 0x00bfbf80 make[2]: *** [visual.ok] Error 8 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WGL: Fix a major ATI regression
by Joerg Mayer Sept. 13, 2007

Sept. 13, 2007

On Thu, Sep 13, 2007 at 01:09:14AM +0200, Roderick Colenbrander wrote: > The change isn't a hack but more a workaround. I have submitted the bugreport to ATI but they likely won't fix it anytime soon. Well, if I understood the ATI development cycle correctly, even if they fixed it right away it will take another two releases (months) until it is released. ciao Joerg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

1 0

Cvs update error.
by Anatoly Lyutin Sept. 13, 2007

Sept. 13, 2007

Hi all!! Today I tried to make cvs update and cvs extradites a error: [vostok(a)windsor wine]$ cvs update cvs [update aborted]: unrecognized auth response from cvs.winehq.org: cvs pserver: /home/wine/CVSROOT/config [8]: warning: this CVS does not support PreservePermissions What happens? -- Best regards Anatoly Lyutin.

1 0

WineHQ Downtime
by Jeremy Newman Sept. 13, 2007

Sept. 13, 2007

This is a reminder. WineHQ will be going offline for upgrades today at 14:00 CDT (19:00 GMT). I expect downtime to be no longer than one hour. Some services will appear to have sporadic outages even after the upgrade is complete. This will be due to changes in configs and upgraded versions of server software. I will post back to wine-devel when the upgrade is complete.

3 3

Re: WGL: Fix a major ATI regression
by Chris Robinson Sept. 12, 2007

Sept. 12, 2007

On Wednesday 12 September 2007 04:09:14 pm Roderick Colenbrander wrote: > + visinfo = pglXGetVisualFromFBConfig(display, cfgs[i]); > + /* We have found an offscreen rendering format when there is no > visualinfo :) */ > + if(visinfo->visualid == visualid) { > pglXGetFBConfigAttrib(display, cfgs[i], GLX_FBCONFIG_ID, > &fmt_id); > fbconfig = cfgs[i]; > } You're using visinfo before making sure it's valid. And I think that comment is a little misleading talking about offscreen formats when checking for the default visual. > + if(!visinfo) { > nOffscreenFormats++; > } > + XFree(visinfo); I don't think we can rely on being able to safely XFree a NULL pointer. None of the other code in opengl.c relies in that behavior.

1 0

Re: [3/5] WineD3D: Fix the reflection calculation in texm3x3(v)spec
by H. Verbeet Sept. 12, 2007

Sept. 12, 2007

On 12/09/2007, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > ...so what the patch *actually* does in a completely obfuscated way, is getting rid of the assumption that the normal is normalized. IOW, - shader_addline(buffer, "tmp0.xyz = reflect(-tmp1.xyz, tmp0.xyz);\n"); + shader_addline(buffer, "tmp0.xyz = reflect(-tmp1.xyz, normalize(tmp0.xyz));\n"); would be just as effective. That also means that the change in the ARB implementation - /* Calculate reflection vector (Assume normal is normalized): RF = 2*(N.E)*N -E */ + /* Calculate reflection vector (Assume normal is normalized): + * See comment in the glsl implementation. is misleading at best.

1 0

Re: problem with silly CreateBitmap call
by Francois Gouget Sept. 12, 2007

Sept. 12, 2007

On Thu, 6 Sep 2007, Deun wrote: [...] > The size of the bitmap seems crazy... So I've made a patch to > fix this in bitmap.c by setting 1x1 size in case of stupid > input instead of failing with BadAlloc. However, since it works > fine on real windows, so I'm not sure about the behaviour that > the function should have. Seems like a good candidate for a conformance test. Call the API with the crazy values and see what comes out... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

4 3

iTunes 7
by Juan Lang Sept. 12, 2007

Sept. 12, 2007

Folks, I just sent a series of wintrust patches that gets iTunes 7 to start, at least for me. I expect some will get rejected due to collision with Francois's patch - I'll resynch and resend. But if you want to play around with iTunes, grab those patches and give them a whirl. Known issues: 1. Your screen will go black when it starts. This is something QuickTime is doing. You can drag windows around to force some repainting to work around it. 2. You'll see lots of fixmes on the console, especially: "fixme:setupapi:CMP_WaitNoPendingInstallEvents 0", "fixme:setupapi:SetupDiGetClassDevsW returning empty list", and "fixme:htmlhelp:HtmlHelpW HH case HH_PRETRANSLATEMESSAGE not handled." 3. The main window will be transparent (and basically unusable) if you don't have GL support compiled in. Have fun, --Juan

4 5

Re: [PATCH] user32: edit control should respond to ctrl + z (try 3)
by Dmitry Timoshkov Sept. 12, 2007

Sept. 12, 2007

"Lei Zhang" <thestig(a)google.com> wrote: > This patch lets users hit ctrl + Z in edit controls to trigger an > undo. The test case has been improved to check for both the return > values and the content of the edit control. In the tests still there is no actual edit contents/selection changes tracking after every message. -- Dmitry.

2 6

Re: WineD3D: PBO support 2/2 (attempt 2)
by Alexandre Julliard Sept. 12, 2007

Sept. 12, 2007

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > This is an updated version of the patch. In the previous one I was > making a glBindBuffer call in a place without checking if PBOs were > around. Further the place didn't need the call anymore. This breaks the tests for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:2043: Test failed: quad 1 has color 0000ffff, expected 0x00FFFF00 visual.c:2045: Test failed: quad 2 has color 0000ffff, expected 0x0000000 visual.c:2047: Test failed: quad 3 has color 0000ffff, expected 0x0000FF00 make[2]: *** [visual.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by Jeremy Newman Sept. 11, 2007

Sept. 11, 2007

Is this the final version of this patch? Or shall I wait for an updated one from you? On Tue, 2007-09-11 at 11:31 -0700, Lei Zhang wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal.

1 0

Re: wordpad: #1 Store bar states in the registry
by Alexandre Julliard Sept. 11, 2007

Sept. 11, 2007

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > wordpad: #1 Store bar states in the registry This doesn't work well when resizing the window, the toolbars get overwritten by the edit area. -- Alexandre Julliard julliard(a)winehq.org

2 7

Re: A fix for a problem with older games
by Stefan Dösinger Sept. 11, 2007

Sept. 11, 2007

Am Sonntag, 9. September 2007 17:10:39 schrieb Martin: That patch is not correct Are you sure that this patch really causes a problem? If you are running the game in winedbg and get an exception there it is a symptom of the DIB management in winex11.drv. You can just use "pass" to pass the exception up to the next handler(winex11.drv). The exception never reaches the app. If you really get a crash there then This->resource.allocatedMemory is pointing to a bad location, most likely NULL. This is a problem at some other place and should be fixed elsewhere. This read is a hack to work around a bug in the open source ati driver which caused a hard system crash if an exception occured during glDrawPixels. You can remove hack as a whole if it really causes problems, but this will cause hard crashes for a wide range of radeon drivers(xorg 6.8 and 7.0 at least). I think it is fixed in the latest version, but I am not sure, I'd have to test that. Since the hack is confined in one single function and doesn't have any side effects I decided to keep it.

1 0

Re: a ddraw patch
by Stefan Dösinger Sept. 11, 2007

Sept. 11, 2007

Am Sonntag, 9. September 2007 17:11:06 schrieb Martin: That patch will obviously break the game the dwTextureCaps modification was added originally... Can you check which cap that game needs that is removed in those lines?

1 0

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by James Hawkins Sept. 11, 2007

Sept. 11, 2007

On 9/11/07, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal. > <th>Blocker</th> - <td>Blocks development and/or testing work</td> + <td>When Wine won't start at all for any application, and there's no work + around</td> I think you've made this too specific, especially for Blocker. For example, in the new description you've left out compile errors, which is a big part of what blocker represents. The original description is fine for blocker. <th>Major</th> - <td>major loss of function</td> + <td>For a problem that is affecting most applications you run in Wine</td> + </tr> Why not something like, major loss of functionality for a wide range of applications instead of totally rewriting the definition. -- James Hawkins

3 3

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by Jesse Allen Sept. 11, 2007

Sept. 11, 2007

On 9/11/07, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal. > > > > > How about for minor you still keep "where an easy workaround is present". That differentiates it from normal. Jesse

1 0

Fifa 07 - wined3d regression
by Jan de Mooij Sept. 11, 2007

Sept. 11, 2007

Hi, Fifa 07 used to work fine with Wine, but around version 0.9.40-0.9.41 the game hangs when I start a new match. The text "Loading..." is displayed, but there is no progressbar because one thread terminates. I attached the results of winedbg (backtrace and some messages before the crash). This is the result of git bisect: 9ba3f389f665aae45b6a8a6861f9621b020e5c25 is first bad commit commit 9ba3f389f665aae45b6a8a6861f9621b020e5c25 Author: Stefan Dösinger <stefandoesinger(a)gmx.at> Date: Sun Jul 8 23:33:48 2007 +0200 wined3d: Initialize surfaces at creation. This patch removes a check of "GL_SUPPORT(APPLE_CLIENT_STORAGE)". If I put that check in again, the game works like before. The if-condition evaluates to True now, so it allocates the memory. But it segfaults there I think. Please let me know if you need more information. Thanks in advance! Jan de Mooij

2 2

AppDB entries
by speedator＠gmx.de Sept. 11, 2007

Sept. 11, 2007

Hi, sometimes app-entries (like Acrobat Reader) are for series of applications and versions for the single applications. Sometimes there are app-entries(like Age of Empires) for single applications in a series and version-entries for patches, betas, demos etc.. And sometimes it is a mixture. What about making this more clear? Do we need entries for the whole series? I think it is important for overview. So what about a new structure like "application / version / derived from version(subversion)"? Julian

3 2

lostwages CVS moved into GIT
by Jeremy Newman Sept. 11, 2007

Sept. 11, 2007

We have switched our website sources (previously known as lostwages), over to git. >From this point on I would prefer if all patches came from the git tree. Refer to the git documentation on the website and wiki on how to prepare patches with git. The git module is called simply "website".

1 0

Re: make_makefiles: ignore .DS_Store files
by Alexandre Julliard Sept. 11, 2007

Sept. 11, 2007

Emmanuel Maillard <mahanuu(a)free.fr> writes: > From b298a599f2b0eb5b8d7f2092573aba28755001d7 Mon Sep 17 00:00:00 2001 > From: Emmanuel Maillard <mahanuu(a)free.fr> > Date: Sun, 2 Sep 2007 12:42:16 +0200 > Subject: [PATCH] - ignore .DS_Store files You should put that in your global ignore file, the .DS_Store files are not created by the build process so they don't belong in .gitignore. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: WineD3D: PBO support 2/2
by Stefan Dösinger Sept. 11, 2007

Sept. 11, 2007

Am Dienstag, 11. September 2007 10:25:28 schrieb Roderick Colenbrander: > Hi, > > This patch adds PBO support for dynamicly locked textures. It greatly > improves performance of games that use render target locking a lot. It looks good to me, here are some suggestions for further improvements in further patches(this patch is good for the start). The locking flag passed to LockRect could be forwarded to GL. D3DLOCK_DISCARD and D3DLOCK_WRITEONLY(ddraw only) would be GL_WRITE_ONLY, D3DLOCK_READONLY GL_READ_ONLY. However, we have to take care about the upside down swap for render target locking. D3DLOCK_DISCARD can be implemented(appart of the surface beeing writeonly) by calling glBufferData with a NULL pointer. This tells gl that the old data can be thrown away. This allows the driver to further optimize the map. e.g. if it is a texture that is still used for rendering in some pending calls, it can duplicate the buffer and doesn't have to wait for the rendering to finish. It will have to be tested if that really helps performance. I tried it for vbos, and it made things noticeably worse. Binding the pbo to 0 after each operation is a good idea for a start, but shouldn't be done in the long term in my opinion.

1 0

settlers 3 and dib engine
by Skrzynka Sept. 10, 2007

Sept. 10, 2007

Hi, I'm trying to get Settlers 3 to run on Wine. After fixing some race condition (seems like the thread calling WaitForXXXObject was giving up time-slice too early after the call) it seems that the only problem left is very slow text output. What I could understand from the forum archives is that with no DIB engine, the rendering into a DC causes copying of the bitmap to/from server (is that correct?). I'd like to contribute to the DIB engine if it's possible/needed, so I'd like to ask about a few things. There were some discussion recently about an implementation of DIB engine by Jesse Allen - what is the status of DIB engine? I compiled winedib.drv but ExtTextOut function is missing there and overall there are regressions visible when running Settlers 3 (wrong colors, no text at all). Which docs/urls/sources would you recommend to read to get some quick introduction to the DIB engine? Which particular functions are making current impl slow? Or, in general: where to start? Sorry for any silly questions... Thanks & regards Piotr -- ----- AlphaNet - najtaniej w sieci! -------- Odnowienia domen w rewelacyjnych cenach! .pl - 65 zl, .com.pl - 50 zl, reg - 20 zl http://www.domeny.alpha.pl --------------------------------------------

4 8

Re: ntdll: Do not segfault with snoop for files with a broken exporttable
by Dmitry Timoshkov Sept. 10, 2007

Sept. 10, 2007

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > ntdll: Do not segfault with snoop for files with a broken export table > + /* Check for files with broken exports */ > + if (exports->Characteristics || > + exports->MajorVersion || > + HIWORD(exports->NumberOfFunctions) || > + HIWORD(exports->NumberOfNames)) { > + WARN_(snoop)("snoop disabled for bad module %p: 0x%x, %u, 0x%x, 0x%x\n", hmod, > + exports->Characteristics, exports->MajorVersion, > + exports->NumberOfFunctions, exports->NumberOfNames); > + return; > + } > + > TRACE_(snoop)("hmod=%p, name=%s\n", hmod, name); It's still helpful to see the line "hmod=%p, name=%s\n" in the log before an error message. -- Dmitry.

2 1

Re: gdi32: return the correct font type, ntmFlags and PitchAndFamily for Type1 fonts (improved, fixes bug #5877)
by Dmitry Timoshkov Sept. 9, 2007

Sept. 9, 2007

"Mikolaj Zalewski" <mikolaj(a)zalewski.pl> wrote: > As suggested by Dmitry the table id is now a symbolic constant. However > I didn't included the tttags.h but defined the constant myself as I see > that every freetype header is checked by configure and included only if > it is available. Thus in case it is not available we would either need > an #ifdef in AddFileToList (what IMHO wouldn't be nice) or in such a > case define the symbol ourselfs. But if we will need to define the > symbol then why to include the header? > +#define WINEENG_SFNTTAG_CFF 0x43464620 /* stores the outline for Type1 OTF fonts */ This is not what I suggested. Using a macro like FT_MAKE_TAG makes this much more readable. WINEENG_SFNTTAG_CFF doesn't follow any macro naming conventions in freetype.c, I'd suggest to use the same name as FreeType has (TTAG_CFF) instead, perhaps inside of #ifdef guard if including tttags.h is much hassle. Although including tttags.h and using #ifdef before defining TTAG_CFF is much more clean IMO. -- Dmitry.

1 0

[PATCH 2/3] wininet: Use parent/child handle framework to track parent/child handle relationships.
by Misha Koshelev Sept. 8, 2007

Sept. 8, 2007

Jacek Caban wrote: > Hi Misha, > > Misha Koshelev wrote: > > We have a lot of parent/child relationships in wininet that are addressed on an individual basis. > > Now we can just address them within the framework since we need that framework for closing handles > > too. The only thing I don't like is that we have to make lots of casts now, but it doesn't really make > > much sense to me to store the "parent" object handle in two different places. > > Sorry for late response. > > This patch reverses what I've done some time ago. There is no reason to > have parent object in header - you need only a child list to handle > closing handles. Also casts make the code much less readable. > > Thanks, > Jacek Ok, that sounds fair. I didn't really like the casts either, that was my biggest problem with this patchset. I am leaving the country tomorrow for 9 days but will change the patches/resubmit as you suggested after I come back. Thanks for your comments. Misha

1 0

Re: [PATCH 2/3] wininet: Use parent/child handle framework to track parent/child handle relationships.
by Jacek Caban Sept. 8, 2007

Sept. 8, 2007

Hi Misha, Misha Koshelev wrote: > We have a lot of parent/child relationships in wininet that are addressed on an individual basis. > Now we can just address them within the framework since we need that framework for closing handles > too. The only thing I don't like is that we have to make lots of casts now, but it doesn't really make > much sense to me to store the "parent" object handle in two different places. Sorry for late response. This patch reverses what I've done some time ago. There is no reason to have parent object in header - you need only a child list to handle closing handles. Also casts make the code much less readable. Thanks, Jacek

1 0

Re: gdi32: return the correct font type, ntmFlags and PitchAndFamily for Type1 fonts (fixes bug #5877)
by Dmitry Timoshkov Sept. 8, 2007

Sept. 8, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> wrote: > As I wrote in Bugzilla for Photoshop to work with Type1 fonts after > applying this patch one needs to reinstall Photoshop in a clean > wineprefix - it seems that Photoshop caches some font data. > + /* check for the presence of the 'CFF ' table to check if the font is Type1 */ > + tmp_size = 0; > + if (pFT_Load_Sfnt_Table && !pFT_Load_Sfnt_Table(ft_face, 0x43464620, 0, NULL, &tmp_size)) > + { > + TRACE("Font %s/%p is OTF Type1\n", wine_dbgstr_a(file), font_data_ptr); > + face->ntmFlags = NTM_PS_OPENTYPE; > + } Please use a symbolic name instead of 0x43464620. FreeType provides TTAG_CFF, or you can define it on your own using FT_MAKE_TAG. -- Dmitry.

1 0

Kudos - Fireworks 8 working better...
by Dan Kegel Sept. 7, 2007

Sept. 7, 2007

http://www.5thpercentile.com/devBlog/archives/2007/09/wine_just_got_t.html and http://appdb.winehq.org/appview.php?iVersionId=4149&iTestingId=15163 both say that wine-0.9.44 really improves Adobe Fireworks. Yay! - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: wined3d: add WINED3DPRESENT_INTERVAL_ONE flag (fix bug 9584)
by Stefan Dösinger Sept. 7, 2007

Sept. 7, 2007

Am Freitag, 7. September 2007 18:29:02 schrieb Louis. Lenders: > I added this initially as a hack to get mame running, but what i understood > from discussion on IRC, there's no way we can check the graphics card's for > this capability now, and adding it as default (so without checking) would > be rather harmless. Short answer: Patch is ok with me Long answer: We can check if opengl supports vsync(which is what this flag does). WineD3D implements vsync using GLX_SGI_video_sync. So if this extension is supported, we should set the flag. If it is not supported, do not set it. Our WGL implementation does not forward the GLX extension yet, so we do not support vsync at the moment, so setting this flag means essentially lying to the app. However, I think it is safe to pretend vsync support. The worst that may happen is that the game renders with a higher framerate, and the hardware consumes more power instead of beeing idle. I think both cases are better then not running the game at all. There's one game which runs into internal race conditions if vsync does not work(need for speed 3), but that game doesn't even care to check that flag.

1 0

build problem on amd64
by Dave Phillips Sept. 7, 2007

Sept. 7, 2007

Greetings, I hope I have the right list. I'm trying to build Wine 0.9.44 under 64Studio, a Debian-based distribution. CPU is an AMD64, GCC is 4.1.2. Configure and make depend report no errors (btw, I ran a simple ./configure, no options), but when I run make I receive these errors : gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -D__i386__ -o interlocked.o interlocked.c {standard input}: Assembler messages: {standard input}:38: Error: suffix or operands invalid for `push' {standard input}:39: Error: suffix or operands invalid for `push' {standard input}:46: Error: suffix or operands invalid for `pop' {standard input}:47: Error: suffix or operands invalid for `pop' make[2]: *** [interlocked.o] Error 1 make[2]: Leaving directory `/home/dlphilp/src/wine-0.9.44/libs/port' make[1]: *** [port] Error 2 make[1]: Leaving directory `/home/dlphilp/src/wine-0.9.44/libs' make: *** [libs] Error 2 Is there a fix for this problem ? Please advise, thanks. Best regards, Dave Phillips

1 0

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite
by Dmitry Timoshkov Sept. 7, 2007

Sept. 7, 2007

"Vincent Povirk" <madewokherd(a)gmail.com> wrote: > fixes bug 9523, Knytt Stories installer fails > +/*********************************************************************** > + * SHPathPrepareForWriteA (SHELL32.@) > + */ > +HRESULT WINAPI SHPathPrepareForWriteA(HWND hwnd, IUnknown *modless, LPCSTR path, DWORD flags) > +{ > + WCHAR wpath[MAX_PATH]; > + MultiByteToWideChar( CP_ACP, 0, path, -1, wpath, MAX_PATH); > + return SHPathPrepareForWriteW(hwnd, modless, wpath, flags); You are still using a buffer of a fixed size. > + /* cut off filename if necessary */ > + if (flags & SHPPFW_IGNOREFILENAME) > + { > + last_slash = StrRChrW(path, NULL, '\\'); StrRChrW is a shlwapi export. Since shlwapi.dll is just mostly a wrapper/helper, and it imports shell32, that would create a circular dependency. I already suggested to use strrchrW here. > + temppath = HeapAlloc(GetProcessHeap(), 0, len * sizeof(WCHAR)); > + if (!temppath) > + return E_OUTOFMEMORY; > + StrCpyNW(temppath, path, len); Again StrCpyNW is a shlwapi export, and since you just allocated the buffer of correct length memcpy + adding an explicit '\0' terminator look more naturally here (if not kernel32.lstrcpynW). > + /* try to create the directory if asked to */ > + if (flags & (SHPPFW_DIRCREATE|SHPPFW_ASKDIRCREATE)) > + { > + if (flags & SHPPFW_ASKDIRCREATE) > + FIXME("treating SHPPFW_ASKDIRCREATE as SHPPFW_DIRCREATE\n"); > + > + SHCreateDirectoryExW(0, realpath, NULL); > + } You are still not checking SHCreateDirectoryExW return value. > + if (temppath) > + HeapFree(GetProcessHeap(), 0, temppath); There is no need to check temppath for NULL before HeapFree call. -- Dmitry.

3 3

re: nhelp, Vector NTI, molecular biologists
by Dan Kegel Sept. 7, 2007

Sept. 7, 2007

Misha wrote: > and even my version of Windows 98 is bundled with mfc42.dll, so wine really should > provide it too... [our own version, not Microsoft's.] Well, sure. Same goes for a lot of things. But since mfc42.dll is a Visual C++ runtime file that has very liberal redistribution terms and is in fact bundled with many apps, we can get away without it for a long time. And it's not currently a showstopper as far as I can tell; I'm more interested in the bugs that keep e.g. Photoshop from running flawlessly. So one of these days it might become a priority. Until then, it's merely important but not urgent. - Dan

6 5

Re: ddraw/tests: Check deviceGUID of enumerated devices.
by Stefan Dösinger Sept. 7, 2007

Sept. 7, 2007

Am Donnerstag, 6. September 2007 16:02:59 schrieb David Hedberg: > This patch adds tests to check the devices enumerated by > IDirect3D7_EnumDevices . At least two games rely on the behavior > tested by one of the test in this patch. If wine behaves incorrectly and your test fails on wine, you have to send a fix before or in the same patch as the test. Alexandre has some scripts that run the conformance tests after each patch and refuses all patches that cause in test failures. If you do not know how to fix the bug, or want to keep it unfixed for some other reason(e.g. the incorrect behavior is hard to fix and considered harmless), then you can mark the test as todo_wine. Then the tests script will ignore failures in the test. However, Alexandre will drop a note and ask for further explanation if a test marked todo_wine succeeds(e.g. we had a test that succeeded or failed for some time based on the features graphics driver). todo_wine test(2 + 2 == 3.99998, "This is my test marked as TODO\n"); /* Microsoft does something insane here */ Other things: + if(!memcmp(&lpdd7->deviceGUID, &IID_IDirect3DRGBDevice, sizeof(IID_IDirect3DRGBDevice))) You can use IsEqualGUID here. Sorry for not spotting this earlier. + IDirect3D7_EnumDevices(lpD3D, (LPD3DENUMDEVICESCALLBACK7) enumDevicesCallbackTest7, &d3d7et); To get more compiler checks, you shouldn't cast the function to the right type, but use void *d3d7et, and cast it to the right pointer in your function. Debugging a wrong function pointer is a nasty thing ;-)

2 2

Re: gdi32[3/3]: if freetype fails try to load manually fonts wrapped asPE resources
by Dmitry Timoshkov Sept. 7, 2007

Sept. 7, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> wrote: > This is some overlap with freetype as freetype 2.3.5 can load fonts > from PE resources. But the code is so small (we have all the tools > needed) and helps many programs (including working around the > Photoshop Z-order problem during startup as now the dialogs doesn't > show) that I thought it is useful. Then there is no point in using FreeType for loading font files at all, (or adding support for new font file formats to FreeType) since FreeType can load fonts from memory. > + TRACE("WineEndAddFontResourceEx failed on PE file %s - trying to load resources manualy\n", > + wine_dbgstr_w(str)); > + if (EnumResourceNamesW(hModule, rt_font, load_enumed_resource, (LONG_PTR)&num_resources)) This code snippet causes a stack corruption since load_enumed_resource has wrong calling convention. I wonder whether gcc issued a warning here. -- Dmitry.

2 4

RE: problem with silly CreateBitmap call
by Rolf Kalbermatter Sept. 6, 2007

Sept. 6, 2007

Deun wrote on Thursday, September 06, 2007 10:40 AM >trace:x11drv:X11DRV_CreateBitmap (0xed4) 2147483646x2147483646 >1 bpp >X Error of failed request: BadAlloc (insufficient resources for operation) > Major opcode of failed request: 53 (X_CreatePixmap) > Serial number of failed request: 3155 > Current serial number in output stream: 3163 > >This occured after an attempt to load a bmp file that can't be found anywhere. > >The size of the bitmap seems crazy... So I've made a patch to fix this in >bitmap.c by setting 1x1 size in case of stupid input instead of failing with >BadAlloc. However, since it works fine on real windows, so I'm not sure about >the behaviour that the function should have. However this patch let me run >the game now : First your patch is not very useful as the diff was run from inside the directory where the two files where, instead of from the main wine directory. So the patch does not contain the necessary full project path for the patch maintainer to apply It without guessing, which he won't do without some very compelling reasons. But the more serious problem is that it is really just a hack and as such won't get into wine. Trapping on some arbitrary size is not an acceptable patch for Wine. Instead the root cause should be found. Since you say that this comes from trying to load a bitmap that can be nowhere found I wonder if this is the result of some unitialized structures that result in garbage but somehow the loading is not aborted with an error for whatever reasons but just passed further to X11DRV_CreateBitmap with whatever garbage happened to be in memory and here probably on the stack. I see two possibilities and they both are likely to be fixed in the actual caller of X11DRV_CreateBitmap instead of in this function itself: 1) Wine code has a bug and should not ever attempt to call X11DRV to create the bitmap after it couldn't find the according file on disk to initialize the bitmap members. Instead that function should just return to the caller with an error. 2) Windows allows to load a nonexisting bitmap file and returns in that case a default bitmap, brush or whatever without causing an error. In that case the structure should be either initialized to some meaningful values like a 0 * 0 or 1 * 1 bitmap before attempting to load the file from disk and when the load fails just fall through to create that default bitmap or on failure of the loading some special code needs to be executed to create whatever Windows returns here. So in any case I think you need to figure out from which function exactly X11DRV_CreateBitmap is called with these silly parameters and concentrate on fixing that one instead. Your patch is still very likely to crash on a 0x7e000000 * 0x7e000000 bitmap and therefore didn't adress the root cause of this problem. Not knowing anything about the stack trace it is completely impossible for anyone not running that application to look for the likely cause of this problem as there are quite a few functions in Wine that call X11DRV_CreateBitmap somewhere and somehow. Rolf Kalbermatter

3 2

Re: [PATCH 3 of 3] shell32: implement SHPathPrepareForWrite
by Dmitry Timoshkov Sept. 6, 2007

Sept. 6, 2007

"Vincent Povirk" <madewokherd(a)gmail.com> wrote: > HRESULT WINAPI SHPathPrepareForWriteA(HWND hwnd, IUnknown *modless, LPCSTR path, DWORD flags) > { > - FIXME("%p %p %s 0x%08x\n", hwnd, modless, debugstr_a(path), flags); > - return S_OK; > + WCHAR wpath[MAX_PATH]; > + MultiByteToWideChar( CP_ACP, 0, path, -1, wpath, MAX_PATH); > + return SHPathPrepareForWriteW(hwnd, modless, wpath, flags); It's better to not use fixed buffer sizes but allocate the buffer dynamically. > + /* make a copy of the path so we can cut off the filename */ > + for (i=0; i<MAX_PATH; i++) > + { > + realpath[i] = path[i]; > + if (path[i] == '\\') > + last_slash = i; > + else if (path[i] == 0) > + break; > + } > + realpath[MAX_PATH-1] = 0; > + > + if (flags & SHPPFW_IGNOREFILENAME) > + realpath[last_slash] = 0; If the job must be done only when SHPPFW_IGNOREFILENAME is specified then don't do it in all cases. And using strrchrW would simplify the code a bit. > + /* try to create the directory if asked to */ > + if (flags & (SHPPFW_DIRCREATE|SHPPFW_ASKDIRCREATE)) > + { > + if (flags & SHPPFW_ASKDIRCREATE) > + FIXME("treating SHPPFW_ASKDIRCREATE as SHPPFW_DIRCREATE\n"); > + > + SHCreateDirectoryExW(0, realpath, NULL); > + } Why there is no check for SHCreateDirectoryExW return value? > + > + /* check if we can access the directory */ > + res = GetFileAttributesW(realpath); > + > + if (res == INVALID_FILE_ATTRIBUTES) > + { > + err = GetLastError(); > + if (err == ERROR_FILE_NOT_FOUND) > + err = ERROR_PATH_NOT_FOUND; > + return HRESULT_FROM_WIN32(err); > + } > + else if (res & FILE_ATTRIBUTE_DIRECTORY) > + return S_OK; > + else > + return 0x8007010b; 0x10b == 267, therefore 0x8007010b is HRESULT_FROM_WIN32(ERROR_DIRECTORY) > --- a/dlls/shell32/tests/shpathprep.c > +++ b/dlls/shell32/tests/shpathprep.c > @@ -82,27 +82,27 @@ START_TEST(shpathprep) > ok(res == S_OK, "res == 0x%08x\n", res); > > res = SHPathPrepareForWriteA(0, 0, "c:\\testdir\\nonexistent", SHPPFW_NONE); > - todo_wine ok(res == 0x80070003, "res == 0x%08x\n", res); > + ok(res == 0x80070003, "res == 0x%08x\n", res); Please use above and in other places symbolic error names instead of hex, and print expected and received codes to make life easier for those who looks at the (failing) test results without looking at the source. For some reason your mailer attaches the patch in text and html formats, it would save some time/traffic by avoiding html in wine-patches. -- Dmitry.

2 6

WineHQ Upgrade Downtime
by Jeremy Newman Sept. 6, 2007

Sept. 6, 2007

On Wednesday Sept 12 at 14:00 US Central Time, we will be taking all of WineHQ offline for maintenance and upgrades. The server itself will offline for about an hour. Some services will be offline longer than that as we adjust/fix them to the upgraded server.

1 0

Wine on 64bit system crashes (critical)
by Roderick Colenbrander Sept. 6, 2007

Sept. 6, 2007

Hi, One of my development machines is a dualcore Athlon64 using a 64bit version of Debian. I have been using this system for months and it always worked fine. Since I hadn't used the system during the summer it contained an older Wine version. I have upgraded it to the latest GIT version and Wine doesn't work anymore. It doesn't just crash, but it locks up the whole system. I have no idea what causes it. I for instance ran Wine some time before as root (I really had to be root at that time) and for the root user it didn't lock up until I wanted to run a fresh .wine directory. I can't really test what caused it as testing this takes a lot of time and I can't use a bad filesystem or so on this system. On irc a ubuntu64 user said he had similar problems using Wine 0.9.44 but for him it 'only' segfaulted. Perhaps there is a connection between the problems. Has anyone recently seen problems like this? It prevents me from playing with Wine code at the moment. Roderick -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

2 3

Re: problem with silly CreateBitmap call
by Jesse Allen Sept. 6, 2007

Sept. 6, 2007

On 9/6/07, Deun <deun76(a)yahoo.com> wrote: > Hi, > > I've tried the free-to-play MMORPG game called Perfect World ( > http://perfect-w.jp ) with wine 0.9.44 and it installs fine. > However, when running it often crashed with the following error > in the x11drv traces : > > trace:x11drv:X11DRV_CreateBitmap (0xed4) 2147483646x2147483646 > 1 bpp > X Error of failed request: BadAlloc (insufficient resources > for operation) > Major opcode of failed request: 53 (X_CreatePixmap) > Serial number of failed request: 3155 > Current serial number in output stream: 3163 > > This occured after an attempt to load a bmp file that can't be > found anywhere. > > The size of the bitmap seems crazy... So I've made a patch to > fix this in bitmap.c by setting 1x1 size in case of stupid > input instead of failing with BadAlloc. However, since it works > fine on real windows, so I'm not sure about the behaviour that > the function should have. Look at the +bitmap debug channel, or others and trace to the original call's parameters. Figure out how the app is wanting to create the bitmap and write a test case for it and test on windows and wine. Jesse

1 0

Re: olethk32.dll
by Juan Lang Sept. 6, 2007

Sept. 6, 2007

Hi Stefan, + if (fdwReason == DLL_PROCESS_ATTACH) + DisableThreadLibraryCalls(hinstDLL); + + return TRUE; You should probably add a DLL_WINE_PREATTACH case that returns FALSE. --Juan

1 0

IDirect3DImpl_EnumDevices only enumerating IID_IDirect3DTnLHalDevice
by David Hedberg Sept. 6, 2007

Sept. 6, 2007

Hi, I've been tracking down the reason for bug 7993 ( http://bugs.winehq.org/show_bug.cgi?id=7993 , "Delta Force Land Warrior 1.31 -> Can't find 3D Video Card" ), and I think I've found it. It appears as if the EnumDevices callback in Delta Force for some reason discards all devices with a GUID of IID_IDirect3DTnLHalDevice, thus discarding the only device enumerated by wine. This is "easily" checked (and bypassed) by searching for and altering the IID_IDirect3DTnLHalDevice value used in the check (78 9E 04 F5 (..) ) in the delta force executable. While this works as a "fix", it's obviously not a good one. In my (somewhat limited and at the moment not doublechecked) understanding, windows "always" returns (at least) two devices, one reporting T&L capable and one not. So I am wondering how one would implement a proper fix for this in wine. Fixing this together with applying (or otherwise fixing the issue highlighted in) the patch at http://flodaby.ath.cx/~david/0001-ddraw-fix-cases-where-desc2.u2.dwMipMapCo… (also sent to wine-patches), would enable both Delta Force Land Warrior and Delta Force Task Force Dagger to run great with wine. David

2 4

Re: winhelp, Vector NTI, molecular biologists
by Misha Koshelev Sept. 6, 2007

Sept. 6, 2007

On 9/4/07, Alexander Sornes wrote: > Tirsdag 04 september 2007 03:17, skrev Misha Koshelev: > > On 9/3/07, Stefan Dosinger wrote: > > > Am Montag, 3. September 2007 13:30:57 schrieb Damjan Jovanovic: > > > > Somebody needs to make a do-nothing-useful app, intended for Windows, > > > > that also installs on wine and supplies each and every DLL that > > > > Windows applications need but we don't have in wine (like MFC42.DLL, > > > > the D3DX9_xx.DLL's, new MSVCRT's, etc.). That way we can legally use > > > > those DLLs without a Windows licence. > > > > > > This is not necessarily true. I don't know about MFC42.dll or the > > > msvcrts, but the directx eula does not allow that; It requires the > > > application to run only on the Microsoft Windows operating system, > > > targetting both Windows and Linux+Wine violates the contract. These are > > > the conditions for distributing the directx dlls. I've not found anything > > > against installing them on Wine, you just must not distribute the DLLs > > > with an app that targets both Windows and Wine. Thus I think it's legal > > > to write a script that downloads them from the original location > > > @microsoft.com and installs them, as long as that script isn't bundled > > > with the dlls. However, IANAL. > > > > > > What remains unanswered though is how this affects game vendors whose > > > games run on Wine without intention from the game vendor and ship the > > > dlls, e.g. Eve Online. > > > > Actually you all bring up rather interesting points with regards to Vector > > NTI as: > > > > (a) It pretty much ships with almost every Microsoft redistributable needed > > (e.g., MDAC, Windows Script, MFC71, etc.) and installs them on its > > installation _except_ MFC42 (not sure why this oversight and if this would > > break it on some native system, although I _believe_ it installed correctly > > on my plain vanilla Win98 VMWare installation, but I would have to double > > check for sure). > > > > I believe mfc42 is bundled with Windows XP. Actually, I just reinstalled Windows 98 in VMWare _without_ installing VMWare tools and even my version of Windows 98 is bundled with mfc42.dll, so wine really should provide it too... > > > (b) If the licenses for those DLLs/redistributables are the same as you > > suggest for DirectX, this would mean they couldn't ever say they support > > Wine (but I'm not sure whether or not the licenses are). Anyway, seeing it > > work "gold" on Wine still wouldn't be a bad thing in either case and > > certainly Vector NTI is not the only program that needs good winhelp > > support. > > > > Misha > Misha

1 1

Would also like to contribute to Wine
by Reece Dunn Sept. 5, 2007

Sept. 5, 2007

I am interested in the Wine project, and my manager at work has accepted my request to work on it. I work for a company that develops Windows software, so as I have access to Visual Studio, and thus the sources for ATL, MFC and the msvc runtime (provided with the full version of Visual Studio), I state that I will not participate in the development of these components. I have not seen, and do not intend on seeing, any of the Windows source code. I am interested in the following. 1. Writing tests for various parts of Wine, initially the RECT API. I know that this is a simple API, but even the simplest API needs tests. I will expand on this set as time permits. Is it possible for me to write tests for ATL and/or the msvc runtime, as this is not implementing those API? 2. Investigating the failing tests (e.g. the new, unknown message in the monthcal tests on Vista) and how to fix them properly. 3. Improve the user32/comctl32 controls. I would like to address the outstanding issues with these if I can. 4. Microsoft Active Accessibility (MSAA)/User Interface Automation (UIA). I would like to get this working with the various Linux accessibility API, so that more people will have access to Windows applications running on Linux+Wine. 5. Microsoft Text-To-Speech API (part of the sapi DLL). This is on my wishlist and is likely beyond my capabilities to get working. It is used by applications like Dragon Naturally Speaking and Cepstral SwiftTalker. Here, there is supporting voices installed on Windows that use the SAPI interface directly, and voices installed on Linux that implement different APIs. 6. Get theming working with the user32 controls and Window frames. Get the theming support working with GNOME themes as well. 7. Anything else I can think of. I would be interested in improving Wine to help get more applications running on Wine. Does anyone know if there are some common things that are holding Wine up, or is it more a per-application problem as each application is hitting different problems in Wine? - Reece

5 6

The Sims - some hacks
by Trent Waddington Sept. 5, 2007

Sept. 5, 2007

Attached is a patch for some hacks that will get The Sims to run and not crash (for a while). First, there's the easy problem of the cursors not working. This is because Sims.exe calls LoadCursorFromFile on a bunch of files that contain icons, not cursors. As the only difference between the two is that the cursor has a hotspot in front of it, I added some code to treat the icon as a cursor with no hotspot. Other programs may benefit from this patch, as it seems it is something you can get away with on Windows. Then there's the problem of the actual crash. This is caused by CreateSurface in ddraw returning an error and Sims.exe doesn't check for the error. It is returning an error because Sims.exe is trying to create a depth buffer without specifying a valid pixelformat. Note that it actually does pass a pixelformat, it's just all zeros, except for the dwSize member. Again, this appears to be something you can get away with on Windows.. the pixelformat defaults to the current screen format. Once these patches are applied there are significant problems with the game. Minor: the company logo flashes and won't go away without a mouse click. Minor: the scrolling text of pointless terms sometimes overlaps itself Annoyance: there seems to be some blitting error on the "neighborhood" screen that results in parts of the splash screen not being overwritten. Major: the characters in the game are not redrawn correctly, and eventually, it will crash. Overall result: not playable. If someone with a better understanding of wined3d code could have a look, I'd love to receive some hints on what could be causing these issues. Thanks, Trent

3 2

Fwd: Phoronix Forums: AMD Linux Announcement
by Dan Kegel Sept. 5, 2007

Sept. 5, 2007

Say, maybe these new drivers won't crash with Wine a la http://wiki.winehq.org/fglrx Wouldn't that be sweet? ---------- Forwarded message ---------- From: phoronix-forums(a)phoronix.com <phoronix-forums(a)phoronix.com> Date: Sep 4, 2007 9:15 PM Subject: Phoronix Forums: AMD Linux Announcement ... We also wanted to let you know that Advanced Micro Devices has officially announced their new Linux driver this morning, which is a overhaul of their existing Linux graphics driver. The AMD fglrx 8.41 (Catalyst 7.9) driver introduces Radeon HD 2000 "R600" support as well as massive performance improvements for all supported generations of ATI graphics processors. This new driver is not available today, but it will be made available within the next week. Though at Phoronix we have been using and testing this new driver now for a number of weeks. Below are the articles we have just published today about this new ATI/AMD Linux driver. AMD 8.41 Display Driver Preview -- Our first article on this new driver are simply the technical details such as noting this driver has been actually in development for over a year, the AIGLX support that is coming next month, and other relevant information. Read More: http://www.phoronix.com/vr.php?view=10955 ATI R300/400 Linux Performance -- We re-tested the Radeon X300 and X800XL with this new driver and it offers some HUGE performance improvements! The Mobility Radeon X300 was as much as 54 times faster compared to the previous ATI Linux driver. The improvements in these older ATI GPUs are simply astonishing. Read More: http://www.phoronix.com/vr.php?view=10964 ATI R500 Linux Performance -- With an X1300PRO, X1800XL, X1800XT, and X1950PRO in hand we compared the ATI 8.40 and 8.41 display drivers. The performance improvements for the Radeon X1000 series range from 50% to 90% faster. Read More: http://www.phoronix.com/vr.php?view=10970 ATI Radeon HD 2900XT Linux Performance -- Four months after the Radeon HD 2900XT was introduced there is finally proper Linux support! Not only is there support, but it offers a pretty darn good level of performance. In fact, the ATI Radeon HD 2900XT offers the best bang for the buck when it comes to high-end graphics cards. There is also more on the R600 support in general inside this article. Read More: http://www.phoronix.com/vr.php?view=10973 AMD: Accelerating Open-Source Drivers? -- Not today, but in the near future AMD will be making an announcement about accelerating efforts within the open-source community. What does this mean? Open-Source ATI Drivers? We will tell you in due time. Read More: http://www.phoronix.com/vr.php?view=10977 At Phoronix we also have a number of other articles we will be publishing in the near future pertaining to this new driver and the Radeon HD 2000 series support. Be sure to check out the latest articles and join in on the discussions in the Phoronix Forums! Best, The Phoronix Staff

2 1

osalt.com top-requested commercial app stats
by Dan Kegel Sept. 5, 2007

Sept. 5, 2007

http://www.osalt.com/ has a list of most-requested commercial windows apps, currently: 1. Visio 2. Norton Ghost 3. Photoshop 4. Nero Burning Rom 5. Dreamweaver 6. AutoCAD 7. Illustrator 8. Access 9. Premiere Pro 10. ACDSee No idea how they generated that list, but it seems somewhat reasonable. cc'ing them in case they feel like commenting on where that list comes from and what it means. (And no, I don't think Ghost will ever run on Wine :-) - Dan

7 7

Re: comctl32: TCM_SETCURSEL also updates the focus item
by Reece Dunn Sept. 5, 2007

Sept. 5, 2007

On 04/09/07, Aric Stewart <aric(a)codeweavers.com> wrote: > --- > dlls/comctl32/tab.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Do you have a test for this? - Reece

2 1

Re: RFC: winealsa.drv: fix memory leak (found by Smatch)
by Michael Stefaniuc Sept. 4, 2007

Sept. 4, 2007

Hello Lionel, the patch has different problems: - lpNewData is used only in "case MOD_MIDIPORT" so moving the HeapAlloc call there makes more sense. - Please keep the indentation level of the surrounding code; here it is 4. - Tabs are 8 spaces. Lionel_Debroux wrote: > modLongData leaks some heap memory in three error paths. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > While looking at the function, I noticed > if (lpNewData) > HeapFree(GetProcessHeap(), 0, lpData); > at lines 1015-1016. > I think "lpData" should be "lpNewData", because this function allocates > "lpNewData", not "lpData" which is passed to the function through a > LPMIDIHDR structure. > So I added a FIXME, and I am asking for comments/corrections :-) lpNewData is allocated only if lpData has a wrong start/end byte in the header. It is passed on in that case instead of lpData. If the functions to which it is passed on process the data asynchronous then the current code is correct: the caller cannot free the data (lpNewData) as the callee might still need to process it whereas lpData is unused and can be freed. The "event" name suggests an asynchronous processing of the data but that's only a guess as i don't know the code. bye michael > > 2007-08-31 Lionel Debroux <lionel_debroux(a)yahoo.fr> > * dlls/winealsa.drv/midi.c: > winealsa.drv: fix memory leak (found by Smatch) > > > ------------------------------------------------------------------------ > >>From e148279419c180bd3db1b8b1a61f737bd92c73be Mon Sep 17 00:00:00 2001 > From: Lionel Debroux <lionel_debroux(a)yahoo.fr> > Date: Fri, 31 Aug 2007 14:33:40 +0200 > Subject: winealsa.drv: fix memory leak (found by Smatch). > > --- > dlls/winealsa.drv/midi.c | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c > index f5e98ed..2cf9287 100644 > --- a/dlls/winealsa.drv/midi.c > +++ b/dlls/winealsa.drv/midi.c > @@ -1013,20 +1013,26 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > snd_seq_ev_set_sysex(&event, lpMidiHdr->dwBufferLength + len_add, lpNewData ? lpNewData : lpData); > snd_seq_event_output_direct(midiSeq, &event); > if (lpNewData) > - HeapFree(GetProcessHeap(), 0, lpData); > + HeapFree(GetProcessHeap(), 0, lpData); /* FIXME: lpNewData instead of lpData ? */ > break; > default: > WARN("Technology not supported (yet) %d !\n", > MidiOutDev[wDevID].caps.wTechnology); > - return MMSYSERR_NOTENABLED; > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > + return MMSYSERR_NOTENABLED; > } > > lpMidiHdr->dwFlags &= ~MHDR_INQUEUE; > lpMidiHdr->dwFlags |= MHDR_DONE; > if (MIDI_NotifyClient(wDevID, MOM_DONE, (DWORD)lpMidiHdr, 0L) != MMSYSERR_NOERROR) { > WARN("can't notify client !\n"); > - return MMSYSERR_INVALPARAM; > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > + return MMSYSERR_INVALPARAM; > } > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > return MMSYSERR_NOERROR; > } > > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

1 0

Re: dinput: Add evdev mouse driver.
by Stefan Dösinger Sept. 4, 2007

Sept. 4, 2007

Hi, > This is the first fully working implementation of dinput mouse using evdev > generic input driver. I have enabled this driver by default. If people do > not have functioning HAL or that for some reasons it can't find the mouse > device, it will fall-back to current mouse driver. > > Use explorer to enumerate all mice devices. Unfortunately msdn says there > can only be one system pointer device. I was curious if that patch fixes Empire Earth, so I tried it, but it fails to create a new evdev mouse and falls back to the x11 based mouse. It seems that HKEY_LOCAL_MACHINE\HARDWARE\DeviceMap\PointerClass does not exist. I've run wineprefixcreate and made sure I have full access to /dev/input/*, do I need anything else?

2 2

Re: winhelp, Vector NTI, molecular biologists
by Misha Koshelev Sept. 4, 2007

Sept. 4, 2007

On 9/3/07, Stefan Dosinger wrote: > Am Montag, 3. September 2007 13:30:57 schrieb Damjan Jovanovic: > > Somebody needs to make a do-nothing-useful app, intended for Windows, > > that also installs on wine and supplies each and every DLL that > > Windows applications need but we don't have in wine (like MFC42.DLL, > > the D3DX9_xx.DLL's, new MSVCRT's, etc.). That way we can legally use > > those DLLs without a Windows licence. > This is not necessarily true. I don't know about MFC42.dll or the msvcrts, but > the directx eula does not allow that; It requires the application to run only > on the Microsoft Windows operating system, targetting both Windows and > Linux+Wine violates the contract. These are the conditions for distributing > the directx dlls. I've not found anything against installing them on Wine, > you just must not distribute the DLLs with an app that targets both Windows > and Wine. Thus I think it's legal to write a script that downloads them from > the original location @microsoft.com and installs them, as long as that > script isn't bundled with the dlls. However, IANAL. > > What remains unanswered though is how this affects game vendors whose games > run on Wine without intention from the game vendor and ship the dlls, e.g. > Eve Online. Actually you all bring up rather interesting points with regards to Vector NTI as: (a) It pretty much ships with almost every Microsoft redistributable needed (e.g., MDAC, Windows Script, MFC71, etc.) and installs them on its installation _except_ MFC42 (not sure why this oversight and if this would break it on some native system, although I _believe_ it installed correctly on my plain vanilla Win98 VMWare installation, but I would have to double check for sure). (b) If the licenses for those DLLs/redistributables are the same as you suggest for DirectX, this would mean they couldn't ever say they support Wine (but I'm not sure whether or not the licenses are). Anyway, seeing it work "gold" on Wine still wouldn't be a bad thing in either case and certainly Vector NTI is not the only program that needs good winhelp support. Misha

3 3

Monster and Me in wine
by Nguyễn Thành Trung Sept. 4, 2007

Sept. 4, 2007

Hi ! I'm playing Monster and Me (www.monsterandme.com) in wine. In wine 0.9.7, there's a small bug when login, but every else work fine. In other newer versions of wine, login screen works fine, the game's performance is better - nearly like in windows. But there's a bug when talking with NPC make me can't play this game. Can any 1 find and fix this plz? Thanks !

2 1

re: Would like to contribute to wine
by Dan Kegel Sept. 4, 2007

Sept. 4, 2007

Maciej wrote: > I'm looking for subject for my Master's thesis. It might be interesting to > do something useful for Wine. A few things you could help finish: 1) widl, Wine's IDL compiler. Dan Hipschman has been improving widl for some time, but his internship is up in a couple months, and I'm sure he'd love some help. 2) crypt32 / wintrust. Lots of apps need these. Juan Lang has been working on these this summer, but his internship is up at the end of the month, and I'll bet he has a big todo list. 3) gdiplus. Evan Stade did a great job getting this going, and several apps that need it now run, but there's lots left to do. 4) msvcrt. Believe it or not, our bugzilla lists 21 or so bugs against the C runtime library. You'd think we'd have that finished by now, but no. 5) wintab, i.e. the library and service that lets Tablet PC apps run. John Klehm got started on that this summer, but wasn't able to get the event sink demo app running. All of the above would probably be fun, and all have the property that you could make useful progress in a month or two. I'm sure there are lots of other ideas... - Dan

2 1

Re: shlwapi: Duplicate shell32.ShellMessageBoxW implementation in shlwapi.ShellMessageBoxWrapW
by Reece Dunn Sept. 4, 2007

Sept. 4, 2007

On 04/09/07, Dmitry Timoshkov <dmitry(a)codeweavers.com> wrote: > Hello, > > as Alexandre pointed out we can't really forward shlwapi.ShellMessageBoxWrapW > to shell32.ShellMessageBoxW, we need to duplicate its implementation. Is it possible to add a function to libwine that contains this code and then forward both these API to that one? Then you don't have the code duplication. - Reece

2 1

re: winhelp, Vector NTI, molecular biologists
by Dan Kegel Sept. 4, 2007

Sept. 4, 2007

Damjan wrote: > Somebody needs to make a do-nothing-useful app, intended for Windows, > that also installs on wine and supplies each and every DLL that > Windows applications need but we don't have in wine (like MFC42.DLL, > the D3DX9_xx.DLL's, new MSVCRT's, etc.). That way we can legally use > those DLLs without a Windows licence. Ah, but look at the EULA. For instance, the Visual C++ 6 EULA http://kegel.com/wine/isv/visual-studio-6-EULA.html says in section 4.1 that any app that redistributes its redistributables has to add "significant and primary functionality". Thus a do-nothing app would probably not satisfy the EULA, but a fun game might. So, rather than creating such an app yourself, it might be better to go look for existing freely distributed apps (preferably from Microsoft!) which already do this. For instance, Word Viewer 97 from MS has a very liberal EULA that allows free redistribution, and providesl DOCOBJ.DLL (required for Dragon Naturally Speaking) and tahoma font. There are probably several similar apps from Microsoft with unlimited redistribution that happen to bundle mfc40 and mfc42. No reason we couldn't put those apps up on winehq.org, and add an easy way in Wine to download the Popular Application Pack or something like that. - Dan

1 0

winhelp, Vector NTI, molecular biologists
by Misha Koshelev Sept. 3, 2007

Sept. 3, 2007

Hi everybody, So as you all know I've been working on various bug fixes throughout wine, with my most significant contributions to date being MSI OLE automation support and implementation of http protocol support in urlmon. This involvement was driven by my initial experiences of getting a key program used by molecular biologists, Invitrogen's Vector NTI, to install on wine with a fairly convoluted shell script and submitting my first patch to fix a crash with this program; Dan Kegel helped me iron out this first patch a lot and furthermore his comments about how it'd be nice if such a complicated shell script was not necessary with wine got me started with my other patches and the rest, as they say, is history. So why, you may ask, am I sending all this in an email to wine-devel? The short answer is that this is a shameless email to see if I might motivate someone to work on our winhelp implementation a bit, as it is currently completely useless with Vector NTI. This seems like a fairly significant task, and my obligations at school/work have recently kicked up quite a bit, making it unlikely I will be able to take it on anytime soon. However, I hope to motivate someone with these reasons: (i) I feel like I've certainly been doing (and will continue to do) my part in helping out wine, and if this in any case motivates someone looking for a development direction I would certainly not object; and (ii) My ultimate vision/goal has been to have Vector NTI run so well that I could approach Invitrogen and see if they might at the very least say something to that effect on their Web site ("add wine + linux as a supported platform"), if not package Vector NTI a la Google Picassa, which would be great publicity for wine. Also, as you can see from the comments on my ubuntuforums howto http://ubuntuforums.org/showthread.php?t=347095 for a lot of molecular biologists, Vector NTI is the only reason they have to dual-boot/use VMWare at all (full-disclaimer: this is not 100% true for myself). So you could help perhaps a fairly small but non-insignificant group of people by doing some work on winhelp. Although Vector NTI is a rather large set of programs, currently I believe the only things keeping it from installing/working to a "gold" level according to winehq definitions are (i) winhelp and (ii) either MFC42 implementation (required for WSH to install properly; I suppose only a few functions prob are really required, but I'm not sure how good an idea having a very small stub MFC42 would be) or JScript support in wine. Either item in (ii) seems like a very significant undertaking, but (i) seems doable and prob. necessary for a lot of apps. So anyhow just my attempt to influence someone to start working on winhelp. Sorry for cluttering your inboxes. Misha

4 4

Re: dsound: Runtime link to advapi32 RegDeleteTree
by Reece Dunn Sept. 3, 2007

Sept. 3, 2007

Correct me if I am wrong on this, but I have a few questions. And I apologise if I ask some stupid questions, as I don't understand how the Wine loader works. On 01/09/07, Maarten Lankhorst <m.b.lankhorst(a)gmail.com> wrote: > Makes the dsound dll work in windows xp and older versions of windows > again. By this, do you mean running the Wine dsound.dll on _native_ Windows? > It is the least of all evils as far as I could see. It's either > this or adding RegDeleteTree to libwine, unless someone has a third option. If the intent is to get this working on native, adding RegDeleteTree to libwine will not help. Unless you mean running Wine in Windows XP or earlier compatibility mode? If so, I was under the assumption that all the API were available to Wine, it was just the reported OS version that differed. I say this, because none of the Windows headers vary on OS version like the Windows SDK does. Even so, since the RegDeleteTree API are queried for by GetProcAddress, this means that they will not be found on WinXP and earlier, so DllUnregisterServer will fail on those platforms, leaving behind the dsound GUIDs on those platforms. This is bad practice, but I don't see how else this will work (assuming that these are run on native). > +static typeof(RegDeleteTreeW) * pRegDeleteTreeW; Is it common practice in Wine to use typeof? I was under the assumption that this was limited to the gcc C++ compiler. Even if it is available in the C compiler, it is not portable to compilers that don't support that, such as pre-typeof gcc compilers. - Reece

2 2

Hmm. Cider and the LGPL
by Dan Kegel Sept. 3, 2007

Sept. 3, 2007

http://www.linux-community.de/story?storyid=23294 and http://www.macnews.de/news/102145.html mention that some users are using Cider from one game to run a second game on the Mac. The game vendors are upset, and are saying they'll do something to make that harder. There is some question about whether Cider includes LGPL components of Wine, and whether there are any violations lurking there. I imagine our friends at Cedega would instinctively avoid such infringement, but accidents might happen. It'll be interesting to see if anybody finds a real problem. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

6 7

UbiSoft giving away games
by Michael Lothian Sept. 3, 2007

Sept. 3, 2007

Hi Just thought I'd share this with you all. http://www.theinquirer.net/default.aspx?article=42069 For those of you that haven't heard I know FarCry works with wine I'm not sure about the other 2 but it could be worth making them work if they don't as a PR exercise especally if they work under Ceider Any hoo I should be off to bed now Mike

3 2

Re: regedit: fixed a memory leak in listview.c (found by Smatch).
by Dmitry Timoshkov Sept. 3, 2007

Sept. 3, 2007

"Lionel_Debroux" <lionel_debroux(a)yahoo.fr> wrote: > diff --git a/programs/regedit/listview.c b/programs/regedit/listview.c > index 0e4b52b..8b58eec 100644 > --- a/programs/regedit/listview.c > +++ b/programs/regedit/listview.c > @@ -61,7 +61,10 @@ static LPTSTR get_item_text(HWND hwndLV, int item) > > curStr = HeapAlloc(GetProcessHeap(), 0, maxLen); > if (!curStr) return NULL; > - if (item == 0) return NULL; /* first item is ALWAYS a default */ > + if (item == 0) { /* first item is ALWAYS a default */ > + HeapFree(GetProcessHeap(), 0, curStr); > + return NULL; > + } A more logical fix would be to move if (item == 0) return NULL; /* first item is ALWAYS a default */ before HeapAlloc() call. -- Dmitry.

1 0

Re: winhelp, Vector NTI, molecular biologists
by Misha Koshelev Sept. 3, 2007

Sept. 3, 2007

> 2007/9/3, Misha Koshelev <mk144210(a)bcm.edu>: > Hi everybody, > > So as you all know I've been working on various bug fixes > throughout > wine, with my most significant contributions to date being MSI > OLE > automation support and implementation of http protocol support > in > urlmon. This involvement was driven by my initial experiences > of getting > a key program used by molecular biologists, Invitrogen's > Vector NTI, to > install on wine with a fairly convoluted shell script and > submitting my > first patch to fix a crash with this program; Dan Kegel helped > me iron > out this first patch a lot and furthermore his comments about > how it'd > be nice if such a complicated shell script was not necessary > with wine > got me started with my other patches and the rest, as they > say, is > history. > > So why, you may ask, am I sending all this in an email to > wine-devel? > The short answer is that this is a shameless email to see if I > might > motivate someone to work on our winhelp implementation a bit, > as it is > currently completely useless with Vector NTI. This seems like > a fairly > significant task, and my obligations at school/work have > recently kicked > up quite a bit, making it unlikely I will be able to take it > on anytime > soon. However, I hope to motivate someone with these reasons: > > (i) I feel like I've certainly been doing (and will continue > to do) my > part in helping out wine, and if this in any case motivates > someone > looking for a development direction I would certainly not > object; and > > (ii) My ultimate vision/goal has been to have Vector NTI run > so well > that I could approach Invitrogen and see if they might at the > very least > say something to that effect on their Web site ("add wine + > linux as a > supported platform"), if not package Vector NTI a la Google > Picassa, > which would be great publicity for wine. Also, as you can see > from the > comments on my ubuntuforums howto > http://ubuntuforums.org/showthread.php?t=347095 for a lot of > molecular > biologists, Vector NTI is the only reason they have to > dual-boot/use > VMWare at all (full-disclaimer: this is not 100% true for > myself). So > you could help perhaps a fairly small but non-insignificant > group of > people by doing some work on winhelp. > > Although Vector NTI is a rather large set of programs, > currently I > believe the only things keeping it from installing/working to > a "gold" > level according to winehq definitions are (i) winhelp and (ii) > either > MFC42 implementation (required for WSH to install properly; I > suppose > only a few functions prob are really required, but I'm not > sure how good > an idea having a very small stub MFC42 would be) or JScript > support in > wine. Either item in (ii) seems like a very significant > undertaking, but > (i) seems doable and prob. necessary for a lot of apps. > > So anyhow just my attempt to influence someone to start > working on > winhelp. Sorry for cluttering your inboxes. > > Misha > Btw I should have posted the URL to the demo version: http://download.invitrogen.com/evergreen/Vector%20NTI%20Advance%2010.exe To me the main problem with winhelp here is just that none of the winhelp navigation (Contents, Search, etc.) is implemented, making it difficult to, for example, answer the question "how do I do X?" which I'm sure Invitrogen would care about. From what I understand looking over some of the winhelp bug reports, the way .hlp files are currently processed this would be difficult/slow to implement, so probably a different way of processing them is necessary (don't know more than I read from searching for winhelp in the bugzilla for this tho, haven't investigated it myself). Currently there is also a "bug" where WinHelp returns the incorrect value (WM_SENDDATA in winhelp program returns 0L and thus so does WinHelp which just returns the result of SendMessage, whereas according to MSDN WinHelp() shoudl return non-zero on success). In any case this latter thing would be pretty easy to fix, but I think really the rest of winhelp would need to be fixed for this second part to have any real use (other than removing an annoying "Failed to open help file" dialog). Thanks everybody Misha

1 0

Re: ddraw: fix cases where desc2.u2.dwMipMapCount is 0.
by Stefan Dösinger Sept. 3, 2007

Sept. 3, 2007

Am Sonntag, 2. September 2007 14:16 schrieb David Hedberg: > (Resending mail after subscribing to list) > > Hi, > > This patch fixes a problem visible in Delta Force Land Warrior and > Delta Force Task Force Dagger, where extra_surfaces would sometimes > get a value of -1 and later cause a "near infinite" loop in > CreateAdditionalSurfaces. I think you should test that in the desc2.dwFlags & DDSD_MIPMAPCOUNT case above, where currently the "Mipmap count is given, nothing to do" comment is. It would be good if you extended the test case in dlls/ddraw/tests/dsurface.c to test the case where the mipmapcount flag is set, but the mipmap count is 0. It could either create a one-level surface (like your patch currently does), or ignore the mipmapcount flag, and create mipmaps until either width and height are 0.

2 2

Re: Window decorations missing on Compiz/Debian Etch
by Maarten Lankhorst Sept. 2, 2007

Sept. 2, 2007

Michael Jung schreef: > Hi Maarten, > > Thanks for pointing me to the FAQ. The FAQ entry seems to address > primarily OpenGL related issues, however, which I'm currently not > concerned about that much. Given the fact that the window decorations > used to work just fine before the mentioned patch, I would consider > this a regression. > > Bye, > -- > Michael Jung > mjung(a)iss.tu-darmstadt.de > Hi Michael, First of all, please do 'reply all' so a copy gets sent to wine-devel too. Second, if the bug only occurs with compiz/beryl it is really likely that it is a compiz/beryl bug., since it's not really a mature window manager, and has a lot of bugs, even not considering opengl. Cheers, Maarten

2 1

[RFC] [PATCH] GNU make based build system for Winelib applications
by Kirill Smelkov Sept. 2, 2007

Sept. 2, 2007

Hello Wine developers, Francois! I am going to port some Win32 applications to GNU/Linux and though it would be useful to improve the build system for Winelib applications. Current status and Motivation ============================= 1. Wine in-tree Makefiles for programs & dlls are pretty much good and maintainable, but they lack C++ support. 2. Initial approach taken by winemaker (I used it in 2003-2004) was to adapt Wine's make rules to support C++ . 3. At present winemaker dropped supplying above mentioned rules and generates very simple makefiles. To me this approach have several problems: - lack of dependency tracking - hard to maintain Makefiles. The rules generated are substituted in each Makefile instead of being in one place. - good as a starting point, but not a complete solution. Winemaker already relies on GNU toolchain (in form of gcc and g++), and I though:: Why not use GNU make with all available extensions when necessary, and deploy a simple full-featured build system for Winelib based applications The result is presented here for public review. Comments, suggestions? Features ======== * support C, C++ and resource files. * automatic dependency tracking for C and C++. * beautified build output (to increase SNR and concentrate on errors and warnings). * winemaker patches provided (although I don't know Perl -- help needed, Francois?). * Tested with GNU make 3.81. This version of GNU make was released in 2006 and is present in all recent Linux distributions. Usage example ============= I attach winelib-gnu-make.tar.gz where an interested reader can see Winemake build system usage. For usage example see directory clock+wow32/ . There I provide example of how to build 1 program and 2 dlls. Original clock.exe & wow32.dll processed by winemaker are located in misc/ for comparison.

1 0

Re: [5/5] WineD3D: texkill ignores the .w only in ps 1.x
by Tomas Carnecky Sept. 1, 2007

Sept. 1, 2007

+ + hr = IDirect3DDevice9_Clear(device, 0, NULL, D3DCLEAR_TARGET, 0xff00ff00, 0.0, 0); + ok(hr == D3D_OK, "IDirect3DDevice9_CreatePixelShader returned %s\n", DXGetErrorString9(hr)); Is that worth changing? tom

2 1

Re: secur32: Add some missing prototypes to ntsecapi.h.
by Kai Blin Sept. 1, 2007

Sept. 1, 2007

On Saturday 01 September 2007 02:45:33 Francois Gouget wrote: > --- > include/ntsecapi.h | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) Thanks, that was on my list, but I didn't get around to it yet. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [1/3] whhc - add chm compiler
by Vitaliy Margolen Sept. 1, 2007

Sept. 1, 2007

Miikka Viljanen wrote: > adds the whhc chm compiler under tools/whhc > > And what told you that you can just change the license from GPL to Wine's LGPL by just editing the header? Have you even asked authors of the program? Vitaliy.

1 0

Re: [PATCH] user32: edit control should respond to ctrl + z (try 2)
by Dmitry Timoshkov Sept. 1, 2007

Sept. 1, 2007

"Lei Zhang" <thestig(a)google.com> wrote: > This patch lets users hit ctrl + Z in edit controls to trigger an > undo. The test case has been improved to check for return values when > appropriate. > + /* select all, cut (ctrl-x), undo (ctrl-z) */ > + SendMessage(hwEdit, EM_SETSEL, 0, -1); > + r = SendMessage(hwEdit, WM_CHAR, 24, 0); > + todo_wine { ok(r == 1, "Expected: %d, got: %d\n", 1, r); } > + r = SendMessage(hwEdit, WM_CHAR, 26, 0); > + todo_wine { ok(r == 1, "Expected: %d, got: %d\n", 1, r); } By "I'd suggest to add checks to make sure that every message you send above really worked." I meant not simply check the SendMessage return values, but actual Edit contents/selection changes tracking. -- Dmitry.

1 0