September 2007 - Wine-Devel

Re: winex11.drv[1/4]: fix two bugs in WTInfoA
by Alexandre Julliard Sept. 19, 2007

Sept. 19, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Two bugs I've found working on previous implentations > From b233532f7adc140c4e36fb2288581fe0ff181935 Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Miko=C5=82aj_Zalewski?= <mikolaj(a)zalewski.pl> > Date: Mon, 17 Sep 2007 11:54:41 -0700 > Subject: [PATCH] winex11.drv: fix two bugs in WTInfoA Please write a better description of the changes, "fix bug" can apply to just about any commit (and in general, if you have two bugs to fix there should be two patches...) -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: A first implentation of services.exe
by Robert Shearman Sept. 18, 2007

Sept. 18, 2007

Mikolaj Zalewski wrote: > I don't want this patch to get committed but to maybe get some > comments. If the patch will be considered to be ok I can send it as > three smaller patches. It implements the basic infrastructure for > services.exe - a process that maintains the services database and > states. I think this can be useful in the long run. Absolutely. > This patch > currently doesn't implement anything useful - it connects to > services.exe in OpenSCManager and disconnect in CloseServiceHandle and > validating the database name is now done in services.exe but if this > approach is good I will add more functionality. > It looks good to me, but I'm a bit worried that you'll come across bugs/unimplemented features in widl when you start adding more calls. > Is there a way to check if a RPC connection over a named pipe was > closed by the client (probably we should close all it's handles in > such a case)? Yes, you can do this using context handles, but unfortunately we're lacking support for these on the RPC server side and in widl. > Also this program show a bug in our rpcrt4 - if we pass > NULL as a [in,unique,string] parameter rpcrt4 will crash because of a > strlen on it in NdrConformantStringBufferSize. To see it one can > remove the workaround in OpenSCManager and do a `make test`. That sounds like a bug in widl to me, and I'll take a look. > Macros > like RET_IF_ERROR should be removed from the final version or can they > stay? Definitely should be removed. > diff --git a/include/wine/svcctl_shared.h b/include/wine/svcctl_shared.h > new file mode 100644 > index 0000000..5687ddc > --- /dev/null > +++ b/include/wine/svcctl_shared.h > @@ -0,0 +1,35 @@ > +/* > + * SVCCTL (services.exe RPC interface) shared constants > + * > + * Copyright (C) 2007 Google (Mikolaj Zalewski) > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#ifndef __WINE_SVCCTL_SHARED_H > +#define __WINE_SVCCTL_SHARED_H > + > +#include <stdarg.h> > +#include <windef.h> > +#include <winbase.h> > + > +#define SVCCTL_TRANSPORT {'n','c','a','c','n','_','n','p',0} > +#define SVCCTL_ENDPOINT {'\\','p','i','p','e','\\','s','v','c','c','t','l',0} > + > +/* Not the Windows event name - if needed the true one can be found in Inside Windows */ > +#define SVCCTL_STARTED_EVENT (const WCHAR[]){'S','v','c','c','t','l','S','t','a','r','t','e','d',0} > + > + > +#endif /* __WINE_RPCSS_SHARED_H */ > We shouldn't need another file for this. You can put this same stuff in svcctl.idl using cpp_quote. > +DWORD RPC_MainLoop() Make sure to fully specify the parameters for functions with no parameters by declaring them as "(void)". -- Rob Shearman

1 0

Want to contact Mike McCormack
by Stefan Ensslen Sept. 18, 2007

Sept. 18, 2007

Dear Sirs, I wanted to contact Mike McCormack from the WinE developer team, but my email to mike(a)codeweavers.com bounced. If you could send me his new email address, I'd be very happy. The question I wanted to ask Mr. McCormack is the following: Dear Mike, I have found your code for generating proxy/stub-code at www.winehq.org. I wanted to ask where you have found a documentation of the functions used in this code (for example NdrProxyInitialize, NdrProxySendReceive, and so on). The MSDN doesn't provide any _valuable_ documentation for this function, so you surely have another source of documentation. Thanks in advance, Stefan Ensslen -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

2 1

AppDB down - too many SQL connections?
by Alexander Nicolaysen Sørnes Sept. 18, 2007

Sept. 18, 2007

Hello, I am unable to access the database now because of too many MySQL connections. Does anyone have a log file to indicate whether this is some sort of attack, or whether we just have too many legitimate users? Alexander N. Sørnes

2 1

make crosstest is missing -lcabinet
by Pedro Araújo Sept. 18, 2007

Sept. 18, 2007

Hi all, I've been trying to cross-compile the Wine tests, but I keep getting this error: $ ./configure && make crosstest [SNIP] i586-mingw32msvc-gcc advpack.cross.o files.cross.o install.cross.o testlist.cross.o -o advpack_crosstest.exe -lcabinet -luser32 -ladvapi32 -lkernel32 /usr/lib/gcc/i586-mingw32msvc/3.4.5/../../../../i586-mingw32msvc/bin/ld: cannot find -lcabinet collect2: ld returned 1 exit status make[2]: *** [advpack_crosstest.exe] Error 1 make[2]: Leaving directory `/.../dlls/advpack/tests' make[1]: *** [advpack/tests/__crosstest__] Error 2 make[1]: Leaving directory `/.../dlls' make: *** [dlls/__crosstest__] Error 2 Am I missing anything? Thanks in advance. -- - Pedro.

2 2

Problem with TCP Option 0x00000008
by Christian Mahnke Sept. 18, 2007

Sept. 18, 2007

Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x00000008" after the loading of native rpcltccm.dll. To work around this i've compiled a modified wine 0.9.44 with an empty case statement for 0x00000008 in socket.c. It doesn't help much, the program just fails a bit later. The TCP Option 0x00000008 is defined as TCP_ATMARK in ws2_ipdef.h in the Windows SDK. Does anyone know how this should be mapped ? Cheers, Christian

4 6

compile wine from sources - strange messages
by Andrey Gavrilin Sept. 18, 2007

Sept. 18, 2007

Hello. I wish to compile wine from sources. Has received such message. The distribution: Ubuntu 7.04. What headers files does not suffice? PS I used the program the translator from Russian to English. configure: WARNING: jack/jack.h: present but cannot be compiled configure: WARNING: jack/jack.h: check for missing prerequisite headers? configure: WARNING: jack/jack.h: see the Autoconf documentation configure: WARNING: jack/jack.h: section "Present But Cannot Be Compiled" configure: WARNING: jack/jack.h: proceeding with the preprocessor's result configure: WARNING: jack/jack.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## configure: WARNING: pthread.h: present but cannot be compiled configure: WARNING: pthread.h: check for missing prerequisite headers? configure: WARNING: pthread.h: see the Autoconf documentation configure: WARNING: pthread.h: section "Present But Cannot Be Compiled" configure: WARNING: pthread.h: proceeding with the preprocessor's result configure: WARNING: pthread.h: in the future, the compiler will take precedence

2 1

Re: kernel32: Don't crash accessing an invalid handle in GlobalSize
by Robert Shearman Sept. 18, 2007

Sept. 18, 2007

James Hawkins wrote: > + if (IsBadReadPtr(pintern, 1)) > + { > + SetLastError(ERROR_INVALID_HANDLE); > + return 0; > + } > + > if(pintern->Magic==MAGIC_GLOBAL_USED) > { > if (!pintern->Pointer) /* handle case of GlobalAlloc( ??,0) */ It would be better to wrap the Magic access with an exception handler rather than use IsBadReadPtr. -- Rob Shearman

1 0

Re: fix for bug 9665
by James Hawkins Sept. 17, 2007

Sept. 17, 2007

On 9/17/07, Martin <martin.marsan(a)gmail.com> wrote: > > > 2007-09-17 Martin Sand <deadlock(a)start.no> > > * dlls/ddraw/direct3d.c: > ddraw: fixes a bug which prevents Kings Quest 8 from starting(bug 9665) > A good changelog entry details what you changed, not what apps are fixed by a change. -- James Hawkins

2 1

Re: fix for bug 9665
by Stefan Dösinger Sept. 17, 2007

Sept. 17, 2007

Am Montag, 17. September 2007 20:45:04 schrieb Martin: I doubt this fix is correct, as explained in bug 9665 a few minutes ago. It should fail the d3d test too

1 0

[AppDB] Bug: Let objectManager delete bug links
by Alexander Nicolaysen Sørnes Sept. 17, 2007

Sept. 17, 2007

Bug: Let objectManager delete bug links Regards, Alexander N. Sørnes

1 0

Re: user32: better fix how to handle GetWindowLongPtr[AW](..., GWLP_WNDPROC) for builtin winprocs [resend]
by Alexandre Julliard Sept. 17, 2007

Sept. 17, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Is there something wrong with this patch? > From 50eacd2465df53e5cfc15458ff5ab80f0cc07e7e Mon Sep 17 00:00:00 2001 > From: Mikolaj Zalewski <mikolaj(a)zalewski.pl> > Date: Mon, 10 Sep 2007 14:03:49 -0700 > Subject: [PATCH] user32: better fix how to handle GetWindowLongPtr[AW](..., GWLP_WNDPROC) for builtin winprocs There are several other places where winprocs are returned, like SetWindowLong or GetClassLong. You probably have to handle them too, or at least write test cases for them. -- Alexandre Julliard julliard(a)winehq.org

1 0

An enumeration of network resources
by Konstantin Kondratyuk Sept. 17, 2007

Sept. 17, 2007

Hello! I try to organize an enumeration of network resources by means of functions WNetOpenEnum and WNetEnumResource. Function WNetOpenEnumW contains a line: " ret = providerTable->table[index].openEnum( dwScope, dwType, dwUsage, lpNet, &handle); " which addresses to function in dll. The information about loaded dll is absent in the wine registry. Whether it means, what there are no preparations of DLL's for work with a network (similar ntlanman.dll in Windows)? -- Best regards, Konstantin Kondratyuk.

2 1

Re: msi(1/3): Don't crash if rec is NULL
by James Hawkins Sept. 17, 2007

Sept. 17, 2007

On 9/14/07, Juan Lang <juan.lang(a)gmail.com> wrote: > This series of patches is in response to Jeremy's troubles with > iTunes. They may or may not fix the installer for him, but they > prevent potential crashes. > --Juan > MSI_FormatRecordW is an internal function and we should be crashing if rec is NULL. -- James Hawkins

3 5

old dos/windows program crashing
by Joris Huizer Sept. 17, 2007

Sept. 17, 2007

Hello, I have a program, that I got like ages ago. It effectively is an atari emulator for dos, by the name "pacifist", but I originally got it installed under windows ME. It has an old atari-basic program "installed" in it, (a simple game) written by a friend in it, which I wanted to play. I decided to try to get it to run again under Linux. The website it came from originally doesn't seem to have the program available for download anymore - so I just copied the files from the windows ME disc. I obviously tried WINE then, but it didn't work, however, dosbox works with it (though slow, obviously) so I know I'm not missing required files (though, perhaps, registry settings - not sure how likely that is, though) Anyway. This isn't such a big deal, though I'd like to look at what's going on in WINE, and possibly fix it - though I need help here. This program is, among things, a "PMODE W/DOS Extender" - so that means it probably does some obscure real-mode/protected-mode stuff. Console output is as follows, Warning: unprotecting memory to allow real-mode calls. NULL pointer accesses will no longer be caught. err:int:__wine_emulate_instruction mov cr0,eax at 0x00000544 err:int:DOSVM_Int33Handler int33: unknown/not implemented parameters: int33: AX 0015, BX 0003, CX 11f7, DX 1165, SI 0055, DI 03ac, DS 11df, ES 11e7 fixme:int:DOSVM_Int10Handler Select vertical resolution - not supported fixme:int:DOSVM_Int10Handler Load ROM 8x8 Double Dot Patterns - Not Supported fixme:int31:DOSVM_Int31Handler physical address mapping (0x00000000) - unimplemented wine: Unhandled page fault on read access to 0xffffffff at address 0x101f:0x0003ed71 (thread 002d), starting debugger... fixme:dbghelp:addr_to_linear Failed to linearize address 08f0:00000002 (mode 0) fixme:dbghelp:addr_to_linear Failed to linearize address 08f0:00000000 (mode 0) Also I attached the visual display the "winevdm" shows as the program crashes. (It seems it crashes somewhere in generated code in kernel32.dll - in DPMI_PendingEventCheck() - written by the winebuild tool) I know some things about real-mode code, but not too much. Could you give me pointers on what to look at next? BTW, please CC me, I'm not on the mailing list currently. Thanks, Joris ____________________________________________________________________________________ Check out the hottest 2008 models today at Yahoo! Autos. http://autos.yahoo.com/new_cars.html

3 4

AppDB: cannot submit a screenshot even when logged in
by Vit Hrachovy Sept. 16, 2007

Sept. 16, 2007

Hello everybody, I may missed something, but I cannot submit a screenshot to the application I maintain in AppDB and I'm logged in. There's always a nasty 'Log in to submit screenshots' instead of Submit button. Is it planned downtime? Regards Vit P.S. It's http://appdb.winehq.org/screenshots.php?iAppId=4025

2 2

DirectDraw opengl renderer
by Alexander Nicolaysen Sørnes Sept. 16, 2007

Sept. 16, 2007

Hello everyone, I know this has been discussed before (and not that long ago), but I think I have some wonderful new information to add to the debate of whether or not to add an option for this in winecfg. As I understand it, there is still a long time before the opengl renderer will become the default one. With Wine 0.9.45, some bugs were fixed allowing the opengl renderer to be used for C&C Tiberian Sun, and I must say the speed improvements are dramatic! Without any FPS tools I would definitely say performance has increased by several hundred per cent. Now the game is so fast I may have to turn down the game speed setting. :) If you move the mouse it still slows down, though, as it does with the gdi renderer. Anyway, I think this should apply to several other games as well (and I will test more). But I was wondering is this is enough to add an option in winecfg? Alexander N. Sørnes

3 3

Re: RICHED20: additional tests plus RFC
by Alexander Nicolaysen Sørnes Sept. 16, 2007

Sept. 16, 2007

On Sunday 16. September 2007 04:34:17 a_villacis(a)palosanto.com wrote: > I am tracking down a richedit bug in FACETS (bug #1713). > > Apparently, the OCX control used by this app expects a particular > SendMessage() > with the message EM_SETCHARFORMAT to return 1. Currently builtin returns 0 > unconditionally, making this app bail out with "Invalid property value". By > changing the return value to 1 unconditionally, the app gets "fixed", but > this > is not a proper solution, since other apps might break with this change. > > This patch adds additional testing of EM_SETCHARFORMAT. All todo_wine's > succeed > in an installation of WinXP SP2. Please confirm this is so for all of you. > > There are two code blocks commented out. The first one makes the app crash > on WinXP, and is listed for completeness. The other one was supposed to > test what > happens when the riched20 control receives a blanked-out CHARFORMAT2 > structure. > However this triggers an assertion in Wine at style.c line 63. WinXP > doesn't bat an eye, and possibly ignores these structure values. Unless > somebody objects, I will shortly send a patch that replaces the assertion > with a NULL return in style.c, plus a NULL check in editor.c . > > There are more riched20 tests that fail in WinXP SP2, unrelated to > EM_SETCHARFORMAT, but I would like confirmation that (1) somebody else sees > failing tests in native Windows, not just me, and (2) this patch does not > introduce any new failing tests in native Windows. > > Changelog: > * Add additional tests for EM_SETCHARFORMAT message of riched20 control Hey, great to see some work on EM_SETCHARFORMAT. If you're interested, Wine has a builtin WordPad (just type 'wine wordpad') which exposes some problems. Try to select a font in the font list when no text is selected, for instance. Alexander N. Sørnes

1 0

Re: [PATCH 2/7] gdi: Implement BiDi classification of characters
by Steven Edwards Sept. 16, 2007

Sept. 16, 2007

Hi Maarten, Could you configure your git scripts to output different filenames when generating patches? Somehow they get managed for me in my gmail inbox. It makes it quite a pain for me to review. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

6 10

Re: patches to make wine compile on osx
by Roderick Colenbrander Sept. 16, 2007

Sept. 16, 2007

Hi Daniel, A few comments regarding the patches. First of all you should use a single patch file for each patch (this makes tracking patches easier). Now over to the patches. Regarding wineosxtypeerrors.patch: - 'GLenum' should be 'unsigned int' instead of int. I don't understand why the casts are needed as it should just get the type info from gl.h. I think that using '%u' for unsigned data could fix most of your problems. Regarding wineosxglexterrors.patch: - Same comment regarding unsigned int data. (make this a separate patch) - GL_TEXTURE_RECTANGLE_NV should be handled in include/wine/wgl.h, strange that I didn't receive compile failures for linux about it .. perhaps it is already in the mesa headers. (make this a separate patch) Anyway I would define GL_TEXTURE_RECTANGLE_NV like this: #ifndef GL_NV_texture_rectangle #define GL_TEXTURE_RECTANGLE_NV 0x84F5 #define GL_TEXTURE_BINDING_RECTANGLE_NV 0x84F6 #define GL_PROXY_TEXTURE_RECTANGLE_NV 0x84F7 #define GL_MAX_RECTANGLE_TEXTURE_SIZE_NV 0x84F8 #endif The extension is fully compatible with GL_ARB_texture_rectangle which osx should have and GL_EXT_texture_rectangle is likely the same. (the constants between the ARB and NV one are also the same, I expect the same for EXT and ARB) Regards, Roderick Colenbrander

1 0

Dfw5 draws graphs black (regression)
by Willi Mann Sept. 15, 2007

Sept. 15, 2007

Hi! Derive 5 no longer draws graphs in color. It should look like that: http://wserver.wm1.at/~willi/wine/dfw.png With current versions, it draw the blue graph in black. I could track it down to this commit (between 0.9.25 and 0.9.26): http://wserver.wm1.at/~willi/wine/wine_dfw.diff.txt (In fact, these are two commits, but the intermediate version does not compile) Please let me know if I can do anything to help fixing this bug. Willi Please CC: me on replies.

2 2

Re: add shell32.755
by Maarten Lankhorst Sept. 15, 2007

Sept. 15, 2007

Louis. Lenders schreef: > Hi, i'm sending in 2 patches from Anastasius Focht for review, and > hopefully for inclusion in git. Otherwise they might get "lost" and > forgotten. > > They're helpful for testing apps with native comdlg32.dll. So although > they do not really fix any real life app (not that i know of I'm missing a few tests to see if this behavior is actually what it should be like in windows. You should always add them to implementations of new functions. Cheers, Maarten

1 0

Re: fnt2fon: janitorial IgnoredReturnValues (1/5)
by Alexandre Julliard Sept. 14, 2007

Sept. 14, 2007

Lionel_Debroux <lionel_debroux(a)yahoo.fr> writes: > tools/fnt2fon is flagged in the janitorial page "IgnoredReturnValues". > This page is outdated, but its content is still valid for fnt2fon, which > ignores a number of return values. I don't think that's worth fixing, the warnings are essentially useless, it just makes the code uglier. There may be a few legitimate errors in there, like checking the fopen() result, and those could be fixed; but please don't add checking to every call that gcc complains about. -- Alexandre Julliard julliard(a)winehq.org

2 2

Problem with TCP Option 0x00000008
by Christian Mahnke Sept. 14, 2007

Sept. 14, 2007

Hello, i have a problem with a program that uses a network license manager. I've installed native DCOM using the winetricks script. When i start the program i got the message "fixme:winsock:WS_setsockopt Unknown IPPROTO_TCP optname 0x00000008" after the loading of native rpcltccm.dll. To work around this i've compiled a modified wine 0.9.44 with an empty case statement for 0x00000008 in socket.c. It doesn't help much, the program just fails a bit later. The TCP Option 0x00000008 is defined as TCP_ATMARK in ws2_ipdef.h in the Windows SDK. Does anyone know how this should be mapped ? Cheers, Christian

1 0

Re: winex11.drv/wintab32[1/5]: store categories field-by-field (resend)
by Alexandre Julliard Sept. 14, 2007

Sept. 14, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > /*********************************************************************** > * X11DRV_WTInfoA (X11DRV.@) > + * > + * NOTES > + * If cchOnlyCountString is not NULL and the data is a string then no > + * data is stored in the output buffer but only the string length is > + * returned in *cchOnlyCountString (and is >= 1 as contains at least a NUL > + * character). It have no effect on non-string data. > + * > + * Apart from the cchOnlyCountString parameter this function differs from the > + * WTInfo[AW] as for nIndex == 0 it returns the number of items in the > + * category. It's wintab32.dll that concatenates the data > + * > + * It is valid to call WTInfoA with lpOutput == NULL, as per standard. > + * lpOutput == NULL signifies the user only wishes to find the size of > + * the data. > */ > -UINT X11DRV_WTInfoA(UINT wCategory, UINT nIndex, LPVOID lpOutput) > +UINT X11DRV_WTInfoA(UINT wCategory, UINT nIndex, LPVOID lpOutput, DWORD *cchOnlyCountString) You shouldn't change the prototype. Driver functions should follow the signature of the corresponding APIs as far as possible. -- Alexandre Julliard julliard(a)winehq.org

2 2

carbon poker under wine
by Trent Waddington Sept. 14, 2007

Sept. 14, 2007

On 9/13/07, Eric Andersen <xxxx(a)xxx.com> wrote: > I was wondering if you could possibly throw me some pointers for > getting Carbon Poker working under wine. > > For the record I'm using ubuntu feisty and wine 0.9.44. I'll forward this to wine-devel, as someone else might want it. Well, first thing you should try is building wine from the git tree. This is painful and annoying because Linus is stupid and ugly but there's been a lot of fixes to the crypt32 stuff recently, and you'll need that: git clone git://source.winehq.org/git/wine.git wine cd wine ; ./configure ; make etc. You can try what I'm doing with your current version first, as it has some of this crypt32 stuff.. so it might work. I downloaded CarbonPoker.exe from the website, ran it with wine and it complains that I don't have flash8 and then just sits there and does nothing. I don't know what it is doing, so I just went downloaded Flash: wget http://fpdownload.macromedia.com/get/flashplayer/current/install_flash_play… ./wine install_flash_player.exe That installs happily. So, running CarbonPoker.exe again.. ./wine CarbonPoker.exe err:ole:COMPOBJ_DllList_Add couldn't load in-process dll L"C:\\windows\\system32\\Macromed\\Flash\\Flash9b.ocx" Uhhh, ok. Having a look in that dir I see a Flash9.ocx but no Flash9b.ocx, what the hell? cd ~/.wine/drive_c/windows/system32/Macromed/Flash/ ln -s Flash9.ocx Flash9b.ocx cd - ./wine CarbonPoker.exe and now it is happy and starts "Installing software..." which actually means it is updating the stub.. which it then runs, and starts "Installing software..." again.. You can ignore the "HTML rendering is currently disabled" where the installer would usually be telling you about the great benefits you get from playing Carbon Poker. Eventually this finishes. The installer goes away.. and after waiting and waiting, I get bored and hit CTRL-C. Fine, let's just run it then: ./wine ~/.wine/drive_c/Program\ Files/CarbonPoker/Poker.exe I get a "It appears the software has generated a bug. You can optionally submit it with comments about what you were doing at..." and as much as I'd like to do that with something like "doesn't work under wine" I'm going to press Cancel. Now we're in the login screen and it's asking me how I'd like to login, etc. So it looks like it is running! Just to check, I'm closing it and running it again.. yep, I'm in the login screen again. It's running. Hmm, I have a login for this game around here somewhere.. putting in my email address and pressing "Forgot Password" gives me this error: wine: Call from 0x7ee53f40 to unimplemented function urlmon.dll.HlinkSimpleNavigateToMoniker, aborting That isn't much help. And that crashed it, so running it again.. Sidenote: http://www.carbonpoker.com/pass.html is not secure.. ever heard of "denial of service" guys? Anyway, got some login details. Logged in, I see spam. Click on "Poker Tables". Up some come. Click on the first non-full one and "Join Table". And yes, I can join the table and sit down. I'm playing Poker. Yah. Trent

1 1

First song purchased on iTunes 7 with Wine...
by Dan Kegel Sept. 13, 2007

Sept. 13, 2007

For the record, I just bought "Autobahn" by Kraftwerk for $0.99 from the iTunes store using iTunes 7 on today's wine from git. It's playing now while I type this message. (OK, the music skips sometimes when I type or adjust the volume or move the mouse or scratch my nose... but hey, at least it's a start!) Thanks, Juan! - Dan

3 4

Re: [2/2] WGL: Sync pixmap after glFlush/glFinish, not before every GL call
by Alexandre Julliard Sept. 13, 2007

Sept. 13, 2007

Chris Robinson <chris.kcat(a)gmail.com> writes: > From 95214f29672566796564db30ab7f61a2462e4e50 Mon Sep 17 00:00:00 2001 > From: Chris Robinson <chris.kcat(a)gmail.com> > Date: Wed, 12 Sep 2007 06:42:05 -0700 > Subject: [PATCH] WGL: Sync pixmap after glFlush/glFinish, not before every GL call The goal is to sync the pixmap before we start drawing to it, so doing it at glFlush time is too late. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: avifil32: Fix some memory leaks
by Paul Vriens Sept. 13, 2007

Sept. 13, 2007

Andrew Talbot wrote: > Changelog: > avifil32: Fix some memory leaks. > > > - if (mmioSeek(This->paf->hmmio, This->paf->dwNextFramePos, SEEK_SET) == -1) > - return AVIERR_FILEWRITE; > - if (mmioCreateChunk(This->paf->hmmio, &ck, 0) != S_OK) > - return AVIERR_FILEWRITE; > - if (mmioWrite(This->paf->hmmio, (HPSTR)lppc, ck.cksize) != ck.cksize) > - return AVIERR_FILEWRITE; > - if (mmioAscend(This->paf->hmmio, &ck, 0) != S_OK) > + if (mmioSeek(This->paf->hmmio, This->paf->dwNextFramePos, SEEK_SET) == -1 || > + mmioCreateChunk(This->paf->hmmio, &ck, 0) != S_OK || > + mmioWrite(This->paf->hmmio, (HPSTR)lppc, ck.cksize) != ck.cksize || > + mmioAscend(This->paf->hmmio, &ck, 0) != S_OK) > + { Doesn't this mean that every one of those 4 mmio-calls are executed? In the previous logic we would bail out after one failure. -- Cheers, Paul.

3 3

Re: wineprefixcreate: Make sure the path returned by GetTempPath() during the $WINEPREFIX creation will be writable.
by Alexandre Julliard Sept. 13, 2007

Sept. 13, 2007

Francois Gouget <fgouget(a)codeweavers.com> writes: > mshtml.dll (and probably many others) use GetTempPath() during the > self-registration process. But at that point the Windows environment > variables, and in particular $TMP and $TEMP, have not been set yet, > especially not in the currently running process. So when mshtml.dll > calls GetTempPath(), that function returns the current directory, which > obviously is no good if that directory is not writable (like '/' for > instance). So this patch makes 'c:\windows\temp' the current directory, > which we know will be writable (and the chdir() should have no other > side effect in this script). Actually GetTempPath is not supposed to use the current directory, I committed a fix. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32[2/4]: implement AddFontMemResourceEx (based on a patch of Byeong-Sik Jeon, helps with bug #5865) (resend)
by Alexandre Julliard Sept. 13, 2007

Sept. 13, 2007

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index c516736..efc044b 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -3214,8 +3214,18 @@ BOOL WINAPI RemoveFontResourceW( LPCWSTR > */ > HANDLE WINAPI AddFontMemResourceEx( PVOID pbFont, DWORD cbFont, PVOID pdv, DWORD *pcFonts) > { > - FIXME("(%p,%08x,%p,%p): stub\n", pbFont, cbFont, pdv, pcFonts); > - return NULL; > + PVOID pFontCopy = HeapAlloc(GetProcessHeap(), 0, cbFont); > + HANDLE ret; > + > + TRACE("Copying %d bytes of data from %p to %p\n", cbFont, pbFont, pFontCopy); > + memcpy(pFontCopy, pbFont, cbFont); > + ret = WineEngAddFontMemResourceEx(pFontCopy, cbFont, pdv, pcFonts); > + if (ret == NULL) > + { > + TRACE("Font create failed - freeing %p\n", pFontCopy); > + HeapFree(GetProcessHeap(), 0, pFontCopy); > + } > + return ret; > } The memory copy should be done in WineEngAddFontMemResourceEx since that's where the data is managed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] WineD3D: Pixel shader 1.x constants are clamped to [-1;1]
by Alexandre Julliard Sept. 13, 2007

Sept. 13, 2007

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > It is hard to judge if this patch will fix anything. A problem is that > clamping the constants on loading makes constants loading more expensive. > Luckilly though there aren't many ps 1.x constants(8 max). It is hard to say > if there are any games that use constants > 1.0, but incorrect constant > loading can have many bad effects. This one fails make test for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:3068: Test failed: quad 1 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3070: Test failed: quad 2 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3073: Test failed: quad 3 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3077: Test failed: quad 4 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3207: Test failed: quad 1 has color 007f7f00, expected 0x00808000 visual.c:3209: Test failed: quad 2 has color 007f7f00, expected 0x00808000 visual.c:3211: Test failed: quad 3 has color 007f7f00, expected 0x00808000 visual.c:3214: Test failed: quad 4 has color 00bfbf7f, expected 0x00bfbf80 make[2]: *** [visual.ok] Error 8 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WGL: Fix a major ATI regression
by Joerg Mayer Sept. 13, 2007

Sept. 13, 2007

On Thu, Sep 13, 2007 at 01:09:14AM +0200, Roderick Colenbrander wrote: > The change isn't a hack but more a workaround. I have submitted the bugreport to ATI but they likely won't fix it anytime soon. Well, if I understood the ATI development cycle correctly, even if they fixed it right away it will take another two releases (months) until it is released. ciao Joerg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

1 0

Cvs update error.
by Anatoly Lyutin Sept. 13, 2007

Sept. 13, 2007

Hi all!! Today I tried to make cvs update and cvs extradites a error: [vostok(a)windsor wine]$ cvs update cvs [update aborted]: unrecognized auth response from cvs.winehq.org: cvs pserver: /home/wine/CVSROOT/config [8]: warning: this CVS does not support PreservePermissions What happens? -- Best regards Anatoly Lyutin.

1 0

WineHQ Downtime
by Jeremy Newman Sept. 13, 2007

Sept. 13, 2007

This is a reminder. WineHQ will be going offline for upgrades today at 14:00 CDT (19:00 GMT). I expect downtime to be no longer than one hour. Some services will appear to have sporadic outages even after the upgrade is complete. This will be due to changes in configs and upgraded versions of server software. I will post back to wine-devel when the upgrade is complete.

3 3

Re: WGL: Fix a major ATI regression
by Chris Robinson Sept. 12, 2007

Sept. 12, 2007

On Wednesday 12 September 2007 04:09:14 pm Roderick Colenbrander wrote: > + visinfo = pglXGetVisualFromFBConfig(display, cfgs[i]); > + /* We have found an offscreen rendering format when there is no > visualinfo :) */ > + if(visinfo->visualid == visualid) { > pglXGetFBConfigAttrib(display, cfgs[i], GLX_FBCONFIG_ID, > &fmt_id); > fbconfig = cfgs[i]; > } You're using visinfo before making sure it's valid. And I think that comment is a little misleading talking about offscreen formats when checking for the default visual. > + if(!visinfo) { > nOffscreenFormats++; > } > + XFree(visinfo); I don't think we can rely on being able to safely XFree a NULL pointer. None of the other code in opengl.c relies in that behavior.

1 0

Re: [3/5] WineD3D: Fix the reflection calculation in texm3x3(v)spec
by H. Verbeet Sept. 12, 2007

Sept. 12, 2007

On 12/09/2007, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > ...so what the patch *actually* does in a completely obfuscated way, is getting rid of the assumption that the normal is normalized. IOW, - shader_addline(buffer, "tmp0.xyz = reflect(-tmp1.xyz, tmp0.xyz);\n"); + shader_addline(buffer, "tmp0.xyz = reflect(-tmp1.xyz, normalize(tmp0.xyz));\n"); would be just as effective. That also means that the change in the ARB implementation - /* Calculate reflection vector (Assume normal is normalized): RF = 2*(N.E)*N -E */ + /* Calculate reflection vector (Assume normal is normalized): + * See comment in the glsl implementation. is misleading at best.

1 0

Re: problem with silly CreateBitmap call
by Francois Gouget Sept. 12, 2007

Sept. 12, 2007

On Thu, 6 Sep 2007, Deun wrote: [...] > The size of the bitmap seems crazy... So I've made a patch to > fix this in bitmap.c by setting 1x1 size in case of stupid > input instead of failing with BadAlloc. However, since it works > fine on real windows, so I'm not sure about the behaviour that > the function should have. Seems like a good candidate for a conformance test. Call the API with the crazy values and see what comes out... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

4 3

iTunes 7
by Juan Lang Sept. 12, 2007

Sept. 12, 2007

Folks, I just sent a series of wintrust patches that gets iTunes 7 to start, at least for me. I expect some will get rejected due to collision with Francois's patch - I'll resynch and resend. But if you want to play around with iTunes, grab those patches and give them a whirl. Known issues: 1. Your screen will go black when it starts. This is something QuickTime is doing. You can drag windows around to force some repainting to work around it. 2. You'll see lots of fixmes on the console, especially: "fixme:setupapi:CMP_WaitNoPendingInstallEvents 0", "fixme:setupapi:SetupDiGetClassDevsW returning empty list", and "fixme:htmlhelp:HtmlHelpW HH case HH_PRETRANSLATEMESSAGE not handled." 3. The main window will be transparent (and basically unusable) if you don't have GL support compiled in. Have fun, --Juan

4 5

Re: [PATCH] user32: edit control should respond to ctrl + z (try 3)
by Dmitry Timoshkov Sept. 12, 2007

Sept. 12, 2007

"Lei Zhang" <thestig(a)google.com> wrote: > This patch lets users hit ctrl + Z in edit controls to trigger an > undo. The test case has been improved to check for both the return > values and the content of the edit control. In the tests still there is no actual edit contents/selection changes tracking after every message. -- Dmitry.

2 6

Re: WineD3D: PBO support 2/2 (attempt 2)
by Alexandre Julliard Sept. 12, 2007

Sept. 12, 2007

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > This is an updated version of the patch. In the previous one I was > making a glBindBuffer call in a place without checking if PBOs were > around. Further the place didn't need the call anymore. This breaks the tests for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:2043: Test failed: quad 1 has color 0000ffff, expected 0x00FFFF00 visual.c:2045: Test failed: quad 2 has color 0000ffff, expected 0x0000000 visual.c:2047: Test failed: quad 3 has color 0000ffff, expected 0x0000FF00 make[2]: *** [visual.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by Jeremy Newman Sept. 11, 2007

Sept. 11, 2007

Is this the final version of this patch? Or shall I wait for an updated one from you? On Tue, 2007-09-11 at 11:31 -0700, Lei Zhang wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal.

1 0

Re: wordpad: #1 Store bar states in the registry
by Alexandre Julliard Sept. 11, 2007

Sept. 11, 2007

Alexander Nicolaysen Sørnes <alex(a)thehandofagony.com> writes: > wordpad: #1 Store bar states in the registry This doesn't work well when resizing the window, the toolbars get overwritten by the edit area. -- Alexandre Julliard julliard(a)winehq.org

2 7

Re: A fix for a problem with older games
by Stefan Dösinger Sept. 11, 2007

Sept. 11, 2007

Am Sonntag, 9. September 2007 17:10:39 schrieb Martin: That patch is not correct Are you sure that this patch really causes a problem? If you are running the game in winedbg and get an exception there it is a symptom of the DIB management in winex11.drv. You can just use "pass" to pass the exception up to the next handler(winex11.drv). The exception never reaches the app. If you really get a crash there then This->resource.allocatedMemory is pointing to a bad location, most likely NULL. This is a problem at some other place and should be fixed elsewhere. This read is a hack to work around a bug in the open source ati driver which caused a hard system crash if an exception occured during glDrawPixels. You can remove hack as a whole if it really causes problems, but this will cause hard crashes for a wide range of radeon drivers(xorg 6.8 and 7.0 at least). I think it is fixed in the latest version, but I am not sure, I'd have to test that. Since the hack is confined in one single function and doesn't have any side effects I decided to keep it.

1 0

Re: a ddraw patch
by Stefan Dösinger Sept. 11, 2007

Sept. 11, 2007

Am Sonntag, 9. September 2007 17:11:06 schrieb Martin: That patch will obviously break the game the dwTextureCaps modification was added originally... Can you check which cap that game needs that is removed in those lines?

1 0

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by James Hawkins Sept. 11, 2007

Sept. 11, 2007

On 9/11/07, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal. > <th>Blocker</th> - <td>Blocks development and/or testing work</td> + <td>When Wine won't start at all for any application, and there's no work + around</td> I think you've made this too specific, especially for Blocker. For example, in the new description you've left out compile errors, which is a big part of what blocker represents. The original description is fine for blocker. <th>Major</th> - <td>major loss of function</td> + <td>For a problem that is affecting most applications you run in Wine</td> + </tr> Why not something like, major loss of functionality for a wide range of applications instead of totally rewriting the definition. -- James Hawkins

3 3

Re: [bugzilla] replace generic severity descriptions with wine specific ones
by Jesse Allen Sept. 11, 2007

Sept. 11, 2007

On 9/11/07, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This is for bug 9110. Hopefully bug reporters will stop marking their > bugs as critical and then get upset when we set it to normal. > > > > > How about for minor you still keep "where an easy workaround is present". That differentiates it from normal. Jesse

1 0

Fifa 07 - wined3d regression
by Jan de Mooij Sept. 11, 2007

Sept. 11, 2007

Hi, Fifa 07 used to work fine with Wine, but around version 0.9.40-0.9.41 the game hangs when I start a new match. The text "Loading..." is displayed, but there is no progressbar because one thread terminates. I attached the results of winedbg (backtrace and some messages before the crash). This is the result of git bisect: 9ba3f389f665aae45b6a8a6861f9621b020e5c25 is first bad commit commit 9ba3f389f665aae45b6a8a6861f9621b020e5c25 Author: Stefan Dösinger <stefandoesinger(a)gmx.at> Date: Sun Jul 8 23:33:48 2007 +0200 wined3d: Initialize surfaces at creation. This patch removes a check of "GL_SUPPORT(APPLE_CLIENT_STORAGE)". If I put that check in again, the game works like before. The if-condition evaluates to True now, so it allocates the memory. But it segfaults there I think. Please let me know if you need more information. Thanks in advance! Jan de Mooij

2 2

AppDB entries
by speedator＠gmx.de Sept. 11, 2007

Sept. 11, 2007

Hi, sometimes app-entries (like Acrobat Reader) are for series of applications and versions for the single applications. Sometimes there are app-entries(like Age of Empires) for single applications in a series and version-entries for patches, betas, demos etc.. And sometimes it is a mixture. What about making this more clear? Do we need entries for the whole series? I think it is important for overview. So what about a new structure like "application / version / derived from version(subversion)"? Julian

3 2

lostwages CVS moved into GIT
by Jeremy Newman Sept. 11, 2007

Sept. 11, 2007

We have switched our website sources (previously known as lostwages), over to git. >From this point on I would prefer if all patches came from the git tree. Refer to the git documentation on the website and wiki on how to prepare patches with git. The git module is called simply "website".

1 0