January 2008 - Wine-Devel - list.winehq.org

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

today's valgrind results online
by Dan Kegel June 23, 2008

June 23, 2008

Online at http://kegel.com/wine/valgrind/20071002/ (I now include more info about memory leaks, but I still only report anything if there was an invalid memory reference.) The following tests were fixed in git yesterday, and no longer have any valgrind warnings: comctl32/rebar comctl32/status crypt32/chain crypt32/crl crypt32/msg cryptnet/cryptnet user32/msg wintrust/softpub Juan thinks nearly all of the remaining crypt32 errors can be suppressed (some are intentional). Here are the directories that still have warnings: advapi32 advpack cabinet comctl32 crypt32 d3d8 d3d9 d3dx8 dplayx dsound gdi32 gdiplus hlink kernel32 mlang msacm32 mscms mshtml msi msvcrt msxml3 netapi32 ntdll ole32 oleaut32 quartz riched20 riched32 rpcrt4 rsaenh setupapi shdocvw shell32 urlmon user32 usp10 wininet winmm wintrust - Dan

3 4

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.
by Robert Shearman June 17, 2008

June 17, 2008

Huang, Zhangrong wrote: > See dlls/ole32/compobj.c, > > static HRESULT apartment_getclassobject(struct apartment *apt, LPCWSTR dllpath, > BOOL apartment_threaded, > REFCLSID rclsid, REFIID riid, > void **ppv) > { > ................... > if (SUCCEEDED(hr)) > { > .................. > TRACE("calling DllGetClassObject %p\n", > apartment_loaded_dll->dll->DllGetClassObject); > /* OK: get the ClassObject */ > hr = apartment_loaded_dll->dll->DllGetClassObject(rclsid, riid, ppv); > ^^^^ > if (hr != S_OK) > ERR("DllGetClassObject returned error 0x%08x\n", hr); > } > .............. > } > > Reference to http://msdn2.microsoft.com/en-us/library/ms680760.aspx, > > riid > > [in] Reference to the identifier of the interface that the caller > is to use to communicate with the class object. Usually, this is > IID_IClassFactory (defined in the OLE headers as the interface > identifier for IClassFactory). > This doesn't mean anything other than CoCreateInstance is usually used instead of CoGetClassObject (and CoCreateInstance always passes in IID_IClassFactory for the IID). > We can't pass riid to DllGetClassObject directly sometimes, causes some dlls' > DllGetClassObject (like native adsldp.dll) can only return reference-counted > pointer to class factory via IID_IClassFactory, for retrieving the > pointer to the > class object interface requested in riid, we must try another way. > Thank you for your patch, but this behaviour seems a little strange and needs a little more investigation before I am happy that it is correct. What parameters are being passed in to CoGetClassObject to cause the call to fail for you? -- Rob Shearman

5 12

Re: hhctrl.ocx: Parse HTML entities in the table of contents.
by Alexandre Julliard April 15, 2008

April 15, 2008

Robert Shearman <rob(a)codeweavers.com> writes: > + p++; > + if ((*p == 'X') || (*p == 'x')) > + { > + /* hexadecimal entity */ > + while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') || > + (*p >= 'A' && *p <= 'F')) > + p++; > + ch = strtolW(start + 2, NULL, 16); > + } This is still broken. > + if (p - start - 1 <= sizeof(char_refs[0].name)) > + { > + for (i = 0; i < sizeof(char_refs)/sizeof(char_refs[0]); i++) > + if (!strncmpW(char_refs[i].name, start + 1, p - start - 1)) > + break; > + } This is still broken too. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: LoadStringW [1/2]
by Dmitry Timoshkov April 9, 2008

April 9, 2008

"Christopher" <raccoonone(a)procyongames.com> wrote: > +static void test_LoadStringW(void) > +{ > + HINSTANCE hInst = GetModuleHandle(NULL); > + WCHAR copiedstring[128], returnedstring[128], *resourcepointer = NULL; > + int strlen, strlen2; > + > + /* Check that the string which is returned by LoadStringW matches > + the string at the pointer returned by Load StringW when called with buflen = 0 */ > + strlen = LoadStringW(hInst, 2, (WCHAR *) &resourcepointer, 0); /* get pointer to resource. */ > + ok(strlen > 0, "LoadStringW failed to get pointer to resource 2, ret %d, err %d \n", strlen, GetLastError()); > + > + strlen2 = LoadStringW(hInst, 2, returnedstring, sizeof(returnedstring) /sizeof(WCHAR)); > + ok(strlen == strlen2, "LoadStringW returned different values dependent on buflen. ret1 %d, ret2 %d \n", > + strlen, strlen2); > + ok(strlen2 > 0, "LoadStringW failed to load resource 2, ret %d, err %d \n", strlen2, GetLastError()); > + > + if(resourcepointer != NULL) > + { > + memcpy(copiedstring, resourcepointer, strlen * sizeof(WCHAR)); > + copiedstring[strlen] = '\0'; > + } > + /* check that strings match */ > + ok(!memcmp(copiedstring, returnedstring, (strlen + 1)*sizeof(WCHAR)), > + "LoadStringW returned a string that does not match the string pointed to by the pointer it returned. \ > + returnedstring = %ls, copiedstring = %ls", returnedstring, copiedstring); > +} It's not clear what this test is supposed to show. If the 1st call to LoadStringW is supposed to set resourcepointer to not NULL, why don't you test it? Then 'if(resourcepointer != NULL)' check and copying to copiedstring are not needed. Also, if the test depends on a later patch to not fail, the test should be included in the patch. -- Dmitry.

4 15

"winefix" - interesting wrapper for wine
by Dan Kegel March 19, 2008

March 19, 2008

Tom W. found and publicized a script called "winefix" by an ubuntu forums user named "deadlydeathcone": http://digg.com/linux_unix/Winefix_improved_desktop_integration_for_Wine http://wine-review.blogspot.com/2007/10/winefix-improved-desktop-integratio… http://ubuntuforums.org/showthread.php?s=6e904c1df87d3fd1698ab5d7bbdbf664&t… It's got a bunch of interesting stuff. I wonder if we could get him to join wine-devel and start contributing to wine itself... - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 2

Re: user32: Test destroying the cursor of a parent process.
by Eric Pouech March 18, 2008

March 18, 2008

Andrew Riedi a écrit : > changelog: user32: Test destroying the cursor of a parent process. > > -- > Andrew Riedi > ------------------------------------------------------------------------ > > From 25a6a6a2eee92c4325d730ff85bd7cdf01bf2ace Mon Sep 17 00:00:00 2001 > From: Andrew Riedi <andrewriedi(a)gmail.com> > Date: Tue, 8 Jan 2008 05:03:55 -0800 > Subject: [PATCH] user32: Test destroying the cursor of a parent process. > > --- > dlls/user32/tests/cursoricon.c | 201 ++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 201 insertions(+), 0 deletions(-) > > diff --git a/dlls/user32/tests/cursoricon.c b/dlls/user32/tests/cursoricon.c > index 781282c..c2beffa 100644 > --- a/dlls/user32/tests/cursoricon.c > +++ b/dlls/user32/tests/cursoricon.c > @@ -32,6 +32,205 @@ > #include "wingdi.h" > #include "winuser.h" > > +static char **test_argv; > +static int test_argc; > +static HWND child = 0; > +static HWND parent = 0; > +static HANDLE child_process; > + > +#define PROC_INIT (WM_USER+1) > + > +LRESULT CALLBACK callback_child(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + BOOL ret; > + DWORD error; > + > + switch (msg) > + { > + /* Destroy the cursor. */ > + case WM_USER+1: > + SetLastError(0xdeadbeef); > + ret = DestroyCursor((HCURSOR) lParam); > + error = GetLastError(); > + todo_wine { > + ok(!ret, "DestroyCursor on the active cursor succeeded.\n"); > + ok(error == ERROR_DESTROY_OBJECT_OF_OTHER_THREAD, > + "Last error: 0x%08x\n", error); > + } > + return TRUE; > + case WM_DESTROY: > + PostQuitMessage(0); > + return 0; > + } > + > + return DefWindowProc(hwnd, msg, wParam, lParam); > +} > + > +LRESULT CALLBACK callback_parent(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > +{ > + if (msg == PROC_INIT) > + { > + child = (HWND) wParam; > + return TRUE; > + } > + > + return DefWindowProc(hwnd, msg, wParam, lParam); > +} > + > +static void do_child(void) > +{ > + WNDCLASS class; > + MSG msg; > + BOOL ret; > + > + /* Register a new class. */ > + class.style = CS_GLOBALCLASS; > + class.lpfnWndProc = callback_child; > + class.cbClsExtra = 0; > + class.cbWndExtra = 0; > + class.hInstance = GetModuleHandle(NULL); > + class.hIcon = NULL; > + class.hCursor = NULL; > + class.hbrBackground = NULL; > + class.lpszMenuName = NULL; > + class.lpszClassName = "cursor_child"; > + > + SetLastError(0xdeadbeef); > + ret = RegisterClass(&class); > + ok(ret, "Failed to register window class. Error: %d\n", GetLastError()); > + > + /* Create a window. */ > + child = CreateWindowA("cursor_child", "cursor_child", WS_POPUP | WS_VISIBLE, > + 0, 0, 200, 200, 0, 0, 0, NULL); > + ok(child != 0, "CreateWindowA error %d\n", GetLastError()); > + > + /* Let the parent know our HWND. */ > + PostMessage(parent, PROC_INIT, (WPARAM) child, 0); > + > + /* Receive messages. */ > + while ((ret = GetMessage(&msg, child, 0, 0))) > + { > + ok(ret != -1, "GetMessage failed. Error: %d\n", GetLastError()); > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > +} > + > +static void do_parent(void) > +{ > + char path_name[MAX_PATH]; > + PROCESS_INFORMATION info; > + STARTUPINFOA startup; > + WNDCLASS class; > + MSG msg; > + BOOL ret; > + > + /* Register a new class. */ > + class.style = CS_GLOBALCLASS; > + class.lpfnWndProc = callback_parent; > + class.cbClsExtra = 0; > + class.cbWndExtra = 0; > + class.hInstance = GetModuleHandle(NULL); > + class.hIcon = NULL; > + class.hCursor = NULL; > + class.hbrBackground = NULL; > + class.lpszMenuName = NULL; > + class.lpszClassName = "cursor_parent"; > + > + SetLastError(0xdeadbeef); > + ret = RegisterClass(&class); > + ok(ret, "Failed to register window class. Error: %d\n", GetLastError()); > + > + /* Create a window. */ > + parent = CreateWindowA("cursor_parent", "cursor_parent", WS_POPUP | WS_VISIBLE, > + 0, 0, 200, 200, 0, 0, 0, NULL); > + ok(parent != 0, "CreateWindowA error %d\n", GetLastError()); > + > + /* Start child process. */ > + memset(&startup, 0, sizeof(startup)); > + startup.cb = sizeof(startup); > + startup.dwFlags = STARTF_USESHOWWINDOW; > + startup.wShowWindow = SW_SHOWNORMAL; > + > + sprintf(path_name, "%s cursoricon %x", test_argv[0], (unsigned int) parent); > + ok(CreateProcessA(NULL, path_name, NULL, NULL, FALSE, 0L, NULL, NULL, &startup, &info), "CreateProcess failed.\n"); > + child_process = info.hProcess; > + > + /* Wait for child window handle. */ > + while ((child == 0) && (ret = GetMessage(&msg, parent, 0, 0))) > + { > + ok(ret != -1, "GetMessage failed. Error: %d\n", GetLastError()); > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + } > +} > + > +static void init(void) > +{ > + test_argc = winetest_get_mainargs(&test_argv); > + > + /* Child process. */ > + if (test_argc >= 3) > + { > + sscanf (test_argv[2], "%x", (unsigned int *) &parent); > + > + ok(parent != NULL, "Parent not found.\n"); > + if (parent == NULL) > + exit(1); > + > + do_child(); > + exit(0); > + } > + else > + { > + do_parent(); > + } > +} > + > +static void finish_process(void) > +{ > + DWORD exit_code; > + BOOL ret; > + > + SendMessage(child, WM_CLOSE, 0, 0); > + ok(WaitForSingleObject(child_process, 30000) == WAIT_OBJECT_0, "Child process termination failed.\n"); > + > + ret = GetExitCodeProcess(child_process, &exit_code); > + ok(ret, "GetExitCodeProcess() failed. Error: 0x%08x\n", GetLastError()); > + ok(exit_code == 0, "Exit code == %d.\n", exit_code); > +} > + > +static void test_child_process(void) > +{ > + static const BYTE bmp_bits[4096]; > + HCURSOR cursor; > + ICONINFO cursorInfo; > + UINT display_bpp; > + HDC hdc; > + > + /* Create and set a dummy cursor. */ > + hdc = GetDC(0); > + display_bpp = GetDeviceCaps(hdc, BITSPIXEL); > + ReleaseDC(0, hdc); > + > + cursorInfo.fIcon = FALSE; > + cursorInfo.xHotspot = 0; > + cursorInfo.yHotspot = 0; > + cursorInfo.hbmMask = CreateBitmap(32, 32, 1, 1, bmp_bits); > + cursorInfo.hbmColor = CreateBitmap(32, 32, 1, display_bpp, bmp_bits); > + > + cursor = CreateIconIndirect(&cursorInfo); > + ok(cursor != NULL, "CreateIconIndirect returned %p.\n", cursor); > + > + SetCursor(cursor); > + > + /* Destroy the cursor. */ > + SendMessage(child, WM_USER+1, (WPARAM) parent, (LPARAM) cursor); > + > + /* Finish the child process. */ > + finish_process(); > +} > + > static void test_CopyImage_Check(HBITMAP bitmap, UINT flags, INT copyWidth, INT copyHeight, > INT expectedWidth, INT expectedHeight, WORD expectedDepth, BOOL dibExpected) > { > @@ -471,6 +670,7 @@ static void test_DestroyCursor(void) > > START_TEST(cursoricon) > { > + init(); > test_CopyImage_Bitmap(1); > test_CopyImage_Bitmap(4); > test_CopyImage_Bitmap(8); > @@ -480,4 +680,5 @@ START_TEST(cursoricon) > test_initial_cursor(); > test_CreateIcon(); > test_DestroyCursor(); > + test_child_process(); > } > > ------------------------------------------------------------------------ > > > IMO, the ok() tests in the child process are a bad idea (they won't be counted, nor returned as errors, by the parent process) all the tests should be done in parent, see kernel32/tests/process.c for some example on how to do it properly A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams)

3 2

Re: dlls/user32/edit.c -- remove superflous check (RESEND)
by Alexandre Julliard Feb. 19, 2008

Feb. 19, 2008

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > dwBufLen already indictes that this variable is of type DWORD and > thus always positive. I also looked at the implementation of > ImmGetCompositionStringW() and we do not seem to return a negative > value (such as -1). Maybe the implementation doesn't, but the function returns a LONG, and can (and probably should) return negative values on error. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: dlls/msi/streams.c -- simplify and constify
by James Hawkins Feb. 17, 2008

Feb. 17, 2008

On Nov 3, 2007 1:10 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > While removing the dead code I noticed that we can actually also > strengthen the const-ness of this function. > > Gerald > > ChangeLog: > Remove a check which never could trigger (due to the domain of the > variable in question) and increase const-ness of STREAMS_CreateView(). > > Index: dlls/msi/streams.c > =================================================================== > RCS file: /home/wine/wine/dlls/msi/streams.c,v > retrieving revision 1.7 > diff -u -3 -p -r1.7 streams.c > --- dlls/msi/streams.c 18 Oct 2007 13:00:57 -0000 1.7 > +++ dlls/msi/streams.c 3 Nov 2007 18:06:27 -0000 > @@ -430,7 +430,7 @@ static UINT add_streams_to_table(MSISTRE > return count; > } > > -UINT STREAMS_CreateView(MSIDATABASE *db, MSIVIEW **view) > +UINT STREAMS_CreateView(const MSIDATABASE *db, MSIVIEW **view) > { > MSISTREAMSVIEW *sv; > > @@ -444,9 +444,6 @@ UINT STREAMS_CreateView(MSIDATABASE *db, > sv->db = db; > sv->num_rows = add_streams_to_table(sv); > > - if (sv->num_rows < 0) > - return ERROR_FUNCTION_FAILED; > - > *view = (MSIVIEW *)sv; > > return ERROR_SUCCESS; > This change is wrong. If you'd actually read what the code intended to do instead of just fixing warnings, you'd see that add_streams_to_table returns -1 on error. While the check for < 0 is not correct, removing the check entirely is wrong. The check should be if (sv->num_rows == -1) return ERROR_FUNCTION_FAILED. -- James Hawkins

2 2

Bugzilla: Remove obsolete components
by Austin English Feb. 9, 2008

Feb. 9, 2008

Howdy, I just finished moving over the last of the obsolete components. _obsolete_binary, _obsolete_directx, and _obsolete_gui can all be removed now. -Austin

3 2

Re: RegOverridePredefKey stub
by Dmitry Timoshkov Feb. 6, 2008

Feb. 6, 2008

"Jens Nestler" <nessi(a)nessi-online.de> wrote: > diff -urN wine-0.9.54_org/include/winreg.h wine-0.9.54/include/winreg.h > --- wine-0.9.54_org/include/winreg.h 2008-01-25 17:05:38.000000000 +0100 > +++ wine-0.9.54/include/winreg.h 2008-01-28 22:07:55.000000000 +0100 > @@ -131,6 +131,7 @@ > WINADVAPI LSTATUS WINAPI RegLoadKeyA(HKEY,LPCSTR,LPCSTR); > WINADVAPI LSTATUS WINAPI RegLoadKeyW(HKEY,LPCWSTR,LPCWSTR); > #define RegLoadKey WINELIB_NAME_AW(RegLoadKey) > +WINADVAPI LSTATUS WINAPI RegOverridePredefKey(HKEY,HKEY); > WINADVAPI LSTATUS WINAPI RegLoadMUIStringA(HKEY,LPCSTR,LPSTR,DWORD,LPDWORD,DWORD,LPCSTR); > WINADVAPI LSTATUS WINAPI RegLoadMUIStringW(HKEY,LPCWSTR,LPWSTR,DWORD,LPDWORD,DWORD,LPCWSTR); > #define RegLoadMUIString WINELIB_NAME_AW(RegLoadMUIString) Isn't there something that suggests that the entries are alphabetically sorted? -- Dmitry.

2 4

re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING
by Dan Kegel Feb. 5, 2008

Feb. 5, 2008

James McKenzie wrote: > Please submit a git diff not a UNIX diff. Now, hang on there. Jens submitted a perfectly good unified diff patch taken from the right directory. There is no reason to turn up our noses at it. It will apply using patch in exactly the same way as a diff generated by git. Jens, you're fine, I wouldn't bother rediffing. You might however resend your patch next week when Alexandre the maintainer is back from vacation! - Dan

2 1

comctl32 failures on Win95, Win98, NT4 asnd Win2K
by Reece Dunn Feb. 5, 2008

Feb. 5, 2008

These tests are all failing consistently with identical failures on these platforms: combobox - 21 failures; all identical across the platforms. datetime - 2 failures; all identical across the platforms. The rebar tests have 146 failures on some (Win95 and NT4) and 545 failures on others (Win98 and Win2K). This looks like it is due to a different comctl32 version as a result of a different IE version. Several of the others have failures on Win95 and Win98 only. Is anyone going to look at these? - Reece

3 2

What's needed to make gdb work again?
by Maarten Lankhorst Feb. 1, 2008

Feb. 1, 2008

Hi folks, I've been trying some debugging with kdbg (Graphical kde debugger), but it fails on wine because it can't attach to a process. While it is of course possible to use WINEDEBUG flags, I want to be able to use a full debugger, and not just deduce from logs what happened, but rather be able to see the corresponding lines of source as well. so would it be possible to make gdb work with winedbg again, and perhaps make it understand threads this time? Cheers, Maarten.

2 1

test.winehq.org
by Stefan Leichter Feb. 1, 2008

Feb. 1, 2008

Hello, i just noticed that the test results for advapi32:service tests are not available for the last build (http://test.winehq.org/data/200801301937/) It looks like the parser did not create the files. Can someone familar with this stuff have a look? Thanks Stefan

4 4

Review comparing Wine and Vista for running games
by Dan Kegel Feb. 1, 2008

Feb. 1, 2008

http://wastingtimewithmikeandari.wordpress.com/2008/01/31/linux-has-better-… It'd be nice if we ran those games properly, but still, at least we didn't lock the system.

3 2

Re: qmgr: Implement DLL server registration.
by Roderick Colenbrander Jan. 31, 2008

Jan. 31, 2008

If possible you should do the registration in the same way as windows as we try to be like windows in every way. Depending on the dll the settings are either hardcoded in a dll (that's what most dlls do) or when it are default windows dlls the keys are stored in wine.inf. In case of your dll I guess it should be hardcoded. Shipping extra files puts an extra burden on packagers and it likely isn't what windows is doing. Regards, Roderick > I like the way Roy used a .INF file for the DLL server registration. > Looking > at some of the other DLL's code, this seems comparably like a very clean > idea. > > ChangeLog: > > Add the server registration code to qmgr. > > From: Roy Shea <roy at cs.hmc.edu> > Date: Thu Dec 20 18:38:31 CST 2007 > > --- > dlls/qmgr/Makefile.in | 4 ++- > dlls/qmgr/qmgr.h | 11 ++++++ > dlls/qmgr/qmgr.inf | 31 ++++++++++++++++ > dlls/qmgr/qmgr.spec | 4 +- > dlls/qmgr/qmgr_main.c | 92 > +++++++++++++++++++++++++++++++++++++++++++++++-- > dlls/qmgr/rsrc.rc | 20 +++++++++++ > 6 files changed, 156 insertions(+), 6 deletions(-) > create mode 100644 dlls/qmgr/qmgr.inf > create mode 100644 dlls/qmgr/rsrc.rc > > diff --git a/dlls/qmgr/Makefile.in b/dlls/qmgr/Makefile.in > index a19eea6..7159607 100644 > --- a/dlls/qmgr/Makefile.in > +++ b/dlls/qmgr/Makefile.in > @@ -3,7 +3,7 @@ TOPOBJDIR = ../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = qmgr.dll > -IMPORTS = kernel32 > +IMPORTS = advpack kernel32 > EXTRALIBS = -luuid > > C_SRCS = \ > @@ -11,6 +11,8 @@ C_SRCS = \ > qmgr.c \ > qmgr_main.c > > +RC_SRCS = rsrc.rc > + > IDL_I_SRCS = qmgr_local.idl > > @MAKE_DLL_RULES@ > diff --git a/dlls/qmgr/qmgr.h b/dlls/qmgr/qmgr.h > index 9b708c8..3ad314d 100644 > --- a/dlls/qmgr/qmgr.h > +++ b/dlls/qmgr/qmgr.h > @@ -27,6 +27,8 @@ > #define COBJMACROS > #include "bits.h" > > +#include <string.h> > + > /* Background copy manager vtbl and related data */ > typedef struct > { > @@ -43,4 +45,13 @@ extern ClassFactoryImpl BITS_ClassFactory; > > HRESULT BackgroundCopyManagerConstructor(IUnknown *pUnkOuter, LPVOID > *ppObj); > > +/* Little helper functions */ > +static inline char * > +qmgr_strdup(const char *s) > +{ > + size_t n = strlen(s) + 1; > + char *d = HeapAlloc(GetProcessHeap(), 0, n); > + return d ? memcpy(d, s, n) : NULL; > +} > + > #endif /* __QMGR_H__ */ > diff --git a/dlls/qmgr/qmgr.inf b/dlls/qmgr/qmgr.inf > new file mode 100644 > index 0000000..0550f01 > --- /dev/null > +++ b/dlls/qmgr/qmgr.inf > @@ -0,0 +1,31 @@ > +[version] > +Signature="$CHICAGO$" > + > + > +[Strings] > +Services="System\CurrentControlSet\Services" > + > + > +[RegisterDll] > +AddReg = Qmgr.Reg > + > + > +[UnregisterDll] > +DelReg = Qmgr.Reg > + > + > +[Qmgr.Reg] > + > +HKCR,"AppID\BITS","AppID",,"%CLSID_BackgroundCopyQMgr%" > +HKCR,"AppID\%CLSID_BackgroundCopyQMgr%","LocalService",,"BITS" > +HKCR,"CLSID\%CLSID_BackgroundCopyManager%","AppID",,"%CLSID_BackgroundCopyQMgr%" > + > +HKLM,"Software\Microsoft\Windows > NT\CurrentVersion\SvcHost","netsvcs",0x00010000,"BITS" > + > +HKLM,"%Services%\BITS","Type",0x00010001,00000110 > +HKLM,"%Services%\BITS","Start",0x00010001,00000003 > +HKLM,"%Services%\BITS","ErrorControl",0x00010001,00000001 > +HKLM,"%Services%\BITS","Description",,"BITS Service" > +HKLM,"%Services%\BITS","DispalyName",,"BITS" > +HKLM,"%Services%\BITS","ImagePath",0x00020000,"svchost.exe -k netsvcs" > +HKLM,"%Services%\BITS\Parameters","ServiceDll",0x00020000,"qmgr.dll" > diff --git a/dlls/qmgr/qmgr.spec b/dlls/qmgr/qmgr.spec > index 1a63b32..0f9b073 100644 > --- a/dlls/qmgr/qmgr.spec > +++ b/dlls/qmgr/qmgr.spec > @@ -1,2 +1,2 @@ > -@ stub DllRegisterServer > -@ stub DllUnregisterServer > +@ stdcall -private DllRegisterServer() > +@ stdcall -private DllUnregisterServer() > diff --git a/dlls/qmgr/qmgr_main.c b/dlls/qmgr/qmgr_main.c > index d00ac2d..2bb5258 100644 > --- a/dlls/qmgr/qmgr_main.c > +++ b/dlls/qmgr/qmgr_main.c > @@ -21,15 +21,27 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > */ > > -#include <stdarg.h> > +#include <stdio.h> > > -#include "windef.h" > -#include "winbase.h" > +#include "objbase.h" > +#include "winuser.h" > +#include "winreg.h" > +#include "advpub.h" > + > +#include "bits.h" > +#include "qmgr.h" > +#include "initguid.h" > > #include "wine/debug.h" > > WINE_DEFAULT_DEBUG_CHANNEL(qmgr); > > +/* Handle to the base address of this DLL */ > +static HINSTANCE hInst; > + > +/* Other GUIDs used by this module */ > +DEFINE_GUID(CLSID_BackgroundCopyQMgr, 0x69AD4AEE, 0x51BE, 0x439b, > 0xA9,0x2C, 0x86,0xAE,0x49,0x0E,0x8B,0x30); > + > /* Entry point for DLL */ > BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, LPVOID > lpvReserved) > { > @@ -41,6 +53,7 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD fdwReason, > LPVOID lpvReserved) > return FALSE; /* prefer native version */ > case DLL_PROCESS_ATTACH: > DisableThreadLibraryCalls(hinstDLL); > + hInst = hinstDLL; > break; > case DLL_PROCESS_DETACH: > break; > @@ -48,3 +61,76 @@ BOOL WINAPI DllMain(HINSTANCE hinstDLL, DWORD > fdwReason, LPVOID lpvReserved) > > return TRUE; > } > + > +static HRESULT init_register_strtable(STRTABLEA *strtable) > +{ > + #define CLSID_EXPANSION_ENTRY(id) { "CLSID_" #id, &CLSID_ ## id } > + static const struct { > + const char *name; > + const CLSID *clsid; > + } expns[] = { > + CLSID_EXPANSION_ENTRY(BackgroundCopyQMgr), > + CLSID_EXPANSION_ENTRY(BackgroundCopyManager) > + }; > + #undef CLSID_EXPANSION_ENTRY > + static STRENTRYA pse[sizeof expns / sizeof expns[0]]; > + int i; > + > + strtable->cEntries = sizeof pse / sizeof pse[0]; > + strtable->pse = pse; > + for (i = 0; i < strtable->cEntries; i++) { > + static const char dummy_sample[] = > "{12345678-1234-1234-1234-123456789012}"; > + const CLSID *clsid = expns[i].clsid; > + pse[i].pszName = qmgr_strdup(expns[i].name); > + pse[i].pszValue = HeapAlloc(GetProcessHeap(), 0, sizeof > dummy_sample); > + if (!pse[i].pszName || !pse[i].pszValue) > + return E_OUTOFMEMORY; > + sprintf(pse[i].pszValue, > "{%08X-%04X-%04X-%02X%02X-%02X%02X%02X%02X%02X%02X}", > + clsid->Data1, clsid->Data2, clsid->Data3, > clsid->Data4[0], > + clsid->Data4[1], clsid->Data4[2], clsid->Data4[3], > clsid->Data4[4], > + clsid->Data4[5], clsid->Data4[6], clsid->Data4[7]); > + } > + > + return S_OK; > +} > + > +static void cleanup_register_strtable(STRTABLEA *strtable) > +{ > + int i; > + for (i = 0; i < strtable->cEntries; i++) { > + HeapFree(GetProcessHeap(), 0, strtable->pse[i].pszName); > + HeapFree(GetProcessHeap(), 0, strtable->pse[i].pszValue); > + if (!strtable->pse[i].pszName || !strtable->pse[i].pszValue) > + return; > + } > +} > + > +/* Use an INF file to register or unregister the DLL */ > +static HRESULT register_server(BOOL do_register) > +{ > + HRESULT hr; > + STRTABLEA strtable; > + > + TRACE("(%x)\n", do_register); > + > + hr = init_register_strtable(&strtable); > + if (SUCCEEDED(hr)) > + hr = RegInstallA(hInst, do_register ? "RegisterDll" : > "UnregisterDll", > + &strtable); > + cleanup_register_strtable(&strtable); > + > + if (FAILED(hr)) > + ERR("failed: %08x\n", hr); > + > + return hr; > +} > + > +HRESULT WINAPI DllRegisterServer() > +{ > + return register_server(TRUE); > +} > + > +HRESULT WINAPI DllUnregisterServer() > +{ > + return register_server(FALSE); > +} > diff --git a/dlls/qmgr/rsrc.rc b/dlls/qmgr/rsrc.rc > new file mode 100644 > index 0000000..dfc64d0 > --- /dev/null > +++ b/dlls/qmgr/rsrc.rc > @@ -0,0 +1,20 @@ > +/* > + * Copyright 2007 Google (Roy Shea) > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, > USA > + */ > + > +/* @makedep: qmgr.inf */ > +REGINST REGINST qmgr.inf > -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

2 1

Is http://test.winehq.org down?
by Reece Dunn Jan. 31, 2008

Jan. 31, 2008

Hi, I an getting a network timeout whern connecting to http://test.winehq.org. - Reece

1 1

No new winetest?
by Francois Gouget Jan. 31, 2008

Jan. 31, 2008

There's been no new winetest for about a week. Does anyone know what's up? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

3 4

Wiki Down?
by Austin English Jan. 31, 2008

Jan. 31, 2008

What happened to the wiki? AppDB/WineHQ/Bugzilla are all fine, but wiki.winehq.org seems to be down. -Austin

4 4

windows xp x64
by EA Durbin Jan. 31, 2008

Jan. 31, 2008

I'm trying to install a game (Zoo Tycoon2) for my little sisters on my Dad's PC, it's running Windows XP pro x64 edition, which gets recognized as Windows Server 2003. The install is complaining about needing Windows XP to install the game and VMWare only has 16mb of video card emulated. Can I run it in wine on Windows, or is there a cool way to spoof my Windows version under Windows? _________________________________________________________________ Helping your favorite cause is as easy as instant messaging. You IM, we give. http://im.live.com/Messenger/IM/Home/?source=text_hotmail_join

1 1

[Fwd: [PATCH] This is an update to riched20 to incorporate EM_FONTRANGE based upon 0.9.54.]
by James McKenzie Jan. 31, 2008

Jan. 31, 2008

Please delete this patch. It is incomplete and I will submit a new one. -------- Original Message -------- Subject: [PATCH] This is an update to riched20 to incorporate EM_FONTRANGE based upon 0.9.54. Date: Mon, 28 Jan 2008 22:17:39 -0700 From: James McKenzie <jjmckenzie51(a)earthlink.net> To: wine-patches(a)winehq.org --- dlls/riched20/context.c | 16 ++ dlls/riched20/editor.c | 9 + dlls/riched20/editor.h | 12 ++ dlls/riched20/list.c | 153 +++++++++++++++++++++ dlls/riched20/paint.c | 312 +++++++++++++++++++++++++++++++++++++++++- dlls/riched20/run.c | 33 ++++ dlls/riched20/style.c | 113 +++++++++++---- dlls/riched20/tests/editor.c | 16 +- dlls/riched20/wrap.c | 23 +++ 9 files changed, 627 insertions(+), 60 deletions(-) This is based upon Lei Zhang's November patch.

1 0

Re: commdlg: PrintDlg16: Handle print quality combobox (try2)
by Detlef Riekenberg Jan. 31, 2008

Jan. 31, 2008

On Mi, 2008-01-30 at 13:48 +0100, Alexander Nicolaysen Sørnes wrote: > + printf("CCC %d\n", lpdm->u1.s1.dmPrintQuality); This looks like debug code -- By by ... Detlef

2 1