January 2008 - Wine-Devel - list.winehq.org

Re: French LTEXT correction
by Jonathan Ernst Jan. 4, 2008

Jan. 4, 2008

On ven, 2008-01-04 at 11:24 +0100, Vincent Hardy wrote: > Regedit displays "Rechercher::". Now Regedit displays "Rechercher :" and > so on... It doesn't here (?). Furthermore in French ":" should be preceded by an unbreakable space (like it's the case now) and not a normal space.

1 0

xrandx responds with too many modes.
by Peter Dons Tychsen Jan. 4, 2008

Jan. 4, 2008

The xrandx X11 extension is very handy. Using it for wine makes great sense. But... the extension also enumerates a whopping amount of modes. Each resolution has a multitude of frequencies and bit-depth variants. Some applications are simply not prepared for that magnitude of information when they call EnumDisplaySettings() (user32) or EnumDisplayModes (ddraw). When using "normal" windows, only a few modes are returned. I know its not a bug, as it could happen on Windows if someone published a driver which implemented tons of silly and crooked modes. Would it be acceptable to insert a filter in xrandx.c (X11-drv), which only allowed "normal" windows resolutions to be enumerated? Does anyone need those awkward ones? The filter would look allot like the one in desktop.c (X11-drv) which is currently used by the desktop mode. I already fixed a portion of the bugs caused by this, as there was a natural limitation which should be set by EnumDisplayModes() which was not honored. I sent in patch for this already. So at least now we can play the classic "Grand Theft Auto".... Thanks, /p

3 2

d3dx implementation senseless?
by tony.wasserka＠freenet.de Jan. 4, 2008

Jan. 4, 2008

Hi, I enjoyed the current wine development of the D3DX libraries and also tried to implement an interface. However, while testing it I noticed that Wine seems to fully support everything when it has a native d3dx9.dll (though it even was able to run one of my games without any dll...). So I was asking myself if there's even a reason to implement anything other than the inlined functions of D3DX, when we only lose performance and development time with it. Also, what would we do at functions like D3DXCreateTextureFromFile which supports 9 file formats? Would we implement e.g. a BMP file loader ourselves or would we use a 3rd party library for that? Are there any patents regarding the DX specific file formats (.x/.dds)? Don't misunderstand me, I'd also like to help out at D3DX, but I really think we'd be better off by removing everything of D3DX but the inlined stuff. Best regards, Tony Wasserka (PS: if one argues that we need the implementation for WineLib, I _think_ it'd be enough to just stub all functions so that the program compiles fine and then use the native dll again)

2 1

Re: mshtml #4: Includes clean up. (fixed)
by Alexandre Julliard Jan. 4, 2008

Jan. 4, 2008

Jacek Caban <jacek(a)codeweavers.com> writes: > diff --git a/dlls/mshtml/install.c b/dlls/mshtml/install.c > index 731af60..2437797 100644 > --- a/dlls/mshtml/install.c > +++ b/dlls/mshtml/install.c > @@ -18,33 +18,23 @@ > > #include "config.h" > > -#include <stdarg.h> > +#include "mshtml_private.h" > +#include "resource.h" > + > #include <fcntl.h> > #ifdef HAVE_UNISTD_H > # include <unistd.h> > #endif It's not a good idea to include Unix headers after the Windows ones, that can create trouble. I have to admit I'm not a big fan of that sort of one include to rule them all approach, I think it's better to have each file maintain control over what it includes and in which order. The global mshtml_private.h header should only include the stuff it itself depends on, not every single header that any source file may want to use. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] ddraw: Return a nullpointer as lpSurface in Lock() if the rect is invalid.
by H. Verbeet Jan. 4, 2008

Jan. 4, 2008

On 03/01/2008, Günther Brammer <GBrammer(a)gmx.de> wrote: > + ok(!locked_desc.lpSurface, "IDirectDrawSurface_Lock did not set lpSurface in the surface desc\n"); > That isn't the clearest message. It should probably say it didn't set lpSurface to NULL.

1 0

USER32 - SPI_GETMOUSE missing a default value.
by Peter Dons Tychsen Jan. 4, 2008

Jan. 4, 2008

I have an app which is bailing out because it cannot get valid data from SPI_GETMOUSE - and indeed this reg key does not exist. The key should be in "Control Panel\\Colors" under CURRENT_USER. There are similar values in the "Control Panel" folder in the registry. Is there a reason this value is not initialized ? If i want to fix it, then: 1) Where is the best place to initialize values like these? I presume its during boot, where the mouse values should be read? 2) Should i get the mouse data from X11 or just simulate something? /p

2 1

Local file in Web Browser doesnt load
by Alistair Leslie-Hughes Jan. 4, 2008

Jan. 4, 2008

Hi, An application that I'm using contains a internal web browser based off the IWebBrowser2 interface. Loading a webpage from a web server works as expected, but when I try to use the "file://C:\myTestPage.html" syntax the file fails to load. NOTE: myTestPage.html has a single paragraph with one line of text Are local files supported in the web browser? Do I need to call a function besides Naviagate2() to load the file? Best Regards Alistair Leslie-Hughes

1 0

re: Bow and question
by Dan Kegel Jan. 3, 2008

Jan. 3, 2008

Juan wrote: > I want know where can i find the option to WINEDEBUG. > In this time, we are used trace+file, trace+reg. > Can trace the sockets?? When I need to figure out WINEDEBUG flags, I always use grep, e.g. dank(a)lappy:~/wine-git/dlls$ grep DEFAULT_DEBUG ws*/*.c ws2_32/async.c:WINE_DEFAULT_DEBUG_CHANNEL(winsock); ws2_32/protocol.c:WINE_DEFAULT_DEBUG_CHANNEL(winsock); ws2_32/socket16.c:WINE_DEFAULT_DEBUG_CHANNEL(winsock); ws2_32/socket.c:WINE_DEFAULT_DEBUG_CHANNEL(winsock); wsock32/service.c:WINE_DEFAULT_DEBUG_CHANNEL(winsock); wsock32/socket.c:WINE_DEFAULT_DEBUG_CHANNEL(winsock); So yes, try +winsock. So how well is Wine running the malware you're interested in? - Dan

2 2

Another Shader/Offscreenrender problem
by László Tari Jan. 3, 2008

Jan. 3, 2008

Tomb Raider Anniversary/Need 4 Speed Carbon When these fog-thing appear n the game, the frame rate suddenly decreased. (Depth of Field is on) __________________________________________________________ Sent from Yahoo! Mail - a smarter inbox http://uk.mail.yahoo.com

1 0

missed patches
by Kirill K. Smirnov Jan. 3, 2008

Jan. 3, 2008

Hi, Is there something wrong with these couple of patches? http://www.winehq.org/pipermail/wine-patches/2007-December/048436.html kernel32/console: convert newborn wineserver handle to kernel32 console handle. This patch makes screenbuffer handle, returned by CreateConsoleScreenBuffer function, be a really "console" handle (h&3 == 3). Fixes behaviour of WriteFile function called upon this handle. and http://www.winehq.org/pipermail/wine-patches/2007-December/048291.html tools/wineshelllink: do not execute applications directly, use 'start' utility instead This patch allows to create correct desktop/menu shortcuts for console applications (e.g. Far Manager). I've caught on the idea suggested by Vitaliy (If console needs to be created for those apps and there isn't one, then Wine should do it when starting an app.), but I cannot understand how to check it - dumb console always present (even redirected to /dev/null): http://www.winehq.org/pipermail/wine-devel/2007-December/061399.html If I missed something important just let me know. Thanks, -- Kirill

1 0

Re: [5/5] wined3d: change colorkey fixup for stage 0 alphaop / alphaarg
by Stefan Dösinger Jan. 3, 2008

Jan. 3, 2008

Am Mittwoch, 2. Januar 2008 13:38:57 schrieb Alexander Dorofeyev: > In case of colorkey emulation for a texture, if the application wants to > select alpha from diffuse color at stage 0, a fixup to modulate with > texture alpha more closely matches what the application wants than fixup to > just select alpha from texture. I am not sure about this. From my understanding of color keying, the color keying should only depend on the texture, not the diffuse color. Unfortunately, this is mutually exclusive with always honoring the app's blending settings. I have two games which use color keying, Moto Racer 2 and Prince of Persia 3D. I'll test the patches with those two games. The problem is that our color keying is emulated, so we'll always have to fiddle to get it working properly everywhere. The correct, but complex and incomplete fix would be a replacement shader for the fixed function pipeline which can implement color keying properly using 'KIL' or 'discard'. Unfortunately that won't fix the problem for cards without fragment shader support. The other patches look good to me

3 3

Re: mshtml #1: Includes clean up. (resend)
by Alexandre Julliard Jan. 3, 2008

Jan. 3, 2008

Jacek Caban <jacek(a)codeweavers.com> writes: > diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h > index c981348..e0c94c3 100644 > --- a/dlls/mshtml/mshtml_private.h > +++ b/dlls/mshtml/mshtml_private.h > @@ -16,6 +16,19 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > +#include "config.h" > + > +#include <stdarg.h> > +#include <stdio.h> You can't use config.h from a header file. -- Alexandre Julliard julliard(a)winehq.org

1 0

So, you want to fix typos?
by Dan Kegel Jan. 3, 2008

Jan. 3, 2008

I see somebody's posting a few fix-typo-in-comments patches, e.g. http://www.winehq.org/pipermail/wine-patches/2007-December/048099.html http://www.winehq.org/pipermail/wine-patches/2007-December/048101.html That reminds me that I worked out some time ago how to find such typos efficiently. At the risk of encouraging lots of silly typo-fixing patches, I've documented the process here: http://kegel.com/wine/spellingpolice/ For instance, to find typos in comments in shell32, you can do: sudo apt-get install ispell wget http://kegel.com/wine/spellingpolice/stop.txt wget http://kegel.com/wine/spellingpolice/lspell-pl.txt -O lspell.pl perl lspell.pl stop.txt ~/wine-git/dlls/shell32/*.[ch] This outputs: /home/dank/wine-git/dlls/shell32/autocomplete.c: 1 dispays /home/dank/wine-git/dlls/shell32/brsfolder.c: 1 relativ /home/dank/wine-git/dlls/shell32/dataobject.c: 1 droping /home/dank/wine-git/dlls/shell32/iconcache.c: 1 resoure /home/dank/wine-git/dlls/shell32/pidl.c: 1 relativ /home/dank/wine-git/dlls/shell32/pidl.h: 1 desribes /home/dank/wine-git/dlls/shell32/shell.c: 1 incidently /home/dank/wine-git/dlls/shell32/shfldr_fs.c: 1 spezified /home/dank/wine-git/dlls/shell32/shfldr_unixfs.c: 4 appart relativ savely should'nt /home/dank/wine-git/dlls/shell32/shlexec.c: 1 foward /home/dank/wine-git/dlls/shell32/shlfileop.c: 2 ERRROR INVLID /home/dank/wine-git/dlls/shell32/shlfolder.c: 1 whitch /home/dank/wine-git/dlls/shell32/shlview.c: 2 buily provied /home/dank/wine-git/dlls/shell32/trash.c: 1 DESCRITION

4 4

I am at the Ubuntu Developer Summit, do we need anything from other projects?
by scott＠tuzakey.com Jan. 3, 2008

Jan. 3, 2008

The other day an X.org developer asked me if Wine needed anything from X. Off the top of my head, all I could think to tell him was relative mouse movements. There are people from many free software projects here, including the kernel and Samba. Should I voice anything else? Thanks, Scott Ritchie

5 5

Re: [1/7] msxml3: Implement setNamedItem
by Alexandre Julliard Jan. 3, 2008

Jan. 3, 2008

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > + /* Must be an Attribute */ > + IUnknown_QueryInterface(newItem, &IID_IXMLDOMNode, (LPVOID*)&pAttr); > + if(pAttr) > + { > + ThisNew = impl_from_IXMLDOMNode( pAttr ); > + > + IUnknown_Release(pAttr); > + > + if(ThisNew->node->type != XML_ATTRIBUTE_NODE) > + return E_FAIL; You shouldn't access the object after having released it. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: wine gdiplus <-> mono gdiplus wrapper
by Dan Kegel Jan. 3, 2008

Jan. 3, 2008

Jerome wrote: > I wrote a little script in order to wrap gdiplus with the mono one; > Here are the source file and the spec file (this one made with winedump), but > I have no idea how to compile it and/or include it in the wine source tree. > Could you tell me what you think about it ? And if it has some utility ? IIRC, the Mono gdiplus isn't so useful for us because it doesn't deal with GDI handles the way we need. That's one reason we have our own gdiplus now. It might be more useful if you would look at fixing bugs in our gdiplus rather than trying to wrap Mono's. - Dan

5 5

Can't figure out how tolink a program
by Blake McBride Jan. 3, 2008

Jan. 3, 2008

I have a library built under Linux with Wine (mylib.a) that uses various Windows API (mainly GUI) that built fine. I compiled the main program from .c to .o and from .rc to .res just fine. My problem is I can't figure our what command line to use to link: myprogram.o myprogram.res mylib.a In other words, when I try to link it all together I get a bunch of unresolved externals on things like: ReleaseDC GetDC SendMessageA MulDiv GlobalAlloc etc....... I don't know what gcc command line argument to load the normal API's. I checked all the online docs. There are no examples and the docs that do exist state that hey are out-of-date. I would really appreciate a few simple example command lines to link a program with the normal API's AND my .res file. Thank you. Blake McBride blake(a)mcbride.name

1 0

TrackPopupMenu() and TPM_RECURSE
by olympia＠skydreams.org Jan. 3, 2008

Jan. 3, 2008

Hi, According to the MSDN documentation (see below), TrackPopupMenu() should only display multiple popupmenus if TPM_RECURSE is used. At the moment, Wine always seems to allow this and in some applications this results in very confusing menu overlaps. Moreover, the old popup menus will never be closed. This seems to particularly be the case in applications that use TrackPopupMenuEx() for their application menus. I was looking at the code and was unsure of how existing popup menus in a window should be safely closed when the application calls TrackPopupMenu() a second or third time. Does anyone have a suggestion? Best regards, Nicholai Windows 98/Me, Windows 2000/XP: Use the TPM_RECURSE flag to display a menu when another menu is already displayed. This is intended to support context menus within a menu.

1 0

Re: comdlg32: Remove unneeded casts (Resend)
by Robert Shearman Jan. 2, 2008

Jan. 2, 2008

Andrew Talbot wrote: > if (fodInfos->ofnInfos->Flags & OFN_ALLOWMULTISELECT) > size += 1; > /* return needed size in first two bytes of lpstrFile */ > - *(WORD *)fodInfos->ofnInfos->lpstrFile = size; > + *fodInfos->ofnInfos->lpstrFile = size; > FILEDLG95_Clean(hwnd); > ret = EndDialog(hwnd, FALSE); > COMDLG32_SetCommDlgExtendedError(FNERR_BUFFERTOOSMALL); > @@ -763,7 +763,7 @@ static BOOL PRINTDLG_SetUpPaperComboBoxW(HWND hDlg, > NrOfEntries = DeviceCapabilitiesW(PrinterName, PortName, > fwCapability_Names, Names, dm); > NrOfEntries = DeviceCapabilitiesW(PrinterName, PortName, > - fwCapability_Words, (LPWSTR)Words, dm); > + fwCapability_Words, Words, dm); > > /* reset any current content in the combobox */ > SendDlgItemMessageW(hDlg, nIDComboBox, CB_RESETCONTENT, 0, 0); > I think these two casts should stay as LPWSTR is compatible with WORD * only by coincidence - one is intended to hold characters and the other numbers. -- Rob Shearman

1 0

wine gdiplus <-> mono gdiplus wrapper
by Jérôme Gardou Jan. 2, 2008

Jan. 2, 2008

I wrote a little script in order to wrap gdiplus with the mono one; Here are the source file and the spec file (this one made with winedump), but I have no idea how to compile it and/or include it in the wine source tree. Could you tell me what you think about it ? And if it has some utility ?

1 0

Is there any reason why these patches were not applied to the git repository?
by Reece Dunn Jan. 2, 2008

Jan. 2, 2008

I sent these patches to wine-patches, but they have not been applied. gdiplus: added the ProfileNotFound status code. [0001-gdiplus-added-the-ProfileNotFound-status-code.patch] 30/12/2007 ‎include: added the new Vista theme schema headers. [0001-include-added-the-new-Vista-theme-schema-headers.patch] 30/12/2007 include: added the BUTTON parts and states. [0001-include-added-the-BUTTON-parts-and-states.patch] 30/12/2007 ‎include: added the AEROWIZARD parts and states. [0001-include-added-the-AEROWIZARD-parts-and-states.patch] 30/12/2007 include: added the COMBOBOX parts and states. [0001-include-added-the-COMBOBOX-parts-and-states.patch] 30/12/2007 - Reece

3 2

Norwegian language files using wrong locale
by Daniel Nylander Jan. 2, 2008

Jan. 2, 2008

I noticed that the Norwegian (bokmål) locale files are using the locale "no". Correct locale for Norwegian Bokmål is "nb" (Nynorsk is "nn"). -- Daniel Nylander (CISSP, GCUX, GCFA) Stockholm, Sweden http://www.DanielNylander.se

4 4

Pixel Shader Problem in 0.9.52
by László Tari Jan. 2, 2008

Jan. 2, 2008

Hi, Problem occurs when Depth Of Filed is turned on in Tomb Raider Anniversary. I simply overwrote the 0.9.52 wined3d.dll.so file with the 0.9.44 wined3d.dll.so in /usr/lib/wine, it works, but a little bit slower. See attachment! Regards, Laszlo Sent from Yahoo! - a smarter inbox. __________________________________________________________ Sent from Yahoo! Mail - a smarter inbox http://uk.mail.yahoo.com

2 1

Re: #4 msvcrt: Correct search strategy for the wide exec/spawn functions.
by Alexandre Julliard Jan. 2, 2008

Jan. 2, 2008

Hans Leidekker <hans(a)it.vu.nl> writes: > Changelog > Correct search strategy for the wide exec/spawn functions. I don't think we want to duplicate all that code. The Ascii functions should convert their arguments and call the Unicode ones. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: include: added the new Vista theme schema headers.
by Alexandre Julliard Jan. 2, 2008

Jan. 2, 2008

"Reece Dunn" <msclrhd(a)googlemail.com> writes: > diff --git a/include/tmschema.h b/include/tmschema.h > index 910de19..3a3e3e3 100644 > --- a/include/tmschema.h > +++ b/include/tmschema.h > @@ -20,6 +20,10 @@ > #ifndef __WINE_TMSCHEMA_H > #define __WINE_TMSCHEMA_H > > +#if defined(__WINE_VSSYM32_H) > +# error tmschema.h (XP) cannot be included along side vssym32.h (Vista). > +#endif That's not the way it's done in the SDK. -- Alexandre Julliard julliard(a)winehq.org

1 0