January 2008 - Wine-Devel - list.winehq.org

Re: Implement IStream interface for msxml3 domdoc
by L. Rahyen Jan. 12, 2008

Jan. 12, 2008

On Saturday January 12 2008 11:31:38 Josef Reidinger wrote: > This patch fix bug #4811. It implements IStream interface for dom > document in msxml. Really implemented is needed part of write function, > other function is not implemented. Part is also not implemented by > windows (readed only at msdn, not tested), part is not implemented > because I don't know how this work on windows and I cannot test it. This > is my first wine patch so feel free give me any hint about my code. > It is four patches because I do it more days. Only one patch per one e-mail is allowed. > It must be implemented > all, because some not work (I forget for example initialize vtbl for > IStream) but all is compilable. last patch fix my bad whitespaces > (trailing spaces and tabs instead of spaces). Patches with whitespace changes only are unlikely to be accepted and patches with tabs probably will not be accepted too. Therefore I suggest to fix formatting in your main patches themselves instead of fixing this with additional patch.

2 1

Re: Implement IStream interface for msxml3 domdoc
by Dmitry Timoshkov Jan. 12, 2008

Jan. 12, 2008

"Josef Reidinger" <josef.reidinger(a)seznam.cz> wrote: > changelog: > * implement IStream write for msxml domdoc What are the tab settings in your editor? All white space in your patches looks completely broken. Set tab size to 8 spaces, and try to avoid tabs at all. > + if (!This->Stream){ > + > + } Why is the code above is needed? > +static const IStreamVtbl xmldoc_IStream_VTable = > +{ > + xmldoc_IStream_QueryInterface, > + xmldoc_IStream_AddRef, > + xmldoc_IStream_Release, > + xmldoc_IStream_Read, > + xmldoc_IStream_Write, > + xmldoc_IStream_Seek, > + xmldoc_IStream_SetSize > +/* xmldoc_IStream_CopyTo, > + xmldoc_IStream_Commit, > + xmldoc_IStream_Revert, > + xmldoc_IStream_LockRegion, > + xmldoc_IStream_UnlockRegion, > + xmldoc_IStream_Stat, > + xmldoc_IStream_Clone*/ > +}; You can't provide a partial vtable. > + TRACE("1"); Remove all debugging craft before submitting the patch. -- Dmitry.

1 0

Please change Bugzilla email settings for wine-bugs
by Luke Bratch Jan. 12, 2008

Jan. 12, 2008

> Yes, the templates for the emails are in git with the > rest of bugzilla. We just need to be carefull to not > throw off anything that parses these mails. Patches > welcome. I'll have a look and submit a patch. > We could change that mailinglist to not accept mail > from anything else than bugzilla. It is configured to do just that; so the emails just end up in the list moderation queue, which (presumably?) is only seen by me. I've been posting people's replies in Bugzilla myself, so they don't get lost forever. __________________________________________________________ Sent from Yahoo! Mail - a smarter inbox http://uk.mail.yahoo.com

1 0

re: bugs audit volunteers require
by Dan Kegel Jan. 12, 2008

Jan. 12, 2008

>> Maybe add a resolution of NEEDMOREINFO? > >There is no need to add one more reason for a bug resolution IMHO, >INVALID with appropriate comment does the job. INVALID seems harsh, it may scare away novice reporters. Do we want to make it easy to search for bugs stuck in a needmoreinfo kind of state? If so, a keyword or state might be handy. Does anybody remember good old gnu gnats, the old bug tracking system? It was great this way; it had an explicit notion of whose ball the court was in. I miss that. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

5 8

Please change Bugzilla email settings for wine-bugs
by Dan Kegel Jan. 12, 2008

Jan. 12, 2008

Say, could we set Mr. Bugs' email preferences in Bugzilla so that mail is never sent to wine-bugs if the CC field changes? I'm getting mighty tired of clicking on something in the wine-bugs archive and seeing only Jaime Rave <jaimerave at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jaimerave at gmail.com Thanks, Dan

5 4

Please change Bugzilla email settings for wine-bugs
by Luke Bratch Jan. 12, 2008

Jan. 12, 2008

Whilst on the subject of Bugzilla email settings, is it possible to add a message to Bugzilla emails asking users not to reply, but to post in Bugzilla? There's now often up to 5 replies a day sent directly to wine-bugs(a)winehq.org, instead of being posted in Bugzilla. Thanks, Luke ___________________________________________________________ Support the World Aids Awareness campaign this month with Yahoo! For Good http://uk.promotions.yahoo.com/forgood/

2 1

Bug audit status
by Dan Kegel Jan. 12, 2008

Jan. 12, 2008

Since Vijay suggested doing a bug audit two weeks ago, the number of open bugs has dropped by about 300, or 10%: http://bugs.winehq.org/reports.cgi?product=-All-&datasets=NEW%3A&datasets=U… That was quite a burst of activity! There are still 1800 bugs that haven't been touched in over 90 days (137 of them reported by me, alas), so we have a lot of auditing and retesting left to do. BTW, James Hawkins suggests that we consider bugs abandoned if the reporter doesn't respond within 90 days (we had, I think, been letting them sit longer), which seems reasonable to me.

1 0

New winetricks: added riched20
by Dan Kegel Jan. 12, 2008

Jan. 12, 2008

Seeing as we have about 45 open riched20 bugs, and some recent regressions, I figured it'd be useful to add riched20 to winetricks. Incidentally, since I lost the workstation that had the old rcs repository it was in, I gave in to modern times and put it in a new repository at http://code.google.com/p/winezeug/ - Dan p.s. I have a backlog of two or three big updates, one from Lei for codecs, and another from Andrea Bocci for all sorts of things. I'd merge them now but I have to go read another Discworld book... they're like crack...

1 0

Bugzilla admin: please remove bug/illegal attachment from the bug 5928
by Vitaliy Margolen Jan. 12, 2008

Jan. 12, 2008

Also please remove poster from the users list of the bugzilla. Posting illegal content is against usage policies. Thanks. Vitaliy.

1 0

urlmon tests now require gecko?
by Dan Kegel Jan. 12, 2008

Jan. 12, 2008

Running the tests now hangs for me waiting for me to click "OK" to the gecko download dialog. Is that something we want to fix, or should I just do 'winetricks gecko' before starting the tests?

1 0