October 2008 - Wine-Devel - list.winehq.org

Please Review WWN 353
by Zachary Goldberg Oct. 6, 2008

Oct. 6, 2008

All, This WWN is all my writing and no quotes, and thus a lot more room for typographical and other errors. Thus I wanted to send everybody the WWN for review before publication. In particular please check the first section for name typos etc. http://home.bluesata.com/WineWWN/WineHQ/?issue=353 -Zach

4 3

Re: [PATCH] also remove backbuffer flags in the v1 DDRAW interface
by Austin English Oct. 6, 2008

Oct. 6, 2008

On Sun, Oct 5, 2008 at 2:26 PM, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > This fixes http://bugs.winehq.org/show_bug.cgi?id=9008 > by also filtering out the backbuffer flag. > > Ciao, Marcus > --- > dlls/ddraw/ddraw_thunks.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/dlls/ddraw/ddraw_thunks.c b/dlls/ddraw/ddraw_thunks.c > index b748ad4..c77b3bb 100644 > --- a/dlls/ddraw/ddraw_thunks.c > +++ b/dlls/ddraw/ddraw_thunks.c > @@ -386,10 +386,10 @@ IDirectDrawImpl_CreateSurface(LPDIRECTDRAW This, LPDDSURFACEDESC pSDesc, > IDirectDrawSurfaceImpl *impl; > HRESULT hr; > > - /* Remove front buffer flag, this causes failure in v7, and its added to normal > - * primaries anyway > + /* Remove front and back buffer flag, this causes failure in v7, > + * and its added to normal primaries anyway. Nitpick, but typo there: should be "it's", not "its" -Austin

2 1

Re: [1/2] user32: Converted rcScrollBar to screen coordinates.
by Dmitry Timoshkov Oct. 6, 2008

Oct. 6, 2008

"Dylan Smith" <dylan.ah.smith(a)gmail.com> wrote: > @@ -1252,6 +1253,9 @@ static BOOL SCROLL_GetScrollBarInfo(HWND hwnd, LONG idObject, LPSCROLLBARINFO in > > SCROLL_GetScrollBarRect(hwnd, nBar, &info->rcScrollBar, &nDummy, > &info->dxyLineButton, &info->xyThumbTop); > + /* rcScrollBar needs to be in screen coordinates */ > + GetWindowRect(hwnd, &rect); > + OffsetRect(&info->rcScrollBar, rect.left, rect.top); You need to fix SCROLL_GetScrollBarRect for the SB_CTL case instead. > +static void scrollbar_test4(void) > +{ > + BOOL ret; > + SCROLLBARINFO sbi; > + RECT rect; > + > + /* Test GetScrollBarInfo to make sure it returns rcScrollBar in screen > + * coordinates. */ > + sbi.cbSize = sizeof(sbi); > + ret = GetScrollBarInfo( hScroll, OBJID_CLIENT, &sbi); > + ok( ret, "The GetScrollBarInfo() call should not fail.\n" ); > + GetWindowRect( hScroll, &rect ); > + ok( ret, "The GetWindowRect() call should not fail.\n" ); > + ok( !(sbi.rgstate[0] & (STATE_SYSTEM_INVISIBLE|STATE_SYSTEM_OFFSCREEN)), > + "unexpected rgstate(0x%x)\n", sbi.rgstate[0]); > + ok( !memcmp(&rect, &sbi.rcScrollBar, sizeof(RECT)), > + "WindowRect(%d, %d, %d, %d) != rcScrollBar(%d, %d, %d, %d)\n", EqualRect is better than memcmp. -- Dmitry.

2 2

Wineconf follow up: Cosmetic website changes
by Zachary Goldberg Oct. 6, 2008

Oct. 6, 2008

Hello all, I just wanted to start up a thread to continue the conversation from Wineconf about revamping the WineHQ homepage. The last notes I took on the subject had Dan Kegel considering doing an actual redesign. --Zach

1 0

request for windows test ddraw/dsurface
by Marcus Meissner Oct. 5, 2008

Oct. 5, 2008

Hi, I am suspecting that in IDirectDraw1 the behaviour regarding backbuffer creation might change if we have a just created frontbuffer of the same size. (This is similar to behaviour shown by bulanci.exe of http://bugs.winehq.org/show_bug.cgi?id=9008 ) Can someone please try this on Windows please? Ciao, Marcus diff --git a/dlls/ddraw/tests/dsurface.c b/dlls/ddraw/tests/dsurface.c index fc7bb88..50f6986 100644 --- a/dlls/ddraw/tests/dsurface.c +++ b/dlls/ddraw/tests/dsurface.c @@ -1331,10 +1331,21 @@ static void AttachmentTest(void) /* This old ddraw version happily creates explicit front buffers */ memset(&ddsd, 0, sizeof(ddsd)); ddsd.dwSize = sizeof(ddsd); + ddsd.dwHeight = 800; + ddsd.dwWidth = 600; ddsd.dwFlags = DDSD_CAPS; ddsd.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE | DDSCAPS_FRONTBUFFER; hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface1, NULL); ok(hr==DD_OK,"CreateSurface returned: %x\n",hr); + + /* MARCUS: Lets try creating a backbuffer with frontbuffer live... */ + memset(&ddsd, 0, sizeof(ddsd)); + ddsd.dwSize = sizeof(ddsd); + ddsd.dwFlags = DDSD_CAPS; + ddsd.ddsCaps.dwCaps = DDSCAPS_BACKBUFFER; + hr = IDirectDraw_CreateSurface(lpDD, &ddsd, &surface2, NULL); + ok(hr==DDERR_INVALIDCAPS,"CreateSurface backbuffer after frontbuffer returned: %x\n",hr); + IDirectDrawSurface_Release(surface1); /* Try a single primary and two offscreen plain surfaces */

2 1

Re: d3d8: initialize IDirect3DDevice8 *device to NULL incase of immedient cleanup. (coverity 795)
by Rob Shearman Oct. 5, 2008

Oct. 5, 2008

2008/10/3 Aric Stewart <aric(a)codeweavers.com>: > - IDirect3DDevice8 *device; > + IDirect3DDevice8 *device=NULL; Add spaces around the "=" here to match the rest of the code. -- Rob Shearman

1 0

Re: [try 4][PATCH 1/2] user32/tests: Added test about minimal child windowsizes.
by Dmitry Timoshkov Oct. 5, 2008

Oct. 5, 2008

"Florian Köberle" <florian(a)fkoeberle.de> wrote: > Changes since try 3: > + I found out that the minimal child window size is "4 + 2*borderWidth" > by testing multiple values for some registery keys like > "HKEY_CURRENT_USER\Control Panel\Desktop\WindowMetrics\BorderWidth" on a > Windows XP machine. I don't know where the 4 comes from, but it could be > hard coded in Windows too. That still looks more like a hack and you still need find what that values mean. "4 + 2*borderWidth" is not something to trust in general. -- Dmitry.

1 0

Wine: Possible typo in dll/msxml3/tests/domdoc.c
by Michael Karcher Oct. 4, 2008

Oct. 4, 2008

Hello Huw Davies, it looks like test_removeChild (introduced by you in commit 187ab1c0) contains a typo. The test passes both ways, but from the code flow I suspect that node_list2 was obtained for a reason, namely using it. Regards, Michael Karcher This patch fixes the type, if it turn out to really be a typo. diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c index 29bebb9..0494e9f 100644 --- a/dlls/msxml3/tests/domdoc.c +++ b/dlls/msxml3/tests/domdoc.c @@ -1785,7 +1785,7 @@ static void test_removeChild(void) r = IXMLDOMNode_get_childNodes( node, &node_list2 ); ok( r == S_OK, "ret %08x\n", r); - r = IXMLDOMNodeList_get_item( node_list, 0, &node4 ); + r = IXMLDOMNodeList_get_item( node_list2, 0, &node4 ); ok( r == S_OK, "ret %08x\n", r); r = IXMLDOMElement_removeChild( element, NULL, &node2 );

2 3

Layered windows required to support Clippy properly?
by Dan Kegel Oct. 4, 2008

Oct. 4, 2008

I see in wine-1.1.5's announcement that we now have partial support for "Layered Windows", http://msdn.microsoft.com/en-us/library/ms997507.aspx Which apps use this? Seems that it used to make screen captures hard, so one way to find them is to look for apps that say you have to turn on "Capture Alpha-Blending" on in UltraVNC to see them remotely. Candidates include: Visual Studio - tooltips Microsoft Office - Clippy Possibly photoshop cs3 Another way is to look for apps that recommend the Vista Layered Windows Performance hotfix or Vista SP1. Candidates include: Yahoo Messenger for Windows Vista Another way is to look for apps that make Wine output fixme:xrender:X11DRV_AlphaBlend Ignoring SourceConstantAlpha ... Candidates include: Miranda IM http://bugs.winehq.org/show_bug.cgi?id=11902 MSN Messenger http://bugs.winehq.org/show_bug.cgi?id=8555 Skype http://bugs.winehq.org/show_bug.cgi?id=12334 I'm getting the feeling it's widespread. Anyone else know of examples of apps that Wine displays poorly because of the lack of this feature? - Dan

2 1

Re: richedit: Show arrow cursor over scrollbar. (Fixes bug 15334)
by Dylan Smith Oct. 4, 2008

Oct. 4, 2008

On Sat, Oct 4, 2008 at 1:21 AM, Dylan Smith <dylan.ah.smith(a)gmail.com>wrote: > Implemented the code to check for this condition in the function that > handles WM_SETCURSOR. For each scrollbar I checked for visibility and > checked the MessagePos to see if the mouse was over the scrollbar. > --- > dlls/riched20/editor.c | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > This fix works alright in Wine, but I found out that it wasn't working when I cross-compiled riched20.dll and wordpad and then ran it on Windows XP. It seems as if GetScrollBarInfo was returning a SCROLLBARINFO struct with an rcScrollBar RECT in client coordinates in Wine and in screen coordinates in Windows XP. This underlying problem should be fixed first before fixing richedit. Later this patch would be modified to move the call to ScreenToClient after the check to see if the position is within the scrollbars, which I found fixes the problem on Windows.

1 0

Silencing a noisy fixme - feedback requested
by Austin English Oct. 3, 2008

Oct. 3, 2008

Howdy, I was taking a look at some of the noisy fixme's, and wanted some feedback on the attached patch. This particular fixme is _really_ noisy...out of this (http://bugs.winehq.org/attachment.cgi?id=16447) log, it has 9635 of the 13117 lines! "fixme:ntdll:NtLockFile I/O completion on lock not implemented yet" 9635 times! Not sure if this is the best way to go about this or not. Any advice appreciated (or if anyone else wants to silence it :-P). -Austin

5 6

RE: d3d8/9: Use WINED3D_OK instead of D3D_OK in vertexshader.c.
by Stefan Dösinger Oct. 3, 2008

Oct. 3, 2008

> -----Original Message----- > From: Henri Verbeet [mailto:hverbeet(a)gmail.com] > Sent: Friday, October 03, 2008 10:25 AM > To: Stefan Dösinger > Subject: Re: d3d8/9: Use WINED3D_OK instead of D3D_OK in vertexshader.c. > > 2008/10/3 Stefan Dösinger <stefan(a)codeweavers.com>: > > Actually, since the return value comes from WineD3D, we should use > WINED3D_OK here. Although there is not really a scheme behind all this > and we never cared about that because both WINED3D_OK and D3D_OK are > #define'd to S_OK. > > > Yes, that's what the patch does :-) Woops. Confusion

1 0

RE: d3d8/9: Use WINED3D_OK instead of D3D_OK in vertexshader.c.
by Stefan Dösinger Oct. 3, 2008

Oct. 3, 2008

Actually, since the return value comes from WineD3D, we should use WINED3D_OK here. Although there is not really a scheme behind all this and we never cared about that because both WINED3D_OK and D3D_OK are #define'd to S_OK. > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Rob Shearman > Sent: Friday, October 03, 2008 6:56 AM > To: wine-patches > Subject: d3d8/9: Use WINED3D_OK instead of D3D_OK in vertexshader.c. > > --- > dlls/d3d8/vertexshader.c | 4 ++-- > dlls/d3d9/vertexshader.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-)

1 0

D3DXAssembleShader, unknown texture formats and misc
by Kjell Rune Skaaraas Oct. 3, 2008

Oct. 3, 2008

Hello,I'm taking a stab at implmenting D3DXAssembleShader, which takes shader instructions like "mul r1, r2.xy, r3.z" and turns them into binary code (one-to-one mapping). Although I've got very little clue what I'm really doing, I've come quite a way on a parser that breaks it down into the separate parts and made some reverse lookups on tables of opcodes, registrys, masks etc. that I found in the wine code. I've basicly come so far that I got the parts like mul = 0x00000005, r = temp registry = 0x00000000, register number = 0x00000001, writemask = 0x000F0000 etc. for all the arguments, but I'm struggling a bit putting it all together into the correct binary format. I have found a lot of material on the *text* format of the shader instructions, but pretty much none on the binary format. Clearly some documentation must have been used/made when you implemented glsl and the other shader backends as they read this stuff and translates it to OpenGL calls. Does anyone have anything they could share with me? P.S. Don't expect too much of me though, 1) It's so ugly it makes grown men cry, 2) Current it leaks memory bigtime and 3) It's a text hack that will never validate shader code or anything like that BUT I think I can make this work for code that already works.On a different note, a game I have is pulling up two completely unknown texture formats R16 and AL16 as fourcc. I figured I could at least find out something about them and add them to the debug tables, but the only references I find on google are to wine and wine bug reports. I figure they may be related to R16F (same with ints?) and L16 (luminosity, so AL16 with alpha?) but I can't find anything on them.Oh yeah and for the misc question - where's the right place to add test code? I expect my D3DXAssembleShader function will need a lot of it - at least one for each opcode, registry tests, write mask tests, whitespace and commenting tests+++. No code for you to review yet, not until it works. THEN you can bring out the tar and feathers over the code. Regards,Kjell Rune _________________________________________________________ Alt i ett. Få Yahoo! Mail med adressekartotek, kalender og notisblokk. http://no.mail.yahoo.com

2 1

Re: msxml3: Add IXMLHTTPRequest support (try 2)
by Juan Lang Oct. 3, 2008

Oct. 3, 2008

Hi Alistair, maybe I'm being overly picky, but:: --- /dev/null +++ b/dlls/msxml3/httprequest.c @@ -0,0 +1,343 @@ +/* This file has DOS line endings. The rest of the files do not. It's really distracting in the patch, since this portion of the patch has ^M at the end of every line. --Juan

1 0

Re: msxml3: Add IXMLHTTPRequest support
by Alistair Leslie-Hughes Oct. 3, 2008

Oct. 3, 2008

From: "Hans Leidekker" <hans(a)meelstraat.net> Sent: Friday, October 03, 2008 9:45 PM To: <wine-devel(a)winehq.org>; "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> Subject: Re: msxml3: Add IXMLHTTPRequest support > On Friday 03 October 2008 13:23:14 Alistair Leslie-Hughes wrote: > >> Changelog: >> msxml3: Add IXMLHTTPRequest support > > Would it be possible to use winhttp instead of nanohttp? The less > we depend on libxml the better I'd say. > Sure. This nanphttp was just my initial thought. I'll resend a corrected patch shortly. Best Regards Alistair Leslie-Hughes

1 0

Re: msxml3: Add IXMLHTTPRequest support
by Hans Leidekker Oct. 3, 2008

Oct. 3, 2008

On Friday 03 October 2008 13:23:14 Alistair Leslie-Hughes wrote: > Changelog: > msxml3: Add IXMLHTTPRequest support Would it be possible to use winhttp instead of nanohttp? The less we depend on libxml the better I'd say. -Hans

2 1

Re: [PATCH 1/2] wininet: Return error codes explicitly from URLCache functions instead of returning a BOOL and storing the error code in the last error value.
by Juan Lang Oct. 3, 2008

Oct. 3, 2008

Hi Rob, + * Locks the index for system-wide exclusive access. + * + * RETURNS + * TRUE if successful + * FALSE if failed and calls SetLastError. */ static LPURLCACHE_HEADER URLCacheContainer_LockIndex(URLCACHECONTAINER * pContainer) The comment's off here. @@ -1346,34 +1353,32 @@ static BOOL URLCache_AddEntryToHash(LPURLCACHE_HEADER pHeader, LPCSTR lpszUrl, D * FALSE if the hash table could not be created * */ -static HASH_CACHEFILE_ENTRY *URLCache_CreateHashTable(LPURLCACHE_HEADER pHeader, HASH_CACHEFILE_ENTRY *pPrevHash) +static DWORD URLCache_CreateHashTable(LPURLCACHE_HEADER pHeader, HASH_CACHEFILE_ENTRY *pPrevHash, HASH_CACHEFILE_ENTRY **ppHash) I think you forgot to update the comment here. --Juan

2 1

Re: msi: Implement the DROP TABLE sql command.
by Steven Edwards Oct. 3, 2008

Oct. 3, 2008

On Thu, Oct 2, 2008 at 3:25 PM, James Hawkins <jhawkins(a)codeweavers.com> wrote: > Hi, I can't repro this problem on my machine, so I'm sending this > patch to patchwatcher by way of wine-patches to get some info. Please > do not apply. Regarding our wineconf discussion about patchwatcher spam on wine-patches and filtering. Perhaps we need 2 email address patches can be sent to. My thinking is the flow could be something like: 1. By default everyone sends a patch to wine-patches 2. If a patch gets rejected the author gets a failure mail in private, and now retries or testing patches should go to wine-patches-testing N times until they get it right 3. once its right, patchwatch could then forward the new good patch to wine-patches or could send an email to the dev saying that its good enough to now send to wine-patches. Doing it like this, if everyone follows the rules, we won't get a ton of patchwatcher retries filling up wine-patches. -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

4 6

Re: howto fix bug 13462
by Louis. Lenders Oct. 2, 2008

Oct. 2, 2008

Rob Shearman <robertshearman <at> gmail.com> writes: Hi Rob, i think i got the test ready now, i'll send it when the defenitions are in place in ctxtcall.idl. Now still strugling how to fix the bug. I fixed up the patch below, also by looking how things are done in similar places in wine-code. With patch applied I can see that ContextCallback_ContextCallback and ContextCallback_Release are called from the application (tested with NASA WorldWind), and the simple stubs are enough to let the app continue fine. But i'm not sure if everything is 100% ok. Is this what you more or less meant in your first comment? diff --git a/dlls/ole32/compobj.c b/dlls/ole32/compobj.c index 37907ec..a1f41fd 100644 --- a/dlls/ole32/compobj.c +++ b/dlls/ole32/compobj.c @@ -55,6 +55,7 @@ #include "objbase.h" #include "ole2.h" #include "ole2ver.h" +#include "ctxtcall.h" #include "compobj_private.h" @@ -3615,25 +3616,39 @@ HRESULT WINAPI CoRegisterChannelHook(REFGUID guidExtension, IChannelHook *pChann typedef struct Context { const IComThreadingInfoVtbl *lpVtbl; + const IContextCallback *lpVtblIContextCallback; LONG refs; APTTYPE apttype; } Context; +static inline Context *impl_from_Context(IComThreadingInfo *iface) +{ + return (Context *)((char*)iface - FIELD_OFFSET(Context, lpVtbl)); +} + static HRESULT WINAPI Context_QueryInterface(IComThreadingInfo *iface, REFIID riid, LPVOID *ppv) { + Context* This=impl_from_Context((IComThreadingInfo*) iface); *ppv = NULL; if (IsEqualIID(riid, &IID_IComThreadingInfo) || IsEqualIID(riid, &IID_IUnknown)) { *ppv = iface; - IUnknown_AddRef(iface); - return S_OK; } + else if(IsEqualIID(riid, &IID_IContextCallback)) + { + *ppv = &This->lpVtblIContextCallback; + } + else + { + FIXME("interface not implemented %s\n", debugstr_guid(riid)); + return E_NOINTERFACE; + } - FIXME("interface not implemented %s\n", debugstr_guid(riid)); - return E_NOINTERFACE; -} + IUnknown_AddRef(iface); + return S_OK; +} static ULONG WINAPI Context_AddRef(IComThreadingInfo *iface) { @@ -3691,6 +3706,31 @@ static HRESULT WINAPI Context_SetCurrentLogicalThreadId(IComThreadingInfo *iface return E_NOTIMPL; } + +static HRESULT WINAPI ContextCallback_QueryInterface(IContextCallback *iface, REFIID riid, LPVOID *ppv) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static ULONG WINAPI ContextCallback_AddRef(IContextCallback *iface) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static ULONG WINAPI ContextCallback_Release(IContextCallback *iface) +{ + FIXME("\n"); + return E_NOTIMPL; +} + +static HRESULT WINAPI ContextCallback_ContextCallback(IContextCallback *iface, PFNCONTEXTCALL pfnCallback, ComCallData* pParam, REFIID riid, int iMethod, IUnknown* pUnk) +{ + FIXME("not implemented yet\n"); + return E_NOTIMPL; +} + static const IComThreadingInfoVtbl Context_Threading_Vtbl = { Context_QueryInterface, @@ -3702,6 +3742,14 @@ static const IComThreadingInfoVtbl Context_Threading_Vtbl = Context_SetCurrentLogicalThreadId }; +static const IContextCallbackVtbl Context_Callback_Vtbl = +{ + ContextCallback_QueryInterface, + ContextCallback_AddRef, + ContextCallback_Release, + ContextCallback_ContextCallback +}; + /*********************************************************************** * CoGetObjectContext [OLE32.@] * @@ -3735,6 +3783,7 @@ HRESULT WINAPI CoGetObjectContext(REFIID riid, void **ppv) return E_OUTOFMEMORY; context->lpVtbl = &Context_Threading_Vtbl; + context->lpVtblIContextCallback=(IContextCallback*)&Context_Callback_Vtbl; context->refs = 1; if (apt->multi_threaded) context->apttype = APTTYPE_MTA;

3 2

Re: [PATCH 4/4] jscript: Added possibility to run test scripts from file.
by winepatches＠kegel.com Oct. 2, 2008

Oct. 2, 2008

> > With this patch it's possible to test scripts by running > wine jscript_test.exe.so run <file_name> > Although it's not what Wine tests are for, it proved to be very useful > for me. That's the second time in the last couple days that your patches confused patchwatcher's patch series detector. You resent patch 4/4 from a different series, and patchwatcher took that other 4/4 and used it in place of this one, leaving this patch as a stuck singleton. Tips: 1) never send two series of the same length on the same day (This confuses even humans.) 2) never partially resend patch series, always resend the whole series. (Eventually patchwatcher will handle this better.)

1 0

Detecting Wine
by Mark Wagner Oct. 2, 2008

Oct. 2, 2008

What's the best way for an application to detect that it's running under Wine? As part of the installation process, under Windows our program does a full-disk search of all local hard drives, but ignoring network drives and removable media. Under Wine, this doesn't work too well, as there's not a one-to-one mapping between disks and drive letters, and there's usually at least one way to access the entire *nix filesystem. If someone's got a few network drives mounted, the installer could spend hours searching them. -- Mark Wagner

10 17

Be careful out there
by Juan Lang Oct. 2, 2008

Oct. 2, 2008

Unfortunately, there is some Microsoft code available on the Internet. More unfortunately, Google has indexed some of it. I was searching for an undocumented function and ran across something that seemed to describe it. I clicked on the link, and fortunately the indexed page was just a reference to the actual source file, because the source file was Microsoft's. (The source file was also available. No, I didn't look at it.) Be very careful: reading Microsoft's source code is a clear way to taint yourself as a developer. --Juan

4 3

Fullscreen window in metacity hides owned window
by Michael Ost Oct. 2, 2008

Oct. 2, 2008

We are seeing a problem in Metacity where a fullscreen window obscures a second created window that has a particular style: WS_DLGFRAME | WS_THICKFRAME. When window A is created fullscreen (WS_POPUP, size matches screen res) and window B is created as an "owned window" (WS_DLGFRAME|WS_THICKFRAME|WS_OVERLAPPED style with "A" as its parent) you cannot see "B" if Metacity is running. You can if other window managers are running. We tried kwin, xfce, fluxbox, enlightenment or fvvm. So the problem is something specific to Metacity. You can also see window "B" if you remove either the WS_DLGFRAME or WS_THICKFRAME bit from the style. Any hints about where to look within Wine or what could be happening? - mo PS: the code (ctrl+c to quit)... #include <windows.h> const char g_szClassName[] = "myWindowClass"; // Step 4: the Window Procedure LRESULT CALLBACK WndProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) { switch(msg) { case WM_CLOSE: DestroyWindow(hwnd); break; case WM_DESTROY: PostQuitMessage(0); break; default: return DefWindowProc(hwnd, msg, wParam, lParam); } return 0; } int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { WNDCLASSEX wc; HWND hwnd, hwnd4; MSG Msg; //Step 1: Registering the Window Class wc.cbSize = sizeof(WNDCLASSEX); wc.style = 0; wc.lpfnWndProc = WndProc; wc.cbClsExtra = 0; wc.cbWndExtra = 0; wc.hInstance = hInstance; wc.hIcon = LoadIcon(NULL, IDI_APPLICATION); wc.hCursor = LoadCursor(NULL, IDC_ARROW); wc.hbrBackground = (HBRUSH)(COLOR_WINDOW+1); wc.lpszMenuName = NULL; wc.lpszClassName = g_szClassName; wc.hIconSm = LoadIcon(NULL, IDI_APPLICATION); if(!RegisterClassEx(&wc)) { MessageBox(NULL, "Window Registration Failed!", "Error!", MB_ICONEXCLAMATION | MB_OK); return 0; } // Step 2: Creating the Window int width = ::GetSystemMetrics(SM_CXSCREEN); int height = ::GetSystemMetrics(SM_CYSCREEN); hwnd = CreateWindowEx( WS_EX_CLIENTEDGE, g_szClassName, "A", WS_POPUP, CW_USEDEFAULT, CW_USEDEFAULT, width, height, NULL, NULL, hInstance, NULL); if(hwnd == NULL) { MessageBox(NULL, "Window Creation Failed!", "Error!", MB_ICONEXCLAMATION | MB_OK); return 0; } hwnd4 = CreateWindowEx( WS_EX_CLIENTEDGE, g_szClassName, "B", #if 1 // invisible WS_DLGFRAME|WS_THICKFRAME|WS_OVERLAPPED, #else // visible WS_THICKFRAME|WS_OVERLAPPED, #endif 300, 300, 240, 120, hwnd, NULL, hInstance, NULL); if(hwnd4 == NULL) { MessageBox(NULL, "Window Creation Failed!", "Error!", MB_ICONEXCLAMATION | MB_OK); return 0; } ShowWindow(hwnd, nCmdShow); ShowWindow(hwnd4, nCmdShow); UpdateWindow(hwnd); UpdateWindow(hwnd4); // Step 3: The Message Loop while(GetMessage(&Msg, NULL, 0, 0) > 0) { TranslateMessage(&Msg); DispatchMessage(&Msg); } return Msg.wParam; }

2 3

Re: (try 2)version: check for out of memory when VerInstallFileA/W converstion. (response to coverity 635)
by Rob Shearman Oct. 2, 2008

Oct. 2, 2008

2008/10/2 Aric Stewart <aric(a)codeweavers.com>: > @@ -543,34 +543,50 @@ DWORD WINAPI VerInstallFileW( > len = WideCharToMultiByte( CP_ACP, 0, srcfilename, -1, NULL, 0, NULL, NULL ); > if ((wsrcf = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_ACP, 0, srcfilename, -1, wsrcf, len, NULL, NULL ); > + else > + ret = VIF_OUTOFMEMORY; > } > - if (srcdir) > + if (srcdir && !ret) Remove the extra space here. > + static const CHAR szSrcDir[] = "C:\\windows\\temp"; > + static const CHAR szDestDir[] = "C:\\windows\\temp\\test"; > + static const CHAR szCurDir[] = "C:\\"; This isn't exactly what I meant. C:\Windows might not even exist on NT4/Win2000 and the temp directory might not be in %WINDIR%\temp. You should use GetTempPath instead. (Hard-coding C:\ is also something to be avoided if at all possible.) -- Rob Shearman

2 2

Re: gdi32: if a font substitution is given then only match to that substitution not to the original family name.
by Dmitry Timoshkov Oct. 2, 2008

Oct. 2, 2008

Aric Stewart <aric(a)codeweavers.com> wrote: > LIST_FOR_EACH(family_elem_ptr, &font_list) { > family = LIST_ENTRY(family_elem_ptr, Family, entry); > - if (!strcmpiW(family->FamilyName, FaceName) || > - (psub && !strcmpiW(family->FamilyName, psub->to.name))) > + if ((!psub && !strcmpiW(family->FamilyName, FaceName)) || > + ( psub && !strcmpiW(family->FamilyName, psub->to.name))) > { > LIST_FOR_EACH(face_elem_ptr, &family->faces) { > face = LIST_ENTRY(face_elem_ptr, Face, entry); Changing the order of 2 comparisons in the 'if' block would be clear IMO, and would help avoiding to check psub twice. -- Dmitry.

1 0

Re: version: check for out of memory when VerInstallFileA/W converstion. (response to coverity 635)
by Rob Shearman Oct. 2, 2008

Oct. 2, 2008

2008/10/2 Aric Stewart <aric(a)codeweavers.com>: > @@ -543,34 +543,50 @@ DWORD WINAPI VerInstallFileW( > len = WideCharToMultiByte( CP_ACP, 0, srcfilename, -1, NULL, 0, NULL, NULL ); > if ((wsrcf = HeapAlloc( GetProcessHeap(), 0, len ))) > WideCharToMultiByte( CP_ACP, 0, srcfilename, -1, wsrcf, len, NULL, NULL ); > + else if (len) > + ret = VIF_OUTOFMEMORY; IIRC HeapAlloc(..., 0) returns a non-NULL value, so the "if (len)" part is not needed. ... > + rc = VerInstallFileA(0x0, "in.txt", "out.txt", "C:\\windows\\temp", "C:\\windows\\temp\\test\\", "C:\\", tmpname, &size); > + ok (rc == 0x10000 && tmpname[0]==0," expected return 0x10000 and no tempname, got %08x/\'%s\'\n",rc,tmpname); You shouldn't hard-code paths such as this. -- Rob Shearman

1 0

Re: gdiplus: Stub GdipRecordMetafileFileName andGdipRecordMetafileFileNameI
by Alistair Leslie-Hughes Oct. 2, 2008

Oct. 2, 2008

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:48DCB2A0.9070405(a)hotmail.com... > Hi, > > Changelog: > gdiplus: Stub GdipRecordMetafileFileName and GdipRecordMetafileFileNameI > Was there anything wrong with this patch? Best Regards Alistair Leslie-Hughes

2 1

Re: msi: Implement the DROP TABLE sql command.
by James Hawkins Oct. 2, 2008

Oct. 2, 2008

Hold off on this patch. There's a missing debugstr_w and a crash on patchwatcher. -- James Hawkins

1 0

Re: [PATCH] wintrust: Add a stub for OpenPersonalTrustDBDialog
by Juan Lang Oct. 1, 2008

Oct. 1, 2008

Hi Detlef, I'm not sure why this wasn't committed, but my hunch is this: + * RETURNS + * Success: TRUE (The Dialog was opened) + * Failure: FALSE + * + */ +BOOL WINAPI OpenPersonalTrustDBDialog(HWND hwnd) +{ + FIXME("(%p) stub\n", hwnd); + return TRUE; Shouldn't it return FALSE instead? In any case, this is a very simple function to implement: it calls cryptui:CryptUIDlgCertMgr. I'll send in a patch that implements it, if you don't mind. --Juan

1 0

Re: [2/2] inetcomm: Add a stub implementation of IIMAPTransport.
by Paul Vriens Oct. 1, 2008

Oct. 1, 2008

Hans Leidekker wrote: > diff --git a/dlls/inetcomm/imaptransport.c b/dlls/inetcomm/imaptransport.c > new file mode 100644 > index 0000000..99011b2 > --- /dev/null > +++ b/dlls/inetcomm/imaptransport.c > @@ -0,0 +1,498 @@ > +/* > + * IMAP Transport > + * > + * Copyright 2008 Hans Leidekker for CodeWeavers > + * > + */ This one misses license information. (Patch is already committed though). -- Cheers, Paul.

1 0

Re: wine.inf: Add entry for fake wintab32.dll
by John Klehm Oct. 1, 2008

Oct. 1, 2008

On Wed, Oct 1, 2008 at 1:05 PM, Andrew Nguyen <arethusa26(a)gmail.com> wrote: > --- > tools/wine.inf.in | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > Add entry for fake wintab32.dll We have a real wintab32.dll. What are you trying to fix? Cheers, --John

2 2

Re: winhttp: tests/server.c[new]: Add basic internal server test
by Zac Brown Oct. 1, 2008

Oct. 1, 2008

Zac Brown wrote: > Add basic internal server test. Thanks to Hans for some help. > > > ------------------------------------------------------------------------ > > As a note, these tests pass on XP and 2003.

1 0

Re: wintab32: Avoid memorizing LOGCONTEXT struct
by Rob Shearman Oct. 1, 2008

Oct. 1, 2008

2008/9/30 John Klehm <xixsimplicityxix(a)gmail.com>: > + TRACE("Name: %s, Options: %x, Status: %x, Locks: %x, MsgBase: %x, Device: %x, PktRate: %x, %x%s, %x%s, %x%s, BtnDnMask: %x, BtnUpMask: %x, InOrgX: %i, InOrgY: %i, InOrgZ: %i, InExtX: %i, InExtY: %i, InExtZ: %i, OutOrgX: %i, OutOrgY: %i, OutOrgZ: %i, OutExtX: %i, OutExtY: %i, OutExtZ: %i, SensX: %i, SensY: %i, SensZ: %i, SysMode: %i, SysOrgX: %i, SysOrgY: %i, SysExtX: %i, SysExtY: %i, SysSensX: %i, SysSensY: %i\n", Even in the age of widescreen displays, a line of 421 columns in length is too long... -- Rob Shearman

2 1

Re: wininet: Add tests for InternetTimeFromSystemTimeW with insufficient buffer.
by Rob Shearman Oct. 1, 2008

Oct. 1, 2008

2008/10/1 Rob Shearman <robertshearman(a)gmail.com>: > --- > dlls/wininet/tests/http.c | 18 ++++++++++++++++++ > 1 files changed, 18 insertions(+), 0 deletions(-) > Please ignore this message. There are several problems with the patch, one of which is that the tests weren't run with Wine and currently fail. -- Rob Shearman

1 0

Marcus pictures
by Marcus Meissner Oct. 1, 2008

Oct. 1, 2008

Hi, http://gallery.kuschelt.net/main.php?g2_view=core.ShowItem&g2_itemId=163676… has my pictures of Wine Conf. Ciao, Marcus

1 0

Discussion of bug versions
by Jeremy White Oct. 1, 2008

Oct. 1, 2008

We discussed bugzilla versions at Wineconf, re: http://bugs.winehq.org/show_bug.cgi?id=12728 There were several points of consensus. First, it would be helpful if we could reduce the number of versions visible in the drop down box when entering a new bug. That would seem to require a bugzilla code change, though. Anyone know of an easy way to accomplish this? Second, we'd like new bug reporters to not be able to use the 'CVS/GIT' version choice, but to instead be encouraged to report the current version. (wine --version reports something that is easy to match up to the choices). Obviously, it seems that it would be really nice if, when we did that, it was a lot easier to find 1.1.5... Cheers, Jeremy

10 10

Re: [2/2] runtest: Let the test program handle the lack of a test name.
by Rob Shearman Oct. 1, 2008

Oct. 1, 2008

2008/9/30 Dylan Smith <dylan.ah.smith(a)gmail.com>: > -exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" "$infile" "$@" > +exec $WINETEST_WRAPPER "$topobjdir/wine" "$program" $infile $@ It looks like this will cause problems now if $infile contains spaces or if any of the arguments in $@ contain spaces. -- Rob Shearman

2 1

Re: add ctxtcall.idl (resend)
by Rob Shearman Oct. 1, 2008

Oct. 1, 2008

2008/9/28 Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk>: > Hi, this is part of bug http://bugs.winehq.org/show_bug.cgi?id=13462. > test shows the interface is available (in winxp) , test follows This patch looks good to me. -- Rob Shearman

1 0

Re: Noisy FIXME
by Rob Shearman Oct. 1, 2008

Oct. 1, 2008

2008/9/28 Dimi Paun <dimi(a)lattica.com>: > Silence noisy FIXME about uninteresting ExtTextOut() flags. > Keep the FIXME in the string to make it easily grep-able. > > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index 1e8cac3..c3e4840 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -1657,7 +1657,7 @@ BOOL WINAPI ExtTextOutW( HDC hdc, INT x, INT y, UINT flags, > breakRem = dc->breakRem; > > if (flags & (ETO_NUMERICSLOCAL | ETO_NUMERICSLATIN | ETO_PDY)) > - FIXME("flags ETO_NUMERICSLOCAL | ETO_NUMERICSLATIN | ETO_PDY unimplemented\n"); > + TRACE("FIXME: flags ETO_NUMERICSLOCAL | ETO_NUMERICSLATIN | ETO_PDY unimplemented\n"); I think the FIXME should at least by fired once since some of the flags may cause hard-to-debug display issues. -- Rob Shearman

1 0