October 2008 - Wine-Devel - list.winehq.org

Re: [PATCH] regedit: Pass VK_DELETE messages to edit controls. (try 2)
by Alexandre Julliard Oct. 8, 2008

Oct. 8, 2008

"Lei Zhang" <thestig(a)google.com> writes: > In regedit, while renaming registry keys / values, the delete key does > not work. This should fix it. > > This version increased the len variable by 1, so comparing "Edit" to > "EditX" will fail. Testing class names is almost always the wrong thing to do. Surely there's a better way to identify the edit window. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [resend] advapi32: Implement CredReadDomainCredentials stub
by James Hawkins Oct. 7, 2008

Oct. 7, 2008

On Tue, Oct 7, 2008 at 11:17 AM, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > [wasn't submitted nor rejected, so resending] > > Added CredReadDomainCredentialsA and CredReadDomainCredentialsW stub implementations. > Required for MSN Messenger 7.0 to start in WinXP mode > > --- > dlls/advapi32/advapi32.spec | 4 +- > dlls/advapi32/cred.c | 142 +++++++++++++++++++++++++++++++++++++++++++ > include/wincred.h | 39 ++++++++++++ > 3 files changed, 183 insertions(+), 2 deletions(-) > + if (TargetInformation->NetbiosServerName) len += sizeof(WCHAR) * MultiByteToWideChar(CP_ACP, 0, TargetInformation->NetbiosServerName, -1, NULL, 0); That is a seriously long line. Please try to keep line lengths close to 80 cols. + if (!TargetInformation || !Size || !Credentials || + !(TargetInformation->NetbiosServerName || TargetInformation->DnsServerName || TargetInformation->NetbiosDomainName + || TargetInformation->DnsDomainName ||TargetInformation->DnsTreeName)) + { + SetLastError(ERROR_INVALID_PARAMETER); + return FALSE; + } I don't think you should make such an implementation without at least some simple tests. -- James Hawkins

1 0

msi trouble; crashes on patchwatcher, valgrind warnings
by Dan Kegel Oct. 7, 2008

Oct. 7, 2008

Lately I've been seeing a failure of ../../../tools/runtest -q -P wine -M msi.dll -T ../../.. -p msi_test.exe.so db.c on patchwatcher on lots of runs. e.g. http://kegel.com/wine/patchwatcher/results/2598.log It kind of looks like a memory corruption: wine: Unhandled page fault on read access to 0x00000018 at address 0x60432d58 (thread 0016), starting debugger... Backtrace: =>1 0x60432d58 CompareStringW+0xe8(lcid=1033, style=0, str1=0x12e0f8, len1=10, str2=0x18, len2=0) [include/wine/unicode.h:212] in kernel32 (0x0032f048) 2 0x60432eb5 lstrcmpW+0x75(str1=?, str2=0x18) [dlls/kernel32/locale.c:2830] in kernel32 (0x0032f078) 3 0x606b47bf find_cached_table+0x3f(db=?, name=0x12e0f8) [dlls/msi/table.c:571] in msi (0x0032f098) 4 0x606b8821 get_table+0x21(db=0x12b200, name=?, table_ret=0x12da80) [dlls/msi/table.c:770] in msi (0x0032f108) 6 0x606b8e9b TABLE_CreateView+0xdb(db=0x12b200, name=?, view=0x32f9a8) [dlls/msi/table.c:2143] in msi (0x0032f148) 6 0x606bfebc sql_parse+0x6bc(info=0x32f9f8) [dlls/msi/sql.y:481] in msi (0x0032f9c8) 7 0x606c08da MSI_ParseSQL+0x4a(db=0x12b200, command=0x12e7e8, phview=0x12e330, mem=0x12e33c) [dlls/msi/sql.y:915] in msi (0x0032fa18) 8 0x60699b3d MSI_DatabaseOpenViewW+0x9d(db=0x12b200, szQuery=0x12e7e8, pView=0x32fa78) [dlls/msi/msiquery.c:135] in msi (0x0032fa48) 9 0x60699cf3 MsiDatabaseOpenViewW+0x133(hdb=1, szQuery=?, phView=0x32faec) [dlls/msi/msiquery.c:277] in msi (0x0032fa88) 10 0x6069b07a MsiDatabaseOpenViewA+0xda(hdb=1, szQuery="SELECT * FROM `IDontExist`", phView=0x32faec) [dlls/msi/msiquery.c:105] in msi (0x0032fac8) 11 0x6052f5bf do_query+0x2f(hdb=?, query=?, phrec=?) [dlls/msi/tests/db.c:148] in msi_test (0x0032faf8) 12 0x6052f94a test_droptable+0x31a() [dlls/msi/tests/db.c:6371] in msi_test (0x0032fb38) 13 0x6054bb1a func_db+0x459a() [dlls/msi/tests/db.c:6444] in msi_test (0x0032fdd8) 14 0x605f07ca run_test+0x14a(name="db.c") [dlls/msi/tests/../../../include/wine/test.h:454] in msi_test (0x0032fe18) 15 0x605f1029 main+0x149(argc=?, argv=0x1103c0) [dlls/msi/tests/../../../include/wine/test.h:503] in msi_test (0x0032fed8) 16 0x605f118b __wine_spec_exe_entry+0x5b(peb=0x7ffdf000) [dlls/winecrt0/exe_entry.c:36] in msi_test (0x0032ff08) 17 0x60449b37 start_process+0xc7(arg=(nil)) [dlls/kernel32/process.c:904] in kernel32 (0x0032ffe8) 0x60432d58 CompareStringW+0xe8 [dlls/kernel32/../../include/wine/unicode.h:212] in kernel32: cmpw $0,0x0(%eax) 212 while (*s) s++; The problem isn't particularly repeatable by hand, so I ran that test under valgrind. It seems to have a few warnings, and sure enough, they seem to be in the same function (test_droptable): Invalid read of size 4 at 0x4ABF0AE: msi_table_get_row_size (table.c:492) by 0x4AC1609: msi_update_table_columns (table.c:1037) by 0x4AC3515: TABLE_remove_column (table.c:1813) by 0x4AC3592: TABLE_drop (table.c:2064) by 0x4A8913E: DROP_execute (drop.c:60) by 0x4AA1F0D: MSI_ViewExecute (msiquery.c:456) by 0x4AA2423: MsiViewExecute (msiquery.c:482) by 0x49388A5: test_droptable (db.c:6359) by 0x4954B19: func_db (db.c:6443) by 0x49F97C9: run_test (test.h:452) by 0x49FA028: main (test.h:502) Address 0x7f01ccc0 is not stack'd, malloc'd or (recently) free'd Invalid read of size 4 at 0x4ABF0B4: msi_table_get_row_size (table.c:127) by 0x4AC1609: msi_update_table_columns (table.c:1037) by 0x4AC3515: TABLE_remove_column (table.c:1813) by 0x4AC3592: TABLE_drop (table.c:2064) by 0x4A8913E: DROP_execute (drop.c:60) by 0x4AA1F0D: MSI_ViewExecute (msiquery.c:456) by 0x4AA2423: MsiViewExecute (msiquery.c:482) by 0x49388A5: test_droptable (db.c:6359) by 0x4954B19: func_db (db.c:6443) by 0x49F97C9: run_test (test.h:452) by 0x49FA028: main (test.h:502) Address 0x7f01ccbc is not stack'd, malloc'd or (recently) free'd Invalid read of size 4 at 0x4AC1614: msi_update_table_columns (table.c:1038) by 0x4AC3515: TABLE_remove_column (table.c:1813) by 0x4AC3592: TABLE_drop (table.c:2064) by 0x4A8913E: DROP_execute (drop.c:60) by 0x4AA1F0D: MSI_ViewExecute (msiquery.c:456) by 0x4AA2423: MsiViewExecute (msiquery.c:482) by 0x49388A5: test_droptable (db.c:6359) by 0x4954B19: func_db (db.c:6443) by 0x49F97C9: run_test (test.h:452) by 0x49FA028: main (test.h:502) Address 0x7f01ccc0 is not stack'd, malloc'd or (recently) free'd Invalid free() / delete / delete[] at 0x471C5CF: RtlFreeHeap (heap.c:1315) by 0x4ABEEC2: msi_free_colinfo (msipriv.h:1074) by 0x4ABEFED: free_table (table.c:481) by 0x4AC36A9: TABLE_drop (table.c:2089) by 0x4A8913E: DROP_execute (drop.c:60) by 0x4AA1F0D: MSI_ViewExecute (msiquery.c:456) by 0x4AA2423: MsiViewExecute (msiquery.c:482) by 0x49388A5: test_droptable (db.c:6359) by 0x4954B19: func_db (db.c:6443) by 0x49F97C9: run_test (test.h:452) by 0x49FA028: main (test.h:502) Address 0x4d434923 is not stack'd, malloc'd or (recently) free'd Invalid read of size 4 at 0x4A8E415: msiobj_release (handle.c:247) by 0x4AC3613: TABLE_drop (table.c:2093) by 0x4A8913E: DROP_execute (drop.c:60) by 0x4AA1F0D: MSI_ViewExecute (msiquery.c:456) by 0x4AA2423: MsiViewExecute (msiquery.c:482) by 0x49388A5: test_droptable (db.c:6359) by 0x4954B19: func_db (db.c:6443) by 0x49F97C9: run_test (test.h:452) by 0x49FA028: main (test.h:502) Address 0x7f01ccb0 is not stack'd, malloc'd or (recently) free'd Could you have a look? (BTW this is valgrind from svn. valgrind-3.3.0 didn't give me stack dumps for some reason.) - Dan

2 1

Re: Added VGA/VESA modes. Fix Attribute Configuration FIXMEs
by Rob Shearman Oct. 7, 2008

Oct. 7, 2008

Hi Jeremiah, Thank you for your contribution to Wine. However, I have some comments about your patch: 2008/10/7 Jeremiah Flerchinger <jeremiah.flerchinger(a)gmail.com>: > Added additional VGA/VESA modes. Added missing information to VGA/VESA mode descriptions. > Used new mode information to fix attributes incorrectly set in int10.c > Moved VGA/VESA mode descriptions to vga.h, so they can be shared by emulated VGA/VESA hardware and > BIOS graphics routines. > --- > dlls/winedos/int10.c | 149 +++++++++++++++++++------------------------------ > dlls/winedos/vga.h | 90 ++++++++++++++++++++++++++++++ > 2 files changed, 148 insertions(+), 91 deletions(-) > mode change 100644 => 100755 dlls/winedos/int10.c Try not to change file modes unnecessarilly. > diff --git a/dlls/winedos/int10.c b/dlls/winedos/int10.c > old mode 100644 > new mode 100755 > index 94ea6ff..554b083 > --- a/dlls/winedos/int10.c > +++ b/dlls/winedos/int10.c > @@ -4,6 +4,8 @@ > * Copyright 1998 Ove Kven > * Copyright 1998 Joseph Pranevich > * > + * 10/2008 - Jeremiah Flerchinger - Extended VGA/VESA mode configuration support > + * The GIT changelog will tell everyone what code you have added so there is no need to state it at the top. If you feel that a significant portion of the file is your copyright now then feel free to add a copyright line similar to the others above. > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > * License as published by the Free Software Foundation; either > @@ -218,7 +155,9 @@ static const INT10_MODE *INT10_FindMode( WORD mode ) > while (ptr->Mode != 0xffff) > { > if (ptr->Mode == mode) > + { > return ptr; > + } > ptr++; > } > This change is unnecessary. > @@ -343,22 +282,34 @@ static BOOL INT10_FillModeInformation( struct _ModeInfoBlock *mib, WORD mode ) > * 13-15 - Reserved. > */ > { > - WORD attr = 0x000a; /* color mode, optional info */ > + WORD attr = 0x0002; /* set optional info available */ > + /* Enable color mode - if both Colors & Depth are 0, then assume monochrome*/ > + if (ptr->Colors || ptr->Depth) > + { > + attr |= 0x0008; > + } > > /* > * FIXME: Attribute handling is incomplete. > */ > > - /* Mode supported? FIXME: correct value */ > - attr |= 0x0001; > + /* Mode supported? */ > + if (ptr->Supported) > + { > + attr |= 0x0001; // set display mode supported C99-style comments are not portable as they don't work on some older compilers. Use "/* */" instead. .. > diff --git a/dlls/winedos/vga.h b/dlls/winedos/vga.h > index 36646a1..317b9ca 100644 > --- a/dlls/winedos/vga.h > +++ b/dlls/winedos/vga.h > @@ -3,6 +3,7 @@ > * > * Copyright 1998 Ove Kven > * > + * Please fix this spurious whitespace change. > * This library is free software; you can redistribute it and/or > * modify it under the terms of the GNU Lesser General Public > * License as published by the Free Software Foundation; either ... > +static const VESA_MODE VESA_modelist[] = Don't put data in header files. If it needs to be shared, make it non-static in the original file and add an extern declaration for it. > +{ > + /* VGA modes */ > + {0x0000, TEXT, 40, 25, 9, 16, 360, 400, 0, 16, 8, TRUE}, /* VGA text mode 0 */ > + {0x0001, TEXT, 40, 25, 9, 16, 360, 400, 0, 16, 8, TRUE}, /* VGA text mode 1 */ > + {0x0002, TEXT, 80, 25, 9, 16, 360, 400, 0, 16, 8, TRUE}, /* VGA text mode 2 */ > + {0x0003, TEXT, 80, 25, 9, 16, 360, 400, 0, 16, 8, TRUE}, /* VGA text mode 3 */ > + {0x0004, GRAPHIC, 40, 25, 8, 8, 320, 200, 2, 4, 1, FALSE}, /* VGA graphics mode 4 */ > + {0x0005, GRAPHIC, 40, 25, 8, 8, 320, 200, 2, 4, 1, FALSE}, /* VGA graphics mode 5 */ > + {0x0006, GRAPHIC, 80, 25, 8, 8, 640, 200, 1, 2, 1, FALSE}, /* VGA graphics mode 6 */ > + {0x0007, TEXT, 80, 25, 9, 16, 720, 400, 0, 0, 8, FALSE}, /* VGA text mode 7 - FIXME bad default address */ > + {0x000d, GRAPHIC, 40, 25, 8, 8, 320, 200, 4, 16, 8, FALSE}, /* VGA graphics mode 13 */ > + {0x000e, GRAPHIC, 80, 25, 8, 8, 640, 200, 4, 16, 4, FALSE}, /* VGA graphics mode 14 */ > + {0x000f, GRAPHIC, 80, 25, 8, 14, 640, 350, 0, 0, 2, FALSE}, /* VGA graphics mode 15 */ > + {0x0010, GRAPHIC, 80, 25, 8, 14, 640, 350, 4, 16, 2, FALSE}, /* VGA graphics mode 16 */ > + {0x0012, GRAPHIC, 80, 30, 8, 16, 640, 480, 1, 2, 1, FALSE}, /* VGA graphics mode 17 */ > + {0x0012, GRAPHIC, 80, 30, 8, 16, 640, 480, 4, 16, 1, FALSE}, /* VGA graphics mode 18 */ > + {0x0013, GRAPHIC, 40, 25, 8, 8, 320, 200, 8, 256, 1, TRUE}, /* VGA graphics mode 19 */ > + /* VESA 7-bit modes */ > + {0x006a, GRAPHIC, 0, 0, 0, 0, 800, 600, 4, 16, 1, TRUE}, /* VESA graphics mode, same as 0x102 */ > + /* VESA 15-bit modes */ > + {0x0100, GRAPHIC, 0, 0, 0, 0, 640, 400, 8, 256, 1, TRUE}, /* VESA graphics mode */ > + {0x0101, GRAPHIC, 0, 0, 0, 0, 640, 480, 8, 256, 1, TRUE}, /* VESA graphics mode */ > + {0x0102, GRAPHIC, 0, 0, 0, 0, 800, 600, 4, 16, 1, TRUE}, /* VESA graphics mode */ > + {0x0103, GRAPHIC, 0, 0, 0, 0, 800, 600, 8, 256, 1, TRUE}, /* VESA graphics mode */ > + {0x0104, GRAPHIC, 0, 0, 0, 0, 1024, 768, 4, 16, 1, TRUE}, /* VESA graphics mode */ > + {0x0105, GRAPHIC, 0, 0, 0, 0, 1024, 768, 8, 256, 1, TRUE}, /* VESA graphics mode */ > + {0x0106, GRAPHIC, 0, 0, 0, 0, 1280, 1024, 4, 16, 1, TRUE}, /* VESA graphics mode */ > + {0x0107, GRAPHIC, 0, 0, 0, 0, 1280, 1024, 8, 256, 1, TRUE}, /* VESA graphics mode */ > + {0x0108, TEXT, 0, 0, 0, 0, 80, 60, 0, 0, 1, TRUE}, /* VESA text mode */ > + {0x0109, TEXT, 0, 0, 0, 0, 132, 25, 0, 0, 1, TRUE}, /* VESA text mode */ > + {0x010a, TEXT, 0, 0, 0, 0, 132, 43, 0, 0, 1, TRUE}, /* VESA text mode */ > + {0x010b, TEXT, 0, 0, 0, 0, 132, 50, 0, 0, 1, TRUE}, /* VESA text mode */ > + {0x010c, TEXT, 0, 0, 0, 0, 132, 60, 0, 0, 1, TRUE}, /* VESA text mode */ > + /* VESA 1.2 modes */ > + {0x010d, GRAPHIC, 0, 0, 0, 0, 320, 200, 15, 0, 1, TRUE}, /* VESA graphics mode, 32K colors */ > + {0x010e, GRAPHIC, 0, 0, 0, 0, 320, 200, 16, 0, 1, TRUE}, /* VESA graphics mode, 64K colors */ > + {0x010f, GRAPHIC, 0, 0, 0, 0, 320, 200, 24, 0, 1, TRUE}, /* VESA graphics mode, 16.8 Million colors */ > + {0x0110, GRAPHIC, 0, 0, 0, 0, 640, 480, 15, 0, 1, TRUE}, /* VESA graphics mode, 32K colors */ > + {0x0111, GRAPHIC, 0, 0, 0, 0, 640, 480, 16, 0, 1, TRUE}, /* VESA graphics mode, 64K colors */ > + {0x0112, GRAPHIC, 0, 0, 0, 0, 640, 480, 24, 0, 1, TRUE}, /* VESA graphics mode, 16.8 Million colors */ > + {0x0113, GRAPHIC, 0, 0, 0, 0, 800, 600, 15, 0, 1, TRUE}, /* VESA graphics mode, 32K colors */ > + {0x0114, GRAPHIC, 0, 0, 0, 0, 800, 600, 16, 0, 1, TRUE}, /* VESA graphics mode, 64K colors */ > + {0x0115, GRAPHIC, 0, 0, 0, 0, 800, 600, 24, 0, 1, TRUE}, /* VESA graphics mode, 16.8 Million colors */ > + {0x0116, GRAPHIC, 0, 0, 0, 0, 1024, 768, 15, 0, 1, TRUE}, /* VESA graphics mode, 32K colors */ > + {0x0117, GRAPHIC, 0, 0, 0, 0, 1024, 768, 16, 0, 1, TRUE}, /* VESA graphics mode, 64K colors */ > + {0x0118, GRAPHIC, 0, 0, 0, 0, 1024, 768, 24, 0, 1, TRUE}, /* VESA graphics mode, 16.8 Million colors */ > + {0x0119, GRAPHIC, 0, 0, 0, 0, 1280, 1024, 15, 0, 1, TRUE}, /* VESA graphics mode, 32K colors */ > + {0x011a, GRAPHIC, 0, 0, 0, 0, 1280, 1024, 16, 0, 1, TRUE}, /* VESA graphics mode, 64K colors */ > + {0x011b, GRAPHIC, 0, 0, 0, 0, 1280, 1024, 24, 0, 1, TRUE}, /* VESA graphics mode, 16.8 Million colors */ > + {0xffff, TEXT, 0, 0, 0, 0, 0, 0, 0, 0, 1, FALSE} > +}; > + > +/* True if video mode is a vesa mode, false otherwise. > + * More correct would be to use something like (x > 0xff || x == 0x6a) > + * but as long as we have only the standard VGA and VESA modes this is ok too */ > +#define IS_VESA_MODE(x) ((x) >= 0x6a) > + In general, you want to submit many small patches instead of one larger patch. Some of the things you are doing are renames of functions or variables and so could be done independently of functional changes. This will make the patch easier to review and hence more likely to get in quickly. -- Rob Shearman

1 0

Re: [1/5] di32: Call AbortProc from StartDoc instead of EndPage
by Henri Verbeet Oct. 7, 2008

Oct. 7, 2008

That should read "gdi32" instead of "di32", of course.

1 0

New Coverity run Oct 1st. 58 fixed, 41 new warnings in cabinet, jscript, mshtml, wined3d, and code generated by widl
by Dan Kegel Oct. 7, 2008

Oct. 7, 2008

Thanks to the half-dozen Wine developers attacking the Coverity warnings, we are slowly making progress. Here are the warnings that were new as of October 1st and which have not yet been classified. They fall into five areas (four DLLs and one kind of generated code): CID Checker Func File 765 FORWARD_NULL FDICopy dlls/cabinet/fdi.c 766 FORWARD_NULL FDICopy dlls/cabinet/fdi.c 770 NULL_RETURNS alloc_array dlls/jscript/array.c 771 NULL_RETURNS Array_sort dlls/jscript/array.c 773 NULL_RETURNS JScriptFactory_CreateInstance dlls/jscript/jscript.c 779 REVERSE_INULL JScript_Close dlls/jscript/jscript.c 780 REVERSE_INULL JScript_Close dlls/jscript/jscript.c 772 NULL_RETURNS alloc_number dlls/jscript/number.c 768 FORWARD_NULL EmitREBytecode dlls/jscript/regexp.c 767 FORWARD_NULL _test_elem_getelembytag dlls/mshtml/tests/dom.c 509 FORWARD_NULL drawStridedSlow dlls/wined3d/drawprim.c 781 REVERSE_INULL __finally_IEnumFORMATETC_RemoteNext_Stub dlls/ole32/ole32_objidl_p.c 782 REVERSE_INULL __finally_IEnumMoniker_RemoteNext_Stub dlls/ole32/ole32_objidl_p.c 783 REVERSE_INULL __finally_IEnumSTATDATA_RemoteNext_Stub dlls/ole32/ole32_objidl_p.c 784 REVERSE_INULL __finally_IEnumUnknown_RemoteNext_Stub dlls/ole32/ole32_objidl_p.c 785 REVERSE_INULL __finally_IDispatch_RemoteInvoke_Stub dlls/oleaut32/oleaut32_oaidl_p.c 786 REVERSE_INULL __finally_IEnumVARIANT_RemoteNext_Stub dlls/oleaut32/oleaut32_oaidl_p.c 787 REVERSE_INULL __finally_ITypeInfo_RemoteGetNames_Stub dlls/oleaut32/oleaut32_oaidl_p.c 788 REVERSE_INULL __finally_ITypeLib_RemoteFindName_Stub dlls/oleaut32/oleaut32_oaidl_p.c 789 REVERSE_INULL __finally_IEnumConnectionPoints_RemoteNext_Stub dlls/oleaut32/oleaut32_ocidl_p.c 790 REVERSE_INULL __finally_IEnumConnections_RemoteNext_Stub dlls/oleaut32/oleaut32_ocidl_p.c 791 REVERSE_INULL __finally_IEnumOleUndoUnits_RemoteNext_Stub dlls/oleaut32/oleaut32_ocidl_p.c 792 REVERSE_INULL __finally_IPropertyPage_SetObjects_Stub dlls/oleaut32/oleaut32_ocidl_p.c 774 REVERSE_INULL __finally_IEnumBackgroundCopyFiles_Next_Stub dlls/qmgrprxy/qmgrprxy_p.c 775 REVERSE_INULL __finally_IEnumBackgroundCopyJobs_Next_Stub dlls/qmgrprxy/qmgrprxy_p.c 793 REVERSE_INULL __finally_IServer_sum_padded2 dlls/rpcrt4/tests/server_s.c 794 REVERSE_INULL __finally_IServer_sum_padded_conf dlls/rpcrt4/tests/server_s.c 776 REVERSE_INULL __finally_epm_ept_delete programs/rpcss/epm_s.c 777 REVERSE_INULL __finally_epm_ept_insert programs/rpcss/epm_s.c 778 REVERSE_INULL __finally_epm_ept_lookup programs/rpcss/epm_s.c For more info, see http://wiki.winehq.org/StaticAnalysis

3 2

Re: gdi32: Fix for capella problem with codepages in symbol fonts
by Dmitry Timoshkov Oct. 7, 2008

Oct. 7, 2008

"Stefan Ziel" <stefan.ziel(a)terra.com.br> wrote: > Ignore characterset bit for symbol fonts > - if(!TranslateCharsetInfo((DWORD*)(INT_PTR)lf.lfCharSet, &csi, TCI_SRCCHARSET)) { > + if (lf.lfCharSet == SYMBOL_CHARSET){ > + /* codepage for symbol is not definied -> ignore it */ > + csi.fs.fsCsb[0] = 0; This patch is obviously wrong, TranslateCharsetInfo does handle SYMBOL_CHARSET, and code page for symbol *is* defined. In any case the first thing to do is write a test case. -- Dmitry.

2 3

Re: msi: Added MsiInstallMissingComponentW stub implementation.
by Kai Blin Oct. 7, 2008

Oct. 7, 2008

On Monday 06 October 2008 23:05:25 Jacek Caban wrote: > +UINT WINAPI MsiInstallMissingComponentW(LPCWSTR szProduct, LPCWSTR ... > 83 stub MsiInstallMissingComponentA > -84 stub MsiInstallMissingComponentW > +84 stdcall MsiInstallMissingComponentW(wstr wstr long) ... > diff --git a/include/msi.h b/include/msi.h > index 20dca3a..cf125ef 100644 > --- a/include/msi.h > +++ b/include/msi.h > @@ -603,6 +603,10 @@ UINT WINAPI MsiDatabaseMergeA(MSIHANDLE, MSIHANDLE, > LPCSTR); UINT WINAPI MsiDatabaseMergeW(MSIHANDLE, MSIHANDLE, LPCWSTR); > #define MsiDatabaseMerge WINELIB_NAME_AW(MsiDatabaseMerge) > > +UINT WINAPI MsiInstallMissingComponentA(LPCSTR, LPCSTR, INSTALLSTATE); > +UINT WINAPI MsiInstallMissingComponentW(LPCWSTR, LPCWSTR, INSTALLSTATE); > +#define MsiInstallMissingComponent WINELIB_NAME_AW(MsiInstallMissingComponent) + Isn't this going to break if an app is trying to use Ansi MsiInstallMissingComponent? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: [PATCH 08/17] mshtml: Added IHTMLStyle::[get|put]_borderimplementation.
by Alistair Leslie-Hughes Oct. 7, 2008

Oct. 7, 2008

Hi Jacek, >static HRESULT WINAPI HTMLStyle_put_border(IHTMLStyle *iface, BSTR v)> {> HTMLStyle *This = HTMLSTYLE_THIS(iface);>- FIXME("(%p)->(%s)\n", This, debugstr_w(v));>- return E_NOTIMPL;>+>+ TRACE("(%p)->(%s)\n", This, debugstr_w(v));>+>+ return set_style_attr(This, STYLEID_BORDER, v, 0);> } My sample code style->put_border(L"groove 5"); produced <BODY style="BORDER-RIGHT: 5px groove; BORDER-TOP: 5px groove; BORDER-LEFT: 5px groove; BORDER-BOTTOM: 5px groove" /BODY> Will gecko expand "border" to the above? Best Regards Alistair Leslie-Hughes _________________________________________________________________

2 1

Re: [try 2] [6/9] Add usbd.sys.
by winepatches＠kegel.com Oct. 7, 2008

Oct. 7, 2008

amorozov wrote: > Changed as directed Rob Shearman. Please use this instead of previous > version of [6/9] patch. Patchwatcher doesn't know what to do with partial resends yet (eventually it will ignore them). At the moment I have to delete them manually, else patchwatcher gets confused and waits for the rest of the series. - Dan

2 1