November 2008 - Wine-Devel - list.winehq.org

IMM / IME work
by Aric Stewart June 16, 2016

June 16, 2016

Hello all, I know this will only interest a small portion of you but thought i would give a quick update on the state of IMM32 since I have brought it to a major milestone. All the main patches are in which now separate IMM32 and IMEs. There is still more work to do but the major framework is in place. X11 XIM processing should be unchanged. However wine can now begin to load native windows IMEs as well. I have tested with windows ATOK20 (a popular Japanese IME) and successfully had text processing in a fully IME aware application. There are still clear issues to resolve in many aspects of this processing but we have forward progress. ImmInstallIME does not work yet, nor does switching keyboards. So to get the native IME to work you need to add this registry key. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\<keyboard layout>] "Ime File"=<IME filename> so for example for ATOK20 in Japanese i used. [System\\CurrentControlSet\\Control\\Keyboard Layouts\\e0010411] "Ime File"="ATOK20W.IME" I would love to hear how well things work. I am sure using native IMEs will quickly show us many places where IMM32 needs to be improved. One issues I am going to investigate next is that sometimes non x11drv ime initialization, if occurring too early, causes x11drv to fail to create windows. I have not investigated with the latest changes to xim.c (which may already correct this problem) but if you see this problem this patch may help and i believe the IME_UpdateAssociation(NULL) is already unneeded. diff --git a/dlls/winex11.drv/xim.c b/dlls/winex11.drv/xim.c index d4df9f7..0c98136 100644 --- a/dlls/winex11.drv/xim.c +++ b/dlls/winex11.drv/xim.c @@ -475,7 +475,6 @@ static void X11DRV_OpenIM(Display *display, XPointer ptr, XP XUnregisterIMInstantiateCallback(display, NULL, NULL, NULL, X11DRV_OpenIM, wine_tsx11_unlock(); IME_XIMPresent(TRUE); - IME_UpdateAssociation(NULL); } thanks, -aric

5 7

What happened to the Fedora packages?
by Neal Gompa Aug. 2, 2014

Aug. 2, 2014

What happened to the Fedora packages? They have not been updated since 0.9.2!!!! Right now it is at 0.9.10!!! Nearly every other Linux distro supported has the up to date packages!!! And why does the Red Hat packages site not go to the SourceForge site as it does for SUSE packages and the others?? I have not really had the guts to ask until now, because I thought that maybe there was a slump, but now, its getting annoying!! And Fedora just released Fedora Core 5 yesterday!!! Please tell me new packages will be ready soon!!! Compiling WINE always crashes my computer, so I prefer to use the RPMs...

10 18

winspool: ERROR_INVALID_NAME in GetDefaultPrinter() ?
by Detlef Riekenberg Oct. 9, 2013

Oct. 9, 2013

Hi. >From which configuration does the "ERROR_INVALID_NAME" came from, when calling GetDefaultPrinter(NULL, &size) and no Printer is installed? This Test is Present in the current "dlls/winspool/tests/info.c". MSDN told us, that we receive an "ERROR_FILE_NOT_FOUND", if no Printer is installed: http://msdn.microsoft.com/library/en-us/gdi/prntspol_0hma.asp I get the "ERROR_FILE_NOT_FOUND" on win98se, winme, w2k and win2003 in this Situation. -- By By ... ... Detlef

3 3

re: Wine t-shirts?
by Dan Kegel Sept. 2, 2009

Sept. 2, 2009

Maarten wrote: > Why don't we have wine t-shirts any more? I dunno, where were they before? I just looked, couldn't find any on cafepress.com. I'd like to bring back the Codeweavers drunken penguin t-shirts, perhaps with a slightly more generic Wine design. Coincidentally, I found some site on the net had taken the logo from that shirt and erased the Crossover logo from the wine bottle; here's a cleaned-up copy: http://kegel.com/wine/wine-penguin-corkscrew.png

15 34

winequartz.drv Mac OS X UI discontinued?
by Adam Strzelecki July 11, 2009

July 11, 2009

Hi, I know that CodeWeavers supports quite nicely Mac builds of Wine, and CrossOver for Mac, yet all of them are X11. There was also once Darwine - an effort to provide Carbon Wine UI driver and Mac optimizations & L&F. Pretty many of those were merged back to Wine, but not winequartz.drv. Do you guys think about reviving winequartz.drv? This would greatly improve Wine on Mac as we could have native Mac fonts handling that's faster than FreeType, Dock icons for Wine applications, and few others. There's still old copy of the it hanging around, but it is abandoned, and no longer compiles with Wine. Or I think it would be cool to write new winecocoa.drv or sthing like that, as Apple officially states that Carbon is deprecated. While it is not well documented, it is pretty easy with Cocoa to make console non-bundled process to be UI foreground process and handle events and Dock: (This code is copyrighted by myself ;P) > int main(int argc, const char * argv[]) { > ProcessSerialNumber psn = {0, kCurrentProcess}; > OSStatus returnCode = TransformProcessType(&psn, > kProcessTransformToForegroundApplication); > SetFrontProcess(&psn); > > NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init]; > [NSApplication sharedApplication]; > > NSImage *icon = [NSImage imageNamed:@"NSApplicationIcon"]; > [NSApp setApplicationIconImage:icon]; > > [NSApp finishLaunching]; > > NSWindow *window = [[NSWindow alloc] > initWithContentRect:NSMakeRect(0, 0, 100, 100) > styleMask:NSTitledWindowMask| > NSClosableWindowMask|NSMiniaturizableWindowMask|NSResizableWindowMask > backing:NSBackingStoreBuffered defer:NO]; > [window center]; > [window setTitle:@"Test"]; > > NSButton *button = [[NSButton alloc] > initWithFrame:NSMakeRect(10, 10, 80, 80)]; > [button setTitle:@"What?"]; > [button setBezelStyle:1]; > [[window contentView] addSubview:button]; > [button release]; > > [window makeKeyAndOrderFront:NSApp]; > > while(1) { > NSEvent *event = [NSApp > nextEventMatchingMask:NSAnyEventMask > untilDate > :[NSDate distantFuture] > inMode:NSDefaultRunLoopMode > dequeue:YES > ]; > if(event) [NSApp sendEvent:event]; > } > [pool release]; > return 0; > } BTW. I heard that someone previously working for Wine project is now in Apple, it is true? Regards, -- Adam Strzelecki |: nanoant.com :|

20 55

Wine desktop integration: current directory of app launched with doubleclick?
by Dan Kegel Feb. 15, 2009

Feb. 15, 2009

I *almost* have a great success story to report; the only thing keeping it from being a success story is the current directory chosen by Nautilus when double-clicking on .exe files. My wife hurt a finger trying to impersonate a Sampsonite Luggage gorilla, and had to go to a hand doctor. Along the way her hand got x-rayed, and the doctor handed her a cd-rom with the x-ray pictures on it. The disc has an autorun.inf on it that should start ViewSel.exe. I don't know if that's supposed to work with Wine and Nautilus, but probably doubleclicking on ViewSel.exe does the same thing. ViewSel.exe puts up two big buttons: low res (which launches a web browser on an html file), and high res (which launches a DICOM viewer). If you cd to the root of the cd-rom drive and run ViewSel, it works. If the current directory is anything else, it doesn't work. If you start the autorun app via Nautilus, those buttons don't work, so presumably it sets the current directory to something other than the root of the drive. To see, I created a wrapper shell script, ~/bin/mywine, containing #!/bin/sh pwd > /tmp/log and used "Start with" to launch ViewSel.exe with ~/bin/mywine. This showed that the current directory was $HOME. I had a look at the gnome code to see how it decided, but it was a bit hard to follow. (See gnome_vfs_mime_application_launch_with_env.) So I tried a little shell magic. I created a new wrapper shell script that assumes the argument is a path to a file, and sets the current directory to the directory containing that file: #!/bin/sh DIR=`dirname "$1"` DIR=`cd "$DIR"; pwd` cd "$DIR" wine "$@" That worked better; it let ViewSel.exe launch the DICOM viewer. So... I suppose the next step is to look at the debian/ubuntu packages for wine and see if that little wrapper script could be incorporated into the default way file browsers start wine? It sure would be nice if apps that expected the current directory to behave like this (it's not uncommon!) Just Worked. - Dan

4 9

Re: [5/9] Add support of WDM drivers for USB devices.
by Alexandre Julliard Jan. 20, 2009

Jan. 20, 2009

Alexander Morozov <amorozov(a)etersoft.ru> writes: > From ed6e12ca39e194829ad8d6be4fbd91d9f276d435 Mon Sep 17 00:00:00 2001 > From: Alexander Morozov <amorozov(a)etersoft.ru> > Date: Fri, 3 Oct 2008 17:57:00 +0400 > Subject: [PATCH] Add support of WDM drivers for USB devices. > > --- > configure.ac | 14 ++ > dlls/wineusbhub/Makefile.in | 15 ++ > dlls/wineusbhub/wineusbhub.c | 291 +++++++++++++++++++++++++++++++++++++++ > dlls/wineusbhub/wineusbhub.spec | 7 + > programs/winedevice/Makefile.in | 2 +- > programs/winedevice/device.c | 79 +++++++++++- > programs/wineusb/Makefile.in | 15 ++ > programs/wineusb/main.c | 224 ++++++++++++++++++++++++++++++ > server/device.c | 111 +++++++++++++++ > server/protocol.def | 16 ++ > tools/wine.inf.in | 10 ++ > 11 files changed, 782 insertions(+), 2 deletions(-) Your design needs a lot more thought. You can't add all these Wine-specific modules, or make winedevice special-case usb devices, or poll the server for the add_device request like you do. All this needs to be properly integrated in the existing infrastructure. -- Alexandre Julliard julliard(a)winehq.org

2 1

re: Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes
by Dan Kegel Jan. 15, 2009

Jan. 15, 2009

FWIW, my opinion is that any deep integration is going to be hard, and that for the moment we should go with something much simpler: simply support mstheme files well, and provide themes that look like the default themes on Ubuntu / OpenSuse / Fedora.

6 15

Valgrind warning in wined3d/swapchain.c in IWineD3DSwapChainImpl_Destroy
by Dan Kegel Dec. 23, 2008

Dec. 23, 2008

Hi Stefan, you seem to have been in this code recently, could you have a look? This is a somewhat flaky error that happens about 80% of the time under heavy load on my quad core box. (This is valgrind's xml output format, it's pretty fluffy, sorry.) Thanks, Dan <error> <kind>UninitCondition</kind> <what>Conditional jump or move depends on uninitialised value(s)</what> <stack> <frame> <obj>dlls/wined3d/wined3d.dll.so</obj> <fn>IWineD3DSwapChainImpl_Destroy</fn> <dir>dlls/wined3d</dir> <file>swapchain.c</file> <line>75</line> </frame> <frame> <obj>dlls/d3d9/d3d9.dll.so</obj> <fn>IDirect3DSwapChain9Impl_Release</fn> <dir>dlls/d3d9</dir> <file>swapchain.c</file> <line>66</line> </frame> <frame> <obj>dlls/d3d9/d3d9.dll.so</obj> <fn>D3D9CB_DestroySwapChain</fn> <dir>dlls/d3d9</dir> <file>directx.c</file> <line>427</line> </frame> <frame> <obj>dlls/wined3d/wined3d.dll.so</obj> <fn>IWineD3DDeviceImpl_Uninit3D</fn> <dir>dlls/wined3d</dir> <file>device.c</file> <line>2426</line> </frame> <frame> <obj>dlls/d3d9/d3d9.dll.so</obj> <fn>IDirect3DDevice9Impl_Release</fn> <dir>dlls/d3d9</dir> <file>device.c</file> <line>98</line> </frame> <frame> <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj> <fn>func_visual</fn> <dir>dlls/d3d9/tests</dir> <file>visual.c</file> <line>9960</line> </frame> <frame> <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj> <fn>run_test</fn> <dir>dlls/d3d9/tests/../../../include/wine</dir> <file>test.h</file> <line>452</line> </frame> <frame> <obj>dlls/d3d9/tests/d3d9_test.exe.so</obj> <fn>main</fn> <dir>dlls/d3d9/tests/../../../include/wine</dir> <file>test.h</file> <line>502</line> </frame> </stack> </error>

2 1

RFC: Proposed new web site design
by Jeremy White Dec. 22, 2008

Dec. 22, 2008

At Wineconf, we made the decision to change the entry page to the Wine web site. The hope was to simplify and stream line it, and to put in place the infrastructure to start moving more content to the Wiki. Jeremy Newman and Jon Parshall have put a lot of time and energy into a proposed new design, following what we took away from the meetings at Wineconf. A mock up of that design is up now here: http://wine.codeweavers.com/winehq_new/ ...and the theming intended for all 'child' pages of the web site, starting with the Wiki: http://wine.codeweavers.com/winehq_new/wiki.html Beyond the normal controversy that any new design sparks there is one major potential controversial change. That is, I am asking for prime placement on the download page on behalf of CodeWeavers instead of the (stale and ugly, sorry) banner ads we used in the past. You can see our current concept around that positioning here: http://wine.codeweavers.com/winehq_new/download.html I hope that the general community sees that as a reasonable exchange for all of the work we put into Wine and hosting the Wine server, and a vast improvement over the banner ads. At any rate, comments and feedback are welcome. And in a vain attempt to prevent all the flames from scorching Jon and Jeremy, I'd like to officially state how much I appreciate their efforts. Cheers, Jeremy

19 32

Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes
by Reece Dunn Dec. 20, 2008

Dec. 20, 2008

Hi, There is a discussion going on over at https://bugs.launchpad.net/ubuntu/+source/wine/+bug/111061 about improving Wine's look and feel to better match the system that it is running on. The situation is as follows: == Colour Schemes Wine supports these by reading the settings from the registry. Winecfg can load a .theme file containing a colour profile and adapt accordingly (saving those settings to the registry). At the moment, if you need to script this (e.g. when installing Wine) you need to manipulate the registry. It would be helpful if winecfg (or some other helper utility) supported setting the theme file on the command line. In addition to this, if the user changes the theme used on their system it would not be reflected by Wine. == Windows Theme Support Windows theming support is in place to some extent, w.r.t. the XP theming APIs. There are some user32 controls and the window/dialog handlers that don't support theming yet and there are some performance issues that need resolving. This would be set via the command line used to set the colour scheme since they can be set via the same .theme file. This is limited in that you need an XP theme for each native theme available. == Native Theme Support The main thing here is that Wine would monitor the native system for theme changes. The colours of the native theme would be mapped to the Windows system colours, saved to the registry and then a WM_SYSCOLORCHANGED message would be sent to all open top-level windows so they could update to the new look. Any metric data would be mapped in a similar way. As for the theme, an implementation of uxtheme would map the API calls to the native calls. Here, it may be possible to just send a request to redraw everything on each active window. If not, a WM_THEMECHANGED message would need to be sent to all active windows. The challenge with native theme support is two-fold: (1) it should work on any system - some have Gtk, some Qt and some Cocoa/Carbon, while others (like the *BSDs and OpenSolaris) are likely not to have those engines available; (2) it should not break any Windows application. Note that as Vista has a different msstyles theming engine (it is a DLL), we could have the msstyles DLL expose the uxtheme API and have uxtheme call msstyles to do the rendering. That way, we could have a gtk.msstyles, qt3.msstyles, qt4.msstyles and an carbon.msstyles that would bind to the corresponding theming engine. If the msstyles DLL does not expose those methods, the uxtheme engine could then fallback to the current XP theme processing. For Mac theme support that would possibly require Objective-C code to be done properly, that theme could be an external package (possibly in darwine) that would be installed in addition to Wine. The same thing for the Qt engines, allowing them to directly interface with the C++ Qt APIs. Thoughts? Ideas? - Reece

7 19

No response to updated patch for gdi32/StretchDIBits
by Mathias Kosch Dec. 13, 2008

Dec. 13, 2008

Hallo! About two weeks ago I tried to hand in a (corrected version of my) patch for "StretchDIBits" [1]. However it isn't accepted until now and I didn't yet notice any response. Would someone please tell me what's wrong or if it was just missed out accidentally? [1] http://www.winehq.org/pipermail/wine-patches/2008-September/062221.html -- Mathias Kosch <info(a)mkosch.de> | http://www.mkosch.de/ RSA Public Key: http://www.mkosch.de/pubkey Roboter zum selber bauen: http://www.heise.de/ct/projekte/ct-bot/

2 2

winetest.exe now available on test.winehq.org
by Paul Vriens Dec. 1, 2008

Dec. 1, 2008

Hi, Test.winehq.org is the new home of the cross compiled winetest.exe. Alexandre put in some magic to create the new winetest.exe on winehq. The new link: http://test.winehq.org/builds/winetest-latest.exe The link can also be found at the bottom of the test.winehq.org index page. I already changed the wiki to reflect these changes. This also means that Paul Millars winetest is no longer available. I'd like to thank Paul for all the hard work he did with keeping up that site and providing us for years with a cross compiled version of winetest. I also like to thank the people that provided the necessary MinGW patches in the past to get that winetest compiled again. -- Cheers, Paul.

2 1

Bugzilla's down again
by Austin English Dec. 1, 2008

Dec. 1, 2008

Different error than usual though: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html><head> <title>500 Internal Server Error</title> </head><body> <h1>Internal Server Error</h1> <p>The server encountered an internal error or misconfiguration and was unable to complete your request.</p> <p>Please contact the server administrator, bugs-admin(a)winehq.org and inform them of the time the error occurred, and anything you might have done that may have caused the error.</p> <p>More information about this error may be available in the server error log.</p> </body></html> Is there anything we can do to prevent it from going down so much? -- -Austin

3 3

Re: wined3d: Sign-compare warnings fix
by Austin English Dec. 1, 2008

Dec. 1, 2008

On Sat, Nov 29, 2008 at 11:42 AM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Changelog: > wined3d: Sign-compare warnings fix. > > @@ -504,7 +504,7 @@ static void shader_generate_glsl_declarations(IWineD3DBaseShader *iface, const s > IWineD3DBaseShaderImpl* This = (IWineD3DBaseShaderImpl*) iface; > IWineD3DDeviceImpl *device = (IWineD3DDeviceImpl *) This->baseShader.device; > int i; > - unsigned int extra_constants_needed = 0; > + unsigned int i, extra_constants_needed = 0; > const local_constant *lconst; > > /* There are some minor differences between pixel and vertex shaders */ > > > You forgot to remove 'int i' here. -- -Austin

2 1

Error Message and Office 2000
by SWEETSKY＠ROCKETMAIL.COM Dec. 1, 2008

Dec. 1, 2008

Hi, I'm in Southern California. I did a search for the event when my Office 2000 Professional gave me an error message. It won't setup. The event was 1000 and the fault address is the same as a read out of your computer that you posted online. http://www.winehq.org/pipermail/wine-devel/2003-July/018313.html Did you ever figure out how to get it to work? Thanks! Ciao! Connie

2 1

Sound regression (in Warcraft III)
by Adam Petaccia Nov. 30, 2008

Nov. 30, 2008

Maarten, could you look at http://bugs.winehq.org/show_bug.cgi?id=16297 as you're the author of 717df5b2972b3cb998ca5a43279ae2283b117eaa? I tried adding you as CC but bugzilla complained.

2 1

Re: Fw: selinux in fedora 10 regarding text relocation in wine and mono.
by Hin-Tak Leung Nov. 30, 2008

Nov. 30, 2008

Hi all, I had managed to fix my selinux/wine/mono problem in fedora 10... it is actually two issues, in fact: 1) fedora 10 ships some much stricter selinux policies (but make some exception for wine). 2) I have kernel support for miscellaneous binary formats enabled and have win32 PE registration in the kernel, and run win32 mono.exe (or other PE executables) direct from time to time. so "wine [path]/mono.exe [.NET.exe]" works within the restriction of f10 selinux policies, but "[path]/mono.exe [.NET.exe]" does not. I could either relax the "execmod" policy in selinux, if I want to run any PE .exe's wholesale; or I just need to remember always putting "wine" in front of PE .exe's I want to run... Sorry for the noise.

1 0

Did anyone have any trouble compiling wine today? Or was it just me ....
by Susan Cragin Nov. 30, 2008

Nov. 30, 2008

and my jaunty jackalope with 2.6.27-7 generic kernel MAKE gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o serial.o serial.c In file included from serial.c:77: /usr/include/linux/serial.h:164: error: expected specifier-qualifier-list before ‘__u32’ make[2]: *** [serial.o] Error 1 make[2]: Leaving directory `/home/susan/wine/dlls/ntdll' make[1]: *** [ntdll] Error 2 make[1]: Leaving directory `/home/susan/wine/dlls' make: *** [dlls] Error 2 INSTALL make[2]: Leaving directory `/home/susan/wine/dlls/newdev' make[2]: Entering directory `/home/susan/wine/dlls/ntdll' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o serial.o serial.c In file included from serial.c:77: /usr/include/linux/serial.h:164: error: expected specifier-qualifier-list before ‘__u32’ make[2]: *** [serial.o] Error 1 make[2]: Leaving directory `/home/susan/wine/dlls/ntdll' make[1]: *** [ntdll/__install__] Error 2 make[1]: Leaving directory `/home/susan/wine/dlls' make: *** [dlls/__install__] Error 2

3 2

Re: includes: Fix macros for ITextServices
by Dylan Smith Nov. 30, 2008

Nov. 30, 2008

The problems with having the macros in the public headers are that they won't work on x86 machines, and are not included in the public headers. Therefore someone developing for another platform will have their code break when using the native public headers or when porting the code to an x86 where the thiscall calling convention is used. On Sun, Nov 30, 2008 at 5:42 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com>wrote: > Commit e4ef9c5c removed the ITextServices macros from > wine/include/textserv.h. With this they are added again, and COBJMACROS > before including that header, so that they won't conflict. > --- > > From c04fcab5168309395602f4c4fd07a319a9a532ab Mon Sep 17 00:00:00 2001 > From: Maarten Lankhorst <maarten(a)codeweavers.com> > Date: Sun, 30 Nov 2008 11:37:54 +0100 > Subject: [PATCH] includes: Fix macros for ITextServices > > --- > dlls/riched20/tests/txtsrv.c | 8 +++++++- > include/textserv.h | 19 +++++++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletions(-) > > diff --git a/dlls/riched20/tests/txtsrv.c b/dlls/riched20/tests/txtsrv.c > index 3d47490..c28f5a7 100644 > --- a/dlls/riched20/tests/txtsrv.c > +++ b/dlls/riched20/tests/txtsrv.c > @@ -29,6 +29,9 @@ > #include <objbase.h> > #include <richedit.h> > #include <initguid.h> > + > +#undef COBJMACROS > +/* Don't define ITextServices, we override it here */ > #include <textserv.h> > #include <wine/test.h> > > @@ -44,6 +47,9 @@ static HMODULE hmoduleRichEdit; > #define TXTSERV_VTABLE(This) (This)->lpVtbl > #endif /* __i386__ */ > > +#define ITextServices_QueryInterface(p,a,b) > (p)->lpVtbl->QueryInterface(p,a,b) > +#define ITextServices_AddRef(p) (p)->lpVtbl->AddRef(p) > +#define ITextServices_Release(p) (p)->lpVtbl->Release(p) > #define ITextServices_TxSendMessage(This,a,b,c,d) > TXTSERV_VTABLE(This)->TxSendMessage(This,a,b,c,d) > #define ITextServices_TxDraw(This,a,b,c,d,e,f,g,h,i,j,k,l) > TXTSERV_VTABLE(This)->TxDraw(This,a,b,c,d,e,f,g,h,i,j,k,l) > #define ITextServices_TxGetHScroll(This,a,b,c,d,e) > TXTSERV_VTABLE(This)->TxGetHScroll(This,a,b,c,d,e) > @@ -84,7 +90,7 @@ static HRESULT WINAPI > ITextHostImpl_QueryInterface(ITextHost *iface, > > if (IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, > &IID_ITextHost)) { > *ppvObject = This; > - ITextHost_AddRef((ITextHost *)*ppvObject); > + IUnknown_AddRef((IUnknown *)*ppvObject); > return S_OK; > } > > diff --git a/include/textserv.h b/include/textserv.h > index 977b742..820fc0a 100644 > --- a/include/textserv.h > +++ b/include/textserv.h > @@ -147,6 +147,25 @@ DECLARE_INTERFACE_(ITextServices,IUnknown) > #define ITextServices_QueryInterface(p,a,b) > (p)->lpVtbl->QueryInterface(p,a,b) > #define ITextServices_AddRef(p) (p)->lpVtbl->AddRef(p) > #define ITextServices_Release(p) (p)->lpVtbl->Release(p) > +/*** ITextServices methods ***/ > +#define ITextServices_TxSendMessage(p,a,b,c,d) > (p)->lpVtbl->TxSendMessage(p,a,b > +#define ITextServices_TxDraw(p,a,b,c,d,e,f,g,h,i,j,k,l) > (p)->lpVtbl->TxDraw(p,a > +#define ITextServices_TxGetHScroll(p,a,b,c,d,e) > (p)->lpVtbl->TxGetHScroll(p,a,b > +#define ITextServices_TxGetVScroll(p,a,b,c,d,e) > (p)->lpVtbl->TxGetVScroll(p,a,b > +#define ITextServices_OnTxSetCursor(p,a,b,c,d,e,f,g,h,i) > (p)->lpVtbl->OnTxSetCu > +#define ITextServices_TxQueryHitPoint(p,a,b,c,d,e,f,g,h,i,j) > (p)->lpVtbl->TxQue > +#define ITextServices_OnTxInplaceActivate(p,a) > (p)->lpVtbl->OnTxInplaceActivate > +#define ITextServices_OnTxInplaceDeactivate(p) > (p)->lpVtbl->OnTxInplaceDeactiva > +#define ITextServices_OnTxUIActivate(p) (p)->lpVtbl->OnTxUIActivate(p) > +#define ITextServices_OnTxUIDeactivate(p) (p)->lpVtbl->OnTxUIDeactivate(p) > +#define ITextServices_TxGetText(p,a) (p)->lpVtbl->TxGetText(p,a) > +#define ITextServices_TxSetText(p,a) (p)->lpVtbl->TxSetText(p,a) > +#define ITextServices_TxGetCurrentTargetX(p,a) > (p)->lpVtbl->TxGetCurrentTargetX > +#define ITextServices_TxGetBaseLinePos(p,a) > (p)->lpVtbl->TxGetBaseLinePos(p,a) > +#define ITextServices_TxGetNaturalSize(p,a,b,c,d,e,f,g,h) > (p)->lpVtbl->TxGetNat > +#define ITextServices_TxGetDropTarget(p,a) > (p)->lpVtbl->TxGetDropTarget(p,a) > +#define ITextServices_OnTxPropertyBitsChange(p,a,b) > (p)->lpVtbl->OnTxPropertyBi > +#define ITextServices_TxGetCachedSize(p,a,b) > (p)->lpVtbl->TxGetCachedSize(p,a,b > #endif > > #undef INTERFACE > -- > 1.5.6.5 > > > > >

1 0

Re: winedos: Fixed a problem with timer values that are below 50ms.
by Michael Stefaniuc Nov. 30, 2008

Nov. 30, 2008

Hello Peter, Peter Dons Tychsen wrote: > Fixed a problem with timer values that are smaller than the minimum time > that can be assigned to the SetTimer() win32 call (approx 50ms). The > patch splits up the timer into several interrupts if too long time has > passed.This fixes good old OutRun, which uses timers of approx 10ms. As > a bonus, this aalso fixes situations where we have fallen behind for > other reasons. your patch introduces a lot of dangling whitespace at the end of lines. bye michael

4 5

today's git does not compile with yesterday's new gcc -- regression test results
by Susan Cragin Nov. 30, 2008

Nov. 30, 2008

I did the regression test. But how legitimate are the results if the problem is the new gcc that I downloaded recently, and not wine? gcc (Ubuntu 4.3.2-2ubuntu5) 4.3.3 20081129 (prerelease) susan(a)ubuntu:~/wine$ git bisect bad Bisecting: 0 revisions left to test after this [0b7478a79fb0594daba5cee3c0288884c352ad39] widl: Make sure format strings for structure and union types are only output once. Susan

3 2

Help need list of wine git versions
by Susan Cragin Nov. 30, 2008

Nov. 30, 2008

Need the number of the current git because am doing regression on it, because it doesn't compile on my machine using my gcc. gcc (Ubuntu 4.3.2-2ubuntu5) 4.3.3 20081129 (prerelease) (And BTW can the regression test page link to this page?) Thank you very much. Susan

3 2

Fw: selinux in fedora 10 regarding text relocation in wine and mono.
by Hin-Tak Leung Nov. 29, 2008

Nov. 29, 2008

I sent this a few days ago from my "other" e-mail alias and it hasn't come back, so it probably got lost in the spam-filtering - anybody has similiar issue? > So I have upgraded to fedora 10... now when I run wine with > mono for some .Net application I get selinux blocking it, > saying: > > ----------------- > > The mscorsvw.exe application attempted to load > /home/Hin-Tak/.wine/drive_c/windows/Microsoft.NET/Framework/v2.0.50727/mscorsvw.exe > which requires text relocation. This is a potential security > problem. Most libraries do not need this permission. > Libraries are sometimes coded incorrectly and request this > permission. > > ------------------ > > And a few other similar errors. Should I file this with > redhat with their shipped policy, wine or mono? I guess it > should be with redhat, but > somehow I have the impression that I might be asked to file > this with wine-devel. > > Any thoughts on this?

1 0

Hmm, guess we have to update our web site a bit
by Dan Kegel Nov. 29, 2008

Nov. 29, 2008

Somebody's walkthrough of installing crossover got lots of diggs: http://digg.com/linux_unix/Running_Windows_Programs_On_Ubuntu_8_10_With_Cro… The comments point out that http://www.winehq.org/site/myths could use a little updating...

2 1

wineconsole: Wait on events in curses backend using select instead of poll
by Kirill K. Smirnov Nov. 29, 2008

Nov. 29, 2008

>Should I add a >check for sys/select.h in the configure script and conditionally included >it, surrounded by HAVE_SYS_SELECT_H? Or would sys/time.h, sys/types.h and >unistd.h be enough to consider it reasonably compatible? Ideally - should. But... 1) There isn't any 'select.h' substring in whole wine tree. 2) There is a file libs/port/usleep.c which uses select() but it does not include any meaningful headers except "config.h" and "wine/port.h". Are these two headers enough wineconsole - I have no idea. Alexandre knows better ;-) Try and see ;-) >After fixing this, I guess I should just submit a new patch against the >current upstream git (not against the old patched version), with the same >commit message, replacing the old one? Yes, and mark a new mail subject with tag '[try 2]' to easily distinguish between different version of the same fix. -- Kirill

2 1

wineconsole: Wait on events in curses backend using select instead of poll
by Kirill K. Smirnov Nov. 29, 2008

Nov. 29, 2008

Hi, Martin, >+ ret = select(pipefd + 1, &readfds, &writefds, &errorfds, NULL); Passing NULL instead of &writefds in this case is better, IMO. It is not used anyway. ...and... I strongly believe that errorfds parameter os select() is useful for sockets only, not for stdio (I am not sure whether it is true for Darwin). Please, check this. -- Kirill

2 1

Implementing wtmpnam in msvcrt
by Tim Holy Nov. 29, 2008

Nov. 29, 2008

Hello, I'm trying to implement the "stub" function wtmpnam in msvcrt. Below is a patch at an attempt; there are a number of questions I have about the right way to implement it, and since I don't know the Wine codebase I thought perhaps readers of this list might (with minimal effort) be able to point me in the right direction. Below is the text of the patch (it's short). My questions are embedded after //-style comments (4 in total). Many thanks in advance for your help! --Tim diff -U 3 -r winecopy/wine-1.1.8/dlls/msvcrt/file.c wine-1.1.8/dlls/msvcrt/file.c --- winecopy/wine-1.1.8/dlls/msvcrt/file.c 2008-11-07 10:09:33.000000000 -0600 +++ wine-1.1.8/dlls/msvcrt/file.c 2008-11-29 07:32:43.000000000 -0600 @@ -88,6 +88,7 @@ /* INTERNAL: Static buffer for temp file name */ static char MSVCRT_tmpname[MAX_PATH]; +static MSVCRT_wchar_t MSVCRT_wtmpname[MAX_PATH]; static const unsigned int EXE = 'e' << 16 | 'x' << 8 | 'e'; static const unsigned int BAT = 'b' << 16 | 'a' << 8 | 't'; @@ -2990,6 +2991,32 @@ } /********************************************************************* + * wtmpnam (MSVCRT.@) + */ +MSVCRT_wchar_t * CDECL MSVCRT_wtmpnam(MSVCRT_wchar_t *s) +{ + static int unique; + char tmpstr[16]; + MSVCRT_wchar_t wtmpstr[16]; + MSVCRT_wchar_t *p; + int count; + if (s == 0) + s = MSVCRT_wtmpname; + msvcrt_int_to_base32(GetCurrentProcessId(), tmpstr); + p = s + MSVCRT_swprintf(s, "\\s%s.", tmpstr); // "implicit declaration" error, function is defined in wcs (but no wcs.h); but how to convert format string to MSVCRT_wchar_t? + for (count = 0; count < MSVCRT_TMP_MAX; count++) + { + msvcrt_int_to_base32(unique++, tmpstr); + mbstowcs(wtmpstr,tmpstr,strlen(tmpstr)); // need a MSVCRT_wchar version + wcscpy(p, wtmpstr); // need a MSVCRT_wchar version + if (GetFileAttributesW(s) == INVALID_FILE_ATTRIBUTES && + GetLastError() == ERROR_FILE_NOT_FOUND) + break; + } + return s; +} + +/********************************************************************* * tmpfile (MSVCRT.@) */ MSVCRT_FILE* CDECL MSVCRT_tmpfile(void) diff -U 3 -r winecopy/wine-1.1.8/dlls/msvcrt/msvcrt.spec wine-1.1.8/dlls/msvcrt/msvcrt.spec --- winecopy/wine-1.1.8/dlls/msvcrt/msvcrt.spec 2008-11-07 10:09:33.000000000 -0600 +++ wine-1.1.8/dlls/msvcrt/msvcrt.spec 2008-11-29 07:12:10.000000000 -0600 @@ -579,7 +579,7 @@ @ cdecl _wstrtime(ptr) @ cdecl _wsystem(wstr) @ cdecl _wtempnam(wstr wstr) -@ stub _wtmpnam #(ptr) +@ cdecl wtmpnam(ptr) MSVCRT_wtmpnam // needs an underscore? @ cdecl _wtoi(wstr) ntdll._wtoi @ cdecl _wtoi64(wstr) ntdll._wtoi64 @ cdecl _wtol(wstr) ntdll._wtol

3 6

new winetricks-20081129: new verbs mshflxgd, controlpad/fm20, native_oleaut32
by Dan Kegel Nov. 29, 2008

Nov. 29, 2008

Also clean up temp directory between verbs, as some verbs were writing readonly files with unique names like 'setup.exe' and stumbling over each other. As always, online at http://kegel.com/wine/winetricks Please submit bug reports to http://code.google.com/p/winezeug/issues/list

1 0

Re: winex11.drv: change bpp fixme to a warn
by James Hawkins Nov. 28, 2008

Nov. 28, 2008

On Fri, Nov 28, 2008 at 4:25 PM, Austin English <austinenglish(a)gmail.com> wrote: > This isn't something we can really fix on our end, so a FIXME isn't appropriate. > diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index 8229377..16aa8c3 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -1155,6 +1155,7 @@ DWORD WINAPI BuildSecurityDescriptorW( BOOL WINAPI InitializeSecurityDescriptor( PSECURITY_DESCRIPTOR pDescr, DWORD revision ) { + pDescr = 0; return set_ntstatus( RtlCreateSecurityDescriptor(pDescr, revision )); } Extraneous change. -- James Hawkins

2 1

Re: shell32/autocomplete: fix handling of WM_KILLFOCUS messages
by Austin English Nov. 28, 2008

Nov. 28, 2008

On Fri, Nov 28, 2008 at 10:53 AM, Jan de Mooij <jandemooij(a)gmail.com> wrote: > In eMule after moving focus from the searchbox to another control, it > still shows the caret and search is unusable without switching tabs. > > Autocomplete overrides the textbox message handler. But after handling > WM_KILLFOCUS messages we should send it to the old handler so it can > move the focus from the textbox, hide the caret, etc. > > Fixes bug 4090: http://bugs.winehq.org/show_bug.cgi?id=4090 > > Regards > > > > Can you add a testcase for this? -- -Austin

1 0

Re: dinput: Remove WINAPI on static functions where not needed.
by Vitaliy Margolen Nov. 28, 2008

Nov. 28, 2008

Francois Gouget wrote: > --- > > If you know other places where the functions touched by this patch > are used, please let me know. For more details, see: > > http://www.winehq.org/pipermail/wine-patches/2008-November/064995.html > > > dlls/dinput/joystick_linux.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/dinput/joystick_linux.c b/dlls/dinput/joystick_linux.c > index 4146f1d..47c734d 100644 > --- a/dlls/dinput/joystick_linux.c > +++ b/dlls/dinput/joystick_linux.c > @@ -966,7 +966,7 @@ static HRESULT WINAPI JoystickAImpl_GetProperty( > /****************************************************************************** > * GetObjectInfo : get object info > */ > -static HRESULT WINAPI JoystickWImpl_GetObjectInfo(LPDIRECTINPUTDEVICE8W iface, > +static HRESULT JoystickWImpl_GetObjectInfo(LPDIRECTINPUTDEVICE8W iface, > LPDIDEVICEOBJECTINSTANCEW pdidoi, DWORD dwObj, DWORD dwHow) > { > static const WCHAR axisW[] = {'A','x','i','s',' ','%','d',0}; Please don't apply this patch. This function should be used in vtable but isn't by mistake. Sending a patch to fix this. Vitaliy.

1 0

Re: [1/2] [try 4] mlang: Add implementation offnIMLangFontLink_GetCharCodePages
by Dmitry Timoshkov Nov. 28, 2008

Nov. 28, 2008

"Vitaly Perov" <vitperov(a)etersoft.ru> wrote: > Changes since last send: > - Used local mlang_data structure instead of calling internal function > wine_cp_enum_table. > - Used macro instead of "iface->lpVtbl->...." Looks good to me. -- Dmitry.

2 1

New winetricks 20081127: new verbs mono20, ie6, msmask, ole2
by Dan Kegel Nov. 27, 2008

Nov. 27, 2008

Also updates to latest directx9, and fixes a Mac problem. As always, online at http://kegel.com/wine/winetricks Please submit bug reports to http://code.google.com/p/winezeug/issues/list Thanks to everybody who sent in suggestions and patches! ie6 - Steven Edwards msmask - Austin mac bugfix - Ryan Schmidt

1 0

Re: programs: Fix broken compilation on win64
by Rob Shearman Nov. 27, 2008

Nov. 27, 2008

2008/11/27 Maarten Lankhorst <maarten(a)codeweavers.com>: > --- > Set the Spare[0] at runtime after a critical section is entered. :-) > > I'm not testing Spare[0] at all calls to EnterCriticalSection, but if this > is a problem I will send a revised patch IMHO, this is too fragile. My solution would be two macros: one for declaring a variable storing the name for a critical section, and a second for putting that name into the critical section structure. The latter would be something like the following for 64-bit: #define WINE_DEBUG_USE_CRIT_SECT_NAME(name) { (DWORD)(DWORD_PTR)name, (DWORD)((DWORD_PTR)name >> 32) } It might even be better to let the macro fill in / declare the entire CRITICAL_SECTION_DEBUG stucture. -- Rob Shearman

2 1

Re: d3dxof: DPRINTF -> TRACE.
by Christian Costa Nov. 27, 2008

Nov. 27, 2008

DPRINTF use here is intentional. Christian Andrew Riedi a écrit : > Changelog: > d3dxof: DPRINTF -> TRACE. > > > ------------------------------------------------------------------------ > >

1 0

Re: [3/5] WineD3D: Fix D3DFMT_R32F, R16F, G16R16F, ... in the pixel shader
by Roderick Colenbrander Nov. 27, 2008

Nov. 27, 2008

Hi, I don't know much about the current shader code but is this the right way to go thinking about GL_EXT_texture_swizzle + GL_ARB_texture_rg? For instance Nvidia drivers will soon get the swizzle extension and for that you don't have to fixups anymore. Is moving this way the right approach, so that it won't become a mess later on? Roderick -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

3 11

Re: [1/2] [try 3] mlang: Add implementation offnIMLangFontLink_GetCharCodePages
by Dmitry Timoshkov Nov. 27, 2008

Nov. 27, 2008

"Vitaly Perov" <vitperov(a)etersoft.ru> wrote: > Changes since last send: > - Used WINAPI function instead of accessing Wine internal code page > structures. You still access internal Wine code page structures, I'm not sure why you claim otherwise. > "Dmitry Timoshkov" <dmitry(a)codeweavers.com> wrote: >>It *is* possible to use EnumSystemCodePages > > Yes, it is possible. But : > 1) this function call wine_cp_enum_table, then converts the result (codepage) > to the string. So we need convert the result back to the number. > 2) It pass code pages to the callback-function. The callback function uses > only one argument - string with codepage number. So it's very difficult to > pass this value back to the GetCharCodePages function. > > So, I think the best decision is to use internal function wine_cp_enum_table What's happend to the idea to use mlang_data? And again: forget about Wine internal code page structures, that's the implementation detail that's internal to kernel32/ntdll, that structures should not be used outside of kernel32/ntdll. > + iface->lpVtbl->CodePageToCodePages(iface, > + cpTable->info.codepage, &codePages); Have a look how other parts in Wine call vtable members, the tests have enough code samples. -- Dmitry.

1 0

Re: user32: Improve the LoadImage() test.
by Dmitry Timoshkov Nov. 27, 2008

Nov. 27, 2008

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > - icon_entry->xHotspot = 1; > - icon_entry->yHotspot = 1; > + icon_entry->xHotspot = 1; /* Color planes for .ico. */ > + icon_entry->yHotspot = ICON_BPP; /* BPP for .ico. */ ... > ok(icon_info.xHotspot == 1, "xHotspot is %u.\n", icon_info.xHotspot); > - ok(icon_info.yHotspot == 1, "yHotspot is %u.\n", icon_info.yHotspot); > + ok(icon_info.yHotspot == 32, "yHotspot is %u.\n", icon_info.yHotspot); It should be ICON_BPP instead of 32 for consistency. > + /* Test loading an icon as an icon. */ > + SetLastError(0xdeadbeef); > + handle = LoadImageA(NULL, "icon.ico", IMAGE_ICON, 0, 0, LR_LOADFROMFILE); > + ok(handle != NULL, "LoadImage() failed.\n"); > + error = GetLastError(); > + ok(error == 0 || > + broken(error == 0xdeadbeef) || /* Win9x */ > + broken(error == ERROR_BAD_PATHNAME), /* Win98, WinMe */ > + "Last error: %u\n", error); There is no point in testing last error value if the API didn't fail. > + /* Test the icon information. */ > + SetLastError(0xdeadbeef); > + ret = GetIconInfo(handle, &icon_info); > + ok(ret, "GetIconInfo() failed.\n"); > + error = GetLastError(); > + ok(error == 0xdeadbeef, "Last error: %u\n", error); Same here. > + if (ret) > + { > + ok(icon_info.fIcon == TRUE, "fIcon == FALSE.\n"); > + ok(icon_info.xHotspot == 16, "xHotspot is %u.\n", icon_info.xHotspot); > + ok(icon_info.yHotspot == 16, "yHotspot is %u.\n", icon_info.yHotspot); > + ok(icon_info.hbmColor != NULL, "No hbmColor!\n"); > + ok(icon_info.hbmMask != NULL, "No hbmMask!\n"); > + } 'if (ret)' is useless if you don't expect a failure. > + > + /* Clean up. */ > + SetLastError(0xdeadbeef); > + ret = DestroyIcon(handle); > + ok(ret, "DestroyIcon() failed.\n"); > + error = GetLastError(); > + ok(error == 0xdeadbeef, "Last error: %u\n", error); Same here. -- Dmitry.

3 2

Re: ole32: Add Co*InitializeSpy functions
by Rob Shearman Nov. 27, 2008

Nov. 27, 2008

2008/11/26 Maarten Lankhorst <maarten(a)codeweavers.com>: > + > +HRESULT WINAPI CoRevokeInitializeSpy(ULARGE_INTEGER cookie) > +{ > + struct oletls *info = COM_CurrentInfo(); > + TRACE("(%s)\n", wine_dbgstr_longlong(cookie.QuadPart)); > + > + if (!info || !info->spy || cookie.QuadPart != (DWORD_PTR)info->spy) > + return E_INVALIDARG; > + > + IUnknown_Release(info->spy); > + return S_OK; > +} No function documentation and you forget to clear info->spy before returning. -- Rob Shearman

2 1

Re: [2/5] WineD3D: Use a separate enum for pixel format fixups
by Henri Verbeet Nov. 27, 2008

Nov. 27, 2008

2008/11/27 Stefan Dösinger <stefan(a)codeweavers.com>: > +enum shader_color_conv > +{ > + fmtconv_none = 1, > + set_blue_1 = 2, > + signed_2_no_ba = 3, > + signed_2 = 4, > + signed_4 = 5, > + signed_l6v5u5 = 6, > + swap_rg_blue_1 = 7, > + a_to_g_ba_1 = 8, > + yuv_yuy2 = 9, > + yuv_uyvy = 10, > + yuv_yv12 = 11, > + force_dword = 0x7ffffff > +}; > Could you please use uppercase enum elements like the rest of the world? :-/

1 0

Re: ntdll: DPRINTF -> TRACE. (heap.c)
by Dmitry Timoshkov Nov. 27, 2008

Nov. 27, 2008

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > Changelog: > ntdll: DPRINTF -> TRACE. (heap.c) DPRINTF is used for a reason here. -- Dmitry.

2 2

Re: imm32: Add some really basic tests for ImmSetCompositionString().
by Dmitry Timoshkov Nov. 27, 2008

Nov. 27, 2008

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > +static int test_ImmSetCompositionString(void) It's a usual practice to have the test cases return 'void', especially if you don't use the return value. > +{ > + HIMC imc; > + BOOL ret; > + DWORD error; > + > + imc = ImmGetContext(hwnd); First thing to test is the return value of ImmGetContext() and report last error in the case of a failure. -- Dmitry.

2 1

Re: [1/5] D3D9: Document a Microsoft header bug
by Adam Petaccia Nov. 26, 2008

Nov. 26, 2008

On Thu, 2008-11-27 at 01:30 +0100, Stefan Dösinger wrote: > > + > + /* Note: Microsoft's d3d9.h does not declare > IDirect3D9Ex::RegisterSoftwareDevice . This would mean that > + * the offsets of the other methods in the Vtable change too. > This, however, seems wrong. In Microsoft's > + * d3d9.dll, the offsets for the other functions are still > compatible with IDirect3D9. > + * (This is probably because even in MS's header IDirect3D9Ex > inherits from IDirect3D9, which makes the > + * C++ inferface compatible, and nobody uses the C interface in > Windows world > + */ Maybe this should be documented via Wine's API doc "BUGS: " declaration as well: http://www.winehq.org/site/docs/winedev-guide/api-docs

1 0

Re: mshtml: Do a case-insensitive compare of type (resend 1)
by Alistair Leslie-Hughes Nov. 26, 2008

Nov. 26, 2008

Any thing wrong with this patch? Best Regards Alistair Leslie-Hughes "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:492681BB.2090608(a)hotmail.com... > Hi, > > Changelog: > mshtml: Do a case-insensitive compare of type > -------------------------------------------------------------------------------- > >From ab3346563682349645f07147c5adbcfc3ce90ebf Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Thu, 13 Nov 2008 21:38:13 +1100 > Subject: [PATCH] Do a case-insensitive compare of type > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/mshtml/script.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/mshtml/script.c b/dlls/mshtml/script.c > index 4d10853..90bfef9 100644 > --- a/dlls/mshtml/script.c > +++ b/dlls/mshtml/script.c > @@ -640,7 +640,7 @@ static BOOL get_guid_from_type(LPCWSTR type, GUID > *guid) > {'t','e','x','t','/','j','a','v','a','s','c','r','i','p','t',0}; > > /* FIXME: Handle more types */ > - if(!strcmpW(type, text_javascriptW)) { > + if(!strcmpiW(type, text_javascriptW)) { > *guid = CLSID_JScript; > }else { > FIXME("Unknown type %s\n", debugstr_w(type)); > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

re: RFC: Proposed new web site design
by Dan Kegel Nov. 26, 2008

Nov. 26, 2008

Looks great so far. Comments: 1) nested scrollbars are evil. Better to put the news on its own tab, lose the little sidebar the news was in, and have a very small area in the main box for just the one most important headline. 2) The main choice text needs to be closer to user tasks. So instead of Information Overview of Wine features. we should have About What is Wine, and why should I use it? and we're missing the user task Will my app work with Wine? which should link to the appdb.

8 8

Re: atl: Remove WINAPI on static functions where not needed.
by Ken Thomases Nov. 26, 2008

Nov. 26, 2008

Thanks for taking care of this, Francois. On Nov 23, 2008, at 5:15 PM, Francois Gouget wrote: > Astute readers will notice that this leaves one loophole: nasty macro > use like in dlls/winmm/message16.c: > > #define A(_x,_y) MMDRV_InstallMap(_x, \ > MMDRV_##_y##_Map16To32W, MMDRV_##_y##_UnMap16To32W, \ > MMDRV_##_y##_Map32WTo16, MMDRV_##_y##_UnMap32WTo16, \ > MMDRV_##_y##_Callback) > A(MMDRV_AUX, Aux); > > A grep would not find that MMDRV_Aux_Callback is referenced by the > above > code. Could you perhaps grep the output from the preprocessor, instead? -Ken

2 1

Re: mshtml: suppress module unloading while gecko is loaded (take 2)
by Paul Vriens Nov. 26, 2008

Nov. 26, 2008

Dan Kegel wrote: > Thanks to Mike Hearn for pointing out that mshtml reference > counting was wrong, and Jacek for pointing out how to fix > it for now. > > Once gecko is loaded, don't let mshtml unload. > This fixes a crash in starting Sketchup (bug 16164), > and probably fixes a number of other apps that > went pear-shaped after unloading mshtml... > > > ------------------------------------------------------------------------ > > C++ style comment? Was this a Patchwatcher test ;) -- Cheers, Paul.

1 0

Icons as cursors patch
by Krzysztof Drewniak Nov. 25, 2008

Nov. 25, 2008

This is my first patch. It allows icons to be loaded as cursors because it defaults hotspots to x = 0 and y = 0 if the hotspot isn't found. Pasting patch into body of message. This is against the latest git . -------------------------------------------------------------------------------------------------------------------------- --- cursoricon.c.orig 2008-11-23 15:07:32.000000000 -0600 +++ cursoricon.c 2008-11-23 15:13:22.000000000 -0600 @@ -932,7 +932,10 @@ static HICON CURSORICON_LoadFromFile( LP entry = CURSORICON_FindBestIconFile( dir, width, height, colors ); if ( !entry ) - goto end; + /* this is my change. If there is no hotspot, default to 0, 0. */ + hotspot.x = 0; + hotspot.y = 0; + goto iconskip; /* check that we don't run off the end of the file */ if ( entry->dwDIBOffset > filesize ) @@ -942,6 +945,7 @@ static HICON CURSORICON_LoadFromFile( LP hotspot.x = entry->xHotspot; hotspot.y = entry->yHotspot; +iconskip: hIcon = CURSORICON_CreateIconFromBMI( (BITMAPINFO *)&bits[entry->dwDIBOffset], hotspot, !fCursor, 0x00030000, width, height, loadflags ); -------------------------------------------------------------------------------------------------------------------------- Please look over the code. Krzys D.

4 7

Re: mshtml: suppress module unloading until we figure out why some apps crash with it enabled
by Jacek Caban Nov. 25, 2008

Nov. 25, 2008

Dan Kegel wrote: > This prevents http://bugs.winehq.org/show_bug.cgi?id=16164 > > ( http://www.microsoft.com/msj/0197/activex/activex0197.aspx looks > like a nice, scary article on the subject. ) > - return module_ref ? S_FALSE : S_OK; + /* Some apps crash if we let mshtml be unloaded. + * Until we figure out why, don't let mshtml be unloaded. + */ + return S_FALSE; /* module_ref ? S_FALSE : S_OK; */ I think we should prevent unloading mshtml.dll if Gecko was loaded. To do it I'd suggest to increase module count in load_gecko function (it will never be decreased so DLL won't be unloaded). Jacek

1 0

Re: [PATCH] advapi: Only allow opening HKEY_CLASSES_ROOT subkeys with backslash prefix on W2K+.
by Lei Zhang Nov. 25, 2008

Nov. 25, 2008

On Tue, Nov 25, 2008 at 11:35 AM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > Commit aacb511da1540fa015c5e853c90fd054b9442701 assumed NT+ behaved > the same way, but running the tests turns out it's actually W2K+. > Doh, that came out wrong. Ignore, sorry.

1 0

Re: RFC: Proposed new web site design
by chris ahrendt Nov. 25, 2008

Nov. 25, 2008

Austin English wrote: > On Tue, Nov 25, 2008 at 12:27 AM, Scott Ritchie <scott(a)open-vote.org> wrote: > >> We also don't really need a link to AppDB from the big buttons in the >> front - AppDB is only the place to go when you're looking for it (hence >> the button in the upper right) or once you know something about Wine >> (hence a link in the about page). >> >> > > I disagree. You could make the same argument against > bugzilla/forums/wiki. The frontpage should serve as a portal to the > rest of the site. Many times when I needs appdb/wiki, I go to > winehq.org and then click the appropriate link. > > I agree the main page should be the portal where you go to find everything... chris p.s. kudo's on the new design!

1 0

Fw: Re: RFC: Proposed new web site design
by James Mckenzie Nov. 25, 2008

Nov. 25, 2008

Sent to wrong mailing list. -----Forwarded Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: Nov 25, 2008 9:01 AM >To: Wine Users Mailing List <wine-users(a)winehq.org> >Subject: Re: RFC: Proposed new web site design > >Daniel Scharrer <dscharrer(a)gmail.com> at Nov 25, 2008 8:50 AM (MST) wrote about Re: RFC: Proposed new web site design >> >>The new user-centric design looks promising. Contrary to some others I >>quite like the round corners and more modern look. Here are a few >>observations: >> >>- Light gray text on a white background is not so nice. > >This is very hard to read. I like a shade of Yellow on a Green background. White on Green is better. Easy on the eyes. White on Red is also good. > >>- I don't really like the icons too much: As others mentioned, a >>simple down arrow for the 'Download' icon might be better > >The use of the down arrow is intuitive as well. This may lead directly to an available download or download page. > >>The Development icon is really non-intuitive. Better alternatives would be >>gears or a wrench (or both). > >+1 for gears with wrench. > > >>- I think a big "Compatibility" link, as done in the re-layout, really >>belongs onto the front page. I'm guessing many users will want to know >>if their favorite app runs with wine before the download link even >>becomes relevant, both for users who are deciding weather to switch to >>Linux / Mac and those that just want to find out if there is any >>reason to upgrade from the Wine version that ships with their distro. > >I agree. A link to a Compatibility page should be on the Front Page where users can find it. The compatibility page should have categories rather than colors as well: >Runs with Wine unaltered >Runs with Wine with Windows DLLS >Partially Runs with Wine >Partially Runs with Wine with Windows DLLS >DOES NOT RUN WITH WINE (Yes, the bold is deliberate.) > >>+1 To the idea of getting screenshots back on the page, > >+1 to this as well. A small, clickable, screenshot of a running application does wonders. > >James McKenzie

1 0

Re: oleaut32: Add support for loading typelibs from NE files.
by Rob Shearman Nov. 25, 2008

Nov. 25, 2008

2008/11/25 Huw Davies <huw(a)codeweavers.com>: > --- > dlls/oleaut32/typelib.c | 218 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 218 insertions(+), 0 deletions(-) Looks good. Thanks for doing this. -- Rob Shearman

1 0

Re: RFC: Proposed new web site design
by Daniel Scharrer Nov. 25, 2008

Nov. 25, 2008

The new user-centric design looks promising. Contrary to some others I quite like the round corners and more modern look. Here are a few observations: - Light gray text on a white background is not so nice. - I thought it was called "Wine" and not "WINE" now. Shouldn't the "logo" at the top left reflect this? - I don't really like the icons too much: As others mentioned, a simple down arrow for the 'Download' icon might be better and the Development icon is really non-intuitive. Better alternatives would be gears or a wrench (or both). Also, I don't see a reason for them being buttons instead of just the icons over the background. Putting the icons into a box just detracts from the icons themselves, at least for me. Also, would it kill to user other colors than than those dictated by the theme for the icons? Compare this to http://www.openoffice.org/ which I'm guessing this design is based on. - I think a big "Compatibility" link, as done in the re-layout, really belongs onto the front page. I'm guessing many users will want to know if their favorite app runs with wine before the download link even becomes relevant, both for users who are deciding weather to switch to Linux / Mac and those that just want to find out if there is any reason to upgrade from the Wine version that ships with their distro. - As many others, I also despise secondary scroll bars. Right now the news content shows way too much redundancy: The "Latest Releases" box, the title of the latest news entry as well as it's first sentence all just say "The latest Wine version is 1.1.8" and they are right next to each other. Is there some way to combine this? How about just: Latest stable release (links to release page) Latest release (also links to it's own release page) Release date. Major changes. 1/2 Non-release news items (WWN,...) Also, even when resizing the browser window to the point where a horizontal scroll bar appears there is still quite a bit of white space in the center, yet the news box has a small fixed width that forces line breaks in the release change summary bullet points. +1 To the idea of getting screenshots back on the page, it's surprising how much a little eye candy can do.They should however be more up to date (perhaps automatically linked from platinum apps on the AppDB) and as was suggested link back to the relevant AppDB entry. Regards, Daniel Scharrer

1 0

Internet Explorer running in Wine usefull for performance testing
by Joris Huizer Nov. 25, 2008

Nov. 25, 2008

Hello, Just as Dan Kegel likes to announce on the list, how Wine gets mentioned out on the internet, I thought this may be interesting/motivating to you. This page, http://ejohn.org/blog/accuracy-of-javascript-time/, mentions (big) problems in testing javascript performances (there's some interest in that in the new race between webbrowsers), when running IE (and other browsers) on Windows, which are fixed when running it under Wine (in this case on a Mac) Regards, Joris

1 0

Windows mobile and ARM
by Scott Ritchie Nov. 25, 2008

Nov. 25, 2008

Is it at all feasible to run Windows mobile apps under Wine? From what I understand it's supposed to be largely the same API as standard Win32. How about a port to ARM for the purpose of running Windows Mobile apps, or just recompiled Winelib apps? Ubuntu is getting serious about its ARM port, so if Wine/ARM becomes a reality within the next, say, 2 years the potential for quickly developing mobile applications by just porting Windows ones is huge. Theoretically, we could run Windows applications on a jailbroken iPhone. Thanks, Scott Ritchie

4 3

Bugs not linked to appdb
by Dan Kegel Nov. 25, 2008

Nov. 25, 2008

Somebody asked if there was a way to find out which bugs were not yet linked into the appdb. There ought to be, but I don't know of one, so I ran the report the hard way last night. It's at http://kegel.com/wine/unlinked.html - Dan

1 0

Re: Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."
by Jacek Caban Nov. 25, 2008

Nov. 25, 2008

Vitaliy Margolen wrote: > Since Jacek did not comment on the bug 14311, revert patch in question. It > restores 100% functionality of the scrollbars in Steam. > The fact that I didn't comment doesn't mean anything. I didn't have time to work on it and I'm currently looking at it (BTW, with today git other Steam bug is fixed). I know that it doesn't make any difference for user, but from technical point of view, there was no regression. Steam draws its own scrollbars and doesn't use built-in MSHTML scrollbars. Previously there were two bugs: - MSHTML scrollbars were not hidden - Steam scrollbars didn't work The patch that you want to revert (with fixes apps like CS3 installer) fixed the first problem. Now the second one needs to be fixed. Jacek

3 2

Re: [6/6] gdiplus: implement GdipGetRegionHRgn for combined regions
by Vincent Povirk Nov. 24, 2008

Nov. 24, 2008

I leaked a region in this last one. Please don't apply it. Vincent Povirk On Mon, Nov 24, 2008 at 5:34 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > >

1 0

Re: mshtml: Add new interfaces into mshtml.idl (try 2)
by Alistair Leslie-Hughes Nov. 24, 2008

Nov. 24, 2008

Hi Konstantin, > Kondratyuk wrote: > Hello! > > Try 2 changes: > - add missed POINTER_GRAVITY_Max, MARKUP_CONTEXT_TYPE_Max, SELECTION_TYPE_Max > constants > - correct attributes of interfaces: object, pointer_default(unique), uuid(...) > - correct attributes Right and Left methods in IMarkupPointer interface > Non of the Functions in IMarkupPointer should be marked as retval, likewise for IMarkupContainer. IElementSegment functions are in the wrong order, likewise for ISelectionServicesListener, ISelectionServices and IHTMLEditServices. Also you will need to double check the [] values, since you have retval where they are not needed. If you have a copy of the mshtml.tlb you can verify the interfaces by using wine's oleview program. Best Regards Alistair Leslie-Hughes

2 2

adding DEVICEMAP\HARDWARE registry entries
by A C Hurst Nov. 24, 2008

Nov. 24, 2008

Dear winehackers, I sent this patch to wine-patches, with a few iterations of editing, and wondered if I could have some feedback on it, before I just resend it. Andy

3 4

Re: Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."
by Reece Dunn Nov. 24, 2008

Nov. 24, 2008

2008/11/24 Vitaliy Margolen <wine-patches(a)kievinfo.com>: > Since Jacek did not comment on the bug 14311, revert patch in question. It > restores 100% functionality of the scrollbars in Steam. This is not the correct fix. Simply reverting a patch because it broke an application without understanding why is not the right way to go. In this case, some applications (http://bugs.winehq.org/show_bug.cgi?id=13459) specify the DOCHOSTUIFLAG_SCROLL_NO flag to specifically not show any scrollbars. In the case of bug 13459, the intro page does not render correctly if scrollbars are shown (and on Windows you don't see any scrollbars). What is the behaviour on Windows? Can you explain comments 3 and 8? - Reece

2 1

Good news regarding Wine and patent threats
by Scott Ritchie Nov. 24, 2008

Nov. 24, 2008

There's a groklaw article summarizing recent discussion about the impact of the Bilski case on software patents: http://www.groklaw.net/article.php?story=20081102011538422 "The judge says this kind of cloning could be done without infringing Microsoft's copyrights, but how about its patents? Prior to Bilski, one might give one answer. Now, one might give another." If we thought Wine unlikely to be attacked by Microsoft due to nebulous patent issues and anti-trust implications, it's even less likely now. Thanks, Scott Ritchie

1 0

Spaces before '...' in Slovenian
by Francois Gouget Nov. 24, 2008

Nov. 24, 2008

Does anyone (especially Rok Mandeljc) know if, in Slovenian: 1) '...' must be preceded by a space 2) '...' must not be preceded by a space 3) either form is valid -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

2 1

Re: adding DEVICEMAP\HARDWARE registry entries
by A C Hurst Nov. 24, 2008

Nov. 24, 2008

> > The code in oldconfig.c is called by process.c/__wine_kernel_init(), on server startup. > > The entries are volatile, and are dynamically created if you count scanning > wineprefix/dosdevices/ > > and doing a stat() on anything named com[1-9] it finds there every time wine starts up. > > I could just call get_dos_device and let it do the stat calls, but it would be less efficient, > and > > you'd end up with registry entries for the successes of get_default_com_device, not just the > ones > > symlinked in dosdevices > > You don't want to depend on the symlinks, things should work without > requiring the user to create any symlink. It should depend on what > actual devices are present on the machine, and probably be done > somewhere in the HAL support. Would using get_dos_device() be better, since that does fall through to default behaviour when the symlink isn't there? I chose oldconfig.c since that's where the \DEVICEMAP\Scsi entries get built. Would the scsi stuff want moving over to HAL too?

2 1

Re: atl: Remove WINAPI on static functions where not needed.
by Chris Robinson Nov. 24, 2008

Nov. 24, 2008

On Sunday 23 November 2008 03:15:36 pm Francois Gouget wrote: > To quote Ken Thomases who did the research on this issue with Alexandre: > > This is motivated by a gcc bug that we've encountered on the Mac. On > the Mac, WINAPI (and other declspecs) include the > force_align_arg_pointer attribute. With -O2 optimization (actually > -funit-at-a-time, implied by -O2) the compiler may change the calling > convention used by non-exported functions to take arguments via > registers rather than on the stack. The prologue generated for > force_align_arg_pointer clobbers one of those registers (and hence > one of the arguments). > > Alexandre's preferred solution is to find and eliminate such cases. > Even if/when the compiler bug is fixed, those functions should still > not have the extraneous declspec. Out of curiousity, then, does this affect static functions that are used for COM objects? It's typical for those to be marked as static, their address put into a (possibly static) vtable struct, which is then used as a field for an allocated struct passed to the user.

2 1

Re: d3d9: Remove WINAPI on static functions where not needed.
by Vitaliy Margolen Nov. 24, 2008

Nov. 24, 2008

Francois Gouget wrote: > --- > > If you know other places where the functions touched by this patch > are used, please let me know. For more details, see: > > /* This isn't in MSDN! > -static HRESULT WINAPI IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) { > +static HRESULT IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) { > IDirect3DDevice9Impl *This = (IDirect3DDevice9Impl *)iface; > FIXME("(%p) : stub\n", This); > return D3D_OK; You can't do that. It's part of the v-table so it can be called by user application. Vitaliy

3 2

FAQ change wrt FontForge
by Francois Gouget Nov. 24, 2008

Nov. 24, 2008

On Thu, 13 Nov 2008, Wine Wiki wrote: [...] > - Unless you plan to work on the TrueType fonts you don't need > FontForge. If you do, then be aware that the FontForge packages from > Breezy and Dapper are a bit out of date. The fonts generated by most > versions of FontForge will not pass the gdi32/tests/fonts.c tests. > + Be aware that the FontForge packages from Breezy and Dapper are a > bit out of date. The fonts generated by most versions of FontForge > will not pass the gdi32/tests/fonts.c tests. [...] > - Note that, unless you are tracking Git and know what you are doing, > you SHOULDN'T have valgrind. Also, unless you plan to work on the > TrueType fonts you don't need FontForge. > + Note that, unless you are tracking Git and know what you are doing, > you SHOULDN'T have valgrind. [...] > - Unless you plan to work on the TrueType fonts you don't need FontForge. [...] > - * The following, but ''only'' if you plan to work on the TrueType > fonts, and can install them from ''testing'' - '''do not''' install > these from ''Sarge'': > + * '''Do not''' install these from ''Sarge'': > * fontforge/testing I think these changes are wrong. As far as I know the TrueType fonts are checked into Git so one does not need to have FontForge to build Wine. Or has this changed? Or is FontForge needed to build another type of fonts? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

4 5

Re: mshtml: Add new interfaces into mshtml.idl
by Alistair Leslie-Hughes Nov. 24, 2008

Nov. 24, 2008

Hi Konstantin, "Konstantin Kondratyuk" <kondratyuk(a)etersoft.ru> wrote in message news:200811232011.33101.kondratyuk(a)etersoft.ru...> I'm sorry, I have sent a wrong patch...> > -- > Best regards,> Konstantin Kondratyuk.> You have missed POINTER_GRAVITY_Max MARKUP_CONTEXT_TYPE_Max SELECTION_TYPE_Max The following interfacess dont contain dual interfaces IHTMLEditDesigner IMarkupContainer IMarkupPointer ISegment ISelectionServicesListener ISelectionServices IHTMLEditServices Best Regards Alistair Leslie-Hughes _________________________________________________________________ Take a summer road trip with Windows Live Hotmail. Multiple prizes and the ultimate dream beach house! http://www.ninemsn.com.au/hotmailroadtrip

2 2

Why do we bother with DllCanUnloadNow?
by Mike Hearn Nov. 24, 2008

Nov. 24, 2008

Is there a specific reason for implementing this function anymore? The resource savings don't seem worth the new potential for bugs. If all of them were simply returning FALSE then what would be the loss? thanks -mike

1 0

Another happy user
by Dan Kegel Nov. 24, 2008

Nov. 24, 2008

http://blog.lokonopa.com/sorry-microsoft/ has a nice quote: "Come to think of it, I don't recall the last piece of software that won't install properly with Wine."

1 0

Compiler keyword
by Austin English Nov. 23, 2008

Nov. 23, 2008

Howdy, Wanted to keep the discussion separate from the OS thread. Would anyone be opposed to a compiler keyword being added? There have been -- -Austin

2 2

re: Bugzilla - Add keyword and remove OS's
by Dan Kegel Nov. 23, 2008

Nov. 23, 2008

Austin wrote: > The OS list in bugzilla is a bit excessive. There are 16 OS's that I > think we should remove... I think we should keep most of them, but classic Mac OS (pre-X) can go, as we never worked there (not even Darwine), and nobody cares about it anymore. I've deleted Mac System 7, and will delete the rest of the classic mac OS's if there is consensus.

2 3

Accounts in bugzilla and e-mail addresses used to submit patches
by Vitaliy Margolen Nov. 23, 2008

Nov. 23, 2008

Can please everyone make sure that their e-mail in bugzilla matches the e-mail they use to submit patches? Or at least make it easily guessable. Or can we have all developers create page on Wiki and state their e-mails they use on bugazilla? The reason I'm asking is the standard procedure for a regression testing is to add author of the patch to CC. However sometimes it's impossible to do. As example this commit that introduced regression (bug 16165): e4f7809cc9969c693d910348315502892848aaf9 is first bad commit commit e4f7809cc9969c693d910348315502892848aaf9 Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 20 14:50:58 2008 +0100 winhttp: Prefer builtin over native. Out of 2 e-mail address (the one used to submit patch and the one used to send messages to wine-devel) neither present in bugzilla. Vitaliy.

5 6

Re: jscript: Implement the String.toLowerCase() method.
by Jacek Caban Nov. 23, 2008

Nov. 23, 2008

Hi Andrew, Andrew Nguyen wrote: > This is an attempt to implement the String.toLowerCase method. The > added jscript tests pass on Windows XP. > --- > dlls/jscript/string.c | 41 +++++++++++++++++++++++++++++++++++++++-- > dlls/jscript/tests/api.js | 11 +++++++++++ > 2 files changed, 50 insertions(+), 2 deletions(-) > > > + res = heap_alloc((length+1)*sizeof(WCHAR)); > + if (!res) > + return E_OUTOFMEMORY; You can avoid this allocation by using SysAllocStringLen. Jacek

1 0

Re: msxml3: Implement IXMLDOMAttribute get/put value
by Alistair Leslie-Hughes Nov. 23, 2008

Nov. 23, 2008

Ignore this patch. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:49269ECA.7070202(a)hotmail.com... > Hi, > > Changelog: > msxml3: Implement IXMLDOMAttribute get/put value > > Best Regards > Alistair Leslie-Hughes > > > -------------------------------------------------------------------------------- > From 485959eb359d1efdf66c4be1aa110ba47877847c Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 21 Nov 2008 21:36:30 +1100 > Subject: [PATCH] Implement IXMLDOMAttribute get/put value > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msxml3/attribute.c | 8 ++++---- > dlls/msxml3/node.c | 21 +++++++++++++++------ > dlls/msxml3/tests/domdoc.c | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 49 insertions(+), 10 deletions(-) > > diff --git a/dlls/msxml3/attribute.c b/dlls/msxml3/attribute.c > index 2681a76..92cafad 100644 > --- a/dlls/msxml3/attribute.c > +++ b/dlls/msxml3/attribute.c > @@ -482,16 +482,16 @@ static HRESULT WINAPI domattr_get_value( > IXMLDOMAttribute *iface, > VARIANT *var1) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domattr *This = impl_from_IXMLDOMAttribute( iface ); > + return IXMLDOMNode_get_nodeValue( This->node, var1 ); > } > > static HRESULT WINAPI domattr_put_value( > IXMLDOMAttribute *iface, > VARIANT var1) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domattr *This = impl_from_IXMLDOMAttribute( iface ); > + return IXMLDOMNode_put_nodeValue( This->node, var1 ); > } > > static const struct IXMLDOMAttributeVtbl domattr_vtbl = > diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c > index 19cee8f..6693803 100644 > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > @@ -339,13 +339,22 @@ static HRESULT WINAPI xmlnode_put_nodeValue( > > TRACE("%p type(%d)\n", This, This->node->type); > > - VariantInit(&string_value); > - hr = VariantChangeType(&string_value, &value, 0, VT_BSTR); > - if(FAILED(hr)) > + /* Attribute nodes treat NULL Variants as empty strings. */ > + if(V_VT(&value) == VT_NULL && This->node->type == XML_ATTRIBUTE_NODE) > { > - VariantClear(&string_value); > - WARN("Couldn't convert to VT_BSTR\n"); > - return hr; > + V_VT(&string_value) = VT_BSTR; > + V_BSTR(&string_value) = SysAllocStringLen(NULL, 0); > + } > + else > + { > + VariantInit(&string_value); > + hr = VariantChangeType(&string_value, &value, 0, VT_BSTR); > + if(FAILED(hr)) > + { > + VariantClear(&string_value); > + WARN("Couldn't convert to VT_BSTR\n"); > + return hr; > + } > } > > hr = S_FALSE; > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index e27c506..c975d73 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -2796,12 +2796,18 @@ static void test_xmlTypes(void) > ok( V_VT(&v) == VT_NULL, "incorrect dataType type\n"); > VariantClear(&v); > > + V_VT(&v) = VT_NULL; > + V_I4(&v) = 0; > + hr = IXMLDOMElement_put_nodeValue(pElement, v); > + ok(hr == DISP_E_TYPEMISMATCH, "ret %08x\n", hr ); > + > /* Attribute */ > hr = IXMLDOMDocument_createAttribute(doc, szAttribute, > &pAttrubute); > ok(hr == S_OK, "ret %08x\n", hr ); > if(hr == S_OK) > { > IXMLDOMNode *pNewChild = (IXMLDOMNode *)0x1; > + IXMLDOMNode *pAttrNode = NULL; > > hr = IXMLDOMAttribute_get_nextSibling(pAttrubute, > NULL); > ok(hr == E_INVALIDARG, "ret %08x\n", hr ); > @@ -2876,6 +2882,30 @@ static void test_xmlTypes(void) > ok( V_VT(&v) == VT_NULL, "incorrect dataType type\n"); > VariantClear(&v); > > + /* test value */ > + V_VT(&v) = VT_NULL; > + VariantClear(&v); > + hr = IXMLDOMAttribute_put_value(pAttrubute, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + VariantClear(&v); > + > + hr = IXMLDOMAttribute_get_value(pAttrubute, &v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + ok( !lstrcmpW( V_BSTR(&v), _bstr_("") ), "incorrect > get_value string\n"); > + VariantClear(&v); > + > + IXMLDOMAttribute_QueryInterface(pAttrubute, > &IID_IXMLDOMNode, (LPVOID*)&pAttrNode); > + if(hr == S_OK) > + { > + V_VT(&v) = VT_NULL; > + VariantClear(&v); > + hr = IXMLDOMNode_put_nodeValue(pAttrNode, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + VariantClear(&v); > + > + IXMLDOMNode_Release(pAttrNode); > + } > + > IXMLDOMAttribute_Release(pAttrubute); > > /* Check Element again with the Add Attribute*/ > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

re: How do I create a backtrace?
by Dan Kegel Nov. 22, 2008

Nov. 22, 2008

The FAQ covers this: http://wiki.winehq.org/FAQ#head-16da35b6327024d6ea576e3678488b16862d0f5e

1 0

How do I create a backtrace?
by Matt Perry Nov. 22, 2008

Nov. 22, 2008

I've been asked by a Wine developer to provide a backtrace along with a "+relay,+seh" log for a bug that I have filed. I've read through the developer documentation but I can't figure out how to do this. I sent an email to the developer with a request for instructions but have not received a reply. Could someone here instruct me on how to do this? I'm a non-programmer so please take that into consideration with regards to your instructions. Thanks. Matt

2 1

Re: Wine release 1.1.9
by Francois Gouget Nov. 22, 2008

Nov. 22, 2008

On Fri, 21 Nov 2008, Alexandre Julliard wrote: > The Wine development release 1.1.9 is now available. > > What's new in this release (see below for details): > - A large number of regression test fixes. <nitpick> Actually it's not regression tests, and it's not regression fixes. It's conformance tests, their main goal is to describe the Windows behavior, so that we can then know whether Wine _conforms_ to that behavior or not. And all (or almost all) of the fixes are so that the tests actually describe the Windows behavior. </nitpick> -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ I haven't lost my mind, it's backed up on tape around here somewhere...

3 3

Regarding ./configure file
by shanmukha sainath addepalli Nov. 22, 2008

Nov. 22, 2008

Sir/Madam, I need to add few functions related to libwnck. It requires some header files to be included. I included them in wine source code. But when compiled it says header files not found. I haven't updated configure file. How can i update it? please tell me what r the changes that i need to made? Regards, Sainath.

7 6

LPD3DXMESH
by Krzysztof Drewniak Nov. 22, 2008

Nov. 22, 2008

What header is LPD3DXMESH supposed to be declared in? Krzys D.

5 4

[RFC/RFH] winmm:wave hang fix question (commit 717df5b2972b3cb998ca5a43279ae2283b117eaa) [bug 15559]
by Reece Dunn Nov. 21, 2008

Nov. 21, 2008

Hi, Looking at the history of that test (http://test.winehq.org/data/tests/winmm:wave.html) I see a lot of timeout errors on the Wine builds, even after this fix went in. The fix itself has caused a regression of playback in many applications and games that play audio (http://bugs.winehq.org/show_bug.cgi?id=15559) I want to submit the following patch to revert the part of the patch that caused the regression and fix some of the tracing. I have been using this patch on Cepstral SwiftTalker without issue and have tested it also with the game Azguard Defense. I am submitting this here and not to wine-patches initially, as I would like to understand what the fix was actually fixing and (based on the test history still showing timeouts) whether it actually fixes the issue it was trying to. diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 6cb2da8..b3f52aa 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -103,14 +103,19 @@ static BOOL wodUpdatePlayedTotal(WINE_WAVEDEV* wwo, snd_pcm_status_t* ps) state = snd_pcm_state(wwo->pcm); snd_pcm_delay(wwo->pcm, &delay); + if (state != SND_PCM_STATE_RUNNING && state != SND_PCM_STATE_PREPARED) + { + WARN("Unexpected state (%d) while updating Total Played, resetting\n", state); + delay=0; + } + /* A delay < 0 indicates an underrun; for our purposes that's 0. */ if (delay < 0) { - WARN("Unexpected state (%d) or delay (%ld) while updating Total Played, resetting\n", state, delay); + WARN("Unexpected delay (%ld) while updating Total Played, resetting\n", delay); delay=0; } - if (state == SND_PCM_STATE_XRUN) - snd_pcm_start(wwo->pcm); + InterlockedExchange((LONG*)&wwo->dwPlayedTotal, wwo->dwWrittenTotal - snd_pcm_frames_to_bytes(wwo->pcm, delay)); return TRUE; } - Reece

2 2

Re: urlmon #6: Added more policy tests.
by Paul Vriens Nov. 21, 2008

Nov. 21, 2008

Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 78 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 77 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Jacek, I'm checking out a test failure on a fresh and clean W2K3 box with SP2 and IE6. Right after this (line 859): + policy = 0xdeadbeef; + hres = IInternetZoneManager_GetZoneActionPolicy(zonemgr, 3, action, (BYTE*)&policy, + sizeof(DWORD), URLZONEREG_DEFAULT); I get a popup asking if I want to add www.winehq.org to the "Trusted sites zone". If I don't add this site the test succeeds. If I add it the test fails (over and over again). I didn't change any of the default IE6 (W2K3 specific?) security settings. I do see that adding this site to that zone doesn't change the content of the checked registry key but instead a new one is created: HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ZoneMap\EscDomains\winehq.org and HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ZoneMap\EscDomains\winehq.org\www with a 'http' REG_DWORD (value = 2) underneath that last one. So how should we proceed fixing/changing this test? -- Cheers, Paul.

2 1

Re: [4/5] wined3d: Use IDL to generate wined3d_interface.h.
by Rob Shearman Nov. 21, 2008

Nov. 21, 2008

2008/11/21 Henri Verbeet <hverbeet(a)codeweavers.com>: > +cpp_quote("#if 0") > +import "wined3d_types.idl"; > +import "wined3d_caps.idl"; ... > +cpp_quote("#endif") > + > +cpp_quote("#include \"wine/wined3d_types.h\"") > +cpp_quote("#include \"wine/wined3d_caps.h\"") You can't do this. It won't work in MIDL and it won't work in widl when it is fixed to put the includes for imported files at the start of the generated header file, rather than in between the statements generated from neighbouring IDL statements. You need to find another way of solving the issue you are facing. -- Rob Shearman

2 1

Re: [3/5] wined3d: Use IDL to generate wined3d_caps.h.
by Rob Shearman Nov. 21, 2008

Nov. 21, 2008

2008/11/21 Henri Verbeet <hverbeet(a)codeweavers.com>: > +cpp_quote("#if 0") > +import "wined3d_types.idl"; > +cpp_quote("#endif") This won't work either, for the same reason as I mentioned for the 4/5 patch. -- Rob Shearman

1 0

re: Add wtmpnam to msvcrt.dll
by Dan Kegel Nov. 21, 2008

Nov. 21, 2008

Hi Tim, welcome to Wine! > A diff (relative to wine-1.1.8/dlls/msvcrt/file.c) is attached. Whoops, you attached the undiffed file! > I did not even get as far as successfully building it to test it Ah. Such patches usually get attached to bug reports in bugzilla or sent to wine-devel. wine-patches is for tested and known working patches. > I'd be happy to do a test build (assuming I can successfully > install the dependencies) That should be easy, see http://wiki.winehq.org/Recommended_Packages > if MSVCRT_tmpname gets initialized, where does that occur? It gets initialized by tmpnam(). Presumably _wtmpnam() will need its own static buffer. Also, please be sure to write a conformance test (see http://www.winehq.org/site/docs/winedev-guide/testing ) for your change! Thanks, Dan p.s. The MSDN doc for this, FWIW, is at http://msdn.microsoft.com/en-us/library/hs3e7355(VS.80).aspx

1 0

dead stores in advapi32
by ricardo filipe Nov. 21, 2008

Nov. 21, 2008

hi rob. i have some dead stores in advapi32 files that i would like to clarify. first, what do you want to do on lines 173 and 194 of cred.c? now, there are also 3 dead assignments in cred.c, lines 992, 199 and 1064. i didn't understand what you meant in your last email about my patch that removed dead code in ole32, so since this is dead code i think i can remove it, but i'm not sure anymore since you confused me. regards, ricardo _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

2 1

Disable regression tests option now available in git!
by Austin English Nov. 21, 2008

Nov. 21, 2008

For those of you that don't monitor wine-commit, Alexandre committed a patch today to disable building the regression tests: http://source.winehq.org/git/wine.git/?a=commitdiff;h=35078f4b57523d4afe00d… So the manual PITA patching is no longer necessary. I've updated the Regression Testing wiki page as well. Thanks Alexandre! -- -Austin

1 0

Re: dlls/ole32: check some dead store results (llvm/clang)
by Michael Karcher Nov. 20, 2008

Nov. 20, 2008

Am Donnerstag, den 20.11.2008, 18:36 +0000 schrieb ricardo filipe: | - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { | + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey) == ERROR_SUCCESS) { No. This inverts the logic of the tests. if(x) means if(x != 0). And ERROR_SUCCESS is just zero. To prevent just this possible mistake, a patch making the condition obvious was requested. Regards, Michael Karcher

1 0

Fedora 9 and MingW
by Paul Vriens Nov. 20, 2008

Nov. 20, 2008

Hi, I was still using the rpm's that Hans provided in the past. Some searching shows: https://fcp.surfsite.org/modules/newbb/viewtopic.php?topic_id=61801&forum=11 I've installed these rpm's but the executables use a different naming convention: i686-pc-mingw32* instead of what we check for: i686-mingw32*. Should we add this to our configure? -- Cheers, Paul.

3 2

Re: cryptdlg: Implement FormatVerisignExtension (take 2)
by Alexandre Julliard Nov. 20, 2008

Nov. 20, 2008

"Juan Lang" <juan.lang(a)gmail.com> writes: > + LPWSTR verisign_statement; > + DWORD bytesNeeded; > + > + LoadStringW(hInstance, IDS_VERISIGN_STATEMENT, > + (LPWSTR)&verisign_statement, 0); > + bytesNeeded = (strlenW(verisign_statement) + 1) * sizeof(WCHAR); You can't use strlenW here, the string is not null-terminated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw/tests: Make the webbrowser test dpi aware, make is pass in wine
by Paul Vriens Nov. 20, 2008

Nov. 20, 2008

Detlef Riekenberg wrote: > I set every dpi between 72 and 100 on Windows, wrote down the results > and > multiplied the results with the dpi value. > The formula ist the best guess. > Works on win98, w2k, Wine > Hi Detlef, This one introduces some extra failures now. If I look at the comment in your patch it says: /* The default size is dpi dependent (96:1323x529 / 120:1058x423) */ and if I look at some of the results on test.winehq.org: webbrowser.c:1840: Test failed: size = {1323 529} (expected 1322 529) This suggests that the calculation in the ok() should be rounded up? Or maybe deal with both situations? -- Cheers, Paul.

1 0

Re: dlls/rpcrt4: fixed dead increments (llvm/clang)
by Rob Shearman Nov. 19, 2008

Nov. 19, 2008

2008/11/18 ricardo filipe <ricardo_barbano(a)hotmail.com>: > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index 3d66740..815ed64 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -479,7 +479,6 @@ static size_t rpcrt4_ncacn_np_get_top_of_tower(unsigned char *tower_data, > memcpy(tower_data, networkaddr, networkaddr_size); > else > tower_data[0] = 0; > - tower_data += networkaddr_size; > > return size; > } > @@ -692,7 +691,6 @@ static size_t rpcrt4_ncalrpc_get_top_of_tower(unsigned char *tower_data, > pipe_floor->count_rhs = endpoint_size; > > memcpy(tower_data, endpoint, endpoint_size); > - tower_data += endpoint_size; > > return size; > } These increments are intentional in case the code is copy and pasted and some more data is added to the end, so please don't remove them. -- Rob Shearman

2 1

Re: dlls/ole32: fixed dead assignments (llvm/clang)
by Rob Shearman Nov. 19, 2008

Nov. 19, 2008

2008/11/18 ricardo filipe <ricardo_barbano(a)hotmail.com>: > @@ -1951,6 +1951,12 @@ HRESULT WINAPI CoRegisterClassObject( > newClass->pMarshaledData, > flags & (REGCLS_MULTIPLEUSE|REGCLS_MULTI_SEPARATE), > &newClass->RpcRegistration); > + MSHLFLAGS_TABLESTRONG); This won't compile. > + if (hr) { > + FIXME("RPC_StartLocalServer failed, %x!\n",hr); You should change this to: ERR("RPC_StartLocalServer failed with error 0x%x\n",hr); > + return hr; > + } > + > } > return S_OK; > } > diff --git a/dlls/ole32/ole16.c b/dlls/ole32/ole16.c > index a8fa59b..21fb1fb 100644 > --- a/dlls/ole32/ole16.c > +++ b/dlls/ole32/ole16.c > @@ -598,13 +598,13 @@ HRESULT WINAPI CLSIDFromProgID16(LPCOLESTR16 progid, LPCLSID riid) > > buf = HeapAlloc(GetProcessHeap(),0,strlen(progid)+8); > sprintf(buf,"%s\\CLSID",progid); > - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { > + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey)) { Since you are changing this anyway, you should explicitly compare the result against ERROR_SUCCESS to improve readability of the code here. > HeapFree(GetProcessHeap(),0,buf); > return CO_E_CLASSSTRING; > } > HeapFree(GetProcessHeap(),0,buf); > buf2len = sizeof(buf2); > - if ((err=RegQueryValueA(xhkey,NULL,buf2,&buf2len))) { > + if (RegQueryValueA(xhkey,NULL,buf2,&buf2len)) { Ditto. > RegCloseKey(xhkey); > return CO_E_CLASSSTRING; > } -- Rob Shearman

1 0

spec file syntax for VARIANT parameter
by Jeremy Drake Nov. 19, 2008

Nov. 19, 2008

In order to implement OleLoadPictureFile and OleLoadPictureFileEx, it will be necessary to change their entries in oleaut32.spec from stub to stdcall. The stdcall syntax wants a list of parameter types, which puts these functions in an unususal situation: they take a VARIANT (which is a struct, in case anyone is not familiar) by value as their first parameter. There does not seem to be any type defined in the spec file that fits this situation. I have been using ptr in my last couple of patches which add stub implementations for these functions, but when I tried to build this on cygwin I got errors like: undefined reference to `_OleLoadPictureFileEx(a)20' undefined reference to `_OleLoadPictureFile(a)8' Looking at the functions that are present in the .o file, I see they are really _OleLoadPictureFileEx(a)32 and _OleLoadPictureFile(a)20. Changing the spec file to list each VARIANT as 4 longs fixes these errors. My question is, should my next version of the patch list the VARIANT as 4 longs, or is there some better way to specify this that I'm not aware of? If not, is there a comment syntax for the spec file where I can explain why there are 4 long params where there should be one VARIANT? Thanks Jeremy

2 1

Re: dlls/msxml3: check some dead store results (llvm/clang)
by Paul Vriens Nov. 19, 2008

Nov. 19, 2008

ricardo filipe wrote: > only return value checking in this patch. > > _________________________________________________________________ > Confira vídeos com notícias do NY Times, gols direto do Lance, videocassetadas e muito mais no MSN Video! > http://video.msn.com/?mkt=pt-br > > > ------------------------------------------------------------------------ > > You are mixing tabs and spaces. -- Cheers, Paul.

1 0

RE: netapi32: Actually return a couple of return values.
by ricardo filipe Nov. 19, 2008

Nov. 19, 2008

it seems you two fixed the same, juan sent a patch in a previous wine-devel email. you might want to check that because you two have different solutions for the first problem, line 415. > From: kai.blin(a)gmail.com > Date: Wed, 19 Nov 2008 12:41:50 +0100 > Subject: netapi32: Actually return a couple of return values. > To: wine-patches(a)winehq.org > > > ricardo filipe <ricardo_barbano(a)hotmail.com> found a couple of dead return > value assignments in nbt.c and netbios.c > > Fix up these error paths. > --- > dlls/netapi32/nbt.c | 12 +++++++++++- > dlls/netapi32/netbios.c | 2 +- > 2 files changed, 12 insertions(+), 2 deletions(-) _________________________________________________________________ Receba GRÁTIS as mensagens do Messenger no seu celular quando você estiver offline. Conheça o MSN Mobile! http://mobile.live.com/signup/signup2.aspx?lc=pt-br

1 0

dead stores in netapi32
by ricardo filipe Nov. 19, 2008

Nov. 19, 2008

hi juan! i'm tracking some dead stores with Clang and i've found some in files you created that i'm not comfortable messing with. file dlls/netapi32/nbt.c: lines: 419 839 1185 1192 1201 file dlls/netapi32/netbios.c: lines: 634 636 i thought you might want to have a look at it :) regards, ricardo _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

3 3

Contribute to wine
by Krzysztof Drewniak Nov. 18, 2008

Nov. 18, 2008

I'd like to contribute something to wine, but I don't know what? Can I get a list? Krzys D. P.S. The audio is choppy on Ubuntu 8.10 with latest git.

3 2