November 2008 - Wine-Devel - list.winehq.org

dead stores in msxml3
by ricardo filipe Nov. 18, 2008

Nov. 18, 2008

hi leslie. i'm tracking some dead stores with Clang and there are some in dlls/msxml3/saxreader.c i'm hoping you can tell me if the stores are to be removed for performance or if they should be checked in each iteration for correctness: file dlls/msxml3/saxreader.c lines: 1163 1166 1213 1216 regards, ricardo _________________________________________________________________ Confira vídeos com notícias do NY Times, gols direto do Lance, videocassetadas e muito mais no MSN Video! http://video.msn.com/?mkt=pt-br

2 1

Re: dlls/ntdll: fixed dead store (llvm/clang)
by Austin English Nov. 18, 2008

Nov. 18, 2008

On Tue, Nov 18, 2008 at 4:22 PM, ricardo filipe <ricardo_barbano(a)hotmail.com> wrote: > > > ________________________________ > Conheça já o Windows Live Spaces, o site de relacionamentos do Messenger! > Crie já o seu! > > > You forgot the patch. -- -Austin

1 0

Re: dlls/oleaut32: add tests for OleLoadPictureFile(Ex)
by Jeremy Drake Nov. 18, 2008

Nov. 18, 2008

On Tue, 18 Nov 2008, Michael Karcher wrote: > Looks OK to me, but what happened to your finding about > INET_E_RESOURCE_NOT_FOUND? Was it a red herring? I saw that on XP, but I couldn't reproduce it on Windows 2000. I need to investigate this further. Is there a mechansim to do windows-version-specific tests? > > I ended up having to add OleLoadPicutreFile and OleLoadPictureFileEx to > > the .spec and .c files as actual functions (for now just returning > > E_NOTIMPL) in order to get the test to even compile. > Might be that they don't appear in the ELF export table otherwise, and > as we don't crossbuild the tests, the imports are done by the ELF > linker/loader. BTW: In general, if you add stubs like this, please add a > FIXME call showing the parameters and saying stub. How do I show the VARIANT in the FIXME call? > This fragment repeats over and over, sometimes with PICTYPE_BITMAP > instead. Might be worth refactoring that into a function. todo_wine > works for function boundaries. If you refactor, you should pass that > function __LINE__ information and print it in your OK calls to know > which of the tests is failing if something fails. > > You do a lot of tests like this. Setting disp to "(void*)0xdeadbeef" > instead before allows you to differentiate between disp unmodified and > disp explicitly set to zero. Good ideas. I'll do that.

2 1

Re: cryptdlg(2/2): Implement FormatVerisignExtension
by Alexandre Julliard Nov. 18, 2008

Nov. 18, 2008

"Juan Lang" <juan.lang(a)gmail.com> writes: > + if (dwFormatStrType & CRYPT_FORMAT_STR_NO_HEX) > + { > + static BOOL stringLoaded = FALSE; > + DWORD bytesNeeded; > + > + if (!stringLoaded) > + { > + LoadStringW(hInstance, IDS_VERISIGN_STATEMENT, verisign_statement, > + sizeof(verisign_statement) / sizeof(verisign_statement[0])); > + stringLoaded = TRUE; > + } There's no need to store a copy of the string. You should load it directly into the destination buffer. -- Alexandre Julliard julliard(a)winehq.org

2 2

Another source of hardware statistics!
by Dan Kegel Nov. 18, 2008

Nov. 18, 2008

Unity3d is a game engine for casual gaming (not hardcore gaming). They have some good data on their user base's hardware at http://unity3d.com/webplayer/hwstats e.g. their breakdown of video cards for this quarter is at http://unity3d.com/webplayer/hwstats/pages/web-2008Q4-gfxcard.html Their top 3 graphics cards are Intel 945 (GMA 950) 13.3% Nvidia GeForce 6100 7.5% ATI Radeon X300/X550/Xpress200/1100 6.9% And believe it or not, 8% of their users still only have 256MB of RAM... - Dan

1 0

Re: fix a crash in widl on Vista x86
by Rob Shearman Nov. 18, 2008

Nov. 18, 2008

2008/11/17 <netzimme(a)aim.com>: > Changelog: > Add a FIXME for the crash in widl on Vista x86. > > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index fcb141e..45467e5 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -3137,7 +3137,7 @@ size_t get_size_procformatstring(const > statement_list_t *stmts, type_pred_t pred > size += get_size_procformatstring(stmt->u.lib->stmts, pred) - 1; > continue; > } > - else if (stmt->type != STMT_TYPE && stmt->u.type->type != > RPC_FC_IP) > + else if (stmt->type != STMT_TYPE || stmt->u.type->type != > RPC_FC_IP) > continue; > > iface = stmt->u.type; Looks good. I had the same fix queued up in my tree. However, your changelog message needs some work. The bug isn't specific to Vista x86, but is probably specific to the IDL file you are compiling. -- Rob Shearman

1 0

NT driver address space
by Alexander Morozov Nov. 18, 2008

Nov. 18, 2008

Hi, Under Wine NT drivers are running in user address space. Some drivers do not work correctly because of this. For example Guardant USB token driver crashes when loading but this problem can be fixed with such patch (really I tested with our wine fork): diff --git a/dlls/ntdll/virtual.c b/dlls/ntdll/virtual.c index 78e38dc..f607f22 100644 --- a/dlls/ntdll/virtual.c +++ b/dlls/ntdll/virtual.c @@ -904,6 +904,7 @@ static NTSTATUS map_image( HANDLE hmapping, int fd, char *base, SIZE_T total_siz server_enter_uninterrupted_section( &csVirtual, &sigset ); + if (0x10000 == base) base = 0x81000000; if (base >= (char *)0x110000) /* make sure the DOS area remains free */ status = map_view( &view, base, total_size, mask, FALSE, VPROT_COMMITTED | VPROT_READ | VPROT_EXEC | VPROT_WRITECOPY | VPROT_IMAGE ); diff --git a/libs/wine/mmap.c b/libs/wine/mmap.c index ff117cc..4c18683 100644 --- a/libs/wine/mmap.c +++ b/libs/wine/mmap.c @@ -346,7 +346,7 @@ void mmap_init(void) #if defined(__i386__) && !defined(__FreeBSD__) && !defined(__FreeBSD_kernel__) /* commented out until FreeBSD gets fixed */ char stack; char * const stack_ptr = &stack; - char *user_space_limit = (char *)0x7ffe0000; + char *user_space_limit = (char *)0xaffe0000; reserve_malloc_space( 8 * 1024 * 1024 ); I see two ways of fixing this. 1. Modify wine to run winedevice.exe in kernel address space (> 0x80000000) by checking name of executable. 2. Modify ExAllocatePool and some other functions to use kernel address space, modify functions which is used by drivers (ntoskrnl.exe exports etc.) to use only this memory allocation functions, modify winedevice.exe to load driver and create stack in kernel address space. What is better decision? Thanks, Alexander Morozov

1 0

Re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games
by Henri Verbeet Nov. 18, 2008

Nov. 18, 2008

2008/11/18 Stefan Dösinger <stefan(a)codeweavers.com>: > I think it would be better f getColorBits returned a proper error to the > caller, and the caller handles these errors without spamming the FIXME or > ERR channel. That would seem better to me than prefiltering the parameters > It does, it returns FALSE for "unsupported" formats. The only thing the patch fixes is the FIXME & ERR output. I think there are places where we'd like getColorBits() to work properly for float formats though.

1 0

Re: dlls/cabinet: fix dead stores (llvm/clang)
by Dmitry Timoshkov Nov. 18, 2008

Nov. 18, 2008

"ricardo filipe" <ricardo_barbano(a)hotmail.com> wrote: > --- a/dlls/cabinet/fci.c > +++ b/dlls/cabinet/fci.c > @@ -462,7 +462,7 @@ static cab_ULONG fci_get_checksum(const void *pv, UINT cb, CHECKSUM seed) > case 2: > ul |= (((ULONG)(*pb++)) << 8); > case 1: > - ul |= *pb++; > + ul |= *pb; > default: > break; > } Is there any reason that you ignored 2 similar cases above? -- Dmitry.

3 2

Re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games
by Henri Verbeet Nov. 18, 2008

Nov. 18, 2008

> + switch(Format) > + { > + case WINED3DFMT_X8R8G8B8: > + case WINED3DFMT_R8G8B8: > + case WINED3DFMT_A8R8G8B8: > + case WINED3DFMT_A2R10G10B10: > + case WINED3DFMT_X1R5G5B5: > + case WINED3DFMT_A1R5G5B5: > + case WINED3DFMT_R5G6B5: > + case WINED3DFMT_X4R4G4B4: > + case WINED3DFMT_A4R4G4B4: > + case WINED3DFMT_R3G3B2: > + case WINED3DFMT_A8P8: > + case WINED3DFMT_P8: > + /* taken from utils.c/getColorBits() */ > + break; > + default: > + /* getColorBits doesn't work here, so avoid the silly error messages. */ > + return FALSE; > + } As you mention in the bug report, this is not a proper fix. We should probably fix the format table to use a shift and a bitcount.

1 0

Re: [PATCH 1/2] Implement GdipGetLogFontA (try3)
by Adam Petaccia Nov. 17, 2008

Nov. 17, 2008

Was there something wrong with this patch series? On Tue, 2008-11-11 at 11:24 -0500, Adam Petaccia wrote: > Changelog: > try3: > Only copy the bytes we'll use > Toss out bytesWritten > try2: > Fix memcpy() use > Add documentation > Add testcase > --- > dlls/gdiplus/font.c | 27 +++++++++++++++++++++++++++ > dlls/gdiplus/gdiplus.spec | 2 +- > include/gdiplusflat.h | 1 + > 3 files changed, 29 insertions(+), 1 deletions(-) > > diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c > index 32713c7..7f815b6 100644 > --- a/dlls/gdiplus/font.c > +++ b/dlls/gdiplus/font.c > @@ -368,6 +368,33 @@ GpStatus WINGDIPAPI GdipGetFontUnit(GpFont *font, Unit *unit) > } > > /******************************************************************************* > + * GdipGetLogFontA [GDIPLUS.@] > + * > + * Converts a font into a LOGFONTA > + * > + * PARAMS > + * font [I] GpFont to create LOGFONTA object > + * graphics [I] Current graphics context > + * lfa [O] Resulting LOGFONTA object > + * RETURNS > + * InvalidParameter: font, graphics, or lfa was NULL. > + * Ok: otherwise > + */ > +GpStatus WINGDIPAPI GdipGetLogFontA(GpFont *font, GpGraphics *graphics, > + LOGFONTA *lfa) > +{ > + /* FIXME: use graphics */ > + if(!(font && graphics && lfa)) > + return InvalidParameter; > + > + memcpy(lfa, &font->lfw, FIELD_OFFSET(LOGFONTA, lfFaceName)); > + WideCharToMultiByte(CP_ACP, 0, font->lfw.lfFaceName, -1, > + lfa->lfFaceName, LF_FACESIZE, NULL, NULL); > + > + return Ok; > +} > + > +/******************************************************************************* > * GdipGetLogFontW [GDIPLUS.@] > */ > GpStatus WINGDIPAPI GdipGetLogFontW(GpFont *font, GpGraphics *graphics, > diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec > index c25d4b7..dce558c 100644 > --- a/dlls/gdiplus/gdiplus.spec > +++ b/dlls/gdiplus/gdiplus.spec > @@ -311,7 +311,7 @@ > @ stdcall GdipGetLineSpacing(ptr long ptr) > @ stub GdipGetLineTransform > @ stdcall GdipGetLineWrapMode(ptr ptr) > -@ stub GdipGetLogFontA > +@ stdcall GdipGetLogFontA(ptr ptr ptr) > @ stdcall GdipGetLogFontW(ptr ptr ptr) > @ stdcall GdipGetMatrixElements(ptr ptr) > @ stub GdipGetMetafileDownLevelRasterizationLimit > diff --git a/include/gdiplusflat.h b/include/gdiplusflat.h > index ea4bec5..a2c6fc9 100644 > --- a/include/gdiplusflat.h > +++ b/include/gdiplusflat.h > @@ -81,6 +81,7 @@ GpStatus WINGDIPAPI GdipCreateFontFromDC(HDC,GpFont**); > GpStatus WINGDIPAPI GdipCreateFontFromLogfontA(HDC,GDIPCONST LOGFONTA*,GpFont**); > GpStatus WINGDIPAPI GdipCreateFontFromLogfontW(HDC,GDIPCONST LOGFONTW*,GpFont**); > GpStatus WINGDIPAPI GdipDeleteFont(GpFont*); > +GpStatus WINGDIPAPI GdipGetLogFontA(GpFont*,GpGraphics*,LOGFONTA*); > GpStatus WINGDIPAPI GdipGetLogFontW(GpFont*,GpGraphics*,LOGFONTW*); > GpStatus WINGDIPAPI GdipGetFamily(GpFont*, GpFontFamily**); > GpStatus WINGDIPAPI GdipGetFontUnit(GpFont*, Unit*);

2 1

Re: implement OleLoadPictureFile
by Austin English Nov. 17, 2008

Nov. 17, 2008

On Wed, Nov 12, 2008 at 2:16 AM, Jeremy Drake <wine(a)jdrake.com> wrote: > I ran into a function that was not implemented when attempting to run a > program I work on under wine. > > This patch implements OleLoadPictureFile based on the MSDN docs > (http://msdn.microsoft.com/en-us/library/ms221680.aspx) and what I saw > when stepping through in windbg on XP. > > A few notes: > I'm not sure I got the spec file right. The first param is a VARIANT, not > a VARIANT *, so I'm not sure ptr is the right thing. > > I'm not sure the right way to do the TRACE call with the VARIANT param. > > I did not implement OleLoadPictureFileEx. Technically, OleLoadPictureFile > should call OleLoadPictureFileEx(varFilename, LP_DEFAULT, LP_DEFAULT, > LP_DEFAULT, ppdispPicture) and OleLoadPictureEx should pass the sizeX, > sizeY, and flags to OleLoadPictureEx. > > When stepping through the function in windbg, I saw it call a function > OLEAUT32!CreateFileStream which does not exist in wine anywhere. Instead > of using that, I used the same mechanism as was used in OleLoadPicturePath > (GlobalAlloc the size of the file, read the whole file in, and > CreateStreamOnHGlobal). > > Since this is my first wine patch, I hope you will forgive me these > shortcomings. I'm not subscribed to any wine list, so please copy me on > any replies. > > Thanks, > Jeremy > > > > -- > Personifiers Unite! You have nothing to lose but Mr. Dignity! > > > Can you add a testcase to show that this behavior is correct? -- -Austin

5 12

re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games
by Dan Kegel Nov. 17, 2008

Nov. 17, 2008

Andrew wrote: >When sending a patch to wine-patches put the patch number followed by >how many patches you are sending so the automated scripts can read it. yes, please! > For example "[1/1] sending only one patch". Poor example, please don't do it on single patches. You only need to do it for series of more than one patch. Also please don't send patches that don't apply cleanly against current git. (You'd be surprised how many people do this. It's ok if Alexandre can figure it out, but poor old Patchwatcher will reject it.) - Dan

1 0

Re: [1/5] WineD3D: Get some vertex pipeline infrastructure in place
by Henri Verbeet Nov. 17, 2008

Nov. 17, 2008

2008/11/17 Stefan Dösinger <stefan(a)codeweavers.com>: > - } else if (fixup || > + } else if (device->vertex_pipe->can_convert_d3dcolor || fixup || Shouldn't this be redundant if you already handle color conversion in IWineD3DVertexBufferImpl_FindDecl()? > - } else { > + } else if(!device->vertex_pipe->can_convert_d3dcolor) { I don't think this is how we want to do this. I think it makes more sense to ask the pipeline if it can handle a particular type for a particular usage. You can handle FLOAT16 support in the same way then. Also note that EXT_vertex_array_bgra adds support for D3DCOLOR, but only for diffuse, specular and generic attributes. That should be enough for anything we come across, but with a "can_convert_d3dcolor" flag like that you can't handle that extension properly.

2 3

Re: Patch for [Bug 16087] wine spews innumerable "Unable to check compatibility for Format..." errors in some games
by Andrew Fenn Nov. 17, 2008

Nov. 17, 2008

Your patch adds extra whitespace on an empty line. You are mixing coding styles with your if statements. When sending a patch to wine-patches put the patch number followed by how many patches you are sending so the automated scripts can read it. For example "[1/1] sending only one patch". 2008/11/16 Bogdan Butnaru <bogdanb(a)gmail.com>: > Patch for http://bugs.winehq.org/show_bug.cgi?id=16087 > > -- > Bogdan Butnaru > > > >

1 0

Re: (try 5) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.
by Alexandre Julliard Nov. 17, 2008

Nov. 17, 2008

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -182,19 +182,26 @@ static UINT CALLBACK create_view_window2_hook(HWND dlg, UINT msg, WPARAM wParam, > > hr = IShellView2_GetCurrentInfo(shell_view2, &folder_settings); > ok(SUCCEEDED(hr), "GetCurrentInfo returned %#x\n", hr); > - ok(folder_settings.ViewMode == FVM_LIST, "view mode is %d, expected %d\n", folder_settings.ViewMode, FVM_LIST); > + ok(folder_settings.ViewMode == FVM_DETAILS, "view mode is %d, expected %d\n", folder_settings.ViewMode, FVM_DETAILS); > > hr = IShellView2_DestroyViewWindow(shell_view2); > ok(SUCCEEDED(hr), "DestroyViewWindow returned %#x\n", hr); > > - view_params.pvid = &VID_Details; > + folder_settings.ViewMode = FVM_LIST; > + folder_settings.fFlags = 0; > + view_params.pvid = NULL; > hr = IShellView2_CreateViewWindow2(shell_view2, &view_params); > - ok(SUCCEEDED(hr), "CreateViewWindow2 returned %#x\n", hr); > + /* > + * Windows XP is unable to recreate the ViewWindow2 returning > + * A Catastrophic failure error > + */ So why can't it recreate it? Do you need to clean up something else beforehand? -- Alexandre Julliard julliard(a)winehq.org

2 1

[wdm.h] AddDevice member
by Alessandro Nov. 17, 2008

Nov. 17, 2008

Hi, I've noticed that the AddDevice member of DRIVER_EXTENSION is not declared as a functio pointer. I've put up a patch to fix this. Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

1 0

Re: msxml3: Determine whether to call xsltInit() or not at run time.
by Michael Karcher Nov. 17, 2008

Nov. 17, 2008

Am Montag, den 17.11.2008, 15:09 +0100 schrieb Francois Gouget: > configure will need to be regenerated. I did not include it here since > the consensus seems to be that it should not be included. Just a nitpick: Same applies for config.h.in, then. > As a reminder, the issue is that it's not because the libxslt.so we > compile against has xlstInit() that the one we load at runtime will have > it too. And vice versa. Wait a moment. I don't know about Wine's dl* functions, but can't we use dlsym with the RTLD_DEFAULT handle to look in the libxslt msxml3.dll.so is linked with anyway? That would do away with the need to know the soname during compilation. As it is hardcoded into the executable during link, hard-coding the soname doesn't hurt that much too, but still it gets simpler Regards, Michael Karcher

2 1

Race in thread shutdown in imm32?
by Dan Kegel Nov. 17, 2008

Nov. 17, 2008

I'm seeing the following valgrind warning in three out of eight runs under heavy load: InvalidRead IMM_FreeThreadData:233 DllMain:382 __wine_spec_dll_entry:40 MODULE_InitDLL:911 LdrShutdownThread:2174 call_thread_func:403 start_thread:444 It kind of feels like a race between thread shutdown and process shutdown. Does that ring a bell with anyone? - Dan

3 3

New error: cp: X and X are the same file
by Dan Kegel Nov. 17, 2008

Nov. 17, 2008

I'm seeing a lot of errors like this lately: cp: `/home/dank/.local/share/icons/3550_shell32.0.xpm' and `/home/dank/.local/share/icons/3550_shell32.0.xpm' are the same file Did the recent rewrite of menu item creation break something?

1 0

Re: ntoskrnl.exe: Implement MmGetSystemRoutineAddress
by Dmitry Timoshkov Nov. 17, 2008

Nov. 17, 2008

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > + if(RtlUnicodeStringToAnsiString(&routineNameA, SystemRoutineName, TRUE) == STATUS_SUCCESS) > + { > + /* We only support functions exported from ntoskrnl.exe or hal.dll */ > + hMod = GetModuleHandleW(ntoskrnlW); > + if(hMod) > + { > + pFunc = GetProcAddress(hMod, routineNameA.Buffer); > + } You are calling GetModuleHandleW from inside of ntoskrnl.exe, how that could fail? > + if(!pFunc) > + { > + hMod = GetModuleHandleW(halW); > + if(hMod) > + { > + pFunc = GetProcAddress(hMod, routineNameA.Buffer); > + } > + } > + > + RtlFreeAnsiString(&routineNameA); > + } > + > + TRACE("Function addresss %p\n", pFunc); > + > + return pFunc; > +} Please follow the existing coding style, place a space after 'if' and avoid not necessary braces for single line statements after 'if'. -- Dmitry.

1 0

ComputeSphereVisibility: a patch
by paulo lesgaz Nov. 17, 2008

Nov. 17, 2008

Hi, here is a patch for a first try to implement ComputeSphereVisibility. Any feedback is welcome. David

3 5

Grumble. Kernel lockup in Intrepid.
by Dan Kegel Nov. 17, 2008

Nov. 17, 2008

Wonder why patchwatcher was down for 12 hours? It seems to have been a kernel problem. This is on an Ubuntu 8.10 32 bit Core 2 Duo system on a P5K Pro motherboard, with a PCI-E NVidia card. I have the proprietary Nvidia drivers installed, so I can't expect support from anybody, but I did want to at least kvetch in public somewhere. The build slave was unresponsive. Upon rebooting, I found the following in /var/log/messages: Nov 15 18:07:05 slave2 kernel: [1146762.712500] Modules linked in: nfs lockd nfs_acl sunrpc af_packet binfmt_misc rfcomm bridge stp bnep sco l2cap bluetooth ppdev ipv6 acpi_cpufreq cpufreq_stats cpufreq_userspace cpufreq_powersave cpufreq_conservative cpufreq_ondemand freq_table sbs wmi sbshc video output container pci_slot battery iptable_filter ip_tables x_tables ac sbp2 parport_pc lp parport snd_hda_intel psmouse pcspkr serio_raw evdev snd_pcm_oss snd_mixer_oss nvidia(P) snd_pcm i2c_core snd_seq_dummy iTCO_wdt iTCO_vendor_support snd_seq_oss snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq snd_timer snd_seq_device snd shpchp soundcore button pci_hotplug snd_page_alloc intel_agp agpgart ext3 jbd mbcache sr_mod cdrom sd_mod crc_t10dif sg pata_marvell pata_acpi usbhid hid natsemi ata_generic ohci1394 ieee1394 ata_piix libata scsi_mod dock sky2 ehci_hcd uhci_hcd usbcore thermal processor fan fbcon tileblit font bitblit softcursor fuse Nov 15 18:07:05 slave2 kernel: [1146762.712501] Nov 15 18:07:05 slave2 kernel: [1146762.712501] Pid: 21048, comm: wrc Tainted: P (2.6.27-7-generic #1) Nov 15 18:07:05 slave2 kernel: [1146762.712501] EIP: 0060:[<c0184320>] EFLAGS: 00000286 CPU: 1 Nov 15 18:07:05 slave2 kernel: [1146762.712501] EIP is at find_get_pages+0x70/0x110 Nov 15 18:07:05 slave2 kernel: [1146762.712501] EAX: ee96fa7c EBX: c1d5ac50 ECX: e2333d38 EDX: 00000000 Nov 15 18:07:05 slave2 kernel: [1146762.712501] ESI: e2333d30 EDI: e2333d38 EBP: e2333ce8 ESP: e2333cb8 Nov 15 18:07:05 slave2 kernel: [1146762.712501] DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 Nov 15 18:07:05 slave2 kernel: [1146762.712501] CR0: 8005003b CR2: 09c28000 CR3: 35009000 CR4: 00000690 Nov 15 18:07:05 slave2 kernel: [1146762.712501] DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000 Nov 15 18:07:05 slave2 kernel: [1146762.712501] DR6: ffff0ff0 DR7: 00000403 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c018d4d7>] pagevec_lookup+0x27/0x40 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c018e2ac>] truncate_inode_pages_range+0x8c/0x360 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<f89e9c7f>] ? do_get_write_access+0x2df/0x4b0 [jbd] Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<f8a23174>] ? ext3_get_group_desc+0x14/0xd0 [ext3] Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c018e59f>] truncate_inode_pages+0x1f/0x30 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c0195d11>] vmtruncate+0x161/0x190 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01c85d2>] inode_setattr+0x62/0x190 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<f8a28ef9>] ext3_setattr+0xd9/0x210 [ext3] Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01c89d6>] fnotify_change+0x2d6/0x3b0 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01b9d81>] ? path_permission+0x31/0x40 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01b0f56>] do_truncate+0x76/0xa0 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c023528f>] ? apparmor_path_permission+0x5f/0x80 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01ba6f3>] may_open+0x193/0x210 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01bda75>] do_filp_open+0x115/0x790 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01c9619>] ? expand_files+0x9/0x60 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01c9750>] ? alloc_fd+0xe0/0x100 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01afff5>] do_sys_open+0x65/0x100 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c01b00fe>] sys_open+0x2e/0x40 Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c0103f7b>] sysenter_do_call+0x12/0x2f Nov 15 18:07:05 slave2 kernel: [1146762.712501] [<c0370000>] ? default_device_exit+0x60/0xb0 It crashed in the middle of a wine build. The last thing in the patchwatcher log was make[1]: Leaving directory `/home/patchslave/winezeug/patchwatcher/wine-continuous-workdir/active/dlls' make[2]: Entering BIOS reported the temperature was 56 degrees after rebooting, fwiw. This is the first problem on this machine since I set it up several weeks ago. I guess I'll just reboot it and hope...

2 1

d3dx9: Add ID3DXSprite tests (review please)
by Tony Wasserka Nov. 16, 2008

Nov. 16, 2008

This is my first test, so I think it's better to ask for feedback on wine-devel, first. There are some points, where I wasn't sure what to do: line 26: Is using inline okay here? IIRC that's C++ only, but other tests do it the same way... line 82: Is it legal to demand A8R8G8B8 support here? Otherwise, how would I do this without making the code overcomplicated? For what other formats should I check then? line 120-123: I hope it's okay to use hardcoded matrix values here, as the point of that test is only to make sure that the same matrix gets returned... line 215-253: 1) Is it okay to initialize D3D that way? 2) Can I simplify the initialization even further? Also, I'd like to know wether the code in general is clean enough. Any other feedback is welcome, too. Best regards, Tony (Note1: This test only finishes successfully if my recent ID3DXSprite patch series is applied, but I already had all of them pass/todo'ed. Note2: visual tests will follow later, this is just for the basic functionality) >From 02587ae3cedb0b68fba1c360f63d2571c175bf07 Mon Sep 17 00:00:00 2001 From: Tony Wasserka <tony.wasserka(a)freenet.de> Date: Sun, 16 Nov 2008 12:26:06 +0100 Subject: [PATCH] d3dx9: Add ID3DXSprite tests --- dlls/d3dx9_36/tests/Makefile.in | 3 +- dlls/d3dx9_36/tests/core.c | 252 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 254 insertions(+), 1 deletions(-) create mode 100644 dlls/d3dx9_36/tests/core.c diff --git a/dlls/d3dx9_36/tests/Makefile.in b/dlls/d3dx9_36/tests/Makefile.in index 40500e2..1ac8b7e 100644 --- a/dlls/d3dx9_36/tests/Makefile.in +++ b/dlls/d3dx9_36/tests/Makefile.in @@ -3,9 +3,10 @@ TOPOBJDIR = ../../.. SRCDIR = @srcdir@ VPATH = @srcdir@ TESTDLL = d3dx9_36.dll -IMPORTS = d3dx9 kernel32 +IMPORTS = d3dx9 d3d9 user32 kernel32 CTESTS = \ + core.c \ math.c \ shader.c diff --git a/dlls/d3dx9_36/tests/core.c b/dlls/d3dx9_36/tests/core.c new file mode 100644 index 0000000..2d15859 --- /dev/null +++ b/dlls/d3dx9_36/tests/core.c @@ -0,0 +1,252 @@ +/* + * Tests for the D3DX9 core interfaces + * + * Copyright 2008 Tony Wasserka + * + * This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + * Lesser General Public License for more details. + * + * You should have received a copy of the GNU Lesser General Public + * License along with this library; if not, write to the Free Software + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA + */ + +#define COBJMACROS +#include "wine/test.h" +#include <dxerr9.h> +#include "d3dx9core.h" + +static inline int get_ref(IUnknown *obj) +{ + if(!obj) return 0; + IUnknown_AddRef(obj); + return IUnknown_Release(obj); +} + +#define CHECK_REF(obj, exp) \ + ok(exp==get_ref((IUnknown*)(obj)), "Invalid refcount. Expected %d, got %d\n", exp, get_ref((IUnknown*)(obj))); + +#define CHECK_RELEASE(obj, exp) \ + { \ + if(obj) { \ + int ref=IUnknown_Release((IUnknown*)(obj)); \ + ok(ref==exp, "Invalid refcount. Expected %d, got %d\n", exp, ref); \ + } else skip("Object was NULL before Release\n"); \ + } + +#define CHECK_CALL(call, name, exp) \ + hr=(call); \ + ok(hr==(exp), "%s returned %#x, expected %#x\n", (name), hr, (exp)); + +#define admitted_error 0.0001f +static inline void check_mat(D3DXMATRIX got, D3DXMATRIX exp) +{ + int i, j, equal=1; + for (i=0; i<4; i++) + for (j=0; j<4; j++) + if (fabs(U(exp).m[i][j]-U(got).m[i][j]) > admitted_error) + equal=0; + + ok(equal, "Got matrix\n\t(%f,%f,%f,%f\n\t %f,%f,%f,%f\n\t %f,%f,%f,%f\n\t %f,%f,%f,%f)\n" + "Expected matrix=\n\t(%f,%f,%f,%f\n\t %f,%f,%f,%f\n\t %f,%f,%f,%f\n\t %f,%f,%f,%f)\n", + U(got).m[0][0],U(got).m[0][1],U(got).m[0][2],U(got).m[0][3], + U(got).m[1][0],U(got).m[1][1],U(got).m[1][2],U(got).m[1][3], + U(got).m[2][0],U(got).m[2][1],U(got).m[2][2],U(got).m[2][3], + U(got).m[3][0],U(got).m[3][1],U(got).m[3][2],U(got).m[3][3], + U(exp).m[0][0],U(exp).m[0][1],U(exp).m[0][2],U(exp).m[0][3], + U(exp).m[1][0],U(exp).m[1][1],U(exp).m[1][2],U(exp).m[1][3], + U(exp).m[2][0],U(exp).m[2][1],U(exp).m[2][2],U(exp).m[2][3], + U(exp).m[3][0],U(exp).m[3][1],U(exp).m[3][2],U(exp).m[3][3]); +} + +static void test_ID3DXSprite(IDirect3DDevice9 *device) +{ + ID3DXSprite *sprite=NULL; + IDirect3D9 *d3d; + IDirect3DDevice9 *cmpdev=NULL; + IDirect3DTexture9 *tex1=NULL, *tex2=NULL; + D3DXMATRIX mat, cmpmat; + D3DVIEWPORT9 vp; + RECT rect; + D3DXVECTOR3 pos, center; + HRESULT hr; + + IDirect3DDevice9_GetDirect3D(device, &d3d); + if(FAILED(IDirect3D9_CheckDeviceFormat(d3d, 0, D3DDEVTYPE_HAL, D3DFMT_UNKNOWN, 0, D3DRTYPE_TEXTURE, D3DFMT_A8R8G8B8))) { + skip("D3DFMT_A8R8B8G8 not supported\n"); + return; + } + IDirect3D9_Release(d3d); + + if(FAILED(hr=IDirect3DDevice9_CreateTexture(device, 64, 64, 1, 0, D3DFMT_A8R8G8B8, D3DPOOL_DEFAULT, &tex1, NULL))) { + skip("Couldn't create first texture, CreateTexture returned %#x\n", hr); + return; + } + if(FAILED(hr=IDirect3DDevice9_CreateTexture(device, 32, 32, 1, 0, D3DFMT_A8R8G8B8, D3DPOOL_DEFAULT, &tex2, NULL))) { + skip("Couldn't create second texture, CreateTexture returned %#x\n", hr); + IDirect3DTexture9_Release(tex1); + return; + } + /* Test D3DXCreateSprite */ + CHECK_CALL(D3DXCreateSprite(device, NULL), "D3DXCreateSprite", D3DERR_INVALIDCALL); + CHECK_CALL(D3DXCreateSprite(NULL, &sprite), "D3DXCreateSprite", D3DERR_INVALIDCALL); + CHECK_CALL(D3DXCreateSprite(device, &sprite), "D3DXCreateSprite", D3D_OK); + + /* Test ID3DXSprite_GetDevice */ + CHECK_CALL(ID3DXSprite_GetDevice(sprite, NULL), "GetDevice", D3DERR_INVALIDCALL); + CHECK_CALL(ID3DXSprite_GetDevice(sprite, &cmpdev), "GetDevice", D3D_OK); /* cmpdev=NULL */ + CHECK_CALL(ID3DXSprite_GetDevice(sprite, &cmpdev), "GetDevice", D3D_OK); /* cmpdev!=NULL */ + IDirect3DDevice9_Release(device); + IDirect3DDevice9_Release(device); + + /* Test ID3DXSprite_GetTransform */ + CHECK_CALL(ID3DXSprite_GetTransform(sprite, NULL), "GetTransform", D3DERR_INVALIDCALL); + CHECK_CALL(ID3DXSprite_GetTransform(sprite, &mat), "GetTransform", D3D_OK); + if(SUCCEEDED(hr)) { + D3DXMATRIX identity; + D3DXMatrixIdentity(&identity); + check_mat(mat, identity); + } else skip("No matrix to test\n"); + + /* Test ID3DXSprite_SetTransform */ + /* Set a transform and test if it gets returned correctly */ + U(mat).m[0][0]=2.1f; U(mat).m[0][1]=6.5f; U(mat).m[0][2]=-9.6f; U(mat).m[0][3]=1.7f; + U(mat).m[1][0]=4.2f; U(mat).m[1][1]=-2.5f; U(mat).m[1][2]=2.1f; U(mat).m[1][3]=5.5f; + U(mat).m[2][0]=-2.6f; U(mat).m[2][1]=0.3f; U(mat).m[2][2]=8.6f; U(mat).m[2][3]=8.4f; + U(mat).m[3][0]=6.7f; U(mat).m[3][1]=-5.1f; U(mat).m[3][2]=6.1f; U(mat).m[3][3]=2.2f; + CHECK_CALL(ID3DXSprite_SetTransform(sprite, NULL), "SetTransform", D3DERR_INVALIDCALL); + CHECK_CALL(ID3DXSprite_SetTransform(sprite, &mat), "SetTransform", D3D_OK); + if(SUCCEEDED(hr)) { + hr=ID3DXSprite_GetTransform(sprite, &cmpmat); + if(SUCCEEDED(hr)) check_mat(cmpmat, mat); + else skip("GetTransform returned %#x\n", hr); + } else skip("No matrix to test\n"); + + /* Test ID3DXSprite_SetWorldViewLH/RH */ + todo_wine { + CHECK_CALL(ID3DXSprite_SetWorldViewLH(sprite, &mat, &mat), "SetWorldViewLH", D3D_OK); + CHECK_CALL(ID3DXSprite_SetWorldViewLH(sprite, NULL, &mat), "SetWorldViewLH", D3D_OK); + CHECK_CALL(ID3DXSprite_SetWorldViewLH(sprite, &mat, NULL), "SetWorldViewLH", D3D_OK); + CHECK_CALL(ID3DXSprite_SetWorldViewLH(sprite, NULL, NULL), "SetWorldViewLH", D3D_OK); + CHECK_CALL(ID3DXSprite_SetWorldViewRH(sprite, &mat, &mat), "SetWorldViewRH", D3D_OK); + CHECK_CALL(ID3DXSprite_SetWorldViewRH(sprite, NULL, &mat), "SetWorldViewRH", D3D_OK); + CHECK_CALL(ID3DXSprite_SetWorldViewRH(sprite, &mat, NULL), "SetWorldViewRH", D3D_OK); + CHECK_CALL(ID3DXSprite_SetWorldViewRH(sprite, NULL, NULL), "SetWorldViewRH", D3D_OK); + } + IDirect3DDevice9_BeginScene(device); + + /* Test ID3DXSprite_Begin*/ + CHECK_CALL(ID3DXSprite_Begin(sprite, 0), "Begin", D3D_OK); + IDirect3DDevice9_GetTransform(device, D3DTS_WORLD, &mat); + D3DXMatrixIdentity(&cmpmat); + check_mat(mat, cmpmat); + IDirect3DDevice9_GetTransform(device, D3DTS_VIEW, &mat); + check_mat(mat, cmpmat); + IDirect3DDevice9_GetTransform(device, D3DTS_PROJECTION, &mat); + IDirect3DDevice9_GetViewport(device, &vp); + D3DXMatrixOrthoOffCenterLH(&cmpmat, vp.X+0.5f, (float)vp.Width+vp.X+0.5f, (float)vp.Height+vp.Y+0.5f, vp.Y+0.5f, vp.MinZ, vp.MaxZ); + check_mat(mat, cmpmat); + + /* Test ID3DXSprite_Flush and ID3DXSprite_End */ + CHECK_CALL(ID3DXSprite_Flush(sprite), "Flush", D3D_OK); + CHECK_CALL(ID3DXSprite_End(sprite), "End", D3D_OK); + CHECK_CALL(ID3DXSprite_Flush(sprite), "Flush", D3DERR_INVALIDCALL); /* May not be called before next Begin */ + CHECK_CALL(ID3DXSprite_End(sprite), "End", D3DERR_INVALIDCALL); + + /* Test ID3DXSprite_Draw */ + CHECK_CALL(ID3DXSprite_Begin(sprite, 0), "Begin", D3D_OK); + if(FAILED(hr)) skip("Couldn't ID3DXSprite_Begin, can't test ID3DXSprite_Draw\n"); + else { /* Feed the sprite batch */ + int texref1, texref2; + + SetRect(&rect, 0, 0, 192, 128); + pos.x=0.f; pos.y=10.f; pos.z=0.f; + center.x=192.f; center.y=0.f; center.z=0.f; + + texref1=get_ref((IUnknown*)tex1); + texref2=get_ref((IUnknown*)tex2); + CHECK_CALL(ID3DXSprite_Draw(sprite, NULL, &rect, &center, &pos, D3DCOLOR_XRGB(255, 255, 255)), "Draw", D3DERR_INVALIDCALL); + CHECK_CALL(ID3DXSprite_Draw(sprite, tex1, &rect, &center, &pos, D3DCOLOR_XRGB(255, 255, 255)), "Draw", D3D_OK); + CHECK_CALL(ID3DXSprite_Draw(sprite, tex2, &rect, &center, &pos, D3DCOLOR_XRGB( 3, 45, 66)), "Draw", D3D_OK); + CHECK_REF(tex1, texref1+1); CHECK_REF(tex2, texref2+1); + CHECK_CALL(ID3DXSprite_Flush(sprite), "Flush", D3D_OK); + CHECK_REF(tex1, texref1); CHECK_REF(tex2, texref2); + + CHECK_CALL(ID3DXSprite_Draw(sprite, tex1, NULL, &center, &pos, D3DCOLOR_XRGB(255, 255, 255)), "Draw", D3D_OK); + CHECK_CALL(ID3DXSprite_Draw(sprite, tex1, &rect, NULL, &pos, D3DCOLOR_XRGB(255, 255, 255)), "Draw", D3D_OK); + CHECK_CALL(ID3DXSprite_Draw(sprite, tex1, &rect, &center, NULL, D3DCOLOR_XRGB(255, 255, 255)), "Draw", D3D_OK); + CHECK_CALL(ID3DXSprite_Draw(sprite, tex1, NULL, NULL, NULL, 0), "Draw", D3D_OK); + CHECK_CALL(ID3DXSprite_Flush(sprite), "Flush", D3D_OK); + CHECK_CALL(ID3DXSprite_Flush(sprite), "Flush", D3D_OK); /* Flushing twice should work */ + CHECK_CALL(ID3DXSprite_End(sprite), "End", D3D_OK); + } + + /* Test ID3DXSprite_OnLostDevice and ID3DXSprite_OnResetDevice */ + /* Both can be called twice */ + CHECK_CALL(ID3DXSprite_OnLostDevice(sprite), "OnLostDevice", D3D_OK); + CHECK_CALL(ID3DXSprite_OnLostDevice(sprite), "OnLostDevice", D3D_OK); + CHECK_CALL(ID3DXSprite_OnResetDevice(sprite), "OnResetDevice", D3D_OK); + CHECK_CALL(ID3DXSprite_OnResetDevice(sprite), "OnResetDevice", D3D_OK); + + /* Make sure everything works like before */ + CHECK_CALL(ID3DXSprite_Begin(sprite, 0), "Begin", D3D_OK); + CHECK_CALL(ID3DXSprite_Draw(sprite, tex2, &rect, &center, &pos, D3DCOLOR_XRGB(255, 255, 255)), "Draw", D3D_OK); + CHECK_CALL(ID3DXSprite_Flush(sprite), "Flush", D3D_OK); + CHECK_CALL(ID3DXSprite_End(sprite), "End", D3D_OK); + + /* OnResetDevice makes the interface "forget" the Begin call */ + CHECK_CALL(ID3DXSprite_Begin(sprite, 0), "Begin", D3D_OK); + CHECK_CALL(ID3DXSprite_OnResetDevice(sprite), "OnResetDevice", D3D_OK); + CHECK_CALL(ID3DXSprite_End(sprite), "End", D3DERR_INVALIDCALL); + + IDirect3DDevice9_EndScene(device); + CHECK_RELEASE(sprite, 0); + CHECK_RELEASE(tex2, 0); + CHECK_RELEASE(tex1, 0); +} + +START_TEST(core) +{ + HWND wnd=NULL; + IDirect3D9 *d3d = NULL; + IDirect3DDevice9 *device=NULL; + D3DPRESENT_PARAMETERS d3dpp; + HRESULT hr; + + wnd=CreateWindow("static", "d3dx9_test", 0, 0, 0, 0, 0, NULL, NULL, NULL, NULL); + d3d=Direct3DCreate9(D3D_SDK_VERSION); + if(!wnd) { + skip("Couldn't create application window\n"); + return; + } + if(!d3d) { + skip("Couldn't create Direct3D9 object\n"); + DestroyWindow(wnd); + return; + } + + ZeroMemory(&d3dpp, sizeof(d3dpp)); + d3dpp.Windowed = TRUE; + d3dpp.SwapEffect = D3DSWAPEFFECT_DISCARD; + hr=IDirect3D9_CreateDevice(d3d, D3DADAPTER_DEFAULT, D3DDEVTYPE_HAL, wnd, + D3DCREATE_MIXED_VERTEXPROCESSING, &d3dpp, &device); + if(FAILED(hr)) { + skip("Failed to create Direct3DDevice9 object %#x\n", hr); + IDirect3D9_Release(d3d); + DestroyWindow(wnd); + return; + } + + test_ID3DXSprite(device); + + CHECK_RELEASE(device, 0); + CHECK_RELEASE(d3d, 0); + if(wnd) DestroyWindow(wnd); +} -- 1.5.6.5

3 3

Re: [5/5] WineD3D: Move the fogdensity state to the misc state table
by Austin English Nov. 16, 2008

Nov. 16, 2008

On Sun, Nov 16, 2008 at 5:20 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > fogstart and fogend will probably follow as well later, I still have to look > at those because they interfere with glEnable(GL_FOG) and the fog source > settings and are thus involved in the vertex pipeline as well > > > > > > You forgot the patch. -- -Austin

1 0

Re: d3dx9: Implement ID3DXSprite_OnLostDevice/OnResetDevice
by Henri Verbeet Nov. 16, 2008

Nov. 16, 2008

2008/11/15 Tony Wasserka <tony.wasserka(a)freenet.de>: > + if(This->sprites) { > + int i; > + for(i=0;i<This->sprite_count;i++) > + if(This->sprites[i].texture) This if should be redundant. I looked at some of the other sprite code, and noticed you've got similar constructions in other places. You also don't handle HeapAlloc/HeapReAlloc failures in most places. > + HeapFree(GetProcessHeap(), 0, This->sprites); Why do you free the sprites array here?

1 0

Re: d3dx9: ID3DXSprite: Move vdecl creation to ID3DXSprite_Begin [PATCH 2/3]
by Henri Verbeet Nov. 16, 2008

Nov. 16, 2008

As a general remark about drawing sprites, when shaders are available you can use those instead, which should save you from messing around with render states and texture stage states.

1 0

Re: d3dx9: Implement ID3DXSprite_*etTransform [PATCH 1/3]
by Henri Verbeet Nov. 16, 2008

Nov. 16, 2008

2008/11/15 Tony Wasserka <tony.wasserka(a)freenet.de>: > + TRACE("(%p): relay\n", This); "relay" doesn't make sense here. > + memcpy(transform, &This->transform, sizeof(D3DXMATRIX)); Why not just write "*transform = This->transform"?

1 0

DIB Engine
by Massimo Del Fedele Nov. 16, 2008

Nov. 16, 2008

I recently had a chat with Dan Kegel about the way to contribute and start hacking on a DIB engine. I grabbed Huw Davies and Jesse Allen's repositories and started looking at them. As it'll be an hard (and long) work, I'd like to know some opinions on how to proceed and propose an idea on how to have it introduced in mainstream without breaking stuff. The idea is, for now, JUST an idea and I still don't know if it'll be possible, but I guess yes. So, I was thinking on : 1) Try to join best stuffs of both repos of Huw and Jesse. 2) Add the environment variable DIBENGINE which could have 3 different values (or be missing) : missing DIBENGINE env var or DIBENGINE=NONE New dib engine will not be used, back to X11DRV DIBENGINE=FORWARD Unimplemented stuffs forwarded to X11, the rest using new dib engine code DIBENGINE=FULL use just dib engine code and shows FIXMEs for unimplemented stuffs The first would allow to insert dib engine in main stream without breaking anything, the last would allow to see what's more important to implement. The middle one (FORWARD) would allow to check if something breaks during the transition, and use the developed parts. 3) Stop and wait till it's put on mainstream, so more people could contribute. The doubt is if it'll be possible the mixed approach, forwarding unimplemented stuffs to X11, but I think so. Is it an acceptable way to proceed ? Ciao Max

4 11

Re: Slovak translations
by Austin English Nov. 16, 2008

Nov. 16, 2008

2008/11/16 Kario <kario(a)szm.sk>: > hi, my name is Mario Kacmar, I am from Slovakia > > and I made this patch with Slovak translations > > please commit my patch, or if is something wrong > > please contact me back > > > > see attachment > > === reklama ====================================== > http://mail.szm.com - e-mail a priestor na www stranku zadarmo > http://webhosting.szm.com - domeny a webhosting za najnizsie ceny > > > > > > > From: unknown <Kario(a).(none)> Your e-mail is munged in the patch. Also, please submit one change per patch, i.e., one translated file per patch. Thanks for helping Wine! -- -Austin

1 0

Re: [1/4] user32/tests: Test size and minmax of WS_THICKFRAME child.
by Austin English Nov. 16, 2008

Nov. 16, 2008

On Sun, Nov 16, 2008 at 10:52 AM, Florian Köberle <florian(a)fkoeberle.de> wrote: > Patch to fix bug 15188. > > This work is based on: > http://www.winehq.org/pipermail/wine-patches/2008-October/062460.html > > In this new patch series I calculate size like this: > > const int outer = 2; > int resizeBorder = GetSystemMetrics(SM_CXFRAME) - > GetSystemMetrics(SM_CXDLGFRAME); > int size = 2*(outer + resizeBorder); > > I took this formular from dlls/user32/nonclient.c: > ------------------ > adjust = 0; > if ((exStyle & WS_EX_DLGMODALFRAME) || > (style & (WS_THICKFRAME|WS_DLGFRAME))) adjust = 2; /* outer */ > } > if (style & WS_THICKFRAME) > adjust += ( GetSystemMetrics (SM_CXFRAME) > - GetSystemMetrics (SM_CXDLGFRAME)); /* The resize > border */ > ------------------ > > While writing this test I also tried some other styles and compared the > behavior between > CreateWindowEx and AdjustWindowRectEx. It didn't look like they have > much in common, that is why I didn't wrote the test against > AdjustWindowRectEx. > > Best regards, > Florian > > > > > From 762f49e2192b6d8477826c6535ef1ba0e1fd9d9b Mon Sep 17 00:00:00 2001 > From: =?utf-8?q?Florian=20K=C3=B6berle?= <florian(a)fkoeberle.de> Looks like you've botched the encoding somehow... > + test_thick_child_size(hwndMain); // causes test_capture_2() to fail Don't use C++ style comments, use C (/* comment */) instead. -- -Austin

2 1

Re: tools/fnt2bdf: fix a few compiler warnings (1/10)
by Michael Stefaniuc Nov. 16, 2008

Nov. 16, 2008

Austin English wrote: > This series of patches fixes most of the new warnings generated in gcc > 4.3.2. There's one issue left, but I'm not quite sure what should be > done on that one. > diff --git a/tools/fnt2bdf.c b/tools/fnt2bdf.c > index 1a14d6c..3c3134b 100644 > --- a/tools/fnt2bdf.c > +++ b/tools/fnt2bdf.c > @@ -595,14 +595,14 @@ int main(int argc, char **argv) > > if( !(lpfont = (unsigned char*) realloc( lpfont, length )) ) > { >- fprintf(stderr, errorMemory ); >+ fprintf(stderr, "%s", errorMemory ); Ugly. You could just use fputs instead. But if you know that the passed in strings are safe aka no format specifiers in them you can leave the code as is as the compiler warning is bogus. > exit(1); > } bye michael

3 3

Re: [PATCH 1/7] msi: Add more tests for the CompLocator part of the AppSearch action.
by Paul Vriens Nov. 16, 2008

Nov. 16, 2008

James Hawkins wrote: > --- > dlls/msi/tests/package.c | 526 +++++++++++++++++++++++++++++++++++++--------- > 1 files changed, 421 insertions(+), 105 deletions(-) > > > ------------------------------------------------------------------------ > > Hi James, I was looking at why on Win9x there were some registry entries left behind with the package tests. It had to do with creating the UserData keys (which doesn't exist at all on win9x/winme btw.) within test_complocator (by calling set_component_path) and trying to delete them with a W-function (that isn't present on win9x/winme by default). I did some further testing on several platforms and it turns out the test_complocator succeeds even without creating those registry keys in the first place (tested on Win98, W2K3 and Wine). The attached 'patch' just excludes the registry entry creation/deletion. Am I completely missing something or can this registry creation/deleted be removed from that test? -- Cheers, Paul. diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c index 47ffa35..3c128f0 100644 --- a/dlls/msi/tests/package.c +++ b/dlls/msi/tests/package.c @@ -7906,6 +7906,7 @@ static void test_complocator(void) CreateDirectoryA("olorotitan", NULL); CreateDirectoryA("pantydraco", NULL); +#if 0 set_component_path("abelisaurus", MSIINSTALLCONTEXT_MACHINE, "{E3619EED-305A-418C-B9C7-F7D7377F0934}", NULL, FALSE); set_component_path("bactrosaurus", MSIINSTALLCONTEXT_MACHINE, @@ -7922,6 +7923,7 @@ static void test_complocator(void) "{8B1034B7-BD5E-41ac-B52C-0105D3DFD74D}", NULL, FALSE); set_component_path("neosodon", MSIINSTALLCONTEXT_MACHINE, "{0B499649-197A-48EF-93D2-AF1C17ED6E90}", NULL, FALSE); +#endif r = MsiDoAction(hpkg, "AppSearch"); ok(r == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", r); @@ -8039,6 +8041,7 @@ static void test_complocator(void) RemoveDirectoryA("neosodon"); RemoveDirectoryA("olorotitan"); RemoveDirectoryA("pantydraco"); +#if 0 delete_component_path("{E3619EED-305A-418C-B9C7-F7D7377F0934}", MSIINSTALLCONTEXT_MACHINE, NULL); delete_component_path("{D56B688D-542F-42Ef-90FD-B6DA76EE8119}", @@ -8055,6 +8058,7 @@ static void test_complocator(void) MSIINSTALLCONTEXT_MACHINE, NULL); delete_component_path("{0B499649-197A-48EF-93D2-AF1C17ED6E90}", MSIINSTALLCONTEXT_MACHINE, NULL); +#endif DeleteFileA(msifile); }

1 0

uninitialized reference in wineconsole in call to WriteConsoleInput?
by Dan Kegel Nov. 16, 2008

Nov. 16, 2008

One more of the 100 valgrind warnings; this one is in kernel32/tests/console.c (but really in wineconsole). It's code Eric wrote six years ago, and the fix might be as straightforward as using memcpy(&ir, 0, sizeof(ir)) in WCUSER_GenerateMouseInputRecord(). Is there a better fix? Short form: SyscallParam wine_server_call WriteConsoleInputW WCUSER_GenerateMouseInputRecord WCUSER_Proc call_window_proc WINPROC_call_window DispatchMessageW WCUSER_MainLoop WinMain main Long form: <kind>SyscallParam</kind> <what>Syscall param writev(vector[...]) points to uninitialised byte(s)</what> <stack> <frame> <obj>dlls/ntdll/ntdll.dll.so</obj> <fn>wine_server_call</fn> <dir>dlls/ntdll</dir> <file>server.c</file> <line>248</line> </frame> <frame> <obj>dlls/kernel32/kernel32.dll.so</obj> <fn>WriteConsoleInputW</fn> <dir>dlls/kernel32/../../include/wine</dir> <file>server.h</file> <line>61</line> </frame> <frame> <obj>programs/wineconsole/wineconsole.exe.so</obj> <fn>WCUSER_GenerateMouseInputRecord</fn> <dir>programs/wineconsole</dir> <file>user.c</file> <line>1087</line> </frame> <frame> <obj>programs/wineconsole/wineconsole.exe.so</obj> <fn>WCUSER_Proc</fn> <dir>programs/wineconsole</dir> <file>user.c</file> <line>1186</line> </frame> <frame> <obj>dlls/user32/user32.dll.so</obj> </frame> <frame> <obj>dlls/user32/user32.dll.so</obj> <fn>call_window_proc</fn> <dir>dlls/user32</dir> <file>winproc.c</file> <line>458</line> </frame> <frame> <obj>dlls/user32/user32.dll.so</obj> <fn>WINPROC_call_window</fn> <dir>dlls/user32</dir> <file>winproc.c</file> <line>2212</line> </frame> <frame> <obj>dlls/user32/user32.dll.so</obj> <fn>DispatchMessageW</fn> <dir>dlls/user32</dir> <file>message.c</file> <line>3108</line> </frame> <frame> <obj>programs/wineconsole/wineconsole.exe.so</obj> <fn>WCUSER_MainLoop</fn> <dir>programs/wineconsole</dir> <file>user.c</file> <line>1378</line> </frame> <origin> <what>Uninitialised value was created by a stack allocation</what> <stack> <frame> <obj>programs/wineconsole/wineconsole.exe.so</obj> <fn>WCUSER_GenerateMouseInputRecord</fn> <dir>programs/wineconsole</dir> <file>user.c</file> <line>1066</line> </frame> </stack> </origin>

2 1

Re: Race in thread shutdown in imm32?
by Ge van Geldorp Nov. 15, 2008

Nov. 15, 2008

> From: "Rob Shearman" <robertshearman(a)gmail.com> > > I believe that Windows terminates all threads on process > exit It does, see http://blogs.msdn.com/oldnewthing/archive/2007/05/03/2383346.aspx

1 0

Re: OLEAUT32: implement OleLoadPictureFile(Ex) and add tests
by Detlef Riekenberg Nov. 14, 2008

Nov. 14, 2008

On Mi, 2008-11-12 at 23:40 -0800, Jeremy Drake wrote: I have no Idea about that area, but the unicode API is not implemented on win9x (GetTempFileNameW, CreateFileW, DeleteFileW) > if(!pOleLoadPictureFile || !pOleLoadPictureFileEx) Are there systems in the Wild that have OleLoadPictureFile, but are missing OleLoadPictureFile? In that case, you should use 2 seperate tests. > skip("Skipping OleLoadPictureFile tests\n"); Think, what you would see in the log before your text: "filename.c:__LINE__: Tests skipped:" "Skipping" is redundant and "tests" also. The usual way would be: skip("OleLoadPictureFile not found\n"); When you want to make sure, that we never skip in Wine here, then use win_skip instead. -- By by ... Detlef

1 1

Re: gdiplus: fix GdipFlattenPath for already-flat paths and add a test
by Vincent Povirk Nov. 14, 2008

Nov. 14, 2008

Please ignore this patch. It has a line removed that shouldn't be. Vincent Povirk On Fri, Nov 14, 2008 at 5:07 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > >

1 0

RFC: Wine Icons
by Joel Holdsworth Nov. 14, 2008

Nov. 14, 2008

Hi All, I notice that some of Wine's icons have been changed in recent releases. In principle I think updating the icons is a great idea, but right now I gotta say that icons in Wine are a real disaster. Take a look here: http://www.airwebreathe.org.uk/icons.png This is a screenshot of the shell folder select dialog. Out of those icons My Documents looks the least broken - with it's wannabe 98/ME/2000 styling. Desktop, "/", My Computer and Trash look like they've been taken from large icons which have shrunk - badly, and with a broken alpha channel. And the new golden Folder icons look completely out of place - they bear no resemblance to anything else, they've been scaled down poorly, they don't look like Windows icons, and they don't fit in with the Gnome desktop (and I can't imagine they'd look good in KDE or on Mac either). I'd really like for Wine to start using icons from the Tango project, or similar. The purpose of Tango was to create a set of icons that are clear to see, and look good on Windows, Gnome, KDE, and MacOS. Surely that's exactly what we want? Note that ReactOS is using Tango, and it seems to be working out pretty well for them! Any comments on that? Best Regards Joel Holdsworth

3 4

Re: RFC: Wine Icons
by Branan Riley Nov. 14, 2008

Nov. 14, 2008

On Fri, Nov 14, 2008 at 9:43 AM, Branan Riley <branan(a)gmail.com> wrote: > On Fri, Nov 14, 2008 at 5:54 AM, Joel Holdsworth > <joel(a)airwebreathe.org.uk> wrote: >> Hi All, >> >> I notice that some of Wine's icons have been changed in recent releases. >> In principle I think updating the icons is a great idea, but right now I >> gotta say that icons in Wine are a real disaster. >> >> Take a look here: http://www.airwebreathe.org.uk/icons.png >> >> This is a screenshot of the shell folder select dialog. Out of those >> icons My Documents looks the least broken - with it's wannabe 98/ME/2000 >> styling. Desktop, "/", My Computer and Trash look like they've been >> taken from large icons which have shrunk - badly, and with a broken >> alpha channel. And the new golden Folder icons look completely out of >> place - they bear no resemblance to anything else, they've been scaled >> down poorly, they don't look like Windows icons, and they don't fit in >> with the Gnome desktop (and I can't imagine they'd look good in KDE or >> on Mac either). >> >> I'd really like for Wine to start using icons from the Tango project, or >> similar. The purpose of Tango was to create a set of icons that are >> clear to see, and look good on Windows, Gnome, KDE, and MacOS. Surely >> that's exactly what we want? >> >> Note that ReactOS is using Tango, and it seems to be working out pretty >> well for them! >> >> Any comments on that? >> >> Best Regards >> Joel Holdsworth > > The problem with hardcoding Tango is that it won't necessarily match > the user's desktop. > > On Linux and FreeBSD, I'd suggest finding a way to detect the current > icon theme (perhaps determine which desktop environment is running, > then read the config file for that desktop?) and use the > freedesktop.org icon names and the XDG_DATA_DIRS variable to locate > the icons. This wouldn't work on KDE3 (which doesn't use the > freedesktop spec). In that case I would say fall back to the hicolor > icons. > > On Mac, you should use the native mac icons, but that might not work > to do Obj-C issues (I know nothing about mac programming, so maybe > there's a way to get native icons without Obj-C?). > > This way, when theming is implemented, the icons and the theme will > both match the user's desktop environment. It's more complicated than > just implementing Tango, but visually it makes more sense. > > Branan Thinking about this a bit more, it would require a tool to generate the .DLL with the icons we want from the freedesktop spec, in order to maintain compatibility with Windows on how system icons are handled. This could be done once when the prefix is created, with an option in winecfg to re-build the icon DLL.

2 1

Re: Revert "quartz: Reaching a renderer in the filtergraph is not an error."
by Lei Zhang Nov. 14, 2008

Nov. 14, 2008

On Fri, Nov 14, 2008 at 1:54 PM, Maarten Lankhorst <maarten(a)codeweavers.com> wrote: > This is plain wrong, input pin and output pin are supposed to be connected > to each other, not the input pin being connected to a renderer pin and NOT > reaching output pin > --- > > From 0f91e8a67c88d1ec0871c772679871249fd7625f Mon Sep 17 00:00:00 2001 > From: Maarten Lankhorst <maarten(a)codeweavers.com> > Date: Fri, 14 Nov 2008 22:50:34 +0100 > Subject: [PATCH] Revert "quartz: Reaching a renderer in the filtergraph is > not an error." > > This reverts commit 62a0bd65d2fe9febd6928ff5912e84a34f76a97f. > --- > dlls/quartz/filtergraph.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c > index b249724..c53771e 100644 > --- a/dlls/quartz/filtergraph.c > +++ b/dlls/quartz/filtergraph.c > @@ -1042,8 +1042,9 @@ static HRESULT WINAPI > FilterGraph2_Connect(IFilterGraph2 *iface, IPin *ppinOut, > if (SUCCEEDED(hr)) { > unsigned int i; > if (nb == 0) { > - TRACE("Reached a renderer\n"); > - break; > + IPin_Disconnect(ppinfilter); > + IPin_Disconnect(ppinOut); > + goto error; > } > TRACE("pins to consider: %d\n", nb); > for(i = 0; i < nb; i++) > -- > 1.5.6.5 > > > > > Correct, I got this one wrong. Please revert my patch and apply Maarten's patch to fix infinite recursion.

1 0

Governance of Wine with respect to the Software Freedom Conservancy
by Jeremy White Nov. 14, 2008

Nov. 14, 2008

Hi folks, As you may recall, several years ago, we decided to work with the Software Freedom Conservancy to ask them to manage aspects of Wine that merited the shield of a formal organization. They have been great, and a great improvement over our former process. I thought I'd send an email out for the record, expressing what they do for us, and how that is governed. First, there are essentially 2 major assets they manage for us. They manage all funds donated to Wine - the donate button goes into a bank account they manage. They also hold trademarks to the Wine logo that they filed on our behalf. For decisions on how to spend funds, we've adopted a loose set of guidelines. That is, Dan Kegel, Alexandre, and myself are in contact with them. The goal is that all 3 of us agree on every decision, but 2 of the 3 of us must concur with any decision before it is effective. We three can appoint anyone else we choose to replace or augment the decision group. All decisions are CC'd to the WWN author (currently Zach Goldberg) for monitoring. The SFC will recognize a 'revolt' by the Wine project. That is, Dan, Alexandre and I can be overthrown, once you figure out our evil plans, if the SFC is persuaded that the majority of Wine contributors agree on that point. Patch count in the Wine tree will be the primary mechanism to recognize a contributor. Finally, all spending by the SFC on Wine's behalf for the last few years has been related to Wineconf. That has either been to pay for conference expenses directly (as in Reading, 2 years ago), or to help defray travel costs for Wine contributors to come to Wineconf (as happened this year). Cheers, Jeremy

1 0

Re: RFC: Wine Icons
by Branan Riley Nov. 14, 2008

Nov. 14, 2008

forgot CC on first send. On Fri, Nov 14, 2008 at 5:54 AM, Joel Holdsworth <joel(a)airwebreathe.org.uk> wrote: > Hi All, > > I notice that some of Wine's icons have been changed in recent releases. > In principle I think updating the icons is a great idea, but right now I > gotta say that icons in Wine are a real disaster. > > Take a look here: http://www.airwebreathe.org.uk/icons.png > > This is a screenshot of the shell folder select dialog. Out of those > icons My Documents looks the least broken - with it's wannabe 98/ME/2000 > styling. Desktop, "/", My Computer and Trash look like they've been > taken from large icons which have shrunk - badly, and with a broken > alpha channel. And the new golden Folder icons look completely out of > place - they bear no resemblance to anything else, they've been scaled > down poorly, they don't look like Windows icons, and they don't fit in > with the Gnome desktop (and I can't imagine they'd look good in KDE or > on Mac either). > > I'd really like for Wine to start using icons from the Tango project, or > similar. The purpose of Tango was to create a set of icons that are > clear to see, and look good on Windows, Gnome, KDE, and MacOS. Surely > that's exactly what we want? > > Note that ReactOS is using Tango, and it seems to be working out pretty > well for them! > > Any comments on that? > > Best Regards > Joel Holdsworth The problem with hardcoding Tango is that it won't necessarily match the user's desktop. On Linux and FreeBSD, I'd suggest finding a way to detect the current icon theme (perhaps determine which desktop environment is running, then read the config file for that desktop?) and use the freedesktop.org icon names and the XDG_DATA_DIRS variable to locate the icons. This wouldn't work on KDE3 (which doesn't use the freedesktop spec). In that case I would say fall back to the hicolor icons. On Mac, you should use the native mac icons, but that might not work to do Obj-C issues (I know nothing about mac programming, so maybe there's a way to get native icons without Obj-C?). This way, when theming is implemented, the icons and the theme will both match the user's desktop environment. It's more complicated than just implementing Tango, but visually it makes more sense. Branan

3 2

Re: imm32: implement ImmInstallIME(W/A)
by Juan Lang Nov. 14, 2008

Nov. 14, 2008

Hi Aric, minor nit: + if (rc == ERROR_SUCCESS) + return hkl; + else + { + FIXME("Unable to set IME registry values\n"); I think a WARN would be more approriate here. --Juan

1 0

Re: RFC: Wine Icons
by Branan Riley Nov. 14, 2008

Nov. 14, 2008

> I totally agree. Of course hardcoding visuals isn't nearly so cool as > doing them "properly", but right now that's what we've got - and these > hardcoded visuals are even being "upgraded", so if they're being > upgraded then wouldn't it be better to upgrade in the direction of some > kind of a standard? > > At least in the past the visuals sort-of looked consistent with Windows > 98. Now they don't look consistent with anything. Don't get me wrong: > the new icons I see aren't specially bad - it's just that they don't fit > with anything else. > > I wonder if we can fix this. > > Best Regards > Joel Holdsworth I don't have any problems with Tango in the short-term - Wine doesn't match my desktop anyway. I just don't want to see a huge amount of effort get put into it if a theming system is going to be put in place. But since the icons are being replaced anyway, I agree that using an already-existing icon set makes way more sense than creating all-new icons. Branan *sigh* the GMAIL web interface makes mailing lists such a pain. Sorry for getting this to you twice again, joel

1 0

re: Bugzilla - Add keyword and remove OS's
by James Mckenzie Nov. 14, 2008

Nov. 14, 2008

Sorry for the top post +1 for removing the Pre-X Mac OS's James McKenzie -----Original Message----- >From: Dan Kegel <dank(a)kegel.com> >Sent: Nov 14, 2008 8:35 AM >To: Wine Devel <wine-devel(a)winehq.org> >Subject: re: Bugzilla - Add keyword and remove OS's > >I think we should keep most of them, but classic Mac OS >(pre-X) can go, as we never worked there (not even Darwine), >and nobody cares about it anymore. I've deleted >Mac System 7, and will delete the rest of the classic >mac OS's if there is consensus. > >

1 0

Bugzilla - Add keyword and remove OS's
by Austin English Nov. 14, 2008

Nov. 14, 2008

Howdy, The OS list in bugzilla is a bit excessive. There are 16 OS's that I think we should remove, as no one is using them (HP-UX has one bug filed against it, but for all intents and purposes, it's not being used). Many of these aren't x86, so only could be used for Winelib anyway. Mac System 7 Mac System 7.5 Mac System 7.6.1 Mac System 8.0 Mac System 8.5 Mac System 8.6 Mac System 9.x BSDI AIX BeOS HP-UX IRIX Neutrino OpenVMS OS/2 OSF/1 While we're at it, I'd like to add PC-BSD and OpenSolaris. Lastly, how about a compiler keyword, for bugs related to compiler warnings/errors/etc.? -- -Austin

3 4

Re: Try#4 for IDirectDrawSurface_GetSurfaceDesc error checking in ddraw test
by chris ahrendt Nov. 14, 2008

Nov. 14, 2008

Stefan D

1 0

Try#4 for IDirectDrawSurface_GetSurfaceDesc error checking in ddraw test
by chris ahrendt Nov. 14, 2008

Nov. 14, 2008

Michael / All, Been busy for awhile so have not had the time to work on this patch but here is the 4th try and hopefully final version of the ddraw patch. I took Michaels suggestions and encorporated them into the patch as well. Please let me know if this patch is now ready to submit =) chris

2 1

Re: Bugzilla - Add keyword and remove OS's
by James Mckenzie Nov. 14, 2008

Nov. 14, 2008

Markus: I don't think that Wine will build on MacOS 9 or earlier anymore. James McKenzie -----Original Message----- >From: Markus Hitter <mah(a)jump-ing.de> >Sent: Nov 14, 2008 1:53 AM >To: Austin English <austinenglish(a)gmail.com> >Cc: Wine Developers List <wine-devel(a)winehq.org> >Subject: Re: Bugzilla - Add keyword and remove OS's > > >Am 14.11.2008 um 00:15 schrieb Austin English: > >> Howdy, >> >> The OS list in bugzilla is a bit excessive. [...] >> Mac System 7 >> Mac System 7.5 >> Mac System 7.6.1 >> Mac System 8.0 >> Mac System 8.5 >> Mac System 8.6 >> Mac System 9.x > >You could merge them to "MacOS 9 and before" > > >MarKus > >- - - - - - - - - - - - - - - - - - - >Dipl. Ing. Markus Hitter >http://www.jump-ing.de/ > > > > > >

2 1

Some oddity with kernel32/pipe tests on NT4 and W2K
by Paul Vriens Nov. 14, 2008

Nov. 14, 2008

Hi I'm looking into the timeout issue on NT4. The timeout seems to be coming from: 796 size = 32678; ... 799 ok(CreatePipe(&piperead, &pipewrite, &pipe_attr, size) != 0, "CreatePipe failed\n"); 800 ok(WriteFile(pipewrite, buffer, size, &written, NULL), "Write to anonymous pipe failed\n"); When I change it to write a smaller number of bytes: 800 ok(WriteFile(pipewrite, buffer, (size - 24), &written, NULL), "Write to anonymous pipe failed\n"); we don't have a timeout. Changing the 'size - 24' to a bigger number like 'size - 23' gives a timeout again. Also changing size to 16384 still needs that 'size - 24' in the WriteFile(). In fact every size I use I need a 'size - 24'; I can also make this timeout go away by specifying at least 'size + 24' in the CreatePipe() call. MSDN states that the passed size for CreatePipe us used as an suggestion. I guess NT4 and W2K don't guess/calculate that well? Any ideas? -- Cheers, Paul.

1 0

Re: user32: TPM_ENTERIDLEEX needs to be set for popup windows (resend)
by David Adam Nov. 14, 2008

Nov. 14, 2008

You need to est your email adress in your patches. David 2008/11/12 Nicholai Benalal <nicholai(a)t-online.de> > Changelog: > user32:TPM_ENTERIDLEEX needs to be set for popup windows since > applications expect the owner window to be set for WM_ENTERIDLE. A NULL > window made several applications, such as Fritz 9 - 11 crash (see bug 9615) > > Best regards, > > Nicholai Benalal (olympia(a)skydreams.org) > > > > > >

3 2

Users posting to wine-bugs
by Luke Bratch Nov. 13, 2008

Nov. 13, 2008

Hi You may remember me as the person that does the mailing list moderation. Every day there are always several users posting directly to wine-bugs, as they are hitting reply to emails generated by Bugzilla instead of posting in Bugzilla itself. I added a message in the text that Bugzilla generates to make it clearer to not reply to the email a few months ago, which at the time seemed to improve things but as of late the number of emails has been going up again. Is anybody opposed to me setting up an auto-responder so that any mail going to wine-bugs(a)winehq.org gets auto responded to with a message to post in Bugzilla instead? I ask this in wine-devel as I'm not sure who is the actual administrator of the lists are. Thanks Luke Bratch

4 6

Re: DDRAW: ComputeSphereVisibility: Am I in the good way?
by paulo lesgaz Nov. 13, 2008

Nov. 13, 2008

I need to use some functions implemented in d3dx8 to do the job. Can I link this dll to ddraw (even if it is not logical in a Windows point of view) or I need to reimplement all the needed math functions in wined3d? David --- En date de : Jeu 13.11.08, Henri Verbeet <hverbeet(a)gmail.com> a écrit : De: Henri Verbeet <hverbeet(a)gmail.com> Objet: Re: DDRAW: ComputeSphereVisibility: Am I in the good way? À: jeremielapuree(a)yahoo.fr Cc: wine-devel(a)winehq.org Date: Jeudi 13 Novembre 2008, 16h13 2008/11/13 paulo lesgaz <jeremielapuree(a)yahoo.fr>: > Hello > > I would like to implement ComputeSphereVisibility. The sting game is > completely black because of this stubbed function. Here is my idea to > implement it. Am I in the good way, or it is completely a bad idea? > > With GetViewport, I retrieve the viewport matrix V, and with GetTransform, > I retrieve projection P and world W matrices ofn the device. > > I multiply the three matrices in a matrice M: M=VPW > > If M is singular, function returns with a failing message > Otherwise, with the matrix M I retrieve the planes of the frustum view > (that's a little bit of math, but quite easy) > > Then for each sphere, > > Let Visibility=0 > for each plane of the frustum view > Let I be the intersection of the orthogonal projection of the center > sphere on the plane. > If I is in the frustum view, then I have the visibility.So > Visibility=Visibility|(flag for the visibility of the chosen plane) > > Once I did it for the 6 plane, I have the visibility of the sphere. > > Is it a good point of start? > > David > The basic idea sounds about right. I don't think you need to project the sphere onto the frustum planes, just using the plane normal to calculate the distance to the sphere center should do.

2 1

Only ~100 valgrind errors left?
by Dan Kegel Nov. 13, 2008

Nov. 13, 2008

I'm getting back to valgrinding again. In preparation for adding valgrind runs to patchwatcher, I'm running the test suite through valgrind zillions of times, looking at how repeatable the results are. At the moment it looks like there is an annoyingly long tail of less likely failures, which is going to be a pain. On the bright side, it is looking like there aren't that many frequent valgrind errors left. See http://kegel.com/wine/valgrind/2008-11-13.txt for a manually deduplicated list. It only shows about 100 problems. Here's the breakdown by error type: 1 InvalidJump 3 InvalidWrite 7 Leak_DefinitelyLost 7 UninitValue 11 SyscallParam 25 InvalidRead 52 UninitCondition A word of warning: don't go fixing the problems behind these warnings unless you really know what you're doing. Superficial fixes are worse than no fix. That said, if anyone has a really good grasp of any of these problems, please go ahead and fix, or let me know which of these should be suppressed. For no particularly good reason, I've omiitted filenames, the list only includes function names and line numbers. That should have the unintended benefit of discouraging people unfamiliar with the code from jumping in and fixing things... Thanks, Dan

1 0

Re: user32: The default WM_CANCELMODE handler needs to call EndMenu() also in the case of a child window (resend)
by Vincent Povirk Nov. 13, 2008

Nov. 13, 2008

Please write a test for this scenario. Vincent Povirk On Tue, Nov 11, 2008 at 6:40 PM, Nicholai Benalal <nicholai(a)t-online.de> wrote: > Changelog: > user32: The default WM_CANCELMODE handler needs to call EndMenu() also in > the case of a child window. With the previous condition, Chessbase > applications never closed their application menus and several would open > at the same time > > Best regards, > > Nicholai Benalal (olympia(a)skydreams.org) > > > > > >

2 1

DDRAW: ComputeSphereVisibility: Am I in the good way?
by paulo lesgaz Nov. 13, 2008

Nov. 13, 2008

Hello I would like to implement ComputeSphereVisibility. The sting game is completely black because of this stubbed function. Here is my idea to implement it. Am I in the good way, or it is completely a bad idea? With GetViewport, I retrieve the viewport matrix V, and with GetTransform, I retrieve projection P and world W matrices ofn the device. I multiply the three matrices in a matrice M: M=VPW If M is singular, function returns with a failing message Otherwise, with the matrix M I retrieve the planes of the frustum view (that's a little bit of math, but quite easy) Then for each sphere, Let Visibility=0 for each plane of the frustum view Let I be the intersection of the orthogonal projection of the center sphere on the plane. If I is in the frustum view, then I have the visibility.So Visibility=Visibility|(flag for the visibility of the chosen plane) Once I did it for the 6 plane, I have the visibility of the sphere. Is it a good point of start? David

2 1

Making changes to Wiki
by Vitaliy Margolen Nov. 13, 2008

Nov. 13, 2008

Whenever someone maks changes to wiki page please add comments indicating what was changed. Without comments it's the same as submitting patches without a description. Vitaliy.

1 0

Re: shdocvw: Correct tests
by Paul Vriens Nov. 13, 2008

Nov. 13, 2008

Alistair Leslie-Hughes wrote: > Hi, > Corrected module the test are corrected in. > > Changelog: > shdocvw: Correct tests > > Best Regards > Alistair Leslie-Hughes > So shouldn't this be changed as well: - ok(site == NULL, "inplace=%p, ezpected NULL\n", runnable); + ok(site == NULL, "inplace=%p, ezpected NULL\n", site); (should be "site=%p....." and the ezpected typo is still there). -- Cheers, Paul.

1 0

Re: mshtml: Correct tests
by Alistair Leslie-Hughes Nov. 13, 2008

Nov. 13, 2008

Ignore this. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:491BFA50.9050407(a)hotmail.com... > Hi, > > Changelog: > mshtml: Correct tests > > Best Regards > Alistair Leslie-Hughes > > > > -------------------------------------------------------------------------------- > From e6ba1638d427366350ab1b4269372479cd4a3476 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Thu, 13 Nov 2008 20:55:59 +1100 > Subject: [PATCH] Correct tests > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/shdocvw/tests/webbrowser.c | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/dlls/shdocvw/tests/webbrowser.c > b/dlls/shdocvw/tests/webbrowser.c > index 3aa4bdd..484efe2 100644 > --- a/dlls/shdocvw/tests/webbrowser.c > +++ b/dlls/shdocvw/tests/webbrowser.c > @@ -1988,31 +1988,31 @@ static void test_QueryInterface(IUnknown *unk) > > hres = IUnknown_QueryInterface(unk, &IID_IQuickActivate, (void**)&qa); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(qa == NULL, "qa=%p, ezpected NULL\n", qa); > + ok(qa == NULL, "qa=%p, expected NULL\n", qa); > > hres = IUnknown_QueryInterface(unk, &IID_IRunnableObject, > (void**)&runnable); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(runnable == NULL, "runnable=%p, ezpected NULL\n", runnable); > + ok(runnable == NULL, "runnable=%p, expected NULL\n", runnable); > > hres = IUnknown_QueryInterface(unk, &IID_IPerPropertyBrowsing, > (void**)&propbrowse); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", runnable); > + ok(propbrowse == NULL, "propbrowse=%p, expected NULL\n", propbrowse); > > hres = IUnknown_QueryInterface(unk, &IID_IOleCache, (void**)&cache); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(cache == NULL, "cache=%p, ezpected NULL\n", runnable); > + ok(cache == NULL, "cache=%p, expected NULL\n", cache); > > hres = IUnknown_QueryInterface(unk, &IID_IOleInPlaceSite, > (void**)&inplace); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(inplace == NULL, "inplace=%p, ezpected NULL\n", runnable); > + ok(inplace == NULL, "inplace=%p, expected NULL\n", inplace); > > hres = IUnknown_QueryInterface(unk, &IID_IObjectWithSite, > (void**)&site); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(site == NULL, "inplace=%p, ezpected NULL\n", runnable); > + ok(site == NULL, "inplace=%p, ezpected NULL\n", site); > > hres = IUnknown_QueryInterface(unk, &IID_IViewObjectEx, > (void**)&viewex); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(viewex == NULL, "viewex=%p, ezpected NULL\n", runnable); > + ok(viewex == NULL, "viewex=%p, expected NULL\n", viewex); > > } > > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Re: Patch to build \\HKLM\HARDWARE\DEVICEMAP\SERIALCOMM entries for COM ports
by A C Hurst Nov. 13, 2008

Nov. 13, 2008

Resending this as it didn't make the list (shef.ac.uk != sheffield.ac.uk) sorry Austin > > Follows example of create_scsi_entries() in oldconfig.c > > Addresses bug 11811 among others. > > docs at http://www.winehq.org/site/docs/wineusr-guide/misc-things-to-configure only mention > > lowercase names in dosdevices. > > Hopefully I'm not too far down the s**t list; only my 2nd wine patch, feedback very welcome. > > -/* create the hardware registry branch */ > -static void create_hardware_branch(void) > ... > +/* create the hardware registry branch */ > +void create_hardware_branch(void) > > Any particular reason you moved this? > > -- > -Austin > Yes, it started as: void convert_old_config(void) { <other stuff..> /* create some hardware keys (FIXME: should not be done here) */ create_hardware_branch(); } but create_hardware_branch() did all/only the scsi stuff. I renamed it create_scsi_branch and added my create_serialcomm_branch, then thought how should I call it? Could just as well be: void convert_old_config(void) { <other stuff..> /* create some hardware keys (FIXME: should not be done here) */ create_scsi_branch(); create_serialcomm_branch(); } Would this be better? Andy

1 0

Make Wine and the tests dpi aware
by Detlef Riekenberg Nov. 12, 2008

Nov. 12, 2008

Wine use some fixed values for calculating gui elements, and hopefully the current values are verified with tests. The tests works in Windows, but only with the default settings: 96 dpi ("Small Fonts" / "Kleine Schriften") and the default theme. It would be a good idea to run the tests also for different settings. A first step should be using 120 dpi (Large Fonts) on Windows, and fix the tests and our Implementation. (comctrl32 has lot's of issues). For Patchwatcher, it should be possible to require selectable tests to run on more than one Machine with different settings. That way patchwatcher can detect 96dpi vs. 120dpi problems. Other possible testing improvement include color-depth and screen size issues. -- By by ... Detlef

2 1

iTunes wine 1.1.8
by Adam Brown Nov. 12, 2008

Nov. 12, 2008

Hi all, I am having a little trouble with iTunes 8 in Wine 1.1.8. Everything works great except that I cannot enter the store to buy music; it crashes. Do I have to adjust a setting or install gecko maybe? Older versions of iTunes I have tried have the same problem. Any suggestions would be appreciated.

2 1

syncing ipod in itunes
by EA Durbin Nov. 12, 2008

Nov. 12, 2008

Has there been any progress lately on achieving this task in wine? What's the status?http://www.winehq.org/pipermail/wine-devel/2008-March/063095.html _________________________________________________________________ Get 5 GB of storage with Windows Live Hotmail. http://windowslive.com/Explore/Hotmail?ocid=TXT_TAGLM_WL_hotmail_acq_5gb_11…

2 2

Re: Patch to build \\HKLM\HARDWARE\DEVICEMAP\SERIALCOMM entries for COM ports
by Austin English Nov. 12, 2008

Nov. 12, 2008

On Wed, Nov 12, 2008 at 1:38 PM, A C Hurst <A.Hurst(a)sheffield.ac.uk> wrote: > Follows example of create_scsi_entries() in oldconfig.c > Addresses bug 11811 among others. > docs at http://www.winehq.org/site/docs/wineusr-guide/misc-things-to-configure only mention > lowercase names in dosdevices. > Hopefully I'm not too far down the s**t list; only my 2nd wine patch, feedback very welcome. > > > Andy > > > -/* create the hardware registry branch */ -static void create_hardware_branch(void) ... +/* create the hardware registry branch */ +void create_hardware_branch(void) Any particular reason you moved this? -- -Austin

2 1

Re: Wine and relocation on not aligned section
by Dan Kegel Nov. 12, 2008

Nov. 12, 2008

> while diving into wine sources i've noticed that wine does not apply > relocation to section not aligned to page boundary. > Is there any reason for this behaviour? > If it is wrong i've put up a little patch that solves the issue. Do you know of an application that needs this? Or can you write a conformance test that shows how Windows behaves in this situation? http://www.uninformed.org/?v=6&a=3&t=txt seems to imply it's not needed? - Dan

3 2

Re: [RESEND] Send page size to cups with lpr command on printing (bug 15942)
by Massimo Del Fedele Nov. 12, 2008

Nov. 12, 2008

Massimo Del Fedele ha scritto: > Print jobs are sent to CUPS without the page size, so they're cropped to > the default one (usually A4). > The patch solves it adding "-o PageSize=<pagesize>" to lpr command. > > Ciao > > Max > > > ------------------------------------------------------------------------ > > Is there something wrong with this one ? Max

5 8

RE: Patch for WineD3D to set Driver an Description
by Stefan Dösinger Nov. 12, 2008

Nov. 12, 2008

> PS: For Fallout 3 those registry settings should be (or similar): > "VideoDescription"="NVIDIA GeForce 9600 GT" > "VideoDriver"="nv4_disp.dll" We have a display driver database in wined3d that specifies the driver version to report. We could include this information there instead adding a new registry key. "nv4_disp.dll" obviously makes problems. Our display driver is called "winex11.drv", or arguably for d3d "wined3d.dll"

4 3

Re: Patch for WineD3D to set Driver an Description
by Roderick Colenbrander Nov. 12, 2008

Nov. 12, 2008

Perhaps the patch should enter Wine. I will do the full restructuring later. One thing which you should do is to set the strings to NULL in the wined3d_settings structure at the start of the file (line 37). Also put the new options right after the video memory one or even before for clarity. Roderick > Hi, but this patch shouldn't brake anything, because it will use wine > default driver name and description and if user want to change it then > he can in registry, same like amount of video memory. > > In the future we will not be able to exactly match driver name and > description in every situation, so I think this can be solution for some > bugs now, and later we can improve it with better driver detection, but > registry settings should be there even then. > > Mirek > > Roderick Colenbrander napsal(a): > >> 2008/11/7 Mirek Slugeň <thunder.m(a)email.cz>: > >>> Hi, Fallout 3 and maybe other games or D3D apps need such special > >> settings, > >>> this patch should be ok, it is well tested. > >>> > >>> This patch is not hack! > >>> > >>> New wine registry settings: > >>> VideoDriver > >>> VideoDescription > >>> > >>> Patch is for current (07.11.2008) git. > >>> > >>> PS: For Fallout 3 those registry settings should be (or similar): > >>> "VideoDescription"="NVIDIA GeForce 9600 GT" > >>> "VideoDriver"="nv4_disp.dll" > >>> > >>> Mirek Slugen > >>> > >> I think you should integrate this with the card detection in > >> IWineD3DImpl_FillGLCaps(), directx.c lines 1029-1330. Roderick might > >> be able to give some help wrt driver and description strings for > >> specific cards. > >> > > > > I would recommend you to hardcode values specific for your card at this > point in your own wined3d version. Right now we estimate all info at Wine > startup based on GL information. In case of cards which we don't know even > from other vendors we also report Nvidia. > > > > The physx/cuda libraries require proper nvidia information in wined3d > but this can't be solved properly at this point. We also need the proper pci > ids and amount of video memory among other things. I'm working on a > solution but this needs some changes in wine's display driver to return this info > from extensions like Nvidia's NV-CONTROL. In case of NV-CONTROL I have > requested some additional functionality and once that is there I will fix this > once and for all. Until then I would recommend using your private wined3d > patch as it can do more bad than good for most users. > > > > Roderick -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

1 0

Re: mlang: Implement IMultiLanguage2::ConvertStringInIStream.
by Hans Leidekker Nov. 12, 2008

Nov. 12, 2008

On Wednesday 12 November 2008 13:37:32 Hans Leidekker wrote: > This version converts the stream all at once. Hold on, I realize now that I can avoid an allocation. -Hans

1 0

Re: Patch for WineD3D to set Driver an Description
by Henri Verbeet Nov. 12, 2008

Nov. 12, 2008

2008/11/7 Mirek Slugeň <thunder.m(a)email.cz>: > Hi, Fallout 3 and maybe other games or D3D apps need such special settings, > this patch should be ok, it is well tested. > > This patch is not hack! > > New wine registry settings: > VideoDriver > VideoDescription > > Patch is for current (07.11.2008) git. > > PS: For Fallout 3 those registry settings should be (or similar): > "VideoDescription"="NVIDIA GeForce 9600 GT" > "VideoDriver"="nv4_disp.dll" > > Mirek Slugen > I think you should integrate this with the card detection in IWineD3DImpl_FillGLCaps(), directx.c lines 1029-1330. Roderick might be able to give some help wrt driver and description strings for specific cards.

3 2

Re: wined3d: fix a compiler warning (2/10)
by Henri Verbeet Nov. 12, 2008

Nov. 12, 2008

The fix is mostly correct (although obviously there's more wrong with that code), but please use a slightly more descriptive subject. "Fix a compiler warning" doesn't say a whole lot.

1 0

Re: winex11.drv: fix a compiler warning (4/10)
by Chris Robinson Nov. 11, 2008

Nov. 11, 2008

On Tuesday 11 November 2008 07:28:11 pm Austin English wrote: > - TRACE(output); > + TRACE(output, "%s"); I think you put this on backwards. Some of the other patches seem to be the same way. This gets rid of the warning because you add an extra parameter, which the compiler takes to mean that you know what you're doing. But if the input string contains an %code, it'll interpret the value incorrectly.

1 0

Compiler warnings in gcc 4.3.2
by Austin English Nov. 11, 2008

Nov. 11, 2008

I recently upgraded to intrepid, which has gcc 4.3.2. It gave a few new warnings, and I've got patches ready for all but this one. I started to write a patch to remove the check, since it's useless, but wasn't sure if it should instead be converted to a signed integer instead. austin(a)austin-desktop:~/wine-git/dlls/dnsapi$ make ccache gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -Werror -g -o ns_parse.o ns_parse.c cc1: warnings being treated as errors ns_parse.c: In function 'dns_ns_parserr': ns_parse.c:139: error: comparison of unsigned expression < 0 is always false make: *** [ns_parse.o] Error 1 Relevant code: int dns_ns_parserr(ns_msg *handle, ns_sect section, int rrnum, ns_rr *rr) { int b; /* Make section right. */ if (section < 0 || section >= ns_s_max) RETERR(ENODEV); -- -Austin

2 2

Re: Implements GradientFill /GdiGradientFill
by Austin English Nov. 11, 2008

Nov. 11, 2008

On Tue, Nov 11, 2008 at 2:22 PM, joirge <jorgebendezu(a)viabcp.com> wrote: > I need it to run a program to change frequencuies to a radiomodem > satelline . > Many Thanks > > > You forgot the patch. -- -Austin

1 0

Re: shdocvw: Correct test for non-existing interfaces
by James Hawkins Nov. 11, 2008

Nov. 11, 2008

On Tue, Nov 11, 2008 at 4:27 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > This add a test for the IViewObjectEx interface as well as correcting the > exiting tests. > > Changelog: > shdocvw: Correct test for non-existing interfaces > - ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", runnable); + ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", propbrowse); Might want to fix the other typos while you're at it: s/ezpected/expected/ -- James Hawkins

1 0

Re: shdocvw: Added Support for the IViewObjectEx interface
by Jacek Caban Nov. 11, 2008

Nov. 11, 2008

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > shdocvw: Added Support for the IViewObjectEx interface Please check if interface you add is really supposed to be there. It's not the first time someone tries to add an interface to WebBrowser or HTMLDocument that shouldn't be there (this time the patch is already in Git). Please remember that the fact that an app queries for interface doesn't mean it should success! I keep adding tests for such cases, but it really easy to tests it before sending patch and it's something you *should* do. Jacek

2 2

Wine and relocation on not aligned section
by Alessandro Nov. 11, 2008

Nov. 11, 2008

Hi list, while diving into wine sources i've noticed that wine does not apply relocation to section not aligned to page boundary. Is there any reason for this behaviour? If it is wrong i've put up a little patch that solves the issue. Greetings, Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

1 0

Re: d3dx9_38.dll: Add the dll.
by Tony Wasserka Nov. 11, 2008

Nov. 11, 2008

Hi, > +#include "config.h" > +#include "wine/port.h" > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "wingdi.h" > +#include "winuser.h" > +#include "wine/debug.h" > + > +#include "d3dx9.h" There's no point in including so many unneccessary header files. Also, we have the year 2008, so you may want to update the Copyright ;-)

1 0

Re: winspool.drv/tests: Fix a test on all platforms.
by Nicolas Le Cam Nov. 11, 2008

Nov. 11, 2008

2008/11/6 Nicolas Le Cam <niko.lecam(a)gmail.com>: > Hi, > > DeviceCapabilities DC_FIELDS always sets the DM_FORMNAME flag. > Mark this test as a todo_wine. > > Nicolas Le Cam Is there something wrong with this one ? Should I fix wine too ? I didn't because I don't know where to fix it (in winspool.drv or in gdi32). There's no tests for this part of gdi32 and I really don't know if windows' winspool.drv calls gdi32 DeviceCapabilities function. Could someone familiar with this part can help me ? Nicolas Le Cam

1 0

Re: mlang: Implement IMultiLanguage2::ConvertStringInIStream.
by Dmitry Timoshkov Nov. 10, 2008

Nov. 10, 2008

"Hans Leidekker" <hans(a)codeweavers.com> wrote: > + while (1) > + { > + hr = IStream_Read(pstmIn, src, sizeof(src), &bytes_read); > + if (FAILED(hr)) goto exit; > + > + srclen = bytes_read; > + dstlen = buffer_size; > + ConvertINetString(pdwMode, dwSrcEncoding, dwDstEncoding, src, &srclen, NULL, &dstlen); > + if (dstlen > buffer_size) > + { > + dst = HeapReAlloc(GetProcessHeap(), 0, dst, dstlen); > + if (!dst) return E_OUTOFMEMORY; > + buffer_size = dstlen; > + } > + > + hr = ConvertINetString(pdwMode, dwSrcEncoding, dwDstEncoding, src, &srclen, dst, &dstlen); > + if (FAILED(hr)) goto exit; > + > + hr = IStream_Write(pstmOut, dst, dstlen, NULL); > + if (FAILED(hr)) goto exit; > + > + if (bytes_read != sizeof(src)) break; > + } > + > +exit: 'break' instead of 'goto' would be cleaner IMO. -- Dmitry.

1 0

Re: [ole32/tests] Don't crash on NT4
by Dmitry Timoshkov Nov. 10, 2008

Nov. 10, 2008

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > static HENHMETAFILE create_emf(void) > { > RECT rect = {0, 0, 100, 100}; > + const RECT rect2 = {0, 0, 100, 100}; > HDC hdc = CreateEnhMetaFile(NULL, NULL, &rect, "HENHMETAFILE Marshaling Test\0Test\0\0"); > - ExtTextOut(hdc, 0, 0, ETO_OPAQUE, NULL, "Test String", strlen("Test String"), NULL); > + ExtTextOut(hdc, 0, 0, ETO_OPAQUE, &rect2, "Test String", strlen("Test String"), NULL); Is there any reason that you introduced rect2 instead of using existing rect? -- Dmitry.

1 0

valgrind warning in "advapi32/tests: Add tests for QueryServiceStatusEx."
by Dan Kegel Nov. 10, 2008

Nov. 10, 2008

Hi Paul, in your change of 21 Aug 2008, http://source.winehq.org/git/wine.git/?a=commit;h=794752200131184506e84939a… valgrind has found something to complain about: ==7145== Conditional jump or move depends on uninitialised value(s) ==7145== at 0x4734514: RtlAllocateHeap (heap.c:1357) ==7145== by 0x496ECF3: test_query_svc (service.c:896) ==7145== by 0x497142C: func_service (service.c:2079) ==7145== by 0x4975C17: run_test (test.h:452) ==7145== by 0x4975E18: main (test.h:502) ==7145== Uninitialised value was created by a stack allocation ==7145== at 0x496E7E1: test_query_svc (service.c:808) Could you have a look? Thanks, Dan

1 0

Please, look at my patch, I'm not sure it's correct
by Vitaly Perov Nov. 10, 2008

Nov. 10, 2008

Hi, This patch add a stub implementation of IMarshal interface. I have no experience at implementing interfaces, so I'm not sure it's implemented correctly. Please, look at this patch. I'll be grateful for any remarks. Thank you. -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru

2 2

Re: Solution for bug 15942 - Send page size with lpr command on printing
by Austin English Nov. 10, 2008

Nov. 10, 2008

On Sun, Nov 9, 2008 at 6:48 PM, Massimo Del Fedele <max(a)veneto.com> wrote: > Send page size with 'lpr' command to CUPS, so it doesn't take always the > default one. > Solves bug 15942. > > Max > > > > +// sprintf(psCmd,"|lpr -P'%s'",pszOutput+4); Don't use C++ comments, use /* comment */ instead. Also, don't comment out code. Remove it if unneeded, or if it should be left as an example, etc., use if(0). -- -Austin

3 2

winehq packages for Debian
by Ben Klein Nov. 10, 2008

Nov. 10, 2008

Hi guys, I'm a regular volunteer in the #winehq IRC channel (man_in_shack). Some of you may know me :) I also maintain a few applications on AppDB and have had a couple of bugs found and fixed via bugzilla posts. I've been building Wine packages for my Debian systems for a while and now I've written myself some helper scripts to make the task trivial :) I build both amd64 and i386 packages. I'd like to request that I take over Scott Ritchie's position as maintainer for the winehq Debian packages as he seems to have all but abandoned Debian package building. I have the following caveats: 1) I don't have a suitable place to upload the packages (in terms of bandwidth restrictions) 2) At the moment, I'm not sure if the packages are suitable for an apt repository, as I don't have proper Changelogs or source packages. I'm not entirely sure what I'd need to do for this, so help would be appreciated 3) I'm fully set up to produce etch packages (Scott's packages aren't etch-compatible any more) as well as packages for lenny and sid 4) I'm not asking to take over Ubuntu package building (Scott seems to be good at this, and I don't have nor want an Ubuntu system) 5) I can be *very* quick to produce packages, as in the day after release (or even building packages from non-release revisions in git if required) Involvement in wine is fun! Regards, Ben Klein

3 4

Another shot at running tests in parallel
by Dan Kegel Nov. 10, 2008

Nov. 10, 2008

On modern CPUs, with a 30 second timeout per test, the wine conformance test suite runs in about 4-5 minutes. That's wonderfully fast, completely sufficient for all purposes... ... except one: running tests under valgrind, which imposes a roughly 10x penalty. 40-50 minutes to run the tests is a bit too long to expect developers to wait for feedback. So I had another try at getting conformance tests to run in parallel, this time without any code modifications. I use WINETEST_WRAPPER="$HOME/alarm 30", where alarm is the output of compiling http://winezeug.googlecode.com/svn/trunk/patchwatcher/alarm.c That file has a hardcoded whitelist of tests that are know to not call CreateWindow (directly or indirectly) or do anything else that might not work well in parallel. alarm takes an exclusive lock when running any test not on that list. Even with this fairly restrictive whitelist, the tests were fairly parallelizable (see below). Because running tests in parallel is tricky, and makes our already somewhat shaky test suite less stable, I will run the tests the normal way first, and only if they pass without regressions will I then do a second run under Valgrind. And I'll ignore any test failures that happen under valgrind; all I care about in those runs are the valgrind warnings. Here are some benchmarks on a quad processor: -j time in seconds 1 255 2 155 3 125 4 105 20 79 With -j4, it looks like valgrind could run the tests in about ten minutes, which would be quick enough. It would be nice if our test suite really ran in parallel some day, but the approximation I have now is probably good enough. - Dan p.s. Out of curiosity, I checked how many tests interfere with themselves if multiple copies are run. To do this, I ran with WINETEST_WRAPPER="$HOME/foowrap.sh" where foowrap.sh was #!/bin/sh # Run same test three times in parallel $@ & sleep 1 $@ & $@ As you can imagine, that broke a lot of tests, many more than just running in parallel.

1 0

Re: Solution for bug 15942 - Send page size with lpr command on printing
by Austin English Nov. 10, 2008

Nov. 10, 2008

On Sun, Nov 9, 2008 at 6:48 PM, Massimo Del Fedele <max(a)veneto.com> wrote: > Send page size with 'lpr' command to CUPS, so it doesn't take always the > default one. > Solves bug 15942. > > Max > > > > +// sprintf(psCmd,"|lpr -P'%s'",pszOutput+4); Don't use C++ comments, use /* comment */ instead. Also, don't comment out code. Remove it if unneeded, or if it should be left as an example, etc., use if(0). -- -Austin

1 0

.ANI patch
by Krzysztof Drewniak Nov. 9, 2008

Nov. 9, 2008

There is a .ANI cursor patch in hacks.git. Would it be possible to integrate it into wine? I know of many applications (especcially games) that would benefit. Thanks Krzys D.

2 3

Wine and relocation on not aligned section
by Alessandro Nov. 9, 2008

Nov. 9, 2008

Hi list, while diving into wine sources i've noticed that wine does not apply relocation to section not aligned to page boundary. Is there any reason for this behaviour? If it is wrong i've put up a little patch that solves the issue. Greetings, Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

1 0

Re: [PATCH 1/2] Implement GdipGetLogFontA (try2)
by Dmitry Timoshkov Nov. 9, 2008

Nov. 9, 2008

"Adam Petaccia" <adam(a)tpetaccia.com> wrote: > +GpStatus WINGDIPAPI GdipGetLogFontA(GpFont *font, GpGraphics *graphics, > + LOGFONTA *lfa) > +{ > + INT bytesWritten; > + /* FIXME: use graphics */ > + if(!(font && graphics && lfa)) > + return InvalidParameter; > + > + memcpy(lfa, &font->lfw, sizeof(LOGFONTA)); FIELD_OFFSET(LOGFONTA, lfFaceName) instead of sizeof(LOGFONTA) would be better IMO. > + bytesWritten = WideCharToMultiByte(CP_ACP, 0, font->lfw.lfFaceName, -1, > + lfa->lfFaceName, LF_FACESIZE, NULL, NULL); > + > + if (bytesWritten == 0) > + { > + ERR("Could not convert from WideChar to Multibyte with error %d\n", > + GetLastError()); > + return GenericError; > + } The ERR() as well as the bytesWritten check are useless, please remove them. -- Dmitry.

1 0

fixme: IDirect3DDevice9::CreateQuery
by Krzysztof Drewniak Nov. 9, 2008

Nov. 9, 2008

I'm getting a "fixme:d3d:IWineD3DDeviceImpl_EvictManagedResources (0xb550510) : stub fixme:d3d:IWineD3DDeviceImpl_CreateQuery (0xb550510) Unhandled query type 4 fixme:d3d9:IDirect3DDevice9Impl_CreateQuery (0xb543bc8) call to IWineD3DDevice_CreateQuery failed" over and over again and the app isn't working right. Either can someone fix this of drop me a line about what might need to be done? (Not a Wine expert, but I'll gladly help.) Krzys D

2 1

Re: [PATCH] Implement GdipGetLogFontA
by Adam Petaccia Nov. 9, 2008

Nov. 9, 2008

Ignore. Will resend. On Sun, 2008-11-09 at 13:03 -0500, Adam Petaccia wrote: > --- > dlls/gdiplus/font.c | 25 +++++++++++++++++++++++++ > dlls/gdiplus/gdiplus.spec | 2 +- > 2 files changed, 26 insertions(+), 1 deletions(-) > > diff --git a/dlls/gdiplus/font.c b/dlls/gdiplus/font.c > index 32713c7..2477f7b 100644 > --- a/dlls/gdiplus/font.c > +++ b/dlls/gdiplus/font.c > @@ -368,6 +368,31 @@ GpStatus WINGDIPAPI GdipGetFontUnit(GpFont *font, Unit *unit) > } > > /******************************************************************************* > + * GdipGetLogFontA [GDIPLUS.@] > + */ > +GpStatus WINGDIPAPI GdipGetLogFontA(GpFont *font, GpGraphics *graphics, > + LOGFONTA *lfa) > +{ > + INT bytesWritten; > + /* FIXME: use graphics */ > + if(!(font && graphics && lfa)) > + return InvalidParameter; > + > + memcpy(&font->lfw, lfa, sizeof(LOGFONTA)); > + bytesWritten = WideCharToMultiByte(CP_ACP, 0, font->lfw.lfFaceName, -1, > + lfa->lfFaceName, LF_FACESIZE, NULL, NULL); > + > + if (bytesWritten == 0) > + { > + ERR("Could not convert from WideChar to Multibyte with error %d\n", > + GetLastError()); > + return GenericError; > + } > + > + return Ok; > +} > + > +/******************************************************************************* > * GdipGetLogFontW [GDIPLUS.@] > */ > GpStatus WINGDIPAPI GdipGetLogFontW(GpFont *font, GpGraphics *graphics, > diff --git a/dlls/gdiplus/gdiplus.spec b/dlls/gdiplus/gdiplus.spec > index a2790a3..0e7ac5c 100644 > --- a/dlls/gdiplus/gdiplus.spec > +++ b/dlls/gdiplus/gdiplus.spec > @@ -311,7 +311,7 @@ > @ stdcall GdipGetLineSpacing(ptr long ptr) > @ stub GdipGetLineTransform > @ stdcall GdipGetLineWrapMode(ptr ptr) > -@ stub GdipGetLogFontA > +@ stdcall GdipGetLogFontA(ptr ptr ptr) > @ stdcall GdipGetLogFontW(ptr ptr ptr) > @ stdcall GdipGetMatrixElements(ptr ptr) > @ stub GdipGetMetafileDownLevelRasterizationLimit

1 0

Re: mshtml: Implement IHTMLStyle get/put posLeft (try 9)
by Austin English Nov. 8, 2008

Nov. 8, 2008

On Fri, Nov 7, 2008 at 10:53 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > Use strtolW correctly. > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft > > Best Regards > Alistair Leslie-Hughes > > > > > > You forgot to attach the patch :-) -- -Austin

1 0

wine build time: 6 (or 3) minutes with q9400
by Dan Kegel Nov. 8, 2008

Nov. 8, 2008

FWIW: with wine from git from a couple days ago, here are wine build times on various Intel CPUs in seconds on Ubuntu 8.10's gcc-4.3.2 (or 8.04): sec cpu wine notes 676 e7200 June http://kegel.com/new-computer-2008.html ubuntu 8.04 615 e7300 Nov 585 e7400 Nov (estimated, supposedly 5% faster than e7300) 540 e8400 Nov 360 q9400 Nov In all cases, this was with the default optimization level, -O2. Compiling with -O0 was roughly twice as fast (e.g. 196 seconds to build on the q9400). The dual core e7300 and e8400 were tested with -j3; the quad core q9400 with -j5. The current crop of CPUs is that they run cooler than older ones. Replacing the old Athlon 64's in the patchwatcher cluster with new CPUs and 80+ power supplies makes a big difference in the room's temperature! The quad CPUs are coming down in price. Once you get used to fast builds, it's hard to go back, so don't try a q9400 or faster CPU unless you want to keep it :-) Older benchmarks: http://techgage.com/article/intel_core_2_quad_q6600/4 (is gentoo really that fast, or was he building with -O0?) http://www.winehq.org/pipermail/wine-devel/2008-June/066121.html (q6600 386 seconds).

3 5

Re: [1/2] richedit: Created initial tests for windowless richedit controls. (try 2)
by Peter Oberndorfer Nov. 8, 2008

Nov. 8, 2008

On Samstag 08 November 2008, Dylan Smith wrote: > (Ensured compiler independence by modifying byte code templates) > > The initial tests added simply call CreateTextServices, and query for > the ITextServices interface, then cleans up. > > Since CreateTextServices needs an implementation of ITextHost to be > given, this patch needed a stub implementation. This required wrappers > for converting thiscall to stdcall which are now implementing by > adapting a byte code wrapper template. Although byte code isn't portable > across processors, this is only needed for x86 platforms so it is only > meant to be compiler independent. > > In order to investigate what is happening in the tests, it is helpful > to trace the calls to ITextHost methods by the richedit controls. I > realized it would be too verbose to trace all these calls by default, > so I wrapped them all with a check for winedebug > 1, since normally > winedebug is 0 or 1. > --- > dlls/riched20/tests/Makefile.in | 3 +- > dlls/riched20/tests/txtsrv.c | 593 +++++++++++++++++++++++++++++++++++++++ > 2 files changed, 595 insertions(+), 1 deletions(-) > create mode 100644 dlls/riched20/tests/txtsrv.c > Hi, This page [1] seems to suggest memory returned from HeapAlloc is marked as not executable. Other tests (ntdll exception) are using VirtualAlloc() for dynamically created code. patch 1 > +/* The following x86 code string converts between the thiscall and stdcall > + * calling convetions. The thiscall calling convention places the This > + * pointer in ecx on the x86 platform, and the stdcall calling convention > + * pushes the This pointer on the stack as the first argument. > + * > + * The wrapper's code finishes by jumping to the real function. > + * > + * Byte codes are used so that a copy of it can be modified to use > + * for each method in ITextHost. */ patch 2 > -/* The following x86 code string converts between the thiscall and stdcall > +/* The following x86 code strings convert between the thiscall and stdcall > * calling convetions. The thiscall calling convention places the This Here you introduce comments that you seem to change in the second patch. Maybe use the right text in the first patch? Additionally the term code string sounds odd. Maybe replace that with "The following x86 assembler code..." or something similar? > #define ITextServices_QueryInterface(p,a,b) (p)->lpVtbl->QueryInterface(p,a,b) > #define ITextServices_AddRef(p) (p)->lpVtbl->AddRef(p) > #define ITextServices_Release(p) (p)->lpVtbl->Release(p) > -/*** ITextServices methods ***/ > -#define ITextServices_TxSendMessage(p,a,b,c,d) (p)->lpVtbl->TxSendMessage(p,a,b,c,d) > -#define ITextServices_TxDraw(p,a,b,c,d,e,f,g,h,i,j,k,l) (p)->lpVtbl->TxDraw(p,a,b,c,d,e,f,g,h,i,j,k,l) Why do you only move some of those #defines part of ITextServices and not the one part of IUnknown ? I do not know much about those #defines but this seems odd Maybe i am missing something but why do you need those thiscall wrappers? Wouldn't it be possible to use the DEFINE_THISCALL_WRAPPER and THISCALL macros like in txtserv.c? Greetings Peter [1] http://www.unixwiz.net/techtips/xp-sp2.html

2 1

noob req: ddraw/vertexbuffer.c and HW vertex buffers
by FeepingCreature Nov. 8, 2008

Nov. 8, 2008

Hi, I've been playing Gothic2 and getting lots of messages regarding d3d7:IDirect3DVertexBufferImpl_Optimize, printed by ddraw/vertexbuffer.c. Reading the comments for that function seems to indicate that vertex buffers are currently emulated in software, and will be handled in hardware as soon as wined3d is capable of that - however, reading wined3d/vertexbuffer.c, especially CreateVBO, implies that hardware/GL vertex buffers are already supported. Git logs also show that ddraw/vertexbuffer.c has not been changed in a few months. Did I completely mis-interpret the comments, or has this file simply been forgotten? And if so, could some kind soul sacrifice the time to bring it up to speed with the rest of Wine, so that us Gothic players can enjoy better framerates? Thanks for reading. ___________________________________________________________ Telefonate ohne weitere Kosten vom PC zum PC: http://messenger.yahoo.de

2 1

integration of winscard patches: ideas for implementing test cases?
by frechdachs69 Nov. 7, 2008

Nov. 7, 2008

Hi together! I am currently wondering which test cases make sense after an integration of winscard patches. So far most API calls are directly related to pcsc-lite behaviour and therefore we need a result from pcsc-lite which is comparable with what Win/winscard.dll would return to us. But this is almost always depending on the smartcard reader setup at the local machine. As a result I see a problem to automate such tests without having underlying assumptions concerning the attached smartcard readers and maybe inserted (or not) smartcards (i.e. specific hardware is necessary). Any ideas? Does anyone know whether someone has written a virtual card reader which can be accessed using pcsc-lite (i.e. an IFD handler exists which simulates reader behaviour)? Maybe together with the option to insert a virtual card? If not then I am going to subscribe to the pcsc-lite maling list and ask this question there, too. Any other ideas how to automate winscard tests to be able to add such tests to the regression test suite? Regards Heiko

2 1

Re: inetcomm: Add an implementation of IVirtualStream.
by Huw Davies Nov. 7, 2008

Nov. 7, 2008

Hans Leidekker wrote: > This interface is undocumented but fortunately its name was enough > of a hint to create a sensible implementation. Used by Outlook when > retrieving or sending a mail. We already have MimeOleCreateVirtualStream() which is implemented on top of CreateStreamOnHGlobal()... Huw.

2 2

Issues with VMware Workstation 6.5.0, winetest and directx acceleration enabled
by Paul Vriens Nov. 7, 2008

Nov. 7, 2008

Hi, FYI. I had to disable "Accelerate 3D graphics (DirectX 9.0c)" in the VM settings on several of my Vmware boxes. Winetest crashed my W2K and Vista box (ddraw:d3d) and made my Win98 box unresponsive (user32:sysparams when changing to 8bit display). If I can find some spare time I will report this to VMware. I do however run VMware Workstation on Fedora 8 which is not officially supported. -- Cheers, Paul.

2 1

[RFC] winecfg -- approach to making the theme names & colours lists sortable
by Reece Dunn Nov. 7, 2008

Nov. 7, 2008

Hi, At the moment, if you have several themes installed on your system (e.g. by installing StyleXP) winecfg will list those themes in a random (read not sorted) order. If I just add the CBS_SORT flag, the wrong theme is chosen because the order in the combo boxes are assumed to be the same order in a DSA (dynamic array) containing the theme, size or colour data. My idea is to store the additional data in the combo box in the item's item data. This will mean a major rewrite of this area to remove the use of the DSAs, so I am wondering what the best way to approach this is. I am currently thinking something along the lines of: 1. Replace the DSA for the theme colour list, storing the data in the item data of the colour list combo box; 2. Replace the DSA for the theme size list, storing the data in the item data of the size list combo box; 3. Replace the DSA for the theme list, storing the data in the item data of the theme list combo box; 4. Make the theme list and theme colour lists sorted. Does this approach seem reasonable? - Reece

1 0