November 2008 - Wine-Devel - list.winehq.org

Re: [1/3] xinput: Initial implementation of xinput xbox 360 joystick library
by Alexandre Julliard Nov. 7, 2008

Nov. 7, 2008

"Andrew Fenn" <andrewfenn(a)gmail.com> writes: > +BOOL WINAPI DllMain(HINSTANCE inst, DWORD reason, LPVOID reserved) > +{ > + switch(reason) > + { > + case DLL_WINE_PREATTACH: > + return FALSE; /* prefer native version */ You need to do that for all the dlls, not just the 1_3 one. Also please send one patch per dll. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3dx9: Implement ID3DXSprite_Begin/End [PATCH 3/5]
by Alexandre Julliard Nov. 7, 2008

Nov. 7, 2008

Tony Wasserka <tony.wasserka(a)freenet.de> writes: > + /* About This->flags: > + != D3DXSPRITE_FLAGLIMIT+1 means we have already called ID3DXSprite_Begin > + == D3DXSPRITE_FLAGLIMIT+1 means we have either called D3DXCreateSprite or ID3DXSprite_End > + In the first case we return D3DERR_INVALIDCALL, in the other one we can continue. > + For ID3DXSprite_Flush/Draw This->flags must be < D3DXSPRITE_FLAGLIMIT+1. */ > + if(flags>D3DXSPRITE_FLAGLIMIT || This->flags!=D3DXSPRITE_FLAGLIMIT+1) > + return D3DERR_INVALIDCALL; That's ugly, if you need to know if Begin has been called you should store a separate flag for that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Launchpad Bugzilla plugin can allow us to share comment histories for forwarded bugs
by Scott Ritchie Nov. 6, 2008

Nov. 6, 2008

There's a launchpad bugzilla plugin available now, made by bugzilla developers: https://help.launchpad.net/Bugs/BugzillaPlugin Having this seems like it would simplify things, as there wouldn't be a need to forward comments on a launchpad bug to the one posted at WineHQ. It can be quite annoying checking both pages once a bugzilla bug and a launchpad bug are linked to eachother. Thoughts? Thanks, Scott Ritchie

2 1

Re: [2/3] comctl32: toolbar: Improve text layout in TBSTYLE_LIST toolbars.
by Paul Vriens Nov. 6, 2008

Nov. 6, 2008

Sergey Khodych wrote: > > > ------------------------------------------------------------------------ > > Sorry for the previous email (replied to the wrong patch email). Hi, Could you have a look at http://test.winehq.org/data/3f4333d70c27a813b4d99e0daeeb613e9e941a9a/ as this patch introduced a failure on all Windows platforms. I guess it's just changing 183 to 185. But that 183 is there for a reason, not? -- Cheers, Paul.

1 0

Re: [1/3] comctl32: toolbar: Calculate a correct size for empty buttons with the BTNS_AUTOSIZE style.
by Paul Vriens Nov. 6, 2008

Nov. 6, 2008

Sergey Khodych wrote: > > > ------------------------------------------------------------------------ > > Hi, Could you have a look at http://test.winehq.org/data/3f4333d70c27a813b4d99e0daeeb613e9e941a9a/ as this patch introduced a failure on all Windows platforms. I guess it's just changing 183 to 185. But that 183 is there for a reason, not? -- Cheers, Paul.

1 0

Re: mshtml: Implement IHTMLStyle get/put posLeft (try 8)
by Jacek Caban Nov. 6, 2008

Nov. 6, 2008

Alistair Leslie-Hughes wrote: > Hi, > Made functions for get/set. > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft + for(ptr=value; isdigitW(*ptr); ptr++) + { + if(*ptr && !strcmpW(ptr, pxW)) { This if expression will never be true. You should move it after for loop and change !strcmpW to strcmpW. Jacek

1 0

Re: winmm: Increase tolerance range in tests
by Alistair Leslie-Hughes Nov. 6, 2008

Nov. 6, 2008

Hi Robert -------------------------------------------------- From: "Robert Reif" <reif(a)earthlink.net> Sent: Thursday, November 06, 2008 11:00 PM To: "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> Cc: <wine-devel(a)winehq.org> Subject: Re: winmm: Increase tolerance range in tests >> > On real hardware or on a virtual machine? The data I was looking at comes from http://test.winehq.org/data/ Some of these will be virtual machines but I cannot tell. Best Regards Alistair Leslie-Hughes

1 0

patchwatcher status: online but no email
by Dan Kegel Nov. 6, 2008

Nov. 6, 2008

Patchwatcher is now working well enough to depend on, I think, but doesn't send email yet. You should see your patch appear at http://kegel.com/wine/patchwatcher/results under a minute after you post, and if your patch is simple, test results should show up about ten minutes later. (Long patch series take longer, since patchwatcher runs the test suite after each patch in the series.) Today's changes (from http://code.google.com/p/winezeug/source/list ): - Update the dashboard immediately upon receiving patches. - Added qmgr timeout and winhttp:notification.c to blacklist. Full blacklist at http://winezeug.googlecode.com/svn/trunk/patchwatcher/blacklist.txt Please fix your tests so I don't have to blacklist them. (The d3d tests should start passing once I move to the latest nvidia drivers, so don't worry about them.)

2 3

What happened to __TRY?
by Michael Ost Nov. 6, 2008

Nov. 6, 2008

Hi all, When I upgraded wine-develfrom 1.0 to 1.1.7, my winelib app that uses __TRY no longer links. It complains that RtlUnwind cannot be found. I can see that RtlUnwind was added to wine/exception.h, but I am not sure how to fix it. I tried adding -lntdll and -lwine to the link command line but it didn't help. Any suggestions? Thanks! ... mo PS: Here's the linker line I am using and the error returns... wineg++ -DNDEBUG=1 -O3 -DBOOST_POSIX_API -DBOOST_POSIX_PATH -DALSA=1 -DMUSE_SSE -Wall -Werror -D__STDC_LIMIT_MACROS=1 -I/home/most/Desktop/cvs/muse/receptor2/rm-host -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/hotspot -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/medioid -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/uniwire -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/muselock -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../external/vst/vstsdk2.4 -I/usr/include/xmlwrapp -I/usr/include/libxml2 -Wb,--3gb -o rm-host.exe.so ChildView.o IsFileOpen.o SerialDevice.o SystemInterface.o Alert.o AudioFader.o AutoAddPage.o Balancer.o BankButton.o BankPatch.o BankPatchPanel.o BufferSizePanel.o BypassPanel.o ChannelDetail.o ChannelStrip.o CopyPanel.o CopyPatchPanel.o CopySwitch.o CPUGauge.o DeletePanel.o Dial.o DualCorePanel.o EditorMenu.o EditPage.o EditParametersPanel.o EditStrip.o EffectPage.o FacelessPage.o FrontPanel.o FrontPanelPage.o GeberDevice.o GeberFrontPanel.o GuitarMonitor.o HostApp.o Host.o HostHandleMidi.o HostInput.o HostLevels.o HostMixer.o HostPage.o HostPlugin.o HostPluginList.o HostPluginOutput.o HostTrack.o Icon.o InformationPanel.o InitializePanel.o InputLevelPanel.o InstallPanel.o InstStrip.o ListenToMidiPanel.o LoadBlankPanel.o LockPanel.o MasterStack.o MetersPanel.o MidiFilterPopup.o MidiMonitorPanel.o MixerStatus.o MixPage.o MultiPage.o MutePanel.o Navigation_hotspot.o OneColumnPopup.o OutputAssignmentPanel.o OutputPopup.o OtherProgramChangesPanel.o PanelParameters.o PanicPanel.o ParameterPanel.o PatchButton.o PatchReport.o PluginControllersPanel.o PluginMenu.o PluginPanel.o PluginsToIgnore.o PluginTypePanel.o Preferences.o PrePostPanel.o ProgramChannelPanel.o ProgramChangeModePanel.o ReceptorAudioControl.o ReceptorNamePanel.o ReceptorXmlRpc.o RemapPanel.o RenamePanel.o RenamePatchPanel.o ReorderPopup.o RoutePanel.o RouteStack.o SampleClockPanel.o SampleClockPopup.o SampleRatePanel.o SampleRatePopup.o SavePatch.o SavePatchPanel.o SelectChannelPanel.o SendStack.o SendStrip.o SetupPage.o SignalLevel.o SinglePage.o SoloPanel.o SourcePage.o SwitchPanel.o TcpipPanel.o TempoAndTransport.o TempoPanel.o TempoPopups.o TempoSourcePanel.o TimeSignaturePanel.o TrackNamePopup.o TrackStack.o TransposePanel.o TransposePopup.o UninstallPluginsPanel.o UninstallPopup.o UniWirePanel.o UniWireXmlRpcServer.o UnsupportedPlugins.o ViewBankPanel.o ViewBar.o ViewPopup.o VstSettingsCache.o VstSettings.o XmlRpcServer.o XmlSupport.o ZloadPanel.o ZombiePlugins.o ZonePanel.o /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/uniwire/wine-release/libuniwire.a /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/medioid/wine-release/libmedioid.a /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/hotspot/wine-release/libhotspot.a /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/muselock/wine-release/libmuselock.a /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/muselock/source/win32/PlugInLib.a -ldl -lrt -lasound -lpng -lusb -lcomdlg32 -lxml2 -lxslt -lxmlwrapp -lboost_filesystem -lboost_thread-mt -lgdi32 -lshell32 HostApp.o: In function `__wine_exception_handler(_EXCEPTION_RECORD*, _EXCEPTION_REGISTRATION_RECORD*, _CONTEXT86*, _EXCEPTION_REGISTRATION_RECORD**)': HostApp.cpp:(.text+0x4cb): undefined reference to `RtlUnwind(void*, void*, _EXCEPTION_RECORD*, void*)' HostMixer.o: In function `__wine_exception_handler(_EXCEPTION_RECORD*, _EXCEPTION_REGISTRATION_RECORD*, _CONTEXT86*, _EXCEPTION_REGISTRATION_RECORD**)': HostMixer.cpp:(.text+0x60b): undefined reference to `RtlUnwind(void*, void*, _EXCEPTION_RECORD*, void*)' collect2: ld returned 1 exit status winegcc: g++ failed

5 6

Re: winmm: Increase tolerance range in tests
by Robert Reif Nov. 6, 2008

Nov. 6, 2008

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > winmm: Increase tolerance range in tests > > Best Regards > Alistair Leslie-Hughes > Please give an explanation why? If it's just to make the test pass, then we need to know why the test is failing. Is it only needed for wine? Could be a wine problem. Is it only needed for specific versions of Windows or specific hardware or drivers? Is it only needed for Windows running on a virtual machine? Then it could be a a virtual machine hardware emulation problem. I think all Windows hardware test failures that only happen on virtual machines should be considered suspect. It would be nice to detect if Windows is running on real hardware or a virtual machine because of this type of problem.

4 4

Re: Vincent Povirk : setupapi: Implement ProfileItems directive.
by Rob Shearman Nov. 6, 2008

Nov. 6, 2008

2008/11/5 Vincent Povirk <vincent(a)codeweavers.com>: > + CoInitialize(NULL); > + > + if (!SUCCEEDED(CoCreateInstance( &CLSID_ShellLink, NULL, > + CLSCTX_INPROC_SERVER, &IID_IShellLinkW, (LPVOID*)&shelllink))) > + goto done; > + > + IShellLinkW_SetPath( shelllink, cmdline ); > + SHPathPrepareForWriteW( NULL, NULL, lnkpath, SHPPFW_DIRCREATE|SHPPFW_IGNOREFILENAME ); > + if (SUCCEEDED(IShellLinkW_QueryInterface( shelllink, &IID_IPersistFile, (LPVOID*)&persistfile))) > + { > + TRACE( "writing link: %s\n", debugstr_w(lnkpath) ); > + IPersistFile_Save( persistfile, lnkpath, FALSE ); > + IPersistFile_Release( persistfile ); > + } > + IShellLinkW_Release( shelllink ); > + > +done: > + HeapFree( GetProcessHeap(), 0, cmdline ); > return TRUE; You've forgotten to call CoUninitialize(). -- Rob Shearman

1 0

Finish the implementation of ID3DXMatrixStack
by paulo lesgaz Nov. 6, 2008

Nov. 6, 2008

Hello You should send one patch for one implementation of a function, not one patch for all the functions. Moreover, you should keep the style of the file. The semi-colon ; is placed just after the parenthesis ) not like this: ) ; David --- En date de : Mer 29.10.08, paulo lesgaz <jeremielapuree(a)yahoo.fr> a écrit : De: paulo lesgaz <jeremielapuree(a)yahoo.fr> Objet: D3DXMatrixstack: where to go.... À: "wine-devel" <wine-devel(a)winehq.org>, "Jérôme Gardou" <jerome.gardou(a)gmail.com> Date: Mercredi 29 Octobre 2008, 13h18 I did several patches about D3DXMAtrixStack. All were uncorrect. The idea of Henri to implement it is this one: it is very time -comsumming to allocate or to free memory. So one needs to do that as less as possible. So, we start with a stack with predefined size. When the stack is full, one multiplies by 2 its size. When one releases items enough of the stack, one divides its size by 2. Here are patches that implemented that idea. When looking at your patch, I saw that in my patch, in the D3dxMatrixstackImpl_release function, I do not free the memory of the array of matrix. It should be done. In the tests patch, I did not check if d3dxmatrixstackcreate fails. If it fails, tests should be skipped. At the end of the test, I did not call the _Release function. It should be done too. Maybe, you should use these patches and try to improve them. All the tests passed on my Windows XP box. David

1 0

Re: [2/2] WINED3D: Fix D3DCOLOR swizzling in shaders.
by Henri Verbeet Nov. 6, 2008

Nov. 6, 2008

2008/11/6 Mark Kilgard <mjk(a)nvidia.com>: > > WineD3D, > > Please be aware of this new OpenGL extension: > > http://www.opengl.org/registry/specs/EXT/vertex_array_bgra.txt > http://www.opengl.org/registry/specs/EXT/vertex_array_bgra.txt > > This extension allows OpenGL implementations supporting the extension to > implement the D3DCOLOR swizzle without any special coding. This extension > is fully supported in hardware by NVIDIA's upcoming 180.xx series drivers > for both Linux and Windows. > > - Mark Kilgard, NVIDIA > Yeah, we noticed that extension a few weeks ago. It looks pretty useful (as well as some of the other new extensions), and we'll certainly start using it once there's driver support. Henri

1 0

Implementing WFP
by C.J. Adams-Collier Nov. 5, 2008

Nov. 5, 2008

Hey all, What steps need to be taken to implement the WFP API using libwine? http://msdn.microsoft.com/en-us/library/bb427363(VS.85).aspx The first platform I'd like to see implementation on is Linux/iptables. *BSD/pf is next on the list followed by Solaris/ipf Cheers, C.J.

2 2

Re: [ddraw/tests] Fix a test on W2K3
by chris ahrendt Nov. 5, 2008

Nov. 5, 2008

Paul Vriens wrote: > Henri Verbeet wrote: > >> 2008/11/4 Paul Vriens <paul.vriens.wine(a)gmail.com>: >> >>> Hi, >>> >>> I upgraded to VMware 6.5.0 this morning and overlay tests are run now on my >>> W2K3 >>> box. As the return value indicates E_NOTIMPL I decided to add a skip() for >>> one particular test. >>> >>> >> VMware is not a valid test platform for ddraw. >> >> >> >> > And how would you like to approach that? Most of us run tests on some piece of > virtualization software. Should we check for VMware and don't run d3d8/9/10 and > ddraw tests anymore at all? We do want to have a green test.winehq.org after all. > > I agree that we shouldn't use VMware as a valid test platform for ddraw but as > long as the skips are kept to a minimum can't we live with that? > > (What would have happened with the patch when I wouldn't have mentioned VMware?) > > Actually as of 6.5 of VMWARE direct draw 9c is 100% supported. So why couldn't we use vmware 6.5 as a valid platform for testing direct draw api's? chris

2 1

Wine support for win64
by Alessandro Nov. 5, 2008

Nov. 5, 2008

Hi, i'd like to know if anyone knows the current status of wine's support fro win64. I've tried to build a git checkout with --enable-win64 configure switch. It has taken some tinkering to make it build, but after that i'm not able to run anything and ti seems that wineboot cannot start. Any suggestion? Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

9 9

Wine theming (follow up)
by Roderick Colenbrander Nov. 5, 2008

Nov. 5, 2008

Hi, The way to go for Wine theming is to use Windows XP themes. Unfortunately the file format itself is not documented. Based on Wine its uxtheme code (BTW our uxtheme is quite complete) and an analysis of some 'free' XP themes like 'ClearLook' I was able to write my own theme template. First of all for I want to warn all people who want to write Wine themes. A Windows theme consists of colors, font sizes, bitmaps and dimensions of controls. Windows theme editors use XP themes as a template for creating new themes, so even if you find a 'free' theme it is in the end derived from a Microsoft theme and most of the time Luna. Myself I analyzed the clearlooks and some other free ones just to understand Wine's uxtheme code. If you want to write themes use the uxtheme code as your reference. For instance dlls/uxtheme/stylemap.c shows which properties are allowed on each control. If a property on lets say a button is called 'CONTENTMARGINS' themes useally type 'ContentMargins', Anyway now to the theme file I created. A theme file is a resource file which contains various sections. They contain the names of the builtin color schemes, font sizes and of course the actual theme data. The theme data itself is stored in ini files. Most themes offer differ font sizes and colors and for each combination there is a ini file. The theme file I made only consists of a 'SysMetrics' section which contains the 'classic' color names which can also be adjusted from the Control Panel\\Colors registry location. The difference is that in XP Microsoft cleaned up the names, so some of the names have changed. The theme is compiled using mingw because right now winecfg seems to need a real 'MZ' header. A lot of work is needed especially in comctl32 and also in uxtheme its drawing code to optimize the drawing performance and to properly render themes. For this purpose you should use some free native XP themes and try them to render properly in Wine. The uxtheme drawing code needs to handle margins, locations and positions properly. Right now in case of a button comctl32 is making assumptions about text locations and I don't think that belongs there. Hopefully some people will step up to create Wine themes and improve utheme and our theme drawing. Myself I envision a 'winetheme.msstyles' which contains some GTK and QT color themes. Roderick -- "Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail

2 2

patchwatcher status: still coming up (ouch)
by Dan Kegel Nov. 5, 2008

Nov. 5, 2008

The new patchwatcher is sort of up; I'm focusing on things like getting the load balancing and blacklist right before I even think about email output. You can look at the results at http://kegel.com/wine/patchwatcher/results2/ but they will probably not be very reliable for a few more days. (And if anybody wonders why the heck I'm looking at this at 4AM, it's because my 5 year old climbed into our bed upside-down a few minutes ago and kicked me out in his sleep. Those little legs can do a lot of damage when they're aimed at your head :-)

1 0

Re: server: Do not cast zero.
by Henri Verbeet Nov. 5, 2008

Nov. 5, 2008

2008/11/4 Michael Stefaniuc <mstefani(a)redhat.de>: > --- > server/console.c | 2 +- > server/trace.c | 130 +++++++++++++++++++++++++++--------------------------- > 2 files changed, 66 insertions(+), 66 deletions(-) > server/trace.c is mostly auto generated, you'd have to modify tools/make_requests (line 341) instead.

2 1

Re: [PATCH 2/4] advapi32/tests: Simple tests of GetFileSecurity()/SetFileSecurity()
by James Hawkins Nov. 5, 2008

Nov. 5, 2008

On Wed, Nov 5, 2008 at 1:01 AM, Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> wrote: > This is a resubmission > > This patch has been reworked. > The changes in the Wine server is withdrawn. > Only a minimum of tests of GetFileSecurity() and SetFileSecuirty() for the > 'file case' are provided. > I haven't tried these tests myself, but as your are writing tests for your fixes, I can't imagine that these tests actually pass. If the tests fail, you have to wrap them in todo_wine. You can find examples of this all over the code base. -- James Hawkins

1 0

Re: [PATCH] comctl32: support drawing themed push buttons. [try 4] [resend]
by Alexandre Julliard Nov. 4, 2008

Nov. 4, 2008

"Reece Dunn" <msclrhd(a)googlemail.com> writes: > +static WCHAR *get_button_text(HWND hwnd, int *len) > +{ > + WCHAR *text; > + *len = GetWindowTextLengthW(hwnd); > + text = HeapAlloc(GetProcessHeap(), 0, (*len + 1) * sizeof(WCHAR)); > + if (text) > + GetWindowTextW(hwnd, text, *len + 1); > + return text; > +} You shouldn't return the length you got from GetWindowTextLength, it can sometimes be larger than necessary. Use the actual length of the string you fetched. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: [ddraw/tests] Fix a test on W2K3
by Henri Verbeet Nov. 4, 2008

Nov. 4, 2008

2008/11/4 Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi, > > I upgraded to VMware 6.5.0 this morning and overlay tests are run now on my > W2K3 > box. As the return value indicates E_NOTIMPL I decided to add a skip() for > one particular test. > VMware is not a valid test platform for ddraw.

2 3

Re: [PATCH 2/6] server: Fix lacuna in server side implementation of SetFileSecurity()
by Alexandre Julliard Nov. 4, 2008

Nov. 4, 2008

Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> writes: > The bit I take issue with is not cloning the "FIXME: get Unix uid and > call fchown" in file_set_sd(), nor really the idea that this bit of > code does nothing, not even return an error to indicate it has not > succeeded but that it is always executed (as it were). > > This is because, as the code stands, the object's sd is not current. > There should be a call to file_get_sd() to make it so, then > file_set_sd() will only (not) try to change the file's ownership only > if that is what the calling application wants. By putting the call to > get_sd() in handle.c, the fix covers all implementations of > get_sd()/set_sd(), which may not be what is wanted. No, it's not what is wanted. If there's a need to retrieve some information before setting that's the responsibility of the individual object. Also returning an error on setting the owner can potentially break some apps, for no good reason since we can't set the Unix owner anyway. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 1/6] advapi32: GetFileSecurity() a couple of simple tests and a fix
by Alexandre Julliard Nov. 4, 2008

Nov. 4, 2008

Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> writes: > This patch adds a couple of conformance tests that check 'error' > return codes. GetFileSecurity() is expected to be called twice - once > to find out how much memory to allocate and again once the memory has > been allocated. It seems the Windows implementation is a bit fussy > and the implementation of GetFileSecurity() was changed to match. That's not necessary, unless there's an application that depends on it. Behavior on invalid parameters is usually inconsistent on Windows too, so there's no need to write test cases for that sort of thing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32/tests: Run a test on more platforms (try2)
by Alexandre Julliard Nov. 4, 2008

Nov. 4, 2008

Nicolas Le Cam <niko.lecam(a)gmail.com> writes: > @@ -614,7 +614,9 @@ static void test_enum_provider_types(void) > DWORD dwTypeCount; > > /* actual values */ > - DWORD index = 0; > + /* the first provider type registry key may not have a TypeName subkey > + * we use the second one instead */ > + DWORD index = 1; That's just moving the problem around, there's no reason that the second one would always be guaranteed to have a typename. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: user32: handle GetMenuItemCount returning -1 (coverity 229)
by Alexandre Julliard Nov. 4, 2008

Nov. 4, 2008

Aric Stewart <aric(a)codeweavers.com> writes: > diff --git a/dlls/user32/mdi.c b/dlls/user32/mdi.c > index fe70b80..1404436 100644 > --- a/dlls/user32/mdi.c > +++ b/dlls/user32/mdi.c > @@ -393,7 +393,8 @@ static LRESULT MDISetMenu( HWND hwnd, HMENU hmenuFrame, > */ > static LRESULT MDI_RefreshMenu(MDICLIENTINFO *ci) > { > - UINT i, count, visible, id; > + UINT i, visible, id; > + INT count; This shouldn't happen since the menu has just been validated. And if you really want to handle that case you have to treat it as an error, not just ignore it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: let automated testers force all DNS lookups to return localhost
by James Mckenzie Nov. 4, 2008

Nov. 4, 2008

Hans Leidekker <hans(a)codeweavers.com> at Oct 31, 2008 5:32 AM wrote about Re: wininet: let automated testers force all DNS lookups to return localhost >> Only include this in debugging builds. > >What happened to your /etc/hosts proposal? It has the >advantage that we don't need changes to Wine source code. > This would not work on Macs as /etc/hosts is locked to admins only and would be a problem to implement. James McKenzie

6 9

Re: [1/5] d3d9: Use the correct AddRef and Release Macros
by Henri Verbeet Nov. 3, 2008

Nov. 3, 2008

I don't think this patch makes sense.

2 3

Re: Henri Verbeet : ddraw: Make sure pWineDirect3DCreate and pWineDirect3DCreateClipper match the header .
by Rob Shearman Nov. 3, 2008

Nov. 3, 2008

2008/10/24 Alexandre Julliard <julliard(a)winehq.org>: > diff --git a/dlls/ddraw/ddraw_private.h b/dlls/ddraw/ddraw_private.h > index 7ff3c5c..cd1ce15 100644 > --- a/dlls/ddraw/ddraw_private.h > +++ b/dlls/ddraw/ddraw_private.h > @@ -414,8 +414,7 @@ struct IDirectDrawClipperImpl > > const IDirectDrawClipperVtbl IDirectDrawClipper_Vtbl; > > -typedef IWineD3DClipper* (WINAPI *fnWineDirect3DCreateClipper)(IUnknown *); > -fnWineDirect3DCreateClipper pWineDirect3DCreateClipper; > +typeof(WineDirect3DCreateClipper) *pWineDirect3DCreateClipper; This isn't portable to some compilers, like MSVC. Can this be reverted? -- Rob Shearman

2 2

Re: [resend 2] [try4] advapi32: Implement CredReadDomainCredentials stub and tests
by Alexandre Julliard Nov. 3, 2008

Nov. 3, 2008

Andrey Turkin <andrey.turkin(a)gmail.com> writes: > + if (TargetInformation->TargetName) > + { > + TargetInformationW->TargetName = buffer; > + buffer += MultiByteToWideChar(CP_ACP, 0, TargetInformation->TargetName, -1, > + TargetInformationW->TargetName, -1); You need to pass the correct destination length, not -1. -- Alexandre Julliard julliard(a)winehq.org

1 0

General script for installing Wine build dependencies
by Dan Kegel Nov. 2, 2008

Nov. 2, 2008

I have in the past written one script per version of Ubuntu to install Wine's build dependencies. Many versions on, that's getting old, and I figure it'd be better to have a single script that handles all common versions on Linux. I've taken a first stab at that, combining my scripts for gutsy and hardy, and adding ibex. The result is at http://winezeug.googlecode.com/svn/trunk/install-wine-deps.sh If anyone wants to add support to that script for another OS, please do, and send me the patch. I'd like to see this in the wine tree sometime. It's kind of silly we have to direct people to a big, confusing wiki page (or set of them) to explain how to install the needed packages; let's just have a unified script and be done with it.

4 8

patchwatcher status: still offline
by Dan Kegel Nov. 2, 2008

Nov. 2, 2008

Let me know if these updates get annoying. I'm bringing up a three-node patchwatcher cluster (master plus two build slaves), and updating http://winezeug.googlecode.com/svn/trunk/patchwatcher/readme.txt as I go. It's coming along ok, but it'll probably be another few days before it's up. - Dan

1 0

[Re] Vertex pipeline replacement
by Tobias Jakobi Nov. 2, 2008

Nov. 2, 2008

Short feedback: - Max Payne 2: works as expected, I don't see any visual changes - Morrowind: 3D rendering breaks completly, minor (blending?) issues in the menu as well - however ingame scenes are fully black now How should I report this? Open a bug? Should I do any regression testing (since your patchset consists of more than one patch)? Greets, Tobias

7 10

rfc: refactoring msxml3 to get rid of aggregation
by Michael Karcher Nov. 2, 2008

Nov. 2, 2008

Hello developers, the msxml3 code currently uses aggregation to implement IXMLDOMNode on all of the different DOM tree elements. As the interfaces for these elements are all derived from IXMLDOMNode, a lot of forwarding thunks have to be implemented to get the calls into the inner object. The attached patch series modifies the source code to derive the objects instead, which seems like the more natural approach to get derived interfaces implemented. The attached patches still have to be cleaned up: They contain lines ending with whitespace, incosistent spacing around function call parenthesis, incosistent style of using a cast helper function or direct casting and other small nits. A more important problem with these patches that make me write this mail is that they generate lots of compiler warnings like | domdoc.c:1556: warning: initialization from incompatible pointer type which is of no surprise, as the vtable for domdoc expects a function taking an IXMLDOMDocument as "this" pointer while I provide a function taking an interface pointer to an IXMLDOMNode as "this" pointer. Both of these pointers point to the same address (as usual for derived objects), so the conversion is safe, but the simple-minded C compiler can't know that. The question that arises is how to handle these warnings. a) ignore them (most probably not an option) b) add lots of casts (only way to make the idea of these patches fly) c) write lots of little forwarding functions that convert the this pointer. d) ditch the idea of using derivation instead of aggregation Any oppions on that? I (obviously) think that b is the right solution, but as a quick grep over the Wine source code revealed, this solution seems to be used nowhere. Is that because this is the first place where deriving makes sense or is that because I'm completely off-track? Kind regards, Michael Karcher PS: The munged "From " lines in the attached patches are intentional. They keep my email program from choosing "application/mbox" as MIME type.

2 2

Re: [PATCH] mountmgr: Add and remove drives when they are (un)mounted.
by Vitaliy Margolen Nov. 2, 2008

Nov. 2, 2008

Lei Zhang wrote: > Hi, > > It looks like mountmgr.sys does not remove drives when devices are > unmounted. We should look at the is_mounted property and take the > appropriate action when it changes. This is going the wrong way. Wine already can't deal with blank media without some "hackish" workarounds. With this patch you will break even that. Wine should keep drive visible for applications even if there is not media or a blank media inserted. Vitaliy.

2 1

Re: wininet: let automated testers force all DNS lookups to return localhost
by Rob Shearman Nov. 2, 2008

Nov. 2, 2008

2008/10/31 Dan Kegel <dank(a)kegel.com>: > The public internet can (and does) go pear-shaped > in the middle of test runs, which means any test > that tries to access the public internet is de facto > flaky, even if it tries to protect itself by skipping > if the internet is down. > > So let's provide a way for automated testers to > force all hostname resolution requests to > return the same result (say, 'localhost' or 'mytestserver'). > Only include this in debugging builds. > > Later we should provide a script to set up > a local test server that can handle all of > our conformance tests' requests, but for > now, just letting patchwatcher or winetest > redirect everything to localhost will let tests > fail reliably instead of randomly. > See http://bugs.winehq.org/show_bug.cgi?id=15716 This approach won't help users of the Wine conformance tests running on Windows, so it appears to me to be a flawed approach. We should instead rewrite any existing tests that use a public server to instead use a server started by the Wine test code (see dlls/wininet/tests/http.c:server_thread). This has the additional benefit of allowing us to be much more precise with what we're testing and to be able to emulate the implementations of different HTTP servers, instead of just what winehq.org runs. -- Rob Shearman

1 0

patchwatcher status: offline
by Dan Kegel Nov. 1, 2008

Nov. 1, 2008

I'm taking the patchwatcher machines down to upgrade them to Intrepid Ibex this weekend. Incidentally, a jaguar plowed through the corner of our garage here at home. For a short while it was a 2.1 car garage :-) I may be somewhat distracted until that's dealt with somehow. - Dan

1 0

Conformance test to try on a windows box.
by Jérôme Gardou Nov. 1, 2008

Nov. 1, 2008

I'm currently implementing the D3DXMatrixStack interface. Could someone try these tests on a windows machine before I go further ?

3 9

Re: [try 2] [2/2] mlang: Add implementation offnIMLangFontLink_GetCharCodePages
by Dmitry Timoshkov Nov. 1, 2008

Nov. 1, 2008

"Vitaly Perov" <vitperov(a)etersoft.ru> wrote: > Changed since last send: use mlang internal mlang_data structures instead of > static array. You still haven't done the other part: use Win32 APIs EnumSystemCodePages/ GetCPInfo/WideCharToMultiByte instead of accessing Wine internals directly. -- Dmitry.

2 4