November 2008 - Wine-Devel - list.winehq.org

Re: jscript: Implement the String.toLowerCase() method.
by Jacek Caban Nov. 23, 2008

Nov. 23, 2008

Hi Andrew, Andrew Nguyen wrote: > This is an attempt to implement the String.toLowerCase method. The > added jscript tests pass on Windows XP. > --- > dlls/jscript/string.c | 41 +++++++++++++++++++++++++++++++++++++++-- > dlls/jscript/tests/api.js | 11 +++++++++++ > 2 files changed, 50 insertions(+), 2 deletions(-) > > > + res = heap_alloc((length+1)*sizeof(WCHAR)); > + if (!res) > + return E_OUTOFMEMORY; You can avoid this allocation by using SysAllocStringLen. Jacek

1 0

Re: msxml3: Implement IXMLDOMAttribute get/put value
by Alistair Leslie-Hughes Nov. 23, 2008

Nov. 23, 2008

Ignore this patch. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:49269ECA.7070202(a)hotmail.com... > Hi, > > Changelog: > msxml3: Implement IXMLDOMAttribute get/put value > > Best Regards > Alistair Leslie-Hughes > > > -------------------------------------------------------------------------------- > From 485959eb359d1efdf66c4be1aa110ba47877847c Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 21 Nov 2008 21:36:30 +1100 > Subject: [PATCH] Implement IXMLDOMAttribute get/put value > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msxml3/attribute.c | 8 ++++---- > dlls/msxml3/node.c | 21 +++++++++++++++------ > dlls/msxml3/tests/domdoc.c | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 49 insertions(+), 10 deletions(-) > > diff --git a/dlls/msxml3/attribute.c b/dlls/msxml3/attribute.c > index 2681a76..92cafad 100644 > --- a/dlls/msxml3/attribute.c > +++ b/dlls/msxml3/attribute.c > @@ -482,16 +482,16 @@ static HRESULT WINAPI domattr_get_value( > IXMLDOMAttribute *iface, > VARIANT *var1) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domattr *This = impl_from_IXMLDOMAttribute( iface ); > + return IXMLDOMNode_get_nodeValue( This->node, var1 ); > } > > static HRESULT WINAPI domattr_put_value( > IXMLDOMAttribute *iface, > VARIANT var1) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domattr *This = impl_from_IXMLDOMAttribute( iface ); > + return IXMLDOMNode_put_nodeValue( This->node, var1 ); > } > > static const struct IXMLDOMAttributeVtbl domattr_vtbl = > diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c > index 19cee8f..6693803 100644 > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > @@ -339,13 +339,22 @@ static HRESULT WINAPI xmlnode_put_nodeValue( > > TRACE("%p type(%d)\n", This, This->node->type); > > - VariantInit(&string_value); > - hr = VariantChangeType(&string_value, &value, 0, VT_BSTR); > - if(FAILED(hr)) > + /* Attribute nodes treat NULL Variants as empty strings. */ > + if(V_VT(&value) == VT_NULL && This->node->type == XML_ATTRIBUTE_NODE) > { > - VariantClear(&string_value); > - WARN("Couldn't convert to VT_BSTR\n"); > - return hr; > + V_VT(&string_value) = VT_BSTR; > + V_BSTR(&string_value) = SysAllocStringLen(NULL, 0); > + } > + else > + { > + VariantInit(&string_value); > + hr = VariantChangeType(&string_value, &value, 0, VT_BSTR); > + if(FAILED(hr)) > + { > + VariantClear(&string_value); > + WARN("Couldn't convert to VT_BSTR\n"); > + return hr; > + } > } > > hr = S_FALSE; > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index e27c506..c975d73 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -2796,12 +2796,18 @@ static void test_xmlTypes(void) > ok( V_VT(&v) == VT_NULL, "incorrect dataType type\n"); > VariantClear(&v); > > + V_VT(&v) = VT_NULL; > + V_I4(&v) = 0; > + hr = IXMLDOMElement_put_nodeValue(pElement, v); > + ok(hr == DISP_E_TYPEMISMATCH, "ret %08x\n", hr ); > + > /* Attribute */ > hr = IXMLDOMDocument_createAttribute(doc, szAttribute, > &pAttrubute); > ok(hr == S_OK, "ret %08x\n", hr ); > if(hr == S_OK) > { > IXMLDOMNode *pNewChild = (IXMLDOMNode *)0x1; > + IXMLDOMNode *pAttrNode = NULL; > > hr = IXMLDOMAttribute_get_nextSibling(pAttrubute, > NULL); > ok(hr == E_INVALIDARG, "ret %08x\n", hr ); > @@ -2876,6 +2882,30 @@ static void test_xmlTypes(void) > ok( V_VT(&v) == VT_NULL, "incorrect dataType type\n"); > VariantClear(&v); > > + /* test value */ > + V_VT(&v) = VT_NULL; > + VariantClear(&v); > + hr = IXMLDOMAttribute_put_value(pAttrubute, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + VariantClear(&v); > + > + hr = IXMLDOMAttribute_get_value(pAttrubute, &v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + ok( !lstrcmpW( V_BSTR(&v), _bstr_("") ), "incorrect > get_value string\n"); > + VariantClear(&v); > + > + IXMLDOMAttribute_QueryInterface(pAttrubute, > &IID_IXMLDOMNode, (LPVOID*)&pAttrNode); > + if(hr == S_OK) > + { > + V_VT(&v) = VT_NULL; > + VariantClear(&v); > + hr = IXMLDOMNode_put_nodeValue(pAttrNode, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + VariantClear(&v); > + > + IXMLDOMNode_Release(pAttrNode); > + } > + > IXMLDOMAttribute_Release(pAttrubute); > > /* Check Element again with the Add Attribute*/ > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

re: How do I create a backtrace?
by Dan Kegel Nov. 22, 2008

Nov. 22, 2008

The FAQ covers this: http://wiki.winehq.org/FAQ#head-16da35b6327024d6ea576e3678488b16862d0f5e

1 0

How do I create a backtrace?
by Matt Perry Nov. 22, 2008

Nov. 22, 2008

I've been asked by a Wine developer to provide a backtrace along with a "+relay,+seh" log for a bug that I have filed. I've read through the developer documentation but I can't figure out how to do this. I sent an email to the developer with a request for instructions but have not received a reply. Could someone here instruct me on how to do this? I'm a non-programmer so please take that into consideration with regards to your instructions. Thanks. Matt

2 1

Re: Wine release 1.1.9
by Francois Gouget Nov. 22, 2008

Nov. 22, 2008

On Fri, 21 Nov 2008, Alexandre Julliard wrote: > The Wine development release 1.1.9 is now available. > > What's new in this release (see below for details): > - A large number of regression test fixes. <nitpick> Actually it's not regression tests, and it's not regression fixes. It's conformance tests, their main goal is to describe the Windows behavior, so that we can then know whether Wine _conforms_ to that behavior or not. And all (or almost all) of the fixes are so that the tests actually describe the Windows behavior. </nitpick> -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ I haven't lost my mind, it's backed up on tape around here somewhere...

3 3

Regarding ./configure file
by shanmukha sainath addepalli Nov. 22, 2008

Nov. 22, 2008

Sir/Madam, I need to add few functions related to libwnck. It requires some header files to be included. I included them in wine source code. But when compiled it says header files not found. I haven't updated configure file. How can i update it? please tell me what r the changes that i need to made? Regards, Sainath.

7 6

LPD3DXMESH
by Krzysztof Drewniak Nov. 22, 2008

Nov. 22, 2008

What header is LPD3DXMESH supposed to be declared in? Krzys D.

5 4

[RFC/RFH] winmm:wave hang fix question (commit 717df5b2972b3cb998ca5a43279ae2283b117eaa) [bug 15559]
by Reece Dunn Nov. 21, 2008

Nov. 21, 2008

Hi, Looking at the history of that test (http://test.winehq.org/data/tests/winmm:wave.html) I see a lot of timeout errors on the Wine builds, even after this fix went in. The fix itself has caused a regression of playback in many applications and games that play audio (http://bugs.winehq.org/show_bug.cgi?id=15559) I want to submit the following patch to revert the part of the patch that caused the regression and fix some of the tracing. I have been using this patch on Cepstral SwiftTalker without issue and have tested it also with the game Azguard Defense. I am submitting this here and not to wine-patches initially, as I would like to understand what the fix was actually fixing and (based on the test history still showing timeouts) whether it actually fixes the issue it was trying to. diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 6cb2da8..b3f52aa 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -103,14 +103,19 @@ static BOOL wodUpdatePlayedTotal(WINE_WAVEDEV* wwo, snd_pcm_status_t* ps) state = snd_pcm_state(wwo->pcm); snd_pcm_delay(wwo->pcm, &delay); + if (state != SND_PCM_STATE_RUNNING && state != SND_PCM_STATE_PREPARED) + { + WARN("Unexpected state (%d) while updating Total Played, resetting\n", state); + delay=0; + } + /* A delay < 0 indicates an underrun; for our purposes that's 0. */ if (delay < 0) { - WARN("Unexpected state (%d) or delay (%ld) while updating Total Played, resetting\n", state, delay); + WARN("Unexpected delay (%ld) while updating Total Played, resetting\n", delay); delay=0; } - if (state == SND_PCM_STATE_XRUN) - snd_pcm_start(wwo->pcm); + InterlockedExchange((LONG*)&wwo->dwPlayedTotal, wwo->dwWrittenTotal - snd_pcm_frames_to_bytes(wwo->pcm, delay)); return TRUE; } - Reece

2 2

Re: urlmon #6: Added more policy tests.
by Paul Vriens Nov. 21, 2008

Nov. 21, 2008

Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 78 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 77 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Jacek, I'm checking out a test failure on a fresh and clean W2K3 box with SP2 and IE6. Right after this (line 859): + policy = 0xdeadbeef; + hres = IInternetZoneManager_GetZoneActionPolicy(zonemgr, 3, action, (BYTE*)&policy, + sizeof(DWORD), URLZONEREG_DEFAULT); I get a popup asking if I want to add www.winehq.org to the "Trusted sites zone". If I don't add this site the test succeeds. If I add it the test fails (over and over again). I didn't change any of the default IE6 (W2K3 specific?) security settings. I do see that adding this site to that zone doesn't change the content of the checked registry key but instead a new one is created: HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ZoneMap\EscDomains\winehq.org and HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ZoneMap\EscDomains\winehq.org\www with a 'http' REG_DWORD (value = 2) underneath that last one. So how should we proceed fixing/changing this test? -- Cheers, Paul.

2 1

Re: [4/5] wined3d: Use IDL to generate wined3d_interface.h.
by Rob Shearman Nov. 21, 2008

Nov. 21, 2008

2008/11/21 Henri Verbeet <hverbeet(a)codeweavers.com>: > +cpp_quote("#if 0") > +import "wined3d_types.idl"; > +import "wined3d_caps.idl"; ... > +cpp_quote("#endif") > + > +cpp_quote("#include \"wine/wined3d_types.h\"") > +cpp_quote("#include \"wine/wined3d_caps.h\"") You can't do this. It won't work in MIDL and it won't work in widl when it is fixed to put the includes for imported files at the start of the generated header file, rather than in between the statements generated from neighbouring IDL statements. You need to find another way of solving the issue you are facing. -- Rob Shearman

2 1

Re: [3/5] wined3d: Use IDL to generate wined3d_caps.h.
by Rob Shearman Nov. 21, 2008

Nov. 21, 2008

2008/11/21 Henri Verbeet <hverbeet(a)codeweavers.com>: > +cpp_quote("#if 0") > +import "wined3d_types.idl"; > +cpp_quote("#endif") This won't work either, for the same reason as I mentioned for the 4/5 patch. -- Rob Shearman

1 0

re: Add wtmpnam to msvcrt.dll
by Dan Kegel Nov. 21, 2008

Nov. 21, 2008

Hi Tim, welcome to Wine! > A diff (relative to wine-1.1.8/dlls/msvcrt/file.c) is attached. Whoops, you attached the undiffed file! > I did not even get as far as successfully building it to test it Ah. Such patches usually get attached to bug reports in bugzilla or sent to wine-devel. wine-patches is for tested and known working patches. > I'd be happy to do a test build (assuming I can successfully > install the dependencies) That should be easy, see http://wiki.winehq.org/Recommended_Packages > if MSVCRT_tmpname gets initialized, where does that occur? It gets initialized by tmpnam(). Presumably _wtmpnam() will need its own static buffer. Also, please be sure to write a conformance test (see http://www.winehq.org/site/docs/winedev-guide/testing ) for your change! Thanks, Dan p.s. The MSDN doc for this, FWIW, is at http://msdn.microsoft.com/en-us/library/hs3e7355(VS.80).aspx

1 0

dead stores in advapi32
by ricardo filipe Nov. 21, 2008

Nov. 21, 2008

hi rob. i have some dead stores in advapi32 files that i would like to clarify. first, what do you want to do on lines 173 and 194 of cred.c? now, there are also 3 dead assignments in cred.c, lines 992, 199 and 1064. i didn't understand what you meant in your last email about my patch that removed dead code in ole32, so since this is dead code i think i can remove it, but i'm not sure anymore since you confused me. regards, ricardo _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

2 1

Disable regression tests option now available in git!
by Austin English Nov. 21, 2008

Nov. 21, 2008

For those of you that don't monitor wine-commit, Alexandre committed a patch today to disable building the regression tests: http://source.winehq.org/git/wine.git/?a=commitdiff;h=35078f4b57523d4afe00d… So the manual PITA patching is no longer necessary. I've updated the Regression Testing wiki page as well. Thanks Alexandre! -- -Austin

1 0

Re: dlls/ole32: check some dead store results (llvm/clang)
by Michael Karcher Nov. 20, 2008

Nov. 20, 2008

Am Donnerstag, den 20.11.2008, 18:36 +0000 schrieb ricardo filipe: | - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { | + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey) == ERROR_SUCCESS) { No. This inverts the logic of the tests. if(x) means if(x != 0). And ERROR_SUCCESS is just zero. To prevent just this possible mistake, a patch making the condition obvious was requested. Regards, Michael Karcher

1 0

Fedora 9 and MingW
by Paul Vriens Nov. 20, 2008

Nov. 20, 2008

Hi, I was still using the rpm's that Hans provided in the past. Some searching shows: https://fcp.surfsite.org/modules/newbb/viewtopic.php?topic_id=61801&forum=11 I've installed these rpm's but the executables use a different naming convention: i686-pc-mingw32* instead of what we check for: i686-mingw32*. Should we add this to our configure? -- Cheers, Paul.

3 2

Re: cryptdlg: Implement FormatVerisignExtension (take 2)
by Alexandre Julliard Nov. 20, 2008

Nov. 20, 2008

"Juan Lang" <juan.lang(a)gmail.com> writes: > + LPWSTR verisign_statement; > + DWORD bytesNeeded; > + > + LoadStringW(hInstance, IDS_VERISIGN_STATEMENT, > + (LPWSTR)&verisign_statement, 0); > + bytesNeeded = (strlenW(verisign_statement) + 1) * sizeof(WCHAR); You can't use strlenW here, the string is not null-terminated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw/tests: Make the webbrowser test dpi aware, make is pass in wine
by Paul Vriens Nov. 20, 2008

Nov. 20, 2008

Detlef Riekenberg wrote: > I set every dpi between 72 and 100 on Windows, wrote down the results > and > multiplied the results with the dpi value. > The formula ist the best guess. > Works on win98, w2k, Wine > Hi Detlef, This one introduces some extra failures now. If I look at the comment in your patch it says: /* The default size is dpi dependent (96:1323x529 / 120:1058x423) */ and if I look at some of the results on test.winehq.org: webbrowser.c:1840: Test failed: size = {1323 529} (expected 1322 529) This suggests that the calculation in the ok() should be rounded up? Or maybe deal with both situations? -- Cheers, Paul.

1 0

Re: dlls/rpcrt4: fixed dead increments (llvm/clang)
by Rob Shearman Nov. 19, 2008

Nov. 19, 2008

2008/11/18 ricardo filipe <ricardo_barbano(a)hotmail.com>: > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index 3d66740..815ed64 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -479,7 +479,6 @@ static size_t rpcrt4_ncacn_np_get_top_of_tower(unsigned char *tower_data, > memcpy(tower_data, networkaddr, networkaddr_size); > else > tower_data[0] = 0; > - tower_data += networkaddr_size; > > return size; > } > @@ -692,7 +691,6 @@ static size_t rpcrt4_ncalrpc_get_top_of_tower(unsigned char *tower_data, > pipe_floor->count_rhs = endpoint_size; > > memcpy(tower_data, endpoint, endpoint_size); > - tower_data += endpoint_size; > > return size; > } These increments are intentional in case the code is copy and pasted and some more data is added to the end, so please don't remove them. -- Rob Shearman

2 1

Re: dlls/ole32: fixed dead assignments (llvm/clang)
by Rob Shearman Nov. 19, 2008

Nov. 19, 2008

2008/11/18 ricardo filipe <ricardo_barbano(a)hotmail.com>: > @@ -1951,6 +1951,12 @@ HRESULT WINAPI CoRegisterClassObject( > newClass->pMarshaledData, > flags & (REGCLS_MULTIPLEUSE|REGCLS_MULTI_SEPARATE), > &newClass->RpcRegistration); > + MSHLFLAGS_TABLESTRONG); This won't compile. > + if (hr) { > + FIXME("RPC_StartLocalServer failed, %x!\n",hr); You should change this to: ERR("RPC_StartLocalServer failed with error 0x%x\n",hr); > + return hr; > + } > + > } > return S_OK; > } > diff --git a/dlls/ole32/ole16.c b/dlls/ole32/ole16.c > index a8fa59b..21fb1fb 100644 > --- a/dlls/ole32/ole16.c > +++ b/dlls/ole32/ole16.c > @@ -598,13 +598,13 @@ HRESULT WINAPI CLSIDFromProgID16(LPCOLESTR16 progid, LPCLSID riid) > > buf = HeapAlloc(GetProcessHeap(),0,strlen(progid)+8); > sprintf(buf,"%s\\CLSID",progid); > - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { > + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey)) { Since you are changing this anyway, you should explicitly compare the result against ERROR_SUCCESS to improve readability of the code here. > HeapFree(GetProcessHeap(),0,buf); > return CO_E_CLASSSTRING; > } > HeapFree(GetProcessHeap(),0,buf); > buf2len = sizeof(buf2); > - if ((err=RegQueryValueA(xhkey,NULL,buf2,&buf2len))) { > + if (RegQueryValueA(xhkey,NULL,buf2,&buf2len)) { Ditto. > RegCloseKey(xhkey); > return CO_E_CLASSSTRING; > } -- Rob Shearman

1 0

spec file syntax for VARIANT parameter
by Jeremy Drake Nov. 19, 2008

Nov. 19, 2008

In order to implement OleLoadPictureFile and OleLoadPictureFileEx, it will be necessary to change their entries in oleaut32.spec from stub to stdcall. The stdcall syntax wants a list of parameter types, which puts these functions in an unususal situation: they take a VARIANT (which is a struct, in case anyone is not familiar) by value as their first parameter. There does not seem to be any type defined in the spec file that fits this situation. I have been using ptr in my last couple of patches which add stub implementations for these functions, but when I tried to build this on cygwin I got errors like: undefined reference to `_OleLoadPictureFileEx(a)20' undefined reference to `_OleLoadPictureFile(a)8' Looking at the functions that are present in the .o file, I see they are really _OleLoadPictureFileEx(a)32 and _OleLoadPictureFile(a)20. Changing the spec file to list each VARIANT as 4 longs fixes these errors. My question is, should my next version of the patch list the VARIANT as 4 longs, or is there some better way to specify this that I'm not aware of? If not, is there a comment syntax for the spec file where I can explain why there are 4 long params where there should be one VARIANT? Thanks Jeremy

2 1

Re: dlls/msxml3: check some dead store results (llvm/clang)
by Paul Vriens Nov. 19, 2008

Nov. 19, 2008

ricardo filipe wrote: > only return value checking in this patch. > > _________________________________________________________________ > Confira vídeos com notícias do NY Times, gols direto do Lance, videocassetadas e muito mais no MSN Video! > http://video.msn.com/?mkt=pt-br > > > ------------------------------------------------------------------------ > > You are mixing tabs and spaces. -- Cheers, Paul.

1 0

RE: netapi32: Actually return a couple of return values.
by ricardo filipe Nov. 19, 2008

Nov. 19, 2008

it seems you two fixed the same, juan sent a patch in a previous wine-devel email. you might want to check that because you two have different solutions for the first problem, line 415. > From: kai.blin(a)gmail.com > Date: Wed, 19 Nov 2008 12:41:50 +0100 > Subject: netapi32: Actually return a couple of return values. > To: wine-patches(a)winehq.org > > > ricardo filipe <ricardo_barbano(a)hotmail.com> found a couple of dead return > value assignments in nbt.c and netbios.c > > Fix up these error paths. > --- > dlls/netapi32/nbt.c | 12 +++++++++++- > dlls/netapi32/netbios.c | 2 +- > 2 files changed, 12 insertions(+), 2 deletions(-) _________________________________________________________________ Receba GRÁTIS as mensagens do Messenger no seu celular quando você estiver offline. Conheça o MSN Mobile! http://mobile.live.com/signup/signup2.aspx?lc=pt-br

1 0

dead stores in netapi32
by ricardo filipe Nov. 19, 2008

Nov. 19, 2008

hi juan! i'm tracking some dead stores with Clang and i've found some in files you created that i'm not comfortable messing with. file dlls/netapi32/nbt.c: lines: 419 839 1185 1192 1201 file dlls/netapi32/netbios.c: lines: 634 636 i thought you might want to have a look at it :) regards, ricardo _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

3 3

Contribute to wine
by Krzysztof Drewniak Nov. 18, 2008

Nov. 18, 2008

I'd like to contribute something to wine, but I don't know what? Can I get a list? Krzys D. P.S. The audio is choppy on Ubuntu 8.10 with latest git.

3 2