November 2008 - Wine-Devel - list.winehq.org

Re: user32: TPM_ENTERIDLEEX needs to be set for popup windows (resend)
by David Adam Nov. 14, 2008

Nov. 14, 2008

You need to est your email adress in your patches. David 2008/11/12 Nicholai Benalal <nicholai(a)t-online.de> > Changelog: > user32:TPM_ENTERIDLEEX needs to be set for popup windows since > applications expect the owner window to be set for WM_ENTERIDLE. A NULL > window made several applications, such as Fritz 9 - 11 crash (see bug 9615) > > Best regards, > > Nicholai Benalal (olympia(a)skydreams.org) > > > > > >

3 2

Users posting to wine-bugs
by Luke Bratch Nov. 13, 2008

Nov. 13, 2008

Hi You may remember me as the person that does the mailing list moderation. Every day there are always several users posting directly to wine-bugs, as they are hitting reply to emails generated by Bugzilla instead of posting in Bugzilla itself. I added a message in the text that Bugzilla generates to make it clearer to not reply to the email a few months ago, which at the time seemed to improve things but as of late the number of emails has been going up again. Is anybody opposed to me setting up an auto-responder so that any mail going to wine-bugs(a)winehq.org gets auto responded to with a message to post in Bugzilla instead? I ask this in wine-devel as I'm not sure who is the actual administrator of the lists are. Thanks Luke Bratch

4 6

Re: DDRAW: ComputeSphereVisibility: Am I in the good way?
by paulo lesgaz Nov. 13, 2008

Nov. 13, 2008

I need to use some functions implemented in d3dx8 to do the job. Can I link this dll to ddraw (even if it is not logical in a Windows point of view) or I need to reimplement all the needed math functions in wined3d? David --- En date de : Jeu 13.11.08, Henri Verbeet <hverbeet(a)gmail.com> a écrit : De: Henri Verbeet <hverbeet(a)gmail.com> Objet: Re: DDRAW: ComputeSphereVisibility: Am I in the good way? À: jeremielapuree(a)yahoo.fr Cc: wine-devel(a)winehq.org Date: Jeudi 13 Novembre 2008, 16h13 2008/11/13 paulo lesgaz <jeremielapuree(a)yahoo.fr>: > Hello > > I would like to implement ComputeSphereVisibility. The sting game is > completely black because of this stubbed function. Here is my idea to > implement it. Am I in the good way, or it is completely a bad idea? > > With GetViewport, I retrieve the viewport matrix V, and with GetTransform, > I retrieve projection P and world W matrices ofn the device. > > I multiply the three matrices in a matrice M: M=VPW > > If M is singular, function returns with a failing message > Otherwise, with the matrix M I retrieve the planes of the frustum view > (that's a little bit of math, but quite easy) > > Then for each sphere, > > Let Visibility=0 > for each plane of the frustum view > Let I be the intersection of the orthogonal projection of the center > sphere on the plane. > If I is in the frustum view, then I have the visibility.So > Visibility=Visibility|(flag for the visibility of the chosen plane) > > Once I did it for the 6 plane, I have the visibility of the sphere. > > Is it a good point of start? > > David > The basic idea sounds about right. I don't think you need to project the sphere onto the frustum planes, just using the plane normal to calculate the distance to the sphere center should do.

2 1

Only ~100 valgrind errors left?
by Dan Kegel Nov. 13, 2008

Nov. 13, 2008

I'm getting back to valgrinding again. In preparation for adding valgrind runs to patchwatcher, I'm running the test suite through valgrind zillions of times, looking at how repeatable the results are. At the moment it looks like there is an annoyingly long tail of less likely failures, which is going to be a pain. On the bright side, it is looking like there aren't that many frequent valgrind errors left. See http://kegel.com/wine/valgrind/2008-11-13.txt for a manually deduplicated list. It only shows about 100 problems. Here's the breakdown by error type: 1 InvalidJump 3 InvalidWrite 7 Leak_DefinitelyLost 7 UninitValue 11 SyscallParam 25 InvalidRead 52 UninitCondition A word of warning: don't go fixing the problems behind these warnings unless you really know what you're doing. Superficial fixes are worse than no fix. That said, if anyone has a really good grasp of any of these problems, please go ahead and fix, or let me know which of these should be suppressed. For no particularly good reason, I've omiitted filenames, the list only includes function names and line numbers. That should have the unintended benefit of discouraging people unfamiliar with the code from jumping in and fixing things... Thanks, Dan

1 0

Re: user32: The default WM_CANCELMODE handler needs to call EndMenu() also in the case of a child window (resend)
by Vincent Povirk Nov. 13, 2008

Nov. 13, 2008

Please write a test for this scenario. Vincent Povirk On Tue, Nov 11, 2008 at 6:40 PM, Nicholai Benalal <nicholai(a)t-online.de> wrote: > Changelog: > user32: The default WM_CANCELMODE handler needs to call EndMenu() also in > the case of a child window. With the previous condition, Chessbase > applications never closed their application menus and several would open > at the same time > > Best regards, > > Nicholai Benalal (olympia(a)skydreams.org) > > > > > >

2 1

DDRAW: ComputeSphereVisibility: Am I in the good way?
by paulo lesgaz Nov. 13, 2008

Nov. 13, 2008

Hello I would like to implement ComputeSphereVisibility. The sting game is completely black because of this stubbed function. Here is my idea to implement it. Am I in the good way, or it is completely a bad idea? With GetViewport, I retrieve the viewport matrix V, and with GetTransform, I retrieve projection P and world W matrices ofn the device. I multiply the three matrices in a matrice M: M=VPW If M is singular, function returns with a failing message Otherwise, with the matrix M I retrieve the planes of the frustum view (that's a little bit of math, but quite easy) Then for each sphere, Let Visibility=0 for each plane of the frustum view Let I be the intersection of the orthogonal projection of the center sphere on the plane. If I is in the frustum view, then I have the visibility.So Visibility=Visibility|(flag for the visibility of the chosen plane) Once I did it for the 6 plane, I have the visibility of the sphere. Is it a good point of start? David

2 1

Making changes to Wiki
by Vitaliy Margolen Nov. 13, 2008

Nov. 13, 2008

Whenever someone maks changes to wiki page please add comments indicating what was changed. Without comments it's the same as submitting patches without a description. Vitaliy.

1 0

Re: shdocvw: Correct tests
by Paul Vriens Nov. 13, 2008

Nov. 13, 2008

Alistair Leslie-Hughes wrote: > Hi, > Corrected module the test are corrected in. > > Changelog: > shdocvw: Correct tests > > Best Regards > Alistair Leslie-Hughes > So shouldn't this be changed as well: - ok(site == NULL, "inplace=%p, ezpected NULL\n", runnable); + ok(site == NULL, "inplace=%p, ezpected NULL\n", site); (should be "site=%p....." and the ezpected typo is still there). -- Cheers, Paul.

1 0

Re: mshtml: Correct tests
by Alistair Leslie-Hughes Nov. 13, 2008

Nov. 13, 2008

Ignore this. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:491BFA50.9050407(a)hotmail.com... > Hi, > > Changelog: > mshtml: Correct tests > > Best Regards > Alistair Leslie-Hughes > > > > -------------------------------------------------------------------------------- > From e6ba1638d427366350ab1b4269372479cd4a3476 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Thu, 13 Nov 2008 20:55:59 +1100 > Subject: [PATCH] Correct tests > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/shdocvw/tests/webbrowser.c | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/dlls/shdocvw/tests/webbrowser.c > b/dlls/shdocvw/tests/webbrowser.c > index 3aa4bdd..484efe2 100644 > --- a/dlls/shdocvw/tests/webbrowser.c > +++ b/dlls/shdocvw/tests/webbrowser.c > @@ -1988,31 +1988,31 @@ static void test_QueryInterface(IUnknown *unk) > > hres = IUnknown_QueryInterface(unk, &IID_IQuickActivate, (void**)&qa); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(qa == NULL, "qa=%p, ezpected NULL\n", qa); > + ok(qa == NULL, "qa=%p, expected NULL\n", qa); > > hres = IUnknown_QueryInterface(unk, &IID_IRunnableObject, > (void**)&runnable); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(runnable == NULL, "runnable=%p, ezpected NULL\n", runnable); > + ok(runnable == NULL, "runnable=%p, expected NULL\n", runnable); > > hres = IUnknown_QueryInterface(unk, &IID_IPerPropertyBrowsing, > (void**)&propbrowse); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", runnable); > + ok(propbrowse == NULL, "propbrowse=%p, expected NULL\n", propbrowse); > > hres = IUnknown_QueryInterface(unk, &IID_IOleCache, (void**)&cache); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(cache == NULL, "cache=%p, ezpected NULL\n", runnable); > + ok(cache == NULL, "cache=%p, expected NULL\n", cache); > > hres = IUnknown_QueryInterface(unk, &IID_IOleInPlaceSite, > (void**)&inplace); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(inplace == NULL, "inplace=%p, ezpected NULL\n", runnable); > + ok(inplace == NULL, "inplace=%p, expected NULL\n", inplace); > > hres = IUnknown_QueryInterface(unk, &IID_IObjectWithSite, > (void**)&site); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(site == NULL, "inplace=%p, ezpected NULL\n", runnable); > + ok(site == NULL, "inplace=%p, ezpected NULL\n", site); > > hres = IUnknown_QueryInterface(unk, &IID_IViewObjectEx, > (void**)&viewex); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(viewex == NULL, "viewex=%p, ezpected NULL\n", runnable); > + ok(viewex == NULL, "viewex=%p, expected NULL\n", viewex); > > } > > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Re: Patch to build \\HKLM\HARDWARE\DEVICEMAP\SERIALCOMM entries for COM ports
by A C Hurst Nov. 13, 2008

Nov. 13, 2008

Resending this as it didn't make the list (shef.ac.uk != sheffield.ac.uk) sorry Austin > > Follows example of create_scsi_entries() in oldconfig.c > > Addresses bug 11811 among others. > > docs at http://www.winehq.org/site/docs/wineusr-guide/misc-things-to-configure only mention > > lowercase names in dosdevices. > > Hopefully I'm not too far down the s**t list; only my 2nd wine patch, feedback very welcome. > > -/* create the hardware registry branch */ > -static void create_hardware_branch(void) > ... > +/* create the hardware registry branch */ > +void create_hardware_branch(void) > > Any particular reason you moved this? > > -- > -Austin > Yes, it started as: void convert_old_config(void) { <other stuff..> /* create some hardware keys (FIXME: should not be done here) */ create_hardware_branch(); } but create_hardware_branch() did all/only the scsi stuff. I renamed it create_scsi_branch and added my create_serialcomm_branch, then thought how should I call it? Could just as well be: void convert_old_config(void) { <other stuff..> /* create some hardware keys (FIXME: should not be done here) */ create_scsi_branch(); create_serialcomm_branch(); } Would this be better? Andy

1 0

Make Wine and the tests dpi aware
by Detlef Riekenberg Nov. 12, 2008

Nov. 12, 2008

Wine use some fixed values for calculating gui elements, and hopefully the current values are verified with tests. The tests works in Windows, but only with the default settings: 96 dpi ("Small Fonts" / "Kleine Schriften") and the default theme. It would be a good idea to run the tests also for different settings. A first step should be using 120 dpi (Large Fonts) on Windows, and fix the tests and our Implementation. (comctrl32 has lot's of issues). For Patchwatcher, it should be possible to require selectable tests to run on more than one Machine with different settings. That way patchwatcher can detect 96dpi vs. 120dpi problems. Other possible testing improvement include color-depth and screen size issues. -- By by ... Detlef

2 1

iTunes wine 1.1.8
by Adam Brown Nov. 12, 2008

Nov. 12, 2008

Hi all, I am having a little trouble with iTunes 8 in Wine 1.1.8. Everything works great except that I cannot enter the store to buy music; it crashes. Do I have to adjust a setting or install gecko maybe? Older versions of iTunes I have tried have the same problem. Any suggestions would be appreciated.

2 1

syncing ipod in itunes
by EA Durbin Nov. 12, 2008

Nov. 12, 2008

Has there been any progress lately on achieving this task in wine? What's the status?http://www.winehq.org/pipermail/wine-devel/2008-March/063095.html _________________________________________________________________ Get 5 GB of storage with Windows Live Hotmail. http://windowslive.com/Explore/Hotmail?ocid=TXT_TAGLM_WL_hotmail_acq_5gb_11…

2 2

Re: Patch to build \\HKLM\HARDWARE\DEVICEMAP\SERIALCOMM entries for COM ports
by Austin English Nov. 12, 2008

Nov. 12, 2008

On Wed, Nov 12, 2008 at 1:38 PM, A C Hurst <A.Hurst(a)sheffield.ac.uk> wrote: > Follows example of create_scsi_entries() in oldconfig.c > Addresses bug 11811 among others. > docs at http://www.winehq.org/site/docs/wineusr-guide/misc-things-to-configure only mention > lowercase names in dosdevices. > Hopefully I'm not too far down the s**t list; only my 2nd wine patch, feedback very welcome. > > > Andy > > > -/* create the hardware registry branch */ -static void create_hardware_branch(void) ... +/* create the hardware registry branch */ +void create_hardware_branch(void) Any particular reason you moved this? -- -Austin

2 1

Re: Wine and relocation on not aligned section
by Dan Kegel Nov. 12, 2008

Nov. 12, 2008

> while diving into wine sources i've noticed that wine does not apply > relocation to section not aligned to page boundary. > Is there any reason for this behaviour? > If it is wrong i've put up a little patch that solves the issue. Do you know of an application that needs this? Or can you write a conformance test that shows how Windows behaves in this situation? http://www.uninformed.org/?v=6&a=3&t=txt seems to imply it's not needed? - Dan

3 2

Re: [RESEND] Send page size to cups with lpr command on printing (bug 15942)
by Massimo Del Fedele Nov. 12, 2008

Nov. 12, 2008

Massimo Del Fedele ha scritto: > Print jobs are sent to CUPS without the page size, so they're cropped to > the default one (usually A4). > The patch solves it adding "-o PageSize=<pagesize>" to lpr command. > > Ciao > > Max > > > ------------------------------------------------------------------------ > > Is there something wrong with this one ? Max

5 8

RE: Patch for WineD3D to set Driver an Description
by Stefan Dösinger Nov. 12, 2008

Nov. 12, 2008

> PS: For Fallout 3 those registry settings should be (or similar): > "VideoDescription"="NVIDIA GeForce 9600 GT" > "VideoDriver"="nv4_disp.dll" We have a display driver database in wined3d that specifies the driver version to report. We could include this information there instead adding a new registry key. "nv4_disp.dll" obviously makes problems. Our display driver is called "winex11.drv", or arguably for d3d "wined3d.dll"

4 3

Re: Patch for WineD3D to set Driver an Description
by Roderick Colenbrander Nov. 12, 2008

Nov. 12, 2008

Perhaps the patch should enter Wine. I will do the full restructuring later. One thing which you should do is to set the strings to NULL in the wined3d_settings structure at the start of the file (line 37). Also put the new options right after the video memory one or even before for clarity. Roderick > Hi, but this patch shouldn't brake anything, because it will use wine > default driver name and description and if user want to change it then > he can in registry, same like amount of video memory. > > In the future we will not be able to exactly match driver name and > description in every situation, so I think this can be solution for some > bugs now, and later we can improve it with better driver detection, but > registry settings should be there even then. > > Mirek > > Roderick Colenbrander napsal(a): > >> 2008/11/7 Mirek Slugeň <thunder.m(a)email.cz>: > >>> Hi, Fallout 3 and maybe other games or D3D apps need such special > >> settings, > >>> this patch should be ok, it is well tested. > >>> > >>> This patch is not hack! > >>> > >>> New wine registry settings: > >>> VideoDriver > >>> VideoDescription > >>> > >>> Patch is for current (07.11.2008) git. > >>> > >>> PS: For Fallout 3 those registry settings should be (or similar): > >>> "VideoDescription"="NVIDIA GeForce 9600 GT" > >>> "VideoDriver"="nv4_disp.dll" > >>> > >>> Mirek Slugen > >>> > >> I think you should integrate this with the card detection in > >> IWineD3DImpl_FillGLCaps(), directx.c lines 1029-1330. Roderick might > >> be able to give some help wrt driver and description strings for > >> specific cards. > >> > > > > I would recommend you to hardcode values specific for your card at this > point in your own wined3d version. Right now we estimate all info at Wine > startup based on GL information. In case of cards which we don't know even > from other vendors we also report Nvidia. > > > > The physx/cuda libraries require proper nvidia information in wined3d > but this can't be solved properly at this point. We also need the proper pci > ids and amount of video memory among other things. I'm working on a > solution but this needs some changes in wine's display driver to return this info > from extensions like Nvidia's NV-CONTROL. In case of NV-CONTROL I have > requested some additional functionality and once that is there I will fix this > once and for all. Until then I would recommend using your private wined3d > patch as it can do more bad than good for most users. > > > > Roderick -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

1 0

Re: mlang: Implement IMultiLanguage2::ConvertStringInIStream.
by Hans Leidekker Nov. 12, 2008

Nov. 12, 2008

On Wednesday 12 November 2008 13:37:32 Hans Leidekker wrote: > This version converts the stream all at once. Hold on, I realize now that I can avoid an allocation. -Hans

1 0

Re: Patch for WineD3D to set Driver an Description
by Henri Verbeet Nov. 12, 2008

Nov. 12, 2008

2008/11/7 Mirek Slugeň <thunder.m(a)email.cz>: > Hi, Fallout 3 and maybe other games or D3D apps need such special settings, > this patch should be ok, it is well tested. > > This patch is not hack! > > New wine registry settings: > VideoDriver > VideoDescription > > Patch is for current (07.11.2008) git. > > PS: For Fallout 3 those registry settings should be (or similar): > "VideoDescription"="NVIDIA GeForce 9600 GT" > "VideoDriver"="nv4_disp.dll" > > Mirek Slugen > I think you should integrate this with the card detection in IWineD3DImpl_FillGLCaps(), directx.c lines 1029-1330. Roderick might be able to give some help wrt driver and description strings for specific cards.

3 2

Re: wined3d: fix a compiler warning (2/10)
by Henri Verbeet Nov. 12, 2008

Nov. 12, 2008

The fix is mostly correct (although obviously there's more wrong with that code), but please use a slightly more descriptive subject. "Fix a compiler warning" doesn't say a whole lot.

1 0

Re: winex11.drv: fix a compiler warning (4/10)
by Chris Robinson Nov. 11, 2008

Nov. 11, 2008

On Tuesday 11 November 2008 07:28:11 pm Austin English wrote: > - TRACE(output); > + TRACE(output, "%s"); I think you put this on backwards. Some of the other patches seem to be the same way. This gets rid of the warning because you add an extra parameter, which the compiler takes to mean that you know what you're doing. But if the input string contains an %code, it'll interpret the value incorrectly.

1 0

Compiler warnings in gcc 4.3.2
by Austin English Nov. 11, 2008

Nov. 11, 2008

I recently upgraded to intrepid, which has gcc 4.3.2. It gave a few new warnings, and I've got patches ready for all but this one. I started to write a patch to remove the check, since it's useless, but wasn't sure if it should instead be converted to a signed integer instead. austin(a)austin-desktop:~/wine-git/dlls/dnsapi$ make ccache gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -Werror -g -o ns_parse.o ns_parse.c cc1: warnings being treated as errors ns_parse.c: In function 'dns_ns_parserr': ns_parse.c:139: error: comparison of unsigned expression < 0 is always false make: *** [ns_parse.o] Error 1 Relevant code: int dns_ns_parserr(ns_msg *handle, ns_sect section, int rrnum, ns_rr *rr) { int b; /* Make section right. */ if (section < 0 || section >= ns_s_max) RETERR(ENODEV); -- -Austin

2 2

Re: Implements GradientFill /GdiGradientFill
by Austin English Nov. 11, 2008

Nov. 11, 2008

On Tue, Nov 11, 2008 at 2:22 PM, joirge <jorgebendezu(a)viabcp.com> wrote: > I need it to run a program to change frequencuies to a radiomodem > satelline . > Many Thanks > > > You forgot the patch. -- -Austin

1 0

Re: shdocvw: Correct test for non-existing interfaces
by James Hawkins Nov. 11, 2008

Nov. 11, 2008

On Tue, Nov 11, 2008 at 4:27 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > This add a test for the IViewObjectEx interface as well as correcting the > exiting tests. > > Changelog: > shdocvw: Correct test for non-existing interfaces > - ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", runnable); + ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", propbrowse); Might want to fix the other typos while you're at it: s/ezpected/expected/ -- James Hawkins

1 0