November 2008 - Wine-Devel - list.winehq.org

Re: [PATCH] advapi: Only allow opening HKEY_CLASSES_ROOT subkeys with backslash prefix on W2K+.
by Lei Zhang Nov. 25, 2008

Nov. 25, 2008

On Tue, Nov 25, 2008 at 11:35 AM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > Commit aacb511da1540fa015c5e853c90fd054b9442701 assumed NT+ behaved > the same way, but running the tests turns out it's actually W2K+. > Doh, that came out wrong. Ignore, sorry.

1 0

Re: RFC: Proposed new web site design
by chris ahrendt Nov. 25, 2008

Nov. 25, 2008

Austin English wrote: > On Tue, Nov 25, 2008 at 12:27 AM, Scott Ritchie <scott(a)open-vote.org> wrote: > >> We also don't really need a link to AppDB from the big buttons in the >> front - AppDB is only the place to go when you're looking for it (hence >> the button in the upper right) or once you know something about Wine >> (hence a link in the about page). >> >> > > I disagree. You could make the same argument against > bugzilla/forums/wiki. The frontpage should serve as a portal to the > rest of the site. Many times when I needs appdb/wiki, I go to > winehq.org and then click the appropriate link. > > I agree the main page should be the portal where you go to find everything... chris p.s. kudo's on the new design!

1 0

Fw: Re: RFC: Proposed new web site design
by James Mckenzie Nov. 25, 2008

Nov. 25, 2008

Sent to wrong mailing list. -----Forwarded Message----- >From: James Mckenzie <jjmckenzie51(a)earthlink.net> >Sent: Nov 25, 2008 9:01 AM >To: Wine Users Mailing List <wine-users(a)winehq.org> >Subject: Re: RFC: Proposed new web site design > >Daniel Scharrer <dscharrer(a)gmail.com> at Nov 25, 2008 8:50 AM (MST) wrote about Re: RFC: Proposed new web site design >> >>The new user-centric design looks promising. Contrary to some others I >>quite like the round corners and more modern look. Here are a few >>observations: >> >>- Light gray text on a white background is not so nice. > >This is very hard to read. I like a shade of Yellow on a Green background. White on Green is better. Easy on the eyes. White on Red is also good. > >>- I don't really like the icons too much: As others mentioned, a >>simple down arrow for the 'Download' icon might be better > >The use of the down arrow is intuitive as well. This may lead directly to an available download or download page. > >>The Development icon is really non-intuitive. Better alternatives would be >>gears or a wrench (or both). > >+1 for gears with wrench. > > >>- I think a big "Compatibility" link, as done in the re-layout, really >>belongs onto the front page. I'm guessing many users will want to know >>if their favorite app runs with wine before the download link even >>becomes relevant, both for users who are deciding weather to switch to >>Linux / Mac and those that just want to find out if there is any >>reason to upgrade from the Wine version that ships with their distro. > >I agree. A link to a Compatibility page should be on the Front Page where users can find it. The compatibility page should have categories rather than colors as well: >Runs with Wine unaltered >Runs with Wine with Windows DLLS >Partially Runs with Wine >Partially Runs with Wine with Windows DLLS >DOES NOT RUN WITH WINE (Yes, the bold is deliberate.) > >>+1 To the idea of getting screenshots back on the page, > >+1 to this as well. A small, clickable, screenshot of a running application does wonders. > >James McKenzie

1 0

Re: oleaut32: Add support for loading typelibs from NE files.
by Rob Shearman Nov. 25, 2008

Nov. 25, 2008

2008/11/25 Huw Davies <huw(a)codeweavers.com>: > --- > dlls/oleaut32/typelib.c | 218 +++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 218 insertions(+), 0 deletions(-) Looks good. Thanks for doing this. -- Rob Shearman

1 0

Re: RFC: Proposed new web site design
by Daniel Scharrer Nov. 25, 2008

Nov. 25, 2008

The new user-centric design looks promising. Contrary to some others I quite like the round corners and more modern look. Here are a few observations: - Light gray text on a white background is not so nice. - I thought it was called "Wine" and not "WINE" now. Shouldn't the "logo" at the top left reflect this? - I don't really like the icons too much: As others mentioned, a simple down arrow for the 'Download' icon might be better and the Development icon is really non-intuitive. Better alternatives would be gears or a wrench (or both). Also, I don't see a reason for them being buttons instead of just the icons over the background. Putting the icons into a box just detracts from the icons themselves, at least for me. Also, would it kill to user other colors than than those dictated by the theme for the icons? Compare this to http://www.openoffice.org/ which I'm guessing this design is based on. - I think a big "Compatibility" link, as done in the re-layout, really belongs onto the front page. I'm guessing many users will want to know if their favorite app runs with wine before the download link even becomes relevant, both for users who are deciding weather to switch to Linux / Mac and those that just want to find out if there is any reason to upgrade from the Wine version that ships with their distro. - As many others, I also despise secondary scroll bars. Right now the news content shows way too much redundancy: The "Latest Releases" box, the title of the latest news entry as well as it's first sentence all just say "The latest Wine version is 1.1.8" and they are right next to each other. Is there some way to combine this? How about just: Latest stable release (links to release page) Latest release (also links to it's own release page) Release date. Major changes. 1/2 Non-release news items (WWN,...) Also, even when resizing the browser window to the point where a horizontal scroll bar appears there is still quite a bit of white space in the center, yet the news box has a small fixed width that forces line breaks in the release change summary bullet points. +1 To the idea of getting screenshots back on the page, it's surprising how much a little eye candy can do.They should however be more up to date (perhaps automatically linked from platinum apps on the AppDB) and as was suggested link back to the relevant AppDB entry. Regards, Daniel Scharrer

1 0

Internet Explorer running in Wine usefull for performance testing
by Joris Huizer Nov. 25, 2008

Nov. 25, 2008

Hello, Just as Dan Kegel likes to announce on the list, how Wine gets mentioned out on the internet, I thought this may be interesting/motivating to you. This page, http://ejohn.org/blog/accuracy-of-javascript-time/, mentions (big) problems in testing javascript performances (there's some interest in that in the new race between webbrowsers), when running IE (and other browsers) on Windows, which are fixed when running it under Wine (in this case on a Mac) Regards, Joris

1 0

Windows mobile and ARM
by Scott Ritchie Nov. 25, 2008

Nov. 25, 2008

Is it at all feasible to run Windows mobile apps under Wine? From what I understand it's supposed to be largely the same API as standard Win32. How about a port to ARM for the purpose of running Windows Mobile apps, or just recompiled Winelib apps? Ubuntu is getting serious about its ARM port, so if Wine/ARM becomes a reality within the next, say, 2 years the potential for quickly developing mobile applications by just porting Windows ones is huge. Theoretically, we could run Windows applications on a jailbroken iPhone. Thanks, Scott Ritchie

4 3

Bugs not linked to appdb
by Dan Kegel Nov. 25, 2008

Nov. 25, 2008

Somebody asked if there was a way to find out which bugs were not yet linked into the appdb. There ought to be, but I don't know of one, so I ran the report the hard way last night. It's at http://kegel.com/wine/unlinked.html - Dan

1 0

Re: Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."
by Jacek Caban Nov. 25, 2008

Nov. 25, 2008

Vitaliy Margolen wrote: > Since Jacek did not comment on the bug 14311, revert patch in question. It > restores 100% functionality of the scrollbars in Steam. > The fact that I didn't comment doesn't mean anything. I didn't have time to work on it and I'm currently looking at it (BTW, with today git other Steam bug is fixed). I know that it doesn't make any difference for user, but from technical point of view, there was no regression. Steam draws its own scrollbars and doesn't use built-in MSHTML scrollbars. Previously there were two bugs: - MSHTML scrollbars were not hidden - Steam scrollbars didn't work The patch that you want to revert (with fixes apps like CS3 installer) fixed the first problem. Now the second one needs to be fixed. Jacek

3 2

Re: [6/6] gdiplus: implement GdipGetRegionHRgn for combined regions
by Vincent Povirk Nov. 25, 2008

Nov. 25, 2008

I leaked a region in this last one. Please don't apply it. Vincent Povirk On Mon, Nov 24, 2008 at 5:34 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > >

1 0

Re: mshtml: Add new interfaces into mshtml.idl (try 2)
by Alistair Leslie-Hughes Nov. 24, 2008

Nov. 24, 2008

Hi Konstantin, > Kondratyuk wrote: > Hello! > > Try 2 changes: > - add missed POINTER_GRAVITY_Max, MARKUP_CONTEXT_TYPE_Max, SELECTION_TYPE_Max > constants > - correct attributes of interfaces: object, pointer_default(unique), uuid(...) > - correct attributes Right and Left methods in IMarkupPointer interface > Non of the Functions in IMarkupPointer should be marked as retval, likewise for IMarkupContainer. IElementSegment functions are in the wrong order, likewise for ISelectionServicesListener, ISelectionServices and IHTMLEditServices. Also you will need to double check the [] values, since you have retval where they are not needed. If you have a copy of the mshtml.tlb you can verify the interfaces by using wine's oleview program. Best Regards Alistair Leslie-Hughes

2 2

adding DEVICEMAP\HARDWARE registry entries
by A C Hurst Nov. 24, 2008

Nov. 24, 2008

Dear winehackers, I sent this patch to wine-patches, with a few iterations of editing, and wondered if I could have some feedback on it, before I just resend it. Andy

3 4

Re: Revert "mshtml: Added support for DOCHOSTUIFLAG_SCROLL_NO DOCHOSTINFO flag."
by Reece Dunn Nov. 24, 2008

Nov. 24, 2008

2008/11/24 Vitaliy Margolen <wine-patches(a)kievinfo.com>: > Since Jacek did not comment on the bug 14311, revert patch in question. It > restores 100% functionality of the scrollbars in Steam. This is not the correct fix. Simply reverting a patch because it broke an application without understanding why is not the right way to go. In this case, some applications (http://bugs.winehq.org/show_bug.cgi?id=13459) specify the DOCHOSTUIFLAG_SCROLL_NO flag to specifically not show any scrollbars. In the case of bug 13459, the intro page does not render correctly if scrollbars are shown (and on Windows you don't see any scrollbars). What is the behaviour on Windows? Can you explain comments 3 and 8? - Reece

2 1

Good news regarding Wine and patent threats
by Scott Ritchie Nov. 24, 2008

Nov. 24, 2008

There's a groklaw article summarizing recent discussion about the impact of the Bilski case on software patents: http://www.groklaw.net/article.php?story=20081102011538422 "The judge says this kind of cloning could be done without infringing Microsoft's copyrights, but how about its patents? Prior to Bilski, one might give one answer. Now, one might give another." If we thought Wine unlikely to be attacked by Microsoft due to nebulous patent issues and anti-trust implications, it's even less likely now. Thanks, Scott Ritchie

1 0

Spaces before '...' in Slovenian
by Francois Gouget Nov. 24, 2008

Nov. 24, 2008

Does anyone (especially Rok Mandeljc) know if, in Slovenian: 1) '...' must be preceded by a space 2) '...' must not be preceded by a space 3) either form is valid -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Any sufficiently advanced bug is indistinguishable from a feature. -- from some indian guy

2 1

Re: adding DEVICEMAP\HARDWARE registry entries
by A C Hurst Nov. 24, 2008

Nov. 24, 2008

> > The code in oldconfig.c is called by process.c/__wine_kernel_init(), on server startup. > > The entries are volatile, and are dynamically created if you count scanning > wineprefix/dosdevices/ > > and doing a stat() on anything named com[1-9] it finds there every time wine starts up. > > I could just call get_dos_device and let it do the stat calls, but it would be less efficient, > and > > you'd end up with registry entries for the successes of get_default_com_device, not just the > ones > > symlinked in dosdevices > > You don't want to depend on the symlinks, things should work without > requiring the user to create any symlink. It should depend on what > actual devices are present on the machine, and probably be done > somewhere in the HAL support. Would using get_dos_device() be better, since that does fall through to default behaviour when the symlink isn't there? I chose oldconfig.c since that's where the \DEVICEMAP\Scsi entries get built. Would the scsi stuff want moving over to HAL too?

2 1

Re: atl: Remove WINAPI on static functions where not needed.
by Chris Robinson Nov. 24, 2008

Nov. 24, 2008

On Sunday 23 November 2008 03:15:36 pm Francois Gouget wrote: > To quote Ken Thomases who did the research on this issue with Alexandre: > > This is motivated by a gcc bug that we've encountered on the Mac. On > the Mac, WINAPI (and other declspecs) include the > force_align_arg_pointer attribute. With -O2 optimization (actually > -funit-at-a-time, implied by -O2) the compiler may change the calling > convention used by non-exported functions to take arguments via > registers rather than on the stack. The prologue generated for > force_align_arg_pointer clobbers one of those registers (and hence > one of the arguments). > > Alexandre's preferred solution is to find and eliminate such cases. > Even if/when the compiler bug is fixed, those functions should still > not have the extraneous declspec. Out of curiousity, then, does this affect static functions that are used for COM objects? It's typical for those to be marked as static, their address put into a (possibly static) vtable struct, which is then used as a field for an allocated struct passed to the user.

2 1

Re: d3d9: Remove WINAPI on static functions where not needed.
by Vitaliy Margolen Nov. 24, 2008

Nov. 24, 2008

Francois Gouget wrote: > --- > > If you know other places where the functions touched by this patch > are used, please let me know. For more details, see: > > /* This isn't in MSDN! > -static HRESULT WINAPI IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) { > +static HRESULT IDirect3DDevice9Impl_GetFrontBuffer(LPDIRECT3DDEVICE9EX iface, IDirect3DSurface9* pDestSurface) { > IDirect3DDevice9Impl *This = (IDirect3DDevice9Impl *)iface; > FIXME("(%p) : stub\n", This); > return D3D_OK; You can't do that. It's part of the v-table so it can be called by user application. Vitaliy

3 2

FAQ change wrt FontForge
by Francois Gouget Nov. 24, 2008

Nov. 24, 2008

On Thu, 13 Nov 2008, Wine Wiki wrote: [...] > - Unless you plan to work on the TrueType fonts you don't need > FontForge. If you do, then be aware that the FontForge packages from > Breezy and Dapper are a bit out of date. The fonts generated by most > versions of FontForge will not pass the gdi32/tests/fonts.c tests. > + Be aware that the FontForge packages from Breezy and Dapper are a > bit out of date. The fonts generated by most versions of FontForge > will not pass the gdi32/tests/fonts.c tests. [...] > - Note that, unless you are tracking Git and know what you are doing, > you SHOULDN'T have valgrind. Also, unless you plan to work on the > TrueType fonts you don't need FontForge. > + Note that, unless you are tracking Git and know what you are doing, > you SHOULDN'T have valgrind. [...] > - Unless you plan to work on the TrueType fonts you don't need FontForge. [...] > - * The following, but ''only'' if you plan to work on the TrueType > fonts, and can install them from ''testing'' - '''do not''' install > these from ''Sarge'': > + * '''Do not''' install these from ''Sarge'': > * fontforge/testing I think these changes are wrong. As far as I know the TrueType fonts are checked into Git so one does not need to have FontForge to build Wine. Or has this changed? Or is FontForge needed to build another type of fonts? -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Nouvelle version : les anciens bogues ont été remplacés par de nouveaux.

4 5

Re: mshtml: Add new interfaces into mshtml.idl
by Alistair Leslie-Hughes Nov. 24, 2008

Nov. 24, 2008

Hi Konstantin, "Konstantin Kondratyuk" <kondratyuk(a)etersoft.ru> wrote in message news:200811232011.33101.kondratyuk(a)etersoft.ru...> I'm sorry, I have sent a wrong patch...> > -- > Best regards,> Konstantin Kondratyuk.> You have missed POINTER_GRAVITY_Max MARKUP_CONTEXT_TYPE_Max SELECTION_TYPE_Max The following interfacess dont contain dual interfaces IHTMLEditDesigner IMarkupContainer IMarkupPointer ISegment ISelectionServicesListener ISelectionServices IHTMLEditServices Best Regards Alistair Leslie-Hughes _________________________________________________________________ Take a summer road trip with Windows Live Hotmail. Multiple prizes and the ultimate dream beach house! http://www.ninemsn.com.au/hotmailroadtrip

2 2

Why do we bother with DllCanUnloadNow?
by Mike Hearn Nov. 24, 2008

Nov. 24, 2008

Is there a specific reason for implementing this function anymore? The resource savings don't seem worth the new potential for bugs. If all of them were simply returning FALSE then what would be the loss? thanks -mike

1 0

Another happy user
by Dan Kegel Nov. 24, 2008

Nov. 24, 2008

http://blog.lokonopa.com/sorry-microsoft/ has a nice quote: "Come to think of it, I don't recall the last piece of software that won't install properly with Wine."

1 0

Compiler keyword
by Austin English Nov. 24, 2008

Nov. 24, 2008

Howdy, Wanted to keep the discussion separate from the OS thread. Would anyone be opposed to a compiler keyword being added? There have been -- -Austin

2 2

re: Bugzilla - Add keyword and remove OS's
by Dan Kegel Nov. 24, 2008

Nov. 24, 2008

Austin wrote: > The OS list in bugzilla is a bit excessive. There are 16 OS's that I > think we should remove... I think we should keep most of them, but classic Mac OS (pre-X) can go, as we never worked there (not even Darwine), and nobody cares about it anymore. I've deleted Mac System 7, and will delete the rest of the classic mac OS's if there is consensus.

2 3

Accounts in bugzilla and e-mail addresses used to submit patches
by Vitaliy Margolen Nov. 23, 2008

Nov. 23, 2008

Can please everyone make sure that their e-mail in bugzilla matches the e-mail they use to submit patches? Or at least make it easily guessable. Or can we have all developers create page on Wiki and state their e-mails they use on bugazilla? The reason I'm asking is the standard procedure for a regression testing is to add author of the patch to CC. However sometimes it's impossible to do. As example this commit that introduced regression (bug 16165): e4f7809cc9969c693d910348315502892848aaf9 is first bad commit commit e4f7809cc9969c693d910348315502892848aaf9 Author: Hans Leidekker <hans(a)codeweavers.com> Date: Thu Nov 20 14:50:58 2008 +0100 winhttp: Prefer builtin over native. Out of 2 e-mail address (the one used to submit patch and the one used to send messages to wine-devel) neither present in bugzilla. Vitaliy.

5 6

Re: jscript: Implement the String.toLowerCase() method.
by Jacek Caban Nov. 23, 2008

Nov. 23, 2008

Hi Andrew, Andrew Nguyen wrote: > This is an attempt to implement the String.toLowerCase method. The > added jscript tests pass on Windows XP. > --- > dlls/jscript/string.c | 41 +++++++++++++++++++++++++++++++++++++++-- > dlls/jscript/tests/api.js | 11 +++++++++++ > 2 files changed, 50 insertions(+), 2 deletions(-) > > > + res = heap_alloc((length+1)*sizeof(WCHAR)); > + if (!res) > + return E_OUTOFMEMORY; You can avoid this allocation by using SysAllocStringLen. Jacek

1 0

Re: msxml3: Implement IXMLDOMAttribute get/put value
by Alistair Leslie-Hughes Nov. 23, 2008

Nov. 23, 2008

Ignore this patch. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:49269ECA.7070202(a)hotmail.com... > Hi, > > Changelog: > msxml3: Implement IXMLDOMAttribute get/put value > > Best Regards > Alistair Leslie-Hughes > > > -------------------------------------------------------------------------------- > From 485959eb359d1efdf66c4be1aa110ba47877847c Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Fri, 21 Nov 2008 21:36:30 +1100 > Subject: [PATCH] Implement IXMLDOMAttribute get/put value > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/msxml3/attribute.c | 8 ++++---- > dlls/msxml3/node.c | 21 +++++++++++++++------ > dlls/msxml3/tests/domdoc.c | 30 ++++++++++++++++++++++++++++++ > 3 files changed, 49 insertions(+), 10 deletions(-) > > diff --git a/dlls/msxml3/attribute.c b/dlls/msxml3/attribute.c > index 2681a76..92cafad 100644 > --- a/dlls/msxml3/attribute.c > +++ b/dlls/msxml3/attribute.c > @@ -482,16 +482,16 @@ static HRESULT WINAPI domattr_get_value( > IXMLDOMAttribute *iface, > VARIANT *var1) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domattr *This = impl_from_IXMLDOMAttribute( iface ); > + return IXMLDOMNode_get_nodeValue( This->node, var1 ); > } > > static HRESULT WINAPI domattr_put_value( > IXMLDOMAttribute *iface, > VARIANT var1) > { > - FIXME("\n"); > - return E_NOTIMPL; > + domattr *This = impl_from_IXMLDOMAttribute( iface ); > + return IXMLDOMNode_put_nodeValue( This->node, var1 ); > } > > static const struct IXMLDOMAttributeVtbl domattr_vtbl = > diff --git a/dlls/msxml3/node.c b/dlls/msxml3/node.c > index 19cee8f..6693803 100644 > --- a/dlls/msxml3/node.c > +++ b/dlls/msxml3/node.c > @@ -339,13 +339,22 @@ static HRESULT WINAPI xmlnode_put_nodeValue( > > TRACE("%p type(%d)\n", This, This->node->type); > > - VariantInit(&string_value); > - hr = VariantChangeType(&string_value, &value, 0, VT_BSTR); > - if(FAILED(hr)) > + /* Attribute nodes treat NULL Variants as empty strings. */ > + if(V_VT(&value) == VT_NULL && This->node->type == XML_ATTRIBUTE_NODE) > { > - VariantClear(&string_value); > - WARN("Couldn't convert to VT_BSTR\n"); > - return hr; > + V_VT(&string_value) = VT_BSTR; > + V_BSTR(&string_value) = SysAllocStringLen(NULL, 0); > + } > + else > + { > + VariantInit(&string_value); > + hr = VariantChangeType(&string_value, &value, 0, VT_BSTR); > + if(FAILED(hr)) > + { > + VariantClear(&string_value); > + WARN("Couldn't convert to VT_BSTR\n"); > + return hr; > + } > } > > hr = S_FALSE; > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index e27c506..c975d73 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -2796,12 +2796,18 @@ static void test_xmlTypes(void) > ok( V_VT(&v) == VT_NULL, "incorrect dataType type\n"); > VariantClear(&v); > > + V_VT(&v) = VT_NULL; > + V_I4(&v) = 0; > + hr = IXMLDOMElement_put_nodeValue(pElement, v); > + ok(hr == DISP_E_TYPEMISMATCH, "ret %08x\n", hr ); > + > /* Attribute */ > hr = IXMLDOMDocument_createAttribute(doc, szAttribute, > &pAttrubute); > ok(hr == S_OK, "ret %08x\n", hr ); > if(hr == S_OK) > { > IXMLDOMNode *pNewChild = (IXMLDOMNode *)0x1; > + IXMLDOMNode *pAttrNode = NULL; > > hr = IXMLDOMAttribute_get_nextSibling(pAttrubute, > NULL); > ok(hr == E_INVALIDARG, "ret %08x\n", hr ); > @@ -2876,6 +2882,30 @@ static void test_xmlTypes(void) > ok( V_VT(&v) == VT_NULL, "incorrect dataType type\n"); > VariantClear(&v); > > + /* test value */ > + V_VT(&v) = VT_NULL; > + VariantClear(&v); > + hr = IXMLDOMAttribute_put_value(pAttrubute, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + VariantClear(&v); > + > + hr = IXMLDOMAttribute_get_value(pAttrubute, &v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + ok( !lstrcmpW( V_BSTR(&v), _bstr_("") ), "incorrect > get_value string\n"); > + VariantClear(&v); > + > + IXMLDOMAttribute_QueryInterface(pAttrubute, > &IID_IXMLDOMNode, (LPVOID*)&pAttrNode); > + if(hr == S_OK) > + { > + V_VT(&v) = VT_NULL; > + VariantClear(&v); > + hr = IXMLDOMNode_put_nodeValue(pAttrNode, v); > + ok(hr == S_OK, "ret %08x\n", hr ); > + VariantClear(&v); > + > + IXMLDOMNode_Release(pAttrNode); > + } > + > IXMLDOMAttribute_Release(pAttrubute); > > /* Check Element again with the Add Attribute*/ > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

re: How do I create a backtrace?
by Dan Kegel Nov. 23, 2008

Nov. 23, 2008

The FAQ covers this: http://wiki.winehq.org/FAQ#head-16da35b6327024d6ea576e3678488b16862d0f5e

1 0

How do I create a backtrace?
by Matt Perry Nov. 22, 2008

Nov. 22, 2008

I've been asked by a Wine developer to provide a backtrace along with a "+relay,+seh" log for a bug that I have filed. I've read through the developer documentation but I can't figure out how to do this. I sent an email to the developer with a request for instructions but have not received a reply. Could someone here instruct me on how to do this? I'm a non-programmer so please take that into consideration with regards to your instructions. Thanks. Matt

2 1

Re: Wine release 1.1.9
by Francois Gouget Nov. 22, 2008

Nov. 22, 2008

On Fri, 21 Nov 2008, Alexandre Julliard wrote: > The Wine development release 1.1.9 is now available. > > What's new in this release (see below for details): > - A large number of regression test fixes. <nitpick> Actually it's not regression tests, and it's not regression fixes. It's conformance tests, their main goal is to describe the Windows behavior, so that we can then know whether Wine _conforms_ to that behavior or not. And all (or almost all) of the fixes are so that the tests actually describe the Windows behavior. </nitpick> -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ I haven't lost my mind, it's backed up on tape around here somewhere...

3 3

Regarding ./configure file
by shanmukha sainath addepalli Nov. 22, 2008

Nov. 22, 2008

Sir/Madam, I need to add few functions related to libwnck. It requires some header files to be included. I included them in wine source code. But when compiled it says header files not found. I haven't updated configure file. How can i update it? please tell me what r the changes that i need to made? Regards, Sainath.

7 6

LPD3DXMESH
by Krzysztof Drewniak Nov. 22, 2008

Nov. 22, 2008

What header is LPD3DXMESH supposed to be declared in? Krzys D.

5 4

[RFC/RFH] winmm:wave hang fix question (commit 717df5b2972b3cb998ca5a43279ae2283b117eaa) [bug 15559]
by Reece Dunn Nov. 21, 2008

Nov. 21, 2008

Hi, Looking at the history of that test (http://test.winehq.org/data/tests/winmm:wave.html) I see a lot of timeout errors on the Wine builds, even after this fix went in. The fix itself has caused a regression of playback in many applications and games that play audio (http://bugs.winehq.org/show_bug.cgi?id=15559) I want to submit the following patch to revert the part of the patch that caused the regression and fix some of the tracing. I have been using this patch on Cepstral SwiftTalker without issue and have tested it also with the game Azguard Defense. I am submitting this here and not to wine-patches initially, as I would like to understand what the fix was actually fixing and (based on the test history still showing timeouts) whether it actually fixes the issue it was trying to. diff --git a/dlls/winealsa.drv/waveout.c b/dlls/winealsa.drv/waveout.c index 6cb2da8..b3f52aa 100644 --- a/dlls/winealsa.drv/waveout.c +++ b/dlls/winealsa.drv/waveout.c @@ -103,14 +103,19 @@ static BOOL wodUpdatePlayedTotal(WINE_WAVEDEV* wwo, snd_pcm_status_t* ps) state = snd_pcm_state(wwo->pcm); snd_pcm_delay(wwo->pcm, &delay); + if (state != SND_PCM_STATE_RUNNING && state != SND_PCM_STATE_PREPARED) + { + WARN("Unexpected state (%d) while updating Total Played, resetting\n", state); + delay=0; + } + /* A delay < 0 indicates an underrun; for our purposes that's 0. */ if (delay < 0) { - WARN("Unexpected state (%d) or delay (%ld) while updating Total Played, resetting\n", state, delay); + WARN("Unexpected delay (%ld) while updating Total Played, resetting\n", delay); delay=0; } - if (state == SND_PCM_STATE_XRUN) - snd_pcm_start(wwo->pcm); + InterlockedExchange((LONG*)&wwo->dwPlayedTotal, wwo->dwWrittenTotal - snd_pcm_frames_to_bytes(wwo->pcm, delay)); return TRUE; } - Reece

2 2

Re: urlmon #6: Added more policy tests.
by Paul Vriens Nov. 21, 2008

Nov. 21, 2008

Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 78 > +++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 77 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi Jacek, I'm checking out a test failure on a fresh and clean W2K3 box with SP2 and IE6. Right after this (line 859): + policy = 0xdeadbeef; + hres = IInternetZoneManager_GetZoneActionPolicy(zonemgr, 3, action, (BYTE*)&policy, + sizeof(DWORD), URLZONEREG_DEFAULT); I get a popup asking if I want to add www.winehq.org to the "Trusted sites zone". If I don't add this site the test succeeds. If I add it the test fails (over and over again). I didn't change any of the default IE6 (W2K3 specific?) security settings. I do see that adding this site to that zone doesn't change the content of the checked registry key but instead a new one is created: HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ZoneMap\EscDomains\winehq.org and HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Internet Settings\ZoneMap\EscDomains\winehq.org\www with a 'http' REG_DWORD (value = 2) underneath that last one. So how should we proceed fixing/changing this test? -- Cheers, Paul.

2 1

Re: [4/5] wined3d: Use IDL to generate wined3d_interface.h.
by Rob Shearman Nov. 21, 2008

Nov. 21, 2008

2008/11/21 Henri Verbeet <hverbeet(a)codeweavers.com>: > +cpp_quote("#if 0") > +import "wined3d_types.idl"; > +import "wined3d_caps.idl"; ... > +cpp_quote("#endif") > + > +cpp_quote("#include \"wine/wined3d_types.h\"") > +cpp_quote("#include \"wine/wined3d_caps.h\"") You can't do this. It won't work in MIDL and it won't work in widl when it is fixed to put the includes for imported files at the start of the generated header file, rather than in between the statements generated from neighbouring IDL statements. You need to find another way of solving the issue you are facing. -- Rob Shearman

2 1

Re: [3/5] wined3d: Use IDL to generate wined3d_caps.h.
by Rob Shearman Nov. 21, 2008

Nov. 21, 2008

2008/11/21 Henri Verbeet <hverbeet(a)codeweavers.com>: > +cpp_quote("#if 0") > +import "wined3d_types.idl"; > +cpp_quote("#endif") This won't work either, for the same reason as I mentioned for the 4/5 patch. -- Rob Shearman

1 0

re: Add wtmpnam to msvcrt.dll
by Dan Kegel Nov. 21, 2008

Nov. 21, 2008

Hi Tim, welcome to Wine! > A diff (relative to wine-1.1.8/dlls/msvcrt/file.c) is attached. Whoops, you attached the undiffed file! > I did not even get as far as successfully building it to test it Ah. Such patches usually get attached to bug reports in bugzilla or sent to wine-devel. wine-patches is for tested and known working patches. > I'd be happy to do a test build (assuming I can successfully > install the dependencies) That should be easy, see http://wiki.winehq.org/Recommended_Packages > if MSVCRT_tmpname gets initialized, where does that occur? It gets initialized by tmpnam(). Presumably _wtmpnam() will need its own static buffer. Also, please be sure to write a conformance test (see http://www.winehq.org/site/docs/winedev-guide/testing ) for your change! Thanks, Dan p.s. The MSDN doc for this, FWIW, is at http://msdn.microsoft.com/en-us/library/hs3e7355(VS.80).aspx

1 0

dead stores in advapi32
by ricardo filipe Nov. 21, 2008

Nov. 21, 2008

hi rob. i have some dead stores in advapi32 files that i would like to clarify. first, what do you want to do on lines 173 and 194 of cred.c? now, there are also 3 dead assignments in cred.c, lines 992, 199 and 1064. i didn't understand what you meant in your last email about my patch that removed dead code in ole32, so since this is dead code i think i can remove it, but i'm not sure anymore since you confused me. regards, ricardo _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

2 1

Disable regression tests option now available in git!
by Austin English Nov. 21, 2008

Nov. 21, 2008

For those of you that don't monitor wine-commit, Alexandre committed a patch today to disable building the regression tests: http://source.winehq.org/git/wine.git/?a=commitdiff;h=35078f4b57523d4afe00d… So the manual PITA patching is no longer necessary. I've updated the Regression Testing wiki page as well. Thanks Alexandre! -- -Austin

1 0

Re: dlls/ole32: check some dead store results (llvm/clang)
by Michael Karcher Nov. 20, 2008

Nov. 20, 2008

Am Donnerstag, den 20.11.2008, 18:36 +0000 schrieb ricardo filipe: | - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { | + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey) == ERROR_SUCCESS) { No. This inverts the logic of the tests. if(x) means if(x != 0). And ERROR_SUCCESS is just zero. To prevent just this possible mistake, a patch making the condition obvious was requested. Regards, Michael Karcher

1 0

Fedora 9 and MingW
by Paul Vriens Nov. 20, 2008

Nov. 20, 2008

Hi, I was still using the rpm's that Hans provided in the past. Some searching shows: https://fcp.surfsite.org/modules/newbb/viewtopic.php?topic_id=61801&forum=11 I've installed these rpm's but the executables use a different naming convention: i686-pc-mingw32* instead of what we check for: i686-mingw32*. Should we add this to our configure? -- Cheers, Paul.

3 2

Re: cryptdlg: Implement FormatVerisignExtension (take 2)
by Alexandre Julliard Nov. 20, 2008

Nov. 20, 2008

"Juan Lang" <juan.lang(a)gmail.com> writes: > + LPWSTR verisign_statement; > + DWORD bytesNeeded; > + > + LoadStringW(hInstance, IDS_VERISIGN_STATEMENT, > + (LPWSTR)&verisign_statement, 0); > + bytesNeeded = (strlenW(verisign_statement) + 1) * sizeof(WCHAR); You can't use strlenW here, the string is not null-terminated. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: shdocvw/tests: Make the webbrowser test dpi aware, make is pass in wine
by Paul Vriens Nov. 20, 2008

Nov. 20, 2008

Detlef Riekenberg wrote: > I set every dpi between 72 and 100 on Windows, wrote down the results > and > multiplied the results with the dpi value. > The formula ist the best guess. > Works on win98, w2k, Wine > Hi Detlef, This one introduces some extra failures now. If I look at the comment in your patch it says: /* The default size is dpi dependent (96:1323x529 / 120:1058x423) */ and if I look at some of the results on test.winehq.org: webbrowser.c:1840: Test failed: size = {1323 529} (expected 1322 529) This suggests that the calculation in the ok() should be rounded up? Or maybe deal with both situations? -- Cheers, Paul.

1 0

Re: dlls/rpcrt4: fixed dead increments (llvm/clang)
by Rob Shearman Nov. 19, 2008

Nov. 19, 2008

2008/11/18 ricardo filipe <ricardo_barbano(a)hotmail.com>: > diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c > index 3d66740..815ed64 100644 > --- a/dlls/rpcrt4/rpc_transport.c > +++ b/dlls/rpcrt4/rpc_transport.c > @@ -479,7 +479,6 @@ static size_t rpcrt4_ncacn_np_get_top_of_tower(unsigned char *tower_data, > memcpy(tower_data, networkaddr, networkaddr_size); > else > tower_data[0] = 0; > - tower_data += networkaddr_size; > > return size; > } > @@ -692,7 +691,6 @@ static size_t rpcrt4_ncalrpc_get_top_of_tower(unsigned char *tower_data, > pipe_floor->count_rhs = endpoint_size; > > memcpy(tower_data, endpoint, endpoint_size); > - tower_data += endpoint_size; > > return size; > } These increments are intentional in case the code is copy and pasted and some more data is added to the end, so please don't remove them. -- Rob Shearman

2 1

Re: dlls/ole32: fixed dead assignments (llvm/clang)
by Rob Shearman Nov. 19, 2008

Nov. 19, 2008

2008/11/18 ricardo filipe <ricardo_barbano(a)hotmail.com>: > @@ -1951,6 +1951,12 @@ HRESULT WINAPI CoRegisterClassObject( > newClass->pMarshaledData, > flags & (REGCLS_MULTIPLEUSE|REGCLS_MULTI_SEPARATE), > &newClass->RpcRegistration); > + MSHLFLAGS_TABLESTRONG); This won't compile. > + if (hr) { > + FIXME("RPC_StartLocalServer failed, %x!\n",hr); You should change this to: ERR("RPC_StartLocalServer failed with error 0x%x\n",hr); > + return hr; > + } > + > } > return S_OK; > } > diff --git a/dlls/ole32/ole16.c b/dlls/ole32/ole16.c > index a8fa59b..21fb1fb 100644 > --- a/dlls/ole32/ole16.c > +++ b/dlls/ole32/ole16.c > @@ -598,13 +598,13 @@ HRESULT WINAPI CLSIDFromProgID16(LPCOLESTR16 progid, LPCLSID riid) > > buf = HeapAlloc(GetProcessHeap(),0,strlen(progid)+8); > sprintf(buf,"%s\\CLSID",progid); > - if ((err=RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey))) { > + if (RegOpenKeyA(HKEY_CLASSES_ROOT,buf,&xhkey)) { Since you are changing this anyway, you should explicitly compare the result against ERROR_SUCCESS to improve readability of the code here. > HeapFree(GetProcessHeap(),0,buf); > return CO_E_CLASSSTRING; > } > HeapFree(GetProcessHeap(),0,buf); > buf2len = sizeof(buf2); > - if ((err=RegQueryValueA(xhkey,NULL,buf2,&buf2len))) { > + if (RegQueryValueA(xhkey,NULL,buf2,&buf2len)) { Ditto. > RegCloseKey(xhkey); > return CO_E_CLASSSTRING; > } -- Rob Shearman

1 0

spec file syntax for VARIANT parameter
by Jeremy Drake Nov. 19, 2008

Nov. 19, 2008

In order to implement OleLoadPictureFile and OleLoadPictureFileEx, it will be necessary to change their entries in oleaut32.spec from stub to stdcall. The stdcall syntax wants a list of parameter types, which puts these functions in an unususal situation: they take a VARIANT (which is a struct, in case anyone is not familiar) by value as their first parameter. There does not seem to be any type defined in the spec file that fits this situation. I have been using ptr in my last couple of patches which add stub implementations for these functions, but when I tried to build this on cygwin I got errors like: undefined reference to `_OleLoadPictureFileEx(a)20' undefined reference to `_OleLoadPictureFile(a)8' Looking at the functions that are present in the .o file, I see they are really _OleLoadPictureFileEx(a)32 and _OleLoadPictureFile(a)20. Changing the spec file to list each VARIANT as 4 longs fixes these errors. My question is, should my next version of the patch list the VARIANT as 4 longs, or is there some better way to specify this that I'm not aware of? If not, is there a comment syntax for the spec file where I can explain why there are 4 long params where there should be one VARIANT? Thanks Jeremy

2 1

Re: dlls/msxml3: check some dead store results (llvm/clang)
by Paul Vriens Nov. 19, 2008

Nov. 19, 2008

ricardo filipe wrote: > only return value checking in this patch. > > _________________________________________________________________ > Confira vídeos com notícias do NY Times, gols direto do Lance, videocassetadas e muito mais no MSN Video! > http://video.msn.com/?mkt=pt-br > > > ------------------------------------------------------------------------ > > You are mixing tabs and spaces. -- Cheers, Paul.

1 0

RE: netapi32: Actually return a couple of return values.
by ricardo filipe Nov. 19, 2008

Nov. 19, 2008

it seems you two fixed the same, juan sent a patch in a previous wine-devel email. you might want to check that because you two have different solutions for the first problem, line 415. > From: kai.blin(a)gmail.com > Date: Wed, 19 Nov 2008 12:41:50 +0100 > Subject: netapi32: Actually return a couple of return values. > To: wine-patches(a)winehq.org > > > ricardo filipe <ricardo_barbano(a)hotmail.com> found a couple of dead return > value assignments in nbt.c and netbios.c > > Fix up these error paths. > --- > dlls/netapi32/nbt.c | 12 +++++++++++- > dlls/netapi32/netbios.c | 2 +- > 2 files changed, 12 insertions(+), 2 deletions(-) _________________________________________________________________ Receba GRÁTIS as mensagens do Messenger no seu celular quando você estiver offline. Conheça o MSN Mobile! http://mobile.live.com/signup/signup2.aspx?lc=pt-br

1 0

dead stores in netapi32
by ricardo filipe Nov. 19, 2008

Nov. 19, 2008

hi juan! i'm tracking some dead stores with Clang and i've found some in files you created that i'm not comfortable messing with. file dlls/netapi32/nbt.c: lines: 419 839 1185 1192 1201 file dlls/netapi32/netbios.c: lines: 634 636 i thought you might want to have a look at it :) regards, ricardo _________________________________________________________________ Cansado de espaço para só 50 fotos? Conheça o Spaces, o site de relacionamentos com até 6,000 fotos! http://www.amigosdomessenger.com.br

3 3

Contribute to wine
by Krzysztof Drewniak Nov. 19, 2008

Nov. 19, 2008

I'd like to contribute something to wine, but I don't know what? Can I get a list? Krzys D. P.S. The audio is choppy on Ubuntu 8.10 with latest git.

3 2