November 2008 - Wine-Devel - list.winehq.org

Re: [ole32/tests] Don't crash on NT4
by Dmitry Timoshkov Nov. 10, 2008

Nov. 10, 2008

"Paul Vriens" <paul.vriens.wine(a)gmail.com> wrote: > static HENHMETAFILE create_emf(void) > { > RECT rect = {0, 0, 100, 100}; > + const RECT rect2 = {0, 0, 100, 100}; > HDC hdc = CreateEnhMetaFile(NULL, NULL, &rect, "HENHMETAFILE Marshaling Test\0Test\0\0"); > - ExtTextOut(hdc, 0, 0, ETO_OPAQUE, NULL, "Test String", strlen("Test String"), NULL); > + ExtTextOut(hdc, 0, 0, ETO_OPAQUE, &rect2, "Test String", strlen("Test String"), NULL); Is there any reason that you introduced rect2 instead of using existing rect? -- Dmitry.

1 0

valgrind warning in "advapi32/tests: Add tests for QueryServiceStatusEx."
by Dan Kegel Nov. 10, 2008

Nov. 10, 2008

Hi Paul, in your change of 21 Aug 2008, http://source.winehq.org/git/wine.git/?a=commit;h=794752200131184506e84939a… valgrind has found something to complain about: ==7145== Conditional jump or move depends on uninitialised value(s) ==7145== at 0x4734514: RtlAllocateHeap (heap.c:1357) ==7145== by 0x496ECF3: test_query_svc (service.c:896) ==7145== by 0x497142C: func_service (service.c:2079) ==7145== by 0x4975C17: run_test (test.h:452) ==7145== by 0x4975E18: main (test.h:502) ==7145== Uninitialised value was created by a stack allocation ==7145== at 0x496E7E1: test_query_svc (service.c:808) Could you have a look? Thanks, Dan

1 0

Please, look at my patch, I'm not sure it's correct
by Vitaly Perov Nov. 10, 2008

Nov. 10, 2008

Hi, This patch add a stub implementation of IMarshal interface. I have no experience at implementing interfaces, so I'm not sure it's implemented correctly. Please, look at this patch. I'll be grateful for any remarks. Thank you. -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru

2 2

Re: Solution for bug 15942 - Send page size with lpr command on printing
by Austin English Nov. 10, 2008

Nov. 10, 2008

On Sun, Nov 9, 2008 at 6:48 PM, Massimo Del Fedele <max(a)veneto.com> wrote: > Send page size with 'lpr' command to CUPS, so it doesn't take always the > default one. > Solves bug 15942. > > Max > > > > +// sprintf(psCmd,"|lpr -P'%s'",pszOutput+4); Don't use C++ comments, use /* comment */ instead. Also, don't comment out code. Remove it if unneeded, or if it should be left as an example, etc., use if(0). -- -Austin

3 2

winehq packages for Debian
by Ben Klein Nov. 10, 2008

Nov. 10, 2008

Hi guys, I'm a regular volunteer in the #winehq IRC channel (man_in_shack). Some of you may know me :) I also maintain a few applications on AppDB and have had a couple of bugs found and fixed via bugzilla posts. I've been building Wine packages for my Debian systems for a while and now I've written myself some helper scripts to make the task trivial :) I build both amd64 and i386 packages. I'd like to request that I take over Scott Ritchie's position as maintainer for the winehq Debian packages as he seems to have all but abandoned Debian package building. I have the following caveats: 1) I don't have a suitable place to upload the packages (in terms of bandwidth restrictions) 2) At the moment, I'm not sure if the packages are suitable for an apt repository, as I don't have proper Changelogs or source packages. I'm not entirely sure what I'd need to do for this, so help would be appreciated 3) I'm fully set up to produce etch packages (Scott's packages aren't etch-compatible any more) as well as packages for lenny and sid 4) I'm not asking to take over Ubuntu package building (Scott seems to be good at this, and I don't have nor want an Ubuntu system) 5) I can be *very* quick to produce packages, as in the day after release (or even building packages from non-release revisions in git if required) Involvement in wine is fun! Regards, Ben Klein

3 4

Another shot at running tests in parallel
by Dan Kegel Nov. 10, 2008

Nov. 10, 2008

On modern CPUs, with a 30 second timeout per test, the wine conformance test suite runs in about 4-5 minutes. That's wonderfully fast, completely sufficient for all purposes... ... except one: running tests under valgrind, which imposes a roughly 10x penalty. 40-50 minutes to run the tests is a bit too long to expect developers to wait for feedback. So I had another try at getting conformance tests to run in parallel, this time without any code modifications. I use WINETEST_WRAPPER="$HOME/alarm 30", where alarm is the output of compiling http://winezeug.googlecode.com/svn/trunk/patchwatcher/alarm.c That file has a hardcoded whitelist of tests that are know to not call CreateWindow (directly or indirectly) or do anything else that might not work well in parallel. alarm takes an exclusive lock when running any test not on that list. Even with this fairly restrictive whitelist, the tests were fairly parallelizable (see below). Because running tests in parallel is tricky, and makes our already somewhat shaky test suite less stable, I will run the tests the normal way first, and only if they pass without regressions will I then do a second run under Valgrind. And I'll ignore any test failures that happen under valgrind; all I care about in those runs are the valgrind warnings. Here are some benchmarks on a quad processor: -j time in seconds 1 255 2 155 3 125 4 105 20 79 With -j4, it looks like valgrind could run the tests in about ten minutes, which would be quick enough. It would be nice if our test suite really ran in parallel some day, but the approximation I have now is probably good enough. - Dan p.s. Out of curiosity, I checked how many tests interfere with themselves if multiple copies are run. To do this, I ran with WINETEST_WRAPPER="$HOME/foowrap.sh" where foowrap.sh was #!/bin/sh # Run same test three times in parallel $@ & sleep 1 $@ & $@ As you can imagine, that broke a lot of tests, many more than just running in parallel.

1 0

Re: Solution for bug 15942 - Send page size with lpr command on printing
by Austin English Nov. 10, 2008

Nov. 10, 2008

On Sun, Nov 9, 2008 at 6:48 PM, Massimo Del Fedele <max(a)veneto.com> wrote: > Send page size with 'lpr' command to CUPS, so it doesn't take always the > default one. > Solves bug 15942. > > Max > > > > +// sprintf(psCmd,"|lpr -P'%s'",pszOutput+4); Don't use C++ comments, use /* comment */ instead. Also, don't comment out code. Remove it if unneeded, or if it should be left as an example, etc., use if(0). -- -Austin

1 0

.ANI patch
by Krzysztof Drewniak Nov. 9, 2008

Nov. 9, 2008

There is a .ANI cursor patch in hacks.git. Would it be possible to integrate it into wine? I know of many applications (especcially games) that would benefit. Thanks Krzys D.

2 3

Wine and relocation on not aligned section
by Alessandro Nov. 9, 2008

Nov. 9, 2008

Hi list, while diving into wine sources i've noticed that wine does not apply relocation to section not aligned to page boundary. Is there any reason for this behaviour? If it is wrong i've put up a little patch that solves the issue. Greetings, Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

1 0

Re: [PATCH 1/2] Implement GdipGetLogFontA (try2)
by Dmitry Timoshkov Nov. 9, 2008

Nov. 9, 2008

"Adam Petaccia" <adam(a)tpetaccia.com> wrote: > +GpStatus WINGDIPAPI GdipGetLogFontA(GpFont *font, GpGraphics *graphics, > + LOGFONTA *lfa) > +{ > + INT bytesWritten; > + /* FIXME: use graphics */ > + if(!(font && graphics && lfa)) > + return InvalidParameter; > + > + memcpy(lfa, &font->lfw, sizeof(LOGFONTA)); FIELD_OFFSET(LOGFONTA, lfFaceName) instead of sizeof(LOGFONTA) would be better IMO. > + bytesWritten = WideCharToMultiByte(CP_ACP, 0, font->lfw.lfFaceName, -1, > + lfa->lfFaceName, LF_FACESIZE, NULL, NULL); > + > + if (bytesWritten == 0) > + { > + ERR("Could not convert from WideChar to Multibyte with error %d\n", > + GetLastError()); > + return GenericError; > + } The ERR() as well as the bytesWritten check are useless, please remove them. -- Dmitry.

1 0