November 2008 - Wine-Devel - list.winehq.org

Re: winedos: Fixed a problem with timer values that are below 50ms.
by Michael Stefaniuc Nov. 30, 2008

Nov. 30, 2008

Hello Peter, Peter Dons Tychsen wrote: > Fixed a problem with timer values that are smaller than the minimum time > that can be assigned to the SetTimer() win32 call (approx 50ms). The > patch splits up the timer into several interrupts if too long time has > passed.This fixes good old OutRun, which uses timers of approx 10ms. As > a bonus, this aalso fixes situations where we have fallen behind for > other reasons. your patch introduces a lot of dangling whitespace at the end of lines. bye michael

4 5

today's git does not compile with yesterday's new gcc -- regression test results
by Susan Cragin Nov. 30, 2008

Nov. 30, 2008

I did the regression test. But how legitimate are the results if the problem is the new gcc that I downloaded recently, and not wine? gcc (Ubuntu 4.3.2-2ubuntu5) 4.3.3 20081129 (prerelease) susan(a)ubuntu:~/wine$ git bisect bad Bisecting: 0 revisions left to test after this [0b7478a79fb0594daba5cee3c0288884c352ad39] widl: Make sure format strings for structure and union types are only output once. Susan

3 2

Help need list of wine git versions
by Susan Cragin Nov. 30, 2008

Nov. 30, 2008

Need the number of the current git because am doing regression on it, because it doesn't compile on my machine using my gcc. gcc (Ubuntu 4.3.2-2ubuntu5) 4.3.3 20081129 (prerelease) (And BTW can the regression test page link to this page?) Thank you very much. Susan

3 2

Fw: selinux in fedora 10 regarding text relocation in wine and mono.
by Hin-Tak Leung Nov. 29, 2008

Nov. 29, 2008

I sent this a few days ago from my "other" e-mail alias and it hasn't come back, so it probably got lost in the spam-filtering - anybody has similiar issue? > So I have upgraded to fedora 10... now when I run wine with > mono for some .Net application I get selinux blocking it, > saying: > > ----------------- > > The mscorsvw.exe application attempted to load > /home/Hin-Tak/.wine/drive_c/windows/Microsoft.NET/Framework/v2.0.50727/mscorsvw.exe > which requires text relocation. This is a potential security > problem. Most libraries do not need this permission. > Libraries are sometimes coded incorrectly and request this > permission. > > ------------------ > > And a few other similar errors. Should I file this with > redhat with their shipped policy, wine or mono? I guess it > should be with redhat, but > somehow I have the impression that I might be asked to file > this with wine-devel. > > Any thoughts on this?

1 0

Hmm, guess we have to update our web site a bit
by Dan Kegel Nov. 29, 2008

Nov. 29, 2008

Somebody's walkthrough of installing crossover got lots of diggs: http://digg.com/linux_unix/Running_Windows_Programs_On_Ubuntu_8_10_With_Cro… The comments point out that http://www.winehq.org/site/myths could use a little updating...

2 1

wineconsole: Wait on events in curses backend using select instead of poll
by Kirill K. Smirnov Nov. 29, 2008

Nov. 29, 2008

>Should I add a >check for sys/select.h in the configure script and conditionally included >it, surrounded by HAVE_SYS_SELECT_H? Or would sys/time.h, sys/types.h and >unistd.h be enough to consider it reasonably compatible? Ideally - should. But... 1) There isn't any 'select.h' substring in whole wine tree. 2) There is a file libs/port/usleep.c which uses select() but it does not include any meaningful headers except "config.h" and "wine/port.h". Are these two headers enough wineconsole - I have no idea. Alexandre knows better ;-) Try and see ;-) >After fixing this, I guess I should just submit a new patch against the >current upstream git (not against the old patched version), with the same >commit message, replacing the old one? Yes, and mark a new mail subject with tag '[try 2]' to easily distinguish between different version of the same fix. -- Kirill

2 1

wineconsole: Wait on events in curses backend using select instead of poll
by Kirill K. Smirnov Nov. 29, 2008

Nov. 29, 2008

Hi, Martin, >+ ret = select(pipefd + 1, &readfds, &writefds, &errorfds, NULL); Passing NULL instead of &writefds in this case is better, IMO. It is not used anyway. ...and... I strongly believe that errorfds parameter os select() is useful for sockets only, not for stdio (I am not sure whether it is true for Darwin). Please, check this. -- Kirill

2 1

Implementing wtmpnam in msvcrt
by Tim Holy Nov. 29, 2008

Nov. 29, 2008

Hello, I'm trying to implement the "stub" function wtmpnam in msvcrt. Below is a patch at an attempt; there are a number of questions I have about the right way to implement it, and since I don't know the Wine codebase I thought perhaps readers of this list might (with minimal effort) be able to point me in the right direction. Below is the text of the patch (it's short). My questions are embedded after //-style comments (4 in total). Many thanks in advance for your help! --Tim diff -U 3 -r winecopy/wine-1.1.8/dlls/msvcrt/file.c wine-1.1.8/dlls/msvcrt/file.c --- winecopy/wine-1.1.8/dlls/msvcrt/file.c 2008-11-07 10:09:33.000000000 -0600 +++ wine-1.1.8/dlls/msvcrt/file.c 2008-11-29 07:32:43.000000000 -0600 @@ -88,6 +88,7 @@ /* INTERNAL: Static buffer for temp file name */ static char MSVCRT_tmpname[MAX_PATH]; +static MSVCRT_wchar_t MSVCRT_wtmpname[MAX_PATH]; static const unsigned int EXE = 'e' << 16 | 'x' << 8 | 'e'; static const unsigned int BAT = 'b' << 16 | 'a' << 8 | 't'; @@ -2990,6 +2991,32 @@ } /********************************************************************* + * wtmpnam (MSVCRT.@) + */ +MSVCRT_wchar_t * CDECL MSVCRT_wtmpnam(MSVCRT_wchar_t *s) +{ + static int unique; + char tmpstr[16]; + MSVCRT_wchar_t wtmpstr[16]; + MSVCRT_wchar_t *p; + int count; + if (s == 0) + s = MSVCRT_wtmpname; + msvcrt_int_to_base32(GetCurrentProcessId(), tmpstr); + p = s + MSVCRT_swprintf(s, "\\s%s.", tmpstr); // "implicit declaration" error, function is defined in wcs (but no wcs.h); but how to convert format string to MSVCRT_wchar_t? + for (count = 0; count < MSVCRT_TMP_MAX; count++) + { + msvcrt_int_to_base32(unique++, tmpstr); + mbstowcs(wtmpstr,tmpstr,strlen(tmpstr)); // need a MSVCRT_wchar version + wcscpy(p, wtmpstr); // need a MSVCRT_wchar version + if (GetFileAttributesW(s) == INVALID_FILE_ATTRIBUTES && + GetLastError() == ERROR_FILE_NOT_FOUND) + break; + } + return s; +} + +/********************************************************************* * tmpfile (MSVCRT.@) */ MSVCRT_FILE* CDECL MSVCRT_tmpfile(void) diff -U 3 -r winecopy/wine-1.1.8/dlls/msvcrt/msvcrt.spec wine-1.1.8/dlls/msvcrt/msvcrt.spec --- winecopy/wine-1.1.8/dlls/msvcrt/msvcrt.spec 2008-11-07 10:09:33.000000000 -0600 +++ wine-1.1.8/dlls/msvcrt/msvcrt.spec 2008-11-29 07:12:10.000000000 -0600 @@ -579,7 +579,7 @@ @ cdecl _wstrtime(ptr) @ cdecl _wsystem(wstr) @ cdecl _wtempnam(wstr wstr) -@ stub _wtmpnam #(ptr) +@ cdecl wtmpnam(ptr) MSVCRT_wtmpnam // needs an underscore? @ cdecl _wtoi(wstr) ntdll._wtoi @ cdecl _wtoi64(wstr) ntdll._wtoi64 @ cdecl _wtol(wstr) ntdll._wtol

3 6

new winetricks-20081129: new verbs mshflxgd, controlpad/fm20, native_oleaut32
by Dan Kegel Nov. 29, 2008

Nov. 29, 2008

Also clean up temp directory between verbs, as some verbs were writing readonly files with unique names like 'setup.exe' and stumbling over each other. As always, online at http://kegel.com/wine/winetricks Please submit bug reports to http://code.google.com/p/winezeug/issues/list

1 0

Re: winex11.drv: change bpp fixme to a warn
by James Hawkins Nov. 28, 2008

Nov. 28, 2008

On Fri, Nov 28, 2008 at 4:25 PM, Austin English <austinenglish(a)gmail.com> wrote: > This isn't something we can really fix on our end, so a FIXME isn't appropriate. > diff --git a/dlls/advapi32/security.c b/dlls/advapi32/security.c index 8229377..16aa8c3 100644 --- a/dlls/advapi32/security.c +++ b/dlls/advapi32/security.c @@ -1155,6 +1155,7 @@ DWORD WINAPI BuildSecurityDescriptorW( BOOL WINAPI InitializeSecurityDescriptor( PSECURITY_DESCRIPTOR pDescr, DWORD revision ) { + pDescr = 0; return set_ntstatus( RtlCreateSecurityDescriptor(pDescr, revision )); } Extraneous change. -- James Hawkins

2 1