November 2008 - Wine-Devel - list.winehq.org

Re: shell32/autocomplete: fix handling of WM_KILLFOCUS messages
by Austin English Nov. 28, 2008

Nov. 28, 2008

On Fri, Nov 28, 2008 at 10:53 AM, Jan de Mooij <jandemooij(a)gmail.com> wrote: > In eMule after moving focus from the searchbox to another control, it > still shows the caret and search is unusable without switching tabs. > > Autocomplete overrides the textbox message handler. But after handling > WM_KILLFOCUS messages we should send it to the old handler so it can > move the focus from the textbox, hide the caret, etc. > > Fixes bug 4090: http://bugs.winehq.org/show_bug.cgi?id=4090 > > Regards > > > > Can you add a testcase for this? -- -Austin

1 0

Re: dinput: Remove WINAPI on static functions where not needed.
by Vitaliy Margolen Nov. 28, 2008

Nov. 28, 2008

Francois Gouget wrote: > --- > > If you know other places where the functions touched by this patch > are used, please let me know. For more details, see: > > http://www.winehq.org/pipermail/wine-patches/2008-November/064995.html > > > dlls/dinput/joystick_linux.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/dlls/dinput/joystick_linux.c b/dlls/dinput/joystick_linux.c > index 4146f1d..47c734d 100644 > --- a/dlls/dinput/joystick_linux.c > +++ b/dlls/dinput/joystick_linux.c > @@ -966,7 +966,7 @@ static HRESULT WINAPI JoystickAImpl_GetProperty( > /****************************************************************************** > * GetObjectInfo : get object info > */ > -static HRESULT WINAPI JoystickWImpl_GetObjectInfo(LPDIRECTINPUTDEVICE8W iface, > +static HRESULT JoystickWImpl_GetObjectInfo(LPDIRECTINPUTDEVICE8W iface, > LPDIDEVICEOBJECTINSTANCEW pdidoi, DWORD dwObj, DWORD dwHow) > { > static const WCHAR axisW[] = {'A','x','i','s',' ','%','d',0}; Please don't apply this patch. This function should be used in vtable but isn't by mistake. Sending a patch to fix this. Vitaliy.

1 0

Re: [1/2] [try 4] mlang: Add implementation offnIMLangFontLink_GetCharCodePages
by Dmitry Timoshkov Nov. 28, 2008

Nov. 28, 2008

"Vitaly Perov" <vitperov(a)etersoft.ru> wrote: > Changes since last send: > - Used local mlang_data structure instead of calling internal function > wine_cp_enum_table. > - Used macro instead of "iface->lpVtbl->...." Looks good to me. -- Dmitry.

2 1

New winetricks 20081127: new verbs mono20, ie6, msmask, ole2
by Dan Kegel Nov. 28, 2008

Nov. 28, 2008

Also updates to latest directx9, and fixes a Mac problem. As always, online at http://kegel.com/wine/winetricks Please submit bug reports to http://code.google.com/p/winezeug/issues/list Thanks to everybody who sent in suggestions and patches! ie6 - Steven Edwards msmask - Austin mac bugfix - Ryan Schmidt

1 0

Re: programs: Fix broken compilation on win64
by Rob Shearman Nov. 27, 2008

Nov. 27, 2008

2008/11/27 Maarten Lankhorst <maarten(a)codeweavers.com>: > --- > Set the Spare[0] at runtime after a critical section is entered. :-) > > I'm not testing Spare[0] at all calls to EnterCriticalSection, but if this > is a problem I will send a revised patch IMHO, this is too fragile. My solution would be two macros: one for declaring a variable storing the name for a critical section, and a second for putting that name into the critical section structure. The latter would be something like the following for 64-bit: #define WINE_DEBUG_USE_CRIT_SECT_NAME(name) { (DWORD)(DWORD_PTR)name, (DWORD)((DWORD_PTR)name >> 32) } It might even be better to let the macro fill in / declare the entire CRITICAL_SECTION_DEBUG stucture. -- Rob Shearman

2 1

Re: d3dxof: DPRINTF -> TRACE.
by Christian Costa Nov. 27, 2008

Nov. 27, 2008

DPRINTF use here is intentional. Christian Andrew Riedi a écrit : > Changelog: > d3dxof: DPRINTF -> TRACE. > > > ------------------------------------------------------------------------ > >

1 0

Re: [3/5] WineD3D: Fix D3DFMT_R32F, R16F, G16R16F, ... in the pixel shader
by Roderick Colenbrander Nov. 27, 2008

Nov. 27, 2008

Hi, I don't know much about the current shader code but is this the right way to go thinking about GL_EXT_texture_swizzle + GL_ARB_texture_rg? For instance Nvidia drivers will soon get the swizzle extension and for that you don't have to fixups anymore. Is moving this way the right approach, so that it won't become a mess later on? Roderick -- Psssst! Schon vom neuen GMX MultiMessenger gehört? Der kann`s mit allen: http://www.gmx.net/de/go/multimessenger

3 11

Re: [1/2] [try 3] mlang: Add implementation offnIMLangFontLink_GetCharCodePages
by Dmitry Timoshkov Nov. 27, 2008

Nov. 27, 2008

"Vitaly Perov" <vitperov(a)etersoft.ru> wrote: > Changes since last send: > - Used WINAPI function instead of accessing Wine internal code page > structures. You still access internal Wine code page structures, I'm not sure why you claim otherwise. > "Dmitry Timoshkov" <dmitry(a)codeweavers.com> wrote: >>It *is* possible to use EnumSystemCodePages > > Yes, it is possible. But : > 1) this function call wine_cp_enum_table, then converts the result (codepage) > to the string. So we need convert the result back to the number. > 2) It pass code pages to the callback-function. The callback function uses > only one argument - string with codepage number. So it's very difficult to > pass this value back to the GetCharCodePages function. > > So, I think the best decision is to use internal function wine_cp_enum_table What's happend to the idea to use mlang_data? And again: forget about Wine internal code page structures, that's the implementation detail that's internal to kernel32/ntdll, that structures should not be used outside of kernel32/ntdll. > + iface->lpVtbl->CodePageToCodePages(iface, > + cpTable->info.codepage, &codePages); Have a look how other parts in Wine call vtable members, the tests have enough code samples. -- Dmitry.

1 0

Re: user32: Improve the LoadImage() test.
by Dmitry Timoshkov Nov. 27, 2008

Nov. 27, 2008

"Andrew Riedi" <andrewriedi(a)gmail.com> wrote: > - icon_entry->xHotspot = 1; > - icon_entry->yHotspot = 1; > + icon_entry->xHotspot = 1; /* Color planes for .ico. */ > + icon_entry->yHotspot = ICON_BPP; /* BPP for .ico. */ ... > ok(icon_info.xHotspot == 1, "xHotspot is %u.\n", icon_info.xHotspot); > - ok(icon_info.yHotspot == 1, "yHotspot is %u.\n", icon_info.yHotspot); > + ok(icon_info.yHotspot == 32, "yHotspot is %u.\n", icon_info.yHotspot); It should be ICON_BPP instead of 32 for consistency. > + /* Test loading an icon as an icon. */ > + SetLastError(0xdeadbeef); > + handle = LoadImageA(NULL, "icon.ico", IMAGE_ICON, 0, 0, LR_LOADFROMFILE); > + ok(handle != NULL, "LoadImage() failed.\n"); > + error = GetLastError(); > + ok(error == 0 || > + broken(error == 0xdeadbeef) || /* Win9x */ > + broken(error == ERROR_BAD_PATHNAME), /* Win98, WinMe */ > + "Last error: %u\n", error); There is no point in testing last error value if the API didn't fail. > + /* Test the icon information. */ > + SetLastError(0xdeadbeef); > + ret = GetIconInfo(handle, &icon_info); > + ok(ret, "GetIconInfo() failed.\n"); > + error = GetLastError(); > + ok(error == 0xdeadbeef, "Last error: %u\n", error); Same here. > + if (ret) > + { > + ok(icon_info.fIcon == TRUE, "fIcon == FALSE.\n"); > + ok(icon_info.xHotspot == 16, "xHotspot is %u.\n", icon_info.xHotspot); > + ok(icon_info.yHotspot == 16, "yHotspot is %u.\n", icon_info.yHotspot); > + ok(icon_info.hbmColor != NULL, "No hbmColor!\n"); > + ok(icon_info.hbmMask != NULL, "No hbmMask!\n"); > + } 'if (ret)' is useless if you don't expect a failure. > + > + /* Clean up. */ > + SetLastError(0xdeadbeef); > + ret = DestroyIcon(handle); > + ok(ret, "DestroyIcon() failed.\n"); > + error = GetLastError(); > + ok(error == 0xdeadbeef, "Last error: %u\n", error); Same here. -- Dmitry.

3 2

Re: ole32: Add Co*InitializeSpy functions
by Rob Shearman Nov. 27, 2008

Nov. 27, 2008

2008/11/26 Maarten Lankhorst <maarten(a)codeweavers.com>: > + > +HRESULT WINAPI CoRevokeInitializeSpy(ULARGE_INTEGER cookie) > +{ > + struct oletls *info = COM_CurrentInfo(); > + TRACE("(%s)\n", wine_dbgstr_longlong(cookie.QuadPart)); > + > + if (!info || !info->spy || cookie.QuadPart != (DWORD_PTR)info->spy) > + return E_INVALIDARG; > + > + IUnknown_Release(info->spy); > + return S_OK; > +} No function documentation and you forget to clear info->spy before returning. -- Rob Shearman

2 1