December 2008 - Wine-Devel - list.winehq.org

winecfg volume serial number
by Hoehle, Joerg-Cyril Dec. 16, 2008

Dec. 16, 2008

Hi, I just sent a bug-fix to wine-patches to prevent a crash in winecfg when editing the volume serial number input field, together with some unrelated thoughts about winecfg and the device/volume serial number handling. Then I realized that wine-patches is not a good place for discussion. So here are the ideas about winecfg's GUI: - Maybe the serial input field should be initialized with %08X instead of %X to hint at the format? E.g. input of serial numbers like "1122-dacf" as printed by DIR produce 00001122 in winecfg, due to strtoul(). - Possibly the input size should be restricted to 8 characters in the GUI? - Maybe winecfg should echo the hex number it read into the input field, no later than "apply" time? Currently one needs to select another drive, then come back to see what it got. Note that winecmd's DIR prints the number in lower case, while MS-w2k DOS window's DIR prints upper case. BTW, winecfg does not seem to be able to set .windows-label anymore: trace:winecfg:apply_drive_changes warn:winecfg:set_drive_label unable to set volume label for devicename of L"E:\\", label of L"xyz" trace:winecfg:PRINTERROR error: 'Access denied' Looks like http://bugs.winehq.org/show_bug.cgi?id=13273 Regards, Jörg Höhle

1 0

Use show instead of glyphshow: gylphshow very slow on kyocera
by Wolfgang Walter Dec. 16, 2008

Dec. 16, 2008

Hello, wineps.drv uses the postscript operator glyphshow to print glyphs. This operator is very slow on all Kyocera postscript printers. To get an idea: its generally only 1/6 to 1/10 of the performance compared to the same document printed with the windows xp postscript driver (which does not use glyphsow). I wrote an email hier where I proposed a patch. This patch changes wineps.drv such that it uses the show operator for downloaded fonts (type1 and type42). This change is not trivial as the show operator (and its relatives xshow, yshow, xyshow) operates on character codes and not on glyhpnames. So wineps.drv must generate postscript code define an appropriate encoding. As a font may only have up to 256 characters encoded and as it is not allowed to modify the encoding once defined the font must be cloned if more then 256 characters are used. This is inexpensive, though, as actually all resources but the encoding array are shared. See the patch my earlier mail for a more detailed explanation. This modification brings the performance of the postscript code generated by wine up to windows' postscript driver (if no clipping region is defined - another problem). I tested it on a wide range of kyocera printer models and two hp models. Of course I tested it with ghostscript. I would appreciate any comments and ideas. Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts Leiter EDV Leopoldstraße 15 80802 München

1 0

wineps: clipping bug; clipping performance
by Wolfgang Walter Dec. 16, 2008

Dec. 16, 2008

Hello, as I wrote clipping in wineps.drv has a bug. Wine does only consider the clipping region and not the meta region. It should combine them. This is a bug which hurts us with a real windows application. I sent a patch which which corrects this. My patch also addressed a general performance problem with all postscript printers from Kyocera concerning non trivial clipping regions. Even if you use ghostscripts pxlmono/pxlcolor driver the generated PCL XL code may lead to errors on our Kyocera and HP printers because the clipping path gets to expensive. I have not received any comment yet. Regards, -- Wolfgang Walter Studentenwerk München Anstalt des öffentlichen Rechts Leiter EDV Leopoldstraße 15 80802 München

2 2

Canonical and wine
by Dan Kegel Dec. 16, 2008

Dec. 16, 2008

http://www.technewsworld.com/rsstory/65431.html quotes Gerry Carr, marketing manager at Canonical: "We aren't considering a pitch about using Wine or Parallels like on a Mac. There is no real look at Wine. It doesn't always work well. So this won't win over users to the benefits of Linux," So there you go. Canonical will think about Wine once it always works well.

14 20

Re: [resend5] gdi32/tests: Add a test fot GdiGetCodePage().
by Paul Vriens Dec. 16, 2008

Dec. 16, 2008

ByeongSik Jeon wrote: > --- > dlls/gdi32/tests/Makefile.in | 2 +- > dlls/gdi32/tests/font.c | 156 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 157 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > Hi, I applied these tests to my local box (no other patches) and the test fails for me. Or to but it more correct some (all?) of the todo_wine's succeeded. I then removed the todo_wine's from your tests and I don't have failures anymore. The fact that the tests fails for me (and probably for others as well) could mean the patch won't be committed (unless it succeeds on AJ's machine of course). -- Cheers, Paul.

1 0

Re: oleaut32/tests: add tests for OleLoadPictureFile(Ex) and OleLoadPicurePath (resend) [3/3]
by Paul Vriens Dec. 16, 2008

Dec. 16, 2008

Jeremy Drake wrote: > This integrates the scenarios that I wasn't testing from Nikolay Sivov's > patch to the tests of 12/7. Also works around some issues I was running > into trying to write wide strings as L"foo". > > --- > dlls/oleaut32/tests/olepicture.c | 311 ++++++++++++++++++++++++++++++++++++++ > 1 files changed, 311 insertions(+), 0 deletions(-) > > diff --git a/dlls/oleaut32/tests/olepicture.c b/dlls/oleaut32/tests/olepicture.c > index 2b5b8bb..2929bd7 100644 > --- a/dlls/oleaut32/tests/olepicture.c > +++ b/dlls/oleaut32/tests/olepicture.c > @@ -489,6 +489,315 @@ static void test_OleCreatePictureIndirect(void) > IPicture_Release(pict); > } > > +static void test_VerifyPictureType(IDispatch *pdisp, short expectedtype, int caller_line) > +{ > + IPicture *pict; > + HRESULT hr; > + short type; > + pict = (void*)0xdeadbeef; > + hr = IDispatch_QueryInterface(pdisp, &IID_IPicture, (LPVOID*)&pict); > + ok(hr == S_OK, "hr %08x\n", hr); > + ok(pict != (void*)0xdeadbeef && pict != NULL, "pict ptr, caller line %d\n", caller_line); > + > + if (SUCCEEDED(hr)) > + { > + type = 0xdead; > + hr = IPicture_get_Type(pict, &type); > + ok(hr == S_OK, "hr %08x, caller line %d\n", hr, caller_line); > + ok(type == expectedtype, "type %hd, expected %hd, caller line %d\n", type, expectedtype, caller_line); > + > + IPicture_Release(pict); > + } > +} > + > +static const WCHAR nopath[] = { '\\', 'n', 'o', 'p', 'a', 't', 'h', 0 }; > +static void test_OleLoadPictureFile(void) > +{ > + IDispatch *disp; > + HRESULT hr; > + char filename[MAX_PATH]; > + VARIANT varFilename; > + HANDLE file; > + DWORD written; > + DWORD widestringlen; > + BSTR tmp = NULL, tmp2 = NULL; > + > + GetTempFileNameA(".", "gif", 0, filename); > + file = CreateFileA(filename, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0); > + ok(file != INVALID_HANDLE_VALUE, "file creation error %u\n", GetLastError()); > + if (file == INVALID_HANDLE_VALUE) return; > + WriteFile(file, gif4pixel, sizeof(gif4pixel), &written, NULL); > + ok(written == sizeof(gif4pixel), "write\n"); > + > + VariantInit(&varFilename); > + V_VT(&varFilename) = VT_ERROR; > + V_ERROR(&varFilename) = DISP_E_PARAMNOTFOUND; > + > + todo_wine > + { > + disp = (void*)0xdeadbeef; > + hr = OleLoadPictureFileEx(varFilename, 2, 2, LP_DEFAULT, &disp); > + ok(hr == S_OK, "hr %08x\n", hr); > + ok(disp != (void*)0xdeadbeef, "dispatch ptr\n"); > + > + if (disp != (void*)0xdeadbeef) > + { > + test_VerifyPictureType(disp, PICTYPE_NONE, __LINE__); > + IDispatch_Release(disp); > + } > + } > + > + > + widestringlen = MultiByteToWideChar(CP_ACP, 0, filename, -1, NULL, 0); > + ok(widestringlen != 0, "determining wide string length error %u\n", GetLastError()); > + if (widestringlen == 0) return; > + V_VT(&varFilename) = VT_BSTR; > + V_BSTR(&varFilename) = SysAllocStringLen(NULL, widestringlen - 1); > + ok(MultiByteToWideChar(CP_ACP, 0, filename, -1, V_BSTR(&varFilename), widestringlen), > + "filename to wide string conversion error %u\n", GetLastError()); > + > + disp = (void*)0xdeadbeef; > + todo_wine > + { > + hr = OleLoadPictureFile(varFilename, &disp); > + ok(hr == CTL_E_PERMISSIONDENIED, "hr %08x\n", hr); > + } > + ok(disp == (void*)0xdeadbeef, "dispatch ptr\n"); > + > + CloseHandle(file); > + > + disp = (void*)0xdeadbeef; > + todo_wine > + { > + hr = OleLoadPictureFileEx(varFilename, 2, 2, LP_DEFAULT, &disp); > + ok(hr == S_OK, "hr %08x\n", hr); > + ok(disp != (void*)0xdeadbeef && disp != NULL, "dispatch ptr\n"); > + > + if (SUCCEEDED(hr)) > + { > + test_VerifyPictureType(disp, PICTYPE_BITMAP, __LINE__); > + IDispatch_Release(disp); > + } > + } > + > + todo_wine > + { > + disp = (void*)0xdeadbeef; > + hr = OleLoadPictureFile(varFilename, &disp); > + ok(hr == S_OK, "hr %08x\n", hr); > + ok(disp != (void*)0xdeadbeef && disp != NULL, "dispatch ptr\n"); > + > + if (SUCCEEDED(hr)) > + { > + test_VerifyPictureType(disp, PICTYPE_BITMAP, __LINE__); > + IDispatch_Release(disp); > + } > + } > + > + ok(MoveFileA(filename, "33"), "move file\n"); > + > + file = CreateFileA(filename, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0); > + ok(file != INVALID_HANDLE_VALUE, "file creation error %u\n", GetLastError()); > + if (file != INVALID_HANDLE_VALUE) > + { > + WriteFile(file, "this is not a valid picture", 28, &written, NULL); > + ok(written == 28, "write\n"); > + CloseHandle(file); > + > + disp = (void*)0xdeadbeef; > + todo_wine > + { > + hr = OleLoadPictureFile(varFilename, &disp); > + ok(hr == CTL_E_INVALIDPICTURE, "hr %08x\n", hr); > + ok(disp == NULL, "dispatch ptr\n"); /* XXX this one is not unmodified!! */ > + } > + DeleteFileA(filename); > + } > + > + tmp = SysAllocString(nopath); > + ok(tmp != NULL, "SysAllocString\n"); > + if (tmp != NULL) > + { > + hr = VarBstrCat(V_BSTR(&varFilename), tmp, &tmp2); > + if (SUCCEEDED(hr)) > + { > + SysFreeString(V_BSTR(&varFilename)); > + V_BSTR(&varFilename) = tmp2; > + > + disp = (void*)0xdeadbeef; > + todo_wine > + { > + hr = OleLoadPictureFile(varFilename, &disp); > + ok(hr == CTL_E_PATHNOTFOUND, "hr %08x\n", hr); > + } > + ok(disp == (void*)0xdeadbeef, "dispatch ptr\n"); > + } > + > + SysFreeString(tmp); > + } > + > + VariantClear(&varFilename); > + VariantInit(&varFilename); > + V_VT(&varFilename) = VT_I4; > + V_I4(&varFilename) = 33; > + > + todo_wine > + { > + disp = (void*)0xdeadbeef; > + hr = OleLoadPictureFile(varFilename, &disp); > + ok(hr == S_OK, "hr %08x\n", hr); > + ok(disp != (void*)0xdeadbeef && disp != NULL, "dispatch ptr\n"); > + > + if (SUCCEEDED(hr)) > + { > + test_VerifyPictureType(disp, PICTYPE_BITMAP, __LINE__); > + IDispatch_Release(disp); > + } > + } > + ok(V_VT(&varFilename) == VT_I4 && V_I4(&varFilename) == 33, "variant unmodified\n"); > + > + DeleteFileA("33"); > + > + VariantClear(&varFilename); > +} > + > +static void test_OleLoadPicturePath(void) > +{ > + static const WCHAR fileproto[] = { 'f','i','l','e',':','/','/',0 }; > + IDispatch *disp; > + HRESULT hr; > + char filename[MAX_PATH]; > + char absfile[MAX_PATH]; > + HANDLE file; > + DWORD written; > + DWORD widestringlen; > + BSTR bstrname = NULL; > + BSTR tmp = NULL, tmp2 = NULL; > + > + GetTempFileNameA(".", "gif", 0, filename); > + GetFullPathNameA(filename, MAX_PATH, absfile, NULL); > + file = CreateFileA(filename, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0); > + ok(file != INVALID_HANDLE_VALUE, "file creation error %u\n", GetLastError()); > + if (file == INVALID_HANDLE_VALUE) return; > + WriteFile(file, gif4pixel, sizeof(gif4pixel), &written, NULL); > + ok(written == sizeof(gif4pixel), "write\n"); > + > + widestringlen = MultiByteToWideChar(CP_ACP, 0, absfile, -1, NULL, 0); > + ok(widestringlen != 0, "determining wide string length error %u\n", GetLastError()); > + if (widestringlen == 0) return; > + bstrname = SysAllocStringLen(NULL, widestringlen - 1); > + ok(MultiByteToWideChar(CP_ACP, 0, absfile, -1, bstrname, widestringlen), > + "filename to wide string conversion error %u\n", GetLastError()); > + > + disp = (void*)0xdeadbeef; > + hr = OleLoadPicturePath(bstrname, NULL, 0, 0, &IID_IDispatch, (LPVOID*)&disp); > + if (hr == E_UNEXPECTED) > + { > + /* E_UNEXPECTED is returned from OleLoadPicturePath on win95 without IE installed */ > + win_skip("OleLoadPicturePath seems to not work on this platform. No IE?\n"); > + CloseHandle(file); > + DeleteFileA(filename); > + return; > + } > + ok(hr == INET_E_DATA_NOT_AVAILABLE /*>=XP*/ || > + hr == E_FAIL /*<=2k*/, "hr %08x\n", hr); > + todo_wine ok(disp == NULL, "dispatch ptr\n"); > + > + CloseHandle(file); > + > + disp = (void*)0xdeadbeef; > + todo_wine > + { > + hr = OleLoadPicturePath(bstrname, NULL, 0, 0, &IID_IDispatch, (LPVOID*)&disp); > + ok(hr == S_OK, "hr %08x\n", hr); > + ok(disp != NULL && disp != (void*)0xdeadbeef, "dispatch ptr\n"); > + > + if (SUCCEEDED(hr)) > + { > + test_VerifyPictureType(disp, PICTYPE_BITMAP, __LINE__); > + IDispatch_Release(disp); > + } > + } > + > + disp = (void*)0xdeadbeef; > + todo_wine > + { > + tmp = SysAllocString(fileproto); > + hr = VarBstrCat(tmp, bstrname, &tmp2); > + SysFreeString(tmp); > + tmp = NULL; > + > + > + hr = OleLoadPicturePath(tmp2, NULL, 0, 0, &IID_IDispatch, (LPVOID*)&disp); > + ok(hr == S_OK, "hr %08x\n", hr); > + ok(disp != NULL && disp != (void*)0xdeadbeef, "dispatch ptr\n"); > + > + if (SUCCEEDED(hr)) > + { > + test_VerifyPictureType(disp, PICTYPE_BITMAP, __LINE__); > + IDispatch_Release(disp); > + } > + SysFreeString(tmp2); > + tmp2 = NULL; > + } > + > + > + widestringlen = MultiByteToWideChar(CP_ACP, 0, filename, -1, NULL, 0); > + ok(widestringlen != 0, "determining wide string length error %u\n", GetLastError()); > + if (widestringlen == 0) return; > + tmp = SysAllocStringLen(NULL, widestringlen - 1); > + ok(MultiByteToWideChar(CP_ACP, 0, filename, -1, tmp, widestringlen), > + "filename to wide string conversion error %u\n", GetLastError()); > + > + disp = (void*)0xdeadbeef; > + > + todo_wine > + { > + hr = OleLoadPicturePath(tmp, NULL, 0, 0, &IID_IDispatch, (LPVOID*)&disp); > + ok(hr == INET_E_UNKNOWN_PROTOCOL /*>= XP*/ || > + hr == E_FAIL /*<= 2k*/, "hr %08x\n", hr); > + ok(disp == NULL, "dispatch ptr\n"); > + SysFreeString(tmp); > + tmp = NULL; > + } > + > + file = CreateFileA(filename, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0); > + ok(file != INVALID_HANDLE_VALUE, "file creation error %u\n", GetLastError()); > + if (file != INVALID_HANDLE_VALUE) > + { > + WriteFile(file, "this is not a valid picture", 28, &written, NULL); > + ok(written == 28, "write\n"); > + CloseHandle(file); > + > + disp = (void*)0xdeadbeef; > + todo_wine > + { > + hr = OleLoadPicturePath(bstrname, NULL, 0, 0, &IID_IDispatch, (LPVOID*)&disp); > + ok(hr == E_FAIL, "hr %08x\n", hr); > + ok(disp == NULL, "dispatch ptr\n"); > + } > + } > + > + DeleteFileA(filename); > + > + tmp = SysAllocString(nopath); > + hr = VarBstrCat(bstrname, tmp, &tmp2); > + SysFreeString(bstrname); > + bstrname = tmp2; > + > + disp = (void*)0xdeadbeef; > + todo_wine > + { > + hr = OleLoadPicturePath(bstrname, NULL, 0, 0, &IID_IDispatch, (LPVOID*)&disp); > + ok(hr == INET_E_RESOURCE_NOT_FOUND /*>=XP*/ || > + hr == E_FAIL /*<=2k*/, "hr %08x\n", hr); > + ok(disp == NULL, "dispatch ptr\n"); > + } > + > + SysFreeString(tmp); > + SysFreeString(bstrname); > +} > + > static void test_apm() > { > OLE_HANDLE handle; > @@ -671,6 +980,8 @@ START_TEST(olepicture) > > test_Invoke(); > test_OleCreatePictureIndirect(); > + test_OleLoadPictureFile(); > + test_OleLoadPicturePath(); > test_Render(); > } > Hi Jeremy, Could you please use spaces instead of tabs. I know that this file already has some tabs but please don't add more. -- Cheers, Paul.

1 0

patch to fix bug 8072, but need some help with tests
by ricardo filipe Dec. 16, 2008

Dec. 16, 2008

hi guys! after many days tinkering on this i managed to make the notification work! (pump fist) now media player classic correctly displays the files when browsing on "Open File" with no native libraries :) i would like some feedback on the patch though because there is some "repeated" code and there is a LPITEMIDLIST cast that i've tried to take out using pointers, but i didn't manage to since the variable is a constant... but you guys might know some other way to not use the cast, no? also i would like some help doing tests for this because i'm sure AJ won't accept this without tests. thanks :) _________________________________________________________________ Receba GRÁTIS as mensagens do Messenger no seu celular quando você estiver offline. Conheça o MSN Mobile! http://mobile.live.com/signup/signup2.aspx?lc=pt-br

1 0

Re: amstream: Some fixes
by Alexandre Julliard Dec. 15, 2008

Dec. 15, 2008

Christian Costa <titan.costa(a)wanadoo.fr> writes: > commit bb5a3b161d69bb2dc0e5be8cbbc5268dbc7d513f > Author: Christian Costa <titan.costa(a)wanadoo.fr> > Date: Sun Dec 14 00:46:24 2008 +0100 > > Some fixes. Please avoid white space changes, and provide a proper log message, "some fixes" doesn't say anything about the change. -- Alexandre Julliard julliard(a)winehq.org

2 1

RE: d3dxof: Add a test to dump an X object data (enabled when objects.txt and templates.txt are present) (try 2)
by Stefan Dösinger Dec. 15, 2008

Dec. 15, 2008

Hi all, I just wanted to take the opportunity to draw some attention to Christian's great work on these higher-level DirectX libraries. I didn't really notice it until I accidentally ran some dx8 sdk samples with the builtin d3dxof and it just worked instead of complaining about lots of stubs. His whole work has been pretty silent, but I think Christian deserves lots of credits here. Good work! > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Christian Costa > Sent: Sunday, December 14, 2008 6:53 PM > To: wine-patches(a)winehq.org > Subject: d3dxof: Add a test to dump an X object data (enabled when > objects.txt and templates.txt are present) (try 2) > > Fixed stdio include that broke make dep.

2 1

Re: msi: improve a debugging message
by James Hawkins Dec. 15, 2008

Dec. 15, 2008

On Mon, Dec 15, 2008 at 1:15 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- > -Austin > Are you adding this because you've been debugging the msi db code? Knowing the row number that we failed to insert is not helpful. In most cases, this message is harmless and should be a warn or removed completely as this is hit if the row already exists in the db (common). Please don't send in a patch for that change, as I'm waiting till I write an exhaustive set of tests for transforms before removing the message. -- James Hawkins

1 0